[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
Hi @John, It just landed in the focal-updates pocket and should be available for 20.04 users. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
Will this patch make it into the normal Ubuntu 20.04 repos? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
This bug was fixed in the package php7.4 - 7.4.3-4ubuntu2.8 --- php7.4 (7.4.3-4ubuntu2.8) focal; urgency=medium * d/p/0047-fix-exception-infinite-loop.patch: Fix ErrorException infinite loop (LP: #1951031) -- Athos Ribeiro Thu, 25 Nov 2021 20:16:22 -0300 ** Changed in: php7.4 (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
This bug was fixed in the package php7.4 - 7.4.16-1ubuntu2.3 --- php7.4 (7.4.16-1ubuntu2.3) hirsute; urgency=medium * d/p/0047-fix-exception-infinite-loop.patch: Fix ErrorException infinite loop (LP: #1951031) -- Athos Ribeiro Thu, 25 Nov 2021 18:36:47 -0300 ** Changed in: php7.4 (Ubuntu Hirsute) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
We see Athos tested via the script, so we focused on testing our app. We have the deployed PHP from the proposed repo. We have verified it fixes our crash issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
I performed the verification for both focal and hirsute following the
test plan described above.
on a hirsute/focal environment:
- Install php7.4
- Fetch and run the test script:
$ wget
https://raw.githubusercontent.com/php/php-src/6dd85f83f78fbafc4a90b264e577a31b59323314/Zend/tests/bug80781.phpt
$ php bug80781.phpt
This will trigger the bug and php will enter an infinite loop.
- Enable the proposed pocked and upgrade php7.4 to the proposed fix
version
The new installed versions were 7.4.3-4ubuntu2.8 in focal, and
7.4.16-1ubuntu2.3 in hirsute
- Re-run the test script
$ php bug80781.phpt
Now, php exists with an error, as expected:
--TEST--
Bug #80781: Error handler that throws ErrorException infinite loop
--FILE--
PHP Fatal error: Uncaught ErrorException: Illegal offset type in isset or
empty in /root/bug80781.phpt:22
Stack trace:
#0 $PATH/bug80781.phpt(22): handle()
#1 {main}
thrown in $PATH/bug80781.phpt on line 22
The results were the same (as expected) for both focal and hirsute.
** Tags removed: verification-needed verification-needed-focal
verification-needed-hirsute
** Tags added: verification-done verification-done-focal
verification-done-hirsute
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1951031
Title:
Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
Hello John, or anyone else affected, Accepted php7.4 into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/php7.4/7.4.16-1ubuntu2.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: php7.4 (Ubuntu Hirsute) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-hirsute ** Changed in: php7.4 (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Changed in: php7.4 (Ubuntu Focal) Status: Triaged => In Progress ** Changed in: php7.4 (Ubuntu Hirsute) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Changed in: php7.4 (Ubuntu Focal) Assignee: (unassigned) => Athos Ribeiro (athos-ribeiro) ** Changed in: php7.4 (Ubuntu Hirsute) Assignee: (unassigned) => Athos Ribeiro (athos-ribeiro) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Description changed:
[Impact]
- When certain code paths where an ErrorException should be raised, php
- will enter an infinite loop, which could possibly lead to having the
- process and a web server connection hanging.
+ When an ErrorException is raised on certain code paths, php will enter
+ an infinite loop, which could possibly lead to having the process and a
+ web server connection hanging.
The proposed upload applies the upstream fix for the issue, as shown in
https://bugs.php.net/bug.php?id=80781.
[Test Plan]
On a {hirsute,focal} environment, install php and use the script
proposed at
https://raw.githubusercontent.com/php/php-
src/6dd85f83f78fbafc4a90b264e577a31b59323314/Zend/tests/bug80781.phpt
to reproduce the bug; php will enter an infinite loop.
Upgrade php to install the proposed fix and run the reproducer script
again.
Now, php will throw an error like
PHP Fatal error: Uncaught ErrorException: Illegal offset type in isset or
empty in $LOCATION_STR
Stack trace:
#0 $LOCATION_STR2: handle()
#1 {main}
- thrown in $LOCATION_STR3
-
+ thrown in $LOCATION_STR3
+
Indicating the issue has been resolved.
[Where problems could occur]
The upstream patch was backported from php 8 to a newer patch version of
php 7.4 than the ones being patched here (available in focal and
hirsute). This could trigger uniexpected behaviors not experienced in
upstream versions of php.
Moreover, php build depends on several different packages. Some of these
could have been changed since the last php build, which could also lead
to unseen, unexpected behavior.
[Other Info]
-
- This bug does not affect the versions of php available in impish and later.
It also does not affect bionic. Therefore, SRUs are only needed for hirsute and
focal.
+
+ This bug does not affect the versions of php available in impish and
+ later. It also does not affect bionic. Therefore, SRUs are only needed
+ for hirsute and focal.
[Original message]
We are experiencing this reproducible crash with 7.4.3-4ubuntu2.7
https://bugs.php.net/bug.php?id=80781
This was fixed 9 months ago in upstream PHP 7.4.15.
Can you apply the patch for #80781 and get it out in the next release of
Ubuntu's PHP?
** Description changed:
[Impact]
When an ErrorException is raised on certain code paths, php will enter
an infinite loop, which could possibly lead to having the process and a
web server connection hanging.
The proposed upload applies the upstream fix for the issue, as shown in
https://bugs.php.net/bug.php?id=80781.
[Test Plan]
On a {hirsute,focal} environment, install php and use the script
proposed at
https://raw.githubusercontent.com/php/php-
src/6dd85f83f78fbafc4a90b264e577a31b59323314/Zend/tests/bug80781.phpt
to reproduce the bug; php will enter an infinite loop.
Upgrade php to install the proposed fix and run the reproducer script
again.
Now, php will throw an error like
PHP Fatal error: Uncaught ErrorException: Illegal offset type in isset or
empty in $LOCATION_STR
Stack trace:
#0 $LOCATION_STR2: handle()
#1 {main}
thrown in $LOCATION_STR3
Indicating the issue has been resolved.
[Where problems could occur]
- The upstream patch was backported from php 8 to a newer patch version of
- php 7.4 than the ones being patched here (available in focal and
- hirsute). This could trigger uniexpected behaviors not experienced in
- upstream versions of php.
+ The upstream patch was backported from php 8 to a newer patch version of php
7.4 than the ones being patched here (available in focal and hirsute). This
could trigger uniexpected behaviors not experienced in upstream versions of
php. The affected code isn't limited to a particular subfunction of PHP that we
could point out, it could be triggered anytime
+ the slow fallback to the internal array handling is running (and the
condition is to throw an exception while in that).
Moreover, php build depends on several different packages. Some of these
could have been changed since the last php build, which could also lead
to unseen, unexpected behavior.
[Other Info]
This bug does not affect the versions of php available in impish and
later. It also does not affect bionic. Therefore, SRUs are only needed
for hirsute and focal.
[Original message]
We are experiencing this reproducible crash with 7.4.3-4ubuntu2.7
https://bugs.php.net/bug.php?id=80781
This was fixed 9 months ago in upstream PHP 7.4.15.
Can you apply the patch for #80781 and get it out in the next release of
Ubuntu's PHP?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1951031
Title:
Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
To manage notifications about this bug go to:
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Description changed:
+ [Impact]
+
+ When certain code paths where an ErrorException should be raised, php
+ will enter an infinite loop, which could possibly lead to having the
+ process and a web server connection hanging.
+
+ The proposed upload applies the upstream fix for the issue, as shown in
+ https://bugs.php.net/bug.php?id=80781.
+
+ [Test Plan]
+
+ On a {hirsute,focal} environment, install php and use the script
+ proposed at
+
+ https://raw.githubusercontent.com/php/php-
+ src/6dd85f83f78fbafc4a90b264e577a31b59323314/Zend/tests/bug80781.phpt
+
+ to reproduce the bug; php will enter an infinite loop.
+
+ Upgrade php to install the proposed fix and run the reproducer script
+ again.
+
+ Now, php will throw an error like
+
+ PHP Fatal error: Uncaught ErrorException: Illegal offset type in isset or
empty in $LOCATION_STR
+ Stack trace:
+ #0 $LOCATION_STR2: handle()
+ #1 {main}
+ thrown in $LOCATION_STR3
+
+ Indicating the issue has been resolved.
+
+ [Where problems could occur]
+
+ The upstream patch was backported from php 8 to a newer patch version of
+ php 7.4 than the ones being patched here (available in focal and
+ hirsute). This could trigger uniexpected behaviors not experienced in
+ upstream versions of php.
+
+ Moreover, php build depends on several different packages. Some of these
+ could have been changed since the last php build, which could also lead
+ to unseen, unexpected behavior.
+
+ [Other Info]
+
+ This bug does not affect the versions of php available in impish and later.
It also does not affect bionic. Therefore, SRUs are only needed for hirsute and
focal.
+
+ [Original message]
+
We are experiencing this reproducible crash with 7.4.3-4ubuntu2.7
https://bugs.php.net/bug.php?id=80781
This was fixed 9 months ago in upstream PHP 7.4.15.
Can you apply the patch for #80781 and get it out in the next release of
Ubuntu's PHP?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1951031
Title:
Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
By using the reproducer script provided in [1], - I confirm that impish and jammy are not affected (the tests resulted in the expected behavior described in [2]); - Both hirsute and focal are affected, as already mentioned by Lucas. I applied the patch linked by Lucas to the hirsute and focal packages in this PPA: https://launchpad.net/~athos- ribeiro/+archive/ubuntu/php7-lp-1951031/+packages MPs were proposed in [3] and [4]. I will follow up with filling an SRU template shortly. [1] https://github.com/php/php-src/commit/6dd85f83f78fbafc4a90b264e577a31b59323314#diff-ec66169649c48cc98a3bb86b988d4486d2fdd7d6bf0ec85ddf3a3593bfc00e8fR4-R26 [2] https://github.com/php/php-src/commit/6dd85f83f78fbafc4a90b264e577a31b59323314#diff-ec66169649c48cc98a3bb86b988d4486d2fdd7d6bf0ec85ddf3a3593bfc00e8fR27-R32 [3] https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/php7.4/+git/php7.4/+merge/412416 [4] https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/php7.4/+git/php7.4/+merge/412418 ** Changed in: php8.0 (Ubuntu Impish) Status: New => Invalid ** Changed in: php7.4 (Ubuntu Focal) Status: New => Triaged ** Changed in: php7.4 (Ubuntu Hirsute) Status: New => Triaged ** Changed in: php8.0 (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Merge proposal linked: https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/php7.4/+git/php7.4/+merge/412416 ** Merge proposal linked: https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/php7.4/+git/php7.4/+merge/412418 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
Adding tasks to php8.0 just to make sure it is not impacted by this bug. ** Tags removed: server-todo ** Tags added: server-next ** Also affects: php8.0 (Ubuntu) Importance: Undecided Status: New ** Changed in: php8.0 (Ubuntu Hirsute) Status: New => Invalid ** Changed in: php8.0 (Ubuntu Focal) Status: New => Invalid ** Changed in: php7.4 (Ubuntu Impish) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
** Also affects: php7.4 (Ubuntu Impish) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1951031] Re: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781
Thanks for taking the time to report this bug and trying to make Ubuntu better. This is the upstream commit that we need to cherry-pick to fix this issue: https://github.com/php/php- src/commit/6dd85f83f78fbafc4a90b264e577a31b59323314 And it seems to be fixed only in version 7.4.17 onward, in despite of the upstream bug saying that it was fixed in 7.4.15. In this case, this should be impacting Focal and Hirsute. ** Also affects: php7.4 (Ubuntu Hirsute) Importance: Undecided Status: New ** Also affects: php7.4 (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: php7.4 (Ubuntu) Status: New => Fix Released ** Changed in: php7.4 (Ubuntu) Status: Fix Released => Invalid ** Tags added: server-todo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1951031 Title: Patch php7.4.3-ubuntu with upstream's fix for upstream #80781 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php7.4/+bug/1951031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
