[Bug 904958] Re: xfwm4: top border still present when window is maximized
This bug was fixed in the package xfwm4 - 4.11.3-0ubuntu1 (but not included in the debian changelog) --- xfwm4 (4.11.3-0ubuntu1) vivid; urgency=medium * New upstream release. - Fix maximizing vetically or horizontally tiled windows. LP: #1397922 - Revert "Experiment with button events." LP: #1394439 - Use source indication in activate window. LP: #1292122 - Determine the maximum host name length correctly. LP: #1233107 * Drop 0001-fix-fullscreen-qt4-behavior-bug-8563.patch, 02-remove-unused-maximize-button.patch, fixed upstream -- Jackson Doak Sun, 15 Feb 2015 06:24:16 +1100 ** Changed in: xfwm4 (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/904958 Title: xfwm4: top border still present when window is maximized To manage notifications about this bug go to: https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 904958] Re: xfwm4: top border still present when window is maximized
** Changed in: xfwm4 Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/904958 Title: xfwm4: top border still present when window is maximized To manage notifications about this bug go to: https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 904958] Re: xfwm4: top border still present when window is maximized
Launchpad has imported 23 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=9905. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2013-03-10T22:29:01+00:00 thesame wrote: Add the ability to undecorate maximized windows to save vertical space on screen. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/5 On 2013-03-10T22:29:20+00:00 thesame wrote: Implemented here https://bitbucket.org/thesame/xfwm4-titleless Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/6 On 2013-03-11T20:09:05+00:00 Olivier Fourdan wrote: (In reply to comment #1) > Implemented here https://bitbucket.org/thesame/xfwm4-titleless Please attach patches here if you want this upstream (can't really teach changes from another git repo,not convenient...) Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/7 On 2013-03-11T20:19:46+00:00 Olivier Fourdan wrote: Note, title-less maximization is already covered by EWMH, so this needs to be implemented via the standard, making it an unconditional option in not the right way to add this feature. 1. add support for EWMH standard for borderless maximization 2. make sure it's not just the title, but border as we'll (ie there is already an option to show or hide borders on maximization, make sure this work in any case) 3. once the feature supports the standard, we can add a user option to set the default behaviour, for apps that don't specify their desired maximization mode via the standard. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/8 On 2013-03-12T01:11:25+00:00 thesame wrote: Created attachment 4959 Adds ability to hide titles of maximized windows Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/9 On 2013-03-12T01:11:50+00:00 thesame wrote: (In reply to comment #3) > Note, title-less maximization is already covered by EWMH, so this needs to > be implemented via the standard, making it an unconditional option in not > the right way to add this feature. I couldn't find appropriate EWMH atom to show/hide titles of maximized windows. My solution isn't unconditional, it adds new checkbox (initially unchecked) to WM tweaks. > 1. add support for EWMH standard for borderless maximization > 2. make sure it's not just the title, but border as we'll (ie there is > already an option to show or hide borders on maximization, make sure this > work in any case) My solution covers both full and vertical titleless maximizations. I'd be glad if someone tested it with me. It works for me and I already use it. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/10 On 2013-06-10T09:28:09+00:00 Konstantin G. Khlebnikov wrote: I have applied this to xfwm4 4.10.1 from debian/testing and it work like a charm. Patch little bit messy, it would be better to split it into pieces. screenshot: https://plus.google.com/105141859736228162791/posts/QpiEk7uf6Ah Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/11 On 2013-06-10T14:26:35+00:00 Olivier Fourdan wrote: (In reply to comment #5) > > I couldn't find appropriate EWMH atom to show/hide titles of maximized > windows. My solution isn't unconditional, it adds new checkbox (initially > unchecked) to WM tweaks. True, indeed, I got confused. But gtk+ has a mechanism for that: "_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED" https://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkwindow-x11.c#n3472 Would be great to have that as well, so that apps that use this get undecorated when maximized even if the user has not specified the option (so we geta consistent behavior with gtk+ apps at least) Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/12 On 2013-07-12T05:19:53+00:00 thesame wrote: Created attachment 5092 _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED support Diff against current git master. Must be applied on top of previous patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/13 On 2013-0
[Bug 904958] Re: xfwm4: top border still present when window is maximized
** Bug watch added: Xfce Bugzilla #9905 https://bugzilla.xfce.org/show_bug.cgi?id=9905 ** Changed in: xfwm4 Importance: Low => Unknown ** Changed in: xfwm4 Status: Invalid => Unknown ** Changed in: xfwm4 Remote watch: Xfce Bugzilla #7436 => Xfce Bugzilla #9905 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/904958 Title: xfwm4: top border still present when window is maximized To manage notifications about this bug go to: https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 904958] Re: xfwm4: top border still present when window is maximized
Launchpad has imported 5 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=7436. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2011-03-23T11:42:09+00:00 Mark wrote: Hi, When a window is maximized so it fills the whole screen, its top border is still shown. The top border in this state is useless though, since it cannot be dragged to resize the maximized window. So it just wastes space. For most xfwm4 styles/themes this doesn't actually look too bad. But with a theme with relatively thick window borders it can look quite ugly. To see what I mean, change the window manager style to "Mofit" then maximize a window. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/0 On 2011-12-15T20:28:42+00:00 Mark wrote: I might have found the cause of the problem. In src/frame.c, the frameTop() definition does not have similar checks for CLIENT_FLAG_MAXIMIZED as the frameLeft(), frameRight() and frameBottom() functions. Should the frameTop() function be changed to read something like this? int frameTop (Client * c) { TRACE ("entering frameTop"); g_return_val_if_fail (c != NULL, 0); if (FLAG_TEST (c->xfwm_flags, XFWM_FLAG_HAS_BORDER) && !FLAG_TEST (c->flags, CLIENT_FLAG_FULLSCREEN) && (!FLAG_TEST_ALL (c->flags, CLIENT_FLAG_MAXIMIZED) // This condition added || !(c->screen_info->params->borderless_maximize))) // This condition added { return c->screen_info->title[TITLE_3][ACTIVE].height; } return 0; } Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/1 On 2011-12-15T20:56:53+00:00 Olivier Fourdan wrote: Removing the top border when maximized would break most themes, not something I would like just for a few themes such as the Motif like theme. Not something I would fix. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/3 On 2013-12-08T21:04:17+00:00 Cedric Leporcq wrote: Hello, I’ve managed to implement this feature without breaking old themes. look at #9905 Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/5 On 2014-11-21T12:58:07+00:00 Landry-o wrote: See #9905 for work on this and patches, resolving this one as duplicate *** This bug has been marked as a duplicate of bug 9905 *** Reply at: https://bugs.launchpad.net/ubuntu/+source/xfwm4/+bug/904958/comments/6 ** Changed in: xfwm4 Status: Unknown => Invalid ** Changed in: xfwm4 Importance: Unknown => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/904958 Title: xfwm4: top border still present when window is maximized To manage notifications about this bug go to: https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 904958] Re: xfwm4: top border still present when window is maximized
Thanks for your bug report. You don't usually need to file a bug on launchpad when you've already reported it upstream. About your request, I'm sorry, but we don't usually apply patches when the upstream developer expressed his disagreement about the bug/feature, and that's what happened here (window management is tricky, so I prefer to stick close to upstream). ** Bug watch added: Xfce Bugzilla #7436 http://bugzilla.xfce.org/show_bug.cgi?id=7436 ** Also affects: xfwm4 via http://bugzilla.xfce.org/show_bug.cgi?id=7436 Importance: Unknown Status: Unknown ** Changed in: xfwm4 (Ubuntu) Status: New => Triaged ** Changed in: xfwm4 (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/904958 Title: xfwm4: top border still present when window is maximized To manage notifications about this bug go to: https://bugs.launchpad.net/xfwm4/+bug/904958/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs