[Bug 942590] Re: update-manager misguiding text
** Changed in: update-manager (Ubuntu) Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
The primary text for an alert should be complete sentences, regardless of whether it is bold. The software on this computer is up to date. It's easy to understand this when considering that sometimes the primary text is a question. Are you sure you want to close all programs and log out of the computer? And sometimes it is multiple sentences. Ubuntu can’t be updated at the moment. Please try again later. It would be inconsistent for some of these sentences to have punctuation while others didn't. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
My last patch that fixes a missing dot. ** Patch added: patch5.diff https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2800711/+files/patch5.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
** Patch removed: This is it https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2796829/+files/patch4.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
patch4.diff labeled This is it was commited by mvo... Thanks for that. I only need Matthew to tell me about the previous question I was asking. So what's up with that string in question Matthew? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Thanks again John. You're right to change Ubuntu Linux to Ubuntu. I just have one niggle: - text_header= bigb%s/b/big % _(The software on this computer is up to date.) + text_header= bigb%s/b/big % _(The software on this computer is up-to-date.) This should stay as it is. Compound adjectives should generally be hyphenated (This is an up-to-date computer, This is open-source software), but adjective phrases should not be (This computer is up to date, This software is open source). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Matthew, you're absolutely right. I fixed my patch now and am uploading it for your another revision. If you now see it fit, then please apply it and commit it. ;) ** Patch removed: 3rd time's a charm :) https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2794573/+files/patch3.diff ** Patch added: This is it https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2796829/+files/patch4.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
** Branch linked: lp:update-manager -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Matthew, I have a question for you. In UpdateManager/UpdateManager.py there's this code: if num_updates == 0: text_header= bigb%s/b/big % _(The software on this computer is up to date.) Since this string is going to be displayed as a title in bold and not as a normal text label -- should we remove the dot so that the string would be _(The software on this computer is up to date) ?? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Hi John. Thank you for your patch. I have three small suggestions and one big suggestion. Small suggestions: 1. For readability, instructional text -- whether it appears in a UI or in help -- should not include any ellipses in labels that it is referring to. So Updates Available... should instead be Updates Available. 2. The old text had the same problem, but since you're changing it: UI text should use typographical apostrophes ’ and quotes “”, not Ascii quotes ' . Abbreviated example of how to do this in Python: _(uIf you don\u2019t want them now, choose \u201cUpdates Available\u201d later.) 3. The accessible title of the last menu is Device, so the text should refer to it as the device menu, not the Session menu. The big suggestion is that I'd actually prefer the second sentence to be removed altogether. :-) Two reasons for this. First, though the menu has the accessible title Device, that's not obvious (as you demonstrated yourself), and there's nothing visible that hints which menu is the device menu -- so the instruction probably isn't useful anyway. And second, I'd like to move towards the design shown in https://wiki.ubuntu.com/SoftwareUpdates#alert, where the only secondary text is context-sensitive (e.g. The computer will need to restart afterwards.). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
** Patch removed: Apply and commit ;) https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792609/+files/patch2.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Matthew, I like the idea of removing the second sentence altogether, so I made a new patch and removed those second sentences. I also removed the whole is_unity_running() thing. Some minor changes were also made, like there was an occurence of Ubuntu Linux which I found totally unnecessary as all other occurences say Ubuntu, so that was changed to only Ubuntu. I hope my contribution with this patch is welcome to the Ubuntu community. Developers, if you please, review the patch and commit it if you find it well done. Also, make sure that all the translators are going to be informed about these changes, so that they will, too, accomodate their translations accordingly. Thanks. ** Patch added: 3rd time's a charm :) https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2794573/+files/patch3.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Michael, you have asked me on IRC to review my patch again if everything looks good. I have done that and I assure you that the patch is now, finally, perfected and ready to be commited. So, if you please, go ahead and commit. ;) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Additional note: The ''menu that has a power icon in the top-right of the screen'' that I was referring to is called a session menu. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Please fix this now that Ubuntu 12.04 is still in alpha stage. ** Changed in: update-manager (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
Notice that is says Applications later not menu. In the dash it is possible to view installed applications and find update-manager. In precise the text displayed is also conditional now and changes depending on whether or not unity is running. ** Changed in: update-manager (Ubuntu) Importance: Undecided = Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
I chatted with Michael Vogt a.k.a. mvo on irc.freenode.net, the creator of update-manager package, and he instruct me to make a patch for update-manager and was perfectly happy that I make this changes. I did create a patch and so now I am giving it to the world. :) I hope you like my little contribution. Keep up the good work with the Ubuntu project. I love it very much. Peace... P.S.: Michael, I hope you had a good night sleep. Now it's my turn. :) ** Attachment added: My solution to the problem... https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792348/+files/patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
The attachment My solution to the problem... of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report. [This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
** Patch removed: My solution to the problem... https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792348/+files/patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 942590] Re: update-manager misguiding text
I removed my first patch because I made a mistake in it. My second patch is now okay. I have fixed only those strings under the statement if is_unity_running() because the fixed text applies only in the situation when the user has the Unity desktop environment installed. Michael, I must inform you that the strings that I have fixed are translatable strings, so please inform the translators that they need to update their translations for this package, after you'll apply the patch of course. ;) ** Patch added: Apply and commit ;) https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792609/+files/patch2.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
