Re: [uClinux-dev] Re: Fwd: [PATCH] NPTL support for uClinux

2009-12-17 Thread Jamie Lokier
Greg Ungerer wrote:
 Did you want me to pick this up and apply the the m68knommu.git
 tree for inclusion in 2.6.34?

Would it not be worth holding off mainlining it until there's a
userspace m68knommu NPTL, just in case it turns out something
important was overlooked?

-- Jamie
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev


Re: [uClinux-dev] Re: Fwd: [PATCH] NPTL support for uClinux

2009-12-17 Thread Greg Ungerer

Hi Jamie,

On 12/17/2009 11:45 PM, Jamie Lokier wrote:

Greg Ungerer wrote:

Did you want me to pick this up and apply the the m68knommu.git
tree for inclusion in 2.6.34?


Would it not be worth holding off mainlining it until there's a
userspace m68knommu NPTL, just in case it turns out something
important was overlooked?


My thinking is that if it is present (and has a good chance
of working given its derivation from m68k) then it may encourage
someone to do the NPTL work needed in uClibc sooner than later.

I would of course test it on a bunch of targets, but if it doesn't
break anything as it stands today is it really a problem?

Regards
Greg



Greg Ungerer  --  Principal EngineerEMAIL: g...@snapgear.com
SnapGear Group, McAfee  PHONE:   +61 7 3435 2888
8 Gardner Close,FAX: +61 7 3891 3630
Milton, QLD, 4064, AustraliaWEB: http://www.SnapGear.com
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev


Re: [uClinux-dev] Re: Fwd: [PATCH] NPTL support for uClinux

2009-12-17 Thread Maxim Kuvyrkov

On 12/17/09 4:45 PM, Jamie Lokier wrote:

Greg Ungerer wrote:

Did you want me to pick this up and apply the the m68knommu.git
tree for inclusion in 2.6.34?


Would it not be worth holding off mainlining it until there's a
userspace m68knommu NPTL, just in case it turns out something
important was overlooked?


I very much doubt that anyone will work on userspace support till the 
kernel support is in place.  It is the userspace support which depends 
on the kernel, not the vice-versa.


--
Maxim Kuvyrkov
CodeSourcery
ma...@codesourcery.com
(650) 331-3385 x724
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev


Re: [uClinux-dev] Re: Fwd: [PATCH] NPTL support for uClinux

2009-12-17 Thread Jamie Lokier
Greg Ungerer wrote:
 Hi Jamie,
 
 On 12/17/2009 11:45 PM, Jamie Lokier wrote:
 Greg Ungerer wrote:
 Did you want me to pick this up and apply the the m68knommu.git
 tree for inclusion in 2.6.34?
 
 Would it not be worth holding off mainlining it until there's a
 userspace m68knommu NPTL, just in case it turns out something
 important was overlooked?
 
 My thinking is that if it is present (and has a good chance
 of working given its derivation from m68k)

There are some kernel API differences needed between arm-nommu and
arm-mmu, due to the inability to map helper functions (atomic cmpxchg,
barrier, get_tls) at fixed virtual addresses, so I wouldn't be
surprised if the same applies to m68k.

 I would of course test it on a bunch of targets, but if it doesn't
 break anything as it stands today is it really a problem?

Only if someone may run a program which works on a later kernel on an
older kernel, and would like it to fail or switch to LinuxThreads,
rather than behave wrongly on the intermediate kernels, if there's an
API problem.

 then it may encourage someone to do the NPTL work needed in uClibc
 sooner than later.

That's a good reason.  I was thinking perhaps anyone doing m68k-nommu
NPTL work would apply the available NPTL-kernel patch to their kernel,
but perhaps I am naive about such things :-)

-- Jamie
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev


Re: [uClinux-dev] Re: Fwd: [PATCH] NPTL support for uClinux

2009-12-16 Thread Greg Ungerer


Hi Maxim,

Maxim Kuvyrkov wrote:

Geert Uytterhoeven wrote:

-- Forwarded message --
From: Maxim Kuvyrkov ma...@codesourcery.com
Date: Sun, Dec 6, 2009 at 20:04
Subject: [PATCH] NPTL support for uClinux
To: Geert Uytterhoeven ge...@linux-m68k.org
Cc: Linux/m68k linux-m...@vger.kernel.org


The following patch makes NPTL syscalls work for m68knommu.

I didn't test this beyond building the kernel, there's no much point
to it till uClibc support for NPTL on m68k is implemented.

The patch is basically a copy of original NPTL patch for usual m68k.
The only real change is in atomic_cmpxchg syscall implementation: code
that checked correctness of the memory reference was removed.


As Andreas noted on linux-m68k@, there are a couple of indentation 
issues in the patch.  Here is a version formatted with scripts/Lindent.


Overall this looks ok to me. (Though it seems the formatting on
unsigned long tp_value in the patch to thread_info_no.h doesn't
match the existing field alignment).

Did you want me to pick this up and apply the the m68knommu.git
tree for inclusion in 2.6.34?

Regards
Greg




Greg Ungerer  --  Principal EngineerEMAIL: g...@snapgear.com
SnapGear Group, McAfee  PHONE:   +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, AustraliaWEB: http://www.SnapGear.com
___
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev