Re: Help with migrating one of OpenJPA classes to commons-collections4
Hi.
On Tue, 18 Dec 2018 20:54:22 +0700, Maxim Solodovnik wrote:
Hello Gilles,
I read documentation and as far as I can see To perform release I
need
rights to create branch
git remote -v
origin g...@github.com:apache/commons-collections.git (fetch)
origin g...@github.com:apache/commons-collections.git (push)
git push -u origin 4.3-release
ERROR: Permission to apache/commons-collections.git denied to
solomax.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
The repository (at Apache) is here:
https://gitbox.apache.org/repos/asf?p=commons-collections.git
We were told that it should now be possible to also write
through GitHub, but I don't know if and how it should work.
IMO, the easiest would be to clone the above, and try again
with that. [If it still does not work, then perhaps the issue
is that the "all-Apache-committers-are-committers" resolution
was not applied.]
Gilles
P.S. We should move this conversation over to the "dev" ML.
Shall I use SVN? Or some other remote?
On Tue, 18 Dec 2018 at 16:04, Maxim Solodovnik
wrote:
Thanks Gilles,
will try to create RC tonight
On Tue, 18 Dec 2018 at 15:55, Gilles
wrote:
Hi.
On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote:
> I can create RC, no problem
> But
> 1) I need my signing key [1] to be added to official KEYS
The file is here:
https://dist.apache.org/repos/dist/release/commons/KEYS
> 2) Do you have description of your release process? I was unable
to
> find one
http://commons.apache.org/proper/commons-release-plugin/index.html
Also, a step-by-step recipe is here:
https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt
[It is for a multimodule maven project ("Commons RNG"); it
mentions problems with the release process that might need
manual adjustments.]
If you encounter something that does not work as noted,
please report it here, and on the bug tracking system:
https://issues.apache.org/jira/projects/COMMONSSITE
> 3) most probably I will need some rights
The "Commons" project has granted "write" access to all
Apache committers.
[But some repositories perhaps miss the actual settings
to make it work. You'll have to try...]
HTH,
Gilles
> [1] https://github.com/apache/openmeetings/blob/master/KEYS#L88
>
> On Tue, 18 Dec 2018 at 01:06, sebb wrote:
>
>> On Mon, 17 Dec 2018 at 15:38, Gary Gregory
>> wrote:
>> >
>> > I am on the road driving this week, my availability is
limited.
>> >
>> > WRT being a RM, I think you need PMC karma for that. Sebb
might be
>> able
>> to
>> > confirm.
>>
>> Creating the dist/dev release candidate only requires project
>> committer karma; Commons requires the same for dist/release
>>
>> I don't know about Nexus; I imagine at least LDAP commons
committer
>> membership is required.
>>
>> There's no harm in trying to create an RC.
>>
>> > Gary
>> >
>> > On Mon, Dec 17, 2018, 03:59 Gilles
>> wrote:
>> >
>> > > Hi.
>> > >
>> > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote:
>> > > > Hello Gary,
>> > > >
>> > > > Is there any progress? :)
>> > >
>> > > Suggestion: Be the release manager of 4.3.
>> > >
>> > > Regards,
>> > > Gilles
>> > >
>> > > >
>> > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory
>>
>> > > > wrote:
>> > > >
>> > > >> [...]
>> > >
>> > >
-
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail: user-h...@commons.apache.org
--
WBR
Maxim aka solomax
-
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail: user-h...@commons.apache.org
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gilles,
I read documentation and as far as I can see To perform release I need
rights to create branch
git remote -v
origin g...@github.com:apache/commons-collections.git (fetch)
origin g...@github.com:apache/commons-collections.git (push)
git push -u origin 4.3-release
ERROR: Permission to apache/commons-collections.git denied to solomax.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Shall I use SVN? Or some other remote?
On Tue, 18 Dec 2018 at 16:04, Maxim Solodovnik wrote:
> Thanks Gilles,
>
> will try to create RC tonight
>
> On Tue, 18 Dec 2018 at 15:55, Gilles wrote:
>
>> Hi.
>>
>> On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote:
>> > I can create RC, no problem
>> > But
>> > 1) I need my signing key [1] to be added to official KEYS
>>
>> The file is here:
>>https://dist.apache.org/repos/dist/release/commons/KEYS
>>
>> > 2) Do you have description of your release process? I was unable to
>> > find one
>>
>> http://commons.apache.org/proper/commons-release-plugin/index.html
>>
>> Also, a step-by-step recipe is here:
>>
>>
>> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt
>>
>> [It is for a multimodule maven project ("Commons RNG"); it
>> mentions problems with the release process that might need
>> manual adjustments.]
>>
>> If you encounter something that does not work as noted,
>> please report it here, and on the bug tracking system:
>>https://issues.apache.org/jira/projects/COMMONSSITE
>>
>> > 3) most probably I will need some rights
>>
>> The "Commons" project has granted "write" access to all
>> Apache committers.
>> [But some repositories perhaps miss the actual settings
>> to make it work. You'll have to try...]
>>
>> HTH,
>> Gilles
>>
>> > [1] https://github.com/apache/openmeetings/blob/master/KEYS#L88
>> >
>> > On Tue, 18 Dec 2018 at 01:06, sebb wrote:
>> >
>> >> On Mon, 17 Dec 2018 at 15:38, Gary Gregory
>> >> wrote:
>> >> >
>> >> > I am on the road driving this week, my availability is limited.
>> >> >
>> >> > WRT being a RM, I think you need PMC karma for that. Sebb might be
>> >> able
>> >> to
>> >> > confirm.
>> >>
>> >> Creating the dist/dev release candidate only requires project
>> >> committer karma; Commons requires the same for dist/release
>> >>
>> >> I don't know about Nexus; I imagine at least LDAP commons committer
>> >> membership is required.
>> >>
>> >> There's no harm in trying to create an RC.
>> >>
>> >> > Gary
>> >> >
>> >> > On Mon, Dec 17, 2018, 03:59 Gilles > >> wrote:
>> >> >
>> >> > > Hi.
>> >> > >
>> >> > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote:
>> >> > > > Hello Gary,
>> >> > > >
>> >> > > > Is there any progress? :)
>> >> > >
>> >> > > Suggestion: Be the release manager of 4.3.
>> >> > >
>> >> > > Regards,
>> >> > > Gilles
>> >> > >
>> >> > > >
>> >> > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory
>> >>
>> >> > > > wrote:
>> >> > > >
>> >> > > >> [...]
>> >> > >
>> >> > >
>>
>>
>> -
>> To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
>> For additional commands, e-mail: user-h...@commons.apache.org
>>
>>
>
> --
> WBR
> Maxim aka solomax
>
--
WBR
Maxim aka solomax
Re: Help with migrating one of OpenJPA classes to commons-collections4
Thanks Gilles,
will try to create RC tonight
On Tue, 18 Dec 2018 at 15:55, Gilles wrote:
> Hi.
>
> On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote:
> > I can create RC, no problem
> > But
> > 1) I need my signing key [1] to be added to official KEYS
>
> The file is here:
>https://dist.apache.org/repos/dist/release/commons/KEYS
>
> > 2) Do you have description of your release process? I was unable to
> > find one
>
> http://commons.apache.org/proper/commons-release-plugin/index.html
>
> Also, a step-by-step recipe is here:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt
>
> [It is for a multimodule maven project ("Commons RNG"); it
> mentions problems with the release process that might need
> manual adjustments.]
>
> If you encounter something that does not work as noted,
> please report it here, and on the bug tracking system:
>https://issues.apache.org/jira/projects/COMMONSSITE
>
> > 3) most probably I will need some rights
>
> The "Commons" project has granted "write" access to all
> Apache committers.
> [But some repositories perhaps miss the actual settings
> to make it work. You'll have to try...]
>
> HTH,
> Gilles
>
> > [1] https://github.com/apache/openmeetings/blob/master/KEYS#L88
> >
> > On Tue, 18 Dec 2018 at 01:06, sebb wrote:
> >
> >> On Mon, 17 Dec 2018 at 15:38, Gary Gregory
> >> wrote:
> >> >
> >> > I am on the road driving this week, my availability is limited.
> >> >
> >> > WRT being a RM, I think you need PMC karma for that. Sebb might be
> >> able
> >> to
> >> > confirm.
> >>
> >> Creating the dist/dev release candidate only requires project
> >> committer karma; Commons requires the same for dist/release
> >>
> >> I don't know about Nexus; I imagine at least LDAP commons committer
> >> membership is required.
> >>
> >> There's no harm in trying to create an RC.
> >>
> >> > Gary
> >> >
> >> > On Mon, Dec 17, 2018, 03:59 Gilles >> wrote:
> >> >
> >> > > Hi.
> >> > >
> >> > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote:
> >> > > > Hello Gary,
> >> > > >
> >> > > > Is there any progress? :)
> >> > >
> >> > > Suggestion: Be the release manager of 4.3.
> >> > >
> >> > > Regards,
> >> > > Gilles
> >> > >
> >> > > >
> >> > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory
> >>
> >> > > > wrote:
> >> > > >
> >> > > >> [...]
> >> > >
> >> > >
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> For additional commands, e-mail: user-h...@commons.apache.org
>
>
--
WBR
Maxim aka solomax
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hi.
On Tue, 18 Dec 2018 09:52:15 +0700, Maxim Solodovnik wrote:
I can create RC, no problem
But
1) I need my signing key [1] to be added to official KEYS
The file is here:
https://dist.apache.org/repos/dist/release/commons/KEYS
2) Do you have description of your release process? I was unable to
find one
http://commons.apache.org/proper/commons-release-plugin/index.html
Also, a step-by-step recipe is here:
https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=blob;f=doc/release/release.howto.txt
[It is for a multimodule maven project ("Commons RNG"); it
mentions problems with the release process that might need
manual adjustments.]
If you encounter something that does not work as noted,
please report it here, and on the bug tracking system:
https://issues.apache.org/jira/projects/COMMONSSITE
3) most probably I will need some rights
The "Commons" project has granted "write" access to all
Apache committers.
[But some repositories perhaps miss the actual settings
to make it work. You'll have to try...]
HTH,
Gilles
[1] https://github.com/apache/openmeetings/blob/master/KEYS#L88
On Tue, 18 Dec 2018 at 01:06, sebb wrote:
On Mon, 17 Dec 2018 at 15:38, Gary Gregory
wrote:
>
> I am on the road driving this week, my availability is limited.
>
> WRT being a RM, I think you need PMC karma for that. Sebb might be
able
to
> confirm.
Creating the dist/dev release candidate only requires project
committer karma; Commons requires the same for dist/release
I don't know about Nexus; I imagine at least LDAP commons committer
membership is required.
There's no harm in trying to create an RC.
> Gary
>
> On Mon, Dec 17, 2018, 03:59 Gilles wrote:
>
> > Hi.
> >
> > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote:
> > > Hello Gary,
> > >
> > > Is there any progress? :)
> >
> > Suggestion: Be the release manager of 4.3.
> >
> > Regards,
> > Gilles
> >
> > >
> > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory
> > > wrote:
> > >
> > >> [...]
> >
> >
-
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail: user-h...@commons.apache.org
Re: Help with migrating one of OpenJPA classes to commons-collections4
I can create RC, no problem But 1) I need my signing key [1] to be added to official KEYS 2) Do you have description of your release process? I was unable to find one 3) most probably I will need some rights [1] https://github.com/apache/openmeetings/blob/master/KEYS#L88 On Tue, 18 Dec 2018 at 01:06, sebb wrote: > On Mon, 17 Dec 2018 at 15:38, Gary Gregory wrote: > > > > I am on the road driving this week, my availability is limited. > > > > WRT being a RM, I think you need PMC karma for that. Sebb might be able > to > > confirm. > > Creating the dist/dev release candidate only requires project > committer karma; Commons requires the same for dist/release > > I don't know about Nexus; I imagine at least LDAP commons committer > membership is required. > > There's no harm in trying to create an RC. > > > Gary > > > > On Mon, Dec 17, 2018, 03:59 Gilles > > > > Hi. > > > > > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: > > > > Hello Gary, > > > > > > > > Is there any progress? :) > > > > > > Suggestion: Be the release manager of 4.3. > > > > > > Regards, > > > Gilles > > > > > > > > > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory > > > > wrote: > > > > > > > >> [...] > > > > > > > > > - > > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > > > For additional commands, e-mail: user-h...@commons.apache.org > > > > > > > > - > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > For additional commands, e-mail: user-h...@commons.apache.org > > -- WBR Maxim aka solomax
Re: Help with migrating one of OpenJPA classes to commons-collections4
On Mon, 17 Dec 2018 at 15:38, Gary Gregory wrote: > > I am on the road driving this week, my availability is limited. > > WRT being a RM, I think you need PMC karma for that. Sebb might be able to > confirm. Creating the dist/dev release candidate only requires project committer karma; Commons requires the same for dist/release I don't know about Nexus; I imagine at least LDAP commons committer membership is required. There's no harm in trying to create an RC. > Gary > > On Mon, Dec 17, 2018, 03:59 Gilles > > Hi. > > > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: > > > Hello Gary, > > > > > > Is there any progress? :) > > > > Suggestion: Be the release manager of 4.3. > > > > Regards, > > Gilles > > > > > > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory > > > wrote: > > > > > >> [...] > > > > > > - > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > > For additional commands, e-mail: user-h...@commons.apache.org > > > > - To unsubscribe, e-mail: user-unsubscr...@commons.apache.org For additional commands, e-mail: user-h...@commons.apache.org
Re: Help with migrating one of OpenJPA classes to commons-collections4
I am on the road driving this week, my availability is limited. WRT being a RM, I think you need PMC karma for that. Sebb might be able to confirm. Gary On Mon, Dec 17, 2018, 03:59 Gilles Hi. > > On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: > > Hello Gary, > > > > Is there any progress? :) > > Suggestion: Be the release manager of 4.3. > > Regards, > Gilles > > > > > On Tue, 4 Dec 2018 at 00:07, Gary Gregory > > wrote: > > > >> [...] > > > - > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > For additional commands, e-mail: user-h...@commons.apache.org > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hi. On Mon, 17 Dec 2018 15:12:16 +0700, Maxim Solodovnik wrote: Hello Gary, Is there any progress? :) Suggestion: Be the release manager of 4.3. Regards, Gilles On Tue, 4 Dec 2018 at 00:07, Gary Gregory wrote: [...] - To unsubscribe, e-mail: user-unsubscr...@commons.apache.org For additional commands, e-mail: user-h...@commons.apache.org
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gary, Is there any progress? :) On Tue, 4 Dec 2018 at 00:07, Gary Gregory wrote: > There are a couple of issues. I'll try to take a look tonight. > > Gary > > On Mon, Dec 3, 2018 at 9:24 AM Maxim Solodovnik > wrote: > > > Hello, > > > > OpenJpa release is blocked by absence of commons-collections release > > Are there any blockers? > > > > On Mon, 26 Nov 2018 at 20:08, Maxim Solodovnik > > wrote: > > > > > Hello Gary, > > > > > > any news regarding release? :))) > > > > > > On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik > > > wrote: > > > > > >> Many thanks :) > > >> > > >> On Tue, 13 Nov 2018 at 12:50, Gary Gregory > > >> wrote: > > >> > > >>> I hope someone will take the time to do this over the US Thanksgiving > > >>> holidays perhaps. > > >>> > > >>> Gary > > >>> > > >>> On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik > >>> wrote: > > >>> > > >>> > Hello Gary, > > >>> > > > >>> > we all are volunteers :) > > >>> > Why I'm asking: it will be blocker for OpenJPA release > > >>> > > > >>> > On Tue, 16 Oct 2018 at 19:39, Gary Gregory > > > >>> wrote: > > >>> > > > >>> > > Hi, > > >>> > > > > >>> > > There is no ETA, and since we are all volunteers, it depends on > > who > > >>> > wants > > >>> > > to step up and take the time to do it. > > >>> > > > > >>> > > Gary > > >>> > > > > >>> > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik < > solomax...@gmail.com > > > > > >>> > wrote: > > >>> > > > > >>> > > > Hello Gary, > > >>> > > > > > >>> > > > SNAPSHOT works for us expected :) > > >>> > > > There is no rush, I just want to get some ETA :) > > >>> > > > > > >>> > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory < > > garydgreg...@gmail.com > > >>> > > > >>> > > wrote: > > >>> > > > > > >>> > > > > Are there any open issues we want to address for 4.3 is the > > >>> SNAPSHOT > > >>> > OK > > >>> > > > as > > >>> > > > > is? > > >>> > > > > > > >>> > > > > Gary > > >>> > > > > > > >>> > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < > > >>> > > solomax...@gmail.com> > > >>> > > > > wrote: > > >>> > > > > > > >>> > > > > > Hello Benedikt, > > >>> > > > > > > > >>> > > > > > I would like to remind you about 4.3 release :) > > >>> > > > > > > > >>> > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < > > >>> > solomax...@gmail.com > > >>> > > > > > >>> > > > > > wrote: > > >>> > > > > > > > > >>> > > > > > > Great, > > >>> > > > > > > > > >>> > > > > > > Thanks a million! > > >>> > > > > > > > > >>> > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < > > >>> > brit...@apache.org> > > >>> > > > > > wrote: > > >>> > > > > > >> > > >>> > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt > > Ritter < > > >>> > > > > > >> brit...@apache.org>: > > >>> > > > > > >> > > >>> > > > > > >> > Hello Maxim, > > >>> > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim > > >>> Solodovnik < > > >>> > > > > > >> > solomax...@gmail.com>: > > >>> > > > > > >> > > > >>> > > > > > >> >> Hello, > > >>> > > > > > >> >> > > >>> > > > > > >> >> could you please create 4.3-SNAPSHOT build? > > >>> > > > > > >> >> > > >>> > > > > > >> > > > >>> > > > > > >> > I'll check whether I have permission to publish a > > SNAPSHOT > > >>> > build > > >>> > > > to > > >>> > > > > > the > > >>> > > > > > >> > SNAPSHOT repo. > > >>> > > > > > >> > > > >>> > > > > > >> > > >>> > > > > > >> I've deployed the latest code to > > >>> > > > > > >> > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > >>> > > > > > >> > > >>> > > > > > >> Regards, > > >>> > > > > > >> Benedikt > > >>> > > > > > >> > > >>> > > > > > >> > > >>> > > > > > >> > > > >>> > > > > > >> > > > >>> > > > > > >> >> > > >>> > > > > > >> >> And if you have any estimates on 4.3 release, could > you > > >>> > please > > >>> > > > > share > > >>> > > > > > it? > > >>> > > > > > >> >> :) > > >>> > > > > > >> >> > > >>> > > > > > >> > > > >>> > > > > > >> > We don't have estimates or a roadmap. But I've this on > > my > > >>> > list, > > >>> > > > > > because I > > >>> > > > > > >> > know you're depending on it. I have two days vacation > > next > > >>> > week. > > >>> > > > > That > > >>> > > > > > may > > >>> > > > > > >> > be an opportunity for me to work towards a 4.3 > release. > > >>> > > > > > >> > > > >>> > > > > > >> > Regards, > > >>> > > > > > >> > Benedikt > > >>> > > > > > >> > > > >>> > > > > > >> > > > >>> > > > > > >> >> > > >>> > > > > > >> >> > > >>> > > > > > >> >> > > >>> > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > > >>> > > > > solomax...@gmail.com > > >>> > > > > > > > > >>> > > > > > >> >> wrote: > > >>> > > > > > >> >> > > >>> > > > > > >> >> > One more question: it seems there is no > 4.3-SNAPSHOT > > >>> build > > >>> > > > > > available > > >>> > > > > > >> >> > Could you please create it? > > >>> > > > > > >> >> > > > >>> > > > > > >> >> >
Re: Help with migrating one of OpenJPA classes to commons-collections4
There are a couple of issues. I'll try to take a look tonight. Gary On Mon, Dec 3, 2018 at 9:24 AM Maxim Solodovnik wrote: > Hello, > > OpenJpa release is blocked by absence of commons-collections release > Are there any blockers? > > On Mon, 26 Nov 2018 at 20:08, Maxim Solodovnik > wrote: > > > Hello Gary, > > > > any news regarding release? :))) > > > > On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik > > wrote: > > > >> Many thanks :) > >> > >> On Tue, 13 Nov 2018 at 12:50, Gary Gregory > >> wrote: > >> > >>> I hope someone will take the time to do this over the US Thanksgiving > >>> holidays perhaps. > >>> > >>> Gary > >>> > >>> On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik >>> wrote: > >>> > >>> > Hello Gary, > >>> > > >>> > we all are volunteers :) > >>> > Why I'm asking: it will be blocker for OpenJPA release > >>> > > >>> > On Tue, 16 Oct 2018 at 19:39, Gary Gregory > >>> wrote: > >>> > > >>> > > Hi, > >>> > > > >>> > > There is no ETA, and since we are all volunteers, it depends on > who > >>> > wants > >>> > > to step up and take the time to do it. > >>> > > > >>> > > Gary > >>> > > > >>> > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik > > >>> > wrote: > >>> > > > >>> > > > Hello Gary, > >>> > > > > >>> > > > SNAPSHOT works for us expected :) > >>> > > > There is no rush, I just want to get some ETA :) > >>> > > > > >>> > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory < > garydgreg...@gmail.com > >>> > > >>> > > wrote: > >>> > > > > >>> > > > > Are there any open issues we want to address for 4.3 is the > >>> SNAPSHOT > >>> > OK > >>> > > > as > >>> > > > > is? > >>> > > > > > >>> > > > > Gary > >>> > > > > > >>> > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < > >>> > > solomax...@gmail.com> > >>> > > > > wrote: > >>> > > > > > >>> > > > > > Hello Benedikt, > >>> > > > > > > >>> > > > > > I would like to remind you about 4.3 release :) > >>> > > > > > > >>> > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < > >>> > solomax...@gmail.com > >>> > > > > >>> > > > > > wrote: > >>> > > > > > > > >>> > > > > > > Great, > >>> > > > > > > > >>> > > > > > > Thanks a million! > >>> > > > > > > > >>> > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < > >>> > brit...@apache.org> > >>> > > > > > wrote: > >>> > > > > > >> > >>> > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt > Ritter < > >>> > > > > > >> brit...@apache.org>: > >>> > > > > > >> > >>> > > > > > >> > Hello Maxim, > >>> > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim > >>> Solodovnik < > >>> > > > > > >> > solomax...@gmail.com>: > >>> > > > > > >> > > >>> > > > > > >> >> Hello, > >>> > > > > > >> >> > >>> > > > > > >> >> could you please create 4.3-SNAPSHOT build? > >>> > > > > > >> >> > >>> > > > > > >> > > >>> > > > > > >> > I'll check whether I have permission to publish a > SNAPSHOT > >>> > build > >>> > > > to > >>> > > > > > the > >>> > > > > > >> > SNAPSHOT repo. > >>> > > > > > >> > > >>> > > > > > >> > >>> > > > > > >> I've deployed the latest code to > >>> > > > > > >> > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > >>> > > > > > >> > >>> > > > > > >> Regards, > >>> > > > > > >> Benedikt > >>> > > > > > >> > >>> > > > > > >> > >>> > > > > > >> > > >>> > > > > > >> > > >>> > > > > > >> >> > >>> > > > > > >> >> And if you have any estimates on 4.3 release, could you > >>> > please > >>> > > > > share > >>> > > > > > it? > >>> > > > > > >> >> :) > >>> > > > > > >> >> > >>> > > > > > >> > > >>> > > > > > >> > We don't have estimates or a roadmap. But I've this on > my > >>> > list, > >>> > > > > > because I > >>> > > > > > >> > know you're depending on it. I have two days vacation > next > >>> > week. > >>> > > > > That > >>> > > > > > may > >>> > > > > > >> > be an opportunity for me to work towards a 4.3 release. > >>> > > > > > >> > > >>> > > > > > >> > Regards, > >>> > > > > > >> > Benedikt > >>> > > > > > >> > > >>> > > > > > >> > > >>> > > > > > >> >> > >>> > > > > > >> >> > >>> > > > > > >> >> > >>> > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > >>> > > > > solomax...@gmail.com > >>> > > > > > > > >>> > > > > > >> >> wrote: > >>> > > > > > >> >> > >>> > > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT > >>> build > >>> > > > > > available > >>> > > > > > >> >> > Could you please create it? > >>> > > > > > >> >> > > >>> > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > >>> > > > > > solomax...@gmail.com> > >>> > > > > > >> >> > wrote: > >>> > > > > > >> >> > > > >>> > > > > > >> >> > > Hello Gary, > >>> > > > > > >> >> > > > >>> > > > > > >> >> > > I have tested changes, everything works as expected > >>> > > > > > >> >> > > Thanks a lot! > >>> > > > > > >> >> > > > >>> > > > > > >> >> > > I have closed PR, but have no rights to close JIRA > :( > >>> > > > > > >> >> > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello, OpenJpa release is blocked by absence of commons-collections release Are there any blockers? On Mon, 26 Nov 2018 at 20:08, Maxim Solodovnik wrote: > Hello Gary, > > any news regarding release? :))) > > On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik > wrote: > >> Many thanks :) >> >> On Tue, 13 Nov 2018 at 12:50, Gary Gregory >> wrote: >> >>> I hope someone will take the time to do this over the US Thanksgiving >>> holidays perhaps. >>> >>> Gary >>> >>> On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik >> wrote: >>> >>> > Hello Gary, >>> > >>> > we all are volunteers :) >>> > Why I'm asking: it will be blocker for OpenJPA release >>> > >>> > On Tue, 16 Oct 2018 at 19:39, Gary Gregory >>> wrote: >>> > >>> > > Hi, >>> > > >>> > > There is no ETA, and since we are all volunteers, it depends on who >>> > wants >>> > > to step up and take the time to do it. >>> > > >>> > > Gary >>> > > >>> > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik >>> > wrote: >>> > > >>> > > > Hello Gary, >>> > > > >>> > > > SNAPSHOT works for us expected :) >>> > > > There is no rush, I just want to get some ETA :) >>> > > > >>> > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory >> > >>> > > wrote: >>> > > > >>> > > > > Are there any open issues we want to address for 4.3 is the >>> SNAPSHOT >>> > OK >>> > > > as >>> > > > > is? >>> > > > > >>> > > > > Gary >>> > > > > >>> > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < >>> > > solomax...@gmail.com> >>> > > > > wrote: >>> > > > > >>> > > > > > Hello Benedikt, >>> > > > > > >>> > > > > > I would like to remind you about 4.3 release :) >>> > > > > > >>> > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < >>> > solomax...@gmail.com >>> > > > >>> > > > > > wrote: >>> > > > > > > >>> > > > > > > Great, >>> > > > > > > >>> > > > > > > Thanks a million! >>> > > > > > > >>> > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < >>> > brit...@apache.org> >>> > > > > > wrote: >>> > > > > > >> >>> > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < >>> > > > > > >> brit...@apache.org>: >>> > > > > > >> >>> > > > > > >> > Hello Maxim, >>> > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim >>> Solodovnik < >>> > > > > > >> > solomax...@gmail.com>: >>> > > > > > >> > >>> > > > > > >> >> Hello, >>> > > > > > >> >> >>> > > > > > >> >> could you please create 4.3-SNAPSHOT build? >>> > > > > > >> >> >>> > > > > > >> > >>> > > > > > >> > I'll check whether I have permission to publish a SNAPSHOT >>> > build >>> > > > to >>> > > > > > the >>> > > > > > >> > SNAPSHOT repo. >>> > > > > > >> > >>> > > > > > >> >>> > > > > > >> I've deployed the latest code to >>> > > > > > >> >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > >>> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ >>> > > > > > >> >>> > > > > > >> Regards, >>> > > > > > >> Benedikt >>> > > > > > >> >>> > > > > > >> >>> > > > > > >> > >>> > > > > > >> > >>> > > > > > >> >> >>> > > > > > >> >> And if you have any estimates on 4.3 release, could you >>> > please >>> > > > > share >>> > > > > > it? >>> > > > > > >> >> :) >>> > > > > > >> >> >>> > > > > > >> > >>> > > > > > >> > We don't have estimates or a roadmap. But I've this on my >>> > list, >>> > > > > > because I >>> > > > > > >> > know you're depending on it. I have two days vacation next >>> > week. >>> > > > > That >>> > > > > > may >>> > > > > > >> > be an opportunity for me to work towards a 4.3 release. >>> > > > > > >> > >>> > > > > > >> > Regards, >>> > > > > > >> > Benedikt >>> > > > > > >> > >>> > > > > > >> > >>> > > > > > >> >> >>> > > > > > >> >> >>> > > > > > >> >> >>> > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < >>> > > > > solomax...@gmail.com >>> > > > > > > >>> > > > > > >> >> wrote: >>> > > > > > >> >> >>> > > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT >>> build >>> > > > > > available >>> > > > > > >> >> > Could you please create it? >>> > > > > > >> >> > >>> > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < >>> > > > > > solomax...@gmail.com> >>> > > > > > >> >> > wrote: >>> > > > > > >> >> > > >>> > > > > > >> >> > > Hello Gary, >>> > > > > > >> >> > > >>> > > > > > >> >> > > I have tested changes, everything works as expected >>> > > > > > >> >> > > Thanks a lot! >>> > > > > > >> >> > > >>> > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( >>> > > > > > >> >> > > >>> > > > > > >> >> > > Do you have any plans for 4.3 release? >>> > > > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < >>> > > > > > garydgreg...@gmail.com> >>> > > > > > >> >> > wrote: >>> > > > > > >> >> > > > >>> > > > > > >> >> > > > Maxim, >>> > > > > > >> >> > > > Thank you for your patch. >>> > > > > > >> >> > > > I created >>> > > > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and >>> > > > > > >> >> > > > committed you patch to git master. >>> > > > > > >> >> >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gary, any news regarding release? :))) On Tue, 13 Nov 2018 at 12:51, Maxim Solodovnik wrote: > Many thanks :) > > On Tue, 13 Nov 2018 at 12:50, Gary Gregory wrote: > >> I hope someone will take the time to do this over the US Thanksgiving >> holidays perhaps. >> >> Gary >> >> On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik > >> > Hello Gary, >> > >> > we all are volunteers :) >> > Why I'm asking: it will be blocker for OpenJPA release >> > >> > On Tue, 16 Oct 2018 at 19:39, Gary Gregory >> wrote: >> > >> > > Hi, >> > > >> > > There is no ETA, and since we are all volunteers, it depends on who >> > wants >> > > to step up and take the time to do it. >> > > >> > > Gary >> > > >> > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik >> > wrote: >> > > >> > > > Hello Gary, >> > > > >> > > > SNAPSHOT works for us expected :) >> > > > There is no rush, I just want to get some ETA :) >> > > > >> > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory >> > > wrote: >> > > > >> > > > > Are there any open issues we want to address for 4.3 is the >> SNAPSHOT >> > OK >> > > > as >> > > > > is? >> > > > > >> > > > > Gary >> > > > > >> > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < >> > > solomax...@gmail.com> >> > > > > wrote: >> > > > > >> > > > > > Hello Benedikt, >> > > > > > >> > > > > > I would like to remind you about 4.3 release :) >> > > > > > >> > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < >> > solomax...@gmail.com >> > > > >> > > > > > wrote: >> > > > > > > >> > > > > > > Great, >> > > > > > > >> > > > > > > Thanks a million! >> > > > > > > >> > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < >> > brit...@apache.org> >> > > > > > wrote: >> > > > > > >> >> > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < >> > > > > > >> brit...@apache.org>: >> > > > > > >> >> > > > > > >> > Hello Maxim, >> > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim >> Solodovnik < >> > > > > > >> > solomax...@gmail.com>: >> > > > > > >> > >> > > > > > >> >> Hello, >> > > > > > >> >> >> > > > > > >> >> could you please create 4.3-SNAPSHOT build? >> > > > > > >> >> >> > > > > > >> > >> > > > > > >> > I'll check whether I have permission to publish a SNAPSHOT >> > build >> > > > to >> > > > > > the >> > > > > > >> > SNAPSHOT repo. >> > > > > > >> > >> > > > > > >> >> > > > > > >> I've deployed the latest code to >> > > > > > >> >> > > > > > >> > > > > >> > > > >> > > >> > >> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ >> > > > > > >> >> > > > > > >> Regards, >> > > > > > >> Benedikt >> > > > > > >> >> > > > > > >> >> > > > > > >> > >> > > > > > >> > >> > > > > > >> >> >> > > > > > >> >> And if you have any estimates on 4.3 release, could you >> > please >> > > > > share >> > > > > > it? >> > > > > > >> >> :) >> > > > > > >> >> >> > > > > > >> > >> > > > > > >> > We don't have estimates or a roadmap. But I've this on my >> > list, >> > > > > > because I >> > > > > > >> > know you're depending on it. I have two days vacation next >> > week. >> > > > > That >> > > > > > may >> > > > > > >> > be an opportunity for me to work towards a 4.3 release. >> > > > > > >> > >> > > > > > >> > Regards, >> > > > > > >> > Benedikt >> > > > > > >> > >> > > > > > >> > >> > > > > > >> >> >> > > > > > >> >> >> > > > > > >> >> >> > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < >> > > > > solomax...@gmail.com >> > > > > > > >> > > > > > >> >> wrote: >> > > > > > >> >> >> > > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT >> build >> > > > > > available >> > > > > > >> >> > Could you please create it? >> > > > > > >> >> > >> > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < >> > > > > > solomax...@gmail.com> >> > > > > > >> >> > wrote: >> > > > > > >> >> > > >> > > > > > >> >> > > Hello Gary, >> > > > > > >> >> > > >> > > > > > >> >> > > I have tested changes, everything works as expected >> > > > > > >> >> > > Thanks a lot! >> > > > > > >> >> > > >> > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( >> > > > > > >> >> > > >> > > > > > >> >> > > Do you have any plans for 4.3 release? >> > > > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < >> > > > > > garydgreg...@gmail.com> >> > > > > > >> >> > wrote: >> > > > > > >> >> > > > >> > > > > > >> >> > > > Maxim, >> > > > > > >> >> > > > Thank you for your patch. >> > > > > > >> >> > > > I created >> > > > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and >> > > > > > >> >> > > > committed you patch to git master. >> > > > > > >> >> > > > Please verify and close the Jira ticket and GitHub >> PR. >> > > > > > >> >> > > > >> > > > > > >> >> > > > Thank you, >> > > > > > >> >> > > > Gary >> > > > > > >> >> > > > >> > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < >> > > > > > >> >> solomax...@gmail.com >> > > > > > >> >> > > >> > > > > > >> >> > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Many thanks :) On Tue, 13 Nov 2018 at 12:50, Gary Gregory wrote: > I hope someone will take the time to do this over the US Thanksgiving > holidays perhaps. > > Gary > > On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik > > Hello Gary, > > > > we all are volunteers :) > > Why I'm asking: it will be blocker for OpenJPA release > > > > On Tue, 16 Oct 2018 at 19:39, Gary Gregory > wrote: > > > > > Hi, > > > > > > There is no ETA, and since we are all volunteers, it depends on who > > wants > > > to step up and take the time to do it. > > > > > > Gary > > > > > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik > > wrote: > > > > > > > Hello Gary, > > > > > > > > SNAPSHOT works for us expected :) > > > > There is no rush, I just want to get some ETA :) > > > > > > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory > > > wrote: > > > > > > > > > Are there any open issues we want to address for 4.3 is the > SNAPSHOT > > OK > > > > as > > > > > is? > > > > > > > > > > Gary > > > > > > > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < > > > solomax...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hello Benedikt, > > > > > > > > > > > > I would like to remind you about 4.3 release :) > > > > > > > > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < > > solomax...@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > > > > Great, > > > > > > > > > > > > > > Thanks a million! > > > > > > > > > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < > > brit...@apache.org> > > > > > > wrote: > > > > > > >> > > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < > > > > > > >> brit...@apache.org>: > > > > > > >> > > > > > > >> > Hello Maxim, > > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik > < > > > > > > >> > solomax...@gmail.com>: > > > > > > >> > > > > > > > >> >> Hello, > > > > > > >> >> > > > > > > >> >> could you please create 4.3-SNAPSHOT build? > > > > > > >> >> > > > > > > >> > > > > > > > >> > I'll check whether I have permission to publish a SNAPSHOT > > build > > > > to > > > > > > the > > > > > > >> > SNAPSHOT repo. > > > > > > >> > > > > > > > >> > > > > > > >> I've deployed the latest code to > > > > > > >> > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > > > > > >> > > > > > > >> Regards, > > > > > > >> Benedikt > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > >> > > > > > > > >> >> > > > > > > >> >> And if you have any estimates on 4.3 release, could you > > please > > > > > share > > > > > > it? > > > > > > >> >> :) > > > > > > >> >> > > > > > > >> > > > > > > > >> > We don't have estimates or a roadmap. But I've this on my > > list, > > > > > > because I > > > > > > >> > know you're depending on it. I have two days vacation next > > week. > > > > > That > > > > > > may > > > > > > >> > be an opportunity for me to work towards a 4.3 release. > > > > > > >> > > > > > > > >> > Regards, > > > > > > >> > Benedikt > > > > > > >> > > > > > > > >> > > > > > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > > > > > solomax...@gmail.com > > > > > > > > > > > > > >> >> wrote: > > > > > > >> >> > > > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT > build > > > > > > available > > > > > > >> >> > Could you please create it? > > > > > > >> >> > > > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > > > > > > solomax...@gmail.com> > > > > > > >> >> > wrote: > > > > > > >> >> > > > > > > > > >> >> > > Hello Gary, > > > > > > >> >> > > > > > > > > >> >> > > I have tested changes, everything works as expected > > > > > > >> >> > > Thanks a lot! > > > > > > >> >> > > > > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( > > > > > > >> >> > > > > > > > > >> >> > > Do you have any plans for 4.3 release? > > > > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < > > > > > > garydgreg...@gmail.com> > > > > > > >> >> > wrote: > > > > > > >> >> > > > > > > > > > >> >> > > > Maxim, > > > > > > >> >> > > > Thank you for your patch. > > > > > > >> >> > > > I created > > > > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and > > > > > > >> >> > > > committed you patch to git master. > > > > > > >> >> > > > Please verify and close the Jira ticket and GitHub > PR. > > > > > > >> >> > > > > > > > > > >> >> > > > Thank you, > > > > > > >> >> > > > Gary > > > > > > >> >> > > > > > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < > > > > > > >> >> solomax...@gmail.com > > > > > > >> >> > > > > > > > > >> >> > > > wrote: > > > > > > >> >> > > > > > > > > > >> >> > > > > Done: > > > > > https://github.com/apache/commons-collections/pull/51 > > > > > > >> >> > > > > Could you please take a look at this PR? > > > > > > >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory < > > > > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
I hope someone will take the time to do this over the US Thanksgiving holidays perhaps. Gary On Mon, Nov 12, 2018, 22:37 Maxim Solodovnik Hello Gary, > > we all are volunteers :) > Why I'm asking: it will be blocker for OpenJPA release > > On Tue, 16 Oct 2018 at 19:39, Gary Gregory wrote: > > > Hi, > > > > There is no ETA, and since we are all volunteers, it depends on who > wants > > to step up and take the time to do it. > > > > Gary > > > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik > wrote: > > > > > Hello Gary, > > > > > > SNAPSHOT works for us expected :) > > > There is no rush, I just want to get some ETA :) > > > > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory > > wrote: > > > > > > > Are there any open issues we want to address for 4.3 is the SNAPSHOT > OK > > > as > > > > is? > > > > > > > > Gary > > > > > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < > > solomax...@gmail.com> > > > > wrote: > > > > > > > > > Hello Benedikt, > > > > > > > > > > I would like to remind you about 4.3 release :) > > > > > > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik < > solomax...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > > Great, > > > > > > > > > > > > Thanks a million! > > > > > > > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter < > brit...@apache.org> > > > > > wrote: > > > > > >> > > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < > > > > > >> brit...@apache.org>: > > > > > >> > > > > > >> > Hello Maxim, > > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < > > > > > >> > solomax...@gmail.com>: > > > > > >> > > > > > > >> >> Hello, > > > > > >> >> > > > > > >> >> could you please create 4.3-SNAPSHOT build? > > > > > >> >> > > > > > >> > > > > > > >> > I'll check whether I have permission to publish a SNAPSHOT > build > > > to > > > > > the > > > > > >> > SNAPSHOT repo. > > > > > >> > > > > > > >> > > > > > >> I've deployed the latest code to > > > > > >> > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > > > > >> > > > > > >> Regards, > > > > > >> Benedikt > > > > > >> > > > > > >> > > > > > >> > > > > > > >> > > > > > > >> >> > > > > > >> >> And if you have any estimates on 4.3 release, could you > please > > > > share > > > > > it? > > > > > >> >> :) > > > > > >> >> > > > > > >> > > > > > > >> > We don't have estimates or a roadmap. But I've this on my > list, > > > > > because I > > > > > >> > know you're depending on it. I have two days vacation next > week. > > > > That > > > > > may > > > > > >> > be an opportunity for me to work towards a 4.3 release. > > > > > >> > > > > > > >> > Regards, > > > > > >> > Benedikt > > > > > >> > > > > > > >> > > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > > > > solomax...@gmail.com > > > > > > > > > > > >> >> wrote: > > > > > >> >> > > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT build > > > > > available > > > > > >> >> > Could you please create it? > > > > > >> >> > > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > > > > > solomax...@gmail.com> > > > > > >> >> > wrote: > > > > > >> >> > > > > > > > >> >> > > Hello Gary, > > > > > >> >> > > > > > > > >> >> > > I have tested changes, everything works as expected > > > > > >> >> > > Thanks a lot! > > > > > >> >> > > > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( > > > > > >> >> > > > > > > > >> >> > > Do you have any plans for 4.3 release? > > > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < > > > > > garydgreg...@gmail.com> > > > > > >> >> > wrote: > > > > > >> >> > > > > > > > > >> >> > > > Maxim, > > > > > >> >> > > > Thank you for your patch. > > > > > >> >> > > > I created > > > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and > > > > > >> >> > > > committed you patch to git master. > > > > > >> >> > > > Please verify and close the Jira ticket and GitHub PR. > > > > > >> >> > > > > > > > > >> >> > > > Thank you, > > > > > >> >> > > > Gary > > > > > >> >> > > > > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < > > > > > >> >> solomax...@gmail.com > > > > > >> >> > > > > > > > >> >> > > > wrote: > > > > > >> >> > > > > > > > > >> >> > > > > Done: > > > > https://github.com/apache/commons-collections/pull/51 > > > > > >> >> > > > > Could you please take a look at this PR? > > > > > >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory < > > > > > garydgreg...@gmail.com > > > > > >> >> > > > > > > >> >> > wrote: > > > > > >> >> > > > > > > > > > > >> >> > > > > > Hi, > > > > > >> >> > > > > > > > > > > >> >> > > > > > Your best shot would be to submit a PR on GitHub > > which > > > > > includes > > > > > >> >> a > > > > > >> >> > unit > > > > > >> >> > > > > test > > > > > >> >> > > > > > that exercises the new code. > > > > > >> >> > > > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gary, we all are volunteers :) Why I'm asking: it will be blocker for OpenJPA release On Tue, 16 Oct 2018 at 19:39, Gary Gregory wrote: > Hi, > > There is no ETA, and since we are all volunteers, it depends on who wants > to step up and take the time to do it. > > Gary > > On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik wrote: > > > Hello Gary, > > > > SNAPSHOT works for us expected :) > > There is no rush, I just want to get some ETA :) > > > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory > wrote: > > > > > Are there any open issues we want to address for 4.3 is the SNAPSHOT OK > > as > > > is? > > > > > > Gary > > > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik < > solomax...@gmail.com> > > > wrote: > > > > > > > Hello Benedikt, > > > > > > > > I would like to remind you about 4.3 release :) > > > > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik > > > > > wrote: > > > > > > > > > > Great, > > > > > > > > > > Thanks a million! > > > > > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter > > > > wrote: > > > > >> > > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < > > > > >> brit...@apache.org>: > > > > >> > > > > >> > Hello Maxim, > > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < > > > > >> > solomax...@gmail.com>: > > > > >> > > > > > >> >> Hello, > > > > >> >> > > > > >> >> could you please create 4.3-SNAPSHOT build? > > > > >> >> > > > > >> > > > > > >> > I'll check whether I have permission to publish a SNAPSHOT build > > to > > > > the > > > > >> > SNAPSHOT repo. > > > > >> > > > > > >> > > > > >> I've deployed the latest code to > > > > >> > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > > > >> > > > > >> Regards, > > > > >> Benedikt > > > > >> > > > > >> > > > > >> > > > > > >> > > > > > >> >> > > > > >> >> And if you have any estimates on 4.3 release, could you please > > > share > > > > it? > > > > >> >> :) > > > > >> >> > > > > >> > > > > > >> > We don't have estimates or a roadmap. But I've this on my list, > > > > because I > > > > >> > know you're depending on it. I have two days vacation next week. > > > That > > > > may > > > > >> > be an opportunity for me to work towards a 4.3 release. > > > > >> > > > > > >> > Regards, > > > > >> > Benedikt > > > > >> > > > > > >> > > > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > > > solomax...@gmail.com > > > > > > > > > >> >> wrote: > > > > >> >> > > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT build > > > > available > > > > >> >> > Could you please create it? > > > > >> >> > > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > > > > solomax...@gmail.com> > > > > >> >> > wrote: > > > > >> >> > > > > > > >> >> > > Hello Gary, > > > > >> >> > > > > > > >> >> > > I have tested changes, everything works as expected > > > > >> >> > > Thanks a lot! > > > > >> >> > > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( > > > > >> >> > > > > > > >> >> > > Do you have any plans for 4.3 release? > > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < > > > > garydgreg...@gmail.com> > > > > >> >> > wrote: > > > > >> >> > > > > > > > >> >> > > > Maxim, > > > > >> >> > > > Thank you for your patch. > > > > >> >> > > > I created > > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and > > > > >> >> > > > committed you patch to git master. > > > > >> >> > > > Please verify and close the Jira ticket and GitHub PR. > > > > >> >> > > > > > > > >> >> > > > Thank you, > > > > >> >> > > > Gary > > > > >> >> > > > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < > > > > >> >> solomax...@gmail.com > > > > >> >> > > > > > > >> >> > > > wrote: > > > > >> >> > > > > > > > >> >> > > > > Done: > > > https://github.com/apache/commons-collections/pull/51 > > > > >> >> > > > > Could you please take a look at this PR? > > > > >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory < > > > > garydgreg...@gmail.com > > > > >> >> > > > > > >> >> > wrote: > > > > >> >> > > > > > > > > > >> >> > > > > > Hi, > > > > >> >> > > > > > > > > > >> >> > > > > > Your best shot would be to submit a PR on GitHub > which > > > > includes > > > > >> >> a > > > > >> >> > unit > > > > >> >> > > > > test > > > > >> >> > > > > > that exercises the new code. > > > > >> >> > > > > > > > > > >> >> > > > > > https://github.com/apache/commons-collections > > > > >> >> > > > > > > > > > >> >> > > > > > Thank you, > > > > >> >> > > > > > Gary > > > > >> >> > > > > > > > > > >> >> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik < > > > > >> >> > solomax...@gmail.com> > > > > >> >> > > > > > wrote: > > > > >> >> > > > > > > > > > >> >> > > > > > > Would it be possible to modify the code of > > > > >> >> > AbstractReferenceMap.java as > > > > >> >> > > > > > > follows? > > > > >> >> > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hi, There is no ETA, and since we are all volunteers, it depends on who wants to step up and take the time to do it. Gary On Mon, Oct 15, 2018, 22:23 Maxim Solodovnik wrote: > Hello Gary, > > SNAPSHOT works for us expected :) > There is no rush, I just want to get some ETA :) > > On Tue, 16 Oct 2018 at 00:07, Gary Gregory wrote: > > > Are there any open issues we want to address for 4.3 is the SNAPSHOT OK > as > > is? > > > > Gary > > > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik > > wrote: > > > > > Hello Benedikt, > > > > > > I would like to remind you about 4.3 release :) > > > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik > > > wrote: > > > > > > > > Great, > > > > > > > > Thanks a million! > > > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter > > > wrote: > > > >> > > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < > > > >> brit...@apache.org>: > > > >> > > > >> > Hello Maxim, > > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < > > > >> > solomax...@gmail.com>: > > > >> > > > > >> >> Hello, > > > >> >> > > > >> >> could you please create 4.3-SNAPSHOT build? > > > >> >> > > > >> > > > > >> > I'll check whether I have permission to publish a SNAPSHOT build > to > > > the > > > >> > SNAPSHOT repo. > > > >> > > > > >> > > > >> I've deployed the latest code to > > > >> > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > > >> > > > >> Regards, > > > >> Benedikt > > > >> > > > >> > > > >> > > > > >> > > > > >> >> > > > >> >> And if you have any estimates on 4.3 release, could you please > > share > > > it? > > > >> >> :) > > > >> >> > > > >> > > > > >> > We don't have estimates or a roadmap. But I've this on my list, > > > because I > > > >> > know you're depending on it. I have two days vacation next week. > > That > > > may > > > >> > be an opportunity for me to work towards a 4.3 release. > > > >> > > > > >> > Regards, > > > >> > Benedikt > > > >> > > > > >> > > > > >> >> > > > >> >> > > > >> >> > > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > > solomax...@gmail.com > > > > > > > >> >> wrote: > > > >> >> > > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT build > > > available > > > >> >> > Could you please create it? > > > >> >> > > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > > > solomax...@gmail.com> > > > >> >> > wrote: > > > >> >> > > > > > >> >> > > Hello Gary, > > > >> >> > > > > > >> >> > > I have tested changes, everything works as expected > > > >> >> > > Thanks a lot! > > > >> >> > > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( > > > >> >> > > > > > >> >> > > Do you have any plans for 4.3 release? > > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < > > > garydgreg...@gmail.com> > > > >> >> > wrote: > > > >> >> > > > > > > >> >> > > > Maxim, > > > >> >> > > > Thank you for your patch. > > > >> >> > > > I created > > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and > > > >> >> > > > committed you patch to git master. > > > >> >> > > > Please verify and close the Jira ticket and GitHub PR. > > > >> >> > > > > > > >> >> > > > Thank you, > > > >> >> > > > Gary > > > >> >> > > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < > > > >> >> solomax...@gmail.com > > > >> >> > > > > > >> >> > > > wrote: > > > >> >> > > > > > > >> >> > > > > Done: > > https://github.com/apache/commons-collections/pull/51 > > > >> >> > > > > Could you please take a look at this PR? > > > >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory < > > > garydgreg...@gmail.com > > > >> >> > > > > >> >> > wrote: > > > >> >> > > > > > > > > >> >> > > > > > Hi, > > > >> >> > > > > > > > > >> >> > > > > > Your best shot would be to submit a PR on GitHub which > > > includes > > > >> >> a > > > >> >> > unit > > > >> >> > > > > test > > > >> >> > > > > > that exercises the new code. > > > >> >> > > > > > > > > >> >> > > > > > https://github.com/apache/commons-collections > > > >> >> > > > > > > > > >> >> > > > > > Thank you, > > > >> >> > > > > > Gary > > > >> >> > > > > > > > > >> >> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik < > > > >> >> > solomax...@gmail.com> > > > >> >> > > > > > wrote: > > > >> >> > > > > > > > > >> >> > > > > > > Would it be possible to modify the code of > > > >> >> > AbstractReferenceMap.java as > > > >> >> > > > > > > follows? > > > >> >> > > > > > > > > > >> >> > > > > > > > > > >> >> > > > > > > diff --git > > > >> >> > > > > > > > > > >> >> > > > > > > > > > >> >> > > > > > > > >> >> > > > > >> >> > > > > > > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > > >> >> > > > > > > > > > >> >> > > > > > > > > > >> >> > > > > > > > >> >> > > > > >> >> > > > > > > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > > >> >> > > > > > > index 0eda632f..81f60b4b 100644 > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gary, SNAPSHOT works for us expected :) There is no rush, I just want to get some ETA :) On Tue, 16 Oct 2018 at 00:07, Gary Gregory wrote: > Are there any open issues we want to address for 4.3 is the SNAPSHOT OK as > is? > > Gary > > On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik > wrote: > > > Hello Benedikt, > > > > I would like to remind you about 4.3 release :) > > > > On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik > > wrote: > > > > > > Great, > > > > > > Thanks a million! > > > > > > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter > > wrote: > > >> > > >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter < > > >> brit...@apache.org>: > > >> > > >> > Hello Maxim, > > >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik < > > >> > solomax...@gmail.com>: > > >> > > > >> >> Hello, > > >> >> > > >> >> could you please create 4.3-SNAPSHOT build? > > >> >> > > >> > > > >> > I'll check whether I have permission to publish a SNAPSHOT build to > > the > > >> > SNAPSHOT repo. > > >> > > > >> > > >> I've deployed the latest code to > > >> > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/ > > >> > > >> Regards, > > >> Benedikt > > >> > > >> > > >> > > > >> > > > >> >> > > >> >> And if you have any estimates on 4.3 release, could you please > share > > it? > > >> >> :) > > >> >> > > >> > > > >> > We don't have estimates or a roadmap. But I've this on my list, > > because I > > >> > know you're depending on it. I have two days vacation next week. > That > > may > > >> > be an opportunity for me to work towards a 4.3 release. > > >> > > > >> > Regards, > > >> > Benedikt > > >> > > > >> > > > >> >> > > >> >> > > >> >> > > >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik < > solomax...@gmail.com > > > > > >> >> wrote: > > >> >> > > >> >> > One more question: it seems there is no 4.3-SNAPSHOT build > > available > > >> >> > Could you please create it? > > >> >> > > > >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik < > > solomax...@gmail.com> > > >> >> > wrote: > > >> >> > > > > >> >> > > Hello Gary, > > >> >> > > > > >> >> > > I have tested changes, everything works as expected > > >> >> > > Thanks a lot! > > >> >> > > > > >> >> > > I have closed PR, but have no rights to close JIRA :( > > >> >> > > > > >> >> > > Do you have any plans for 4.3 release? > > >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory < > > garydgreg...@gmail.com> > > >> >> > wrote: > > >> >> > > > > > >> >> > > > Maxim, > > >> >> > > > Thank you for your patch. > > >> >> > > > I created > > https://issues.apache.org/jira/browse/COLLECTIONS-696 and > > >> >> > > > committed you patch to git master. > > >> >> > > > Please verify and close the Jira ticket and GitHub PR. > > >> >> > > > > > >> >> > > > Thank you, > > >> >> > > > Gary > > >> >> > > > > > >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik < > > >> >> solomax...@gmail.com > > >> >> > > > > >> >> > > > wrote: > > >> >> > > > > > >> >> > > > > Done: > https://github.com/apache/commons-collections/pull/51 > > >> >> > > > > Could you please take a look at this PR? > > >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory < > > garydgreg...@gmail.com > > >> >> > > > >> >> > wrote: > > >> >> > > > > > > > >> >> > > > > > Hi, > > >> >> > > > > > > > >> >> > > > > > Your best shot would be to submit a PR on GitHub which > > includes > > >> >> a > > >> >> > unit > > >> >> > > > > test > > >> >> > > > > > that exercises the new code. > > >> >> > > > > > > > >> >> > > > > > https://github.com/apache/commons-collections > > >> >> > > > > > > > >> >> > > > > > Thank you, > > >> >> > > > > > Gary > > >> >> > > > > > > > >> >> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik < > > >> >> > solomax...@gmail.com> > > >> >> > > > > > wrote: > > >> >> > > > > > > > >> >> > > > > > > Would it be possible to modify the code of > > >> >> > AbstractReferenceMap.java as > > >> >> > > > > > > follows? > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > diff --git > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > >> >> > > > >> >> > > > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > >> >> > > > >> >> > > > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > >> >> > > > > > > index 0eda632f..81f60b4b 100644 > > >> >> > > > > > > --- > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > >> >> > > > >> >> > > > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > >> >> > > > > > > +++ > > >> >> > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > >> >> > > > >> >> > > > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java > > >> >> > > > > > > @@ -400,13 +400,15 @@ public abstract class > > >> >> > AbstractReferenceMap > > >> >> > > > > > > extends
Re: Help with migrating one of OpenJPA classes to commons-collections4
Are there any open issues we want to address for 4.3 is the SNAPSHOT OK as
is?
Gary
On Mon, Oct 15, 2018 at 10:42 AM Maxim Solodovnik
wrote:
> Hello Benedikt,
>
> I would like to remind you about 4.3 release :)
>
> On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik
> wrote:
> >
> > Great,
> >
> > Thanks a million!
> >
> > On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter
> wrote:
> >>
> >> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter <
> >> brit...@apache.org>:
> >>
> >> > Hello Maxim,
> >> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik <
> >> > solomax...@gmail.com>:
> >> >
> >> >> Hello,
> >> >>
> >> >> could you please create 4.3-SNAPSHOT build?
> >> >>
> >> >
> >> > I'll check whether I have permission to publish a SNAPSHOT build to
> the
> >> > SNAPSHOT repo.
> >> >
> >>
> >> I've deployed the latest code to
> >>
> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/
> >>
> >> Regards,
> >> Benedikt
> >>
> >>
> >> >
> >> >
> >> >>
> >> >> And if you have any estimates on 4.3 release, could you please share
> it?
> >> >> :)
> >> >>
> >> >
> >> > We don't have estimates or a roadmap. But I've this on my list,
> because I
> >> > know you're depending on it. I have two days vacation next week. That
> may
> >> > be an opportunity for me to work towards a 4.3 release.
> >> >
> >> > Regards,
> >> > Benedikt
> >> >
> >> >
> >> >>
> >> >>
> >> >>
> >> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik >
> >> >> wrote:
> >> >>
> >> >> > One more question: it seems there is no 4.3-SNAPSHOT build
> available
> >> >> > Could you please create it?
> >> >> >
> >> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik <
> solomax...@gmail.com>
> >> >> > wrote:
> >> >> > >
> >> >> > > Hello Gary,
> >> >> > >
> >> >> > > I have tested changes, everything works as expected
> >> >> > > Thanks a lot!
> >> >> > >
> >> >> > > I have closed PR, but have no rights to close JIRA :(
> >> >> > >
> >> >> > > Do you have any plans for 4.3 release?
> >> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory <
> garydgreg...@gmail.com>
> >> >> > wrote:
> >> >> > > >
> >> >> > > > Maxim,
> >> >> > > > Thank you for your patch.
> >> >> > > > I created
> https://issues.apache.org/jira/browse/COLLECTIONS-696 and
> >> >> > > > committed you patch to git master.
> >> >> > > > Please verify and close the Jira ticket and GitHub PR.
> >> >> > > >
> >> >> > > > Thank you,
> >> >> > > > Gary
> >> >> > > >
> >> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik <
> >> >> solomax...@gmail.com
> >> >> > >
> >> >> > > > wrote:
> >> >> > > >
> >> >> > > > > Done: https://github.com/apache/commons-collections/pull/51
> >> >> > > > > Could you please take a look at this PR?
> >> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory <
> garydgreg...@gmail.com
> >> >> >
> >> >> > wrote:
> >> >> > > > > >
> >> >> > > > > > Hi,
> >> >> > > > > >
> >> >> > > > > > Your best shot would be to submit a PR on GitHub which
> includes
> >> >> a
> >> >> > unit
> >> >> > > > > test
> >> >> > > > > > that exercises the new code.
> >> >> > > > > >
> >> >> > > > > > https://github.com/apache/commons-collections
> >> >> > > > > >
> >> >> > > > > > Thank you,
> >> >> > > > > > Gary
> >> >> > > > > >
> >> >> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik <
> >> >> > solomax...@gmail.com>
> >> >> > > > > > wrote:
> >> >> > > > > >
> >> >> > > > > > > Would it be possible to modify the code of
> >> >> > AbstractReferenceMap.java as
> >> >> > > > > > > follows?
> >> >> > > > > > >
> >> >> > > > > > >
> >> >> > > > > > > diff --git
> >> >> > > > > > >
> >> >> > > > > > >
> >> >> > > > >
> >> >> >
> >> >>
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> >> >> > > > > > >
> >> >> > > > > > >
> >> >> > > > >
> >> >> >
> >> >>
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> >> >> > > > > > > index 0eda632f..81f60b4b 100644
> >> >> > > > > > > ---
> >> >> > > > > > >
> >> >> > > > > > >
> >> >> > > > >
> >> >> >
> >> >>
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> >> >> > > > > > > +++
> >> >> > > > > > >
> >> >> > > > > > >
> >> >> > > > >
> >> >> >
> >> >>
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> >> >> > > > > > > @@ -400,13 +400,15 @@ public abstract class
> >> >> > AbstractReferenceMap
> >> >> > > > > > > extends AbstractHashedMap
> >> >> > > > > > > HashEntry previous = null;
> >> >> > > > > > > HashEntry entry = data[index];
> >> >> > > > > > > while (entry != null) {
> >> >> > > > > > > -if (((ReferenceEntry)
> entry).purge(ref)) {
> >> >> > > > > > > +ReferenceEntry refEntry =
> >> >> (ReferenceEntry >> >> > V>)
> >> >> > > > > entry;
> >> >> > > > > > > +if (refEntry.purge(ref)) {
> >> >> > > > > > > if (previous == null) {
> >> >> > > > > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Benedikt,
I would like to remind you about 4.3 release :)
On Tue, 25 Sep 2018 at 20:45, Maxim Solodovnik wrote:
>
> Great,
>
> Thanks a million!
>
> On Tue, 25 Sep 2018 at 20:39, Benedikt Ritter wrote:
>>
>> Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter <
>> brit...@apache.org>:
>>
>> > Hello Maxim,
>> > Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik <
>> > solomax...@gmail.com>:
>> >
>> >> Hello,
>> >>
>> >> could you please create 4.3-SNAPSHOT build?
>> >>
>> >
>> > I'll check whether I have permission to publish a SNAPSHOT build to the
>> > SNAPSHOT repo.
>> >
>>
>> I've deployed the latest code to
>> https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/
>>
>> Regards,
>> Benedikt
>>
>>
>> >
>> >
>> >>
>> >> And if you have any estimates on 4.3 release, could you please share it?
>> >> :)
>> >>
>> >
>> > We don't have estimates or a roadmap. But I've this on my list, because I
>> > know you're depending on it. I have two days vacation next week. That may
>> > be an opportunity for me to work towards a 4.3 release.
>> >
>> > Regards,
>> > Benedikt
>> >
>> >
>> >>
>> >>
>> >>
>> >> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik
>> >> wrote:
>> >>
>> >> > One more question: it seems there is no 4.3-SNAPSHOT build available
>> >> > Could you please create it?
>> >> >
>> >> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik
>> >> > wrote:
>> >> > >
>> >> > > Hello Gary,
>> >> > >
>> >> > > I have tested changes, everything works as expected
>> >> > > Thanks a lot!
>> >> > >
>> >> > > I have closed PR, but have no rights to close JIRA :(
>> >> > >
>> >> > > Do you have any plans for 4.3 release?
>> >> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory
>> >> > wrote:
>> >> > > >
>> >> > > > Maxim,
>> >> > > > Thank you for your patch.
>> >> > > > I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
>> >> > > > committed you patch to git master.
>> >> > > > Please verify and close the Jira ticket and GitHub PR.
>> >> > > >
>> >> > > > Thank you,
>> >> > > > Gary
>> >> > > >
>> >> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik <
>> >> solomax...@gmail.com
>> >> > >
>> >> > > > wrote:
>> >> > > >
>> >> > > > > Done: https://github.com/apache/commons-collections/pull/51
>> >> > > > > Could you please take a look at this PR?
>> >> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory > >> >
>> >> > wrote:
>> >> > > > > >
>> >> > > > > > Hi,
>> >> > > > > >
>> >> > > > > > Your best shot would be to submit a PR on GitHub which includes
>> >> a
>> >> > unit
>> >> > > > > test
>> >> > > > > > that exercises the new code.
>> >> > > > > >
>> >> > > > > > https://github.com/apache/commons-collections
>> >> > > > > >
>> >> > > > > > Thank you,
>> >> > > > > > Gary
>> >> > > > > >
>> >> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik <
>> >> > solomax...@gmail.com>
>> >> > > > > > wrote:
>> >> > > > > >
>> >> > > > > > > Would it be possible to modify the code of
>> >> > AbstractReferenceMap.java as
>> >> > > > > > > follows?
>> >> > > > > > >
>> >> > > > > > >
>> >> > > > > > > diff --git
>> >> > > > > > >
>> >> > > > > > >
>> >> > > > >
>> >> >
>> >> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> >> > > > > > >
>> >> > > > > > >
>> >> > > > >
>> >> >
>> >> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> >> > > > > > > index 0eda632f..81f60b4b 100644
>> >> > > > > > > ---
>> >> > > > > > >
>> >> > > > > > >
>> >> > > > >
>> >> >
>> >> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> >> > > > > > > +++
>> >> > > > > > >
>> >> > > > > > >
>> >> > > > >
>> >> >
>> >> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> >> > > > > > > @@ -400,13 +400,15 @@ public abstract class
>> >> > AbstractReferenceMap
>> >> > > > > > > extends AbstractHashedMap
>> >> > > > > > > HashEntry previous = null;
>> >> > > > > > > HashEntry entry = data[index];
>> >> > > > > > > while (entry != null) {
>> >> > > > > > > -if (((ReferenceEntry) entry).purge(ref)) {
>> >> > > > > > > +ReferenceEntry refEntry =
>> >> (ReferenceEntry> >> > V>)
>> >> > > > > entry;
>> >> > > > > > > +if (refEntry.purge(ref)) {
>> >> > > > > > > if (previous == null) {
>> >> > > > > > > data[index] = entry.next;
>> >> > > > > > > } else {
>> >> > > > > > > previous.next = entry.next;
>> >> > > > > > > }
>> >> > > > > > > this.size--;
>> >> > > > > > > +refEntry.onPurge();
>> >> > > > > > > return;
>> >> > > > > > > }
>> >> > > > > > > previous = entry;
>> >> > > > > > > @@ -721,12 +723,15 @@ public abstract class
>> >> > AbstractReferenceMap
>> >> > > > > > > extends AbstractHashedMap
>> >> > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Am Di., 25. Sep. 2018 um 15:36 Uhr schrieb Benedikt Ritter <
brit...@apache.org>:
> Hello Maxim,
> Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik <
> solomax...@gmail.com>:
>
>> Hello,
>>
>> could you please create 4.3-SNAPSHOT build?
>>
>
> I'll check whether I have permission to publish a SNAPSHOT build to the
> SNAPSHOT repo.
>
I've deployed the latest code to
https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-collections4/4.3-SNAPSHOT/
Regards,
Benedikt
>
>
>>
>> And if you have any estimates on 4.3 release, could you please share it?
>> :)
>>
>
> We don't have estimates or a roadmap. But I've this on my list, because I
> know you're depending on it. I have two days vacation next week. That may
> be an opportunity for me to work towards a 4.3 release.
>
> Regards,
> Benedikt
>
>
>>
>>
>>
>> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik
>> wrote:
>>
>> > One more question: it seems there is no 4.3-SNAPSHOT build available
>> > Could you please create it?
>> >
>> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik
>> > wrote:
>> > >
>> > > Hello Gary,
>> > >
>> > > I have tested changes, everything works as expected
>> > > Thanks a lot!
>> > >
>> > > I have closed PR, but have no rights to close JIRA :(
>> > >
>> > > Do you have any plans for 4.3 release?
>> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory
>> > wrote:
>> > > >
>> > > > Maxim,
>> > > > Thank you for your patch.
>> > > > I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
>> > > > committed you patch to git master.
>> > > > Please verify and close the Jira ticket and GitHub PR.
>> > > >
>> > > > Thank you,
>> > > > Gary
>> > > >
>> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik <
>> solomax...@gmail.com
>> > >
>> > > > wrote:
>> > > >
>> > > > > Done: https://github.com/apache/commons-collections/pull/51
>> > > > > Could you please take a look at this PR?
>> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory > >
>> > wrote:
>> > > > > >
>> > > > > > Hi,
>> > > > > >
>> > > > > > Your best shot would be to submit a PR on GitHub which includes
>> a
>> > unit
>> > > > > test
>> > > > > > that exercises the new code.
>> > > > > >
>> > > > > > https://github.com/apache/commons-collections
>> > > > > >
>> > > > > > Thank you,
>> > > > > > Gary
>> > > > > >
>> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik <
>> > solomax...@gmail.com>
>> > > > > > wrote:
>> > > > > >
>> > > > > > > Would it be possible to modify the code of
>> > AbstractReferenceMap.java as
>> > > > > > > follows?
>> > > > > > >
>> > > > > > >
>> > > > > > > diff --git
>> > > > > > >
>> > > > > > >
>> > > > >
>> >
>> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> > > > > > >
>> > > > > > >
>> > > > >
>> >
>> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> > > > > > > index 0eda632f..81f60b4b 100644
>> > > > > > > ---
>> > > > > > >
>> > > > > > >
>> > > > >
>> >
>> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> > > > > > > +++
>> > > > > > >
>> > > > > > >
>> > > > >
>> >
>> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>> > > > > > > @@ -400,13 +400,15 @@ public abstract class
>> > AbstractReferenceMap
>> > > > > > > extends AbstractHashedMap
>> > > > > > > HashEntry previous = null;
>> > > > > > > HashEntry entry = data[index];
>> > > > > > > while (entry != null) {
>> > > > > > > -if (((ReferenceEntry) entry).purge(ref)) {
>> > > > > > > +ReferenceEntry refEntry =
>> (ReferenceEntry> > V>)
>> > > > > entry;
>> > > > > > > +if (refEntry.purge(ref)) {
>> > > > > > > if (previous == null) {
>> > > > > > > data[index] = entry.next;
>> > > > > > > } else {
>> > > > > > > previous.next = entry.next;
>> > > > > > > }
>> > > > > > > this.size--;
>> > > > > > > +refEntry.onPurge();
>> > > > > > > return;
>> > > > > > > }
>> > > > > > > previous = entry;
>> > > > > > > @@ -721,12 +723,15 @@ public abstract class
>> > AbstractReferenceMap
>> > > > > > > extends AbstractHashedMap
>> > > > > > > throw new Error();
>> > > > > > > }
>> > > > > > >
>> > > > > > > +protected void onPurge() {
>> > > > > > > +}
>> > > > > > > +
>> > > > > > > /**
>> > > > > > > * Purges the specified reference
>> > > > > > > * @param ref the reference to purge
>> > > > > > > * @return true or false
>> > > > > > > */
>> > > > > > > -boolean purge(final Reference ref) {
>> > > > > > > +protected boolean purge(final Reference ref) {
>> > > > > > > boolean r = parent.keyType !=
>> > ReferenceStrength.HARD &&
>> > > > > key ==
>> > > > > > > ref;
>> > > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Maxim,
Am Mo., 24. Sep. 2018 um 05:32 Uhr schrieb Maxim Solodovnik <
solomax...@gmail.com>:
> Hello,
>
> could you please create 4.3-SNAPSHOT build?
>
I'll check whether I have permission to publish a SNAPSHOT build to the
SNAPSHOT repo.
>
> And if you have any estimates on 4.3 release, could you please share it? :)
>
We don't have estimates or a roadmap. But I've this on my list, because I
know you're depending on it. I have two days vacation next week. That may
be an opportunity for me to work towards a 4.3 release.
Regards,
Benedikt
>
>
>
> On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik
> wrote:
>
> > One more question: it seems there is no 4.3-SNAPSHOT build available
> > Could you please create it?
> >
> > On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik
> > wrote:
> > >
> > > Hello Gary,
> > >
> > > I have tested changes, everything works as expected
> > > Thanks a lot!
> > >
> > > I have closed PR, but have no rights to close JIRA :(
> > >
> > > Do you have any plans for 4.3 release?
> > > On Wed, 19 Sep 2018 at 22:11, Gary Gregory
> > wrote:
> > > >
> > > > Maxim,
> > > > Thank you for your patch.
> > > > I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
> > > > committed you patch to git master.
> > > > Please verify and close the Jira ticket and GitHub PR.
> > > >
> > > > Thank you,
> > > > Gary
> > > >
> > > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik <
> solomax...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Done: https://github.com/apache/commons-collections/pull/51
> > > > > Could you please take a look at this PR?
> > > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory
> > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > Your best shot would be to submit a PR on GitHub which includes a
> > unit
> > > > > test
> > > > > > that exercises the new code.
> > > > > >
> > > > > > https://github.com/apache/commons-collections
> > > > > >
> > > > > > Thank you,
> > > > > > Gary
> > > > > >
> > > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik <
> > solomax...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Would it be possible to modify the code of
> > AbstractReferenceMap.java as
> > > > > > > follows?
> > > > > > >
> > > > > > >
> > > > > > > diff --git
> > > > > > >
> > > > > > >
> > > > >
> >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > >
> > > > > > >
> > > > >
> >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > > index 0eda632f..81f60b4b 100644
> > > > > > > ---
> > > > > > >
> > > > > > >
> > > > >
> >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > > +++
> > > > > > >
> > > > > > >
> > > > >
> >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > > @@ -400,13 +400,15 @@ public abstract class
> > AbstractReferenceMap
> > > > > > > extends AbstractHashedMap
> > > > > > > HashEntry previous = null;
> > > > > > > HashEntry entry = data[index];
> > > > > > > while (entry != null) {
> > > > > > > -if (((ReferenceEntry) entry).purge(ref)) {
> > > > > > > +ReferenceEntry refEntry = (ReferenceEntry > V>)
> > > > > entry;
> > > > > > > +if (refEntry.purge(ref)) {
> > > > > > > if (previous == null) {
> > > > > > > data[index] = entry.next;
> > > > > > > } else {
> > > > > > > previous.next = entry.next;
> > > > > > > }
> > > > > > > this.size--;
> > > > > > > +refEntry.onPurge();
> > > > > > > return;
> > > > > > > }
> > > > > > > previous = entry;
> > > > > > > @@ -721,12 +723,15 @@ public abstract class
> > AbstractReferenceMap
> > > > > > > extends AbstractHashedMap
> > > > > > > throw new Error();
> > > > > > > }
> > > > > > >
> > > > > > > +protected void onPurge() {
> > > > > > > +}
> > > > > > > +
> > > > > > > /**
> > > > > > > * Purges the specified reference
> > > > > > > * @param ref the reference to purge
> > > > > > > * @return true or false
> > > > > > > */
> > > > > > > -boolean purge(final Reference ref) {
> > > > > > > +protected boolean purge(final Reference ref) {
> > > > > > > boolean r = parent.keyType !=
> > ReferenceStrength.HARD &&
> > > > > key ==
> > > > > > > ref;
> > > > > > > r = r || parent.valueType !=
> ReferenceStrength.HARD
> > &&
> > > > > value
> > > > > > > == ref;
> > > > > > > if (r) {
> > > > > > > @@ -1073,4 +1078,17 @@ public abstract class
> > AbstractReferenceMap
> > > > > > > extends AbstractHashedMap
> > > > > > > protected boolean isKeyType(final ReferenceStrength type)
> {
> > > > > > > return this.keyType == type;
> > > > > > > }
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello,
could you please create 4.3-SNAPSHOT build?
And if you have any estimates on 4.3 release, could you please share it? :)
On Thu, 20 Sep 2018 at 17:58, Maxim Solodovnik wrote:
> One more question: it seems there is no 4.3-SNAPSHOT build available
> Could you please create it?
>
> On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik
> wrote:
> >
> > Hello Gary,
> >
> > I have tested changes, everything works as expected
> > Thanks a lot!
> >
> > I have closed PR, but have no rights to close JIRA :(
> >
> > Do you have any plans for 4.3 release?
> > On Wed, 19 Sep 2018 at 22:11, Gary Gregory
> wrote:
> > >
> > > Maxim,
> > > Thank you for your patch.
> > > I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
> > > committed you patch to git master.
> > > Please verify and close the Jira ticket and GitHub PR.
> > >
> > > Thank you,
> > > Gary
> > >
> > > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik >
> > > wrote:
> > >
> > > > Done: https://github.com/apache/commons-collections/pull/51
> > > > Could you please take a look at this PR?
> > > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory
> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > Your best shot would be to submit a PR on GitHub which includes a
> unit
> > > > test
> > > > > that exercises the new code.
> > > > >
> > > > > https://github.com/apache/commons-collections
> > > > >
> > > > > Thank you,
> > > > > Gary
> > > > >
> > > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik <
> solomax...@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Would it be possible to modify the code of
> AbstractReferenceMap.java as
> > > > > > follows?
> > > > > >
> > > > > >
> > > > > > diff --git
> > > > > >
> > > > > >
> > > >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > >
> > > > > >
> > > >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > index 0eda632f..81f60b4b 100644
> > > > > > ---
> > > > > >
> > > > > >
> > > >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > +++
> > > > > >
> > > > > >
> > > >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > > @@ -400,13 +400,15 @@ public abstract class
> AbstractReferenceMap
> > > > > > extends AbstractHashedMap
> > > > > > HashEntry previous = null;
> > > > > > HashEntry entry = data[index];
> > > > > > while (entry != null) {
> > > > > > -if (((ReferenceEntry) entry).purge(ref)) {
> > > > > > +ReferenceEntry refEntry = (ReferenceEntry V>)
> > > > entry;
> > > > > > +if (refEntry.purge(ref)) {
> > > > > > if (previous == null) {
> > > > > > data[index] = entry.next;
> > > > > > } else {
> > > > > > previous.next = entry.next;
> > > > > > }
> > > > > > this.size--;
> > > > > > +refEntry.onPurge();
> > > > > > return;
> > > > > > }
> > > > > > previous = entry;
> > > > > > @@ -721,12 +723,15 @@ public abstract class
> AbstractReferenceMap
> > > > > > extends AbstractHashedMap
> > > > > > throw new Error();
> > > > > > }
> > > > > >
> > > > > > +protected void onPurge() {
> > > > > > +}
> > > > > > +
> > > > > > /**
> > > > > > * Purges the specified reference
> > > > > > * @param ref the reference to purge
> > > > > > * @return true or false
> > > > > > */
> > > > > > -boolean purge(final Reference ref) {
> > > > > > +protected boolean purge(final Reference ref) {
> > > > > > boolean r = parent.keyType !=
> ReferenceStrength.HARD &&
> > > > key ==
> > > > > > ref;
> > > > > > r = r || parent.valueType != ReferenceStrength.HARD
> &&
> > > > value
> > > > > > == ref;
> > > > > > if (r) {
> > > > > > @@ -1073,4 +1078,17 @@ public abstract class
> AbstractReferenceMap
> > > > > > extends AbstractHashedMap
> > > > > > protected boolean isKeyType(final ReferenceStrength type) {
> > > > > > return this.keyType == type;
> > > > > > }
> > > > > > +
> > > > > > +/**
> > > > > > + * Provided protected read-only access to the value type.
> > > > > > + * @param type the type to check against.
> > > > > > + * @return true if valueType has the specified type
> > > > > > + */
> > > > > > +protected boolean isValueType(final ReferenceStrength type)
> {
> > > > > > +return this.valueType == type;
> > > > > > +}
> > > > > > +
> > > > > > +public boolean isPurgeValues() {
> > > > > > +return purgeValues;
> > > > > > +}
> > > > > > }
> > > > > >
> > > > > >
> > > > > > On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik <
> solomax...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Thanks a lot for the
Re: Help with migrating one of OpenJPA classes to commons-collections4
One more question: it seems there is no 4.3-SNAPSHOT build available
Could you please create it?
On Thu, 20 Sep 2018 at 12:47, Maxim Solodovnik wrote:
>
> Hello Gary,
>
> I have tested changes, everything works as expected
> Thanks a lot!
>
> I have closed PR, but have no rights to close JIRA :(
>
> Do you have any plans for 4.3 release?
> On Wed, 19 Sep 2018 at 22:11, Gary Gregory wrote:
> >
> > Maxim,
> > Thank you for your patch.
> > I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
> > committed you patch to git master.
> > Please verify and close the Jira ticket and GitHub PR.
> >
> > Thank you,
> > Gary
> >
> > On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik
> > wrote:
> >
> > > Done: https://github.com/apache/commons-collections/pull/51
> > > Could you please take a look at this PR?
> > > On Thu, 6 Sep 2018 at 03:17, Gary Gregory wrote:
> > > >
> > > > Hi,
> > > >
> > > > Your best shot would be to submit a PR on GitHub which includes a unit
> > > test
> > > > that exercises the new code.
> > > >
> > > > https://github.com/apache/commons-collections
> > > >
> > > > Thank you,
> > > > Gary
> > > >
> > > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik
> > > > wrote:
> > > >
> > > > > Would it be possible to modify the code of AbstractReferenceMap.java
> > > > > as
> > > > > follows?
> > > > >
> > > > >
> > > > > diff --git
> > > > >
> > > > >
> > > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > >
> > > > >
> > > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > index 0eda632f..81f60b4b 100644
> > > > > ---
> > > > >
> > > > >
> > > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > +++
> > > > >
> > > > >
> > > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > > @@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
> > > > > extends AbstractHashedMap
> > > > > HashEntry previous = null;
> > > > > HashEntry entry = data[index];
> > > > > while (entry != null) {
> > > > > -if (((ReferenceEntry) entry).purge(ref)) {
> > > > > +ReferenceEntry refEntry = (ReferenceEntry)
> > > entry;
> > > > > +if (refEntry.purge(ref)) {
> > > > > if (previous == null) {
> > > > > data[index] = entry.next;
> > > > > } else {
> > > > > previous.next = entry.next;
> > > > > }
> > > > > this.size--;
> > > > > +refEntry.onPurge();
> > > > > return;
> > > > > }
> > > > > previous = entry;
> > > > > @@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
> > > > > extends AbstractHashedMap
> > > > > throw new Error();
> > > > > }
> > > > >
> > > > > +protected void onPurge() {
> > > > > +}
> > > > > +
> > > > > /**
> > > > > * Purges the specified reference
> > > > > * @param ref the reference to purge
> > > > > * @return true or false
> > > > > */
> > > > > -boolean purge(final Reference ref) {
> > > > > +protected boolean purge(final Reference ref) {
> > > > > boolean r = parent.keyType != ReferenceStrength.HARD &&
> > > key ==
> > > > > ref;
> > > > > r = r || parent.valueType != ReferenceStrength.HARD &&
> > > value
> > > > > == ref;
> > > > > if (r) {
> > > > > @@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap > > > > V>
> > > > > extends AbstractHashedMap
> > > > > protected boolean isKeyType(final ReferenceStrength type) {
> > > > > return this.keyType == type;
> > > > > }
> > > > > +
> > > > > +/**
> > > > > + * Provided protected read-only access to the value type.
> > > > > + * @param type the type to check against.
> > > > > + * @return true if valueType has the specified type
> > > > > + */
> > > > > +protected boolean isValueType(final ReferenceStrength type) {
> > > > > +return this.valueType == type;
> > > > > +}
> > > > > +
> > > > > +public boolean isPurgeValues() {
> > > > > +return purgeValues;
> > > > > +}
> > > > > }
> > > > >
> > > > >
> > > > > On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik
> > > > > wrote:
> > > > >
> > > > > > Thanks a lot for the answer,
> > > > > >
> > > > > > OpenJPA ReferenceHashMap overrides purge method to be able to call
> > > > > > custom methods keyExpired/valueExpired [1]
> > > > > > I see no way to migrate this code without massive copy/paste or
> > > > > reflection
> > > > > > ...
> > > > > >
> > > > > > Maybe you can suggest something?
> > > > > > Or maybe commons-collections API can be enhanced so this task will
> > > > > > be
> > > > > > trivial :)
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > >
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hello Gary,
I have tested changes, everything works as expected
Thanks a lot!
I have closed PR, but have no rights to close JIRA :(
Do you have any plans for 4.3 release?
On Wed, 19 Sep 2018 at 22:11, Gary Gregory wrote:
>
> Maxim,
> Thank you for your patch.
> I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
> committed you patch to git master.
> Please verify and close the Jira ticket and GitHub PR.
>
> Thank you,
> Gary
>
> On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik
> wrote:
>
> > Done: https://github.com/apache/commons-collections/pull/51
> > Could you please take a look at this PR?
> > On Thu, 6 Sep 2018 at 03:17, Gary Gregory wrote:
> > >
> > > Hi,
> > >
> > > Your best shot would be to submit a PR on GitHub which includes a unit
> > test
> > > that exercises the new code.
> > >
> > > https://github.com/apache/commons-collections
> > >
> > > Thank you,
> > > Gary
> > >
> > > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik
> > > wrote:
> > >
> > > > Would it be possible to modify the code of AbstractReferenceMap.java as
> > > > follows?
> > > >
> > > >
> > > > diff --git
> > > >
> > > >
> > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > >
> > > >
> > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > index 0eda632f..81f60b4b 100644
> > > > ---
> > > >
> > > >
> > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > +++
> > > >
> > > >
> > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > > @@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
> > > > extends AbstractHashedMap
> > > > HashEntry previous = null;
> > > > HashEntry entry = data[index];
> > > > while (entry != null) {
> > > > -if (((ReferenceEntry) entry).purge(ref)) {
> > > > +ReferenceEntry refEntry = (ReferenceEntry)
> > entry;
> > > > +if (refEntry.purge(ref)) {
> > > > if (previous == null) {
> > > > data[index] = entry.next;
> > > > } else {
> > > > previous.next = entry.next;
> > > > }
> > > > this.size--;
> > > > +refEntry.onPurge();
> > > > return;
> > > > }
> > > > previous = entry;
> > > > @@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
> > > > extends AbstractHashedMap
> > > > throw new Error();
> > > > }
> > > >
> > > > +protected void onPurge() {
> > > > +}
> > > > +
> > > > /**
> > > > * Purges the specified reference
> > > > * @param ref the reference to purge
> > > > * @return true or false
> > > > */
> > > > -boolean purge(final Reference ref) {
> > > > +protected boolean purge(final Reference ref) {
> > > > boolean r = parent.keyType != ReferenceStrength.HARD &&
> > key ==
> > > > ref;
> > > > r = r || parent.valueType != ReferenceStrength.HARD &&
> > value
> > > > == ref;
> > > > if (r) {
> > > > @@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap
> > > > extends AbstractHashedMap
> > > > protected boolean isKeyType(final ReferenceStrength type) {
> > > > return this.keyType == type;
> > > > }
> > > > +
> > > > +/**
> > > > + * Provided protected read-only access to the value type.
> > > > + * @param type the type to check against.
> > > > + * @return true if valueType has the specified type
> > > > + */
> > > > +protected boolean isValueType(final ReferenceStrength type) {
> > > > +return this.valueType == type;
> > > > +}
> > > > +
> > > > +public boolean isPurgeValues() {
> > > > +return purgeValues;
> > > > +}
> > > > }
> > > >
> > > >
> > > > On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik
> > > > wrote:
> > > >
> > > > > Thanks a lot for the answer,
> > > > >
> > > > > OpenJPA ReferenceHashMap overrides purge method to be able to call
> > > > > custom methods keyExpired/valueExpired [1]
> > > > > I see no way to migrate this code without massive copy/paste or
> > > > reflection
> > > > > ...
> > > > >
> > > > > Maybe you can suggest something?
> > > > > Or maybe commons-collections API can be enhanced so this task will be
> > > > > trivial :)
> > > > >
> > > > >
> > > > >
> > > >
> > https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138
> > > > >
> > > > > On Mon, 3 Sep 2018 at 20:03, Julio Oliveira
> > > > > wrote:
> > > > > >
> > > > > > What is realy your problem??..
> > > > > >
> > > > > > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik <
> > solomax...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > > Hello,
> > > > > > >
> > > > > > > I'm trying to migrate code of Apache OpenJPA from
>
Re: Help with migrating one of OpenJPA classes to commons-collections4
Maxim,
Thank you for your patch.
I created https://issues.apache.org/jira/browse/COLLECTIONS-696 and
committed you patch to git master.
Please verify and close the Jira ticket and GitHub PR.
Thank you,
Gary
On Wed, Sep 19, 2018 at 1:24 AM Maxim Solodovnik
wrote:
> Done: https://github.com/apache/commons-collections/pull/51
> Could you please take a look at this PR?
> On Thu, 6 Sep 2018 at 03:17, Gary Gregory wrote:
> >
> > Hi,
> >
> > Your best shot would be to submit a PR on GitHub which includes a unit
> test
> > that exercises the new code.
> >
> > https://github.com/apache/commons-collections
> >
> > Thank you,
> > Gary
> >
> > On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik
> > wrote:
> >
> > > Would it be possible to modify the code of AbstractReferenceMap.java as
> > > follows?
> > >
> > >
> > > diff --git
> > >
> > >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > >
> > >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > index 0eda632f..81f60b4b 100644
> > > ---
> > >
> > >
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > +++
> > >
> > >
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > > @@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
> > > extends AbstractHashedMap
> > > HashEntry previous = null;
> > > HashEntry entry = data[index];
> > > while (entry != null) {
> > > -if (((ReferenceEntry) entry).purge(ref)) {
> > > +ReferenceEntry refEntry = (ReferenceEntry)
> entry;
> > > +if (refEntry.purge(ref)) {
> > > if (previous == null) {
> > > data[index] = entry.next;
> > > } else {
> > > previous.next = entry.next;
> > > }
> > > this.size--;
> > > +refEntry.onPurge();
> > > return;
> > > }
> > > previous = entry;
> > > @@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
> > > extends AbstractHashedMap
> > > throw new Error();
> > > }
> > >
> > > +protected void onPurge() {
> > > +}
> > > +
> > > /**
> > > * Purges the specified reference
> > > * @param ref the reference to purge
> > > * @return true or false
> > > */
> > > -boolean purge(final Reference ref) {
> > > +protected boolean purge(final Reference ref) {
> > > boolean r = parent.keyType != ReferenceStrength.HARD &&
> key ==
> > > ref;
> > > r = r || parent.valueType != ReferenceStrength.HARD &&
> value
> > > == ref;
> > > if (r) {
> > > @@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap
> > > extends AbstractHashedMap
> > > protected boolean isKeyType(final ReferenceStrength type) {
> > > return this.keyType == type;
> > > }
> > > +
> > > +/**
> > > + * Provided protected read-only access to the value type.
> > > + * @param type the type to check against.
> > > + * @return true if valueType has the specified type
> > > + */
> > > +protected boolean isValueType(final ReferenceStrength type) {
> > > +return this.valueType == type;
> > > +}
> > > +
> > > +public boolean isPurgeValues() {
> > > +return purgeValues;
> > > +}
> > > }
> > >
> > >
> > > On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik
> > > wrote:
> > >
> > > > Thanks a lot for the answer,
> > > >
> > > > OpenJPA ReferenceHashMap overrides purge method to be able to call
> > > > custom methods keyExpired/valueExpired [1]
> > > > I see no way to migrate this code without massive copy/paste or
> > > reflection
> > > > ...
> > > >
> > > > Maybe you can suggest something?
> > > > Or maybe commons-collections API can be enhanced so this task will be
> > > > trivial :)
> > > >
> > > >
> > > >
> > >
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138
> > > >
> > > > On Mon, 3 Sep 2018 at 20:03, Julio Oliveira
> > > > wrote:
> > > > >
> > > > > What is realy your problem??..
> > > > >
> > > > > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik <
> solomax...@gmail.com>
> > > > wrote:
> > > > >
> > > > > > Hello,
> > > > > >
> > > > > > I'm trying to migrate code of Apache OpenJPA from
> commons-collections
> > > > > > to commons-collections4
> > > > > >
> > > > > > The only real issue so far with migrating this class
> > > > > >
> > > > > >
> > > >
> > >
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112
> > > > > >
> > > > > > code of commons-collections4 is more restrictive could you please
> > > > > > suggest how custom purge can be implemented?
> > > > > >
> > > > > > --
> > > > > > WBR
> > > > > > Maxim aka
Re: Help with migrating one of OpenJPA classes to commons-collections4
Done: https://github.com/apache/commons-collections/pull/51
Could you please take a look at this PR?
On Thu, 6 Sep 2018 at 03:17, Gary Gregory wrote:
>
> Hi,
>
> Your best shot would be to submit a PR on GitHub which includes a unit test
> that exercises the new code.
>
> https://github.com/apache/commons-collections
>
> Thank you,
> Gary
>
> On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik
> wrote:
>
> > Would it be possible to modify the code of AbstractReferenceMap.java as
> > follows?
> >
> >
> > diff --git
> >
> > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> >
> > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > index 0eda632f..81f60b4b 100644
> > ---
> >
> > a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > +++
> >
> > b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> > @@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
> > extends AbstractHashedMap
> > HashEntry previous = null;
> > HashEntry entry = data[index];
> > while (entry != null) {
> > -if (((ReferenceEntry) entry).purge(ref)) {
> > +ReferenceEntry refEntry = (ReferenceEntry) entry;
> > +if (refEntry.purge(ref)) {
> > if (previous == null) {
> > data[index] = entry.next;
> > } else {
> > previous.next = entry.next;
> > }
> > this.size--;
> > +refEntry.onPurge();
> > return;
> > }
> > previous = entry;
> > @@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
> > extends AbstractHashedMap
> > throw new Error();
> > }
> >
> > +protected void onPurge() {
> > +}
> > +
> > /**
> > * Purges the specified reference
> > * @param ref the reference to purge
> > * @return true or false
> > */
> > -boolean purge(final Reference ref) {
> > +protected boolean purge(final Reference ref) {
> > boolean r = parent.keyType != ReferenceStrength.HARD && key ==
> > ref;
> > r = r || parent.valueType != ReferenceStrength.HARD && value
> > == ref;
> > if (r) {
> > @@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap
> > extends AbstractHashedMap
> > protected boolean isKeyType(final ReferenceStrength type) {
> > return this.keyType == type;
> > }
> > +
> > +/**
> > + * Provided protected read-only access to the value type.
> > + * @param type the type to check against.
> > + * @return true if valueType has the specified type
> > + */
> > +protected boolean isValueType(final ReferenceStrength type) {
> > +return this.valueType == type;
> > +}
> > +
> > +public boolean isPurgeValues() {
> > +return purgeValues;
> > +}
> > }
> >
> >
> > On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik
> > wrote:
> >
> > > Thanks a lot for the answer,
> > >
> > > OpenJPA ReferenceHashMap overrides purge method to be able to call
> > > custom methods keyExpired/valueExpired [1]
> > > I see no way to migrate this code without massive copy/paste or
> > reflection
> > > ...
> > >
> > > Maybe you can suggest something?
> > > Or maybe commons-collections API can be enhanced so this task will be
> > > trivial :)
> > >
> > >
> > >
> > https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138
> > >
> > > On Mon, 3 Sep 2018 at 20:03, Julio Oliveira
> > > wrote:
> > > >
> > > > What is realy your problem??..
> > > >
> > > > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik
> > > wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > I'm trying to migrate code of Apache OpenJPA from commons-collections
> > > > > to commons-collections4
> > > > >
> > > > > The only real issue so far with migrating this class
> > > > >
> > > > >
> > >
> > https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112
> > > > >
> > > > > code of commons-collections4 is more restrictive could you please
> > > > > suggest how custom purge can be implemented?
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > > >
> > > > > -
> > > > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> > > > > For additional commands, e-mail: user-h...@commons.apache.org
> > > > >
> > > > >
> > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
--
WBR
Maxim aka solomax
-
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail:
Re: Help with migrating one of OpenJPA classes to commons-collections4
Hi,
Your best shot would be to submit a PR on GitHub which includes a unit test
that exercises the new code.
https://github.com/apache/commons-collections
Thank you,
Gary
On Wed, Sep 5, 2018 at 10:12 AM Maxim Solodovnik
wrote:
> Would it be possible to modify the code of AbstractReferenceMap.java as
> follows?
>
>
> diff --git
>
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
>
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> index 0eda632f..81f60b4b 100644
> ---
>
> a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> +++
>
> b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
> @@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
> extends AbstractHashedMap
> HashEntry previous = null;
> HashEntry entry = data[index];
> while (entry != null) {
> -if (((ReferenceEntry) entry).purge(ref)) {
> +ReferenceEntry refEntry = (ReferenceEntry) entry;
> +if (refEntry.purge(ref)) {
> if (previous == null) {
> data[index] = entry.next;
> } else {
> previous.next = entry.next;
> }
> this.size--;
> +refEntry.onPurge();
> return;
> }
> previous = entry;
> @@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
> extends AbstractHashedMap
> throw new Error();
> }
>
> +protected void onPurge() {
> +}
> +
> /**
> * Purges the specified reference
> * @param ref the reference to purge
> * @return true or false
> */
> -boolean purge(final Reference ref) {
> +protected boolean purge(final Reference ref) {
> boolean r = parent.keyType != ReferenceStrength.HARD && key ==
> ref;
> r = r || parent.valueType != ReferenceStrength.HARD && value
> == ref;
> if (r) {
> @@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap
> extends AbstractHashedMap
> protected boolean isKeyType(final ReferenceStrength type) {
> return this.keyType == type;
> }
> +
> +/**
> + * Provided protected read-only access to the value type.
> + * @param type the type to check against.
> + * @return true if valueType has the specified type
> + */
> +protected boolean isValueType(final ReferenceStrength type) {
> +return this.valueType == type;
> +}
> +
> +public boolean isPurgeValues() {
> +return purgeValues;
> +}
> }
>
>
> On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik
> wrote:
>
> > Thanks a lot for the answer,
> >
> > OpenJPA ReferenceHashMap overrides purge method to be able to call
> > custom methods keyExpired/valueExpired [1]
> > I see no way to migrate this code without massive copy/paste or
> reflection
> > ...
> >
> > Maybe you can suggest something?
> > Or maybe commons-collections API can be enhanced so this task will be
> > trivial :)
> >
> >
> >
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138
> >
> > On Mon, 3 Sep 2018 at 20:03, Julio Oliveira
> > wrote:
> > >
> > > What is realy your problem??..
> > >
> > > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik
> > wrote:
> > >
> > > > Hello,
> > > >
> > > > I'm trying to migrate code of Apache OpenJPA from commons-collections
> > > > to commons-collections4
> > > >
> > > > The only real issue so far with migrating this class
> > > >
> > > >
> >
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112
> > > >
> > > > code of commons-collections4 is more restrictive could you please
> > > > suggest how custom purge can be implemented?
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > > > -
> > > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> > > > For additional commands, e-mail: user-h...@commons.apache.org
> > > >
> > > >
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Help with migrating one of OpenJPA classes to commons-collections4
Would it be possible to modify the code of AbstractReferenceMap.java as
follows?
diff --git
a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
index 0eda632f..81f60b4b 100644
---
a/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
+++
b/src/main/java/org/apache/commons/collections4/map/AbstractReferenceMap.java
@@ -400,13 +400,15 @@ public abstract class AbstractReferenceMap
extends AbstractHashedMap
HashEntry previous = null;
HashEntry entry = data[index];
while (entry != null) {
-if (((ReferenceEntry) entry).purge(ref)) {
+ReferenceEntry refEntry = (ReferenceEntry) entry;
+if (refEntry.purge(ref)) {
if (previous == null) {
data[index] = entry.next;
} else {
previous.next = entry.next;
}
this.size--;
+refEntry.onPurge();
return;
}
previous = entry;
@@ -721,12 +723,15 @@ public abstract class AbstractReferenceMap
extends AbstractHashedMap
throw new Error();
}
+protected void onPurge() {
+}
+
/**
* Purges the specified reference
* @param ref the reference to purge
* @return true or false
*/
-boolean purge(final Reference ref) {
+protected boolean purge(final Reference ref) {
boolean r = parent.keyType != ReferenceStrength.HARD && key ==
ref;
r = r || parent.valueType != ReferenceStrength.HARD && value
== ref;
if (r) {
@@ -1073,4 +1078,17 @@ public abstract class AbstractReferenceMap
extends AbstractHashedMap
protected boolean isKeyType(final ReferenceStrength type) {
return this.keyType == type;
}
+
+/**
+ * Provided protected read-only access to the value type.
+ * @param type the type to check against.
+ * @return true if valueType has the specified type
+ */
+protected boolean isValueType(final ReferenceStrength type) {
+return this.valueType == type;
+}
+
+public boolean isPurgeValues() {
+return purgeValues;
+}
}
On Mon, 3 Sep 2018 at 20:08, Maxim Solodovnik wrote:
> Thanks a lot for the answer,
>
> OpenJPA ReferenceHashMap overrides purge method to be able to call
> custom methods keyExpired/valueExpired [1]
> I see no way to migrate this code without massive copy/paste or reflection
> ...
>
> Maybe you can suggest something?
> Or maybe commons-collections API can be enhanced so this task will be
> trivial :)
>
>
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138
>
> On Mon, 3 Sep 2018 at 20:03, Julio Oliveira
> wrote:
> >
> > What is realy your problem??..
> >
> > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik
> wrote:
> >
> > > Hello,
> > >
> > > I'm trying to migrate code of Apache OpenJPA from commons-collections
> > > to commons-collections4
> > >
> > > The only real issue so far with migrating this class
> > >
> > >
> https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112
> > >
> > > code of commons-collections4 is more restrictive could you please
> > > suggest how custom purge can be implemented?
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> > > -
> > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: user-h...@commons.apache.org
> > >
> > >
>
>
>
> --
> WBR
> Maxim aka solomax
>
--
WBR
Maxim aka solomax
Re: Help with migrating one of OpenJPA classes to commons-collections4
Thanks a lot for the answer, OpenJPA ReferenceHashMap overrides purge method to be able to call custom methods keyExpired/valueExpired [1] I see no way to migrate this code without massive copy/paste or reflection ... Maybe you can suggest something? Or maybe commons-collections API can be enhanced so this task will be trivial :) https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L138 On Mon, 3 Sep 2018 at 20:03, Julio Oliveira wrote: > > What is realy your problem??.. > > On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik wrote: > > > Hello, > > > > I'm trying to migrate code of Apache OpenJPA from commons-collections > > to commons-collections4 > > > > The only real issue so far with migrating this class > > > > https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112 > > > > code of commons-collections4 is more restrictive could you please > > suggest how custom purge can be implemented? > > > > -- > > WBR > > Maxim aka solomax > > > > - > > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > > For additional commands, e-mail: user-h...@commons.apache.org > > > > -- WBR Maxim aka solomax - To unsubscribe, e-mail: user-unsubscr...@commons.apache.org For additional commands, e-mail: user-h...@commons.apache.org
Re: Help with migrating one of OpenJPA classes to commons-collections4
What is realy your problem??.. On Sat, Sep 1, 2018, 5:46 AM Maxim Solodovnik wrote: > Hello, > > I'm trying to migrate code of Apache OpenJPA from commons-collections > to commons-collections4 > > The only real issue so far with migrating this class > > https://github.com/apache/openjpa/blob/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/util/ReferenceHashMap.java#L112 > > code of commons-collections4 is more restrictive could you please > suggest how custom purge can be implemented? > > -- > WBR > Maxim aka solomax > > - > To unsubscribe, e-mail: user-unsubscr...@commons.apache.org > For additional commands, e-mail: user-h...@commons.apache.org > >
