Re: [Neo4j] BatchInserterIndex and ValueContext[]

2011-08-29 Thread Peter Neubauer
Benjamin,


On Sun, Aug 28, 2011 at 2:23 AM, Benjamin Gehrels 
neo4j-mailingl...@gehrels.info wrote:

  great, will merge it in as soon as you send in the CLA, see
  http://wiki.neo4j.org/content/About_Contributor_License_Agreement

 pull request and CLA are crawling through the sea cables to sweden right
 now.

 thanks, merged and pushed!


  For testing, we normally use the ImpermanentGraphDatabase which does
 exactly
  this. It's not in RAM, but does the cleanup :)

 That one looks cool, maybe it's possible to move it from src/test/java
 to src/main/java so it will be included into the distribution jars and
 can be used outside the neo4j build infrastructure?

You can, since the tests are pushed as their own artifacts. Just depend on

dependency

  groupIdorg.neo4j/groupId

  artifactIdneo4j-kernel/artifactId

  version${neo4j.version}/version

  typetest-jar/type

  scopetest/scope

/dependency


And you will be able to use the goodness :)


/peter
___
Neo4j mailing list
User@lists.neo4j.org
https://lists.neo4j.org/mailman/listinfo/user


Re: [Neo4j] BatchInserterIndex and ValueContext[]

2011-08-27 Thread Peter Neubauer
Ben,
that is faulty behavior, since the Batchinseter should insert the same data
as in normal operations. Could you provide a test and maybe fix it (fork on
GIThub)? Would be awesome! Otherwise, raise an issue in
https://github.com/neo4j/community so we can get to it ASAP!

Cheers,

/peter neubauer

GTalk:  neubauer.peter
Skype   peter.neubauer
Phone   +46 704 106975
LinkedIn   http://www.linkedin.com/in/neubauer
Twitter  http://twitter.com/peterneubauer

http://www.neo4j.org   - Your high performance graph database.
http://startupbootcamp.org/- Ă–resund - Innovation happens HERE.
http://www.thoughtmade.com - Scandinavia's coolest Bring-a-Thing party.


On Sat, Aug 27, 2011 at 3:12 AM, Benjamin Gehrels 
neo4j-mailingl...@gehrels.info wrote:

 Hi folks,

 i've just - after a lot of searching - recognized, that the
 LuceneBatchInserterIndex handles ValueContext[] a little bit different
 than the normal one:

 When calling add(),  the LuceneIndex converts its Parameter to an
 Object[], and checks for each element if it is an ValueContext.

 The BatchInserterIndex checks the input parameter for beeing a
 ValueContext first, than converts it to an Object[] and indexing it
 Element by element.

 This results in a ValueContext[]{numeric(123L), numeric(456L)} being
 indexed as (123L,456L) when using the normal LuceneIndex, but
 (123,456) when using the BatchInserterIndex.

 Is this intended behaviour?

 Best regards,
 Benjamin
 ___
 Neo4j mailing list
 User@lists.neo4j.org
 https://lists.neo4j.org/mailman/listinfo/user

___
Neo4j mailing list
User@lists.neo4j.org
https://lists.neo4j.org/mailman/listinfo/user


Re: [Neo4j] BatchInserterIndex and ValueContext[]

2011-08-27 Thread Benjamin Gehrels
Hi Peter,

  Could you provide a test and maybe fix it (fork on
  GIThub)? Would be awesome!

No problem, I'll send you a pull request tonight.

I still have one question that already had come to my mind while testing 
my own app: Have you ever thought of implementing a GraphDatabaseService 
backed by a main memory store? This could be really usefull for unit 
testing, so you don't have to do things like cleaning up your 
environment after each test. Just shut down the graph database service 
and everyting is in a well defined, clean state again.

Best regards,
Benjamin
___
Neo4j mailing list
User@lists.neo4j.org
https://lists.neo4j.org/mailman/listinfo/user


Re: [Neo4j] BatchInserterIndex and ValueContext[]

2011-08-27 Thread Peter Neubauer
Ben,
great, will merge it in as soon as you send in the CLA, see
http://wiki.neo4j.org/content/About_Contributor_License_Agreement

For testing, we normally use the ImpermanentGraphDatabase which does exactly
this. It's not in RAM, but does the cleanup :)

/peter

On Sun, Aug 28, 2011 at 12:51 AM, Benjamin Gehrels 
neo4j-mailingl...@gehrels.info wrote:

 Hi Peter,

   Could you provide a test and maybe fix it (fork on
   GIThub)? Would be awesome!

 No problem, I'll send you a pull request tonight.

 I still have one question that already had come to my mind while testing
 my own app: Have you ever thought of implementing a GraphDatabaseService
 backed by a main memory store? This could be really usefull for unit
 testing, so you don't have to do things like cleaning up your
 environment after each test. Just shut down the graph database service
 and everyting is in a well defined, clean state again.

 Best regards,
 Benjamin
 ___
 Neo4j mailing list
 User@lists.neo4j.org
 https://lists.neo4j.org/mailman/listinfo/user

___
Neo4j mailing list
User@lists.neo4j.org
https://lists.neo4j.org/mailman/listinfo/user


Re: [Neo4j] BatchInserterIndex and ValueContext[]

2011-08-27 Thread Benjamin Gehrels
 great, will merge it in as soon as you send in the CLA, see
 http://wiki.neo4j.org/content/About_Contributor_License_Agreement

pull request and CLA are crawling through the sea cables to sweden right 
now.

 For testing, we normally use the ImpermanentGraphDatabase which does exactly
 this. It's not in RAM, but does the cleanup :)

That one looks cool, maybe it's possible to move it from src/test/java 
to src/main/java so it will be included into the distribution jars and 
can be used outside the neo4j build infrastructure?
___
Neo4j mailing list
User@lists.neo4j.org
https://lists.neo4j.org/mailman/listinfo/user