Re: [uml-devel] [PATCH] UML - support checkstack
On Wed, 9 August 2006 14:15:24 -0400, Jeff Dike wrote: > > Make checkstack work for UML. We need to pass the underlying architecture > name, rather than "um" to checkstack.pl. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> Acked-by: Joern Engel <[EMAIL PROTECTED]> Jörn -- Geld macht nicht glücklich. Glück macht nicht satt. - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
[uml-devel] UML hostfs bugs
Hi all,
There is a bug with UML kernel, some host directory can not be read, for example "ls /mnt/host/usr/lib", this command is dead until you press CTRL+c. I test it with Redhat Enterprise Linux 4.
This is because the UML read host directory through opendir, seekdir, readdir and telldir. When get the dir stream offset through telldir, it always return 0 on some directory, for example".", I don't know why? But we can fix it as follows although the next dir entry offset is not exact:
Modify the fs/hostfs/hostfs_user.c file, update the read_dir function,
char *read_dir(void *stream, unsigned long long *pos, unsigned long long *ino_out, int *len_out){ DIR *dir = stream; struct dirent *ent;
unsigned long long oldpos;
oldpos = *pos;
seekdir(dir, *pos); ent = readdir(dir); if(ent == NULL) { return(NULL); } *len_out = strlen(ent->d_name);
*ino_out = ent->d_ino; *pos = telldir(dir);
/* Fix the telldir return 0 error */ if (*pos == 0) *pos = oldpos + *len_out;
return(ent->d_name);}
although the next offset is not exact, but the readdir can get the next entry correct.
Can anyone give a better solution?
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642___
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Re: [uml-devel] [PATCH] UML - support checkstack
On Thu, Aug 10, 2006 at 12:22:16AM -0400, Jeff Dike wrote: > On Wed, Aug 09, 2006 at 09:09:22PM -0500, Matt Mackall wrote: > > On Wed, Aug 09, 2006 at 02:15:24PM -0400, Jeff Dike wrote: > > > Make checkstack work for UML. We need to pass the underlying architecture > > > name, rather than "um" to checkstack.pl. > > > > Does this do the right thing with something like Voyager? > > SUBARCH has a different meaning here. For UML, it's the underlying, > host, architecture, not a variant architecture like Voyager. Right, so it sounds like this breaks Voyager. Which I think means we ought to pass ARCH and SUBARCH and do the right thing inside checkstack. -- Mathematics is the supreme nostalgia of our time. - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
