Re: Request to be added to kafka contributors list
It's working now. Thank you Matthias! From: Matthias J. Sax Sent: Wednesday, May 22, 2024 2:58 To: users@kafka.apache.org Subject: Re: Request to be added to kafka contributors list Ok. Hopefully it's working now. Sorry for the hiccup. -Matthias On 5/21/24 1:14 AM, Fan Yang wrote: > Hi Matthia, > > I tried sign out and sign in, still can't find the "Assign" button, my JIRA > ID is fanyan, could you help me set it again? > > Best, > Fan > > > From: Matthias J. Sax > Sent: Saturday, May 18, 2024 4:06 > To: users@kafka.apache.org > Subject: Re: 回复: Request to be added to kafka contributors list > > Did you sign out and sign in again? > > On 5/17/24 9:49 AM, Yang Fan wrote: >> Thanks Matthias, >> >> I still can't find "Assign to me" button beside Assignee and Reporter. Could >> you help me set it again? >> >> Best regards, >> Fan >> ____________ >> 发件人: Matthias J. Sax >> 发送时间: 2024年5月17日 2:24 >> 收件人: users@kafka.apache.org >> 主题: Re: Request to be added to kafka contributors list >> >> Thanks for reaching out Yang. You should be all set. >> >> -Matthias >> >> On 5/16/24 7:40 AM, Yang Fan wrote: >>> Dear Apache Kafka Team, >>> >>> I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I >>> kindly request to be added to the contributors list for Apache Kafka. Being >>> part of this list would allow me to be assigned to JIRA tickets and work on >>> them. >>> Thank you for considering my request. >>> Best regards, >>> Fan
Re: Fwd: Request to be added to kafka contributors list
Hello, 1/ for sure 2/ after rebasing my code change, I'll do the full test. To answer to the question I'm under Debian 12, OpenJDK 17.0.10 on my dev machine. Best regards Le 2024-05-21 16:46, Greg Harris a écrit : Hi Franck, Thank you for contributing to Apache Kafka! 1. Git is generally permissive of this, as long as there are no merge conflicts. If you have merge conflicts with `trunk`, you will need to resolve them before a committer can merge your changes, so rebasing on trunk before opening the PR is a good idea :) 2. Are you on an M1 mac, with a recent (>11) JDK? I've been experiencing some consistent failures recently [1] and haven't figured it out yet. You may also be getting a flaky failure: a test which is nondeterministic and sometimes fails. We are constantly trying to burn down the list of flaky tests [2], but there are still some around. As far as how this impacts the PR: You should find and resolve all of the deterministic failures that you introduce in the PR, and do your best to check whether you introduced any flakiness. You can look for tickets mentioning those failures, or ask a committer for more information. Hope this helps, Greg Harris [1] https://issues.apache.org/jira/browse/KAFKA-16701 [2] https://issues.apache.org/jira/browse/KAFKA-16701?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20flaky-test On Tue, May 21, 2024 at 6:43 AM Franck wrote: Hello, It works like a charm. Few questions: 1. Now, I'm asking my self, I did the job describe in JIRA 16707 in a fork/branch of the 3.7.0 of kafka, but reading the "Contributing Code Change", I feeI should have done it on a branch from trunk of my fork? (if so, I'll just do on my fork a new branch, rebase, and re-run test for sure, I just want to from which point I should start to PR correctly) 2. when doing a "gradelew clean test" from a clean fork of the 3.7.0 branch, I have a failure, so I'm asking my self how it will be managed when I'll do the PR, do you know? Best regards On 21/05/2024 03:35, Matthias J. Sax wrote: > Done. You should be all set :) > > > -Matthias > > On 5/20/24 10:10 AM, bou...@ulukai.net wrote: >> >> Dear Apache Kafka Team, >> >> I hope to post in the right place: my name is Franck LEDAY, >> under Apache-Jira ID "handfreezer". >> >> I opened an issue as Improvement KAFKA-16707 but I failed to >> assigned it to me. >> >> May I ask to be added to the contributors list for Apache Kafka? >> As I already did the job of improvement, and would like to be >> assigned on to end my contribution. >> >> Thank you for considering my request. >> Best regards, Franck.
Re: Request to be added to kafka contributors list
Ok. Hopefully it's working now. Sorry for the hiccup. -Matthias On 5/21/24 1:14 AM, Fan Yang wrote: Hi Matthia, I tried sign out and sign in, still can't find the "Assign" button, my JIRA ID is fanyan, could you help me set it again? Best, Fan From: Matthias J. Sax Sent: Saturday, May 18, 2024 4:06 To: users@kafka.apache.org Subject: Re: 回复: Request to be added to kafka contributors list Did you sign out and sign in again? On 5/17/24 9:49 AM, Yang Fan wrote: Thanks Matthias, I still can't find "Assign to me" button beside Assignee and Reporter. Could you help me set it again? Best regards, Fan 发件人: Matthias J. Sax 发送时间: 2024年5月17日 2:24 收件人: users@kafka.apache.org 主题: Re: Request to be added to kafka contributors list Thanks for reaching out Yang. You should be all set. -Matthias On 5/16/24 7:40 AM, Yang Fan wrote: Dear Apache Kafka Team, I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I kindly request to be added to the contributors list for Apache Kafka. Being part of this list would allow me to be assigned to JIRA tickets and work on them. Thank you for considering my request. Best regards, Fan
Re: Fwd: Request to be added to kafka contributors list
Hi Franck, Thank you for contributing to Apache Kafka! 1. Git is generally permissive of this, as long as there are no merge conflicts. If you have merge conflicts with `trunk`, you will need to resolve them before a committer can merge your changes, so rebasing on trunk before opening the PR is a good idea :) 2. Are you on an M1 mac, with a recent (>11) JDK? I've been experiencing some consistent failures recently [1] and haven't figured it out yet. You may also be getting a flaky failure: a test which is nondeterministic and sometimes fails. We are constantly trying to burn down the list of flaky tests [2], but there are still some around. As far as how this impacts the PR: You should find and resolve all of the deterministic failures that you introduce in the PR, and do your best to check whether you introduced any flakiness. You can look for tickets mentioning those failures, or ask a committer for more information. Hope this helps, Greg Harris [1] https://issues.apache.org/jira/browse/KAFKA-16701 [2] https://issues.apache.org/jira/browse/KAFKA-16701?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20flaky-test On Tue, May 21, 2024 at 6:43 AM Franck wrote: > > Hello, > > It works like a charm. > > Few questions: > > 1. Now, I'm asking my self, I did the job describe in JIRA 16707 in a > fork/branch of the 3.7.0 of kafka, but reading the "Contributing > Code Change", I feeI should have done it on a branch from trunk of > my fork? (if so, I'll just do on my fork a new branch, rebase, and > re-run test for sure, I just want to from which point I should start > to PR correctly) > 2. when doing a "gradelew clean test" from a clean fork of the 3.7.0 > branch, I have a failure, so I'm asking my self how it will be > managed when I'll do the PR, do you know? > > Best regards > > On 21/05/2024 03:35, Matthias J. Sax wrote: > > Done. You should be all set :) > > > > > > -Matthias > > > > On 5/20/24 10:10 AM, bou...@ulukai.net wrote: > >> > >> Dear Apache Kafka Team, > >> > >> I hope to post in the right place: my name is Franck LEDAY, > >> under Apache-Jira ID "handfreezer". > >> > >> I opened an issue as Improvement KAFKA-16707 but I failed to > >> assigned it to me. > >> > >> May I ask to be added to the contributors list for Apache Kafka? > >> As I already did the job of improvement, and would like to be > >> assigned on to end my contribution. > >> > >> Thank you for considering my request. > >> Best regards, Franck.
Request to be added to kafka contributors list
Dear Apache Kafka Team, I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer". I opened an issue as Improvement KAFKA-16707 but I failed to assigned it to me. May I ask to be added to the contributors list for Apache Kafka? As I already did the job of improvement, and would like to be assigned on to end my contribution. Thank you for considering my request. Best regards, Franck.
Re: Fwd: Request to be added to kafka contributors list
Hello, It works like a charm. Few questions: 1. Now, I'm asking my self, I did the job describe in JIRA 16707 in a fork/branch of the 3.7.0 of kafka, but reading the "Contributing Code Change", I feeI should have done it on a branch from trunk of my fork? (if so, I'll just do on my fork a new branch, rebase, and re-run test for sure, I just want to from which point I should start to PR correctly) 2. when doing a "gradelew clean test" from a clean fork of the 3.7.0 branch, I have a failure, so I'm asking my self how it will be managed when I'll do the PR, do you know? Best regards On 21/05/2024 03:35, Matthias J. Sax wrote: Done. You should be all set :) -Matthias On 5/20/24 10:10 AM, bou...@ulukai.net wrote: Dear Apache Kafka Team, I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer". I opened an issue as Improvement KAFKA-16707 but I failed to assigned it to me. May I ask to be added to the contributors list for Apache Kafka? As I already did the job of improvement, and would like to be assigned on to end my contribution. Thank you for considering my request. Best regards, Franck.
Re: Request to be added to kafka contributors list
Hi Matthia, I tried sign out and sign in, still can't find the "Assign" button, my JIRA ID is fanyan, could you help me set it again? Best, Fan From: Matthias J. Sax Sent: Saturday, May 18, 2024 4:06 To: users@kafka.apache.org Subject: Re: 回复: Request to be added to kafka contributors list Did you sign out and sign in again? On 5/17/24 9:49 AM, Yang Fan wrote: > Thanks Matthias, > > I still can't find "Assign to me" button beside Assignee and Reporter. Could > you help me set it again? > > Best regards, > Fan > > 发件人: Matthias J. Sax > 发送时间: 2024年5月17日 2:24 > 收件人: users@kafka.apache.org > 主题: Re: Request to be added to kafka contributors list > > Thanks for reaching out Yang. You should be all set. > > -Matthias > > On 5/16/24 7:40 AM, Yang Fan wrote: >> Dear Apache Kafka Team, >> >> I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I >> kindly request to be added to the contributors list for Apache Kafka. Being >> part of this list would allow me to be assigned to JIRA tickets and work on >> them. >> Thank you for considering my request. >> Best regards, >> Fan
Re: Fwd: Request to be added to kafka contributors list
Done. You should be all set :) -Matthias On 5/20/24 10:10 AM, bou...@ulukai.net wrote: Dear Apache Kafka Team, I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer". I opened an issue as Improvement KAFKA-16707 but I failed to assigned it to me. May I ask to be added to the contributors list for Apache Kafka? As I already did the job of improvement, and would like to be assigned on to end my contribution. Thank you for considering my request. Best regards, Franck.
Fwd: Request to be added to kafka contributors list
Dear Apache Kafka Team, I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer". I opened an issue as Improvement KAFKA-16707 but I failed to assigned it to me. May I ask to be added to the contributors list for Apache Kafka? As I already did the job of improvement, and would like to be assigned on to end my contribution. Thank you for considering my request. Best regards, Franck.
Re: 回复: Request to be added to kafka contributors list
Did you sign out and sign in again? On 5/17/24 9:49 AM, Yang Fan wrote: Thanks Matthias, I still can't find "Assign to me" button beside Assignee and Reporter. Could you help me set it again? Best regards, Fan 发件人: Matthias J. Sax 发送时间: 2024年5月17日 2:24 收件人: users@kafka.apache.org 主题: Re: Request to be added to kafka contributors list Thanks for reaching out Yang. You should be all set. -Matthias On 5/16/24 7:40 AM, Yang Fan wrote: Dear Apache Kafka Team, I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I kindly request to be added to the contributors list for Apache Kafka. Being part of this list would allow me to be assigned to JIRA tickets and work on them. Thank you for considering my request. Best regards, Fan
回复: Request to be added to kafka contributors list
Thanks Matthias, I still can't find "Assign to me" button beside Assignee and Reporter. Could you help me set it again? Best regards, Fan 发件人: Matthias J. Sax 发送时间: 2024年5月17日 2:24 收件人: users@kafka.apache.org 主题: Re: Request to be added to kafka contributors list Thanks for reaching out Yang. You should be all set. -Matthias On 5/16/24 7:40 AM, Yang Fan wrote: > Dear Apache Kafka Team, > > I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I > kindly request to be added to the contributors list for Apache Kafka. Being > part of this list would allow me to be assigned to JIRA tickets and work on > them. > Thank you for considering my request. > Best regards, > Fan
Re: Request to be added to kafka contributors list
Thanks for reaching out Yang. You should be all set. -Matthias On 5/16/24 7:40 AM, Yang Fan wrote: Dear Apache Kafka Team, I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I kindly request to be added to the contributors list for Apache Kafka. Being part of this list would allow me to be assigned to JIRA tickets and work on them. Thank you for considering my request. Best regards, Fan
Request to be added to kafka contributors list
Dear Apache Kafka Team, I hope this email finds you well. My name is Fan Yang, JIRA ID is fanyan, I kindly request to be added to the contributors list for Apache Kafka. Being part of this list would allow me to be assigned to JIRA tickets and work on them. Thank you for considering my request. Best regards, Fan
