Re: [VOTE] Release Qpid JMS 0.1.0

2015-03-18 Thread Robbie Gemmell
On 17 March 2015 at 16:56, Gordon Sim g...@redhat.com wrote:
 On 03/16/2015 07:53 PM, Robbie Gemmell wrote:

 Hi all,

 We have reached a point that it would be useful to do an initial
 release of the new Proton-based JMS client, so I have put up an RC for
 folks to test and vote on.

 The source and binary archives can be grabbed from here:
 https://dist.apache.org/repos/dist/dev/qpid/jms/0.1.0-rc1/

 Those and the other individual maven artifacts are also staged for now at:
 https://repository.apache.org/content/repositories/orgapacheqpid-1030

 I will close the vote some point towards the end of the week. I'll be
 off on vacation by then so the exact timing is a little fuzzy but it
 will be after 72hrs are up, i.e after 8pm GMT on Thursday 19th.


 The binary tarball includes a netty jar, but I didn't see any mention of
 that in the notice? There is a mention in the license file of slf4j, but
 again not for netty. Although it is also Apache licensed, shouldn't there be
 some explicit note of it?

 For the source tarball, I got some test errors[1]. Not sure if this was just
 something I was missing (e.g. starting up some other broker). Not a
 show-stopper either.

 Ran the hello world example successfully against the 0.32 qpidd.

 Just to mention it, though not a blocker by any means, following the readme
 for the examples in the binary tarball doesn't work.


I just randomly recalled you had mentioned this and realised I forgot
to answer it.

Short answer, that is a side effect of the release process and is
expected behaviour based on how the examples are structured and how
maven works in general. I tried to convey this somewhat in the README
but obviously not clearly enough, ill see if I can reword it for
clarity.

Longer answer, the poms are looking for dependencies with a release
version 0.1.0, which as they havent been released dont yet exist in
any of the remote repositories the poms enable maven to access (i.e,
maven central by default and the apache snapshots repo if the parent
poms are also available - which they obviously are in the source
release, but arent for the binary archive unless retrievable from a
remote repo, such as central). As a result of this, during the release
process the instructions in the README for the binary tar will only
work if you first 'mvn install' the source release to make the
necessary dependencies available (via the local repo), or modify the
pom to provide the repository info for the temporary staging repo
(details included in the vote email for that reason).

As soon as the artifacts are actually released and sync to central
then the instructions in the binary tar will work without needing a
local install or modified pom, with maven then being able to grab the
needed dependencies from central.

 [1] test errors:

 Running org.apache.qpid.jms.discovery.JmsAmqpDiscoveryTest
 Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 241.219
 sec  FAILURE! - in org.apache.qpid.jms.discovery.JmsAmqpDiscoveryTest

 testDiscoversAndReconnectsToSecondaryBroker(org.apache.qpid.jms.discovery.JmsAmqpDiscoveryTest)
 Time elapsed: 60.303 sec   ERROR!
 org.junit.runners.model.TestTimedOutException: test timed out after 6
 milliseconds
 at sun.misc.Unsafe.park(Native Method)
 at
 java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
 at
 java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
 at
 java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:994)
 at
 java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1303)
 at
 java.util.concurrent.CountDownLatch.await(CountDownLatch.java:236)
 at
 org.apache.qpid.jms.provider.ProviderFuture.sync(ProviderFuture.java:86)
 at
 org.apache.qpid.jms.JmsConnection.createResource(JmsConnection.java:616)
 at
 org.apache.qpid.jms.JmsConnection.connect(JmsConnection.java:525)
 at org.apache.qpid.jms.JmsConnection.start(JmsConnection.java:318)
 at
 org.apache.qpid.jms.discovery.JmsAmqpDiscoveryTest.testDiscoversAndReconnectsToSecondaryBroker(JmsAmqpDiscoveryTest.java:116)


 testConnectionRestoresAfterBrokerRestarted(org.apache.qpid.jms.discovery.JmsAmqpDiscoveryTest)
 Time elapsed: 60.23 sec   ERROR!
 org.junit.runners.model.TestTimedOutException: test timed out after 6
 milliseconds
 at sun.misc.Unsafe.park(Native Method)
 at
 java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
 at
 java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
 at
 java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:994)
 at
 

Re: [VOTE] Release Qpid JMS 0.1.0

2015-03-17 Thread Gordon Sim

On 03/17/2015 05:21 PM, Robbie Gemmell wrote:

On 17 March 2015 at 16:56, Gordon Sim g...@redhat.com wrote:

On 03/16/2015 07:53 PM, Robbie Gemmell wrote:


Hi all,

We have reached a point that it would be useful to do an initial
release of the new Proton-based JMS client, so I have put up an RC for
folks to test and vote on.

The source and binary archives can be grabbed from here:
https://dist.apache.org/repos/dist/dev/qpid/jms/0.1.0-rc1/

Those and the other individual maven artifacts are also staged for now at:
https://repository.apache.org/content/repositories/orgapacheqpid-1030

I will close the vote some point towards the end of the week. I'll be
off on vacation by then so the exact timing is a little fuzzy but it
will be after 72hrs are up, i.e after 8pm GMT on Thursday 19th.



The binary tarball includes a netty jar, but I didn't see any mention of
that in the notice? There is a mention in the license file of slf4j, but
again not for netty. Although it is also Apache licensed, shouldn't there be
some explicit note of it?


Dependencies that are Apache licensed dont need mentioned in the
licence file, only really those that aren't Apache licensed, such as
SLF4J. For the notice file, we didnt include anything for netty as the
jar doesnt incorporate any notices. Doing a quick search of
apache.org, I didn't see any other projects using it having entries in
notice for it.


Ok, +1 from me on the release then.


-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org



Re: [VOTE] Release Qpid JMS 0.1.0

2015-03-16 Thread Timothy Bish

+1

* Verified the signatures matched
* Built source bundle and ran tests
* Tested ActiveMQ using staged jars
* Checked that all artefacts have proper license and notice files included.

On 03/16/2015 03:53 PM, Robbie Gemmell wrote:

Hi all,

We have reached a point that it would be useful to do an initial
release of the new Proton-based JMS client, so I have put up an RC for
folks to test and vote on.

The source and binary archives can be grabbed from here:
https://dist.apache.org/repos/dist/dev/qpid/jms/0.1.0-rc1/

Those and the other individual maven artifacts are also staged for now at:
https://repository.apache.org/content/repositories/orgapacheqpid-1030

I will close the vote some point towards the end of the week. I'll be
off on vacation by then so the exact timing is a little fuzzy but it
will be after 72hrs are up, i.e after 8pm GMT on Thursday 19th.

Regards,
Robbie


P.S. If you want to test it out from the staging repo (e.g using the
examples src, or your own things), add this to your poms:
   repositories
 repository
   idstaging/id
   
urlhttps://repository.apache.org/content/repositories/orgapacheqpid-1030/url
 /repository
   /repositories

The dependency for the client itself would then be:
   dependency
 groupIdorg.apache.qpid/groupId
 artifactIdqpid-jms-client/artifactId
 version0.1.0/version
   /dependency

-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org





--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com
skype: tabish121 | twitter: @tabish121
blog: http://timbish.blogspot.com/


-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org



Re: [VOTE] Release Qpid JMS 0.1.0

2015-03-16 Thread Robbie Gemmell
Adding my +1

I tested as follows:
- Checked license/notice files present.
- Verified sigs and checksums match.
- Built from the src, ran the tests.
- Ran the HelloWorld example against the 0.32 RC2 C++ and Java brokers
using the output from the src build.
- Cleared my local repo, built+ran the HelloWorld example again using
the remote maven staging repo (with a modified pom).

Robbie

On 16 March 2015 at 19:53, Robbie Gemmell robbie.gemm...@gmail.com wrote:
 Hi all,

 We have reached a point that it would be useful to do an initial
 release of the new Proton-based JMS client, so I have put up an RC for
 folks to test and vote on.

 The source and binary archives can be grabbed from here:
 https://dist.apache.org/repos/dist/dev/qpid/jms/0.1.0-rc1/

 Those and the other individual maven artifacts are also staged for now at:
 https://repository.apache.org/content/repositories/orgapacheqpid-1030

 I will close the vote some point towards the end of the week. I'll be
 off on vacation by then so the exact timing is a little fuzzy but it
 will be after 72hrs are up, i.e after 8pm GMT on Thursday 19th.

 Regards,
 Robbie


 P.S. If you want to test it out from the staging repo (e.g using the
 examples src, or your own things), add this to your poms:
   repositories
 repository
   idstaging/id
   
 urlhttps://repository.apache.org/content/repositories/orgapacheqpid-1030/url
 /repository
   /repositories

 The dependency for the client itself would then be:
   dependency
 groupIdorg.apache.qpid/groupId
 artifactIdqpid-jms-client/artifactId
 version0.1.0/version
   /dependency

-
To unsubscribe, e-mail: users-unsubscr...@qpid.apache.org
For additional commands, e-mail: users-h...@qpid.apache.org