Re: Wicket 1.4.14 and WiQuery Tabs
This is from another thread but it sounds like the devs have found the problem (and a fix). I'm hopeful anyway! http://apache-wicket.1842946.n4.nabble.com/Re-svn-commit-r1031432-wicket-branches-wicket-1-4-x-wicket-src-main-java-org-apache-wicket-ajax-Ajaxa-tt3067178.html - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
I managed to get wiquery 1.1.1 working (under 1.4.12). Unfortunately I'm still getting inconsistent behavior with Wicket 1.4.14. I'm looking at the diffs to try and find the culprit...not sure how else to pin this down. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
On Nov 30, 2010, at 12:30 PM, Brad Grier wrote: not sure how else to pin this down. If it were me, I would diff the generated HTML, then narrow down which component(s) is/are causing the headache, THEN diff changes in those components. As well because it's a great way to learn more about the code in the process instead of just being numbed by the volume of changes... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
When I look at a diff from the ajax debug window between the failed 1.4.14 request and the 1.4.12, it's obvious the wiquery javascript resources aren't being contributed in the error scenarios. Any thoughts on where to look in Wicket to see why these contributions are failing? -Original Message- From: Brian Topping Sent: Tuesday, November 30, 2010 11:54 AM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 30, 2010, at 12:30 PM, Brad Grier wrote: not sure how else to pin this down. If it were me, I would diff the generated HTML, then narrow down which component(s) is/are causing the headache, THEN diff changes in those components. As well because it's a great way to learn more about the code in the process instead of just being numbed by the volume of changes... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Maybe find the contributions in the source tree, look for references in the code to that filename. Set a breakpoint on the code that normally contributes it, run the old code that works. When you hit the breakpoint, set more breakpoints a reasonably relevant distance back up the call chain (the caller, the caller's caller, etc). Now run it with the broken code and the breakpoints in the same places and see what decisions are being made differently, why the call chain never makes it as deep as the working configuration. You can do all this statically (i.e. with find usages searches), but the use of interfaces with multiple implementations can obscure the food chain unless you really know what to look for. On Nov 30, 2010, at 5:49 PM, Brad Grier wrote: When I look at a diff from the ajax debug window between the failed 1.4.14 request and the 1.4.12, it's obvious the wiquery javascript resources aren't being contributed in the error scenarios. Any thoughts on where to look in Wicket to see why these contributions are failing? -Original Message- From: Brian Topping Sent: Tuesday, November 30, 2010 11:54 AM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 30, 2010, at 12:30 PM, Brad Grier wrote: not sure how else to pin this down. If it were me, I would diff the generated HTML, then narrow down which component(s) is/are causing the headache, THEN diff changes in those components. As well because it's a great way to learn more about the code in the process instead of just being numbed by the volume of changes... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
I actually did a bit of what you described. I found where wiquery contributes the js files. I was hoping it would be as simple as some evaluation preventing that call in 1.4.14. Of course not. The contribution from wiquery happens regardless. I even stepped forward to the point where renderJavascriptReference is called on IHeaderResponse...happens regardless. After that I was in Wicket code and it became difficult to know what was happening. I wonder if there's some place in my code where I could save a stack trace and then just compare the working and non-working method calls. If they were different, I'd know where to look. Unfortunately I'm not sure how to create a quickstart when this problem seems to reveal itself in the way we're dynamically creating our pages. The quickstart would likely end up being not-so-quick. I'll look at it a bit more before giving up and hoping someone else will report the bug in an (easily) reproducible way. Thanks for all the help. -Original Message- From: Brian Topping Sent: Tuesday, November 30, 2010 5:02 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs Maybe find the contributions in the source tree, look for references in the code to that filename. Set a breakpoint on the code that normally contributes it, run the old code that works. When you hit the breakpoint, set more breakpoints a reasonably relevant distance back up the call chain (the caller, the caller's caller, etc). Now run it with the broken code and the breakpoints in the same places and see what decisions are being made differently, why the call chain never makes it as deep as the working configuration. You can do all this statically (i.e. with find usages searches), but the use of interfaces with multiple implementations can obscure the food chain unless you really know what to look for. On Nov 30, 2010, at 5:49 PM, Brad Grier wrote: When I look at a diff from the ajax debug window between the failed 1.4.14 request and the 1.4.12, it's obvious the wiquery javascript resources aren't being contributed in the error scenarios. Any thoughts on where to look in Wicket to see why these contributions are failing? -Original Message- From: Brian Topping Sent: Tuesday, November 30, 2010 11:54 AM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 30, 2010, at 12:30 PM, Brad Grier wrote: not sure how else to pin this down. If it were me, I would diff the generated HTML, then narrow down which component(s) is/are causing the headache, THEN diff changes in those components. As well because it's a great way to learn more about the code in the process instead of just being numbed by the volume of changes... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
On Nov 29, 2010, at 12:04 PM, Brad Grier wrote: After 1.4.14 wiquery tab components no longer render in my application. These tabs are sitting on panels displayed via ajax so perhaps it’s something to do with the css/javascript contribution. Interestingly the wiquery accordions still work fine. Since I was due to upgrade this as well and am using both wiquery accordions and tabs, I thought I would give it a try. My tabs are on panels that are triggered by selections in the accordions (hey, are we working on the same source tree? ;-)). But I'm unable to replicate this, everything is rendering fine. If I can assist by checking any specific rendering or you want a snippet of the HTML that's being generated on my end to help you debug, feel free to contact me off-list. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Hey thanks for trying it. My tabs are on panels that get swapped in and out via ajax. Are you using this approach? Since our app creates these tabs dynamically via ListViews, I thought maybe it was my implementation. As a test I took the most basic tab example from the wiQuery site and put it on a panel displayed via ajax when a link is clicked. It's not working either. If I go back to 1.4.12, it works fine. I'll poke around a little with Firebug but I'm guessing the css and perhaps javascript aren't being contributed in my scenario. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 12:27 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 29, 2010, at 12:04 PM, Brad Grier wrote: After 1.4.14 wiquery tab components no longer render in my application. These tabs are sitting on panels displayed via ajax so perhaps it’s something to do with the css/javascript contribution. Interestingly the wiquery accordions still work fine. Since I was due to upgrade this as well and am using both wiquery accordions and tabs, I thought I would give it a try. My tabs are on panels that are triggered by selections in the accordions (hey, are we working on the same source tree? ;-)). But I'm unable to replicate this, everything is rendering fine. If I can assist by checking any specific rendering or you want a snippet of the HTML that's being generated on my end to help you debug, feel free to contact me off-list. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Hopefully that's relatively future-proof... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
On Nov 29, 2010, at 3:02 PM, Brian Topping wrote: On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Erm, that should have been what I use in my onClick()... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Okay, well...it's more than a contribution problem. It looks like the tab's associated div, ul and li tags do not get modified by wiquery in 1.4.14. WiQuery assigns classes to these tags (ui-tabs, ui-tabs-nav, ui-state-default, etc). Those are all missing when I run in Wicket 1.4.14. Since it works fine for you, I'm not sure where to look. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 2:04 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 29, 2010, at 3:02 PM, Brian Topping wrote: On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Erm, that should have been what I use in my onClick()... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Hi all, Can you try tabs with the last release of wiquery ? (the 1.1.1). A lot of changes and refactoring were don into the core. Maybe that will solved your problems. Can you give me your feedbacks please . Thank you Regards Julien Roche On Mon, Nov 29, 2010 at 9:33 PM, Brad Grier brad.gr...@salusnovus.comwrote: Okay, well...it's more than a contribution problem. It looks like the tab's associated div, ul and li tags do not get modified by wiquery in 1.4.14. WiQuery assigns classes to these tags (ui-tabs, ui-tabs-nav, ui-state-default, etc). Those are all missing when I run in Wicket 1.4.14. Since it works fine for you, I'm not sure where to look. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 2:04 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 29, 2010, at 3:02 PM, Brian Topping wrote: On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Erm, that should have been what I use in my onClick()... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Ah, great point. I am already using 1.1.1! On Nov 29, 2010, at 4:34 PM, julien roche AKA indiana_jules wrote: Hi all, Can you try tabs with the last release of wiquery ? (the 1.1.1). A lot of changes and refactoring were don into the core. Maybe that will solved your problems. Can you give me your feedbacks please . Thank you Regards Julien Roche On Mon, Nov 29, 2010 at 9:33 PM, Brad Grier brad.gr...@salusnovus.comwrote: Okay, well...it's more than a contribution problem. It looks like the tab's associated div, ul and li tags do not get modified by wiquery in 1.4.14. WiQuery assigns classes to these tags (ui-tabs, ui-tabs-nav, ui-state-default, etc). Those are all missing when I run in Wicket 1.4.14. Since it works fine for you, I'm not sure where to look. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 2:04 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 29, 2010, at 3:02 PM, Brian Topping wrote: On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Erm, that should have been what I use in my onClick()... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 1.4.14 and WiQuery Tabs
Sadly, none of my wiquery components seem to work under 1.1.1. Previously, I had to disable auto-import of jquery resources because I was having conflicts with other jquery-based components (jgrowl, custom stuff). Maybe that's why. I assume 1.1.1 is backwards compatible and setup is the same? Anyway, tabs do work in *certain* places using 1.03. A panel with a broken tab will work if placed on a different page/panel. (In other words, if I use the app's cms interface to position the panel somewhere else). Once tabs start working, they work everywhere in the application until logout. I can't figure out what's different between the working and non-working instances of the same panel. It's odd. I suppose I need to debug into wiquery and/or wicket. If I switch to 1.4.12, no problems at all. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 3:48 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs Ah, great point. I am already using 1.1.1! On Nov 29, 2010, at 4:34 PM, julien roche AKA indiana_jules wrote: Hi all, Can you try tabs with the last release of wiquery ? (the 1.1.1). A lot of changes and refactoring were don into the core. Maybe that will solved your problems. Can you give me your feedbacks please . Thank you Regards Julien Roche On Mon, Nov 29, 2010 at 9:33 PM, Brad Grier brad.gr...@salusnovus.comwrote: Okay, well...it's more than a contribution problem. It looks like the tab's associated div, ul and li tags do not get modified by wiquery in 1.4.14. WiQuery assigns classes to these tags (ui-tabs, ui-tabs-nav, ui-state-default, etc). Those are all missing when I run in Wicket 1.4.14. Since it works fine for you, I'm not sure where to look. -Original Message- From: Brian Topping Sent: Monday, November 29, 2010 2:04 PM To: users@wicket.apache.org Subject: Re: Wicket 1.4.14 and WiQuery Tabs On Nov 29, 2010, at 3:02 PM, Brian Topping wrote: On Nov 29, 2010, at 2:39 PM, Brad Grier wrote: My tabs are on panels that get swapped in and out via ajax. Are you using this approach? They are ajax, but I haven't bothered looking at how it works. Here's what I use in populateItem(): mainContentPanel = cp.loadComponentInstance(mainContentPanel); mainContentPanel.setOutputMarkupId(true); AdminPage.this.replace(mainContentPanel); target.addComponent(mainContentPanel); Erm, that should have been what I use in my onClick()... - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
