RE: master branch compiler error in core?
Just pushed a hack that solves the problem. Pull and try again. Yah! That works. It's a pity clirr's file separator agnostic solution is so verbose heh! Given that it is Java based I hoped clirr could have used package style separators i.e. the period '.' but they don't work with it. On Mon, Dec 3, 2012 at 1:47 AM, Chris Colman chr...@stepaheadsoftware.comwrote: Bingo! - it's the difference between *nix and Windows. When I change the forward slashes to backslashes in the clirr ignored section's className element it works - for Windows at least!! There's a good chance that backslashes will probably break for *nix but even though I have a machine with Linux available I don't have any build environments set up on it yet. ignored difference classNameorg\apache\wicket\feedback\FeedbackCollector/className method*/method differenceType7014/differenceType /difference /ignored I tried replacing / with . but that failed also. It seems like clirr has not been written in a 'directory separator' agnostic way. Which is a pity as the most recent release seems to be in 2005 - so maybe the clirr devs aren't as active as with other projects. -Original Message- From: Igor Vaynberg [mailto:igor.vaynb...@gmail.com] Sent: Monday, 3 December 2012 8:39 AM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? im on osx -igor On Sun, Dec 2, 2012 at 4:37 AM, Martin Grigorov mgrigo...@apache.org wrote: I use Ubuntu 12. BuildBot (the CI) is some Unix too ( http://ci.apache.org/builders/wicket-master). I cannot test builds on Windows here. On Sun, Dec 2, 2012 at 1:29 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I'm still having the problem. I can see the clirr exclusions Igor added and they seem fine according to the (vary sparse) Clirr doco. What platform are you and Igor building on? I'm building on: Win XP Java 1.6.0_31 4GB RAM -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
RE: master branch compiler error in core?
I'm still having the problem. I can see the clirr exclusions Igor added and they seem fine according to the (vary sparse) Clirr doco. What platform are you and Igor building on? I'm building on: Win XP Java 1.6.0_31 4GB RAM -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: master branch compiler error in core?
I use Ubuntu 12. BuildBot (the CI) is some Unix too ( http://ci.apache.org/builders/wicket-master). I cannot test builds on Windows here. On Sun, Dec 2, 2012 at 1:29 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I'm still having the problem. I can see the clirr exclusions Igor added and they seem fine according to the (vary sparse) Clirr doco. What platform are you and Igor building on? I'm building on: Win XP Java 1.6.0_31 4GB RAM -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/
Re: master branch compiler error in core?
im on osx -igor On Sun, Dec 2, 2012 at 4:37 AM, Martin Grigorov mgrigo...@apache.org wrote: I use Ubuntu 12. BuildBot (the CI) is some Unix too ( http://ci.apache.org/builders/wicket-master). I cannot test builds on Windows here. On Sun, Dec 2, 2012 at 1:29 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I'm still having the problem. I can see the clirr exclusions Igor added and they seem fine according to the (vary sparse) Clirr doco. What platform are you and Igor building on? I'm building on: Win XP Java 1.6.0_31 4GB RAM -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
RE: master branch compiler error in core?
Bingo! - it's the difference between *nix and Windows. When I change the forward slashes to backslashes in the clirr ignored section's className element it works - for Windows at least!! There's a good chance that backslashes will probably break for *nix but even though I have a machine with Linux available I don't have any build environments set up on it yet. ignored difference classNameorg\apache\wicket\feedback\FeedbackCollector/className method*/method differenceType7014/differenceType /difference /ignored I tried replacing / with . but that failed also. It seems like clirr has not been written in a 'directory separator' agnostic way. Which is a pity as the most recent release seems to be in 2005 - so maybe the clirr devs aren't as active as with other projects. -Original Message- From: Igor Vaynberg [mailto:igor.vaynb...@gmail.com] Sent: Monday, 3 December 2012 8:39 AM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? im on osx -igor On Sun, Dec 2, 2012 at 4:37 AM, Martin Grigorov mgrigo...@apache.org wrote: I use Ubuntu 12. BuildBot (the CI) is some Unix too ( http://ci.apache.org/builders/wicket-master). I cannot test builds on Windows here. On Sun, Dec 2, 2012 at 1:29 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I'm still having the problem. I can see the clirr exclusions Igor added and they seem fine according to the (vary sparse) Clirr doco. What platform are you and Igor building on? I'm building on: Win XP Java 1.6.0_31 4GB RAM -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: master branch compiler error in core?
No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d47448d1bf5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/
RE: master branch compiler error in core?
I see Igor's exlusion in the parent pom.xml but it doesn't seem to help the build succeed. -Original Message- From: Martin Grigorov [mailto:mgrigo...@apache.org] Sent: Friday, 30 November 2012 11:52 PM To: users@wicket.apache.org Subject: Re: master branch compiler error in core? No errors here. Igor added an exclusion in parent pom.xml for this change. https://git-wip- us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 8d1b f5b5d0e8207bb8c0cf605cef8c18c On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman chr...@stepaheadsoftware.comwrote: I've just updated the master branch and I get the following build errors: [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ wicket-core --- [INFO] Comparing to version: 6.0.0 [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect()' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public java.util.List collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setIncludeSession(boolean)' is now final [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method 'public org.apache.wicket.feedback.FeedbackCollector setRecursive(boolean)' is now final [INFO] Am I doing something wrong or is there an error in the latest source? -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com http://jweekend.com/ - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
