Re: [vbox-dev] Recent changes to vboxsf have introduced a bug? (was Opportunity to significantly shrink the vboxsf Linux driver)

2017-10-20 Thread Michael Thayer 
Hello Hans,

08.08.2017 16:24, Hans de Goede wrote:
[Discussion of r68101].
> It seems that you've introduced a bug there. You've removed the
> 
> err = RT_FAILURE(err) ? -EPROTO : 0;
> 
> Line after the VbglR0SfWritePhysCont() call, but that call returns
> a VBox status code and sf_reg_write should return a negative
> errno value on error.

Long overdue.  Please see r69151[1].

[1] https://www.virtualbox.org/changeset/69151/vbox

Thank you!
Regards
Michael
-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister
der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev

Re: [vbox-dev] Recent changes to vboxsf have introduced a bug? (was Opportunity to significantly shrink the vboxsf Linux driver)

2017-08-08 Thread Hans de Goede 

Hi,

On 07/25/2017 11:06 AM, Michael Thayer wrote:

13.07.2017 16:42, Michael Thayer wrote:

10.07.2017 12:29, Hans de Goede wrote:
[Patch to shared folder code proposed by Hans to reduce the line count
of the Linux driver.]





I redid the patch again, after realising that the non-physical-page path
was for supporting VirtualBox 3.0 and older on the host, which we have
not tested or supported for a long time.  Therefore
VbglR0CanUsePhysPageList() could be removed altogether.

Hans, I kept your signed-off-by despite my changes, I hope that is fine.


Yes that is fine.


The changes I committed are also attached to this message.


It seems that you've introduced a bug there. You've removed the

err = RT_FAILURE(err) ? -EPROTO : 0;

Line after the VbglR0SfWritePhysCont() call, but that call returns
a VBox status code and sf_reg_write should return a negative
errno value on error.

Regards,

Hans
___
vbox-dev mailing list
vbox-dev@virtualbox.org
https://www.virtualbox.org/mailman/listinfo/vbox-dev