Re: [vdr] [PATCH] vdr/config.c: memset has wrong parameters
Am 21.12.2011 23:31, schrieb Klaus Schmidinger:
On 21.12.2011 23:18, Lars Hanisch wrote:
Hi,
The compiler gives me:
:~/src/vdr$ make config.o
g++ -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses -c
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -DREMOTE_KBD -DLIRC_DEVICE=\"/var/run/lirc/lircd\"
-DRCU_DEVICE=\"/dev/ttyS1\" -D_GNU_SOURCE
-DVIDEODIR=\"/video\" -DCONFDIR=\"/video\" -DPLUGINDIR=\"./PLUGINS/lib\"
-DLOCDIR=\"./locale\" -I/usr/include/freetype2 config.c
In file included from /usr/include/string.h:642:0,
from config.h:16,
from config.c:10:
In Funktion »void* memset(void*, int, size_t)«,
eingefügt von »cSatCableNumbers::cSatCableNumbers(int, const char*)« bei
config.c:72:39:
/usr/include/x86_64-linux-gnu/bits/string3.h:82:32: Warnung: Aufruf von
»__warn_memset_zero_len« mit Attributwarnung
deklariert: memset used with constant zero length parameter; this could be due
to transposed parameters [standardmäßig
aktiviert]
I think, the memset arguments should be swapped:
diff --git a/config.c b/config.c
index 94f6845..53beb4b 100644
--- a/config.c
+++ b/config.c
@@ -69,7 +69,7 @@ cSatCableNumbers::cSatCableNumbers(int Size, const char *s)
{
size = Size;
array = MALLOC(int, size);
- memset(array, size * sizeof(int), 0);
+ memset(array, 0, size * sizeof(int));
FromString(s);
}
Ville Skyttä already reported this to me and I have removed that call
altogether for the next developer version, because the array is initialized
explicitly, anyway.
Fine! :-)
Lars.
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [PATCH] vdr/config.c: memset has wrong parameters
On 21.12.2011 23:18, Lars Hanisch wrote:
Hi,
The compiler gives me:
:~/src/vdr$ make config.o
g++ -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses -c -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-DREMOTE_KBD -DLIRC_DEVICE=\"/var/run/lirc/lircd\" -DRCU_DEVICE=\"/dev/ttyS1\" -D_GNU_SOURCE
-DVIDEODIR=\"/video\" -DCONFDIR=\"/video\" -DPLUGINDIR=\"./PLUGINS/lib\"
-DLOCDIR=\"./locale\" -I/usr/include/freetype2 config.c
In file included from /usr/include/string.h:642:0,
from config.h:16,
from config.c:10:
In Funktion »void* memset(void*, int, size_t)«,
eingefügt von »cSatCableNumbers::cSatCableNumbers(int, const char*)« bei
config.c:72:39:
/usr/include/x86_64-linux-gnu/bits/string3.h:82:32: Warnung: Aufruf von
»__warn_memset_zero_len« mit Attributwarnung deklariert: memset used with
constant zero length parameter; this could be due to transposed parameters
[standardmäßig aktiviert]
I think, the memset arguments should be swapped:
diff --git a/config.c b/config.c
index 94f6845..53beb4b 100644
--- a/config.c
+++ b/config.c
@@ -69,7 +69,7 @@ cSatCableNumbers::cSatCableNumbers(int Size, const char *s)
{
size = Size;
array = MALLOC(int, size);
- memset(array, size * sizeof(int), 0);
+ memset(array, 0, size * sizeof(int));
FromString(s);
}
Ville Skyttä already reported this to me and I have removed that call
altogether for the next developer version, because the array is initialized
explicitly, anyway.
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
[vdr] [PATCH] vdr/config.c: memset has wrong parameters
Hi,
The compiler gives me:
:~/src/vdr$ make config.o
g++ -g -O3 -Wall -Woverloaded-virtual -Wno-parentheses -c -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -DREMOTE_KBD -DLIRC_DEVICE=\"/var/run/lirc/lircd\" -DRCU_DEVICE=\"/dev/ttyS1\" -D_GNU_SOURCE
-DVIDEODIR=\"/video\" -DCONFDIR=\"/video\" -DPLUGINDIR=\"./PLUGINS/lib\" -DLOCDIR=\"./locale\" -I/usr/include/freetype2
config.c
In file included from /usr/include/string.h:642:0,
from config.h:16,
from config.c:10:
In Funktion »void* memset(void*, int, size_t)«,
eingefügt von »cSatCableNumbers::cSatCableNumbers(int, const char*)« bei
config.c:72:39:
/usr/include/x86_64-linux-gnu/bits/string3.h:82:32: Warnung: Aufruf von »__warn_memset_zero_len« mit Attributwarnung
deklariert: memset used with constant zero length parameter; this could be due to transposed parameters [standardmäßig
aktiviert]
I think, the memset arguments should be swapped:
diff --git a/config.c b/config.c
index 94f6845..53beb4b 100644
--- a/config.c
+++ b/config.c
@@ -69,7 +69,7 @@ cSatCableNumbers::cSatCableNumbers(int Size, const char *s)
{
size = Size;
array = MALLOC(int, size);
- memset(array, size * sizeof(int), 0);
+ memset(array, 0, size * sizeof(int));
FromString(s);
}
Regards,
Lars.
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Rotor / Rotor-NG not working with latest VDR
Hi, Am 21.12.2011 22:12, schrieb jan med: I think the problem is YaVDR. Rotorng work whit both vdr-1.7.21/22 (whit patch). There are only same problem with low/no signal! The old-rotor not compile for me. That may be. Have you installed the latest updates? # sudo apt-get update # sudo apt-get dist-upgrade There should at least be an update for vdr-plugin-dynamite. Regards, Lars. kind regards, Jan23 ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] LiveBuffer for vdr 1.7.x
On 21.12.2011 13:34 , Norm Dressler wrote: On 12/21/2011 3:48 AM, René wrote: On 21.12.2011 24:12 , Lists wrote: I'm stuck to vdr 1.6.0-2 because i can't find a current LiveBuffer patch for any current vdr 1.7.x. Does anyone know if there is any work going on with this great patch? Here you go. I grabbed this from the yaVDR source. Norm Hi Norm, Thanks!! Do you know which vdr-build this patch is for? I'm running gentoo, so it should be pretty easy to update an ebuild to contain this patch! :-) René This is for vdr 1.7.21 :) Norm Oh yeah!! Great!! I have right away try to modify an ebuild for this :-) If i'm succesful, i'll post the ebuild back to this thread! René ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
[vdr] Rotor / Rotor-NG not working with latest VDR
I think the problem is YaVDR.
Rotorng work whit both vdr-1.7.21/22 (whit patch).
There are only same problem with low/no signal!
The old-rotor not compile for me.
kind regards,
Jan23
diff -ruN 1.7.22//device.h 1.7.22a//device.h
--- 1.7.22//device.h 2011-12-04 14:38:17.0 +0100
+++ 1.7.22a//device.h 2011-12-05 21:17:36.77513 +0100
@@ -24,6 +24,8 @@
#include "spu.h"
#include "thread.h"
#include "tools.h"
+#include
+#include
#define MAXDEVICES 16 // the maximum number of devices in the system
#define MAXPIDHANDLES 64 // the maximum number of different PIDs per device
@@ -324,7 +325,7 @@
virtual bool HasProgramme(void);
///< Returns true if the device is currently showing any programme to
///< the user, either through replaying or live.
-
+ virtual bool SendDiseqcCmd(dvb_diseqc_master_cmd cmd) {return false;}
// PID handle facilities
private:
diff -ruN 1.7.22/dvbdevice.c 1.7.22a/dvbdevice.c
--- 1.7.22/dvbdevice.c 2011-12-03 16:24:27.0 +0100
+++ 1.7.22a/dvbdevice.c 2011-12-08 22:13:44.04113 +0100
@@ -261,6 +261,7 @@
private:
static cMutex bondMutex;
enum eTunerStatus { tsIdle, tsSet, tsTuned, tsLocked };
+ bool SendDiseqc;
const cDvbDevice *device;
int fd_frontend;
int adapter, frontend;
@@ -276,6 +277,7 @@
cMutex mutex;
cCondVar locked;
cCondVar newSet;
+ dvb_diseqc_master_cmd diseqc_cmd;
cDvbTuner *bondedTuner;
bool bondedMaster;
bool bondedMasterFailed;
@@ -297,6 +299,7 @@
uint32_t SubsystemId(void) const { return subsystemId; }
bool IsTunedTo(const cChannel *Channel) const;
void SetChannel(const cChannel *Channel);
+ bool SendDiseqcCmd(dvb_diseqc_master_cmd cmd);
bool Locked(int TimeoutMs = 0);
int GetSignalStrength(void) const;
int GetSignalQuality(void) const;
@@ -308,6 +311,7 @@
{
device = Device;
fd_frontend = Fd_Frontend;
+ SendDiseqc=false;
adapter = Adapter;
frontend = Frontend;
frontendType = FrontendType;
@@ -813,6 +817,10 @@
if (GetFrontendStatus(NewStatus))
Status = NewStatus;
cMutexLock MutexLock(&mutex);
+if (SendDiseqc) {
+ CHECK(ioctl(fd_frontend, FE_DISEQC_SEND_MASTER_CMD, &diseqc_cmd));
+ SendDiseqc=false;
+ }
switch (tunerStatus) {
case tsIdle:
break;
@@ -867,6 +875,17 @@
}
}
+bool cDvbTuner::SendDiseqcCmd(dvb_diseqc_master_cmd cmd)
+{
+ cMutexLock MutexLock(&mutex);
+ if ((frontendType!=SYS_DVBS2 && frontendType!=SYS_DVBS) || SendDiseqc)
+return false;
+ diseqc_cmd=cmd;
+ SendDiseqc=true;
+ newSet.Broadcast();
+ return true;
+}
+
// --- cDvbSourceParam ---
class cDvbSourceParam : public cSourceParam {
@@ -1415,6 +1434,11 @@
return dvbTuner ? dvbTuner->Locked(TimeoutMs) : false;
}
+bool cDvbDevice::SendDiseqcCmd(dvb_diseqc_master_cmd cmd)
+{
+ return dvbTuner->SendDiseqcCmd(cmd);
+}
+
void cDvbDevice::SetTransferModeForDolbyDigital(int Mode)
{
setTransferModeForDolbyDigital = Mode;
diff -ruN 1.7.22//dvbdevice.h 1.7.22a//dvbdevice.h
--- 1.7.22//dvbdevice.h 2011-12-04 14:38:17.0 +0100
+++ 1.7.22a//dvbdevice.h 2011-12-05 21:17:36.75513 +0100
@@ -181,6 +181,7 @@
virtual bool SetChannelDevice(const cChannel *Channel, bool LiveView);
public:
virtual bool HasLock(int TimeoutMs = 0);
+ virtual bool SendDiseqcCmd(dvb_diseqc_master_cmd cmd);
// PID handle facilities
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] vdr 1.7 in Fedora Rawhide
On 2011-12-21 17:36, Pim Zandbergen wrote: > VDR 1.7.22 is in Fedora Rawhide, which means vdr 1.7.X should > become available in Fedora 17 due in May 2012. Hopefully it'll be 1.8.x or 2.x by then ;) > For those who > can't wait, the rawhide binary RPM's install en work just fine > in Fedora 16, though I rebuilt them from source rpm to be sure. Right. My VDR box runs F-16 plus the VDR related packages from Rawhide as-is, they've worked fine for me so far. > Ville, can we expect more plugins in the final release? I don't personally have plans to use or maintain more plugins than I do now. There are a couple of other people maintaining plugins in Fedora, dunno if they'd be interested. They can be reached at vdr-streamdev-owner and vdr-tvonscreen-owner at fedoraproject.org. If you have interest and some time to spare, helping out isn't that hard... http://fedoraproject.org/wiki/PackageMaintainers/Join ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
[vdr] vdr 1.7 in Fedora Rawhide
VDR 1.7.22 is in Fedora Rawhide, which means vdr 1.7.X should become available in Fedora 17 due in May 2012. Thanks to Ville Skyttä for maintaining the RPM's. For those who can't wait, the rawhide binary RPM's install en work just fine in Fedora 16, though I rebuilt them from source rpm to be sure. Ville, can we expect more plugins in the final release? Here's my wishlist: - eepg is pretty essential for getting EPG for Dutch and UK stations The latest git snapshot builds fine without full VDR source, unlike older stable versions http://projects.vdr-developer.org/git/vdr-plugin-eepg.git/ - some channel scan plugin would be nice, maybe http://wirbel.htpc-forum.de/wirbelscan/index2.html - lcdproc plugin would be nice, since Fedora already comes with lcdproc daemon http://projects.vdr-developer.org/git/vdr-plugin-lcdproc.git/ - xvdr would _really_ be cool, but I guess this is for rpmfusion only https://github.com/pipelka/vdr-plugin-xvdr Thanks, Pim ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [PATCH] vdr-1.7.21 & DVB-T2 support
No comments? Am I really the only one running such a DVB-T + DVB-T2 system? Anyway, this has worked quite nicely for a rather long time on my setup, and therefore I strongly suggest the integration of the patch into the official VDR tree before the next stable release. BR, -- rofa ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] LiveBuffer for vdr 1.7.x
On 12/21/2011 3:48 AM, René wrote: On 21.12.2011 24:12 , Lists wrote: I'm stuck to vdr 1.6.0-2 because i can't find a current LiveBuffer patch for any current vdr 1.7.x. Does anyone know if there is any work going on with this great patch? Here you go. I grabbed this from the yaVDR source. Norm Hi Norm, Thanks!! Do you know which vdr-build this patch is for? I'm running gentoo, so it should be pretty easy to update an ebuild to contain this patch! :-) René This is for vdr 1.7.21 :) Norm ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] LiveBuffer for vdr 1.7.x
On 21.12.2011 24:12 , Lists wrote: I'm stuck to vdr 1.6.0-2 because i can't find a current LiveBuffer patch for any current vdr 1.7.x. Does anyone know if there is any work going on with this great patch? Here you go. I grabbed this from the yaVDR source. Norm Hi Norm, Thanks!! Do you know which vdr-build this patch is for? I'm running gentoo, so it should be pretty easy to update an ebuild to contain this patch! :-) René ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
