Change in vdsm[master]: getIsoList() returns dict with files metadata
Ayal Baron has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5: Code-Review-1
(1 comment)
File vdsm/storage/hsm.py
Line 2261: found = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
why are you filtering out the files with wrong permissions from the dict?
We now have the opportunity to return these together with this information so
that user (engine) would be able to know why a file is not usable...
Line 2266: if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'fileStats': filtered}
Line 2269:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Drop single use inheritance
Antoni Segura Puimedon has posted comments on this change.
Change subject: Drop single use inheritance
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 1142: self.log = log
Line 1143: self._deviceXML = None
Line 1144:
Line 1145: def __str__(self):
Line 1146: attrs = [':'.join((a, str(getattr(self, a for a in
dir(self)
My idea was just to drop the parent class and move the methods down to the only
inheriting class. But I can modify the __str__ in one shot.
Line 1147: if not a.startswith('__')]
Line 1148: return ' '.join(attrs)
Line 1149:
Line 1150: def createXmlElem(self, elemType, deviceType, attributes=[]):
--
To view, visit http://gerrit.ovirt.org/18351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If781ab20110874e71ba16b60d1d5511a54914979
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 5:
(1 comment)
File vdsm/storage/hsm.py
Line 2261: found = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263:
Line 2264: # Filter out files without proper permissions
Line 2265: filtered = dict((key, value) for key, value in found.items()
Great idea! And update the commit message and documentation that now *all*
files are returned, and the engine can display information about inaccessible
files which was hidden before.
Line 2266: if value['status'] == 0)
Line 2267:
Line 2268: return {'isolist': filtered.keys(), 'fileStats': filtered}
Line 2269:
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage and fix test dummies handling - module level
Antoni Segura Puimedon has posted comments on this change. Change subject: Manage and fix test dummies handling - module level .. Patch Set 9: (1 comment) File tests/functional/networkTests.py Line 1259: ruleAdd(rule) Line 1260: self.assertTrue(ruleExists(rule)) Line 1261: ruleDel(rule) Line 1262: self.assertFalse(ruleExists(rule)) Line 1263: addrFlush(nic) Because this patch makes dummy nics be reused across the module. Before it, each test got newly created dummy interfaces, so that no ip address cleanup was necessary. However, now, if you were to get the same nic in testRuleExists and testRouteExists, the test would be skipped when setIP would fail on EEXISTS for the IP address. Line 1264: Line 1265: @RequireDummyMod Line 1266: @ValidateRunningAsRoot Line 1267: def testRouteExists(self): -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Alphabetize test modules list that has gone out of order.
mooli tayer has posted comments on this change. Change subject: Alphabetize test modules list that has gone out of order. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f9a8bdc1a16a172d8a3cabb1b7005accb32ced6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring of retrieving device info from xml
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring of retrieving device info from xml
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Refactoring of retrieving device info from xml .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4629/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Yeela Kaplan has uploaded a new change for review.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
vm: Pause vm in case volume allocation is greater than lv size
qemu bug is causing qcow to allocate extents beyond the volume's
physical size.
In this case we want to avoid extending the volume in
infinite loop.
Also, pause the vm, to avoid data corruption.
Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Signed-off-by: Yeela Kaplan ykap...@redhat.com
---
M vdsm/vm.py
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/19719/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 92d274e..baf407e 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -508,6 +508,12 @@
capacity, alloc, physical = \
self._vm._dom.blockInfo(vmDrive.path, 0)
+if physical - alloc 0:
+self.pause(pauseCode='EOTHER')
+self._log.error('vm: %s paused due to the corrupted volume: ',
+self._vm.id, vmDrive.path)
+continue
+
if physical - alloc = vmDrive.watermarkLimit:
continue
@@ -2407,12 +2413,13 @@
if not guestCpuLocked:
self._guestCpuLock.release()
-def pause(self, afterState='Paused', guestCpuLocked=False):
+def pause(self, afterState='Paused', guestCpuLocked=False,
+ pauseCode='NOERR'):
if not guestCpuLocked:
self._acquireCpuLockWithTimeout()
try:
with self._confLock:
-self.conf['pauseCode'] = 'NOERR'
+self.conf['pauseCode'] = pauseCode
self._underlyingPause()
if hasattr(self, 'updateGuestCpuRunning'):
self.updateGuestCpuRunning()
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Pause vm in case volume allocation is greater than lv size .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4630/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Yaniv Bronhaim has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 10: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3822/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4707/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4631/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsi: Iscsi rescan cleanup
Yaniv Bronhaim has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 10: Code-Review+1 Looks good from my prospective. Need additional storage prospective to see if it doesn't brake the old iscsiScan -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 11: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3823/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4708/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4632/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Yeela Kaplan has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4709/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4633/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4710/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4634/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4711/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4635/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: hibernate now sends required hiberVolHandle
Martin Polednik has posted comments on this change. Change subject: vdsClient: hibernate now sends required hiberVolHandle .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id703a349bac7d75d3acb7e124392ac05d25e2869 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4636/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 16: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4713/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_functional_tests/637/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage and fix test dummies handling - module level
oVirt Jenkins CI Server has posted comments on this change. Change subject: Manage and fix test dummies handling - module level .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4714/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4638/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage and fix test dummies handling - module level
oVirt Jenkins CI Server has posted comments on this change. Change subject: Manage and fix test dummies handling - module level .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4715/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_functional_tests/638/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage and fix test dummies handling - module level
oVirt Jenkins CI Server has posted comments on this change. Change subject: Manage and fix test dummies handling - module level .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_functional_tests/639/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Manage and fix test dummies handling - module level
Dan Kenigsberg has posted comments on this change. Change subject: Manage and fix test dummies handling - module level .. Patch Set 12: Code-Review-1 (1 comment) Thanks for the rebase. File tests/functional/networkTests.py Line 1258: self.assertFalse(ruleExists(rule)) Line 1259: ruleAdd(rule) Line 1260: self.assertTrue(ruleExists(rule)) Line 1261: ruleDel(rule) Line 1262: self.assertFalse(ruleExists(rule)) now that you've explained why this is required, I can tell that it should sit in a finally clause of a try block starting after the setIP command. Line 1263: addrFlush(nic) Line 1264: Line 1265: @RequireDummyMod Line 1266: @ValidateRunningAsRoot -- To view, visit http://gerrit.ovirt.org/19650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c040fc3175b5760728d749578728be60c75cb9b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
mooli tayer has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 12: Verified+1 Verified: live migration seems to still be broken on master so I gave that up. Tested on the environment that originally produces this bug. (migration network right after it's creation, see bug) -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3832/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4717/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4641/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for virtio-rng devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for virtio-rng devices .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4642/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9b2c355e06bae5f66bbaadffd5fda8d3ed4e9a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File vdsm/vm.py Line 3318:volume %s, drive['volumeID'], exc_info=True) Line 3319: finally: Line 3320: os.close(transientHandle) Line 3321: Line 3322: drive['path'] = transientPath drive['format'] = 'cow' Line 3323: Line 3324: def _removeTransientDisk(self, drive): Line 3325: if getattr(drive, 'transient', False): Line 3326: os.unlink(drive.path) -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 8: (1 comment) File lib/vdsm/tool/transient.py Line 70: # one access has been found, fuser returns zero. we can discard the Line 71: # return code. Line 72: open_transient_images = set(x.rsplit(:, 1)[0] for x in cmd_out) Line 73: Line 74: for image_path in transient_images - open_transient_images: absolute path vs relative path Line 75: # NOTE: This could cause a race with the creation of a virtual Line 76: # machine with a transient disk (if vdsm is running). Line 77: try: Line 78: os.unlink(image_path) -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: hibernate now sends required hiberVolHandle
Dan Kenigsberg has posted comments on this change. Change subject: vdsClient: hibernate now sends required hiberVolHandle .. Patch Set 2: Fixes a small vdsClient bug. -- To view, visit http://gerrit.ovirt.org/18280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id703a349bac7d75d3acb7e124392ac05d25e2869 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: hibernate now sends required hiberVolHandle
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsClient: hibernate now sends required hiberVolHandle .. vdsClient: hibernate now sends required hiberVolHandle - vdsClient did not pass hiberVolHandle, causing it to fail any attempt to hibernate - BindigsXMLRPC defaulted required parameter to None Change-Id: Id703a349bac7d75d3acb7e124392ac05d25e2869 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=802446 Signed-off-by: Martin Polednik mpole...@redhat.com Reviewed-on: http://gerrit.ovirt.org/18280 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M vdsm/BindingXMLRPC.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/18280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id703a349bac7d75d3acb7e124392ac05d25e2869 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Refactoring the device dict creation
..
vdsm: Refactoring the device dict creation
The device dictionaries are created on two different locations and
explicitly. Since we have the DeviceMapping already, we can use this to
generate the dictionary of device lists.
Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M vdsm/vm.py
1 file changed, 5 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/19733/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index d23cd21..cce643a 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -2082,6 +2082,8 @@
(REDIR_DEVICES, RedirDevice),
(SMARTCARD_DEVICES, SmartCardDevice))
+def _makeDeviceDict(self):
+return dict((dev, []) for dev, _ in self.DeviceMapping)
def _makeChannelPath(self, deviceName):
return constants.P_LIBVIRT_VMCHANNELS + self.id + '.' + deviceName
@@ -2136,12 +2138,7 @@
self.stopDisksStatsCollection()
self._vmCreationEvent = threading.Event()
self._pathsPreparedEvent = threading.Event()
-self._devices = {DISK_DEVICES: [], NIC_DEVICES: [],
- SOUND_DEVICES: [], VIDEO_DEVICES: [],
- CONTROLLER_DEVICES: [], GENERAL_DEVICES: [],
- BALLOON_DEVICES: [], REDIR_DEVICES: [],
- WATCHDOG_DEVICES: [], CONSOLE_DEVICES: [],
- SMARTCARD_DEVICES: []}
+self._devices = self._makeDeviceDict()
self._connection = libvirtconnection.get(cif)
if 'vmName' not in self.conf:
@@ -2240,12 +2237,7 @@
return removables
def getConfDevices(self):
-devices = {DISK_DEVICES: [], NIC_DEVICES: [],
- SOUND_DEVICES: [], VIDEO_DEVICES: [],
- CONTROLLER_DEVICES: [], GENERAL_DEVICES: [],
- BALLOON_DEVICES: [], REDIR_DEVICES: [],
- WATCHDOG_DEVICES: [], CONSOLE_DEVICES: [],
- SMARTCARD_DEVICES: []}
+devices = self._makeDeviceDict()
for dev in self.conf.get('devices'):
try:
devices[dev['type']].append(dev)
@@ -3116,7 +3108,7 @@
self._qemuguestSocketFile.decode('utf-8'),
_QEMU_GA_DEVICE_NAME)
domxml.appendInput()
-domxml.appendGraphics()
+domxml.appendGraphics()
self._appendDevices(domxml)
--
To view, visit http://gerrit.ovirt.org/19733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Get underlying device info moved to Device classes
Vinzenz Feenstra has uploaded a new change for review.
Change subject: vdsm: Get underlying device info moved to Device classes
..
vdsm: Get underlying device info moved to Device classes
Change-Id: I8f797baece3601b88584f611b420523828f7
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M vdsm/vm.py
1 file changed, 379 insertions(+), 396 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/19732/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4f2f35d..d23cd21 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1196,6 +1196,98 @@
element.setAttrs(**elemAttrs)
return element
+@classmethod
+def _getDeviceAlias(cls, device):
+return device.getElementsByTagName('alias')[0].getAttribute('name')
+
+@classmethod
+def _getDeviceAddress(cls, device):
+
+Obtain device's address from libvirt
+
+address = {}
+dom = device.getElementsByTagName('address')[0]
+# Parse address to create proper dictionary.
+# Libvirt device's address definition is:
+# PCI = {'type':'pci', 'domain':'0x', 'bus':'0x00',
+#'slot':'0x0c', 'function':'0x0'}
+# IDE = {'type':'drive', 'controller':'0', 'bus':'0', 'unit':'0'}
+for key in dom.attributes.keys():
+address[key.strip()] = dom.getAttribute(key).strip()
+
+return address
+
+@classmethod
+def _defaultUpdate(cls, element, type, desc, devices, conf, **kwargs):
+getAddress = kwargs.get('address', True)
+getAddressRequired = False
+if 'getAddressRequired' in kwargs:
+getAddressRequired = kwargs.get('aliasRequired')
+getAddress = getAddressRequired
+
+default = desc.getElementsByTagName(element)
+for x in default:
+if getAddressRequired:
+if not x.getElementsByTagName('address'):
+continue
+
+address = None
+if getAddress:
+address = cls._getDeviceAddress(x)
+
+alias = cls._getDeviceAliasName(x)
+
+for x in devices[type]:
+if address and not hasattr(x, 'address'):
+x.address = address
+if alias and not hasattr(x, 'alias'):
+x.alias = alias
+
+for dev in conf['devices']:
+if dev['type'] == type:
+if address and not dev.get('address'):
+dev['address'] = address
+if alias and not dev.get('alias'):
+dev['alias'] = alias
+
+@classmethod
+def updateFromDesc(cls, desc, devices, conf):
+pass
+
+
+class UnknownDevice(VmDevice):
+@classmethod
+def updateFromDesc(cls, desc, devices, conf):
+
+Obtain unknown devices info from libvirt.
+
+Unknown device is a device that has an address but wasn't
+passed during VM creation request.
+
+def isKnownDevice(alias):
+for dev in conf['devices']:
+if dev.get('alias') == alias:
+return True
+return False
+
+for x in desc.childNodes:
+# Ignore empty nodes and devices without address
+if (x.nodeName == '#text' or
+not x.getElementsByTagName('address')):
+continue
+
+alias = cls._getDeviceAliasName(x)
+if not isKnownDevice(alias):
+address = cls._getDeviceAddress(x)
+# I general case we assume that device has attribute 'type',
+# if it hasn't getAttribute returns ''.
+device = x.getAttribute('type')
+newDev = {'type': x.nodeName,
+ 'alias': alias,
+ 'device': device,
+ 'address': address}
+conf['devices'].append(newDev)
+
class GeneralDevice(VmDevice):
@@ -1219,6 +1311,52 @@
return ctrl
+@classmethod
+def updateFromDesc(cls, desc, devices, conf):
+
+Obtain controller devices info from libvirt.
+
+controllers = desc.getElementsByTagName('controller')
+for x in controllers:
+# Ignore controller devices without address
+if not x.getElementsByTagName('address'):
+continue
+alias = cls._getDeviceAliasName(x)
+device = x.getAttribute('type')
+# Get model and index. Relevant for USB controllers.
+model = x.getAttribute('model')
+index = x.getAttribute('index')
+
+# Get controller address
+address = cls._getDeviceAddress(x)
+
+# In case the controller has index and/or model, they
+# are compared. Currently relevant for USB controllers.
+
Change in vdsm[master]: vdsm: Get underlying device info moved to Device classes
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Get underlying device info moved to Device classes .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3834/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4719/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4643/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/19732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f797baece3601b88584f611b420523828f7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Dan Kenigsberg has submitted this change and it was merged. Change subject: libvirtconnection: ping libvirt upon disconnection .. libvirtconnection: ping libvirt upon disconnection Upon recieving an error from libvirt we should ping it (using getLibVersion) and only upon failure treat it as down. Libvirt error codes do not distinguish recoverable from non-recoverable libvirt errors. Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=982634 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19444 Reviewed-by: Saggi Mizrahi smizr...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/libvirtconnection.py M tests/Makefile.am A tests/libvirtconnectionTests.py 3 files changed, 142 insertions(+), 9 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Refactoring the device dict creation .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3835/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4720/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Get underlying device info moved to Device classes
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Get underlying device info moved to Device classes .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3837/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4722/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4646/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/19732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f797baece3601b88584f611b420523828f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Refactoring the device dict creation .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3836/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4721/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4645/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restart needed services after reconfigure libvirt
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Restart needed services after reconfigure libvirt
..
Restart needed services after reconfigure libvirt
Without starting libvirtd service after reconfigure, nwfilter fails
to run.
Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013371
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M init/vdsmd_init_common.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/19737/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 38da542..5c8895c 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -55,7 +55,8 @@
task_reconfigure_libvirt(){
-$VDSM_TOOL libvirt-configure
+$VDSM_TOOL libvirt-configure
+$VDSM_TOOL libvirt-configure-services-restart
}
--
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restart needed services after reconfigure libvirt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Restart needed services after reconfigure libvirt .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4723/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4647/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restart needed services after reconfigure libvirt
Yaniv Bronhaim has posted comments on this change. Change subject: Restart needed services after reconfigure libvirt .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding call to svdsm.ping from vdsm ping verb
Yaniv Bronhaim has abandoned this change. Change subject: Adding call to svdsm.ping from vdsm ping verb .. Abandoned Maybe it could be used for sanity tests when a user wants to check the communication to vdsm and between vdsm to its related services, but then we should add ping to libvirt as well. Anyhow, not so useful, and doesn't say much, so I pass. -- To view, visit http://gerrit.ovirt.org/18329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Moti Asayag masa...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restart needed services after reconfigure libvirt
Alon Bar-Lev has posted comments on this change. Change subject: Restart needed services after reconfigure libvirt .. Patch Set 1: (1 comment) File init/vdsmd_init_common.sh.in Line 55 Line 56 Line 57 Line 58 Line 59 I thought we removed this from the common, it should not be used anywhere, and should be removed. -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Restart needed services after reconfigure libvirt
Yaniv Bronhaim has posted comments on this change. Change subject: Restart needed services after reconfigure libvirt .. Patch Set 1: (1 comment) File init/vdsmd_init_common.sh.in Line 55 Line 56 Line 57 Line 58 Line 59 what do you mean? its part of vdsmd_init_common.sh --pre-start and it is used also over systemd and upstart. It must be called from here -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Lee Yarwood has uploaded a new change for review. Change subject: supervdsm: Enable multiprocessing module logging. .. supervdsm: Enable multiprocessing module logging. The multiprocessing module includes error logging using Python's logging module, but it is not enabled by default. This patch enables the logging and sets it to propagate to the supervdsmServer's root logger, so it now defaults to producing logging and can be configured easily from /etc/vdsm/svdsm.logger.conf. Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Signed-off-by: Lee Yarwood lyarw...@redhat.com Signed-off-by: David Gibson dgib...@redhat.com --- M vdsm/supervdsmServer 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/19741/1 diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer index 40ec9df..006c35c 100755 --- a/vdsm/supervdsmServer +++ b/vdsm/supervdsmServer @@ -30,6 +30,7 @@ import signal import logging import logging.config +import multiprocessing LOG_CONF_PATH = /etc/vdsm/svdsm.logger.conf @@ -356,6 +357,7 @@ def main(sockfile, pidfile=None): log = logging.getLogger(SuperVdsm.Server) +multiprocessing.get_logger().propagate = 1 def bind(func): def wrapper(_SuperVdsm, *args, **kwargs): -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
oVirt Jenkins CI Server has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4648/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix tokenizing of unsupported data in vdsmapi-schema.json
Saggi Mizrahi has posted comments on this change. Change subject: Fix tokenizing of unsupported data in vdsmapi-schema.json .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d29686d3189fd9e64e26c56dcd9da370f855406 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Pause vm in case volume allocation is greater than lv size .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4649/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Yeela Kaplan has posted comments on this change. Change subject: vm: Pause vm in case volume allocation is greater than lv size .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Michal Skrivanek has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 508: capacity, alloc, physical = \
Line 509: self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510:
Line 511: if physical - alloc 0:
Line 512: self._vm.pause(pauseCode='EOTHER')
wouldn't EIO be more appropriate here?
Line 513: self._log.error('vm: %s paused due to the corrupt
volume: %s',
Line 514: self._vm.id, vmDrive.path)
Line 515: continue
Line 516:
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Yeela Kaplan has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 508: capacity, alloc, physical = \
Line 509: self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510:
Line 511: if physical - alloc 0:
Line 512: self._vm.pause(pauseCode='EOTHER')
As far as I see, it's not an IO error, but a problem with the qcow format, a
corruption, which we don't have an error code for, and I also think we
shouldn't add one just because of a temporary qemu bug...
If the user will think it's an IO error, he'll try fixing connectivity to
storage...
Line 513: self._log.error('vm: %s paused due to the corrupt
volume: %s',
Line 514: self._vm.id, vmDrive.path)
Line 515: continue
Line 516:
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Michal Skrivanek has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 2: Code-Review+1
(1 comment)
File vdsm/vm.py
Line 508: capacity, alloc, physical = \
Line 509: self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510:
Line 511: if physical - alloc 0:
Line 512: self._vm.pause(pauseCode='EOTHER')
yeah, I guess you're right
Line 513: self._log.error('vm: %s paused due to the corrupt
volume: %s',
Line 514: self._vm.id, vmDrive.path)
Line 515: continue
Line 516:
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Dan Kenigsberg has posted comments on this change. Change subject: bugfix: UpdateVmDevice QoS .. Patch Set 5: Code-Review-1 I suggest to keep this patch unmerged (and the bug open) until the underlying libvirt issue is solved and available in el6/Fedora. https://bugzilla.redhat.com/show_bug.cgi?id=1014200 https://bugzilla.redhat.com/show_bug.cgi?id=1014198 -- To view, visit http://gerrit.ovirt.org/19545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Pause vm in case volume allocation is greater than lv size
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 2: Code-Review-1
(2 comments)
File vdsm/vm.py
Line 509: self._vm._dom.blockInfo(vmDrive.path, 0)
Line 510:
Line 511: if physical - alloc 0:
Line 512: self._vm.pause(pauseCode='EOTHER')
Line 513: self._log.error('vm: %s paused due to the corrupt
volume: %s',
nit: each log line has the long vmid and module name anyway. no need to repeat
them twice.
also, we are not 100% sure that a corrupt vmDrive.path is the reason, it's just
the most likely one. I'd prefer a more informative text such as: implausible
alloc %(alloc) physical %(physical) in volume vmDrive.
Line 514: self._vm.id, vmDrive.path)
Line 515: continue
Line 516:
Line 517: if physical - alloc = vmDrive.watermarkLimit:
Line 4211: #in the case of a qcow2-like file stored inside
a block
Line 4212: #device 'physical' will give the block device
size, while
Line 4213: #'allocation' will give the qcow2 image size
Line 4214: #D. Berrange
Line 4215: capacity, alloc, physical =
self._dom.blockInfo(d.path, 0)
Shouldn't you catch the problem in this case, too?
Line 4216: if (physical
Line 4217: (alloc + config.getint(
Line 4218: 'irs', 'volume_utilization_chunk_mb'))):
Line 4219: self.log.warn('%s = %s/%s error %s phys: %s
alloc: %s '
--
To view, visit http://gerrit.ovirt.org/19719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95aa1ed7508218d8ae6a878606cd2d251ac2b05
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Arik Hadas aha...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Alphabetize test modules list that has gone out of order.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Alphabetize test modules list that has gone out of order. .. Alphabetize test modules list that has gone out of order. Change-Id: I9f9a8bdc1a16a172d8a3cabb1b7005accb32ced6 Signed-off-by: Mooli Tayer mta...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19512 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M tests/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, approved mooli tayer: Verified -- To view, visit http://gerrit.ovirt.org/19512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f9a8bdc1a16a172d8a3cabb1b7005accb32ced6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileVolume: fix volume type check in _extendSizeRaw
oVirt Jenkins CI Server has posted comments on this change. Change subject: fileVolume: fix volume type check in _extendSizeRaw .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4650/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87695d67bd912f084e99314cff4ce42fd9d4cd2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
oVirt Jenkins CI Server has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3842/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4651/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix tokenizing of unsupported data in vdsmapi-schema.json
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix tokenizing of unsupported data in vdsmapi-schema.json .. Fix tokenizing of unsupported data in vdsmapi-schema.json vdsmapi tokenizer got into an endless loop when unsupported token was found. Example input trigering this are invalid tokens such as unquoted string, or valid JSON tokens like null, true and false, which are not supported by the parser. Now the tokenizer raise ValueError with the offending data. This should be good enough for developers usage. New unittests cover tokenizing valid, invalid and unspported tokens. Change-Id: I7d29686d3189fd9e64e26c56dcd9da370f855406 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19697 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Saggi Mizrahi smizr...@redhat.com --- M tests/schemaTests.py M vdsm_api/vdsmapi.py 2 files changed, 70 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Saggi Mizrahi: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d29686d3189fd9e64e26c56dcd9da370f855406 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Nir Soffer has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 6:
(10 comments)
Looks very good - but need to emphasize the difference between the old isolist
and new fileStats. It is little confusing that one collection include only
usable files and the other all files; hopefully more precise documentation will
mitigate this confusion.
Commit Message
Line 5: CommitDate: 2013-10-01 22:45:50 +0300
Line 6:
Line 7: getIsoList() returns dict with files metadata
Line 8:
Line 9: Previously getIsoList() returned only list of file names although it has
More correct:
Previously getIsoList() returned only list of usable file names although it
has
Line 10: additional information such as file size. Absence of this information
Line 11: prevented Engine to display correct data.
Line 12:
Line 13: Now this API returns all available information about these files
Line 13: Now this API returns all available information about these files
Line 14: including files with wrong permissions, so Engine can display correct
Line 15: sizes and files that previously were hidden. It also returns
Line 16: the information in the old format in order to support old Engine
Line 17: versions.
Good description!
Line 18:
Line 19: Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Line 20: Bug-Url: https://bugzilla.redhat.com/1005889
File vdsm/storage/hsm.py
Line 2240: @public
Line 2241: def getIsoList(self, spUUID, extension='iso', options=None):
Line 2242:
Line 2243: Gets a dict of ISO files in a storage pool. For backward
Line 2244: compatibility also return a list of file names.
More correct:
Gets a dict of all iso files in a storage pool. For backward
compatibility also return a list of usable file names.
Line 2245:
Line 2246: :param spUUID: The UUID of the storage pool you want to
query.
Line 2247: :type spUUID: UUID
Line 2248: :param extension: ?
Line 2256: vars.task.getSharedLock(STORAGE, spUUID)
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Explain why do not filter fileStats:
# Return all files stats including those with wrong permissions,
# so client can tell why file is not usable and display more helpful
# information.
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2257: isoDom = self.getPool(spUUID).getIsoDomain()
Line 2258: if not isoDom:
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Rename to fileStats
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2259: raise se.GetIsoListError(spUUID)
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Replace comment that explain what the code does with comment that explain why
it does that:
# Older clients expected list of file names with correct permissions.
Line 2264: fileNames = [key for key, value in filesDict.items()
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2260:
Line 2261: filesDict = isoDom.getFileList(pattern='*.' + extension,
Line 2262:caseSensitive=False)
Line 2263: # Get list of iso file names with proper permissions only
Line 2264: fileNames = [key for key, value in filesDict.items()
Rename fileNames to usableFileNames
Line 2265: if value['status'] == 0]
Line 2266:
Line 2267: return {'isolist': fileNames, 'fileStats': filesDict}
Line 2268:
Line 2269: @public
Line 2270: def getFloppyList(self, spUUID, options=None):
Line 2271:
Line 2272: Gets a dict of floppy files in a storage pool. For backward
Line 2273: compatibility also return a list of file names.
More correct:
Gets a dict of all floppy files in a storage pool. For backward
compatibility also return a list of usable file
Change in vdsm[master]: fileVolume: fix volume type check in _extendSizeRaw
Ayal Baron has posted comments on this change. Change subject: fileVolume: fix volume type check in _extendSizeRaw .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87695d67bd912f084e99314cff4ce42fd9d4cd2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: readme: how to configure libvirt after manual installation
Nir Soffer has uploaded a new change for review. Change subject: readme: how to configure libvirt after manual installation .. readme: how to configure libvirt after manual installation When vdsm is installed automatically, libvirt is configured during the bootstap flow. However, when installing vdsm manually the user has configure and restart libvirt using vdsm-tool. Change-Id: I208a752993c0e714a065026155da1f7efa29eeeb Signed-off-by: Nir Soffer nsof...@redhat.com --- M README 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/19761/1 diff --git a/README b/README index e649da5..7ddce56 100644 --- a/README +++ b/README @@ -25,9 +25,17 @@ make sudo make install +Before starting the VDSM service in the first time, you must configure and +restart libvirt service: + + vdsm-tool libvirt-configure + vdsm-tool libvirt-configure-services-restart + +Packaging += + The 'vdsm.spec' file demonstrates how to distribute VDSM as an RPM package. - Getting Help -- To view, visit http://gerrit.ovirt.org/19761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I208a752993c0e714a065026155da1f7efa29eeeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: readme: how to configure libvirt after manual installation
oVirt Jenkins CI Server has posted comments on this change. Change subject: readme: how to configure libvirt after manual installation .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4652/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I208a752993c0e714a065026155da1f7efa29eeeb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: readme: how to configure libvirt after manual installation
oVirt Jenkins CI Server has posted comments on this change. Change subject: readme: how to configure libvirt after manual installation .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4653/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I208a752993c0e714a065026155da1f7efa29eeeb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has uploaded a new change for review.
Change subject: Adding [start|stop]MonitoringDomain().
..
Adding [start|stop]MonitoringDomain().
startMonitoringDomain() is added for monitoring a storage domain
without being connected to the pool and geting and ID for such
SD lockspace.
stopMonitoringDomain() stops the monitoring and releases the ID.
Monitoring results are gathered with repoStats().
Caveat Emptor:
SDs added to the monitor using startMonitoringDomain() should not
be part of the pool! i.e. the pool domain set and the added SDs set
should be disjoint.
Making repoStats pool independent.
Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Signed-off-by: Eduardo ewars...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm_api/vdsmapi-schema.json
6 files changed, 105 insertions(+), 32 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/19762/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 590b1e7..6aba25e 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1692,6 +1692,16 @@
print 'Domain %s %s' % (d, str(stats[d]))
return 0, ''
+def startMonitoringDomain(self, args):
+sdUUID, hostID = args
+self.s.startMonitoringDomain(sdUUID, hostID)
+return 0, ''
+
+def stopMonitoringDomain(self, args):
+sdUUID, = args
+self.s.stopMonitoringDomain(sdUUID)
+return 0, ''
+
def snapshot(self, args):
vmUUID, sdUUID, imgUUID, baseVolUUID, volUUID = args
@@ -2466,8 +2476,16 @@
)),
'repoStats': (serv.repoStats,
('',
- 'Get the the health status of the active domains'
+ 'Get the health status of the monitored domains'
)),
+'startMonitoringDomain': (serv.startMonitoringDomain,
+ ('sdUUID hostID',
+ 'Start SD: sdUUID monitoring with hostID'
+ )),
+'stopMonitoringDomain': (serv.stopMonitoringDomain,
+ ('sdUUID',
+ 'Stop monitoring SD: sdUUID'
+ )),
'snapshot': (serv.snapshot,
('vmId sdUUID imgUUID baseVolUUID volUUID',
'Take a live snapshot'
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..fa9a3ab 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1396,6 +1396,12 @@
def getStorageRepoStats(self):
return self._irs.repoStats()
+def startMonitoringDomain(self, sdUUID, hostID):
+return self._irs.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID):
+return self._irs.stopMonitoringDomain(sdUUID)
+
def getLVMVolumeGroups(self, storageType=None):
return self._irs.getVGList(storageType)
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fb65ad4..5dd747a 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -787,6 +787,14 @@
api = API.Global()
return api.getStorageRepoStats()
+def startMonitoringDomain(self, sdUUID, hostID, options=None):
+api = API.Global()
+return api.startMonitoringDomain(sdUUID, hostID)
+
+def stopMonitoringDomain(self, sdUUID, options=None):
+api = API.Global()
+return api.stopMonitoringDomain(sdUUID)
+
def vgsGetList(self, storageType=None, options=None):
api = API.Global()
return api.getLVMVolumeGroups(storageType)
@@ -937,6 +945,8 @@
(self.domainsGetList, 'getStorageDomainsList'),
(self.poolsGetConnectedList, 'getConnectedStoragePoolsList'),
(self.storageRepoGetStats, 'repoStats'),
+(self.startMonitoringDomain, 'startMonitoringDomain'),
+(self.stopMonitoringDomain, 'stopMonitoringDomain'),
(self.vgsGetList, 'getVGList'),
(self.devicesGetList, 'getDeviceList'),
(self.devicesGetVisibility, 'getDevicesVisibility'),
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 4ea68ea..5f14468 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -40,6 +40,7 @@
from vdsm.config import config
import sp
+import domainMonitor
import sd
import blockSD
import nfsSD
@@ -93,6 +94,8 @@
STORAGE_CONNECTION_DIR = os.path.join(constants.P_VDSM_LIB, connections/)
QEMU_READABLE_TIMEOUT = 30
+
+HSM_DOM_MON_LOCK = HsmDomainMonitorLock
def public(f=None, **kwargs):
@@ -398,6 +401,9 @@
name=storageRefresh)
storageRefreshThread.daemon = True
storageRefreshThread.start()
+
+monitorInterval = config.getint('irs', 'sd_health_check_delay')
+
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
oVirt Jenkins CI Server has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4654/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4655/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix getStorageDomainInfo() logic.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3847/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4656/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4657/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Eduardo has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1: Verified+1
More verification (with engine) is required!
[root@localhost ~]# vdsClient -s 0 getStorageDomainsList
9615bd0c-ed20-4d47-b8d9-61a06e634830
577c3957-ee57-4496-ac84-c35067e1913a
2a7fbb64-f64c-4139-ba79-aaf21547845f
eff02bb9-cea8-4f89-a077-47f36be46197
[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo
9615bd0c-ed20-4d47-b8d9-61a06e634830
uuid = 9615bd0c-ed20-4d47-b8d9-61a06e634830
vguuid = FScea1-AGv1-hwlM-dYHv-BZFb-Wit8-1ogEdM
lver = -1
state = OK
version = 3
role = Regular
pool = ['5849b030-626e-47cb-ad90-3ce782d831b3']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = iscsi1
[root@localhost ~]# vdsClient -s 0 getStorageDomainInfo
2a7fbb64-f64c-4139-ba79-aaf21547845f
uuid = 2a7fbb64-f64c-4139-ba79-aaf21547845f
vguuid = fzjUA0-bfG5-UJIL-nya2-T6NI-yAOh-8w3FsC
lver = -1
state = OK
version = 3
role = Master
pool = ['0d1ef687-3b3f-4e27-89f2-69d38dc4dc22']
spm_id = -1
type = ISCSI
class = Data
master_ver = 0
name = edu1
[root@localhost ~]# vdsClient -s 0 getConnectedStoragePoolsList
[root@localhost ~]# vdsClient -s 0 repoStats
[root@localhost ~]# vdsClient -s 0 startMonitoringDomain
9615bd0c-ed20-4d47-b8d9-61a06e634830 9
[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000697625',
'lastCheck': '9.3', 'code': 0, 'valid': True, 'version': 3}
[root@localhost ~]# vdsClient -s 0 connectStoragePool
0d1ef687-3b3f-4e27-89f2-69d38dc4dc22 4 0 2a7fbb64-f64c-4139-ba79-aaf21547845f 1
[root@localhost ~]# vdsClient -s 0 repoStats
Domain 9615bd0c-ed20-4d47-b8d9-61a06e634830 {'delay': '0.000580883',
'lastCheck': '9.0', 'code': 0, 'valid': True, 'version': 3}
Domain 2a7fbb64-f64c-4139-ba79-aaf21547845f {'delay': '0.000485516',
'lastCheck': '9.6', 'code': 0, 'valid': True, 'version': 3}
[root@localhost ~]# vdsClient -s 0 stopMonitoringDomain
9615bd0c-ed20-4d47-b8d9-61a06e634830
[root@localhost ~]# vdsClient -s 0 repoStats
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Eduardo has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 8: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix getStorageDomainInfo() logic.
Eduardo has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 6: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
Eduardo has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 7: Verified+1 Verified with Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vdsClient.repoStats() bad path.
Eduardo has uploaded a new change for review. Change subject: Fix vdsClient.repoStats() bad path. .. Fix vdsClient.repoStats() bad path. (Or why using your list as a dict is bad.) Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Signed-off-by: Eduardo ewars...@redhat.com --- M client/vdsClient.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/19764/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index 5ecf04d..a393f1c 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1685,7 +1685,7 @@ stats = self.s.repoStats() if stats['status']['code']: print count not get repo stats -return int(list['status']['code']) +return int(stats['status']['code']) for d in stats: if d == status: continue -- To view, visit http://gerrit.ovirt.org/19764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: is list a dict?
Eduardo has uploaded a new change for review. Change subject: vdsClient: is list a dict? .. vdsClient: is list a dict? Short answer: NO! Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Signed-off-by: Eduardo ewars...@redhat.com --- M client/vdsClient.py 1 file changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/19763/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index 590b1e7..5ecf04d 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1642,44 +1642,44 @@ return status['status']['code'], status['power'] return status['status']['code'], status['status']['message'] -def __image_status(self, imgUUID, list): -if imagestatus in list and message in list: +def __image_status(self, imgUUID, res): +if imagestatus in res and message in res: status = OK -if list[imagestatus]: +if res[imagestatus]: status = ERROR print (Image %s status %s: %s (%s) % - (imgUUID, status, list[message], list[imagestatus])) -if badvols in list: -for v, err in list[badvols].iteritems(): + (imgUUID, status, res[message], res[imagestatus])) +if badvols in res: +for v, err in res[badvols].iteritems(): print \tVolume %s is bad: %s % (v, err) -def __domain_status(self, sdUUID, list): -if domainstatus in list and message in list: +def __domain_status(self, sdUUID, res): +if domainstatus in res and message in res: status = OK -if list[domainstatus]: +if res[domainstatus]: status = ERROR print (Domain %s status %s: %s (%s) % - (sdUUID, status, list[message], list[domainstatus])) -if badimages in list: -for i in list[badimages]: + (sdUUID, status, res[message], res[domainstatus])) +if badimages in res: +for i in res[badimages]: print \tImage %s is bad % (i) -self.__image_status(i, list[badimages][i]) +self.__image_status(i, res[badimages][i]) -def __pool_status(self, spUUID, list): -if poolstatus in list and message in list: +def __pool_status(self, spUUID, res): +if poolstatus in res and message in res: status = OK -if list[poolstatus]: +if res[poolstatus]: status = ERROR print (Pool %s status %s: %s (%s) % - (spUUID, status, list[message], list[poolstatus])) + (spUUID, status, res[message], res[poolstatus])) if masterdomain: -print \tMaster domain is %s % list[masterdomain] +print \tMaster domain is %s % res[masterdomain] if spmhost: -print \tThe SPM host id is %s % list[spmhost] -if baddomains in list: -for d in list[baddomains]: +print \tThe SPM host id is %s % res[spmhost] +if baddomains in res: +for d in res[baddomains]: print \tDomain %s is bad: % (d) -self.__domain_status(d, list[baddomains][d]) +self.__domain_status(d, res[baddomains][d]) def repoStats(self, args): stats = self.s.repoStats() -- To view, visit http://gerrit.ovirt.org/19763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vdsClient.repoStats() bad path.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix vdsClient.repoStats() bad path. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4659/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7f6c367c83c2d00967e31dda6c9d0ef2fd3e57 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsClient: is list a dict?
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsClient: is list a dict? .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4658/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacd7af3691eb2ed15b7fbb042f8ce43528dce31e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
