Change in vdsm[master]: iscsi: Iscsi rescan cleanup
Ayal Baron has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 11: (2 comments) File vdsm/storage/iscsi.py Line 391: Line 392: log.debug(Performing SCSI scan, this will take up to %s seconds, Line 393: maxTimeout) Line 394: Line 395: rescanOp = iscsiadm.session_rescan_async() iscsiadm rescan does not hang for long periods of time afaik, so I'm not sure what's the point of this here. i.e. instead of all this fancy code, just remove this function and keep the previous 'rescan' and possibly add a minWait sleep to it, to give the host some time to add devices Line 396: time.sleep(minTimeout) Line 397: rescanOp.wait(timeout=(maxTimeout - minTimeout)) Line 398: Line 399: File vdsm/storage/iscsiadm.py Line 307: return AsyncProcessOperation(proc, parse_result) Line 308: Line 309: Line 310: def session_rescan(): Line 311: aop = session_rescan_async() did you mean apo? that's an implementation detail (that the object returned is of AsyncProcessOperation type). Line 312: return aop.result() Line 313: Line 314: Line 315: def session_logout(sessionId): -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rescan FC when rescanning for new multipath devices
Ayal Baron has posted comments on this change. Change subject: Rescan FC when rescanning for new multipath devices .. Patch Set 5: (2 comments) File lib/vdsm/utils.py Line 798: if append: Line 799: cmd.append(--append) Line 800: Line 801: cmd.extend(outputFiles) Line 802: proc = execCmd(cmd, sync=False) I thought you disapprove of direct usage of execCmd? Line 803: proc.stdin.write(data) Line 804: Line 805: def parser(rc, out, err): Line 806: if rc != 0: File vdsm/storage/multipath.py Line 107: Should only be called from hsm._rescanDevices() Line 108: Line 109: Line 110: # First ask fc and iSCSI to rescan all of their sessions Line 111: fc.rescan() I thought the premise of the previous patch is that iscsiadm -m session -R already does this? Line 112: iscsi.rescan() Line 113: Line 114: # Now let multipath daemon pick up new devices Line 115: -- To view, visit http://gerrit.ovirt.org/19539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idec939222676a24452e8825b36db68839bfd2bbc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3941/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Dan Kenigsberg has posted comments on this change. Change subject: getIsoList() returns dict with files metadata .. Patch Set 7: A gallant developer suggested that using the existing getFileList verb would be more fitting for this task, while keeping our API cleaner. The only problem with using it NOW is that its current globbing is case-sensitive, while Engine would like it to be insensitive. This can be solved by passing a new option to control case sensitivity. In https://bugzilla.redhat.com/show_bug.cgi?id=693218 Engine requested the getFileList verb. Maybe it's time to start using it? I'm not stating my opinion as firmly as I should because I woke up late in the process of these reviews. -- To view, visit http://gerrit.ovirt.org/19544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getIsoList() returns dict with files metadata
Saggi Mizrahi has posted comments on this change.
Change subject: getIsoList() returns dict with files metadata
..
Patch Set 7: Code-Review-1
Since you changed the base return type of the call you need to change Bridge.py
as well
look for:
'StoragePool_getIsoList': {'ret': 'isolist'},
--
To view, visit http://gerrit.ovirt.org/19544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b28488a81cec756188ed763e4489b8a39b2b05d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Dan Kenigsberg has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 1545: # {sdUUID1: status1, sdUUID2: status2, ...}
Line 1546: self.invalidateMetadata()
Line 1547: poolDoms = self.getDomains()
Line 1548: activeDomains = tuple(sdUUID for sdUUID in poolDoms
Line 1549: if poolDoms[sdUUID] ==
sd.DOM_ACTIVE_STATUS)
I think that Eduardo is saying that we must not iterate over all
monitoredDomains, but only on those connected to the pool. Hence
poolDoms = self.getDomains()
is required, and to avoid races (and added metadata reads), a repeated call
with
activeOnly=True
should not be used.
Line 1550: monitoredDomains = self.domainMonitor.monitoredDomains
Line 1551:
Line 1552: for sdUUID in poolDoms:
Line 1553: if sdUUID not in activeDomains:
--
To view, visit http://gerrit.ovirt.org/19762
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com
Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks _getUnderlyingDriveInfo() is broken by design. It has no reliable means to match Engine-requested devices with libvirt-produced ones. As a heuristic, it uses the device's as matching key. However, before this patch, it failed to extract the path from the xml definition of gluster disks. Bug-Url: https://bugzilla.redhat.com/1007980 Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19906 Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Martin Polednik mpole...@redhat.com Tested-by: Martin Polednik mpole...@redhat.com --- M vdsm/vm.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Martin Polednik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Dan Kenigsberg has posted comments on this change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
Patch Set 1: Code-Review+2
(1 comment)
File vdsm/vm.py
Line 4647: sources = x.getElementsByTagName('source')
Line 4648: if sources:
Line 4649: devPath = (sources[0].getAttribute('file') or
Line 4650:sources[0].getAttribute('dev') or
Line 4651:sources[0].getAttribute('name'))
Given the +1s and verifications - I opt for postponing log fixes to a future
patch.
Line 4652: else:
Line 4653: devPath = ''
Line 4654:
Line 4655: target = x.getElementsByTagName('target')
--
To view, visit http://gerrit.ovirt.org/19906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Hello Vinzenz Feenstra, Michal Skrivanek, Martin Polednik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19949
to review the following change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
_getUnderlyingDriveInfo() is broken by design. It has no reliable means
to match Engine-requested devices with libvirt-produced ones. As a
heuristic, it uses the device's as matching key. However, before this
patch, it failed to extract the path from the xml definition of gluster
disks.
Bug-Url: https://bugzilla.redhat.com/1007980
Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19906
Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com
Reviewed-by: Martin Polednik mpole...@redhat.com
Tested-by: Martin Polednik mpole...@redhat.com
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/19949/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 4333170..d73671b 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -4562,7 +4562,8 @@
sources = x.getElementsByTagName('source')
if sources:
devPath = (sources[0].getAttribute('file') or
- sources[0].getAttribute('dev'))
+ sources[0].getAttribute('dev') or
+ sources[0].getAttribute('name'))
else:
devPath = ''
--
To view, visit http://gerrit.ovirt.org/19949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3.0]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Hello Vinzenz Feenstra, Michal Skrivanek, Martin Polednik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/19950
to review the following change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
_getUnderlyingDriveInfo() is broken by design. It has no reliable means
to match Engine-requested devices with libvirt-produced ones. As a
heuristic, it uses the device's as matching key. However, before this
patch, it failed to extract the path from the xml definition of gluster
disks.
Bug-Url: https://bugzilla.redhat.com/1007980
Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19906
Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com
Reviewed-by: Martin Polednik mpole...@redhat.com
Tested-by: Martin Polednik mpole...@redhat.com
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/19950/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index f0690b7..662eacc 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -4579,7 +4579,8 @@
sources = x.getElementsByTagName('source')
if sources:
devPath = (sources[0].getAttribute('file') or
- sources[0].getAttribute('dev'))
+ sources[0].getAttribute('dev') or
+ sources[0].getAttribute('name'))
else:
devPath = ''
--
To view, visit http://gerrit.ovirt.org/19950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3.0
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3.0]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Dan Kenigsberg has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: This issue is detrimental to anyone trying gluster volumes. I suggest to push it as a quick async fix for ovirt-3.3.0. -- To view, visit http://gerrit.ovirt.org/19950 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3.0 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Dan Kenigsberg has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 5: Code-Review-1 reminder: add functional tests. -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix getStorageDomainInfo() logic.
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix getStorageDomainInfo() logic. .. Fix getStorageDomainInfo() logic. Domains with 'role' == MASTER_DOMAIN should always be attached to a pool. Detect 'stale' master domains. Not hiding errors anymore. Catching specific errors. BC: If the domain is a Master but it is not connected to the actual (host) pool, master_ver, host_id and lver are not returned. Required for making repoStats pool independent. Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14671 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 21 insertions(+), 9 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Eduardo: Verified -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix missing error code error during jenkins build
Hello Ayal Baron, Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/19956 to review the following change. Change subject: gluster: fix missing error code error during jenkins build .. gluster: fix missing error code error during jenkins build Remove unused error codes: 4162, 4163, 4164, 4165 from vdsm/gluster/exception.py Change-Id: I3364743666c4291ad3f7b72e82fdce89255c7e1a Signed-off-by: Timothy Asir tjeya...@redhat.com --- M vdsm/gluster/exception.py 1 file changed, 0 insertions(+), 45 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/19956/1 diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index 1d9399f..20c157e 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -356,51 +356,6 @@ message = Volume tasks list failed -class GlusterTaskNotFoundException(GlusterVolumeException): -code = 4162 -message = Task not found - -def __init__(self, taskId): -self.taskId = taskId -s = 'task id: %s' % taskId -self.err = [s] - - -class GlusterTaskActionNotFoundException(GlusterVolumeException): -code = 4163 -message = Task action not found - -def __init__(self, taskId, action): -self.taskId = taskId -self.action = action -s = 'Action %s not found for task %s' % (action, taskId) -self.err = [s] - - -class GlusterTaskActionUnsupportedException(GlusterVolumeException): -code = 4164 -message = Task action unsupported - -def __init__(self, taskId, taskType, action): -self.taskId = taskId -self.taskType = taskType -self.action = action -s = 'Unsupported action %s for task %s and type %s' % \ -(action, taskId, taskType) -self.err = [s] - - -class GlusterTaskTypeUnknownException(GlusterVolumeException): -code = 4165 -message = Task type unknown - -def __init__(self, taskId, taskType): -self.taskId = taskId -self.taskType = taskType -s = 'Unknown task type %s for task %s' % (taskId, taskType) -self.err = [s] - - # Host class GlusterHostException(GlusterException): code = 4400 -- To view, visit http://gerrit.ovirt.org/19956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3364743666c4291ad3f7b72e82fdce89255c7e1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Vinzenz Feenstra has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
Yaniv Bronhaim has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 1:
(1 comment)
File init/systemd/systemd-vdsmd.in
Line 28:
Line 29: @BINDIR@/vdsm-tool libvirt-configure ${2:+--force}
Line 30: @BINDIR@/vdsm-tool libvirt-configure-services-restart
Line 31: @BINDIR@/vdsm-tool sanlock-check-service
Line 32: @BINDIR@/vdsm-tool service-restart sanlock
in EL6 we call service vdsmd reconfigure that does that
--
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Michal Skrivanek has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: Code-Review+1 Martin, can you please verify... -- To view, visit http://gerrit.ovirt.org/19906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Merge configuration tools to configurator.py and add configu...
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Merge configuration tools to configurator.py and add
configure-all verb
..
Merge configuration tools to configurator.py and add configure-all verb
Change-Id: Id173b3257ba1d493d0ea44185fbb57bb5872cb2e
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M init/sysvinit/vdsmd.init.in
R lib/vdsm/tool/configurator.py
D lib/vdsm/tool/sanlock.py
3 files changed, 53 insertions(+), 68 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/19915/1
diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 13ac769..13bfa11 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -106,16 +106,11 @@
return 1
}
-reconfigure_libvirt() {
+reconfigure() {
local force
[ ${1} = force ] force=--force
-$VDSM_TOOL libvirt-configure ${force}
+$VDSM_TOOL configure-all ${force}
$VDSM_TOOL libvirt-configure-services-restart
-}
-
-reconfigure_sanlock() {
-$VDSM_TOOL sanlock-check-service
-$VDSM_TOOL service-restart sanlock
}
start() {
@@ -207,8 +202,7 @@
reconfigure)
# Jump over 'reconfigure'
shift 1
-reconfigure_libvirt $@
-reconfigure_sanlock
+reconfigure $@
RETVAL=$?
;;
*)
diff --git a/lib/vdsm/tool/libvirt_configure.py b/lib/vdsm/tool/configurator.py
similarity index 62%
rename from lib/vdsm/tool/libvirt_configure.py
rename to lib/vdsm/tool/configurator.py
index 26987ed..3f1cc62 100644
--- a/lib/vdsm/tool/libvirt_configure.py
+++ b/lib/vdsm/tool/configurator.py
@@ -19,11 +19,19 @@
import os
import sys
+import grp
from vdsm import utils
import vdsm.tool
from vdsm.tool import service
-from vdsm.constants import P_VDSM_EXEC
+from vdsm.constants import P_VDSM_EXEC, DISKIMAGE_GROUP
+
+
+SANLOCK_PID = /var/run/sanlock/sanlock.pid
+
+PROC_STATUS_PATH = /proc/%s/status
+PROC_STATUS_GROUPS = Groups:\t
+PROC_STATUS_GROUPS_LEN = len(PROC_STATUS_GROUPS)
def exec_libvirt_configure(action, *args):
@@ -82,3 +90,44 @@
Check if libvirt is already configured for vdsm
return exec_libvirt_configure(check_if_configured, *args)
+
+
+@vdsm.tool.expose(sanlock-check-service)
+def sanlock_check_service(*args):
+
+Check if sanlock service requires a restart to reload the relevant
+supplementary groups.
+
+
+try:
+sanlock_pid = open(SANLOCK_PID, r).readline().strip()
+sanlock_status = open(PROC_STATUS_PATH % sanlock_pid, r)
+except IOError as e:
+if e.errno == os.errno.ENOENT:
+return 0 # service is not running, returning
+raise
+
+for status_line in sanlock_status:
+if status_line.startswith(PROC_STATUS_GROUPS):
+groups = [int(x) for x in
+ status_line[PROC_STATUS_GROUPS_LEN:].strip().split( )]
+break
+else:
+raise RuntimeError(Unable to find sanlock service groups)
+
+diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2]
+return 0 if diskimage_gid in groups else 1
+
+
+@vdsm.tool.expose(reconfigure-all)
+def configure_all(*args):
+
+configure related services for vdsm
+
+if '--force' in args:
+service.service_stop(supervdsmd)
+service.service_stop(libvirtd)
+
+configure_libvirt(*args)
+if sanlock_check_service(*args):
+service.service_restart(sanlock)
diff --git a/lib/vdsm/tool/sanlock.py b/lib/vdsm/tool/sanlock.py
deleted file mode 100644
index 650a5cf..000
--- a/lib/vdsm/tool/sanlock.py
+++ /dev/null
@@ -1,58 +0,0 @@
-# Copyright 2013 Red Hat, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-import os
-import grp
-
-from vdsm import constants
-from vdsm.tool import expose
-
-
-SANLOCK_PID = /var/run/sanlock/sanlock.pid
-
-PROC_STATUS_PATH = /proc/%s/status
-PROC_STATUS_GROUPS = Groups:\t
-PROC_STATUS_GROUPS_LEN = len(PROC_STATUS_GROUPS)
-
-
-@expose(sanlock-check-service)
-def sanlock_check_service(*args):
-
-Check if sanlock service requires a restart to reload the relevant
-supplementary groups.
-
-
-try:
-sanlock_pid = open(SANLOCK_PID,
Change in vdsm[master]: Moving coredump configuration to common script
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving coredump configuration to common script .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4804/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3919/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoiding automatically restart of sanlock service when starting vdsmd .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4805/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3920/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing libvirt_configure from pre-start and ask for manual...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing libvirt_configure from pre-start and ask for manual run .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4806/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3921/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing return method from vdsmd start function
oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing return method from vdsmd start function .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4808/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3923/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Merge configuration tools to configurator.py and add configu...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Merge configuration tools to configurator.py and add configure-all verb .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4807/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3922/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id173b3257ba1d493d0ea44185fbb57bb5872cb2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Dan Kenigsberg has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 24: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
Petr Šebek has posted comments on this change.
Change subject: Add IPv6 support to configNetwork
..
Patch Set 4:
(2 comments)
File vdsm/netmodels.py
Line 407: class IpConfig(object):
Line 408: ipConfig = namedtuple('ipConfig', ['ipaddr', 'netmask', 'gateway',
Line 409:'defaultRoute', 'ipv6addr',
Line 410:'ipv6gateway',
'ipv6defaultRoute',
Line 411:'bootproto', 'async',
'ipv6autoconf',
Fixed
Line 412:'dhcpv6'])
Line 413:
Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None,
blocking=False,
Line 415: ipv6autoconf=None, dhcpv6=None):
Line 411:'bootproto', 'async',
'ipv6autoconf',
Line 412:'dhcpv6'])
Line 413:
Line 414: def __init__(self, inet4=None, inet6=None, bootproto=None,
blocking=False,
Line 415: ipv6autoconf=None, dhcpv6=None):
You are right that was the problem. Now I pass both configuration even if it
has only None values.
Line 416: if inet4 is None and inet6 is None:
Line 417: raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to
specify '
Line 418: 'IPv4 or IPv6 or both address.')
Line 419: if ((inet4 and inet4.address and bootproto == 'dhcp') or
--
To view, visit http://gerrit.ovirt.org/18284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add IPv6 support to configNetwork
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IPv6 support to configNetwork .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_network_functional_tests/653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4809/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3924/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed056b683f0cb893b2edcf1ae673c64ce5cd18c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: -Code-Review Please verify this with a complete engine setup that it still works. I might be wrong about the backwards compatibility (therefore removing my -1) -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] More refactor work
Vinzenz Feenstra has abandoned this change. Change subject: [WIP] More refactor work .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I11154569c1d7593ebb70827d584337b0c2d32638 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Merge _base_init and __init__
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Merge _base_init and __init__ .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic4426942852c8c2c0c950f744e6bae5bfe3aaa2f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Simplify the retrieval of device XML objects
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Simplify the retrieval of device XML objects .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9d67e1f675ed5b4a6dfdc4fa0ee1a15487fb0a97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Code simplifications
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Code simplifications .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iaff375542048f49da507910252a35780161ee09c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Remove duplicated variable and class comment
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Remove duplicated variable and class comment .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1100efe3e14574fce651df6e2b1bf0ddd3130994 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Vm remove unused method _incomingMigrationPending
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Vm remove unused method _incomingMigrationPending .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/10870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I726a46a1d7dea4461a44414ac5f596222cfbee68 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Nicer names for methods
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Nicer names for methods .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/10868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9614084b812d1da4a5a1b0cc8aedefbd63713f60 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactor out LibvirtVmDevice
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Refactor out LibvirtVmDevice .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/10866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4e05b948dbe88328f3cd3186df7d12a40eb5e648 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: replace self.conf['vmId'] with self.id
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: replace self.conf['vmId'] with self.id .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/11744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie116d8db8d0bf2157bc78be16a03b556443c18ef Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Simplify device map initialization
Vinzenz Feenstra has abandoned this change. Change subject: vdsm: Simplify device map initialization .. Abandoned Out of date -- To view, visit http://gerrit.ovirt.org/10867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I36b89a0aec6fc1311aba2b9213ee4dc705f43e7e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4810/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3925/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/654/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4811/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3926/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Assaf Muller has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 25: Code-Review-1 Nope. Nope. Nope. Pushed an old patch set. Will fix now. -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 25: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/655/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4812/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3927/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4814/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3929/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70d8c01176e8159e462d311b1241dbda0baf0bb2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4815/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3930/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1c6650b357cebfcaa375a2babb8c12637fd5a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4813/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3928/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Assaf Muller has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 26: Sorry about that - Patch set 24 is identical to 26. -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol
Assaf Muller has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol .. Patch Set 10: Patch set 10 is a rebase. -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4816/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3931/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enhanced netinfo.getBootProtocol
oVirt Jenkins CI Server has posted comments on this change. Change subject: Enhanced netinfo.getBootProtocol .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/656/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4817/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3932/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib50721b55ed6e3a2e92d839926d32dda012a51d2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 24:
(5 comments)
File init/vdsmd_init_common.sh.in
Line 172: $VDSM_TOOL libvirt-test-conflicts
Line 173: }
Line 174:
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE=@VDSMRUNDIR@/nets_restored
please change to:
local restoration_file=...
Line 177: if [ ! -f $RESTORATION_FILE ]; then
Line 178: @PYTHON@ @VDSMDIR@/vdsm-restore-net-config
Line 179: touch $RESTORATION_FILE
Line 180: fi
Line 173: }
Line 174:
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE=@VDSMRUNDIR@/nets_restored
Line 177: if [ ! -f $RESTORATION_FILE ]; then
use ${..}
Line 178: @PYTHON@ @VDSMDIR@/vdsm-restore-net-config
Line 179: touch $RESTORATION_FILE
Line 180: fi
Line 181: }
Line 175: task_restore_nets(){
Line 176: RESTORATION_FILE=@VDSMRUNDIR@/nets_restored
Line 177: if [ ! -f $RESTORATION_FILE ]; then
Line 178: @PYTHON@ @VDSMDIR@/vdsm-restore-net-config
Line 179: touch $RESTORATION_FILE
It can return a failure code.. don't you want to report it?
Line 180: fi
Line 181: }
Line 182: pre-start tasks end
Line 183:
File vdsm/vdsm-restore-net-config
Line 65:
Line 66:
Line 67: if __name__ == '__main__':
Line 68: try:
Line 69: logging.config.fileConfig(/etc/vdsm/svdsm.logger.conf)
why supervdsm conf? use vdsm.logger.conf..
Line 70: except:
Line 71: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 72: level=logging.DEBUG)
Line 73: logging.error(Could not init proper logging, exc_info=True)
Line 67: if __name__ == '__main__':
Line 68: try:
Line 69: logging.config.fileConfig(/etc/vdsm/svdsm.logger.conf)
Line 70: except:
Line 71: logging.basicConfig(filename='/dev/stdout', filemode='w+',
don't you prefer to use syslog as fallback?
Line 72: level=logging.DEBUG)
Line 73: logging.error(Could not init proper logging, exc_info=True)
Line 74:
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 26: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/657/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4818/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3933/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3934/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Hello Timothy Asir, Saggi Mizrahi, Aravinda VK, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/19922 to review the following change. Change subject: gluster: remove unwanted error codes .. gluster: remove unwanted error codes This patch fixes to remove unwanted error codes which are no longer needed. Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Signed-off-by: Bala.FA barum...@redhat.com --- M vdsm/gluster/exception.py 1 file changed, 0 insertions(+), 45 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/19922/1 diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py index 1d9399f..20c157e 100644 --- a/vdsm/gluster/exception.py +++ b/vdsm/gluster/exception.py @@ -356,51 +356,6 @@ message = Volume tasks list failed -class GlusterTaskNotFoundException(GlusterVolumeException): -code = 4162 -message = Task not found - -def __init__(self, taskId): -self.taskId = taskId -s = 'task id: %s' % taskId -self.err = [s] - - -class GlusterTaskActionNotFoundException(GlusterVolumeException): -code = 4163 -message = Task action not found - -def __init__(self, taskId, action): -self.taskId = taskId -self.action = action -s = 'Action %s not found for task %s' % (action, taskId) -self.err = [s] - - -class GlusterTaskActionUnsupportedException(GlusterVolumeException): -code = 4164 -message = Task action unsupported - -def __init__(self, taskId, taskType, action): -self.taskId = taskId -self.taskType = taskType -self.action = action -s = 'Unsupported action %s for task %s and type %s' % \ -(action, taskId, taskType) -self.err = [s] - - -class GlusterTaskTypeUnknownException(GlusterVolumeException): -code = 4165 -message = Task type unknown - -def __init__(self, taskId, taskType): -self.taskId = taskId -self.taskType = taskType -s = 'Unknown task type %s for task %s' % (taskId, taskType) -self.err = [s] - - # Host class GlusterHostException(GlusterException): code = 4400 -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3935/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Maor Lipchuk has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: What about GlusterVolumeTasksFailedException with code 4161. I see that he was merged in http://gerrit.ovirt.org/#/c/10200/20/vdsm/gluster/exception.py, but still it is not in the engine. -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: remove unwanted error codes
Bala.FA has posted comments on this change. Change subject: gluster: remove unwanted error codes .. Patch Set 1: This error is used at vdsm side. I am sure there is patch in review at engine side or on the way to consume. -- To view, visit http://gerrit.ovirt.org/19922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284121a14b1e0f9f2d7c56c2f867eb71791bfd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Return the new volume after merge
Ayal Baron has posted comments on this change. Change subject: image: Return the new volume after merge .. Patch Set 1: (1 comment) File vdsm/storage/image.py Line 1132: self.log.error(Failure to remove subchain %s - %s in image %s, Line 1133:ancestor, successor, imgUUID, exc_info=True) Line 1134: Line 1135: try: Line 1136: srcVol.shrinkToOptimalSize() wouldn't it be simpler and safer just to produce the new volume here? We just finished merging volumes so the overhead is negligible and this way we wouldn't care about any implementation changes above (also, it would be 1 line without changing internal APIs etc). Line 1137: except qemuImg.QImgError: Line 1138: self.log.warning(Auto shrink after merge failed, exc_info=True) Line 1139: Line 1140: self.log.info(Merge src=%s with dst=%s was successfully finished., -- To view, visit http://gerrit.ovirt.org/19883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b0969c3144b51ff22a7f5eb756563cf178ffb36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 26:
(1 comment)
File lib/vdsm/tool/restore_nets.py
Line 31: Restores the networks to what was previously persisted via vdsm.
Line 32:
Line 33: rc, out, err = utils.execCmd([os.path.join(
Line 34: P_VDSM, 'vdsm-restore-net-config')], raw=True,
Line 35: sudo=kwargs.get('sudo', False))
only root should run it anyway.. no?
Line 36: sys.stdout.write(out)
Line 37: sys.stderr.write(err)
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Michal Skrivanek has posted comments on this change.
Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 4647: sources = x.getElementsByTagName('source')
Line 4648: if sources:
Line 4649: devPath = (sources[0].getAttribute('file') or
Line 4650:sources[0].getAttribute('dev') or
Line 4651:sources[0].getAttribute('name'))
would be good to actually add some log lines. It is once per VM life so I think
it is worth couple of lines what devices we have, what is matched, etc...
e.g. in this case it would save us 2 weeks
Line 4652: else:
Line 4653: devPath = ''
Line 4654:
Line 4655: target = x.getElementsByTagName('target')
--
To view, visit http://gerrit.ovirt.org/19906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi: gluster: vdsmapi schema definitions for existing gl...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4745/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3936/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70d8c01176e8159e462d311b1241dbda0baf0bb2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi: gluster: vdsmapi schema definitions for existing gl...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4746/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3937/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70d8c01176e8159e462d311b1241dbda0baf0bb2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add logging to _getUnderlyingDriveInfo
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
vdsm: add logging to _getUnderlyingDriveInfo
_getUnderlyingDriveInfo() currently logs nothing - due
to unfrequent calls to this function, it might be good idea
to add verbose logging that displays how the devices are
matched in _devices and conf['devices']
Change-Id: I884e6b25c5bcb71ee24ad9ebad8df7c2775c5e19
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M vdsm/vm.py
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/19928/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index f09b739..1926631 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -4667,8 +4667,15 @@
# Get disk address
address = self._getUnderlyingDeviceAddress(x)
+# Keep data as dict for easier debugging
+deviceDict = {'path': devPath, 'target': target, 'name': name,
+ 'readonly': readonly, 'bootOrder': bootOrder,
+ 'address': address, 'type': devType, 'boot': boot}
+
+self.log.debug('Found drive with attributes %s', deviceDict)
for d in self._devices[DISK_DEVICES]:
if d.path == devPath:
+self.log.debug('Matched %s with %s', deviceDict, d)
d.name = name
d.type = devType
d.drv = drv
@@ -4681,6 +4688,7 @@
knownDev = False
for dev in self.conf['devices']:
if dev['type'] == DISK_DEVICES and dev['path'] == devPath:
+self.log.debug('Matched %s with %s', deviceDict, dev)
dev['name'] = name
dev['address'] = address
dev['alias'] = alias
@@ -4697,6 +4705,7 @@
'readonly': str(readonly)}
if bootOrder:
diskDev['bootOrder'] = bootOrder
+self.log.debug('Found unknown drive: %s', diskDev)
self.conf['devices'].append(diskDev)
def _getUnderlyingDisplayPort(self):
--
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I884e6b25c5bcb71ee24ad9ebad8df7c2775c5e19
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add logging to _getUnderlyingDriveInfo
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add logging to _getUnderlyingDriveInfo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4823/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3938/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I884e6b25c5bcb71ee24ad9ebad8df7c2775c5e19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move zombieReaper to its own package
Yaniv Bronhaim has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 6: Code-Review-1
(1 comment)
only tiny little thing..
File vdsm.spec.in
Line 97: Requires: python-netaddr
Line 98: Requires: python-inotify
Line 99: Requires: python-argparse
Line 100: Requires: python-ethtool = 0.6-3
Line 101: Requires: vdsm-python-zombiereaper = %{version}-%{release}
use %{name}
Line 102: Requires: rpm-python
Line 103: Requires: nfs-utils
Line 104: Requires: m2crypto
Line 105: Requires: libguestfs-tools-c
--
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58e9c834820d98fb3dcffdf06bfc05eb68ea6827
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing libvirt_configure from pre-start and ask for manual...
Alon Bar-Lev has posted comments on this change.
Change subject: Removing libvirt_configure from pre-start and ask for manual run
..
Patch Set 6:
(2 comments)
File init/vdsmd_init_common.sh.in
Line 219:
Line 220: ;;
Line 221: --post-stop)
Line 222: run_tasks \
Line 223: run_final_hooks \
indent missing
Line 224:
Line 225: ;;
Line 226: --help|*)
Line 227: usage
File lib/vdsm/tool/libvirt_configure.sh.in
Line 199: #
Line 200: if [ ${force_reconfigure} != --force ] \
Line 201: ! [ -f ${FORCE_RECONFIGURE} ] \
Line 202: is_already_configured ${lconf} ${qconf} ${ldconf}
${qlconf}; then
Line 203: echo Not forcing reconfigure
wrong indent?
Line 204: return 0
Line 205: fi
Line 206:
Line 207: # Remove a previous configuration (if present)
--
To view, visit http://gerrit.ovirt.org/19737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf70a749454ea341d5b52220e16e9567b90431a0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving coredump configuration to common script
Alon Bar-Lev has posted comments on this change.
Change subject: Moving coredump configuration to common script
..
Patch Set 2:
(2 comments)
File init/daemonAdapter
Line 67: def execute(self):
Line 68: try:
Line 69: self._parse_args()
Line 70: os.nice(config.getint('vars', 'vdsm_nice'))
Line 71: if os.environ['COREDUMP_ENABLED']:
this value is not reaching here.
Line 72: resource.setrlimit(resource.RLIMIT_CORE, 0)
Line 73:
Line 74: env = os.environ.copy()
Line 75: env.update({
File init/vdsmd_init_common.sh.in
Line 27: local getconfitem=@VDSMDIR@/get-conf-item
Line 28:
Line 29: if ${getconfitem} ${conf_file} vars core_dump_enable false |
Line 30: tr A-Z a-z | grep -q true; then
Line 31: export COREDUMP_ENABLED=True
this is not go into the damaemon anyway... just remove.
Line 32: echo /var/log/core/core.%p.%t.dump
/proc/sys/kernel/core_pattern
Line 33: fi
Line 34: }
Line 35:
--
To view, visit http://gerrit.ovirt.org/19889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I763889c9b91676582a58aa238d47ccc8dac9375e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Calculation of chain to remove is inaccurate
Dan Kenigsberg has posted comments on this change. Change subject: image: Calculation of chain to remove is inaccurate .. Patch Set 1: Is this fix related to https://bugzilla.redhat.com/show_bug.cgi?id=1015071 ? -- To view, visit http://gerrit.ovirt.org/19852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoiding automatically restart of sanlock service when start...
Alon Bar-Lev has posted comments on this change.
Change subject: Avoiding automatically restart of sanlock service when starting
vdsmd
..
Patch Set 2:
(2 comments)
this patch if merge by its own breaks host-deploy.
File init/sysvinit/vdsmd.init.in
Line 207: reconfigure)
Line 208: # Jump over 'reconfigure'
Line 209: shift 1
Line 210: reconfigure_libvirt $@
Line 211: reconfigure_sanlock
what is the return if one fail? if two?
Line 212: RETVAL=$?
Line 213: ;;
Line 214: *)
Line 215: echo Usage: $0
{start|stop|status|restart|force-reload|try-restart}
File init/vdsmd_init_common.sh.in
Line 56
Line 57
Line 58
Line 59
Line 60
should be:
if ! $VDSM_TOOL sanlock-check-service; then
echo Perform 'vdsm-tool service-restart sanlock' and start vdsm again
return 1
fi
return 0
see bellow and above...
--
To view, visit http://gerrit.ovirt.org/19890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48658066f707632719df8d65799d26c7b239dcd5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing return method from vdsmd start function
Alon Bar-Lev has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 2:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 73:fi
Line 74: fi
Line 75: ret_val=$?
Line 76: # Only if service exists and stop failed, fail the operation
Line 77: if which ${srv} /dev/null [ ${ret_val} -ne 0 ]; then
which? I do not understand... first it should be [ -x ${srv} ] as you check
for file existence at /etc/init.d/, second it should be tested before you
attempt to even start or stop it.
Line 78: log_failure_msg ${prog}: Stop conflicting ${srv}
Line 79: return ${ret_val}
Line 80: fi
Line 81: done
--
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: Calculation of chain to remove is inaccurate
Yeela Kaplan has posted comments on this change. Change subject: image: Calculation of chain to remove is inaccurate .. Patch Set 1: No. Just fixed it along the way. -- To view, visit http://gerrit.ovirt.org/19852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248c51727584a35d1f439e57c93613caa9f369a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Create the java bindings and fix bugs
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Create the java bindings and fix bugs .. Patch Set 6: Code-Review+1 (1 comment) +1 only for json python part! I'll recheck on new ps File lib/yajsonrpc/betterAsyncore.py Line 221: self.ac_in_buffer = '' Line 222: Line 223: def _find_prefix_at_end(haystack, needle): Line 224: l = len(needle) - 1 Line 225: while l and not haystack.endswith(needle[:l]): while l0 Line 226: l -= 1 Line 227: return l Line 228: Line 229: def handle_write(self, dispatcher): -- To view, visit http://gerrit.ovirt.org/19497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Saggi Mizrahi has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: I'm quite afraid of logging related deadlocks. The python guys are known to miss those kinds of races. I would someone to look at how they implement the logging before I can agree to this. -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Saggi Mizrahi has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: Code-Review-1 Just so it's not pushed by mistake -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: produce volume in order to shrink after merge
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: produce volume in order to shrink after merge .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4824/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3939/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b0969c3144b51ff22a7f5eb756563cf178ffb36 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: produce volume in order to shrink after merge
oVirt Jenkins CI Server has posted comments on this change. Change subject: image: produce volume in order to shrink after merge .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4749/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4825/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3940/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b0969c3144b51ff22a7f5eb756563cf178ffb36 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: unify lease params
Ayal Baron has posted comments on this change.
Change subject: sd: unify lease params
..
Patch Set 3:
(3 comments)
File vdsm/storage/fileSD.py
Line 214: # initialize domain metadata content
Line 215: # FIXME : This is 99% like the metadata in block SD
Line 216: # Do we really need to keep the EXPORT_PATH?
Line 217: # no one uses it
Line 218: meta = {}
if you're already changing the name, why not make it consistent with blockSD?
Line 219: meta.update({
Line 220: sd.DMDK_VERSION: version,
Line 221: sd.DMDK_SDUUID: sdUUID,
Line 222: sd.DMDK_TYPE: storageType,
Line 223: sd.DMDK_CLASS: domClass,
Line 224: sd.DMDK_DESCRIPTION: domainName,
Line 225: sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 226: sd.DMDK_POOLS: [],
Line 227: sd.DMDK_LOCK_POLICY: '',
why not unify all of the above as well?
Line 228: REMOTE_PATH: remotePath
Line 229: })
Line 230: meta.update(sd.SUB_DEFAULT_LEASE_PARAMS)
Line 231: md.update(meta)
File vdsm/storage/sd.py
Line 120: DMDK_LEASE_TIME_SEC = 'LEASETIMESEC'
Line 121: DMDK_IO_OP_TIMEOUT_SEC = 'IOOPTIMEOUTSEC'
Line 122: DMDK_LEASE_RETRIES = 'LEASERETRIES'
Line 123:
Line 124: SUB_DEFAULT_LEASE_PARAMS = {DMDK_LEASE_RETRIES: 3,
I don't understand the name of this dict
Line 125: DMDK_LEASE_TIME_SEC: 60,
Line 126: DMDK_LOCK_RENEWAL_INTERVAL_SEC: 5,
Line 127: DMDK_IO_OP_TIMEOUT_SEC: 10}
Line 128:
--
To view, visit http://gerrit.ovirt.org/16318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65d5dd2a0130a19234d7fb699854a09f5748566
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: produce volume in order to shrink after merge
Ayal Baron has posted comments on this change. Change subject: image: produce volume in order to shrink after merge .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b0969c3144b51ff22a7f5eb756563cf178ffb36 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Create AsyncProcessOperation
Ayal Baron has posted comments on this change. Change subject: utils: Create AsyncProcessOperation .. Patch Set 9: (5 comments) File lib/vdsm/utils.py Line 914: Line 915: time.sleep(sleep) Line 916: Line 917: Line 918: class AsyncProcessOperation(object): why is this a separate class and not part of AsyncProc? Line 919: def __init__(self, proc, resultParser=None): Line 920: Wraps a running process operation. Line 921: Line 922: resultParser should be of type callback(rc, out, err) and can return Line 933: the condition has been met Line 934: return self._proc.wait(timeout, cond) Line 935: Line 936: def stop(self): Line 937: Stops the running operaions, effectively sending a kill signal to s/operaions/operations/ Line 938: the process Line 939: self._proc.kill() Line 940: Line 941: def result(self): Line 938: the process Line 939: self._proc.kill() Line 940: Line 941: def result(self): Line 942: Returns the result in the as a tuple of (result, error). 'in the' what? Line 943: if the operation is still running it will block until it returns. Line 944: Line 945: The if no resultParser has been set the default result Line 946: is (rc, out, err) Line 941: def result(self): Line 942: Returns the result in the as a tuple of (result, error). Line 943: if the operation is still running it will block until it returns. Line 944: Line 945: The if no resultParser has been set the default result 'The if no'? Line 946: is (rc, out, err) Line 947: with self._lock: Line 948: if self._result is None: Line 949: out, err = self._proc.communicate() Line 956: self._result = (None, e) Line 957: else: Line 958: self._result = ((rc, out, err), None) Line 959: Line 960: self._done = True this is never used Line 961: Line 962: return self._result Line 963: Line 964: def __del__(self): -- To view, visit http://gerrit.ovirt.org/19254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79d0eefc9d917a4a93916d52867fb4f1e793c60e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Move all calls to multipath exe to a single method
Ayal Baron has posted comments on this change. Change subject: multipath: Move all calls to multipath exe to a single method .. Patch Set 9: (1 comment) Commit Message Line 5: CommitDate: 2013-10-06 16:49:08 +0300 Line 6: Line 7: multipath: Move all calls to multipath exe to a single method Line 8: Line 9: This makes the code a bit cleaner cleaner how? why is this dependent on AsyncProcessOperation (which seems totally unrelated to me). Afaiu this should be a part of a new topic branch? i.e. this should be one of many patches Line 10: Line 11: Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd -- To view, visit http://gerrit.ovirt.org/19255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52afc07a07a925ed7572eb369deb7c203edb04cd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 5: You can add your investigation details or questions about it on the BZ. Better document it there. -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Gibson dgib...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks
Martin Polednik has posted comments on this change. Change subject: vm.Vm._getUnderlyingDriveInfo: extract path of gluster disks .. Patch Set 1: Verified+1 Code-Review+1 verified, fixes bug #1007980 -- To view, visit http://gerrit.ovirt.org/19906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4459916cab24d735c067a6eb7020d4f43505fc97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
