Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Nir Soffer has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 1: Please confirm that this package is available on all supported platforms. -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added lib/vdsm/utils.py:touchFile
Dan Kenigsberg has submitted this change and it was merged. Change subject: Added lib/vdsm/utils.py:touchFile .. Added lib/vdsm/utils.py:touchFile Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21590 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbbea57c425adc8b911bb9e1931c02edb71db820 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Made ipwrapper.py:Route class more robust
Dan Kenigsberg has submitted this change and it was merged. Change subject: Made ipwrapper.py:Route class more robust .. Made ipwrapper.py:Route class more robust Route can now parse routes of the form: 'local 127.0.0.1 dev lo src 127.0.0.1' Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21788 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py M lib/vdsm/netinfo.py M tests/functional/networkTests.py M tests/ipwrapperTests.py M vdsm/sourceRoute.py 5 files changed, 62 insertions(+), 44 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2d62ad31bd9d5c7bea28605a0b195c1886f0dab Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Introduce CallbackChain .. utils: Introduce CallbackChain Added new utility class encapsulating the pattern of invoking multiple alternative methods to achieve given task. Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Signed-off-by: Martin Betak mbe...@redhat.com Reviewed-on: http://gerrit.ovirt.org/19228 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/utils.py M tests/utilsTests.py 2 files changed, 117 insertions(+), 1 deletion(-) Approvals: Martin Betak: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Add limit to rollback for recursive configurator
Dan Kenigsberg has submitted this change and it was merged. Change subject: netconf: Add limit to rollback for recursive configurator .. netconf: Add limit to rollback for recursive configurator This is the first patch of a series that is intended to provide a default configurator memory rollback implementation and define the contracts of the rollback operation. To do that, first it is necessary to define a difference between a regular setupNetworks operation and one performed with the purpose of rolling back. If a configurator implemented the rollback operation via calling setupNetworks, we would potentially end up recursing until it succeeded (and we have no guarantee for success). This patch adds a parameter to the configurator constructor and the setupNetworks options that allows the configurator to pass to setupNetworks inRollback=True when it uses it for rollback purposes. Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21615 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/constants.py.in M vdsm/configNetwork.py M vdsm/netconf/__init__.py M vdsm/netconf/ifcfg.py 4 files changed, 16 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd24cfb15f37695d999c66deada9c6dcd6bef574 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(5 comments)
File client/vdsClient.py
Line 245: params = {'vmId': args[0], 'drive': drive}
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def setNumberOfCpus(self, args):
Line 249: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
Done
Line 250:
Line 251: def do_changeCD(self, args):
Line 252: vmId = args[0]
Line 253: file = self._parseDriveSpec(args[1])
File vdsm/API.py
Line 456: def setNumberOfCpus(self, params):
Line 457: try:
Line 458: utils.validateMinimalKeySet(params, ('vmId',
'numberOfCpus'))
Line 459: except ValueError:
Line 460: self.log.error('Missing one of required parameters: vmId,
drive')
will the backtrace include the missing params? otherwise I don't see the real
value
Line 461: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 462:'message': 'Missing one of required '
Line 463: 'parameters: vmId,
numberOfCpus'}}
Line 464: try:
File vdsm/vm.py
Line 3309: if self.isMigrating():
Line 3310: return errCode['migInProgress']
Line 3311:
Line 3312: self.log.debug(Setting number of cpus to : %s %
Line 3313:params.get['numberOfCpus'])
Done
Line 3314:
Line 3315: try:
Line 3316: self._dom.setVcpu(params.get('numberOfCpus'))
Line 3317: except libvirt.libvirtError as e:
File vdsm_api/Bridge.py
Line 339: 'Volume_getInfo': {'ret': 'info'},
Line 340: 'Volume_getPath': {'ret': 'path'},
Line 341: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 342: 'Host_getAllTasks': {'ret': 'tasks'},
Line 343: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Done
Line 344: }
Line 345:
Line 346:
Line 347: def fieldClone(oldName, newName, obj):
File vdsm_api/vdsmapi-schema.json
Line 6694: #
Line 6695: # Since: 4.10.0
Line 6696: ##
Line 6697: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6698: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int' },
Done
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 3: * addressed comments * rename the new vdsClient verb to plural: setNumberOfCpu - setNumberOfCpus -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5840/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of legacy status 'Running'
Dan Kenigsberg has posted comments on this change. Change subject: Get rid of legacy status 'Running' .. Patch Set 1: Code-Review-1 (1 comment) I'd like to drop the 'Running' state, but such a change of API requires a comprehensive awareness about it. I suppose that even a release note for ovirt-3.4. Commit Message Line 6: Line 7: Get rid of legacy status 'Running' Line 8: Line 9: The status 'Running' means 'Up' for any case, now we get rid of it Line 10: completely as this is not helpful having two states for Up. This text is incomplete. 'Running' means 'Up and has an active guest agent', so it is not exactly the same thing. This deprecation requires a more thorough review. Are you sure that there are no supported Engines that expect the Running state? The master branch of Engine seems safe, but older versions should be checked too. What about command line scripts using vdsClient? Does any of them care about the difference? Such a change of API should be communicated to vdsm-devel and engine-devel lists. Line 11: Line 12: Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 -- To view, visit http://gerrit.ovirt.org/21766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Add force option to add brick command .. gluster: Add force option to add brick command Allows option to glusterfs to create brick directries under root partition. Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Signed-off-by: Timothy Asir tjeya...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21525 Reviewed-by: Bala.FA barum...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/cli.py M vdsm/gluster/vdsmapi-gluster-schema.json 4 files changed, 27 insertions(+), 9 deletions(-) Approvals: Timothy Asir: Verified Bala.FA: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Add force option to add brick command
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Add force option to add brick command .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907e3798d2a360cfcfd736d7cf9cb8f43c95ca10 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Kanagaraj M kmayi...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rescan multipath before loading lvm cache
Dan Kenigsberg has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache .. Patch Set 2: Code-Review-1 requires rebase -- To view, visit http://gerrit.ovirt.org/21567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report device to engine in a new fashion
Assaf Muller has posted comments on this change. Change subject: Report device to engine in a new fashion .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/21470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report device to engine in a new fashion
Dan Kenigsberg has submitted this change and it was merged. Change subject: Report device to engine in a new fashion .. Report device to engine in a new fashion Previously we were using the source IP of the socket to the engine and trying to extract the device out of that. The new approach is to simulate routing to the engine and get the device used to forward packets to the engine. Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21470 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py M lib/vdsm/netinfo.py M tests/functional/networkTests.py M tests/netinfoTests.py M vdsm/BindingXMLRPC.py 5 files changed, 36 insertions(+), 30 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icedb16c7f0bfccf05ffd2438e013e4894fda20da Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: refresh metadata on hsm when listing domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: refresh metadata on hsm when listing domains .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4951/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5841/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I095cd0760076fb4be97a776498af78a40ff84112 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4952/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5843/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove the getFormat method
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove the getFormat method .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4953/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5842/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb292ef57f94e1fea67f3111e5f414cc41c346a9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move reconnection info check to StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4954/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5844/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused recoveryMode from spmStart
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove unused recoveryMode from spmStart .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4955/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5845/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4be0a2aad270e87cf6a83f8b1fd36d928312104e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove scsiKey from connectStoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove scsiKey from connectStoragePool .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4956/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5846/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39c02f9256b1ef802ca4ec434a19aeecfea1f87a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: encapsulate spm status in StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: encapsulate spm status in StoragePool .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4957/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5847/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b71349e2a0dfc453b68cd2d9ca6c563b1bee90c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: add setMasterDomain to StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: add setMasterDomain to StoragePool .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4958/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5848/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99caffb6143d3a4fff16102c3b7c00616373e193 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: remove unused scsiFencing parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: remove unused scsiFencing parameter .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4959/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5849/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b62c08cf8925fbc1856655dc49dd41eacd2d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bootstrap: Return recovery error during lvm bootstrap
Nir Soffer has posted comments on this change.
Change subject: bootstrap: Return recovery error during lvm bootstrap
..
Patch Set 4:
(1 comment)
File vdsm/clientIF.py
Line 255: self.irs = None
Line 256: if config.getboolean('irs', 'irs_enable'):
Line 257: try:
Line 258: self.irs = Dispatcher(HSM())
Line 259: except:
Good idea! I will add this in a later patch.
Line 260: self.log.error(Error initializing IRS,
exc_info=True)
Line 261: else:
Line 262:
self.irs.registerDomainStateChangeCallback(self.contEIOVms)
Line 263:
--
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster: correct parameter for creating hookpath in verb hoo...
Yaniv Bronhaim has posted comments on this change. Change subject: gluster: correct parameter for creating hookpath in verb hookAdd. .. Patch Set 2: Code-Review+1 verified? please take care of rhev-3.3 ack on BZ 1028972 asap. thanks -- To view, visit http://gerrit.ovirt.org/21538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16885a7f837ccceede2cf1b70b5da3138a12a60 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Fix vm unpausing during recovery
Nir Soffer has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 2: Verified+1 Verified: - Paused vm are unpuased when starting vdsm - Start and stop vms - Create new vm, created disk, install os and run it -- To view, visit http://gerrit.ovirt.org/21782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of legacy status 'Running'
Martin Sivák has posted comments on this change.
Change subject: Get rid of legacy status 'Running'
..
Patch Set 1:
Athough I agree with Dan's reasoning, there is no trace of Running in
VALID_STATES or the documented API:
VALID_STATES = ('Down', 'Migration Destination', 'Migration Source',
'Paused', 'Powering down', 'RebootInProgress',
'Restoring state', 'Saving State',
'Up', 'WaitForLaunch')
##
# @VmStatus:
#
# An enumeration of possible virtual machine statuses.
#
# @Down: The VM is powered off
#
# @Migration Destination: The VM is migrating to this host
#
# @Migration Source: The VM is migrating away from this host
#
# @Paused: The VM is paused
#
# @Powering down: A shutdown command has been sent to the VM
#
# @RebootInProgress: The VM is currently rebooting
#
# @Restoring state:The VM is waking from hibernation
#
# @Saving State: The VM is preparing for hibernation
#
# @Up: The VM is running
#
# @WaitForLaunch: The VM is being created
#
# Since: 4.10.0
##
{'enum': 'VmStatus',
'data': ['Down', 'Migration Destination', 'Migration Source', 'Paused',
'Powering down', 'RebootInProgress', 'Restoring state',
'Saving State', 'Up', 'WaitForLaunch']}
So we either fix it in the documentation (and document the state as deprecated)
or in the code. Otherwise someone else will try hit it when trying to check for
the Up state.
--
To view, visit http://gerrit.ovirt.org/21766
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Fix vm unpausing during recovery
Yaniv Bronhaim has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 3: Verified+1 Nir verified it. -- To view, visit http://gerrit.ovirt.org/21782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Fix vm unpausing during recovery
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: Fix vm unpausing during recovery .. vm: Fix vm unpausing during recovery Domain monitor thread was not reporting when going from unknown state to known state. The thread would start with a bogus valid state, before checking the domain. If the first domain check found the domain as valid, no notification was emitted. If there were paused vms while connecting to the pool, they were not unpaused as they should. This patch fixes various modules: - Domain monitor status lastCheck is initialized now to special NOT_CHECKED_YET value. The monitor thread use this value to detect the first sample, and emit the missing notification. - To get the new event when monitor thread starts, domain state change callbacks are registered now *before* the monitor threads are started. - To get the vm unpause code to work in recovery mode, the Vm.sdIds is initialized in Vm._run. This probably fixes other issues with recovered vms. This is a backport of http://gerrit.ovirt.org/21649. Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Bug-Url: https://bugzilla.redhat.com/1003588 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21782 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/domainMonitor.py M vdsm/storage/hsm.py M vdsm/vm.py 3 files changed, 19 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: Fix vm unpausing during recovery
Yaniv Bronhaim has posted comments on this change. Change subject: vm: Fix vm unpausing during recovery .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c468edb967de5bcf15259029ace84333fc4b7e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of legacy status 'Running'
Martin Sivák has posted comments on this change. Change subject: Get rid of legacy status 'Running' .. Patch Set 1: For the reason behind this last-minute change see the related hosted-engine bug https://bugzilla.redhat.com/show_bug.cgi?id=1034787 as it was caused by us believing in the documented API... -- To view, visit http://gerrit.ovirt.org/21766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
oVirt Jenkins CI Server has posted comments on this change. Change subject: use defined options from configure .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4960/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5850/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Adding [start|stop]MonitoringDomain().
Yaniv Bronhaim has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 3: -Verified -- To view, visit http://gerrit.ovirt.org/20194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: package: allow redefine user and group as configure options
oVirt Jenkins CI Server has posted comments on this change. Change subject: package: allow redefine user and group as configure options .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4961/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5851/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6033f2450551600ec172523ab038fdf157176a8f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
what about creating /var/log/core if not exist? .. is it required?
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: package: allow redefine user and group as configure options
Alon Bar-Lev has posted comments on this change.
Change subject: package: allow redefine user and group as configure options
..
Patch Set 2:
(3 comments)
File configure.ac
Line 116: default_vdsm_group=kvm
Line 117: default_metadata_user=vdsm
Line 118: default_metadata_group=kvm
Line 119: default_qemu_user=qemu
Line 120: default_qemu_group=qemu
you don't need these.
Line 121:
Line 122: if grep -i ubuntu /etc/*-release; then
Line 123: default_qemu_user=libvirt-qemu
Line 124: default_qemu_group=kvm
Line 121:
Line 122: if grep -i ubuntu /etc/*-release; then
Line 123: default_qemu_user=libvirt-qemu
Line 124: default_qemu_group=kvm
Line 125: fi
distro specific using this kind will not support building on different host nor
cross compile.
the ubuntu packaging should provide proper setting.
Line 126:
Line 127: AC_ARG_WITH([vdsm-user],
Line 128: AC_HELP_STRING([--with-vdsm-user],
Line 129: [username to run vdsm daemon as @:@default=platform
dependent@:@]),
Line 127: AC_ARG_WITH([vdsm-user],
Line 128: AC_HELP_STRING([--with-vdsm-user],
Line 129: [username to run vdsm daemon as @:@default=platform
dependent@:@]),
Line 130: [VDSMUSER=${withval}],
Line 131: [VDSMUSER=${default_vdsm_user}])
well, while you are at it... consider:
AC_ARG_WITH(
[vdsm-user],
AC_HELP_STRING([--with-vdsm-user], [bla bla]),
,
[with_vdsm_user=vdsm],
]
this will result in with_vdsm_user to be whatever specified or default. then
you can use this to add substitutions later.
AC_SUBST([VDSMUSER], [${with_vdsm_user}])
let's say you want to have conditionals... so you have a test to detect
distribution:
AC_MSG_CHECKING([distribution])
DISTRIBUTION=whatever based on tests
AC_MSG_RESULT([${DISTRIBUTION}])
then:
AC_ARG_WITH(
[vdsm-user],
AC_HELP_STRING([--with-vdsm-user], [bla bla]),
,
[
case ${DISTRIBUTION} in
ubuntu) with_vdsm_user=vdsmd ;;
*) with_vdsm_user=vdsm ;;
esac
],
]
Line 132: AC_ARG_WITH([vdsm-group],
Line 133: AC_HELP_STRING([--with-vdsm-group],
Line 134: [groupname to run vdsm daemon as @:@default=platform
dependent@:@]),
Line 135: [VDSMGROUP=${withval}],
--
To view, visit http://gerrit.ovirt.org/18703
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6033f2450551600ec172523ab038fdf157176a8f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of legacy status 'Running'
Michal Skrivanek has posted comments on this change. Change subject: Get rid of legacy status 'Running' .. Patch Set 1: I also think this should be removed immediately. It was not documented and in any case you would have to check for Up and Running already, as it could return either of these two on unpredictable basis (if you play with guest agent inside the VM) -- To view, visit http://gerrit.ovirt.org/21766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4962/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5852/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
mooli tayer has posted comments on this change.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 643: /etc/sysctl.conf
Line 644: fi
Line 645:
Line 646: # hack until we replace core dump with abrt
Line 647: /usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
I tested this and only restorecon complained.
Line 648: /sbin/restorecon -R -v /var/log
Line 649:
Line 650: %if 0%{?rhel}
Line 651: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0d14193d9306944649d7ab0ee19edf2ca29ae7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Get rid of legacy status 'Running'
Michal Skrivanek has posted comments on this change. Change subject: Get rid of legacy status 'Running' .. Patch Set 1: (1 comment) Commit Message Line 6: Line 7: Get rid of legacy status 'Running' Line 8: Line 9: The status 'Running' means 'Up' for any case, now we get rid of it Line 10: completely as this is not helpful having two states for Up. well, not really, in corner cases like migration or manual agent stop you will end up with misleading information if you presume the above. Engine since 3.0 has a workaround code to just handle Running in addition (overwriting it to Up), so we're safe there. Other clients - well, tests are using it because they hit it first. Other than that it doesn't really matter, everyone had to deal with both states already Line 11: Line 12: Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 -- To view, visit http://gerrit.ovirt.org/21766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3c6e66365fe02158e5a7bb8db56c724b612b366 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
mooli tayer has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4: Code-Review+1
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
Sorry a bit busy. Two issue:
1.) a problem with my original patch - If the dir does not exist
restorecon will complain. not sure it is related to this patch.
2.) if user installs at point a then selinux enables at point b
he will not have selinux permissions.
for now I'm giving +1.
In the long run i'm think we should do what Dan wanted
and replace with abrt.
I hope to get back to it next week and will appreciate help
If someone feels like joining in;
http://gerrit.ovirt.org/#/c/20751/
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: add gluster dependency conditionally
Dan Kenigsberg has posted comments on this change. Change subject: build: add gluster dependency conditionally .. Patch Set 1: Code-Review-1 How is it going to work with the requirement of http://gerrit.ovirt.org/10200 for 3.4.1? -- To view, visit http://gerrit.ovirt.org/21705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib61b9acb8aa4e842dfc133c48811a6a6b43e025e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA barum...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Vijay Bellur vbel...@gmail.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: conditional to execute semanage
..
Patch Set 4:
(1 comment)
File vdsm.spec.in
Line 657: # hack until we replace core dump with abrt
Line 658: if /usr/sbin/selinuxenabled; then
Line 659: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 660: fi
Line 661: /sbin/restorecon -R -v /var/log/core
Thanks for the catch Yaniv but there is a different patch to address this
different problem: http://gerrit.ovirt.org/21290
Line 662: # hack until we replace core dump with abrt
Line 663:
Line 664: %if 0%{?rhel}
Line 665: if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Bala.FA has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Bala.FA has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: -Verified -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: define rollback contract at internal API
Assaf Muller has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 2: Code-Review-1 Had an off-line review session with Toni. Currently the design allows an infinite loop of setupNetworks involving vdsm-restore-net-config. One possible fix is to change 'inRollback' to a sort of an enum that will tell you what 'kind' of rollback you're performing, so that if a rollback to the persistent configuration fails then we stop trying to rollback and accept defeat. -- To view, visit http://gerrit.ovirt.org/21702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29c9411ce3f1ede6557c529bb4d984f74ed8f8ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to execute semanage
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: conditional to execute semanage .. vdsm.spec: conditional to execute semanage To avoid load policy when selinux is disabled, only execute semanage when selinux is enabled. Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21432 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: mooli tayer mta...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Hello Yaniv Bronhaim, mooli tayer, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21830
to review the following change.
Change subject: vdsm.spec: conditional to execute semanage
..
vdsm.spec: conditional to execute semanage
To avoid load policy when selinux is disabled, only
execute semanage when selinux is enabled.
Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21432
Reviewed-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-by: mooli tayer mta...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm.spec.in
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/21830/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 08119d9..147bf3f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -649,8 +649,11 @@
fi
# hack until we replace core dump with abrt
-/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
+if /usr/sbin/selinuxenabled; then
+/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
+fi
/sbin/restorecon -R -v /var/log/core
+# hack until we replace core dump with abrt
%if 0%{?rhel}
if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Dan Kenigsberg has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 1: Code-Review-1 (1 comment) http://mirror.centos.org/centos-6/6.4/updates/x86_64/Packages/selinux-policy-3.7.19-195.el6_4.13.noarch.rpm is out, but the patch is not good. File vdsm.spec.in Line 155: Requires: initscripts = 9.03.31-2.el6_3.1 Line 156: Requires: policycoreutils = 2.0.83-19.30 Line 157: Requires: policycoreutils-python = 2.0.83-19.30 Line 158: Requires: python-pthreading Line 159: Requires: selinux-policy-targeted = 3.7.19-195.el6.13 that should be 3.7.19-195.el6_5.13 Line 160: Requires: lvm2 = 2.02.95-10.el6_3.2 Line 161: Requires: logrotate 3.8.0 Line 162: %endif Line 163: %else -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/299/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/300/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage.glusterVolume.getVmVolInfo: move logic to storage do...
Dan Kenigsberg has abandoned this change. Change subject: storage.glusterVolume.getVmVolInfo: move logic to storage domain .. Abandoned a proper solution for this breakage should include reporting the gluster-native parameter per chain element, not only per the link. -- To view, visit http://gerrit.ovirt.org/21122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I05352ee60546f03b8e6272abbdd923d0ec6074b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: prepareImage: decommission volType from gluster info
Dan Kenigsberg has abandoned this change. Change subject: prepareImage: decommission volType from gluster info .. Abandoned a proper solution for this breakage should include reporting the gluster-native parameter per chain element, not only per the link. -- To view, visit http://gerrit.ovirt.org/21123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I720b4b145e63899584e601d01fd423eb016583e4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: decommission GlusterVolume
Dan Kenigsberg has abandoned this change. Change subject: gluster: decommission GlusterVolume .. Abandoned a proper solution for this breakage should include reporting the gluster-native parameter per chain element, not only per the link. -- To view, visit http://gerrit.ovirt.org/21124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id023ad3b4c2d6852d1b6b5ce8fdec707524553bc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/301/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Ayal Baron has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 2726: # getSharedLock(connectionsResource...) Line 2727: Line 2728: vars.task.getSharedLock(STORAGE, sdUUID) Line 2729: info = dom.getInfo() Line 2730: # This only occurred because someone As far as I can see engine never read this part of the info. As you wrote in the commit message, getStorageDomainInfo should not return pool info. I could not agree more. Pending a bit testing, I see no reason why not to just delete lines 2730 - 2767 here (everything regarding the pool). Line 2731: # thought it would be clever to return pool Line 2732: # information in the domain.getInfo() method Line 2733: # In a perfect world I would have just stopped Line 2734: # giving this information in the response. -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Aharon Canan aharo...@gmail.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Yaniv Bronhaim has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
Yeela Kaplan has uploaded a new change for review. Change subject: clientIF: Fix use of getConfDevices .. clientIF: Fix use of getConfDevices getConfDevices was merged into buildConfDevices Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Signed-off-by: Yeela Kaplan ykap...@redhat.com --- M vdsm/clientIF.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/21832/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index 0b67e45..dd939f8 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -455,7 +455,7 @@ # Do not prepare volumes when system goes down if self._enabled: vmObj.preparePaths( -vmObj.getConfDevices()[vm.DISK_DEVICES]) +vmObj.buildConfDevices()[vm.DISK_DEVICES]) except: self.log.error(Vm %s recovery failed, vmId, exc_info=True) -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Douglas Schilling Landgraf has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Fix use of getConfDevices .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4963/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5853/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Federico Simoncelli has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: Code-Review-1 (1 comment) Commit Message Line 12: directly the pool MD for any MSD. Line 13: This changes the previous behaviour. Line 14: Line 15: TODO: pool related information should not be returned as part of Line 16: this API response. I also prefer to return the pool-related info only on the connected pool master. It seems easier, it would respect the current api and it would prevent the use of StoragePool internals from hsm.py. Line 17: Line 18: Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Aharon Canan aharo...@gmail.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Fix use of getConfDevices
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Fix use of getConfDevices .. Patch Set 1: (1 comment) Commit Message Line 5: CommitDate: 2013-11-28 15:30:29 +0200 Line 6: Line 7: clientIF: Fix use of getConfDevices Line 8: Line 9: getConfDevices was merged into buildConfDevices who's to blame (except the reviewer)? in which commit? When is this visible? it is important to learn a lesson here. Line 10: Line 11: Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e -- To view, visit http://gerrit.ovirt.org/21832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9776e1237f6799dfccd5ff3edf197c5bf32f5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Douglas Schilling Landgraf has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 2: Code-Review+2 same as in master. -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/302/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix selinux dependency .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4964/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5854/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/303/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec: conditional for hostname require .. vdsm.spec: conditional for hostname require Fedora rawhide (F21) build is failing because cannot locate /bin/hostname. It has changed to /usr/bin/hostname as changelog from hostname 3.14-2. Koji info: http://koji.fedoraproject.org/koji/buildinfo?buildID=471302 Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21194 Reviewed-by: Bala.FA barum...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M .gitignore M configure.ac M vdsm.spec.in M vdsm/gluster/Makefile.am R vdsm/gluster/hostname.py.in 5 files changed, 25 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Bala.FA: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 7: Code-Review+2 I do not understand your resentment for utils.CommandPath, but if Bala (the file owner) does not mind, I won't block this patch. -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getStorageDomainInfo: SP keys when disconnected.
Federico Simoncelli has posted comments on this change. Change subject: getStorageDomainInfo: SP keys when disconnected. .. Patch Set 2: (1 comment) File vdsm/storage/hsm.py Line 2726: # getSharedLock(connectionsResource...) Line 2727: Line 2728: vars.task.getSharedLock(STORAGE, sdUUID) Line 2729: info = dom.getInfo() Line 2730: # This only occurred because someone +1 to remove this all. Line 2731: # thought it would be clever to return pool Line 2732: # information in the domain.getInfo() method Line 2733: # In a perfect world I would have just stopped Line 2734: # giving this information in the response. -- To view, visit http://gerrit.ovirt.org/19555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b7323d4ccaaaec0f39d5590a06879faa7fc999e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Aharon Canan aharo...@gmail.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Revert fix premature selinux dependency .. Revert fix premature selinux dependency This reverts commit 6193dbe36d4d5e17a4c5342193e7f20d0bc8bc04 as selinux-policy-3.7.19-195.el6_4.13 is out. Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20760 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
Yaniv Bronhaim has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm.spec: conditional to execute semanage .. vdsm.spec: conditional to execute semanage To avoid load policy when selinux is disabled, only execute semanage when selinux is enabled. Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21830 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Revert fix premature selinux dependency
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert fix premature selinux dependency .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/304/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1a5225d9f3dde4fe7b394ed25408e29babc2f43 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Hello Doron Fediuck, Amador Pahim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21839
to review the following change.
Change subject: Allow setting just a single value in MoM policy
..
Allow setting just a single value in MoM policy
This patch prevents a policy coruption that could have happened
when the 01-parameters policy was updated with just a single
value. If there were more values defined, the variables were lost
and the policy ended up broken.
This patch defines the variables in a file that is not touched
by the setMOMPolicyParameters and uses (set name value) syntax
in the generated policy part.
It also remembers the old setting and puts all the values to
the policy part when it is autogenerated.
Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1025780
Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8
Signed-off-by: Martin Sivak msi...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21225
Reviewed-by: Amador Pahim apa...@redhat.com
Reviewed-by: Doron Fediuck dfedi...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M debian/vdsm.install
M vdsm/Makefile.am
A vdsm/mom.d/00-defines.policy
D vdsm/mom.d/00-python.policy
M vdsm/mom.d/01-parameters.policy
M vdsm/momIF.py
6 files changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/21839/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index 6de089e..89b6e6c 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -14,7 +14,7 @@
./etc/sysctl.d/vdsm.conf
./etc/vdsm/logger.conf
./etc/vdsm/mom.conf
-./etc/vdsm/mom.d/00-python.policy
+./etc/vdsm/mom.d/00-defines.policy
./etc/vdsm/mom.d/01-parameters.policy
./etc/vdsm/mom.d/02-balloon.policy
./etc/vdsm/mom.d/03-ksm.policy
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 26be4dc..5ab291e 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -110,7 +110,7 @@
logger.conf.in \
mk_sysprep_floppy.in \
mom.conf.in \
- mom.d/00-python.policy \
+ mom.d/00-defines.policy \
mom.d/01-parameters.policy \
mom.d/02-balloon.policy \
mom.d/03-ksm.policy \
diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy
new file mode 100644
index 000..93b70ee
--- /dev/null
+++ b/vdsm/mom.d/00-defines.policy
@@ -0,0 +1,9 @@
+# This file defines python constans that make it easier to convert data
+# received by setMOMPolicyParameters
+(defvar False 0)
+(defvar True 1)
+
+# Define variables for configurable options here
+(defvar ksmEnabled 1)
+(defvar balloonEnabled 0)
+
diff --git a/vdsm/mom.d/00-python.policy b/vdsm/mom.d/00-python.policy
deleted file mode 100644
index face6fa..000
--- a/vdsm/mom.d/00-python.policy
+++ /dev/null
@@ -1,4 +0,0 @@
-# This file defines python constans that make it easier to convert data
-# received by setMOMPolicyParameters
-(defvar False 0)
-(defvar True 1)
diff --git a/vdsm/mom.d/01-parameters.policy b/vdsm/mom.d/01-parameters.policy
index 980e71c..e69de29 100644
--- a/vdsm/mom.d/01-parameters.policy
+++ b/vdsm/mom.d/01-parameters.policy
@@ -1 +0,0 @@
-(defvar balloonEnabled 0)
diff --git a/vdsm/momIF.py b/vdsm/momIF.py
index 8b62657..c1e00ef 100644
--- a/vdsm/momIF.py
+++ b/vdsm/momIF.py
@@ -46,6 +46,7 @@
self.log = logging.getLogger(MOM)
self.log.info(Starting up MOM)
self._mom = mom.MOM(momconf)
+self._policy = {}
threading.Thread.__init__(self, target=self._mom.run, name=MOM)
self.start()
@@ -64,14 +65,16 @@
def setPolicyParameters(self, key_value_store):
# mom.setNamedPolicy will raise an exception on failure.
+
# Prepare in-memory policy file with tuning variables
# this might need to convert certain python types to proper MoM
# policy language
+self._policy.update(key_value_store)
-# Python bool values are defined in 00-python.policy so need no
+# Python bool values are defined in 00-defines.policy so need no
# conversion here
-policy_string = \n.join([(defvar %s %r) % (k, v)
- for k, v in key_value_store.iteritems()])
+policy_string = \n.join([(set %s %r) % (k, v)
+ for k, v in self._policy.iteritems()])
self._mom.setNamedPolicy(config.get(mom, tuning_policy),
policy_string)
--
To view, visit http://gerrit.ovirt.org/21839
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/305/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Martin Sivák has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Reorder limit checks in grow quest
Martin Sivák has posted comments on this change. Change subject: Reorder limit checks in grow quest .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a8d19f7fe66bb98d97718da34ec2bad6f7987f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional for hostname require
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/56/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional to execute semanage
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional to execute semanage .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/306/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional for hostname require
Hello Bala.FA, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21840
to review the following change.
Change subject: vdsm.spec: conditional for hostname require
..
vdsm.spec: conditional for hostname require
Fedora rawhide (F21) build is failing because cannot locate /bin/hostname.
It has changed to /usr/bin/hostname as changelog from hostname 3.14-2.
Koji info:
http://koji.fedoraproject.org/koji/buildinfo?buildID=471302
Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21194
Reviewed-by: Bala.FA barum...@redhat.com
Reviewed-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M .gitignore
M configure.ac
M vdsm.spec.in
M vdsm/gluster/Makefile.am
R vdsm/gluster/hostname.py.in
5 files changed, 25 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/21840/1
diff --git a/.gitignore b/.gitignore
index 295e1fb..ab5fa96 100644
--- a/.gitignore
+++ b/.gitignore
@@ -65,6 +65,7 @@
vdsm/vdsm-store-net-config
vdsm/vdsm.rwtab
vdsm/vdsmd.8
+vdsm/gluster/hostname.py
vdsm_api/vdsm-api.html
vdsm_hooks/openstacknet/sudoers
vdsm_hooks/persist-vdsm-hooks
diff --git a/configure.ac b/configure.ac
index fac9755..52105e9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -199,6 +199,7 @@
AC_PATH_PROG([FUSER_PATH], [fuser], [/sbin/fuser])
AC_PATH_PROG([GREP_PATH], [grep], [/bin/grep])
AC_PATH_PROG([GRUBBY_PATH], [grubby], [/sbin/grubby])
+AC_PATH_PROG([HOSTNAME_PATH], [hostname], [/usr/bin/hostname])
AC_PATH_PROG([HWCLOCK_PATH], [hwclock], [/usr/sbin/hwclock])
AC_PATH_PROG([IFDOWN_PATH], [ifdown], [/sbin/ifdown])
AC_PATH_PROG([IFUP_PATH], [ifup], [/sbin/ifup])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0bb73b1..00f8c70 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -220,7 +220,13 @@
Requires: pyparted
Requires(post): /usr/sbin/saslpasswd2
+
+%if 0%{?fedora} 0%{?fedora} = 21
+Requires(post): hostname
+%else
Requires(post): /bin/hostname
+%endif
+
Requires(post): policycoreutils-python
Requires(preun): policycoreutils-python
diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am
index dd5434d..ea36692 100644
--- a/vdsm/gluster/Makefile.am
+++ b/vdsm/gluster/Makefile.am
@@ -21,16 +21,31 @@
include $(top_srcdir)/build-aux/Makefile.subs
vdsmglusterdir = $(vdsmdir)/gluster
+
+nodist_vdsmgluster_PYTHON = \
+ hostname.py
+ $(NULL)
+
dist_vdsmgluster_PYTHON = \
__init__.py \
api.py \
cli.py \
exception.py \
hooks.py \
- hostname.py \
services.py \
$(NULL)
dist_vdsmgluster_DATA = \
vdsmapi-gluster-schema.json \
$(NULL)
+
+EXTRA_DIST = \
+ hostname.py.in
+ $(NULL)
+
+CLEANFILES = \
+ hostname.py
+ $(NULL)
+
+all-local: \
+ $(nodist_vdsmgluster_PYTHON)
diff --git a/vdsm/gluster/hostname.py b/vdsm/gluster/hostname.py.in
similarity index 83%
rename from vdsm/gluster/hostname.py
rename to vdsm/gluster/hostname.py.in
index ffcf6c2..c817b0a 100644
--- a/vdsm/gluster/hostname.py
+++ b/vdsm/gluster/hostname.py.in
@@ -20,10 +20,6 @@
from vdsm import utils
-_hostNameCommandPath = utils.CommandPath(hostname,
- /bin/hostname,
- )
-
class HostNameException(Exception):
def __init__(self, rc):
@@ -35,7 +31,7 @@
def getHostNameFqdn():
-rc, out, err = utils.execCmd([_hostNameCommandPath.cmd, '--fqdn'])
+rc, out, err = utils.execCmd(['@HOSTNAME_PATH@', '--fqdn'])
if rc:
raise HostNameException(rc)
else:
--
To view, visit http://gerrit.ovirt.org/21840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional for hostname require
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional for hostname require
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/307/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: differentiate between MEMORY and PERSISTENT rollback
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback
..
netconf: differentiate between MEMORY and PERSISTENT rollback
The change:
netconf: Add limit to rollback for recursive configurator
Added a last resort to the rollback that consists on rolling back to
the last persisted configuration. That however meant that an eventual
failure in the setupNetworks commands issued in
vdsm-restore-net-config would be attempted to rollback, probably
going also for the last restort, effectively making this a probably
infinite loop.
This patch addresses the issue by marking vdsm-restore-net-config
setupNetworks commands as PERSISTENT_ROLLBACK and qualifying thusly
marked rollback operations as final.
Change-Id: Ib841d5c431bb64574398d41ad34aed32c734e03c
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/configNetwork.py
M vdsm/netconf/__init__.py
M vdsm/vdsm-restore-net-config
3 files changed, 25 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/21841/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 3afcb4e..21a49c7 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -537,7 +537,8 @@
force=0|1
connectivityCheck=0|1
connectivityTimeout=int
-inRollback=True|False
+inRollback=None|netconf.MEMORY_ROLLBACK|
+ netconf.PERSISTENT_ROLLBACK
Notes:
When you edit a network that is attached to a bonding, it's not
@@ -561,7 +562,7 @@
hooks.before_network_setup()
logger.debug(Applying...)
-with Ifcfg(options.get('inRollback', False)) as configurator:
+with Ifcfg(options.get('inRollback')) as configurator:
libvirt_nets = netinfo.networks()
# Remove edited networks and networks with 'remove' attribute
for network, networkAttrs in networks.items():
diff --git a/vdsm/netconf/__init__.py b/vdsm/netconf/__init__.py
index 50934a5..233bd13 100644
--- a/vdsm/netconf/__init__.py
+++ b/vdsm/netconf/__init__.py
@@ -24,13 +24,19 @@
from sourceRoute import StaticSourceRoute
from vdsm import netinfo
from vdsm.config import config
-from vdsm.constants import EXT_VDSM_RESTORE_NET_CONFIG
from vdsm.netconfpersistence import RunningConfig
-from vdsm.utils import execCmd
+from vdsm.tools import restore_nets
+
+PERSISTENT_ROLLBACK = 1
+MEMORY_ROLLBACK = 2
+
+
+class RollbackIncomplete(Exception):
+pass
class Configurator(object):
-def __init__(self, configApplier, inRollback=False):
+def __init__(self, configApplier, inRollback=None):
self.configApplier = configApplier
self._inRollback = inRollback
self._libvirtAdded = set()
@@ -46,13 +52,18 @@
def __exit__(self, type, value, traceback):
if type is None:
self.commit()
-elif self._inRollback:
+elif self._inRollback == MEMORY_ROLLBACK:
# If we failed the rollback transaction, we try to apply the last
# known good network configuration, i.e., last persistent.
-rc, _, err = execCmd(EXT_VDSM_RESTORE_NET_CONFIG, raw=True)
-if not rc:
+try:
+restore_nets.restore()
+except Exception as err:
logging.error('Failed rollback transaction and restoration to '
'last known good network. ERR=%s', err)
+elif self._inRollback == PERSISTENT_ROLLBACK:
+# If we are trying to rollback from a persistent rollback
+# transaction we should just give up and fail.
+logging.error('Failed persistent rollback transaction.')
else:
self.rollback()
diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config
index 29b2a8d..46c1d62 100755
--- a/vdsm/vdsm-restore-net-config
+++ b/vdsm/vdsm-restore-net-config
@@ -22,7 +22,7 @@
import logging
import logging.config
-from netconf import ifcfg
+from netconf import ifcfg, PERSISTENT_ROLLBACK
from vdsm.config import config
from vdsm.netconfpersistence import RunningConfig, PersistentConfig
from configNetwork import setupNetworks
@@ -48,7 +48,8 @@
removeBonds[bond] = {'remove': True}
logging.debug('Removing all networks (%s) and bonds (%s) in running '
'config.', removeNetworks, removeBonds)
-setupNetworks(removeNetworks, removeBonds, connectivityCheck=False)
+setupNetworks(removeNetworks, removeBonds, connectivityCheck=False,
+ inRollback=PERSISTENT_ROLLBACK)
configurator.flush()
persistentConfig = PersistentConfig()
@@ -56,7 +57,8 @@
bonds = persistentConfig.bonds
logging.debug('Calling setupNetworks with networks (%s) and bond (%s).',
Change in vdsm[master]: netconf: differentiate between MEMORY and PERSISTENT rollback
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4965/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5855/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/904/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib841d5c431bb64574398d41ad34aed32c734e03c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: differentiate between MEMORY and PERSISTENT rollback
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: differentiate between MEMORY and PERSISTENT rollback .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4966/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5856/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/905/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib841d5c431bb64574398d41ad34aed32c734e03c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix selinux dependency
Douglas Schilling Landgraf has posted comments on this change. Change subject: fix selinux dependency .. Patch Set 2: Verified+1 Code-Review+1 Affecting: http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/label=centos64/56/console -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix selinux dependency
Nir Soffer has posted comments on this change. Change subject: fix selinux dependency .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627deb840d2351b48c19eb7d17f26f9ba9f54566 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ohad Basan oba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional for hostname require
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: conditional for hostname require .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: conditional for hostname require
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm.spec: conditional for hostname require .. vdsm.spec: conditional for hostname require Fedora rawhide (F21) build is failing because cannot locate /bin/hostname. It has changed to /usr/bin/hostname as changelog from hostname 3.14-2. Koji info: http://koji.fedoraproject.org/koji/buildinfo?buildID=471302 Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21194 Reviewed-by: Bala.FA barum...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21840 --- M .gitignore M configure.ac M vdsm.spec.in M vdsm/gluster/Makefile.am R vdsm/gluster/hostname.py.in 5 files changed, 25 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I865d1b84fe646932d3039b131bc236d36b8550ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: provide a default rollback for configurators
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: provide a default rollback for configurators .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4969/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5859/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/907/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I267e7d682e5075695fbc16fd45b241c4137296da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: define rollback contract at internal API
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: define rollback contract at internal API .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4968/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5858/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/908/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29c9411ce3f1ede6557c529bb4d984f74ed8f8ad Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
