Change in vdsm[ovirt-3.3]: vdsm.spec: Remove Obsoletes: python-cpopen
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm.spec: Remove Obsoletes: python-cpopen .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5523c3530cbac667ce5c7db4f78543f21778c54 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: Remove Obsoletes: python-cpopen
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vdsm.spec: Remove Obsoletes: python-cpopen .. vdsm.spec: Remove Obsoletes: python-cpopen python-cpopen spec obsoletes vdsm-python-cpopen, so vdsm.spec don't need to obsolete python-cpopen. Otherwise, it will generate an infinity loop during the yum update between these packages. Change-Id: If5523c3530cbac667ce5c7db4f78543f21778c54 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22113 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5523c3530cbac667ce5c7db4f78543f21778c54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: Remove Obsoletes: python-cpopen
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Remove Obsoletes: python-cpopen .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/318/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5523c3530cbac667ce5c7db4f78543f21778c54 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vdsm.spec: Remove Obsoletes: python-cpopen
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: Remove Obsoletes: python-cpopen .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/319/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5523c3530cbac667ce5c7db4f78543f21778c54 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add an exception for wrong master version.
Sergey Gotliv has posted comments on this change. Change subject: vdsm: Add an exception for wrong master version. .. Patch Set 3: (1 comment) File vdsm/storage/storage_exception.py Line 609: code = 330 Line 610: message = Cannot get file stats Line 611: Line 612: Line 613: class StoragePoolWrongVersion(StorageException): We are working to remove pool in 3.4, I am wondering if its really necessary to add new pool related exception at this phase. I am fine with the code once you verified that the current engine without any additional change will survive that exception. Line 614: def __init__(self, spUUID, sdUUID): Line 615: self.value = SD=%s, pool=%s % (sdUUID, spUUID) Line 616: code = 331 Line 617: message = Wrong Master version -- To view, visit http://gerrit.ovirt.org/21175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: extnet: attach a vNIC to a libvirt network defined out...
Dan Kenigsberg has posted comments on this change. Change subject: hook: extnet: attach a vNIC to a libvirt network defined outside oVirt .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/22124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70bc74a9ac4a6eb88d089baa86918275c61f5190 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: extnet: attach a vNIC to a libvirt network defined out...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hook: extnet: attach a vNIC to a libvirt network defined outside oVirt .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5978/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5182/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6070/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/106/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70bc74a9ac4a6eb88d089baa86918275c61f5190 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Yaniv Bronhaim has uploaded a new change for review. Change subject: sanlock isconfigured raises an exception instead of returning result .. sanlock isconfigured raises an exception instead of returning result isconfigured calls expect boolean as return value. Exception should be raised only on critical failures such as sanlock service isn't installed, or sanlock group does not exist. Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/22184/1 diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index 51eda80..83bdb22 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -141,6 +141,7 @@ Return 0 if sanlock service requires a restart to reload the relevant supplementary groups. +_isconfigured = True proc_status_group_prefix = Groups:\t try: with open(/var/run/sanlock/sanlock.pid, r) as f: @@ -158,15 +159,18 @@ except IOError as e: if e.errno == os.errno.ENOENT: -raise RuntimeError(sanlock service is not running) -raise +sys.stdout.write(sanlock service is not running) +_isconfigured = False +else: +raise diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] if diskimage_gid not in groups: -raise RuntimeError(sanlock service requires restart) +sys.stdout.write(sanlock service requires restart\n) +_isconfigured = False sys.stdout.write(sanlock service is already configured\n) -return True +return _isconfigured __configurers = ( -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Yaniv Bronhaim has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 1: Verified+1 (1 comment) File lib/vdsm/tool/configurator.py Line 158: raise RuntimeError(Unable to find sanlock service groups) Line 159: Line 160: except IOError as e: Line 161: if e.errno == os.errno.ENOENT: Line 162: sys.stdout.write(sanlock service is not running) I'll add \n next ps. waiting for other comments Line 163: _isconfigured = False Line 164: else: Line 165: raise Line 166: -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5979/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5183/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6071/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Alon Bar-Lev has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 1: (1 comment) File lib/vdsm/tool/configurator.py Line 159: Line 160: except IOError as e: Line 161: if e.errno == os.errno.ENOENT: Line 162: sys.stdout.write(sanlock service is not running) Line 163: _isconfigured = False it is configured if not running, right? Line 164: else: Line 165: raise Line 166: Line 167: diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long during migrations
Vinzenz Feenstra has posted comments on this change. Change subject: Avoid going into 'Paused' status during long during migrations .. Patch Set 3: (1 comment) Commit Message Line 3: AuthorDate: 2013-12-03 15:26:18 +0100 Line 4: Commit: Vinzenz Feenstra vfeen...@redhat.com Line 5: CommitDate: 2013-12-06 10:20:25 +0100 Line 6: Line 7: Avoid going into 'Paused' status during long during migrations It's during a migration with a long duration, I will reformulate it though Line 8: Line 9: If a migration is taking longer than 'migration_timeout' the Line 10: migration is moving into 'Paused' state. Line 11: We increased the timeout to 6 hours as an absolute maximum for -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Dan Kenigsberg has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 1: (1 comment) File lib/vdsm/tool/configurator.py Line 137: raise RuntimeError(Failed to perform sanlock config.) Line 138: Line 139: def isconfigured(self, *args): Line 140: Line 141: Return 0 if sanlock service requires a restart to reload the relevant the doc says 0, the code says False. Confusing. Line 142: supplementary groups. Line 143: Line 144: _isconfigured = True Line 145: proc_status_group_prefix = Groups:\t -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid going into 'Paused' status during long lasting migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid going into 'Paused' status during long lasting migrations .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5980/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5184/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6072/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb1c9ae7ead92093c0d300df7c3567ab20b1e09 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Martin Sivák has restored this change. Change subject: Allow setting just a single value in MoM policy .. Restored It turns out this won't be DS only change.. -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
Humble Devassy Chirammal has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 2:
(4 comments)
File vdsm.spec.in
Line 535:
Line 536: %description hook-spiceoptions
Line 537: This vdsm hook can be used to configure some of
Line 538: the spice optimization attributes and values..
Line 539:
Done
Line 540: %package hook-vmfex
Line 541: Summary:vmfex support for VDSM
Line 542: BuildArch: noarch
Line 543:
Line 1236:
Line 1237:
Line 1238: %files hook-spiceoptions
Line 1239: %defattr(-, root, root, -)
Line 1240: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/60_spiceoptions
Done
Line 1241:
Line 1242: %files hook-vmdisk
Line 1243: %defattr(-, root, root, -)
Line 1244: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vmdisk
File vdsm_hooks/Makefile.am
Line 40:qos \
Line 41:scratchpad \
Line 42:smbios \
Line 43:sriov \
Line 44:spiceoptions \
Done
Line 45:vmdisk \
Line 46:vmfex
Line 47: endif
Line 48:
File vdsm_hooks/spiceoptions/README
Line 43:spiceoptions={'image': {'compression': 'auto_glz'},
Line 44: 'jpeg': {'compressions': 'never'},
Line 45: 'streaming':{'mode':'filter'},
Line 46: 'clipboard':{'copypaste':'yes'}}..etc
Line 47:
Done
Line 48:
Line 49: Installation:
Line 50: * Use the engine-config to append the appropriate custom property as
such:
Line 51:sudo engine-config -s UserDefinedVMProperties=
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: hook: spiceoptions: To provide spice option attributes to vm .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5981/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5185/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6073/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/107/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow disable MOM KSM control.
Amador Pahim has posted comments on this change. Change subject: Allow disable MOM KSM control. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc4333ce92561e23c062c398e24f876a74056a05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Sandro Bonazzola has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow disable MOM KSM control.
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Allow disable MOM KSM control. .. Allow disable MOM KSM control. This patch add ksmEnabled var to enable/disable mom ksm control. Now users can use vdsClient to runtime disable/enable (default enabled) ksm control: $ vdsClient -s 0 setMOMPolicyParameters ksmEnabled=False Change-Id: Icc4333ce92561e23c062c398e24f876a74056a05 Bug-Url: http://bugzilla.redhat.com/1025780 Signed-off-by: Amador Pahim apa...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20879 Reviewed-by: Martin Sivák msi...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22150 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/mom.d/01-parameters.policy M vdsm/mom.d/03-ksm.policy 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc4333ce92561e23c062c398e24f876a74056a05 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow disable MOM KSM control.
Yaniv Bronhaim has posted comments on this change. Change subject: Allow disable MOM KSM control. .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc4333ce92561e23c062c398e24f876a74056a05 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Martin Polednik has uploaded a new change for review.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
tests: validate cdrom path sent to/received from vdsm
related to http://gerrit.ovirt.org/#/c/20074/
Tests prepareVolumePath for cdrom by verifying that path and
specParams['path'] remains unchanged during creation of VM
Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Signed-off-by: Martin Polednik mpole...@redhat.com
---
M tests/functional/utils.py
M tests/functional/virtTests.py
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/22194/1
diff --git a/tests/functional/utils.py b/tests/functional/utils.py
index 5713db3..8bdd978 100644
--- a/tests/functional/utils.py
+++ b/tests/functional/utils.py
@@ -210,6 +210,11 @@
else:
return result['status']['code'], result['status']['message']
+def getVmList(self, vmId):
+result = self.vdscli.list('true', [vmId])
+return result['status']['code'], result['status']['message'],\
+result['vmList'][0]
+
def getVdsCapabilities(self):
result = self.vdscli.getVdsCapabilities()
return result['status']['code'], result['status']['message'],\
diff --git a/tests/functional/virtTests.py b/tests/functional/virtTests.py
index bd54621..e799eb1 100644
--- a/tests/functional/virtTests.py
+++ b/tests/functional/virtTests.py
@@ -271,3 +271,39 @@
deviceDef['hotplugDisk']), timeout=10)
self.retryAssert(partial(self.vdsm.hotunplugDisk,
deviceDef['hotplugDisk']), timeout=10)
+
+@permutations([['self'], ['specParams'], ['both']])
+def testVmWithCdrom(self, pathLocation):
+fd, path = tempfile.mkstemp()
+os.chmod(path, 0o644)
+
+cdrom = {'index': '2', 'iface': 'ide', 'specParams':
+ {'path': ''}, 'readonly': 'true', 'path':
+ '', 'device': 'cdrom', 'shared':
+ 'false', 'type': 'disk'}
+
+if pathLocation == 'self':
+cdrom['path'] = path
+elif pathLocation == 'specParams':
+cdrom['specParams']['path'] = path
+else:
+# we can use the same path to avoid having to generate another
+# tmpfile
+cdrom['path'] = path
+cdrom['specParams']['path'] = path
+
+customization = {'vmId': '----',
+ 'vmName': 'testVm', 'devices': [cdrom]}
+
+with RunningVm(self.vdsm, customization) as vm:
+self._waitForStartup(vm, 10)
+
+status, msg, stats = self.vdsm.getVmList(vm)
+self.assertEqual(status, SUCCESS, msg)
+for device in stats['devices']:
+if device['device'] == 'cdrom':
+self.assertEqual(device['path'], cdrom['path'])
+self.assertEqual(device['specParams']['path'],
+ cdrom['specParams']['path'])
+
+os.unlink(path)
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
Martin Polednik has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 1: Verified+1 correctly detects failure without the fix applied / success with fix applied (also handles more general specParams['path']/path combinations to avoid regression) -- To view, visit http://gerrit.ovirt.org/22194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom
Martin Polednik has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 6: Test added in http://gerrit.ovirt.org/#/c/22194/ -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5982/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/985/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5186/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6074/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: drop remaining betterPopen references
Dan Kenigsberg has uploaded a new change for review. Change subject: janitorial: drop remaining betterPopen references .. janitorial: drop remaining betterPopen references betterPopen has been named cpopen long ago, and was spun off to an independent package. This patch clears the remaining references to the old vague name. Change-Id: Idba693ef181f948e0ac4a525326698ef96684318 Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/utils.py M lib/zombiereaper/tests.py M tests/Makefile.am M tests/README R tests/cPopenTests.py M vdsm/storage/remoteFileHandler.py 6 files changed, 25 insertions(+), 27 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/22195/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index d9c6cc5..d0f7b4f 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -53,7 +53,7 @@ import time import zombiereaper -from cpopen import CPopen as BetterPopen +from cpopen import CPopen from . import constants # Buffsize is 1K because I tested it on some use cases and 1k was fastets. If @@ -530,8 +530,8 @@ cmdline = repr(subprocess.list2cmdline(printable)) execCmdLogger.debug(%s (cwd %s), cmdline, cwd) -p = BetterPopen(command, close_fds=True, cwd=cwd, env=env, -deathSignal=deathSignal) +p = CPopen(command, close_fds=True, cwd=cwd, env=env, + deathSignal=deathSignal) p = AsyncProc(p) if not sync: if data is not None: diff --git a/lib/zombiereaper/tests.py b/lib/zombiereaper/tests.py index 3a85a11..425ac74 100644 --- a/lib/zombiereaper/tests.py +++ b/lib/zombiereaper/tests.py @@ -21,7 +21,7 @@ import os import zombiereaper -from cpopen import CPopen as BetterPopen +from cpopen import CPopen from unittest import TestCase @@ -30,7 +30,7 @@ class zombieReaperTests(TestCase): def testProcessDiesAfterBeingTracked(self): -p = BetterPopen([sleep, 1]) +p = CPopen([sleep, 1]) zombiereaper.autoReapPID(p.pid) # wait for the grim reaper to arrive sleep(4) @@ -39,7 +39,7 @@ self.assertRaises(OSError, os.waitpid, p.pid, os.WNOHANG) def testProcessDiedBeforeBeingTracked(self): -p = BetterPopen([sleep, 0]) +p = CPopen([sleep, 0]) # wait for the process to die sleep(1) diff --git a/tests/Makefile.am b/tests/Makefile.am index 435beca..2f9b1ae 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -25,7 +25,7 @@ test_modules = \ alignmentScanTests.py \ apiTests.py \ - betterPopenTests.py \ + cPopenTests.py \ capsTests.py \ configNetworkTests.py \ fileVolumeTests.py \ diff --git a/tests/README b/tests/README index e60389b..9e4d4b4 100644 --- a/tests/README +++ b/tests/README @@ -14,8 +14,8 @@ ./run_tests.sh *.py Individual files or test cases can be specified: -./run_tests.sh betterPopenTests.py -./run_tests.sh betterPopenTests.py:TestBetterPopen.testEcho +./run_tests.sh cPopenTests.py +./run_tests.sh cPopenTests.py:TestCPopen.testEcho Functional test suite: diff --git a/tests/betterPopenTests.py b/tests/cPopenTests.py similarity index 88% rename from tests/betterPopenTests.py rename to tests/cPopenTests.py index 7285877..a5c112b 100644 --- a/tests/betterPopenTests.py +++ b/tests/cPopenTests.py @@ -28,13 +28,13 @@ if __name__ != __main__: # This will not be available when we use this module as a subprocess -from cpopen import CPopen as BetterPopen +from cpopen import CPopen -class TestBetterPopen(TestCaseBase): +class TestCPopen(TestCaseBase): def testEcho(self): data = Hello -p = BetterPopen([EXT_ECHO, -n, data]) +p = CPopen([EXT_ECHO, -n, data]) p.wait() self.assertTrue(p.returncode == 0, Process failed: %s % os.strerror(p.returncode)) @@ -42,7 +42,7 @@ def testCat(self): path = /etc/passwd -p = BetterPopen([cat, path]) +p = CPopen([cat, path]) p.wait() self.assertTrue(p.returncode == 0, Process failed: %s % os.strerror(p.returncode)) @@ -50,8 +50,7 @@ self.assertEquals(p.stdout.read(), f.read()) def _subTest(self, name, params, *args, **kwargs): -p = BetterPopen([python, __file__, name] + params, -*args, **kwargs) +p = CPopen([python, __file__, name] + params, *args, **kwargs) p.wait() self.assertTrue(p.returncode == 0, Process failed: %s % os.strerror(p.returncode)) @@ -80,25 +79,24 @@ def testCwd(self): cwd = /proc -p = BetterPopen([python, -c, import os; print os.getcwd()], -cwd=cwd) +p = CPopen([python, -c, import os; print os.getcwd()], cwd=cwd) p.wait() self.assertTrue(p.returncode == 0,
Change in vdsm[master]: janitorial: drop remaining betterPopen references
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: drop remaining betterPopen references .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5983/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5187/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6075/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba693ef181f948e0ac4a525326698ef96684318 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Dan Kenigsberg has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 2: Code-Review+1 imo can get into 3.3.2. -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
Humble Devassy Chirammal has posted comments on this change. Change subject: hook: spiceoptions: To provide spice option attributes to vm .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Doron Fediuck has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Yaniv Bronhaim has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: extnet: attach a vNIC to a libvirt network defined out...
Humble Devassy Chirammal has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
Patch Set 4: Code-Review-1
(2 comments)
File vdsm_hooks/extnet/README
Line 15: Usage:
Line 16: Define a vNIC profile and set one of its custom properites to extnet
with
Line 17: the value of the name of a libvirt network that is managed outside of
oVirt.
Line 18: Then, attach the defined profile to a vNIC. When the VM is run, the
relevant
Line 19: vNIC would be attached to the forced external network network instead
of the
above line is incomplete...
File vdsm_hooks/extnet/extnet_vnic.py
Line 21:
Line 22: def replaceSource(interface, newnet):
Line 23: source, = interface.getElementsByTagName('source')
Line 24: source.removeAttribute('bridge')
Line 25: source.setAttribute('network', newnet)
If it is openvswitch bridge , is n't it, we have to 'append' below line to the
interface definition ?
virtualport type='openvswitch'/
Line 26: interface.setAttribute('type', 'network')
Line 27:
Line 28:
Line 29: def main():
--
To view, visit http://gerrit.ovirt.org/22124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70bc74a9ac4a6eb88d089baa86918275c61f5190
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS: make report only when present and say so in the schema
Adam Litke has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9d2bc8310fed2ad3c0a748cdf1cfd2cf050aa2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Lior Vernia lver...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5188/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6076/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Martin Sivák has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 3: Verified+1 Rebased with only a minor change. -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Allow setting just a single value in MoM policy .. Allow setting just a single value in MoM policy This patch prevents a policy coruption that could have happened when the 01-parameters policy was updated with just a single value. If there were more values defined, the variables were lost and the policy ended up broken. This patch defines the variables in a file that is not touched by the setMOMPolicyParameters and uses (set name value) syntax in the generated policy part. It also remembers the old setting and puts all the values to the policy part when it is autogenerated. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025780 Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Signed-off-by: Martin Sivak msi...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21225 Reviewed-by: Amador Pahim apa...@redhat.com Reviewed-by: Doron Fediuck dfedi...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21839 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M debian/vdsm.install M vdsm/Makefile.am A vdsm/mom.d/00-defines.policy D vdsm/mom.d/00-python.policy M vdsm/mom.d/01-parameters.policy M vdsm/momIF.py 6 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Allow setting just a single value in MoM policy
Yaniv Bronhaim has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add an exception for wrong master version.
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Add an exception for wrong master version. .. Patch Set 3: (1 comment) File vdsm/storage/storage_exception.py Line 611: Line 612: Line 613: class StoragePoolWrongVersion(StorageException): Line 614: def __init__(self, spUUID, sdUUID): Line 615: self.value = SD=%s, pool=%s % (sdUUID, spUUID) depends on what the bug requests .. honestly I don't mind Line 616: code = 331 Line 617: message = Wrong Master version Line 618: Line 619: -- To view, visit http://gerrit.ovirt.org/21175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7356c6ebc1aa15910725e0bd17faccd0858621 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadPool: Do not keep reference to tasks
Nir Soffer has posted comments on this change. Change subject: threadPool: Do not keep reference to tasks .. Patch Set 2: Verified+1 Verified by creating a vm and creating few templates. -- To view, visit http://gerrit.ovirt.org/22136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert vdsm: refactor buildConfDevices and getConfDevices i...
Nir Soffer has abandoned this change. Change subject: Revert vdsm: refactor buildConfDevices and getConfDevices into single function .. Abandoned Simpler fix seems to work now. -- To view, visit http://gerrit.ovirt.org/21900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I13d07d6de964ecbc7b518fc53adae0b26cef9658 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadPool: Do not keep reference to tasks
Dan Kenigsberg has submitted this change and it was merged. Change subject: threadPool: Do not keep reference to tasks .. threadPool: Do not keep reference to tasks Worker thread was taking a task from the threadpool queue, run it, and then hold it until the next task is run. This causes the task and all objects referenced from it to keep living until the next task is run by this thread. This patch ensure that worker thread does not keep referece to tasks after they were run. Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58 Relates-To: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22136 Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com --- M vdsm/storage/threadPool.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ayal Baron: Looks good to me, approved Nir Soffer: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
Ayal Baron has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: spiceoptions: To provide spice option attributes to vm
Dan Kenigsberg has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 3: Code-Review-1
(2 comments)
partial review
File vdsm_hooks/spiceoptions/before_vm_start.py
Line 42: strModeList = ['filter', 'all', 'off']
Line 43:
Line 44: mouseModeList = ['server', 'client']
Line 45:
Line 46: spiceDict = {'image': {'compression': imageCompList},
these are all CONSTANTS, and should be named as such.
Line 47: 'jpeg': {'compression': jpegCompList},
Line 48: 'streaming': {'mode': strModeList},
Line 49: 'mouse': {'mode': mouseModeList},
Line 50: 'clipboard': {'copypaste': copyPaste}}
Line 104: sys.stderr.write('\n No Valid Element created for graphic
device :%s\n'
Line 105: % (attrname))
Line 106:
Line 107:
Line 108: if 'spiceoptions' in os.environ:
please split to main() and test() functions, and use hooking.py's hook_exit().
Line 109: try:
Line 110: attrName = ''
Line 111: attrVal = ''
Line 112: attrOpt = ''
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7761aab98cdc3a0d37bed7984ae540278e6bbf70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5985/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5189/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/108/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Yaniv Bronhaim has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Yaniv Bronhaim has posted comments on this change. Change subject: use defined options from configure .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 5: Code-Review+2 (1 comment) Minor nit. But overall is +2. File vdsm/storage/domainMonitor.py Line 247: self.domainMonitor.onDomainStateChange.emit( Line 248: self.sdUUID, self.nextStatus.valid) Line 249: except: Line 250: self.log.warn(Could not emit domain state change event, Line 251: exc_info=True) I wanted to suggest to change the firstChange value here: try: self.domainMonitor.onDomainStateChange.emit(... except: self.log.warn(... else: self.firstChange = False but it's not so important. Line 252: Line 253: self.firstChange = False Line 254: Line 255: # An ISO domain can be shared by multiple pools -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Yaniv Bronhaim has posted comments on this change. Change subject: use defined options from configure .. Patch Set 3: -Verified -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: extnet: attach a vNIC to a libvirt network defined out...
oVirt Jenkins CI Server has posted comments on this change. Change subject: hook: extnet: attach a vNIC to a libvirt network defined outside oVirt .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5190/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/109/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70bc74a9ac4a6eb88d089baa86918275c61f5190 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Humble Devassy Chirammal hchir...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Yaniv Bronhaim has posted comments on this change. Change subject: use defined options from configure .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Alon Bar-Lev has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 2: (1 comment) File lib/vdsm/tool/configurator.py Line 140: Line 141: True if sanlock service requires a restart to reload the relevant Line 142: supplementary groups. Line 143: Line 144: _isconfigured = True now... lets do syntax... always assume failure... never assume success... so I expect False here. also the convention of _ as prefix is something private... I guess you tried to avoid conflict with function name, why not just call this ret? Line 145: proc_status_group_prefix = Groups:\t Line 146: try: Line 147: with open(/var/run/sanlock/sanlock.pid, r) as f: Line 148: sanlock_pid = f.readline().strip() -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
File vdsm/vm.py
Line 1729: self.timeout = max(0, timeout)
Line 1730: self.force = force
Line 1731:
Line 1732: def start(self):
Line 1733: try:
This was just to guard against any unexpected CallbackChain exceptions. While
the current implementation of CallbackChain shouldn't throw, I wanted to make
the code more future-resistant. If you want I can remove the try/catch
alltogether.
Line 1734: self._setGuestEvent()
Line 1735: # are there any available methods for shutdown/reboot?
Line 1736: if self.chain.callbacks:
Line 1737: self.chain.start()
Line 1756: self.vm._guestEventTime = time.time()
Line 1757: self.vm._guestEvent = self.desc['guestEvent']
Line 1758:
Line 1759: @classmethod
Line 1760: def create(cls, vm, delay, message, timeout, reboot, force):
Done
Line 1761: graceful_timeout = int(timeout)
Line 1762: agent_user_delay = int(delay)
Line 1763:
Line 1764: # flag for successful power-down event detection
Line 1764: # flag for successful power-down event detection
Line 1765: # this flag is common for both shutdown and reboot workflows
Line 1766: # because we want to exit the CallbackChain in case either
Line 1767: # of them happens
Line 1768: vm._powerDownEvent.clear()
If you look at some of the older patches, this feature started as being
implemented in the Vm.shutdown() method with callbacks being methods of the Vm
itself. After lengthy discussions the general consensus was that all this
functionality should be encapsulated in one single class (with callbacks and
everything) that could be easily moved to a different file. The motivation was
in fact to use the Command pattern more in the VM class and split it possibly
into multiple files in the future.
Line 1769: if reboot:
Line 1770: desc = {'action': 'Reboot',
Line 1771: 'guestEvent': 'RebootInProgress',
Line 1772: 'returnMsg': 'Machine rebooting'}
Line 1803: return powerDown
Line 1804:
Line 1805: def _waitForEvent(self, event):
Line 1806: event.wait(self.timeout)
Line 1807: return event.is_set()
Done
Line 1808:
Line 1809: # Callbacks for Callback Chain
Line 1810:
Line 1811: def guestAgentShutdown(self, delay, message):
Line 1809: # Callbacks for Callback Chain
Line 1810:
Line 1811: def guestAgentShutdown(self, delay, message):
Line 1812: self.vm.guestAgent.desktopShutdown(delay, message, False)
Line 1813: time.sleep(self.delay)
Done
Line 1814: return self._waitForEvent(self.vm._powerDownEvent)
Line 1815:
Line 1816: def guestAgentReboot(self, delay, message):
Line 1817: self.vm.guestAgent.desktopShutdown(delay, message, True)
Line 1838: def forceReboot(self):
Line 1839: self.vm.reset()
Line 1840: return self._waitForEvent(self.vm._powerDownEvent)
Line 1841:
Line 1842: # End Callbacks
Done
Line 1843:
Line 1844:
Line 1845: class Vm(object):
Line 1846:
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Martin Betak mbe...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 38: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 38: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5191/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6079/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 5: Verified+1 Verified first change event by starting vdsm and checking the emitted events. Verified next events by blocking and unblocking access to storage server. -- To view, visit http://gerrit.ovirt.org/21878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 3: Verified+1 Rebase over http://gerrit.ovirt.org/21878 since this change conflicts with it. Verified by starting vdsm, blocking and unblocking access to storage and verifying repoStat results. -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
Federico Simoncelli has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
Dan Kenigsberg has submitted this change and it was merged. Change subject: domainMonitor: Rename confusing lastCheck variable .. domainMonitor: Rename confusing lastCheck variable In repoStats we use the lastCheck value as the time since domain status was checked. In DomainMonitorStatus we use lastCheck value as the time were domain was checked. This patch eliminates the confusion by using checkTime for the time where status was checked. Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21879 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com --- M vdsm/storage/domainMonitor.py M vdsm/storage/hsm.py 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: threadPool: Do not keep reference to tasks
Hello Ayal Baron, Allon Mureinik, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22208 to review the following change. Change subject: threadPool: Do not keep reference to tasks .. threadPool: Do not keep reference to tasks Worker thread was taking a task from the threadpool queue, run it, and then hold it until the next task is run. This causes the task and all objects referenced from it to keep living until the next task is run by this thread. This patch ensure that worker thread does not keep referece to tasks after they were run. Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58 Relates-To: https://bugzilla.redhat.com/1032925 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22136 Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com --- M vdsm/storage/threadPool.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/22208/1 diff --git a/vdsm/storage/threadPool.py b/vdsm/storage/threadPool.py index b1f3142..a0e24a2 100644 --- a/vdsm/storage/threadPool.py +++ b/vdsm/storage/threadPool.py @@ -191,8 +191,8 @@ it, calling the callback if any. while not self.__isDying: +id, cmd, args, callback = self.__pool.getNextTask() try: -id, cmd, args, callback = self.__pool.getNextTask() if id is None: # should retry. pass elif self.__isDying: @@ -212,6 +212,11 @@ self.__pool.setRunningTask(False) except Exception: self.log.error(Task %s failed % repr(cmd), exc_info=True) +finally: +# Don't keep reference to objects taken from the pool. +# Otherwise this thread may keep those object alive until the +# next iteration. See BZ#1032925. +del id, cmd, args, callback def goAway(self): -- To view, visit http://gerrit.ovirt.org/22208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6e024e0727e11a4c98f4e5ede20229d148fdc58 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Dan Kenigsberg has submitted this change and it was merged. Change subject: use defined options from configure .. use defined options from configure Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Signed-off-by: Alexey Shabalin a.shaba...@gmail.com Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/18694 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/vdsmd_init_common.sh.in M lib/vdsm/tool/libvirt_configure.sh.in 2 files changed, 17 insertions(+), 17 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: use defined options from configure
Dan Kenigsberg has posted comments on this change. Change subject: use defined options from configure .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic15a03f4f9da6fe1ee881881d1c19d8052cf1e17 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Alexey Shabalin a.shaba...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Dan Kenigsberg has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
Dan Kenigsberg has submitted this change and it was merged. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Removing hack for stopping libvirt-guests as conflict service Due to recent fix in libvirt, libvirt-guests daemon now returns right error code when checking its status. Thanks to that we can treat libvirt-guests as all other daemons. Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21205 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/sysvinit/vdsmd.init.in M vdsm.spec.in 2 files changed, 10 insertions(+), 19 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing hack for stopping libvirt-guests as conflict service
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing hack for stopping libvirt-guests as conflict service .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/110/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61b274587e811edfbe63a02d762764700acd3eec Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Separate change detection from lastCheck value
Hello Ayal Baron, Federico Simoncelli, Allon Mureinik, Liron Ar, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22209 to review the following change. Change subject: domainMonitor: Separate change detection from lastCheck value .. domainMonitor: Separate change detection from lastCheck value Since commit 45f3037ca1e, lastCheck value is initialized to special NOT_CHECKED_YET value, and used for detecting the first monitor status change. This change caused repoStats to return high lastCheck value until the first monitor check is done, causing host activation to fail, and host becoming non-operational. Previously, lastCheck value was initialized to monitor thread creation time, and repoStats was returning valid lastCheck value even before the first domain check was finished. While somewhat incorrect, this behavior is required for engine monitoring logic. This patch restore the previous lastCheck semantics and use a new firstChange flag for detecting the first status change. Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Relates-To: https://bugzilla.redhat.com/1003588 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21878 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Liron Ar lara...@redhat.com Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/22209/1 diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py index ac01e8b..d95f133 100644 --- a/vdsm/storage/domainMonitor.py +++ b/vdsm/storage/domainMonitor.py @@ -27,8 +27,6 @@ from vdsm.config import config from sdc import sdCache -NOT_CHECKED_YET = -1 - class DomainMonitorStatus(object): __slots__ = ( @@ -43,7 +41,7 @@ def clear(self): self.error = None -self.lastCheck = NOT_CHECKED_YET +self.lastCheck = time() self.valid = True self.readDelay = 0 self.diskUtilization = (None, None) @@ -133,6 +131,7 @@ self.sdUUID = sdUUID self.hostId = hostId self.interval = interval +self.firstChange = True self.status = DomainMonitorStatus() self.nextStatus = DomainMonitorStatus() self.isIsoDomain = None @@ -244,6 +243,8 @@ self.log.warn(Could not emit domain state change event, exc_info=True) +self.firstChange = False + # An ISO domain can be shared by multiple pools if (not self.isIsoDomain and self.nextStatus.valid and self.nextStatus.hasHostId is False): @@ -257,5 +258,4 @@ self.status.update(self.nextStatus) def _statusDidChange(self): -return (self.status.lastCheck == NOT_CHECKED_YET or -self.status.valid != self.nextStatus.valid) +return self.firstChange or self.status.valid != self.nextStatus.valid -- To view, visit http://gerrit.ovirt.org/22209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8e0df2ee054146b5d9429fd83a4f914ff751 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5192/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6080/ : ABORTED -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ce7c2903c33c25693601dde5a1af376b789e59 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: drop remaining betterPopen references
Francesco Romani has posted comments on this change. Change subject: janitorial: drop remaining betterPopen references .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba693ef181f948e0ac4a525326698ef96684318 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo
Francesco Romani has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 3:
(1 comment)
File lib/vdsm/utils.py
Line 194: with open('/proc/meminfo') as f:
Line 195: lines = f.readlines()
Line 196: return _parseMemInfo(lines)
Line 197: except:
Line 198: logging.warning(lines, exc_info=True)
Yes, I will investigate about that.
Line 199: if tries = 0:
Line 200: raise
Line 201: time.sleep(0.1)
Line 202:
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife98134e4512613fb9812f3162c7cd6a4af8fc89
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
mooli tayer has posted comments on this change.
Change subject: generate qemu-kvm coredumps using abrt
..
Patch Set 7:
(1 comment)
File vdsm.spec.in
Line 608: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 609: %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 610: %endif
Line 611:
Line 612: %if %{?rhel}
note to self, this is a mistake, fix according to
http://gerrit.ovirt.org/#/c/21290/1
Line 613: # Install the configuration sample
Line 614: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 615: %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 616:
--
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5193/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6081/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
Dan Kenigsberg has posted comments on this change. Change subject: lvm.env: move to /usr/share/vdsm/storage .. Patch Set 2: Verified+1 rebased, verified, fixed alphabetization, and added to debina/install. -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm.env: move to /usr/share/vdsm/storage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5194/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/111/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Dan Kenigsberg has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: (1 comment) File lib/vdsm/tool/configurator.py Line 138: Line 139: def isconfigured(self, *args): Line 140: Line 141: True if sanlock service requires a restart to reload the relevant Line 142: supplementary groups. I am still confused by the name of the function and its True/False/raise semantics. Could you state what should each of the three mean? Line 143: Line 144: ret = False Line 145: proc_status_group_prefix = Groups:\t Line 146: try: -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
mooli tayer has uploaded a new change for review.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Avoid calling restorecon on a nonexistent dir.
/var/log/core is only created when vdsm service goes up.
If vdsm never ran on the machine we might get:
restorecon: lstat(/var/log/core) failed: No such file or directory
Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Signed-off-by: Mooli Tayer mta...@redhat.com
---
M init/vdsmd_init_common.sh.in
M vdsm.spec.in
2 files changed, 4 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/22211/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 4b7d079..cc010fe 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -112,14 +112,6 @@
@CHOWN_PATH@ @METADATAUSER@:@METADATAGROUP@
${_DOM_METADATA_BACKUP_DIR} /dev/null 21
}
-_mk_core_path() {
-local core_path=/var/log/core
-if ! [ -d ${core_path} ]; then
-@MKDIR_P@ ${core_path} /dev/null 21
-fi
-@CHMOD_PATH@ a+tw ${core_path} /dev/null 21
-}
-
_mk_run_path() {
local run_path
@@ -133,7 +125,6 @@
task_mkdirs(){
_mk_data_center
-_mk_core_path
_mk_dom_backup
_mk_run_path
@CHMOD_PATH@ 1777 /dev/shm
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7ee0218..a63e415 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -590,6 +590,10 @@
install -Dm 0644 vdsm/limits.conf \
%{buildroot}/etc/security/limits.d/99-vdsm.conf
+# This is not commonplace, but we want /var/log/core to be a world-writable
+# dropbox for core dumps
+install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
+
%if 0%{?with_systemd}
install -Dm 0755 init/systemd/systemd-vdsmd
%{buildroot}/lib/systemd/systemd-vdsmd
install -Dm 0644 init/systemd/vdsmd.service
%{buildroot}%{_unitdir}/vdsmd.service
@@ -615,10 +619,6 @@
%endif
%if 0%{?rhel}
-# This is not commonplace, but we want /var/log/core to be a world-writable
-# dropbox for core dumps
-install -dDm 1777 %{buildroot}%{_localstatedir}/log/core
-%else
# Install the configuration sample
install -Dm 0644 lib/vdsm/vdsm.conf.sample \
%{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
--
To view, visit http://gerrit.ovirt.org/22211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
Nir Soffer has posted comments on this change. Change subject: lvm.env: move to /usr/share/vdsm/storage .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Alon Bar-Lev has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: (1 comment) File lib/vdsm/tool/configurator.py Line 164: else: Line 165: raise Line 166: Line 167: if not ret: Line 168: diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] why can't you move this block within the above try and avoid conditional? Line 169: if diskimage_gid not in groups: Line 170: sys.stdout.write(sanlock service requires restart\n) Line 171: else: Line 172: sys.stdout.write(sanlock service is already configured\n) -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Avoid calling restorecon on a nonexistent dir. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5991/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5195/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/112/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: utils: Add unhandled exceptions logging decorator
Hello Sergey Gotliv, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22212
to review the following change.
Change subject: utils: Add unhandled exceptions logging decorator
..
utils: Add unhandled exceptions logging decorator
We have at least two places where exceptions in thread main function are
not handled, making debugging such threads impossible. This patch adds a
new decorator that make it easy to log tracebacks for unhandled
exceptions.
The recommended use case is to decorate a thread main function. This
ensure that we get a traceback for any error in the thread, including
errors in error handling code. This should be used on all in threads in
the system.
Note that the decorator only adds logging - it does not change the
program flow. The unhandled exception is raise again so you can safely
use it on script main function, without changing the exit code. Do not
try to use this for ignoring exceptions.
See utilsTests for example usage.
Change-Id: I39265bac4f26fefa365bad080dafb6106145f846
Relates-To: https://bugzilla.redhat.com/1034741
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21778
Reviewed-by: Sergey Gotliv sgot...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M lib/vdsm/utils.py
M tests/utilsTests.py
2 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/22212/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index d3e0c2b..ef0f512 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -599,6 +599,28 @@
return int(stat.split(') ')[-1].split()[16])
+def traceback(on=, msg=Unhandled exception):
+
+Log a traceback for unhandled execptions.
+
+:param on: Use specific logger name instead of root logger
+:type on: str
+:param msg: Use specified message for the exception
+:type msg: str
+
+def decorator(f):
+@functools.wraps(f)
+def wrapper(*a, **kw):
+try:
+return f(*a, **kw)
+except Exception:
+log = logging.getLogger(on)
+log.exception(msg)
+raise # Do not swallow
+return wrapper
+return decorator
+
+
def tobool(s):
try:
if s is None:
diff --git a/tests/utilsTests.py b/tests/utilsTests.py
index a6a222d..5f7c82d 100644
--- a/tests/utilsTests.py
+++ b/tests/utilsTests.py
@@ -17,7 +17,9 @@
#
# Refer to the README and COPYING files for full details of the license
#
+import contextlib
import errno
+import logging
from testrunner import VdsmTestCase as TestCaseBase
from vdsm import utils
@@ -80,3 +82,61 @@
class GeneralUtilsTests(TestCaseBase):
def testPanic(self):
self.assertRaises(AssertionError, utils.panic, panic test)
+
+
+@contextlib.contextmanager
+def loghandler(handler, logger=):
+log = logging.getLogger(logger)
+log.addHandler(handler)
+try:
+yield {}
+finally:
+log.removeHandler(handler)
+
+
+class TracebackTests(TestCaseBase):
+
+def __init__(self, *a, **kw):
+self.record = None
+super(TestCaseBase, self).__init__(*a, **kw)
+
+def testDefaults(self):
+@utils.traceback()
+def fail():
+raise Exception
+with loghandler(self):
+self.assertRaises(Exception, fail)
+self.assertEquals(self.record.name, root)
+self.assertTrue(self.record.exc_text is not None)
+
+def testOn(self):
+logger = test
+
+@utils.traceback(on=logger)
+def fail():
+raise Exception
+with loghandler(self, logger=logger):
+self.assertRaises(Exception, fail)
+self.assertEquals(self.record.name, logger)
+
+def testMsg(self):
+@utils.traceback(msg=WAT)
+def fail():
+raise Exception
+with loghandler(self):
+self.assertRaises(Exception, fail)
+self.assertEquals(self.record.message, WAT)
+
+# Logging handler interface
+
+level = logging.DEBUG
+
+def acquire(self):
+pass
+
+def release(self):
+pass
+
+def handle(self, record):
+assert self.record is None
+self.record = record
--
To view, visit http://gerrit.ovirt.org/22212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39265bac4f26fefa365bad080dafb6106145f846
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Distribute /var/log/core with vdsm rpm.
mooli tayer has posted comments on this change.
Change subject: Distribute /var/log/core with vdsm rpm.
..
Patch Set 1:
(1 comment)
Shouldn't have abandoned:
http://gerrit.ovirt.org/#/c/21290/
this patch will make sure /var/log/core is always created with rpm.
File vdsm.spec.in
Line 617: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 618: %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 619: %endif
Line 620:
Line 621: %if 0%{?rhel}
This condition should have actually been negated,
but I couldn't find how to do it.
Any help/pointers?
Line 622: # Install the configuration sample
Line 623: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 624: %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 625:
--
To view, visit http://gerrit.ovirt.org/22211
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Distribute /var/log/core with vdsm rpm.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Distribute /var/log/core with vdsm rpm. .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5196/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/113/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: Log unhandled exceptions in storage refresh thread
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22213 to review the following change. Change subject: hsm: Log unhandled exceptions in storage refresh thread .. hsm: Log unhandled exceptions in storage refresh thread hsm's storage refresh background thread does not handle exceptions, making it harder then it should to debug stupid errors in underlying calls or debug real errors in the field. This patch log a traceback for unhandled exceptions so it will never die silently again. Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21486 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/13/22213/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index a91ae92..1d36cee 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -370,6 +370,7 @@ except Exception: self.log.warn(Failed to clean Storage Repository., exc_info=True) +@utils.traceback(on=self.log.name) def storageRefresh(): lvm.bootstrap(refreshlvs=blockSD.SPECIAL_LVS) sdCache.refreshStorage() -- To view, visit http://gerrit.ovirt.org/22213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: domainMonitor: Log unhandled exceptions in domain monitor th...
Hello Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22214 to review the following change. Change subject: domainMonitor: Log unhandled exceptions in domain monitor thread .. domainMonitor: Log unhandled exceptions in domain monitor thread DomainMonitorThread does not handle exceptions in the thread main function, making it harder to modify the code or understanding unexpected failures in the field. The patch log unhandled exceptions so it will never die silently. Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Relates-To: https://bugzilla.redhat.com/1034741 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21487 Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/domainMonitor.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/22214/1 diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py index ac01e8b..09952b8 100644 --- a/vdsm/storage/domainMonitor.py +++ b/vdsm/storage/domainMonitor.py @@ -24,6 +24,7 @@ import logging import misc +from vdsm import utils from vdsm.config import config from sdc import sdCache @@ -152,6 +153,7 @@ def getStatus(self): return self.status.copy() +@utils.traceback(on=log.name) def _monitorLoop(self): self.log.debug(Starting domain monitor for %s, self.sdUUID) -- To view, visit http://gerrit.ovirt.org/22214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I743c59bffa99ab9868f1878ca96b7d979a703efb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: drop remaining betterPopen references
Antoni Segura Puimedon has posted comments on this change. Change subject: janitorial: drop remaining betterPopen references .. Patch Set 1: Code-Review+1 Thanks! It was confusing for non-historians ;-) -- To view, visit http://gerrit.ovirt.org/22195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba693ef181f948e0ac4a525326698ef96684318 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Yaniv Bronhaim has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: (2 comments) File lib/vdsm/tool/configurator.py Line 138: Line 139: def isconfigured(self, *args): Line 140: Line 141: True if sanlock service requires a restart to reload the relevant Line 142: supplementary groups. why? the function can raise exceptions on failure, but the result should be configured or not configured signed by True and False. Quite common imo.. Line 143: Line 144: ret = False Line 145: proc_status_group_prefix = Groups:\t Line 146: try: Line 164: else: Line 165: raise Line 166: Line 167: if not ret: Line 168: diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] I could .. some don't like big try block without a reason. in the above I catch IOError and that's the reason of this scope as it contains two open blocks. So some would prefer to leave it with one more condition and indentation .. and I'm already used to avoid big try blocks. so I prefer to leave it that way for now Line 169: if diskimage_gid not in groups: Line 170: sys.stdout.write(sanlock service requires restart\n) Line 171: else: Line 172: sys.stdout.write(sanlock service is already configured\n) -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Alon Bar-Lev has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: (1 comment) File lib/vdsm/tool/configurator.py Line 164: else: Line 165: raise Line 166: Line 167: if not ret: Line 168: diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2] consider: ret = False try: normal flow this means process is running and all is ok if you reach here process is running, right? ret = grp.getgrnam(DISKIMAGE_GROUP)[2] in groups except IOError as e: if e.errno == os.errno.ENOENT: ret = True else: raise if ret: sys.stdout.write(sanlock service is already configured\n) else: sys.stdout.write(sanlock service requires restart\n) return ret Line 169: if diskimage_gid not in groups: Line 170: sys.stdout.write(sanlock service requires restart\n) Line 171: else: Line 172: sys.stdout.write(sanlock service is already configured\n) -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
Dan Kenigsberg has submitted this change and it was merged. Change subject: lvm.env: move to /usr/share/vdsm/storage .. lvm.env: move to /usr/share/vdsm/storage lvm.env is a tiny helper script, intended to make it a bit easier to debug Vdsm-controlled lvm state. It is being created whenever the lvm module is loaded, which generates an annoying warning message in unit test. This patch makes lvm.env ship statically with vdsm. It can be used by . /usr/share/vdsm/storage/lvm.env Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21872 Reviewed-by: Nir Soffer nsof...@redhat.com --- M .gitignore M debian/vdsm.install M vdsm.spec.in M vdsm/storage/Makefile.am A vdsm/storage/lvm.env.in M vdsm/storage/lvm.py 6 files changed, 17 insertions(+), 14 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
Dan Kenigsberg has posted comments on this change. Change subject: lvm.env: move to /usr/share/vdsm/storage .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm.env: move to /usr/share/vdsm/storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm.env: move to /usr/share/vdsm/storage .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/114/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae6bc789efa22321eb06422e910bf272c575007 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Haim Ateya hat...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
Nir Soffer has posted comments on this change.
Change subject: generate qemu-kvm coredumps using abrt
..
Patch Set 7:
(2 comments)
Commit Message
Line 4: Commit: Mooli Tayer mta...@redhat.com
Line 5: CommitDate: 2013-11-21 10:58:52 +0200
Line 6:
Line 7: generate qemu-kvm coredumps using abrt
Line 8:
I would describe how we did this before, and why we want to use abrt instead.
Line 9: Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
File vdsm/sampling.py
Line 150:
Line 151: A sample of host-related statistics.
Line 152:
Line 153: Contains the state of the host in the time of initialization.
Line 154:
Is this spelling related to this patch?
Line 155: MONITORED_PATHS = ['/tmp', '/var/log', '/var/log/core',
P_VDSM_RUN]
Line 156:
Line 157: def _getDiskStats(self):
Line 158: d = {}
--
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
Dan Kenigsberg has posted comments on this change. Change subject: sanlock isconfigured raises an exception instead of returning result .. Patch Set 3: (1 comment) File lib/vdsm/tool/configurator.py Line 138: Line 139: def isconfigured(self, *args): Line 140: Line 141: True if sanlock service requires a restart to reload the relevant Line 142: supplementary groups. The docstring does not say something as simple as that. Maybe you can improv the English. Line 143: Line 144: ret = False Line 145: proc_status_group_prefix = Groups:\t Line 146: try: -- To view, visit http://gerrit.ovirt.org/22184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ksm: janitorial: with construct, file() to open()
Dan Kenigsberg has posted comments on this change. Change subject: ksm: janitorial: with construct, file() to open() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47213b3d85eac9afd4cb316c50b192b9c1dfbbd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: utils: Add unhandled exceptions logging decorator
Dan Kenigsberg has posted comments on this change. Change subject: utils: Add unhandled exceptions logging decorator .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39265bac4f26fefa365bad080dafb6106145f846 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: hsm: Log unhandled exceptions in storage refresh thread
Dan Kenigsberg has posted comments on this change. Change subject: hsm: Log unhandled exceptions in storage refresh thread .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e69464ba27b7d522c5ceb3a3099949efe7fbc88 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Distribute /var/log/core with vdsm rpm.
Dan Kenigsberg has posted comments on this change. Change subject: Distribute /var/log/core with vdsm rpm. .. Patch Set 2: (1 comment) You can restore an abandoned change btw. File vdsm.spec.in Line 617 Line 618 Line 619 Line 620 Line 621 %else removal kills rpm build. -- To view, visit http://gerrit.ovirt.org/22211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rpm_spec: Add ethtool as a requirement
Dan Kenigsberg has posted comments on this change. Change subject: rpm_spec: Add ethtool as a requirement .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rpm_spec: Add ethtool as a requirement
Dan Kenigsberg has submitted this change and it was merged. Change subject: rpm_spec: Add ethtool as a requirement .. rpm_spec: Add ethtool as a requirement The new ipwrapper link type detection depends on the ethtool binary that is commonly installed by default but not on minimal installations. This patch ensures that it is not missing. Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22177 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rpm_spec: Add ethtool as a requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: rpm_spec: Add ethtool as a requirement .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/115/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8c806decad74b3e90d485eb8e9a57eeac41ebf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: ifcfg configurator static methods and list handling
Dan Kenigsberg has posted comments on this change. Change subject: cleanup: ifcfg configurator static methods and list handling .. Patch Set 2: Code-Review+2 Probably requires a rebase. -- To view, visit http://gerrit.ovirt.org/20536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83051a07d3b907ba31a01f75e64f01f3f2e7a165 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
