Change in vdsm[master]: vdsm: update size of LUN volume in prepareVolume
Daniel Erez has posted comments on this change. Change subject: vdsm: update size of LUN volume in prepareVolume .. Patch Set 4: (5 comments) File vdsm/clientIF.py Line 108 Line 109 Line 110 Line 111 Line 112 done (looks like a rebase issue..) File vdsm/storage/hsm.py Line 2991: sdUUID=sdUUID).produceVolume(imgUUID=imgUUID, Line 2992: volUUID=volUUID).refreshVolume() Line 2993: Line 2994: @public Line 2995: def getVolumeSize(self, *args): Yeah, the suggestion is to keep a common api (getVolumeSize) for both LUN devices and PDIV volumes. In case of LUN, the first argument should be a GUID. Line 2996: if len(args) == 1: Line 2997: return self.getLUVolumeSize(args[0]) Line 2998: else: Line 2999: return self.getPDIVSize(args[0], args[1], args[2], args[3]) Line 2998: else: Line 2999: return self.getPDIVSize(args[0], args[1], args[2], args[3]) Line 3000: Line 3001: @public Line 3002: def getLUVolumeSize(self, devGUID, options=None): Yeah, I'm passing drive[GUID] now and not the full path Line 3003: Line 3004: Gets the size of a LUN device volume. Line 3005: Line 3006: :param volPath: The LUN device volume path. Line 3002: def getLUVolumeSize(self, devGUID, options=None): Line 3003: Line 3004: Gets the size of a LUN device volume. Line 3005: Line 3006: :param volPath: The LUN device volume path. Done Line 3007: :type volPath: string Line 3008: Line 3009: :returns: a dict with the size of the volume. Line 3010: :rtype: dict Line 3012: size = str(multipath.getDeviceSize(devicemapper.getDmId(devGUID))) Line 3013: Line 3014: return dict(truesize=size, apparentsize=size) Line 3015: Line 3016: @public Yeah, I guess we shouldn't expose it now - will convert to private. Line 3017: def getPDIVSize(self, sdUUID, spUUID, imgUUID, volUUID, options=None): Line 3018: Line 3019: Gets the size of a volume. Line 3020: -- To view, visit http://gerrit.ovirt.org/22976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Update LUN size when starting a vm .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6655/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6568/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Vinzenz Feenstra has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 6: (1 comment) File vdsm/vmstatus.py Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. Well I authored it 2013 even if I rebase it that's not a reason. The commit date still contains the date of 2013. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Nir Soffer has posted comments on this change.
Change subject: vm: Update LUN size when starting a vm
..
Patch Set 5: Code-Review-1
(4 comments)
Suggest how to implement this correctly, but I think it is a bad idea. The fact
that Python has a very liberal type system does not mean we should abuse it.
File vdsm/storage/hsm.py
Line 2991: sdUUID=sdUUID).produceVolume(imgUUID=imgUUID,
Line 2992:
volUUID=volUUID).refreshVolume()
Line 2993:
Line 2994: @public
Line 2995: def getVolumeSize(self, *args):
First, this is not an acceptable api. A device is not a volume and we should
not use the same verb to get the size.
Second, the signature must be:
getVolumeSize(self, *args, **kw)
Because the function should accept the options kwarg.
Line 2996: if len(args) == 1:
Line 2997: return self._getLUVolumeSize(args[0])
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
Line 2993:
Line 2994: @public
Line 2995: def getVolumeSize(self, *args):
Line 2996: if len(args) == 1:
Line 2997: return self._getLUVolumeSize(args[0])
This call must be:
return self._getLUVolumeSize(*args, **kw)
Otherwise we don't pass the options kwarg.
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
Line 3000:
Line 3001: def _getLUVolumeSize(self, devGUID, options=None):
Line 2995: def getVolumeSize(self, *args):
Line 2996: if len(args) == 1:
Line 2997: return self._getLUVolumeSize(args[0])
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
This call must be:
return self._getLUVolumeSize(*args, **kw)
Otherwise we don't pass the kw args, and this will fail with IndexError if
len(args) != 4, instead of a helpful TypeError.
def a(*a, **kw):
... if len(a) == 1:
... return b(*a, **kw)
... else:
... return c(*a, **kw)
...
def b(p1, options=None):
... pass
...
def c(p1, p2, p3, p4, options=None):
... pass
...
a('a')
a('a', 'b')
Traceback (most recent call last):
File stdin, line 1, in module
File stdin, line 5, in a
TypeError: c() takes at least 4 arguments (2 given)
def a(*a, **kw):
... if len(a) == 1:
... return b(a[0])
... else:
... return c(a[0], a[1], a[2], a[3])
...
a('a', 'b', options='foo')
Traceback (most recent call last):
File stdin, line 1, in module
File stdin, line 5, in a
IndexError: tuple index out of range
Line 3000:
Line 3001: def _getLUVolumeSize(self, devGUID, options=None):
Line 3002:
Line 3003: Gets the size of a LUN device volume.
Line 2997: return self._getLUVolumeSize(args[0])
Line 2998: else:
Line 2999: return self._getPDIVSize(args[0], args[1], args[2],
args[3])
Line 3000:
Line 3001: def _getLUVolumeSize(self, devGUID, options=None):
Why LUVolume? There is no volume here, and why LU instead of LUN?
Line 3002:
Line 3003: Gets the size of a LUN device volume.
Line 3004:
Line 3005: :param devGUID: The LUN device GUID.
--
To view, visit http://gerrit.ovirt.org/22976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Ayal Baron has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 3:
(1 comment)
File vdsm/storage/sp.py
Line 866: os.path.join(newmsd.domaindir, sd.MASTER_FS_DIR),
Line 867: exclude=('./lost+found',))
Line 868:
Line 869: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870: self.switchMasterDomain(curmsd, newmsd, masterVersion)
Why did you not address this in latest patchset?
Line 871: except Exception:
Line 872: self.log.exception('migration to new master failed')
Line 873: newmsd.unmountMaster()
Line 874: newmsd.releaseClusterLock()
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Nir Soffer has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 3:
(1 comment)
File vdsm/storage/sp.py
Line 866: os.path.join(newmsd.domaindir, sd.MASTER_FS_DIR),
Line 867: exclude=('./lost+found',))
Line 868:
Line 869: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870: self.switchMasterDomain(curmsd, newmsd, masterVersion)
swichMasterDomain is the last operation in this flow. After this operation, you
cannot rollback. This function will implemented in the pool backends.
If changeRole succeeds, and switchMasterDomain fails, we are left with two
domains set as master, but one will have valid pool meta data and one not. We
are allready handling this situation in reconstructMaster.
Line 871: except Exception:
Line 872: self.log.exception('migration to new master failed')
Line 873: newmsd.unmountMaster()
Line 874: newmsd.releaseClusterLock()
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 3:
(1 comment)
File vdsm/storage/sp.py
Line 866: os.path.join(newmsd.domaindir, sd.MASTER_FS_DIR),
Line 867: exclude=('./lost+found',))
Line 868:
Line 869: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870: self.switchMasterDomain(curmsd, newmsd, masterVersion)
There's a comment explaining this all.
Line 871: except Exception:
Line 872: self.log.exception('migration to new master failed')
Line 873: newmsd.unmountMaster()
Line 874: newmsd.releaseClusterLock()
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: split metadata transaction in createMaster
Dan Kenigsberg has submitted this change and it was merged. Change subject: sp: split metadata transaction in createMaster .. sp: split metadata transaction in createMaster This patch splits the createMaster metadata transactions in two parts: one part related to the pool metadata initialization (with safe default values) and the second one related to the domain metadata (including role, masterVersion and attached pool). The reason to split the two operations is to encapsulate the storage pool metadata into methods that later on can be moved out of the StoragePool class. Removing the previous transaction is not risky as the pool metadata values are safe defaults and the real commit phase is executed in the domain metadata transaction. The two side effects of this change are: - we always initialize the pool metadata even when the domain metadata transaction fails - the createMaster operation takes now two storage operations instead of one Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078 Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22418 Reviewed-by: Ayal Baron aba...@redhat.com --- M vdsm/storage/sd.py M vdsm/storage/sp.py 2 files changed, 27 insertions(+), 18 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified -- To view, visit http://gerrit.ovirt.org/22418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: replace type() with isinstance()
Francesco Romani has posted comments on this change. Change subject: clientIF: replace type() with isinstance() .. Patch Set 1: Nir, thanks for the detailed review. I definitely see your point. This tiny patch, altough armed only with good intentions, heads in the wrong direction. I'll put more effort in the points you highlighted. -- To view, visit http://gerrit.ovirt.org/23056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53afef3476a2aedbc5dac830a99f6ee9c093688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(4 comments)
File vdsm/vm.py
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self.conf.get('smp', 1)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', smp))
Line 902: # hotplug cpu requires a maximum number which is higher than
the static
Done
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'current': smp, 'placement': 'static'})
Line 906:
Line 901: 'vcpu', text=self.conf.get('maxVCpus', smp))
Line 902: # hotplug cpu requires a maximum number which is higher than
the static
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'current': smp, 'placement': 'static'})
Done
Line 906:
Line 907: memSizeGuaranteedKB = str(1024 * int(
Line 908: self.conf.get('memGuaranteedSize', '0')
Line 909: ))
Line 1056: cpu.appendChildWithArgs('feature', **featureAttrs)
Line 1057:
Line 1058: if ('smpCoresPerSocket' in self.conf or
Line 1059: 'smpThreadsPerCore' in self.conf):
Line 1060: maxVCpus = int(self.conf.get('maxVCpus', '160'))
Done
Line 1061: cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 1062: threads = int(self.conf.get('smpThreadsPerCore', '1'))
Line 1063: cpu.appendChildWithArgs('topology',
Line 1064: sockets=str(maxVCpus / cores /
threads),
Line 3386: except libvirt.libvirtError as e:
Line 3387: self.log.error(setNumberOfCpus failed, exc_info=True)
Line 3388: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3389: return errCode['noVM']
Line 3390: return {'status': {'code': errCode['setNumberOfCpusErr
/']
Done
Line 3391: ['status']['code'], 'message': e.message}}
Line 3392:
Line 3393: self.saveState()
Line 3394: hooks.after_set_num_of_cpus()
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: replace type() with isinstance()
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: replace type() with isinstance() .. Patch Set 1: Code-Review-1 isinstance IS slightly more pythonic than type(), but Nir is correct in the fact that this patch fixes nothing, and as such, would better be avoided. -- To view, visit http://gerrit.ovirt.org/23056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic53afef3476a2aedbc5dac830a99f6ee9c093688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(1 comment)
File vdsm/hooks.py
Line 295: return _runHooksDir(domxml, 'after_disk_hotunplug', vmconf=vmconf,
Line 296: params=params, raiseError=False)
Line 297:
Line 298:
Line 299: def before_set_num_of_cpus(vmconf={}, params={}):
no use case for the host at the moment, I think. But it makes sense to invoke
something inside the guest in each case…and we don't have any hook system in
guest agent so this would be the only way (even something like virsh
qemu-agent-command may make sense, as ugly as it is)
Line 300: return _runHooksDir(None, 'before_set_num_of_cpus', vmconf=vmconf,
Line 301: params=params, raiseError=True)
Line 302:
Line 303:
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: replace type() with isinstance()
Francesco Romani has abandoned this change. Change subject: clientIF: replace type() with isinstance() .. Abandoned We all agree it is better to avoid this patch; discussion was fruitful and provided the right direction for further work. -- To view, visit http://gerrit.ovirt.org/23056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic53afef3476a2aedbc5dac830a99f6ee9c093688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Michal Skrivanek has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 895: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 896: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 897: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
I would not obfuscate the code more. I'd leave this the way it was without
helper functions; and similarly for vcpus just use a variable vcpu holding the
number (and use again at line 1057) and call the xml snippet on the next line
vcpuelem instead (as is the convention elsewhere)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
Line 903:
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix return parameter value and name of sanlockConfigModule i...
Dan Kenigsberg has posted comments on this change. Change subject: Fix return parameter value and name of sanlockConfigModule is-configured .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee05a07727a99adae2eab619eada1a42c0ad5f73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Gluster API verbs will now be callable again
Dan Kenigsberg has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 3: Verified+1 Copied score after adding a URL to the bug which should have included this fix. -- To view, visit http://gerrit.ovirt.org/23045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1513a5dca444c3e176fb31a9425da85980401b0f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2:
(1 comment)
File lib/vdsm/utils.py
Line 706: logging.warning('Could not find host UUID.')
Line 707: elif arch == 'ppc64':
Line 708: if os.path.exists('/proc/device-tree/system-id'):
Line 709: #eg. output IBM,03061C14A
Line 710: systemId =
file('/proc/device-tree/system-id').readline()
do not use file, it leaks.
take from host-deploy:
elif arch in ('ppc', 'ppc64'):
#eg. output IBM,03061C14A
if os.path.exists('/proc/device-tree/system-id'):
with open('/proc/device-tree/system-id') as f:
vdsmId = f.readline().rstrip('\0').replace(',', '')
Line 711:
Line 712: __hostUUID = systemId.rstrip('\0').replace(,,
)
Line 713:
Line 714: if legacy:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Federico Simoncelli has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 5: Verified+1 Positive flow verified performing masterMigrate multiple times. -- To view, visit http://gerrit.ovirt.org/22419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Validate VDSM user's sudoer permissions
Dan Kenigsberg has posted comments on this change. Change subject: Validate VDSM user's sudoer permissions .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: sasha.chuz...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Validate VDSM user's sudoer permissions
Dan Kenigsberg has submitted this change and it was merged. Change subject: Validate VDSM user's sudoer permissions .. Validate VDSM user's sudoer permissions On startup VDSM will try to run SUDO arbitrary command to validate that vdsm sudoer configuration (sudoers.d/50_vdsm file) is set and read properly. If not, will report to syslog and exit. Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024236 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22888 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/vdsm 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: sasha.chuz...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: enhance vdsmcli error handling
Timothy Asir has posted comments on this change. Change subject: gluster: enhance vdsmcli error handling .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 19: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6656/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5763/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6569/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/220/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: improve masterMigrate safety .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Dan Kenigsberg has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 2: Code-Review-1 Alon, would you use -1 to make it clear when you would not like to see a patch posted as it is? -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Changing the order of the services management alternatives
Dan Kenigsberg has posted comments on this change. Change subject: Changing the order of the services management alternatives .. Patch Set 1: Code-Review-1 Zhou is right - please explain your motivations in the commit message. -- To view, visit http://gerrit.ovirt.org/22867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678cee34d02ebbdcccd49f4c95cca9aa90f6fab3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6657/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6570/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/221/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 2: Alon, would you use -1 to make it clear when you would not like to see a patch posted as it is? well, we discussed that in the past. -1 is not a marker... it is strong rejection. why can't it used as a marker, let's say the author just rebase his patch, so -1 is gone, and now we are in chase of marking -1 all over to avoid merge, what if someone is not available? I think the interpretation should be modified, but not that important to discuss that again. -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/222/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 20:
(5 comments)
File vdsm/vm.py
Line 896: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 897: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
Line 900: vcpu = self.dom.appendChildWithArgs(
nit: lines could be joined
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
Line 903:
Line 904: memSizeGuaranteedKB = str(1024 * int(
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
so now there's no real need of the smp variable.
Line 903:
Line 904: memSizeGuaranteedKB = str(1024 * int(
Line 905: self.conf.get('memGuaranteedSize', '0')
Line 906: ))
Line 1150: def toxml(self):
Line 1151: return self.doc.toprettyxml(encoding='utf-8')
Line 1152:
Line 1153: def _getSmp(self):
Line 1154: return self.conf.get('smp', 1)
make sure the type of the return value is int. Currently, _getMaxVCpus() can be
either int or str, which can get you into troubles.
Line 1155:
Line 1156: def _getMaxVCpus(self):
Line 1157: return self.conf.get('maxVCpus', self._getSmp())
Line 1158:
File vdsm_api/vdsmapi-schema.json
Line 2809: # @kvmEnable: Indicates if KVM hardware acceleration is
enabled
Line 2810: #
Line 2811: # @memSize: The amount of memory assigned to the VM in
MB
Line 2812: #
Line 2813: # @maxVCpus Maximum number of CPU available for the
guest
mark as #optional, keep in alphabetic order.
Line 2814: # It is the upper boundry for hot plug CPU
action
Line 2815: #
Line 2816: # @memGuaranteedSize: The amount of memory guaranteed to the VM
in MB
Line 2817: #
Line 2856: 'displayPort': 'int', 'displaySecurePort': 'int',
Line 2857: '*emulatedMachine': 'str', '*keyboardLayout': 'str',
Line 2858: 'kvmEnable': 'bool', 'memSize': 'uint',
'memGuaranteedSize': 'uint',
Line 2859: 'nicModel': 'str', 'nice': 'int', '*pauseCode': 'str',
Line 2860: 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Add *maxVCpus to this dict, too.
Line 2861: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2862: 'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2863: 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
Line 2864: '*exitCode': 'int', '*exitMessage': 'str'}}
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 23: Code-Review-1 please see my comments to ps20. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix return parameter value and name of sanlockConfigModule i...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix return parameter value and name of sanlockConfigModule is-configured .. Fix return parameter value and name of sanlockConfigModule is-configured 1. Fixing the return value to the right expected boolean. 2. Changing ret to configured for more readability of the code. Change-Id: Iee05a07727a99adae2eab619eada1a42c0ad5f73 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/22496 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/configurator.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee05a07727a99adae2eab619eada1a42c0ad5f73 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix return parameter value and name of sanlockConfigModule i...
Dan Kenigsberg has posted comments on this change. Change subject: Fix return parameter value and name of sanlockConfigModule is-configured .. Patch Set 3: Verified+1 Copying score from verified version. -- To view, visit http://gerrit.ovirt.org/22496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee05a07727a99adae2eab619eada1a42c0ad5f73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Vitor de Lima has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Vitor de Lima has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2:
(1 comment)
File lib/vdsm/utils.py
Line 706: logging.warning('Could not find host UUID.')
Line 707: elif arch == 'ppc64':
Line 708: if os.path.exists('/proc/device-tree/system-id'):
Line 709: #eg. output IBM,03061C14A
Line 710: systemId =
file('/proc/device-tree/system-id').readline()
Done
Line 711:
Line 712: __hostUUID = systemId.rstrip('\0').replace(,,
)
Line 713:
Line 714: if legacy:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 3: Code-Review+1
(2 comments)
minor comments.
File lib/vdsm/utils.py
Line 687: with open(constants.P_VDSM_NODE_ID) as f:
Line 688: __hostUUID = f.readline().replace(\n, )
Line 689: else:
Line 690: arch = platform.machine()
Line 691: if arch == 'x86_64':
in host-deploy it is:
if arch in ('x86_64', 'i686'):
not sure we want to keep support for i686, it is used mostly for fake I think.
Line 692: p = subprocess.Popen([constants.EXT_SUDO,
Line 693: constants.EXT_DMIDECODE, -s,
Line 694: system-uuid],
Line 695: close_fds=True,
stdin=subprocess.PIPE,
Line 707: elif arch in ('ppc', 'ppc64'):
Line 708: #eg. output IBM,03061C14A
Line 709: if os.path.exists('/proc/device-tree/system-id'):
Line 710: with open('/proc/device-tree/system-id') as f:
Line 711: systemId = f.readline()
any reason for this temp variable?
Line 712: __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713:
Line 714: if legacy:
Line 715: try:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6660/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6573/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/223/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Francesco Romani has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 6: (2 comments) Commit Message Line 6: Line 7: Convert vm status strings to constants Line 8: Line 9: This patch replaces all vmstatuses to constants. Line 10: Additionally added not documented 'Powering up' status to schema. Just wondering if the documentation part deserves a separate patch Line 11: Line 12: Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 File vdsm/vmstatus.py Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. OK, fine then. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6575/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Dan Kenigsberg has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 3: Alon, if someone rebases a patch without attending to all comments therein, he is at fault. -1 serves as a notice to the author and to me, that not all is well in the current version of the patch, and that the reviewer would not be happy if the code is merged as-is. It should not be interpreted as a strong rejection. (You are correct that this is not the proper venue to discuss that) -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/224/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 3: +1 is served as a positive notice. how reviewer should express 'strong rejection' if all he have is -1? hence -1 is the strongest that it can get, a notice to maintainer that something is should be addressed. anyway, not that it is important right now. -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Vitor de Lima has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 3:
(2 comments)
File lib/vdsm/utils.py
Line 687: with open(constants.P_VDSM_NODE_ID) as f:
Line 688: __hostUUID = f.readline().replace(\n, )
Line 689: else:
Line 690: arch = platform.machine()
Line 691: if arch == 'x86_64':
Done
Line 692: p = subprocess.Popen([constants.EXT_SUDO,
Line 693: constants.EXT_DMIDECODE, -s,
Line 694: system-uuid],
Line 695: close_fds=True,
stdin=subprocess.PIPE,
Line 707: elif arch in ('ppc', 'ppc64'):
Line 708: #eg. output IBM,03061C14A
Line 709: if os.path.exists('/proc/device-tree/system-id'):
Line 710: with open('/proc/device-tree/system-id') as f:
Line 711: systemId = f.readline()
It is just to not exceed the 80 columns limit that is enforced in the project.
Line 712: __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713:
Line 714: if legacy:
Line 715: try:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Alon Bar-Lev has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 3:
(1 comment)
File lib/vdsm/utils.py
Line 707: elif arch in ('ppc', 'ppc64'):
Line 708: #eg. output IBM,03061C14A
Line 709: if os.path.exists('/proc/device-tree/system-id'):
Line 710: with open('/proc/device-tree/system-id') as f:
Line 711: systemId = f.readline()
:)))
__hostUUID = f.readline().rstrip(
'\0'
).replace(',', '')
not that it is important
Line 712: __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713:
Line 714: if legacy:
Line 715: try:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6576/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Ayal Baron has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Francesco Romani has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 4:
(1 comment)
File lib/vdsm/utils.py
Line 705: else:
Line 706: logging.warning('Could not find host UUID.')
Line 707: elif arch in ('ppc', 'ppc64'):
Line 708: #eg. output IBM,03061C14A
Line 709: if os.path.exists('/proc/device-tree/system-id'):
There still an -admittedly, tiny- window right here between those two lines.
Maybe is simpler and safer something like
try:
with open('/proc/device-tree/system-id') as f:
systemId = f.readline()
__hostUUID = systemId.rstrip('\0').replace(',', '')
except IOError:
logging.warning(...)
However, even if we acknowledge this as flaw, all the code all around is
similar, so this is probably better addressed in a different change.
Line 710: with open('/proc/device-tree/system-id') as f:
Line 711: systemId = f.readline()
Line 712: __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Itamar Heim has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 4: also, gerrit 2.8 may have some improvements on copying scores during rebases - we'll see... -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 5: (1 comment) File vdsm/storage/hsm.py Line 1343: :type sdUUID: UUID Line 1344: :param options: ? Line 1345: Line 1346: pool = self.getPool(spUUID) Line 1347: if not sdUUID or sdUUID != sd.BLANK_UUID: mistake Line 1348: sdUUID = pool.masterDomain.sdUUID Line 1349: vars.task.getSharedLock(STORAGE, sdUUID) Line 1350: vms = pool.getVmsList(sdUUID) Line 1351: return dict(vmlist=vms) -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 23:
(1 comment)
(sorry)
File vdsm_api/vdsmapi-schema.json
Line 6726: #
Line 6727: # Returns:
Line 6728: # The VM definition, as updated
Line 6729: #
Line 6730: # Since: 4.14.0
as we've been too late for 4.14, this should be updated to 4.15.0
Line 6731: ##
Line 6732: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6733: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int'},
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: Verified+1 I have been running with this for some time now. It also doesn't seem so risky. -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: receive domains map in connectStoragePool
Federico Simoncelli has posted comments on this change.
Change subject: sp: receive domains map in connectStoragePool
..
Patch Set 2:
(2 comments)
Commit Message
Line 4: Commit: Federico Simoncelli fsimo...@redhat.com
Line 5: CommitDate: 2014-01-08 08:52:01 -0500
Line 6:
Line 7: sp: receive domains map in connectStoragePool
Line 8:
I know.
Line 9: Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
File vdsm/storage/spbackends.py
Line 326: futureMaster.releaseClusterLock()
Line 327:
Line 328:
Line 329: @secured
Line 330: class StoragePoolNew(object):
Ah I forgot to come up with a better name for this. Please suggest.
Line 331:
Line 332: __slots__ = ('pool', 'masterVersion', 'domainsMap')
Line 333:
Line 334: log = logging.getLogger('Storage.StoragePoolNew')
--
To view, visit http://gerrit.ovirt.org/21427
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6577/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/225/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: improve masterMigrate safety
Nir Soffer has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 5:
(9 comments)
There are few text issues, some more whitespace can be nice, and some more
comments about the tricky parts.
There is also important issue of handling failures in the cleanup step, after
the master was switched.
Commit Message
Line 9: The goal of this patch is to clean, optimize and give robustness to
Line 10: the masterMigrate method.
Line 11:
Line 12: In this patch:
Line 13: - acquire the cluster lock before start using the new master filesystem
Acquire
Line 14: - refactor out all the required metadata changes in switchMasterDomain
Line 15: - divde the method in two parts (operations required to switch to the
Line 16: new master and previous master cleanup)
Line 17: - address the two parts exception handling (hard failure for the first,
Line 10: the masterMigrate method.
Line 11:
Line 12: In this patch:
Line 13: - acquire the cluster lock before start using the new master filesystem
Line 14: - refactor out all the required metadata changes in switchMasterDomain
Refactor
Line 15: - divde the method in two parts (operations required to switch to the
Line 16: new master and previous master cleanup)
Line 17: - address the two parts exception handling (hard failure for the first,
Line 18: logging only for the second)
Line 11:
Line 12: In this patch:
Line 13: - acquire the cluster lock before start using the new master filesystem
Line 14: - refactor out all the required metadata changes in switchMasterDomain
Line 15: - divde the method in two parts (operations required to switch to the
Divide
Line 16: new master and previous master cleanup)
Line 17: - address the two parts exception handling (hard failure for the first,
Line 18: logging only for the second)
Line 19:
Line 13: - acquire the cluster lock before start using the new master filesystem
Line 14: - refactor out all the required metadata changes in switchMasterDomain
Line 15: - divde the method in two parts (operations required to switch to the
Line 16: new master and previous master cleanup)
Line 17: - address the two parts exception handling (hard failure for the first,
Address
Line 18: logging only for the second)
Line 19:
Line 20: Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
File vdsm/storage/sp.py
Line 872: # or even in this method if we fail to set the old master
to
Line 873: # regular). That said, for API cleaness
switchMasterDomain is
Line 874: # the last method to call as point of no return after
which we
Line 875: # only try to cleanup but we cannot rollback.
Line 876: newmsd.changeRole(sd.MASTER_DOMAIN)
Lets add an empty line before the critical switchMasterDomain() call, to make
it more clear.
Line 877: self.switchMasterDomain(curmsd, newmsd, masterVersion)
Line 878: except Exception:
Line 879: self.log.exception('migration to new master failed')
Line 880: try:
Line 880: try:
Line 881: self.setDomainRegularRole(newmsd)
Line 882: except Exception:
Line 883: self.log.exception('unable to mark domain %s as
regular',
Line 884:newmsd.sdUUID)
Lets add a comment before unmount, explaining that if unmount fails, we would
keep the cluster lock. Otherwise someone may try to fix this later.
Line 885: newmsd.unmountMaster()
Line 886: newmsd.releaseClusterLock()
Line 887: raise
Line 888:
Line 881: self.setDomainRegularRole(newmsd)
Line 882: except Exception:
Line 883: self.log.exception('unable to mark domain %s as
regular',
Line 884:newmsd.sdUUID)
Line 885: newmsd.unmountMaster()
And an empty line after the unmount. Tricky parts in the code needs more
whitespace.
Line 886: newmsd.releaseClusterLock()
Line 887: raise
Line 888:
Line 889: # From this point on we have a new master and should not fail
Line 902: fileUtils.cleanupdir(directory)
Line 903: except Exception:
Line 904: self.log.exception('ignoring old master cleanup failure')
Line 905: finally:
Line 906: # Unmoung old master filesystem and release old cluster
lock
Lets add same comment about failure and old cluster lock.
Line 907: curmsd.unmountMaster()
Line 908: curmsd.releaseClusterLock()
Line 909:
Line 910: def attachSD(self, sdUUID):
Line 904: self.log.exception('ignoring old master cleanup failure')
Line 905: finally:
Line 906: # Unmoung old master filesystem and release
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Nir Soffer has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (2 comments) Looks good please address the question about the api change. Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: Please add note about removing the optional sdUUID from getVmList and why it was removed. Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b File vdsm/storage/sp.py Line 1938 Line 1939 Line 1940 Line 1941 Line 1942 Do we use this option, getting the vm list from the master domain instead of some sdUUID? -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Vitor de Lima has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 4:
(1 comment)
File lib/vdsm/utils.py
Line 705: else:
Line 706: logging.warning('Could not find host UUID.')
Line 707: elif arch in ('ppc', 'ppc64'):
Line 708: #eg. output IBM,03061C14A
Line 709: if os.path.exists('/proc/device-tree/system-id'):
Done
Line 710: with open('/proc/device-tree/system-id') as f:
Line 711: systemId = f.readline()
Line 712: __hostUUID =
systemId.rstrip('\0').replace(',', '')
Line 713:
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Federico Simoncelli has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (2 comments) Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: It was just moved. Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b File vdsm/storage/sp.py Line 1938 Line 1939 Line 1940 Line 1941 Line 1942 No idea. But the behavior has been moved to hsm.py for consistency. -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Gluster API verbs will now be callable again
Yaniv Bronhaim has posted comments on this change. Change subject: Gluster API verbs will now be callable again .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/23045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1513a5dca444c3e176fb31a9425da85980401b0f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Gluster API verbs will now be callable again
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Gluster API verbs will now be callable again .. Gluster API verbs will now be callable again Fix regression introduced in #22967. When wrapping GlusterAPI methods via wrapApiMethod, wrapApiMethod was accessing a GlusterAPI method's im_self, (If f is the wrapped method, then f.im_self), which is an alias to an GlusterAPI instance, but the glusterAPI class doesn't define updateTimestamp. This patch moves 'updateTimestamp' to be a module function, which will be available no matter what method wrapApiMethod is wrapping. Relates-To: https://bugzilla.redhat.com/1048596 Change-Id: I1513a5dca444c3e176fb31a9425da85980401b0f Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/23045 Tested-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Tested-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/BindingXMLRPC.py 1 file changed, 12 insertions(+), 11 deletions(-) Approvals: Yaniv Bronhaim: Verified; Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit http://gerrit.ovirt.org/23045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1513a5dca444c3e176fb31a9425da85980401b0f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Determine bootproto without ifcfg files
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Determine bootproto without ifcfg files
..
netinfo: Determine bootproto without ifcfg files
This is an initial take with comments on IPv4/6 and completeness.
Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8
Bug-Url: https://bugzilla.redhat.com/??
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M lib/vdsm/netinfo.py
1 file changed, 47 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/23098/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 6d0c5ff..2ea3236 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -40,7 +40,7 @@
from .ipwrapper import routeShowAllDefaultGateways
from . import libvirtconnection
from .ipwrapper import linkShowDev
-from .utils import anyFnmatch
+from .utils import anyFnmatch, pgrep, getCmdArgs
from .netconfpersistence import RunningConfig
@@ -447,6 +447,44 @@
raise NotImplementedError
+def getBootProtocolDynamic(iface):
+logging.info('Looking for DHCP client for %s.', iface)
+
+for pid in pgrep('dhclient'):
+if iface in getCmdArgs(pid):
+logging.info('Found dhclient running for %s.', iface)
+return 'dhcp'
+
+for pid in pgrep('dhcpcd'):
+if iface in getCmdArgs(pid):
+logging.info('Found dhcpcd running for %s.', iface)
+return 'dhcp'
+
+# To do/consider (optimization and edge (?) cases):
+#
+# There are a bunch of network managers around but all of them
+# hopefully only use either dhclient or dhcpcd
+# = not worth asking them or is NetworkManager so widespread?
+#
+# Walk the process list only once for all interfaces
+#
+# Treat IPv4 and IPv6 independently
+#
+# Fall back to getBootProtocol?
+#
+# Try harder (how much?) in cases a device name is not explicitly specified
+# on command line / or DHCP client already gone but its lease still valid
+# This possibly includes: defaulting to all interfaces; dhcpcd's globbing;
+# explicit/implicit configuration files (of different nature, indeed)
+#
+# A last resort: lease files created by daemons _somewhere_
+
+logging.info('No DHCP client found for %s. '
+ 'Please file a bug if it was configured using DHCP.', iface)
+
+return 'none'
+
+
def permAddr():
paddr = {}
for b in bondings():
@@ -480,6 +518,7 @@
'gateway': getgateway(gateways, iface),
'ipv6addrs': ipv6addrs,
'ipv6gateway': ipv6routes.get(iface, '::'),
+ 'bootproto4': getBootProtocolDynamic(iface),
'mtu': str(getMtu(iface))})
if qosInbound:
data['qosInbound'] = qosInbound
@@ -527,6 +566,7 @@
return {'addr': ipv4addr,
'cfg': getIfaceCfg(dev),
'ipv6addrs': ipv6addrs,
+'bootproto4': getBootProtocolDynamic(dev),
'mtu': str(getMtu(dev)),
'netmask': ipv4netmask}
@@ -538,6 +578,12 @@
ipv6routes = getIPv6Routes()
paddr = permAddr()
+# To do:
+#
+# Determine if interfaces were configured using DHCP in a single loop
+# over processes run from here / a run over interfaces when resorting
+# to lease files
+
for net, netAttr in networks().iteritems():
try:
d['networks'][net] = _getNetInfo(netAttr.get('iface', net),
--
To view, visit http://gerrit.ovirt.org/23098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Vitor de Lima has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Rescan devices if device not found after vmHotplug...
Dan Kenigsberg has submitted this change and it was merged. Change subject: clientIF: Rescan devices if device not found after vmHotplugDisk .. clientIF: Rescan devices if device not found after vmHotplugDisk According to the analysis in the bug, invoking vmHotplugDisk right after connectStorageServer may not leave enough time for multipathd to create the device, leading to unnecessary failure. As I understand, multipathd is receiving events from udev and creating devices. The race is probably related to the asynchronous nature of this mechanism. Invoking multipath.rescan() force synchronous update of the found devices. The original fix in commit 15c7f74365cb5d2c9258bc333c441941c6e42bdb tried to to invoke multipath.rescan() if the device was not found. Due to a unfortunate error, multipath.rescan() was never invoked. Although the bug was never fixed, QE verified it and customers are using this code for the last 6 month. We believe that the problem is a tiny race that is unlikely to happen, but it is possible and should be fixed. This patch implements the original fix in a different way, calling getDevicesVisibility(), which invokes multipath.rescan() if a device is missing. Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Relates-To: https://bugzilla.redhat.com/923773 Bug-Url: https://bugzilla.redhat.com/1044068 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21181 Reviewed-by: Ayal Baron aba...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/clientIF.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Ayal Baron: Looks good to me, but someone else must approve Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit// : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6579/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
Nir Soffer has posted comments on this change. Change subject: sp: move validatePoolSD in the StoragePool class .. Patch Set 6: (1 comment) Commit Message Line 7: sp: move validatePoolSD in the StoragePool class Line 8: Line 9: It's the StoragePool duty to validate if an operation cannot be Line 10: accomplished because the storage domain is not part of the pool. Line 11: So add note about this change? Line 12: Change-Id: I75f0245ec5449d57431df7055be401d73975312b -- To view, visit http://gerrit.ovirt.org/21787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Francesco Romani has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Vdsm changes
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6668/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6581/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/226/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If828355b7efe28fe6a2e784069425fefd2f3f25c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Determine bootproto without ifcfg files
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Determine bootproto without ifcfg files .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6580/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6670/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6583/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a933bec0df3f7773c0f8e47fc0bf0492149031 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: exclude HWADDR lines if requested
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: exclude HWADDR lines if requested .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6669/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5776/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1134/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6582/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Update LUN size when starting a vm
Daniel Erez has posted comments on this change. Change subject: vm: Update LUN size when starting a vm .. Patch Set 5: (2 comments) File vdsm/storage/hsm.py Line 2991: sdUUID=sdUUID).produceVolume(imgUUID=imgUUID, Line 2992: volUUID=volUUID).refreshVolume() Line 2993: Line 2994: @public Line 2995: def getVolumeSize(self, *args): * The idea is to have a common API for PDIV and logical unit volume. * The options aren't currently in use, but right, need to pass them through. Line 2996: if len(args) == 1: Line 2997: return self._getLUVolumeSize(args[0]) Line 2998: else: Line 2999: return self._getPDIVSize(args[0], args[1], args[2], args[3]) Line 2997: return self._getLUVolumeSize(args[0]) Line 2998: else: Line 2999: return self._getPDIVSize(args[0], args[1], args[2], args[3]) Line 3000: Line 3001: def _getLUVolumeSize(self, devGUID, options=None): A short for 'logical unit volume'. Line 3002: Line 3003: Gets the size of a LUN device volume. Line 3004: Line 3005: :param devGUID: The LUN device GUID. -- To view, visit http://gerrit.ovirt.org/22976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez de...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc
Dan Kenigsberg has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 2: surprise, surprise: checking python module: cpopen... no configure: error: failed to find required module cpopen (unrelated to this patch) -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9a933bec0df3f7773c0f8e47fc0bf0492149031 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump the core of a VM
Adam Litke has posted comments on this change.
Change subject: dump the core of a VM
..
Patch Set 14: Code-Review-1
(1 comment)
I propose some changes to the vdsm API for this command.
File vdsm_api/vdsmapi-schema.json
Line 5549: #
Line 5550: ##
Line 5551: {'command': {'class': 'VM', 'name': 'coreDump'},
Line 5552: 'data': {'to': 'str', 'params': 'DumpParams'}}
Line 5553:
I don't see any value in wrapping some parameters into a params dict while
leaving the 'to' param on the command line. How about specifying all arguments
to the command directly:
{'command': {'class': 'VM', 'name': 'coreDump'},
5552+ 'data': {'to': 'str', 'post-action': 'CoreDumpPostAction', 'flags':
'CoreDumpFlags'}}
Line 5554: ##
Line : # @VM.monitorCommand:
Line 5556: #
Line 5557: # Send a command to the qemu monitor.
--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: get the status of core dump
Adam Litke has posted comments on this change.
Change subject: get the status of core dump
..
Patch Set 8: Code-Review-1
(2 comments)
File vdsm/vm.py
Line 1349: finally:
Line 1350: self._guestCpuLock.release()
Line 1351:
Line 1352: def coreDumpStatus(self):
Line 1353: return self._coredumpThread.getStat()
This function should really be named self._coredumpThread.getStatus
File vdsm_cli/vdsClient.py
Line 1683:
Line 1684: def do_coreDumpStat(self, args):
Line 1685: vmId = args[0]
Line 1686: response = self.s.coreDumpStatus(vmId)
Line 1687: return response['status']['code'],
response['status']['message']
It looks like you are overriding the 'status' member to return the dump status.
In general you should not do this. This command's job is to retrieve the
status of an asynchronous operation and return it. So the 'status' member
should indicate whether the thread status could be retrieved and another field
is needed to deliver the actual retrieved core dump status.
For example, this command should return success even if the retrieved core dump
status is a failure.
Line 1688:
Line 1689: def coreDump(self, args):
Line 1690: dumpParams = {'bypass-cache': False,
Line 1691: 'memory-only': False}
--
To view, visit http://gerrit.ovirt.org/11131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cancel the core dump of a VM
Adam Litke has posted comments on this change.
Change subject: cancel the core dump of a VM
..
Patch Set 9:
(1 comment)
File vdsm_api/vdsmapi-schema.json
Line 5558: #
Line 5559: # Since: 4.10.4
Line 5560: #
Line 5561: ##
Line 5562: {'command': {'class': 'VM', 'name': 'coreDumpCancel'}}
I don't think it needs to. Either the dump is cancelled (status OK) or it
failed (return error code and message)
Line 5563:
Line 5564: ##
Line 5565: # @VM.monitorCommand:
Line 5566: #
--
To view, visit http://gerrit.ovirt.org/11130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Determine bootproto without ifcfg files
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Determine bootproto without ifcfg files .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5778/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1135/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6584/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/23098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump the core of a VM
Adam Litke has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 14: I'd like to pick this up and work on it. I will need to rebase as there have been quite a few major changes since this was updated (removal of libvirtvm, etc.). Shao He: since you're pretty busy these days I am guessing you won't mind? -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils.py: Add hostUUID retrieval support for KVM on PPC64
Dan Kenigsberg has posted comments on this change. Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/8637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a557b096550631e340fcc61bcb3fa4c3ae73837 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 24: Code-Review-1 (1 comment) one last documentation nit, and we're good to go. File vdsm_api/vdsmapi-schema.json Line 2854: '*cpuType': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 2855: 'display': 'VmDisplayType', 'displayIp': 'str', Line 2856: 'displayPort': 'int', 'displaySecurePort': 'int', Line 2857: '*emulatedMachine': 'str', '*keyboardLayout': 'str', Line 2858: 'kvmEnable': 'bool', '*maxVCpus': 'str', 'memSize': 'uint', it should be a 'uint' (even though it is encoded as a string due to xmlrpc limitations - much like smp. Line 2859: 'memGuaranteedSize': 'uint', 'nicModel': 'str', 'nice': 'int', Line 2860: '*pauseCode': 'str', 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 2861: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus', Line 2862: 'timeOffset': 'uint', 'transparentHugePages': 'bool', -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Determine bootproto without ifcfg files
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Determine bootproto without ifcfg files
..
Patch Set 2:
(4 comments)
File lib/vdsm/netinfo.py
Line 447: raise NotImplementedError
Line 448:
Line 449:
Line 450: def getBootProtocolDynamic(iface):
Line 451: logging.info('Looking for DHCP client for %s.', iface)
I see no reason to include so many logging lines, certainly not in INFO level.
Line 452:
Line 453: for pid in pgrep('dhclient'):
Line 454: if iface in getCmdArgs(pid):
Line 455: logging.info('Found dhclient running for %s.', iface)
Line 465: # There are a bunch of network managers around but all of them
Line 466: # hopefully only use either dhclient or dhcpcd
Line 467: # = not worth asking them or is NetworkManager so widespread?
Line 468: #
Line 469: # Walk the process list only once for all interfaces
Right. It should not be hard to define a helper function that returns a
forzenset() of all interfaces with dhcp.
Line 470: #
Line 471: # Treat IPv4 and IPv6 independently
Line 472: #
Line 473: # Fall back to getBootProtocol?
Line 467: # = not worth asking them or is NetworkManager so widespread?
Line 468: #
Line 469: # Walk the process list only once for all interfaces
Line 470: #
Line 471: # Treat IPv4 and IPv6 independently
that's important indeed. Can we easily discern than from the dhclient command
line? Not sure at all. However, since IPv6 is still very experimental, you may
leave bootproto6 under a big TODO sign.
Line 472: #
Line 473: # Fall back to getBootProtocol?
Line 474: #
Line 475: # Try harder (how much?) in cases a device name is not explicitly
specified
Line 469: # Walk the process list only once for all interfaces
Line 470: #
Line 471: # Treat IPv4 and IPv6 independently
Line 472: #
Line 473: # Fall back to getBootProtocol?
at first stage, please fall back to the current implementation of
getBootProtocol(), and that's that. Note that there is no need for a specific
getBootProtocolDynamic() function - we simply improve getBootProtocol() so it
works without ifcfg*.
Line 474: #
Line 475: # Try harder (how much?) in cases a device name is not explicitly
specified
Line 476: # on command line / or DHCP client already gone but its lease
still valid
Line 477: # This possibly includes: defaulting to all interfaces; dhcpcd's
globbing;
--
To view, visit http://gerrit.ovirt.org/23098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: configNetwork: Fix bridgeless broken network deletion
Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: Fix bridgeless broken network deletion .. Patch Set 5: Verified+1 Code-Review+2 Copy verification flag from PS3 (no code change) -- To view, visit http://gerrit.ovirt.org/22436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c641d91da9ef7eab876ed8c77fff7a9becb503 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: exclude HWADDR lines if requested
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: exclude HWADDR lines if requested .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1136/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6585/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/22288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4904251150756594502367d4bea87620dfba58 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump the core of a VM
ShaoHe Feng has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 14: Adam, I'm very glad that you can pick this up. This patch pending so long time. -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Jiří Moskovčák jmosk...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
