Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Sandro Bonazzola has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 6: Verified patchset 4 lvm rules working deploying Hosted Engine with iSCSI storage on CentOS 7 as in Bug #1142709. -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Sandro Bonazzola has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 6: please let me know when this patch will be included in a vdsm build so I can require the new vdsm version from hosted engine spec files. -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/404/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11731/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12520/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce hostdev module
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: introduce hostdev module .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/405/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11732/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12676/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12521/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: toolTests: Fix undefined name usage introduced by 32713.
oVirt Jenkins CI Server has posted comments on this change. Change subject: toolTests: Fix undefined name usage introduced by 32713. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12522/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: addNetwork script: Prevent empty bond and vlan from reaching...
oVirt Jenkins CI Server has posted comments on this change. Change subject: addNetwork script: Prevent empty bond and vlan from reaching RunningConfig .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2008/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12523/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6d56eefc05cdb7456f80b7ec13d0be8ad087aa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: expose hostdev via vdsClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: expose hostdev via vdsClient .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11735/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12679/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12524/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4dd1a1ee9af0d1873a081c115289ad2e52204f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libguestfs: rename virtsparsify to guestfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: libguestfs: rename virtsparsify to guestfs .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/406/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12680/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12525/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07a7f4d5ebd5d8c16df4a35904a8bdf80f77e7b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12681/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12526/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: guestfs: rename virtsparsify to guestfs
oVirt Jenkins CI Server has posted comments on this change. Change subject: guestfs: rename virtsparsify to guestfs .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/407/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11738/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12682/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12527/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2d965b74371db8e9112f47e8f31e5d24e9d4029 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sysprep: implement virt-sysprep functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysprep: implement virt-sysprep functionality .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12684/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12529/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/33545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6815e101bd1f037bf21c9233b18e86f3667cce6e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sysprep: implement virt-sysprep functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysprep: implement virt-sysprep functionality .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11739/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12683/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12528/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/33545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6815e101bd1f037bf21c9233b18e86f3667cce6e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sysprep: implement virt-sysprep functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysprep: implement virt-sysprep functionality .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11741/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12685/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12530/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/33545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6815e101bd1f037bf21c9233b18e86f3667cce6e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: dump domain xml when change is detected
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: dump domain xml when change is detected .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12688/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1701/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12533/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sysprep: implement virt-sysprep functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: sysprep: implement virt-sysprep functionality .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12687/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12532/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6815e101bd1f037bf21c9233b18e86f3667cce6e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: volume: Fix exception re-rasing
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Fix exception re-rasing .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12536/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f505f4ff70c528b5decd2665f9cd983eb58f605 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
Ido Barkan has uploaded a new change for review.
Change subject: Functional test for Multiple Gateways source routing
..
Functional test for Multiple Gateways source routing
adding assertions on the source routing definitions taht are configured
when the network is configured with DHCP.
Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f
Signed-off-by: ibarkan ibar...@redhat.com
---
M AUTHORS
M tests/functional/dhcp.py
M tests/functional/networkTests.py
M tests/functional/utils.py
4 files changed, 49 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/33612/1
diff --git a/AUTHORS b/AUTHORS
index 25197a5..28aec45 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -37,6 +37,7 @@
Lee Yarwood lyarw...@redht.com
Jarod.W work.iec23...@gmail.com
Vitor de Lima vitor.l...@eldorado.org.br
+ Ido Barkan ibar...@redhat.com
[send patches to get your name here]
diff --git a/tests/functional/dhcp.py b/tests/functional/dhcp.py
index abed8c8..9e1338f 100644
--- a/tests/functional/dhcp.py
+++ b/tests/functional/dhcp.py
@@ -42,15 +42,18 @@
def __init__(self):
self.proc = None
-def start(self, interface, dhcpRangeFrom, dhcpRangeTo):
+def start(self, interface, dhcpRangeFrom, dhcpRangeTo, router=None):
# --dhcp-option=3 don't send gateway address which would break routing
+# --dhcp-option=3,router advertise specific router
# -O 6don't reply with any DNS servers either
# -d do not daemonize and log to stderr
# -p 0disable all the dnsmasq dns functionality
self.proc = execCmd([
_DNSMASQ_BINARY.cmd, '--dhcp-authoritative',
'-p', '0', '--dhcp-range=' + dhcpRangeFrom + ',' +
-dhcpRangeTo + ',2m', '--dhcp-option=3', '-O', '6',
+dhcpRangeTo + ',2m',
+'--dhcp-option=3,%s' % (router,) if router else '--dhcp-option=3',
+'-O', '6',
'-i', interface, '-I', 'lo', '-d',
'--bind-interfaces'], sync=False)
sleep(_START_CHECK_TIMEOUT)
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 9a49238..ca4062a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -21,6 +21,7 @@
import os.path
import json
import signal
+import netaddr
from hookValidation import ValidatesHook
from testlib import (VdsmTestCase as TestCaseBase, namedTemporaryDir,
@@ -34,11 +35,11 @@
import veth
from nose import with_setup
from nose.plugins.skip import SkipTest
-from utils import SUCCESS, VdsProxy, cleanupRules
+from utils import SUCCESS, VdsProxy, cleanupRules, wait_for_predicate
from vdsm.ipwrapper import (ruleAdd, ruleDel, routeAdd, routeDel, routeExists,
ruleExists, Route, Rule, addrFlush, LinkType,
-getLinks)
+getLinks, routeShowTable)
from vdsm.constants import EXT_BRCTL
from vdsm.utils import RollbackContext, execCmd
@@ -94,11 +95,12 @@
@contextmanager
-def dnsmasqDhcp(interface):
+def dnsmasqDhcp(interface, dhcp_router=None):
Manages the life cycle of dnsmasq as a DHCP server.
dhcpServer = dhcp.Dnsmasq()
try:
-dhcpServer.start(interface, DHCP_RANGE_FROM, DHCP_RANGE_TO)
+dhcpServer.start(interface, DHCP_RANGE_FROM, DHCP_RANGE_TO,
+ router=dhcp_router)
except dhcp.DhcpError as e:
raise SkipTest(e)
@@ -1907,10 +1909,12 @@
@RequireVethMod
@ValidateRunningAsRoot
def testSetupNetworksAddDelDhcp(self, bridged):
+self.assertTrue(
+os.path.exists('/etc/dhcp/dhclient.d/sourceRoute.sh'))
with vethIf() as (left, right):
veth.setIP(left, IP_ADDRESS, IP_CIDR)
veth.setLinkUp(left)
-with dnsmasqDhcp(left):
+with dnsmasqDhcp(left, dhcp_router=IP_GATEWAY):
network = {NETWORK_NAME: {'nic': right, 'bridged': bridged,
'bootproto': 'dhcp',
'blockingdhcp': True}}
@@ -1921,7 +1925,6 @@
net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
self.assertEqual(net['bootproto4'], 'dhcp')
-
if bridged:
self.assertEqual(net['cfg']['BOOTPROTO'], 'dhcp')
@@ -1929,11 +1932,35 @@
self.assertIn(NETWORK_NAME, devs)
self.assertEqual(devs[NETWORK_NAME]['cfg']['BOOTPROTO'],
'dhcp')
+route_rule_dev = NETWORK_NAME
else:
devs = self.vdsm_net.netinfo.nics
self.assertIn(right, devs)
self.assertEqual(devs[right]['cfg']['BOOTPROTO'], 'dhcp')
+route_rule_dev =
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12692/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12537/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11749/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1702/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2009/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12538/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12694/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1703/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2010/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12539/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Francesco Romani has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Verified+1 Verification (against locally patched vdsm-4.16.5-5.gitb16b036.el6.x86_64 , but relevant code path are identical) - live storage migration flow is broken (https://bugzilla.redhat.com/show_bug.cgi?id=1147971#c0) - live merge not available due to libvirt limitations - so I had to play with disk hotplug/hotunplug, which is good enough as soon as a diks disappears under VDSM's nose. - tuned VDSM to do more frequent polling: vm_sample_disk_interval = 1 vm_sample_disk_latency_interval = 1 - added watch to exercise the code path: - watch vdsClient -s 0 getAllVmStats the two above will significantly increase the chance to trigger the error being addressed by this change. On a VM with three disks (main plus two auxiliary) - plugged/unplugged at random sequence/times the two auxiliary disk - snooped the vdsm logs for errors - verified the entries appears and disappears from vdsClient output did the above for ~10 cycles -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: networkTests: BOND_NAME constant changed to bond11
Petr Horáček has abandoned this change. Change subject: networkTests: BOND_NAME constant changed to bond11 .. Abandoned -- To view, visit http://gerrit.ovirt.org/33529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Modify lv selinux label only if not labablled as libvirt
image
..
lvm: Modify lv selinux label only if not labablled as libvirt image
When using the faulty version of systemd that removes libvirt image
labels from block devices, this patch has no effect. However when a fix
is available and libvirt image label exists, vdsm will not change the
original libvirt label. This allows the increase protection for virtual
machines.
Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb
Bug-Url: https://bugzilla.redhat.com/1127460
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M .gitignore
M configure.ac
M vdsm.spec.in
A vdsm/storage/vdsm-chcon.in
M vdsm/storage/vdsm-lvm.rules.tpl.in
5 files changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/33620/1
diff --git a/.gitignore b/.gitignore
index 5890806..cba2247 100644
--- a/.gitignore
+++ b/.gitignore
@@ -60,6 +60,7 @@
vdsm/sos/vdsm.py
vdsm/storage/protect/safelease
vdsm/storage/lvm.env
+vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
diff --git a/configure.ac b/configure.ac
index 40c37a9..e4b0c88 100644
--- a/configure.ac
+++ b/configure.ac
@@ -122,7 +122,10 @@
)
AC_SUBST([LIBVIRT_SERVICE_DEFAULT], [${with_libvirt_service_default}])
-AC_SUBST([LIBVIRT_IMAGE_LABEL], ['svirt_image_t'])
+
+# Selinux image label
+AC_SUBST([SVIRT_IMAGE_LABEL], ['svirt_image_t'])
+AC_SUBST([SVIRT_CONTENT_LABEL], ['svirt_content_t'])
# Users and groups
@@ -281,6 +284,7 @@
AC_PATH_PROG([IP_PATH], [ip], [/sbin/ip])
AC_PATH_PROG([ISCSIADM_PATH], [iscsiadm], [/sbin/iscsiadm])
AC_PATH_PROG([KILL_PATH], [kill], [/bin/kill])
+AC_PATH_PROG([LS_PATH], [ls], [/bin/ls])
AC_PATH_PROG([LVM_PATH], [lvm], [/sbin/lvm])
AC_PATH_PROG([MKFS_MSDOS_PATH], [mkfs.msdos], [/sbin/mkfs.msdos])
AC_PATH_PROG([MKFS_PATH], [mkfs], [/sbin/mkfs])
@@ -351,6 +355,7 @@
vdsm/storage/Makefile
vdsm/storage/imageRepository/Makefile
vdsm/storage/protect/Makefile
+ vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules.tpl
vdsm/virt/Makefile
vdsm_hooks/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 15006d4..7ec5c42 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -55,8 +55,10 @@
%if 0%{?rhel} == 6
%global _udevrulesdir /lib/udev/rules.d/
+%global _udevexecdir /lib/udev/
%else
%global _udevrulesdir /usr/lib/udev/rules.d/
+%global _udevexecdir /usr/lib/udev/
%endif
Name: %{vdsm_name}
@@ -688,6 +690,11 @@
install -Dm 0644 vdsm/storage/vdsm-lvm.rules \
%{buildroot}%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+install -Dm 0755 vdsm/storage/vdsm-chcon \
+ %{buildroot}%{_udevexecdir}/vdsm-chcon
+%endif
+
install -Dm 0644 vdsm/limits.conf \
%{buildroot}/etc/security/limits.d/99-vdsm.conf
@@ -1174,6 +1181,9 @@
%endif
%{python_sitelib}/sos/plugins/vdsm.py*
%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+%{_udevexecdir}/vdsm-chcon
+%endif
/etc/security/limits.d/99-vdsm.conf
%{_mandir}/man8/vdsmd.8*
%if 0%{?rhel}
diff --git a/vdsm/storage/vdsm-chcon.in b/vdsm/storage/vdsm-chcon.in
new file mode 100644
index 000..6f1eb6e
--- /dev/null
+++ b/vdsm/storage/vdsm-chcon.in
@@ -0,0 +1,14 @@
+#!/bin/sh
+
+# This script must be called from a udev rule and assumes the udev environment
+# variables.
+
+# Do not touch the device if it is already labelled is libvirt image. It will
+# probably be a fixed_disk_t or it may have no selinux label.
+if @LS_PATH@ -Z $DEVNAME | \
+@GREP_PATH@ -q -E :@SVIRT_CONTENT_LABEL@:|:@SVIRT_IMAGE_LABEL@:; then
+exit 0
+fi
+
+echo Changing selinux type to @SVIRT_IMAGE_LABEL@ on $DEVNAME 2
+@CHCON_PATH@ -t @SVIRT_IMAGE_LABEL@ $DEVNAME
diff --git a/vdsm/storage/vdsm-lvm.rules.tpl.in
b/vdsm/storage/vdsm-lvm.rules.tpl.in
index 0869cdf..fb6c87a 100644
--- a/vdsm/storage/vdsm-lvm.rules.tpl.in
+++ b/vdsm/storage/vdsm-lvm.rules.tpl.in
@@ -23,16 +23,13 @@
# label is lost after refreshing a logical volume, and vm get paused. This rule
# ensures that the label exist after device changes. See
# https://bugzilla.redhat.com/1147910
-#
-# TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax is
-# supported. See https://bugzilla.redhat.com/1015300
{{endif}}
# add event is processed on coldplug only, so we need change, too.
ACTION!=add|change, GOTO=lvm_end
# Fix ownership for RHEV volumes
-ENV{DM_VG_NAME}==[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9],
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Nir Soffer has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 7: Verified+1 Version 7 fixes the build on el6 (flags argument added in re.sub in 2.7). Otherwise there is no change the the installed rule, so still verified. -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: sampling: more cautious disk stats check .. virt: sampling: more cautious disk stats check In commit d6d0eb763e623 we changed the disk stats collection to deal with the benign case of known-missing disk stats samples, to avoid add bogus error on the logs. Unfortunately a case was missing in the live storage migration flow, which causes TypeError: argument of type 'NoneType' is not iterable in the logs defeating the purposes of the originating change. This patch fixes this issue by adding the missing check. Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33482 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
Nir Soffer has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Rebase -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kaxmlrpc: fix ancient comment text
Dan Kenigsberg has uploaded a new change for review. Change subject: kaxmlrpc: fix ancient comment text .. kaxmlrpc: fix ancient comment text Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Signed-off-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/kaxmlrpclib.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/33621/1 diff --git a/vdsm/kaxmlrpclib.py b/vdsm/kaxmlrpclib.py index a776ff0..238b1b5 100644 --- a/vdsm/kaxmlrpclib.py +++ b/vdsm/kaxmlrpclib.py @@ -37,7 +37,7 @@ import socket # It would have been nicer to make these server-specific and not module-wide -# constants. But it is not really importat for it, so it should wait. +# constants. But it is not really important for us, so it should wait. KEEPIDLE = 60 KEEPINTVL = 10 KEEPCNT = 6 -- To view, visit http://gerrit.ovirt.org/33621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33611/1//COMMIT_MSG Commit Message: Line 9: When rebooting host most of the times ssl_accept blocks when there is Line 10: new connection estabilished just after socket is opened. Setting timeout Line 11: on socket seems to help but when testing I noticed sometimes there is Line 12: still connection blocked on ssl_accept. Line 13: And more importantly, without this timeout, it is SO easy to DoS us. Please add a test that verifies that opening a plaintext TCP connection to an SSL server does not block us, and backport as far as you can. Line 14: Line 15: Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Nir Soffer has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Verified+1 Verified on el6 and el7. - Check installed lvm rule - Check that vdsm-chcon is installed correctly - Create and provision vm with thin provisioned disk and verify extend flow -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: dump domain xml when change is detected
Francesco Romani has abandoned this change. Change subject: virt: dump domain xml when change is detected .. Abandoned bad idea. Better idea: per-device log when device changes, either solicited or unsolicited by VDSM. -- To view, visit http://gerrit.ovirt.org/33549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: sampling: more cautious disk stats check
Nir Soffer has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
Dan Kenigsberg has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: sampling: more cautious disk stats check
Francesco Romani has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Verified+1 added bug-url to better document this change and to make the bot happy. No code changes. Ticking verified because this is the same patch and code path of master; actually, for the sake of transparency, the patch verified was against this branch. -- To view, visit http://gerrit.ovirt.org/33623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Federico Simoncelli has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
Federico Simoncelli has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: more cautious disk stats check
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5878/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4038/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/48/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/44/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/50/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/24/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
Dan Kenigsberg has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
Dan Kenigsberg has submitted this change and it was merged. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. lvm: Set libvirt image selinux label on block devices backing vdsm images The SELinux sVirt protection for QEMU virtual machines is setup in such a way that a domain can only access files or devices which are labelled svirt_image_t label. Libvirt sets this label on block devices backing images when it starts a vm. On Fedora 19, 20 and EL 7, the selinux label on the block device is lost after refreshing a logical volume. The root cause of this issue is systemd-udevd, trying to preserve the selinux label upon device change event. Loosing the selinux label causes the vm to pause. The only way to use the vm is to restart the vm. Practically, this breaks thin provisioning on block storage, since after each automatic extend, a logical volume must be refreshed. This patch adds a temporary hack, by updating vdsm lvm rules to set the libvirt image selinux label on vdsm images. This change should be reverted when a fix is available in systemd-udevd. This hack is enabled by default only for EL7, since we hope to get a fix for systemd-udevd soon for Fedora. To enable this hack on other platforms: ./configure --enable-chcon-hack Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Bug-Url: https://bugzilla.redhat.com/1127460 Releates-To: https://bugzilla.redhat.com/1147910 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33492 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M configure.ac M vdsm.spec.in M vdsm/storage/Makefile.am R vdsm/storage/vdsm-lvm.rules.tpl.in 4 files changed, 52 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Enable lvm selinux fix for Fedora .. spec: Enable lvm selinux fix for Fedora In case we cannot get the real fix in systemd quickly, this patch enables the temporary hack on Fedora. Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33555 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: kaxmlrpc: fix ancient comment text
Dan Kenigsberg has posted comments on this change. Change subject: kaxmlrpc: fix ancient comment text .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b49f5644932e4bdc5dcd312b14b413c5ea230eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/246/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4039/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/49/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/45/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/51/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/25/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Federico Simoncelli has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review-1 If we limit ourselves to chcon -t svirt_image_t I don't think we fiddle with the category part. -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Enable lvm selinux fix for Fedora
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/247/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5880/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4040/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/50/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/46/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/52/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/26/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: consolidate disk statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1704/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12544/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Hello Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33628
to review the following change.
Change subject: spec: Enable lvm selinux fix for Fedora
..
spec: Enable lvm selinux fix for Fedora
In case we cannot get the real fix in systemd quickly, this patch
enables the temporary hack on Fedora.
Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8
Bug-Url: https://bugzilla.redhat.com/1127460
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/33555
Reviewed-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/33628/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 205715a..f867105 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -35,7 +35,7 @@
%global with_vhostmd 1
%endif
-%if 0%{?rhel} = 7
+%if 0%{?fedora} = 19 || 0%{?rhel} = 7
%global with_chcon_hack 1
%endif
--
To view, visit http://gerrit.ovirt.org/33628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Hello Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33627
to review the following change.
Change subject: lvm: Set libvirt image selinux label on block devices backing
vdsm images
..
lvm: Set libvirt image selinux label on block devices backing vdsm images
The SELinux sVirt protection for QEMU virtual machines is setup in such
a way that a domain can only access files or devices which are labelled
svirt_image_t label. Libvirt sets this label on block devices backing
images when it starts a vm.
On Fedora 19, 20 and EL 7, the selinux label on the block device is lost
after refreshing a logical volume. The root cause of this issue is
systemd-udevd, trying to preserve the selinux label upon device change
event.
Loosing the selinux label causes the vm to pause. The only way to use
the vm is to restart the vm. Practically, this breaks thin provisioning
on block storage, since after each automatic extend, a logical volume
must be refreshed.
This patch adds a temporary hack, by updating vdsm lvm rules to set the
libvirt image selinux label on vdsm images. This change should be
reverted when a fix is available in systemd-udevd.
This hack is enabled by default only for EL7, since we hope to get a
fix for systemd-udevd soon for Fedora.
To enable this hack on other platforms:
./configure --enable-chcon-hack
Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10
Bug-Url: https://bugzilla.redhat.com/1127460
Releates-To: https://bugzilla.redhat.com/1147910
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/33492
Reviewed-by: Dan Kenigsberg dan...@redhat.com
Reviewed-by: Federico Simoncelli fsimo...@redhat.com
---
M configure.ac
M vdsm.spec.in
M vdsm/storage/Makefile.am
R vdsm/storage/vdsm-lvm.rules.tpl.in
4 files changed, 52 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/33627/1
diff --git a/configure.ac b/configure.ac
index c35289b..4261216 100644
--- a/configure.ac
+++ b/configure.ac
@@ -56,6 +56,17 @@
AM_CONDITIONAL([HOOKS], [test ${enable_hooks} = yes])
AC_ARG_ENABLE(
+[chcon_hack],
+[AS_HELP_STRING(
+[--enable-chcon-hack],
+[enable chcon hack for block devices @:@default=no@:@]
+)],
+,
+[enable_chcon_hack=no]
+)
+AM_CONDITIONAL([CHCON_HACK], [test ${enable_chcon_hack} = yes])
+
+AC_ARG_ENABLE(
[libvirt-sanlock],
[AS_HELP_STRING(
[--disable-libvirt-sanlock],
@@ -110,6 +121,9 @@
[with_libvirt_service_default=${sysconfdir}/sysconfig/libvirtd]
)
AC_SUBST([LIBVIRT_SERVICE_DEFAULT], [${with_libvirt_service_default}])
+
+AC_SUBST([LIBVIRT_IMAGE_LABEL], ['svirt_image_t'])
+
# Users and groups
AC_SUBST([VDSMUSER], [vdsm])
@@ -191,6 +205,7 @@
AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
+AC_PATH_PROG([CHCON_PATH], [chcon], [/bin/chcon])
AC_PATH_PROG([CHKCONFIG_PATH], [chkconfig], [/sbin/chkconfig])
AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
AC_PATH_PROG([CHOWN_PATH], [chown], [/bin/chown])
@@ -281,7 +296,7 @@
vdsm/storage/Makefile
vdsm/storage/imageRepository/Makefile
vdsm/storage/protect/Makefile
- vdsm/storage/vdsm-lvm.rules
+ vdsm/storage/vdsm-lvm.rules.tpl
vdsm/virt/Makefile
vdsm_hooks/Makefile
vdsm_hooks/checkimages/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index ca2e86f..205715a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -35,6 +35,10 @@
%global with_vhostmd 1
%endif
+%if 0%{?rhel} = 7
+%global with_chcon_hack 1
+%endif
+
%if 0%{?fedora} = 15 || 0%{?rhel} = 7
%global with_systemd 1
%endif
@@ -637,7 +641,7 @@
%if 0%{?enable_autotools}
autoreconf -if
%endif
-%configure %{?with_hooks:--enable-hooks}
+%configure %{?with_hooks:--enable-hooks}
%{?with_chcon_hack:--enable-chcon-hack}
make
# Setting software_version and software_revision in dsaversion.py
baserelease=`echo %{release} | sed 's/\([0-9]\+\(\.[0-9]\+\)\?\).*/\1/'`
diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index 99b1460..89fa1e5 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -81,3 +81,22 @@
EXTRA_DIST = \
lvm.env.in \
$(NULL)
+
+all-local: vdsm-lvm.rules
+
+vdsm-lvm.rules: vdsm-lvm.rules.tpl
+if CHCON_HACK
+ python -c '\
+ import sys, re; \
+ s = open(sys.argv[1]).read(); \
+ pat = re.compile(r{{.+?}}\n?, re.S); \
+ s = pat.sub(, s); \
+ sys.stdout.write(s)' $ $@;
+else
+ python -c '\
+ import sys, re; \
+ s = open(sys.argv[1]).read(); \
+ pat = re.compile(r{{if chcon_hack}}\n?.+?{{endif}}\n?, re.S);
\
+ s = pat.sub(, s); \
+ sys.stdout.write(s)' $ $@;
Change in vdsm[master]: virt: sampling: extract disk latency calculation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: extract disk latency calculation .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12700/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1705/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12545/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Nir Soffer has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 1: Verified+1 Verified build and the extend flow on el6 and el7, other flows verified in upstream. -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Nir Soffer has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 1: Verified+1 Verified build on el6 el7 and f20 -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Federico Simoncelli has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review+1 Ok because of the difference between svirt_content_t and svirt_image_t. -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Dan Kenigsberg has submitted this change and it was merged. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. lvm: Modify lv selinux label only if not labablled as libvirt image When using the faulty version of systemd that removes libvirt image labels from block devices, this patch has no effect. However when a fix is available and libvirt image label exists, vdsm will not change the original libvirt label. This allows the increase protection for virtual machines. Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33620 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M .gitignore M configure.ac M vdsm.spec.in A vdsm/storage/vdsm-chcon.in M vdsm/storage/vdsm-lvm.rules.tpl.in 5 files changed, 32 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Nir Soffer has uploaded a new change for review. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer nsof...@redhat.com --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/33630/1 diff --git a/.gitignore b/.gitignore index 5890806..bcd5915 100644 --- a/.gitignore +++ b/.gitignore @@ -61,6 +61,7 @@ vdsm/storage/protect/safelease vdsm/storage/lvm.env vdsm/storage/vdsm-lvm.rules +vdsm/storage/vdsm-lvm.rules.tpl vdsm/sudoers.vdsm vdsm/svdsm.logger.conf vdsm/vdscli.py -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: sampling: more cautious disk stats check
Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: more cautious disk stats check .. Patch Set 2: Code-Review-1 Please wait for 3.5.1, to avoid 3.5.0 delays. -- To view, visit http://gerrit.ovirt.org/33623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Nir Soffer has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
oVirt Jenkins CI Server has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12546/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Martin Peřina has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 1: Verified+1 Verified, that it fixes engine - host connection issues after host was fenced when using JSONRPC (more than 10 tests executed without error). Verified, that it doesn't introduce any error in the above scenario when using XMLRPC (6 tests executed without errror) -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: move wait countdown in a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11758/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1706/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12547/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11759/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1707/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12548/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5881/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4041/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/51/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/47/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/53/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/27/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Hello Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33632
to review the following change.
Change subject: lvm: Modify lv selinux label only if not labablled as libvirt
image
..
lvm: Modify lv selinux label only if not labablled as libvirt image
When using the faulty version of systemd that removes libvirt image
labels from block devices, this patch has no effect. However when a fix
is available and libvirt image label exists, vdsm will not change the
original libvirt label. This allows the increase protection for virtual
machines.
Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb
Bug-Url: https://bugzilla.redhat.com/1127460
Signed-off-by: Nir Soffer nsof...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/33620
Reviewed-by: Federico Simoncelli fsimo...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M .gitignore
M configure.ac
M vdsm.spec.in
A vdsm/storage/vdsm-chcon.in
M vdsm/storage/vdsm-lvm.rules.tpl.in
5 files changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/33632/1
diff --git a/.gitignore b/.gitignore
index efb99aa..cafa8d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,7 @@
vdsm/sos/vdsm.py
vdsm/storage/protect/safelease
vdsm/storage/lvm.env
+vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
diff --git a/configure.ac b/configure.ac
index 4261216..3aae03e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -122,7 +122,10 @@
)
AC_SUBST([LIBVIRT_SERVICE_DEFAULT], [${with_libvirt_service_default}])
-AC_SUBST([LIBVIRT_IMAGE_LABEL], ['svirt_image_t'])
+
+# Selinux image label
+AC_SUBST([SVIRT_IMAGE_LABEL], ['svirt_image_t'])
+AC_SUBST([SVIRT_CONTENT_LABEL], ['svirt_content_t'])
# Users and groups
@@ -228,6 +231,7 @@
AC_PATH_PROG([ISCSIADM_PATH], [iscsiadm], [/sbin/iscsiadm])
AC_PATH_PROG([KILL_PATH], [kill], [/bin/kill])
AC_PATH_PROG([LSBLK_PATH], [lsblk], [/bin/lsblk])
+AC_PATH_PROG([LS_PATH], [ls], [/bin/ls])
AC_PATH_PROG([LVM_PATH], [lvm], [/sbin/lvm])
AC_PATH_PROG([MKFS_MSDOS_PATH], [mkfs.msdos], [/sbin/mkfs.msdos])
AC_PATH_PROG([MKFS_PATH], [mkfs], [/sbin/mkfs])
@@ -296,6 +300,7 @@
vdsm/storage/Makefile
vdsm/storage/imageRepository/Makefile
vdsm/storage/protect/Makefile
+ vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules.tpl
vdsm/virt/Makefile
vdsm_hooks/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f867105..4f822e4 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -50,8 +50,10 @@
%if 0%{?rhel} == 6
%global _udevrulesdir /lib/udev/rules.d/
+%global _udevexecdir /lib/udev/
%else
%global _udevrulesdir /usr/lib/udev/rules.d/
+%global _udevexecdir /usr/lib/udev/
%endif
Name: %{vdsm_name}
@@ -668,6 +670,11 @@
install -Dm 0644 vdsm/storage/vdsm-lvm.rules \
%{buildroot}%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+install -Dm 0755 vdsm/storage/vdsm-chcon \
+ %{buildroot}%{_udevexecdir}/vdsm-chcon
+%endif
+
install -Dm 0644 vdsm/limits.conf \
%{buildroot}/etc/security/limits.d/99-vdsm.conf
@@ -1143,6 +1150,9 @@
%endif
%{python_sitelib}/sos/plugins/vdsm.py*
%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+%{_udevexecdir}/vdsm-chcon
+%endif
/etc/security/limits.d/99-vdsm.conf
%{_mandir}/man8/vdsmd.8*
%if 0%{?rhel}
diff --git a/vdsm/storage/vdsm-chcon.in b/vdsm/storage/vdsm-chcon.in
new file mode 100644
index 000..6f1eb6e
--- /dev/null
+++ b/vdsm/storage/vdsm-chcon.in
@@ -0,0 +1,14 @@
+#!/bin/sh
+
+# This script must be called from a udev rule and assumes the udev environment
+# variables.
+
+# Do not touch the device if it is already labelled is libvirt image. It will
+# probably be a fixed_disk_t or it may have no selinux label.
+if @LS_PATH@ -Z $DEVNAME | \
+@GREP_PATH@ -q -E :@SVIRT_CONTENT_LABEL@:|:@SVIRT_IMAGE_LABEL@:; then
+exit 0
+fi
+
+echo Changing selinux type to @SVIRT_IMAGE_LABEL@ on $DEVNAME 2
+@CHCON_PATH@ -t @SVIRT_IMAGE_LABEL@ $DEVNAME
diff --git a/vdsm/storage/vdsm-lvm.rules.tpl.in
b/vdsm/storage/vdsm-lvm.rules.tpl.in
index 0869cdf..fb6c87a 100644
--- a/vdsm/storage/vdsm-lvm.rules.tpl.in
+++ b/vdsm/storage/vdsm-lvm.rules.tpl.in
@@ -23,16 +23,13 @@
# label is lost after refreshing a logical volume, and vm get paused. This rule
# ensures that the label exist after device changes. See
# https://bugzilla.redhat.com/1147910
-#
-# TODO: use SECLABEL{selinux}=@LIBVIRT_IMAGE_LABEL@ when this syntax is
-# supported. See https://bugzilla.redhat.com/1015300
{{endif}}
# add event is processed on coldplug only, so we need change, too.
ACTION!=add|change, GOTO=lvm_end
# Fix ownership for RHEV volumes
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Nir Soffer has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Verified+1 Verified the extend flow on el6 and el7, other flows. -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has submitted this change and it was merged. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33634 to review the following change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/33634/1 diff --git a/.gitignore b/.gitignore index efb99aa..d1e919b 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,7 @@ vdsm/storage/protect/safelease vdsm/storage/lvm.env vdsm/storage/vdsm-lvm.rules +vdsm/storage/vdsm-lvm.rules.tpl vdsm/sudoers.vdsm vdsm/svdsm.logger.conf vdsm/vdscli.py -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12549/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Nir Soffer has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Verified+1 Yea, there is no bug url, but it fixes the build (first check in make check fails without it). -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/33611/2/tests/sslTests.py File tests/sslTests.py: Line 109: Line 110: class SocketTests(TestCaseBase): Line 111: Line 112: def test_block_socket(self): Line 113: # this test make sure that we won't block during I don't understand how this test works :-( You start a server, open a TCP connection to it, but you don't check that the server is still responsive. Would this test really fail on master branch (before your fix)? I think that you should: * start a server * open a DoS connection to it * open a legitimate client to the server * if the client is not served within 10 seconds, fail the test. Line 114: # accept. It will hang the build if accept blocks Line 115: server = TestServer() Line 116: server.start() Line 117: try: Line 119: sock.settimeout(1) Line 120: sock.connect((HOST, server.port)) Line 121: finally: Line 122: server.stop() Line 123: sock.close() puritan: at this point, sock may have not been defined. better use with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock: Line 124: Line 125: Line 126: class VerifyingTransportTests(TestCaseBase): Line 127: -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Dan Kenigsberg has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
Antoni Segura Puimedon has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/33612/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1950:
Line 1951: # DHCP source routing configuration is async hence
we wait
Line 1952: # patiently
Line 1953: rules_exist = lambda: (ruleExists(rule1) and
ruleExists(rule2))
Line 1954: wait_for_predicate(rules_exist, 10)
Good for now. We should eventually replace this with the netlink monitor.
Line 1955: routes = [Route.fromText(r)
Line 1956: for r in routeShowTable(routing_table)]
Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY,
Line 1958: device=str(route_rule_dev))
Line 1955: routes = [Route.fromText(r)
Line 1956: for r in routeShowTable(routing_table)]
Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY,
Line 1958: device=str(route_rule_dev))
Line 1959: specific_route = Route(IP_NETWORK_AND_CIDR,
If I'm not mistaken the proper name for such route would be link scope route.
However, unfortunately, the configuring code does not currently set it with the
correct scope (link instead of local).
Line 1960:via=str(device_ip_addr),
Line 1961:device=str(route_rule_dev))
Line 1962: self.assertIn(default_route, routes)
Line 1963: self.assertIn(specific_route, routes)
--
To view, visit http://gerrit.ovirt.org/33612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: sanitize earlier the 'smp' parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: vm: sanitize earlier the 'smp' parameter .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1708/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12550/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b90a26ff6af560359f3d60a73afc56fb25dc15c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
oVirt Jenkins CI Server has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/249/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5882/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4042/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/52/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/48/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/54/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/28/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12551/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. lvm: Set libvirt image selinux label on block devices backing vdsm images The SELinux sVirt protection for QEMU virtual machines is setup in such a way that a domain can only access files or devices which are labelled svirt_image_t label. Libvirt sets this label on block devices backing images when it starts a vm. On Fedora 19, 20 and EL 7, the selinux label on the block device is lost after refreshing a logical volume. The root cause of this issue is systemd-udevd, trying to preserve the selinux label upon device change event. Loosing the selinux label causes the vm to pause. The only way to use the vm is to restart the vm. Practically, this breaks thin provisioning on block storage, since after each automatic extend, a logical volume must be refreshed. This patch adds a temporary hack, by updating vdsm lvm rules to set the libvirt image selinux label on vdsm images. This change should be reverted when a fix is available in systemd-udevd. This hack is enabled by default only for EL7, since we hope to get a fix for systemd-udevd soon for Fedora. To enable this hack on other platforms: ./configure --enable-chcon-hack Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Bug-Url: https://bugzilla.redhat.com/1127460 Releates-To: https://bugzilla.redhat.com/1147910 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33492 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33627 --- M configure.ac M vdsm.spec.in M vdsm/storage/Makefile.am R vdsm/storage/vdsm-lvm.rules.tpl.in 4 files changed, 52 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. lvm: Modify lv selinux label only if not labablled as libvirt image When using the faulty version of systemd that removes libvirt image labels from block devices, this patch has no effect. However when a fix is available and libvirt image label exists, vdsm will not change the original libvirt label. This allows the increase protection for virtual machines. Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33620 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33632 --- M .gitignore M configure.ac M vdsm.spec.in A vdsm/storage/vdsm-chcon.in M vdsm/storage/vdsm-lvm.rules.tpl.in 5 files changed, 32 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: Enable lvm selinux fix for Fedora .. spec: Enable lvm selinux fix for Fedora In case we cannot get the real fix in systemd quickly, this patch enables the temporary hack on Fedora. Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33555 Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33628 --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+1 First start might fail[1]. since this is simple and on specific upgrade scenario, consider declaring this a known issue? [1] (since ultimately systemd starts libvirt vdsm and long libvirt restart, done by tool, might cause systemd to timeout on starting vdsm) -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12552/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33611/4/tests/sslTests.py File tests/sslTests.py: Line 114: server.server.socket.accept_timeout = 1 Line 115: timeout = server.server.socket.accept_timeout + 1 Line 116: server.start() Line 117: try: Line 118: client_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) nit picking again: please use with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as client_socket and drop the close() on finally. client_socket may not be defined there. Line 119: client_socket.settimeout(timeout) Line 120: client_socket.connect((HOST, server.port)) Line 121: # Wait for data that will never arrive. Line 122: # This will return successfuly if the other side closes the -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 1: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has uploaded a new change for review.
Change subject: DONTMERGE: virt: log device changes
..
DONTMERGE: virt: log device changes
DO NOT MERGE - DEBUG ONLY
log device changes to improve debuggability of VDSM.
This is an hack which adds unnecessary traffic in the logs!
Proper, streamlined change will be prepared in parallel.
Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/33641/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0f9e4ce..e845a50 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4810,9 +4810,13 @@
def _getUnderlyingVmInfo(self):
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
-getElementsByTagName('devices')[0]
-self._devXmlHash = str(hash(devxml.toxml()))
+getElementsByTagName('devices')[0].toxml()
+xmlHash = hash(devxml)
+if xmlHash != self._devXmlHash:
+self.log.debug('VM device changed:\n%s', devxml)
+
+self._devXmlHash = xmlHash
return self._lastXMLDesc
def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/33641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has submitted this change and it was merged. Change subject: ssl: ssl_accept blocks after reboot .. ssl: ssl_accept blocks after reboot When rebooting host most of the times ssl_accept blocks when there is new connection established just after socket is opened. Setting timeout on socket seems to help but when testing I noticed sometimes there is still connection blocked on ssl_accept. Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Signed-off-by: Saggi Mizrahi smizr...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33611 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/sslutils.py M tests/sslTests.py 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 2: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/27/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/23/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/22/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/27/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Saggi Mizrahi has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
Saggi Mizrahi has uploaded a new change for review. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. protocol_acceptor: Make SSL handshake asynchronous Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Signed-off-by: Saggi Mizrahi smizr...@redhat.com --- M lib/vdsm/sslutils.py M vdsm/protocoldetector.py 2 files changed, 53 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/33657/1 diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py index 74d2bdf..505db0e 100644 --- a/lib/vdsm/sslutils.py +++ b/lib/vdsm/sslutils.py @@ -169,7 +169,7 @@ def wrapSocket(self, sock): context = self.context -return SSLSocket(SSL.Connection(context, sock=sock), self) +return SSLSocket(SSL.Connection(context, sock=sock)) class VerifyingHTTPSConnection(httplib.HTTPSConnection): diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py index 7e15f9c..7d428bf 100644 --- a/vdsm/protocoldetector.py +++ b/vdsm/protocoldetector.py @@ -27,9 +27,15 @@ from M2Crypto import SSL -from vdsm.sslutils import SSLServerSocket from vdsm.utils import traceback from vdsm import utils + + +def _is_handshaking(sock): +if not hasattr(sock, is_handshaking): +return False + +return sock.is_handshaking class MultiProtocolAcceptor: @@ -60,8 +66,11 @@ log = logging.getLogger(vds.MultiProtocolAcceptor) -READ_ONLY_MASK = (select.POLLIN | select.POLLPRI | select.POLLHUP - | select.POLLERR) +READ_ONLY_MASK = (select.POLLIN | select.POLLPRI | select.POLLHUP | + select.POLLERR) + +READ_WRITE_MASK = (select.POLLIN | select.POLLPRI | + select.POLLOUT | select.POLLHUP | select.POLLERR) CLEANUP_INTERVAL = 30.0 def __init__(self, host, port, sslctx=None): @@ -113,8 +122,8 @@ self._accept_connection() else: self._handle_connection_read(fd) -else: -pass +if event (select.POLLOUT): +self._handle_connection_write(fd) now = time.time() if now self._next_cleanup: @@ -173,12 +182,21 @@ raise def _accept_connection(self): -try: -client_socket, _ = self._socket.accept() -except SSL.SSLError as e: -self.log.warning(Unable to accept connection due to %s, e) -else: -self._add_connection(client_socket) +client_socket, address = self._socket.accept() +if self._sslctx: +client_socket = self._sslctx.wrapSocket(client_socket) +client_socket.address = address +try: +client_socket.setup_ssl() +client_socket.set_accept_state() +except SSL.SSLError as e: +self.log.warning(Error setting up ssl: %s, e) +client_socket.close() +return + +client_socket.is_handshaking = True + +self._add_connection(client_socket) def _add_connection(self, socket): host, port = socket.getpeername() @@ -186,7 +204,10 @@ socket.setblocking(0) self._pending_connections[socket.fileno()] = (time.time(), socket) -self._poller.register(socket, self.READ_ONLY_MASK) +if _is_handshaking(socket): +self._poller.register(socket, self.READ_WRITE_MASK) +else: +self._poller.register(socket, self.READ_ONLY_MASK) def _remove_connection(self, socket): self._poller.unregister(socket) @@ -195,8 +216,27 @@ host, port = socket.getpeername() self.log.debug(Connection removed from %s:%d, host, port) +def _process_handshake(self, socket): +try: +socket.is_handshaking = (socket.accept_ssl() == 0) +except Exception as e: +self.log.debug(Error during handshake: %s, e) +socket.close() +else: +if not socket.is_hanshaking: +self._poller.modify(socket, self.READ_ONLY_MASK) + +def _handle_connection_write(self, fd): +_, client_socket = self._pending_connections[fd] +if _is_handshaking(client_socket): +self._process_handshake(client_socket) + def _handle_connection_read(self, fd): _, client_socket = self._pending_connections[fd] +if _is_handshaking(client_socket): +self._process_handshake(client_socket) +return + try: data = client_socket.recv(self._required_size, socket.MSG_PEEK) except socket.error as e: @@ -233,12 +273,6 @@ server_socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1) server_socket.bind(addr[0][4]) server_socket.listen(5) - -if
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/28/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/24/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/23/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/28/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12709/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12554/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Nir Soffer has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33643/2/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 25: DEFAULT_ACCEPT_TIMEOUT = 5 Line 26: Line 27: # M2Crypto.threading needs initialization. Line 28: # See https://bugzilla.redhat.com/482420 Line 29: threading.init() Why this is new code? I move this code here few moth ago, after you deleted in one of your patches. Please separate this to a new patch and explain this change. Line 30: Line 31: Line 32: class SSLSocket(object): Line 33: def __init__(self, connection): Line 117: Line 118: try: Line 119: client.setup_ssl() Line 120: client.set_accept_state() Line 121: client.settimeout(self.accept_timeout) accept does not work in non-blocking mode? This is really bad for a non blocking server. Line 122: client.accept_ssl() Line 123: client.settimeout(None) Line 124: except SSL.SSLError as e: Line 125: raise SSL.SSLError(%s, client %s % (e, address[0])) -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Francesco Romani has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 24: rebased, due to vmxml.py changes introduced since the revision before. -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
