Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Adam Litke has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Introduce EventFD support
Yaniv Bronhaim has posted comments on this change. Change subject: infra: Introduce EventFD support .. Patch Set 7: Code-Review-1 any new patch before it gets in as is ? please re-submit already -- To view, visit https://gerrit.ovirt.org/37051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Hello Nir Soffer, Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38437 to review the following change. Change subject: Live Merge: Update drive.format after active layer merge .. Live Merge: Update drive.format after active layer merge A merge of the active layer can change the drive format from cow - raw if a snapshot was merged into a raw backing file. In that case we must correct the VM Drive metadata to ensure the drive is handled properly after the merge has finished. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198512 Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Signed-off-by: Adam Litke ali...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36923 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/38437/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 16f8212..904c8e1 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -5986,15 +5986,25 @@ return volumeID = volumes[-1] +res = self.cif.irs.getVolumeInfo(drive.domainID, drive.poolID, + drive.imageID, volumeID) +if res['status']['code'] != 0: +self.log.error(Unable to get info of volume %s (domain: %s image: +%s), volumeID, drive.domainID, drive.imageID) +raise RuntimeError(Unable to get volume info) +driveFormat = res['info']['format'].lower() + # Sync this VM's data strctures. Ugh, we're storing the same info in # two places so we need to change it twice. device = self._lookupConfByPath(drive['path']) if drive.volumeID != volumeID: # If the active layer changed: -# Update the disk path, volumeID, and volumeInfo members +# Update the disk path, volumeID, volumeInfo, and format members volInfo = getVolumeInfo(device, volumeID) + # Path must be set with the value being used by libvirt device['path'] = drive.path = volInfo['path'] = activePath +device['format'] = drive.format = driveFormat device['volumeID'] = drive.volumeID = volumeID device['volumeInfo'] = drive.volumeInfo = volInfo for v in device['volumeChain']: -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemu-img: Handle image end offset on different lines of output
Adam Litke has uploaded a new change for review.
Change subject: qemu-img: Handle image end offset on different lines of output
..
qemu-img: Handle image end offset on different lines of output
Current code assumes that qemu-img check output will place the image end
offset in the second line of output but it can appear later:
$ sudo qemu-img check
/rhev/data-center/.../41b2b944-77f0-40d5-a681-c63e0dbb7482
No errors were found on the image.
70088/98304 = 71.30% allocated, 0.17% fragmented, 0.00% compressed clusters
Image end offset: 4594466816
Update the scanner so it can find it on any line from the second until
the end of output.
Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1196072
Signed-off-by: Adam Litke ali...@redhat.com
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 51 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/38438/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 2aa130a..61d67bc 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -50,7 +50,11 @@
'offset': re.compile(^Image end offset: (?Pvalue\d+)$),
}
-INFO_OPTFIELDS_STARTIDX = 4 # qemu-img info optional fields start in this line
+# The first row of qemu-img info output where optional fields may appear
+_INFO_OPTFIELDS_STARTIDX = 4
+
+# The first row of qemu-img check output where the 'offset' may appear
+_CHECK_OPTFIELDS_STARTIDX = 1
class _RegexSearchError(Exception):
@@ -97,7 +101,7 @@
raise QImgError(rc, out, err, unable to parse qemu-img info output)
# Scan for optional fields in the output
-row = INFO_OPTFIELDS_STARTIDX
+row = _INFO_OPTFIELDS_STARTIDX
for field, filterFn in (('clustersize', int), ('backingfile', str)):
try:
info[field] = filterFn(__iregexSearch(field, out[row]))
@@ -179,15 +183,18 @@
# FIXME: handle different error codes and raise errors accordingly
if rc != 0:
raise QImgError(rc, out, err)
-try:
-check = {
-'offset': int(__iregexSearch(offset, out[1]))
-}
-# TODO: Add requires for qemu supporting offset and print exc_info
-except:
-raise QImgError(rc, out, err, unable to parse qemu-img check output)
-
-return check
+# Scan for 'offset' in the output
+for row in range(_CHECK_OPTFIELDS_STARTIDX, len(out)):
+try:
+check = {
+'offset': int(__iregexSearch(offset, out[row]))
+}
+return check
+except _RegexSearchError:
+pass
+except:
+break
+raise QImgError(rc, out, err, unable to parse qemu-img check output)
def convert(srcImage, dstImage, stop, srcFormat=None, dstFormat=None):
diff --git a/tests/qemuimgTests.py b/tests/qemuimgTests.py
index ce7cb76..0ffbab5 100644
--- a/tests/qemuimgTests.py
+++ b/tests/qemuimgTests.py
@@ -174,3 +174,36 @@
with FakeExecCmd(qcow2_compat_supported, create_qcow2_compat):
qemuimg.create('image', format='qcow2')
+
+
+class CheckTests(TestCaseBase):
+
+def test_offset_with_stats(self):
+def call(cmd, **kw):
+out = [No errors were found on the image.,
+ 65157/98304 = 66.28% allocated, 0.00% fragmented, 0.00%
+ compressed clusters,
+ Image end offset: 4271243264]
+return 0, out, []
+
+with FakeExecCmd(call):
+check = qemuimg.check('unused')
+self.assertEquals(4271243264, check['offset'])
+
+def test_offset_without_stats(self):
+def call(cmd, **kw):
+out = [No errors were found on the image.,
+ Image end offset: 4271243264]
+return 0, out, []
+
+with FakeExecCmd(call):
+check = qemuimg.check('unused')
+self.assertEquals(4271243264, check['offset'])
+
+def test_offset_no_match(self):
+def call(cmd, **kw):
+out = [All your base are belong to us.]
+return 0, out, []
+
+with FakeExecCmd(call):
+self.assertRaises(qemuimg.QImgError, qemuimg.check, 'unused')
--
To view, visit https://gerrit.ovirt.org/38438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke ali...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16310/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15510/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16480/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemu-img: check/use -T src_cache option in convert/rebase ...
Nir Soffer has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Martin Peřina has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 2: Verified+1 Added note that vmMigrating is deprecated by incomingVmMigrations and outgoingVmMigrations -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: switch to response.error()
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: switch to response.error() .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38268/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1588 Line 1589 Line 1590 Line 1591 Line 1592 Is errCode used after this patch? -- To view, visit https://gerrit.ovirt.org/38268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3825faf7a144ef8973dee3cb9f9f0e52fabfc039 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
Candace Sheremeta has posted comments on this change. Change subject: vdsm: added documentation for downloadImage method .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/37934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Amit Aviram aavi...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: added documentation for downloadImage method .. Patch Set 5: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16311/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15511/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16481/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Amit Aviram aavi...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: remove _reportError
Nir Soffer has posted comments on this change. Change subject: janitorial: vm: remove _reportError .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
Candace Sheremeta has posted comments on this change. Change subject: vdsm: added documentation for downloadImage method .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/37934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Amit Aviram aavi...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: added documentation for downloadImage method .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16312/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15512/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16482/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Amit Aviram aavi...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
Candace Sheremeta has posted comments on this change.
Change subject: vdsm: added documentation for downloadImage method
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/37934/5/client/vdsClient.py
File client/vdsClient.py:
Line 2612: '
copy of console output:
downloadImage
methodArgs spUUID sdUUID imgUUID [volUUID]
Download an image from a remote endpoint using the specified methodArgs.
Arguments:
methodArgs:Python dictionary literal specifying the download
method. The dictionary must be quoted (e.g.
'{methodArgs: {url: ...}')
Keys:
- url: url of the source image
- headers: dictionary of headers (optional)
- method: currently only http is supported
spUUID:UUID of the Storage Pool associated with the Image
sdUUID:UUID of the Storage Domain associated with the Image
imgUUID: UUID of the Image
volUUID: UUID of the Volume (optional)
Returns: A task UUID
Example:
vdsClient -s 0 downloadImage \
{url: http://example.com/myimage;, headers: {Foo: Bar}, \
method: http} spUUID sdUUID imgUUID
--
To view, visit https://gerrit.ovirt.org/37934
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta csher...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Amit Aviram aavi...@redhat.com
Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: Idan Shaby ish...@redhat.com
Gerrit-Reviewer: Liron Aravot lara...@redhat.com
Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove obfuscated use of errCode
Nir Soffer has posted comments on this change. Change subject: vm: remove obfuscated use of errCode .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38267/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3740: diskelem.toxml(), libvirt.VIR_DOMAIN_DEVICE_MODIFY_FORCE) Line 3741: except Exception: Line 3742: self.log.debug(updateDeviceFlags failed, exc_info=True) Line 3743: self.cif.teardownVolumePath(drivespec) Line 3744: return errCode['changeDisk'] The old code was creating new dict for this error - safe. You return the shared mutable dict so if the caller change the returned dict, the next time you return this error it may be different - unsafe. Line 3745: if vmDev in self.conf: Line 3746: self.cif.teardownVolumePath(self.conf[vmDev]) Line 3747: Line 3748: self.conf[vmDev] = path -- To view, visit https://gerrit.ovirt.org/38267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
Nir Soffer has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 6: Nice! -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: added documentation for downloadImage method
Candace Sheremeta has posted comments on this change. Change subject: vdsm: added documentation for downloadImage method .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb26a36734e2381473aee81614c924c3f285e86c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Amit Aviram aavi...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed description for Image.download method
Candace Sheremeta has posted comments on this change. Change subject: vdsm: changed description for Image.download method .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f355e2328bd307adda54a45bd45899baa363cfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed description for Image.download method
Candace Sheremeta has uploaded a new change for review. Change subject: vdsm: changed description for Image.download method .. vdsm: changed description for Image.download method changed the description for Image.download method in vdsmapi-schema.json in order to more accurately reflect the nature of the method's methodArgs parameter Change-Id: I8f355e2328bd307adda54a45bd45899baa363cfa Signed-off-by: Candace Sheremeta csher...@redhat.com --- M vdsm/rpc/vdsmapi-schema.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/38439/1 diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json index 1d919e8..0b7e2a1 100644 --- a/vdsm/rpc/vdsmapi-schema.json +++ b/vdsm/rpc/vdsmapi-schema.json @@ -4658,7 +4658,7 @@ # Download an image to a remote endpoint using the specified method # and methodArgs. # -# @methodArgs: Download method and map of arguments +# @methodArgs: An ImageSharingMethodArgs record specifying the download method. # # @storagepoolID:The UUID of the Storage Pool associated with the Image # -- To view, visit https://gerrit.ovirt.org/38439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f355e2328bd307adda54a45bd45899baa363cfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: removed optional markers for volUUID .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16314/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15514/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16484/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Raise an exception if missing physical volume
Nir Soffer has posted comments on this change. Change subject: lvm: Raise an exception if missing physical volume .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/27442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: changed description for Image.download method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: changed description for Image.download method .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16313/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15513/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16483/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f355e2328bd307adda54a45bd45899baa363cfa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
Candace Sheremeta has posted comments on this change. Change subject: vdsm: removed optional markers for volUUID .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: removed optional markers for volUUID
Candace Sheremeta has uploaded a new change for review.
Change subject: vdsm: removed optional markers for volUUID
..
vdsm: removed optional markers for volUUID
after examining the code, it's clear that the volUUID parameter
for vdsClient's prepareImage command is NOT optional. therefore,
I have removed any comments marking it as optional in the
vdsClient documentation and in vdsmapi-schema.json
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115556
Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Signed-off-by: Candace Sheremeta csher...@redhat.com
---
M client/vdsClient.py
M vdsm/rpc/vdsmapi-schema.json
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/38440/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 07dbaa2..c8aa7cf 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -2595,7 +2595,7 @@
'methodArgs.'
)),
'prepareImage': (serv.prepareImage, (
-'spUUID sdUUID imgUUID [volUUID]',
+'spUUID sdUUID imgUUID volUUID',
'Prepare an image, making the needed volumes available.'
)),
'teardownImage': (serv.teardownImage, (
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 1d919e8..5b99aaa 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4715,13 +4715,13 @@
#
# @imageID: The UUID of the Image
#
-# @volumeID: #optional The UUID of the Volume (optional)
+# @volumeID: The UUID of the Volume
#
# Since: 4.15.0
##
{'command': {'class': 'Image', 'name': 'prepare'},
'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID',
- 'imageID': 'UUID', '*volumeID': 'UUID'}}
+ 'imageID': 'UUID', 'volumeID': 'UUID'}}
##
# @Image.teardown:
--
To view, visit https://gerrit.ovirt.org/38440
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic88bc322bbf84bf79e51edd714687565b123a9c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Candace Sheremeta csher...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: sourceroute: demote error log message
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: sourceroute: demote error log message
..
net: sourceroute: demote error log message
DHCP server may provide vdsm with partial IP information (one of IPADDR,
NETMASK or GATEWAY is missing). This is not Vdsm's fault, and should not
marked as an error.
Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/network/configurators/__init__.py
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/38429/1
diff --git a/vdsm/network/configurators/__init__.py
b/vdsm/network/configurators/__init__.py
index a3c7567..6e14a2d 100644
--- a/vdsm/network/configurators/__init__.py
+++ b/vdsm/network/configurators/__init__.py
@@ -131,10 +131,11 @@
ip.gateway))
if (ip.gateway in (None, '0.0.0.0')
or not ip.ipaddr or not ip.netmask):
-logging.error('invalid input for source routing: name=%s, '
- 'addr=%s, netmask=%s, gateway=%s',
- netEnt.name, ip.ipaddr, ip.netmask,
- ip.gateway)
+logging.warning(
+'invalid input for source routing: name=%s, '
+'addr=%s, netmask=%s, gateway=%s',
+netEnt.name, ip.ipaddr, ip.netmask,
+ip.gateway)
else:
StaticSourceRoute(netEnt.name, self, ip.ipaddr, ip.netmask,
ip.gateway).configure()
--
To view, visit https://gerrit.ovirt.org/38429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: sourceroute: demote error log message
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: sourceroute: demote error log message .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16306/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15506/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2784/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...
Nir Soffer has posted comments on this change. Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI) .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/38354/2/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 142 Line 143 Line 144 Line 145 Line 146 This is not related to your change, but using same temporaries for different types of data (path, contents of path) in the same function is evil. Line 104: Arguments: Line 105: sessionID - the iSCSI session ID. Line 106: Returns: Line 107: - iSCSI host path - e.g. '/sys/class/iscsi_host/host17/' Line 108: - None if host session is not present (i.e. hardware iSCSI) How do we know that the missing path means using hardware iscsi, and not session was disconnected? Do we have some other sysfs attribute that can tell us that we should not expect this path? Line 109: Line 110: Line 111: pattern = '/sys/devices/platform/host*/session%s' % sessionID Line 112: for path in glob.iglob(pattern): Line 112: for path in glob.iglob(pattern): Line 113: host = os.path.basename(os.path.dirname(path)) Line 114: return '/sys/class/iscsi_host/' + host Line 115: Line 116: return None It is more useful to raise here and handle the error in the caller. Line 117: Line 118: Line 119: def readSessionInfo(sessionID): Line 120: iscsi_session = getIscsiSessionPath(sessionID) Line 123: iscsi_host = getIscsiHostPath(sessionID) Line 124: if iscsi_host is not None: Line 125: netdev = os.path.join(iscsi_host, netdev) Line 126: else: Line 127: netdev = None You can handle the OSError here: try: iscsi_host = getIscsiHostPath(sessionID) netdev = os.path.join(iscsi_host, netdev) except OSError as e: if e.errno != errno.ENOENT: raise netdev = None But the OSError we get is not a real error, we can make this code nicer by raising module private error: try: build netdev path... except NoSessionPath: netdev = None Line 128: Line 129: if not os.path.isdir(iscsi_session) or not os.path.isdir(iscsi_connection): Line 130: raise OSError(errno.ENOENT, No such session) Line 131: Line 143: for fname in (targetname, iface, tpgt, user, passwd, paddr, pport, netdev): Line 144: try: Line 145: with open(fname, r) as f: Line 146: res.append(f.read().strip()) Line 147: except (OSError, IOError, TypeError): This code will silently hide None value for any of the names (targetname, iface, ...), while you are trying to handle None netdev. Even if this could only fail when netdev is None, this is bad idea. You don't try to use None (open(fname, ...)) and depend on the fact that it raises TypeError; you should check explicitly for None and handle it. The correct way would be to extract a function for reading path content, so we can write: for path in (values that must exits): append content at path if netdev is not None: append content at path We probably need a helper to append contents of file at path. Line 148: res.append() Line 149: Line 150: iqn, iface, tpgt, username, password, ip, port, netdev = res Line 151: port = int(port) -- To view, visit https://gerrit.ovirt.org/38354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...
Nir Soffer has posted comments on this change. Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI) .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/38354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16307/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15507/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16477/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has abandoned this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Abandoned -- To view, visit https://gerrit.ovirt.org/38430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55.
Unfortunately, this patch ended up causing a regression with
oldready-released engine-3.5.0.
Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Related-To: https://bugzilla.redhat.com/1198680
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/rpc/Bridge.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/38430/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index 1d44b90..6ec7326 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -339,6 +339,13 @@
return API.Global().getVMList(True, vmList)
+def Host_getVMList_Ret(ret):
+
+Just return a list of VM UUIDs
+
+return [v['vmId'] for v in ret['vmList']]
+
+
def StoragePool_getInfo_Ret(ret):
The result contains two data structures which must be merged
@@ -412,7 +419,7 @@
'Host_hostdevChangeNumvfs': {},
'Host_startMonitoringDomain': {},
'Host_stopMonitoringDomain': {},
-'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
--
To view, visit https://gerrit.ovirt.org/38430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55.
Unfortunately, this patch ended up causing a regression with
oldready-released engine-3.5.0.
Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Related-To: https://bugzilla.redhat.com/1198680
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/rpc/Bridge.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/38431/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index e1781a2..e4b12aa 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -333,6 +333,13 @@
return API.Global().getVMList(True, vmList)
+def Host_getVMList_Ret(ret):
+
+Just return a list of VM UUIDs
+
+return [v['vmId'] for v in ret['vmList']]
+
+
def StoragePool_getInfo_Ret(ret):
The result contains two data structures which must be merged
@@ -402,7 +409,7 @@
'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
'Host_startMonitoringDomain': {},
'Host_stopMonitoringDomain': {},
-'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
--
To view, visit https://gerrit.ovirt.org/38431
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...
Nir Soffer has posted comments on this change. Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI) .. Patch Set 3: Please see my comments in version 2. -- To view, visit https://gerrit.ovirt.org/38354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: sourceroute: demote error log message
Assaf Muller has posted comments on this change. Change subject: net: sourceroute: demote error log message .. Patch Set 1: The issue of course is not a missing IP address or netmask, but is a missing default gateway. Networks without a gateway are perfectly valid, just not for source routing. I don't remember how deep this code path is (Should it expect a gateway present at this point)? Anyhow, I think that a network without a gateway is a 'supported' or 'expected' use case and perhaps even warning is too harsh. If the admin screwed up and he meant to supply a gateway when he configured his DHCP server, he'll have many other indicators that he screwed up anyway, the VDSM log will probably be the last place he'd look. -- To view, visit https://gerrit.ovirt.org/38429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I683b8e6c45808374da322bb5418870562d6b4c81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Revert json-rpc: fix the Host.getVMList return value This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55. Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1196327 Reviewed-on: https://gerrit.ovirt.org/38432 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/rpc/Bridge.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16308/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15508/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16478/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has abandoned this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Abandoned -- To view, visit https://gerrit.ovirt.org/38431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16309/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16479/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemu-img: check/use -T src_cache option in convert/rebase ...
Hello Nir Soffer, Federico Simoncelli,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38434
to review the following change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
qemu-img: check/use -T src_cache option in convert/rebase when available
qemu-img is used for operations like disk move or snapshot delete.
This process reads data using the hypervisor page cache. As this data might
be hotter than any VM memory the system starts swapping out memory pages of
the running VMs.
vdsm already uses -t none option to avoid cache for output image. Now
qemu-img introduced a new -T src_cache to avoid cache for the
input image (bz#1116558).
This patch is testing if qemu-img has the new -T src_cache option available
for convert and rebase commands and using it with -T none when true.
Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690
Signed-off-by: Amador Pahim apa...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/36308
Reviewed-by: Nir Soffer nsof...@redhat.com
Reviewed-by: Federico Simoncelli fsimo...@redhat.com
Signed-off-by: Amador Pahim apa...@redhat.com
---
M lib/vdsm/qemuimg.py
1 file changed, 29 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/38434/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 2aa130a..90e5e0f 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -193,6 +193,9 @@
def convert(srcImage, dstImage, stop, srcFormat=None, dstFormat=None):
cmd = [_qemuimg.cmd, convert, -t, none]
+if _supports_src_cache('convert'):
+cmd.extend((-T, none))
+
if srcFormat:
cmd.extend((-f, srcFormat))
@@ -231,6 +234,9 @@
stop=None):
cmd = [_qemuimg.cmd, rebase, -t, none]
+if _supports_src_cache('rebase'):
+cmd.extend((-T, none))
+
if unsafe:
cmd.extend((-u,))
@@ -249,3 +255,26 @@
if rc != 0:
raise QImgError(rc, out, err)
+
+
+# Testing capabilities
+
+@utils.memoized
+def _supports_src_cache(command):
+
+The -T option specifies the cache mode that should be used with the
+source file. This will check if -T option is available, aiming to set it
+to none, avoiding the use of cache memory (BZ#1138690).
+
+# REQUIRED_FOR: FEDORA 20 (no qemu-img with -T support)
+cmd = [_qemuimg.cmd, --help]
+rc, out, err = utils.execCmd(cmd, raw=True)
+
+# REQUIRED_FOR: EL6 (--help returns 1)
+if rc not in (0, 1):
+raise QImgError(rc, out, err)
+
+# Line to match:
+# convert [-c] [-p] [-q] [-n] [-f fmt] [-t cache] [-T src_cache]...
+pattern = r\n +%s .*\[-T src_cache\] % command
+return re.search(pattern, out) is not None
--
To view, visit https://gerrit.ovirt.org/38434
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemu-img: check/use -T src_cache option in convert/rebase ...
Amador Pahim has abandoned this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Abandoned Abandoned due to the wrong change-id. Please visit https://gerrit.ovirt.org/#/c/38434. -- To view, visit https://gerrit.ovirt.org/38413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iab9c2abb22814c2660cd05180537db9e35a34636 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: qemu-img: check/use -T src_cache option in convert/rebase ...
Allon Mureinik has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Francesco Romani has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 1: Verified+1 verified running the new tests -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: add the response.success() helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: add the response.success() helper .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2643/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15495/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16465/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcd6c832f3a16a543357570c591c1f9a907c97a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: use recommended logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: use recommended logging .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16301/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15501/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16471/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: export setLogLevel API
oVirt Jenkins CI Server has posted comments on this change. Change subject: json-rpc: export setLogLevel API .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15503/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16473/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7481a59fb5f0598a671118394e368eab79a381b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos plugin: collect /var/lib/vdsm
Yeela Kaplan has posted comments on this change. Change subject: sos plugin: collect /var/lib/vdsm .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f79e02dacd790d6ed8b1f5bea52674af5330c5e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert json-rpc: fix the Host.getVMList return value
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/301/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/295/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/710/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Michal Skrivanek has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38420/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1989: # Line 1990: # @memShared: Approximate amount of memory that is shared by VMs due to Line 1991: # the KSM feature (in bytes) Line 1992: # Line 1993: # @memCommitted:Amount of memory committed to running VMs (in MB) I'd add a not that this is obsolete (if implemented on engine side) since 3.6 and will be removed since we now have in+out Just so we can drop it in 4.y Line 1994: # Line 1995: # @swapTotal: The total amount of swap space (in MB) Line 1996: # Line 1997: # @swapFree:The amount of free swap space remaining (in MB) -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
Idan Shaby has uploaded a new change for review. Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API .. lvm: Update hsm.__processVGInfos() with lvm.getPV() new API In change I9932b044c (lvm: Raise an exception if missing physical volume), we changed lvm.getPV() to raise an InaccessiblePhysDev exception when the device is no longer in lvm's cache. This patch updates hsm.__processVGInfos() to log a warning in such a case since if we called lvm.getPV() with a device that is no longer in lvm's cache, we still want to get the information for the other PVs. That is, we don't want to stop hsm.__processVGInfos() operation. Note that blovkSD.getMetaDataMapping() also calls lvm.getPV(), but in contrast to hsm.__processVGInfos(), we don't want blovkSD.getMetaDataMapping() to handle InaccessiblePhysDev because it's a part of a scenario that creates a storage domain, and we want to fail the whole operation in case that the PV is no longer in lvm's cache. Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f Bug-Url: https://bugzilla.redhat.com/1048696 Signed-off-by: Idan Shaby ish...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/38421/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index b92349c..bbc0f84 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3000,7 +3000,11 @@ vgType != dev[devtype]): vgType = multipath.DEV_MIXED -pvInfo = lvm.getPV(pv) +try: +pvInfo = lvm.getPV(pv) +except se.InaccessiblePhysDev: +self.log.error(PV %s no longer exists, pv) +continue vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo, vgType)) if vgType == multipath.DEV_FCP: -- To view, visit https://gerrit.ovirt.org/38421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby ish...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Raise an exception if missing physical volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Raise an exception if missing physical volume .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16299/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15499/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16469/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/27442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: allow setLogLevel to tune a specific logger
Francesco Romani has uploaded a new change for review.
Change subject: api: allow setLogLevel to tune a specific logger
..
api: allow setLogLevel to tune a specific logger
the not widely known setLogLevel VDSM verb allows to dinamically tune
the log level of the root logger, until the next restart of VDSM.
This patch extends the API to let the client tune any specific
logger.
Change-Id: I8f40488fac04031552f36b9de026a0062ab81db0
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/vdsmapi-schema.json
3 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/38426/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 85478b1..593f336 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1360,7 +1360,7 @@
return {'status': doneCode, 'info': stats}
-def setLogLevel(self, level):
+def setLogLevel(self, level, name=None):
Set verbosity level of vdsm's log.
@@ -1382,8 +1382,10 @@
except KeyError:
return errCode['unavail']
else:
-logging.info('Setting loglevel to %s (%d)', level, log_level)
-_set_log_level(logging.getLogger(), log_level)
+logger = logging.getLogger(name)
+logging.info('Setting loglevel on %s to %s (%d)',
+ logger.name, level, log_level)
+_set_log_level(logger, log_level)
return {'status': doneCode}
# VM-related functions
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index b01b661..ea0e0c3 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -583,9 +583,9 @@
return api.fenceNode(addr, port, agent, username, password, action,
secure, options, policy)
-def setLogLevel(self, level):
+def setLogLevel(self, level, name=None):
api = API.Global()
-return api.setLogLevel(level)
+return api.setLogLevel(level, name)
def setMOMPolicy(self, policy):
api = API.Global()
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 1d919e8..854e7aa 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -4030,10 +4030,14 @@
#
# @level: The new verosity level desired
#
+# @name: #optional If present, change settings only for the logger
+# with this name. Otherwise, change settings for the top-level
+# logger (new in version 4.17.0).
+#
# Since: 4.10.0
##
{'command': {'class': 'Host', 'name': 'setLogLevel'},
- 'data': {'level': 'LoggingLevel'}}
+ 'data': {'level': 'LoggingLevel', '*name': 'str'}}
##
# @Host.setSafeNetworkConfig:
--
To view, visit https://gerrit.ovirt.org/38426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f40488fac04031552f36b9de026a0062ab81db0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: make usage of doneCode uniform
Francesco Romani has uploaded a new change for review.
Change subject: api: make usage of doneCode uniform
..
api: make usage of doneCode uniform
The usage of doneCode in VDSM is a little ugly,
but this patch makes it uniformly ugly, avoiding
pointless (and not yielding better results) diversions
from the common practice.
Change-Id: Ib782500fe24a4dcc948bf52558bcd7b0d93b6f9e
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/38423/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 6b8da3a..5cbda50 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1375,7 +1375,7 @@
isinstance(h, logging.FileHandler)]
fileHandler.setLevel(int(level))
-return dict(status=doneCode)
+return {'status': doneCode}
# VM-related functions
def getVMList(self, fullStatus=False, vmList=()):
--
To view, visit https://gerrit.ovirt.org/38423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib782500fe24a4dcc948bf52558bcd7b0d93b6f9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: use recommended logging
Francesco Romani has uploaded a new change for review.
Change subject: api: use recommended logging
..
api: use recommended logging
Update the logging in setLogLevel to use
less convoluted and more modern idiom.
Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/API.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/38422/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 42c471e..6b8da3a 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1369,8 +1369,7 @@
Doesn't survive a restart
-logging.getLogger('clientIF.setLogLevel').info('Setting loglevel '
- 'to %s' % level)
+logging.info('Setting loglevel to %s', level)
handlers = logging.getLogger().handlers
[fileHandler] = [h for h in handlers if
isinstance(h, logging.FileHandler)]
--
To view, visit https://gerrit.ovirt.org/38422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91c3b4aa3344b5093d13fb11e017394cf0bf52b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: streamline and make setLogLevel correct
Francesco Romani has uploaded a new change for review.
Change subject: API: streamline and make setLogLevel correct
..
API: streamline and make setLogLevel correct
According to the schema, setLogLevel should accept
a log level string ('DEBUG', 'INFO',...). But the code
actually blindly casted the given value to int(), and this suggests
the code actually expected an integer value.
To make things a bit user friendlier and comformant to schema, change
the argument to actually be a log level in string format.
Along the way, this patch streamlines the implementation of setLogLevel
and makes it simpler.
Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/API.py
1 file changed, 21 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/38425/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 5cbda50..85478b1 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1369,13 +1369,22 @@
Doesn't survive a restart
-logging.info('Setting loglevel to %s', level)
-handlers = logging.getLogger().handlers
-[fileHandler] = [h for h in handlers if
- isinstance(h, logging.FileHandler)]
-fileHandler.setLevel(int(level))
+LEVELS = {
+'DEBUG': logging.DEBUG,
+'INFO': logging.INFO,
+'WARNING': logging.WARNING,
+'ERROR': logging.ERROR,
+'CRITICAL': logging.CRITICAL
+}
-return {'status': doneCode}
+try:
+log_level = LEVELS[level]
+except KeyError:
+return errCode['unavail']
+else:
+logging.info('Setting loglevel to %s (%d)', level, log_level)
+_set_log_level(logging.getLogger(), log_level)
+return {'status': doneCode}
# VM-related functions
def getVMList(self, fullStatus=False, vmList=()):
@@ -1772,3 +1781,9 @@
logging.warn(options %s is deprecated. Use %s instead %
(k, _translationMap[k]))
options[_translationMap[k]] = options.pop(k)
+
+
+def _set_log_level(logger, log_level):
+for handler in logger.handlers:
+if isinstance(handler, logging.FileHandler):
+handler.setLevel(log_level)
--
To view, visit https://gerrit.ovirt.org/38425
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: json-rpc: export setLogLevel API
Francesco Romani has uploaded a new change for review.
Change subject: json-rpc: export setLogLevel API
..
json-rpc: export setLogLevel API
This API was already available over XMl-RPC.
There is no reason to leave JSON-RPC behind.
Change-Id: I7481a59fb5f0598a671118394e368eab79a381b5
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/rpc/Bridge.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/38424/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index 1d44b90..62773df 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -415,6 +415,7 @@
'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
+'Host_setLogLevel': {},
'Host_setupNetworks': {'ret': 'status'},
'Image_cloneStructure': {'ret': 'uuid'},
'Image_delete': {'ret': 'uuid'},
--
To view, visit https://gerrit.ovirt.org/38424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7481a59fb5f0598a671118394e368eab79a381b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: fix volume name parsing in getVmVolumeInfo
Sandro Bonazzola has posted comments on this change. Change subject: gluster: fix volume name parsing in getVmVolumeInfo .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/36237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfdbc573ec2aec31b78323253f8178425a07302c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make queryBlockJobs a periodic operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make queryBlockJobs a periodic operation .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2628/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15476/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16446/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore unresponsive on timeout when sampling
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: restore unresponsive on timeout when sampling .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2627/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16275/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15475/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16445/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2630/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1097/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16448/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1080/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/36730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: restore highWrite monitoring .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2631/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16279/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15479/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16449/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.
Francesco Romani has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 5:
(3 comments)
minor comments
https://gerrit.ovirt.org/#/c/38249/5/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:
Line 28:
Line 29: def __init__(self, conf, log, **kwargs):
Line 30: super(HostDevice, self).__init__(conf, log, **kwargs)
Line 31: self._deviceParams = {}
Line 32: self.macAddr = kwargs.get('macAddr')
why not _private?
Line 33:
Line 34: def detach(self):
Line 35:
Line 36: Detach the device from the host. This method *must* be
Line 43: return self._create_network_interface_xml()
Line 44: else:
Line 45: return self._create_generic_hostdev_xml()
Line 46:
Line 47: def _create_generic_hostdev_xml(self):
here _hostdev seems redundant.
_create_generic_xml()
seems a bit nicer
Line 48:
Line 49: Create domxml for a host device.
Line 50:
Line 51: devices
Line 86: return hostdev
Line 87:
Line 88: def _create_network_interface_xml(self):
Line 89:
Line 90: Create domxml for a host device.
this seems stale
Line 91:
Line 92: devices
Line 93: interface type='hostdev' managed='no'
Line 94: driver name='vfio'/
--
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2634/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15482/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16452/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make updateVolume a periodic operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make updateVolume a periodic operation .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2629/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16277/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15477/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16447/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2626/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15474/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16444/ : FAILURE -- To view, visit https://gerrit.ovirt.org/37592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2632/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16280/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15480/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16450/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: upgrade selinux dependency for gluster
Allon Mureinik has uploaded a new change for review. Change subject: spec: upgrade selinux dependency for gluster .. spec: upgrade selinux dependency for gluster Upgrade the SELinux policy dependency in order to require a fix that prevents creating GlusterFS domains on EL7. Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Bug-Url: https://bugzilla.redhat.com/1177651 Signed-off-by: Allon Mureinik amure...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/38414/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 0740530..f6efecc 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -221,7 +221,7 @@ Requires: lvm2 Requires: python Requires: policycoreutils-python -Requires: selinux-policy-targeted = 3.12.1-153.el7_0.13 +Requires: selinux-policy-targeted = selinux-policy-3.13.1-16.el7 %else Requires: python Requires: device-mapper-multipath = 0.4.9-52 -- To view, visit https://gerrit.ovirt.org/38414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9291da0ef9c078864bf56ffd4dec377fee358e92 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik amure...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Francesco Romani has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Francesco Romani has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 2: verified again running the tests -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...
Dan Kenigsberg has posted comments on this change. Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI) .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38354/3/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 143: for fname in (targetname, iface, tpgt, user, passwd, paddr, pport, netdev): Line 144: try: Line 145: with open(fname, r) as f: Line 146: res.append(f.read().strip()) Line 147: except (OSError, IOError, TypeError): netdev=None is not a surprise here. We should not just swallow all TypeError to avoid it. Please skip opening the filename if it is none to be None. if fname is None: res.append() continue Line 148: res.append() Line 149: Line 150: iqn, iface, tpgt, username, password, ip, port, netdev = res Line 151: port = int(port) -- To view, visit https://gerrit.ovirt.org/38354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of IO statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of IO statistics .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2633/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16451/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38391/2/tests/vmTests.py File tests/vmTests.py: Line 1299: self.assertEqual(int(testvm.conf['smp']), cpus) Line 1300: Line 1301: Line 1302: # we need a different ClientIF Fake because we need to Line 1303: # fake odd line breaking in comment. different ClientIF of what? Line 1304: # prepareVolumePath Line 1305: # and Line 1306: # teardownVolumePath Line 1307: -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Francesco Romani has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/37700/10/vdsm/hostdev.py File vdsm/hostdev.py: Line 185: def detach_detachable(device_name, only_get_params=False): Line 186: libvirt_device, device_params = _get_device_ref_and_params(device_name) Line 187: Line 188: if only_get_params: Line 189: return device_params I think it would be better (= nicer and more readable) if we instead add a little helper like def get_device_params(device_name): _, device_params = _get_device_ref_and_params(device_name) return device_params and the we use this new little helper from the outside, so this function can be left unchanged. Line 190: Line 191: iommu_group = device_params['iommu_group'] Line 192: Line 193: if device_params['capability'] in _UDEV_REQUIRING_CAPS: -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Martin Polednik has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 10: Verified+1 vdsmapi schema wasn't pushed, other than that copying +v -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] Adding cron job check for available updates of vdsm pa...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [wip] Adding cron job check for available updates of vdsm packages .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/534/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16261/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1092/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15461/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1075/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drive: allow error policy fine tuning
Francesco Romani has posted comments on this change. Change subject: vm: drive: allow error policy fine tuning .. Patch Set 8: version 8 just changes the commit message (no code changes), explaining in a better way the rationale for this patch. -- To view, visit https://gerrit.ovirt.org/38009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b1234ab15fc87ad75dfeae197d058eec23accbc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Ravi Nori rn...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: drop useless return value of VM.create
Francesco Romani has abandoned this change. Change subject: virt: drop useless return value of VM.create .. Abandoned this may be conceptually right, but timing for this patch is wrong. Will restore later on -- To view, visit https://gerrit.ovirt.org/34871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8689de514379285cb91cebc84be6ec5df5c9875b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: vm: remove _reportError
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: vm: remove _reportError .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2642/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16294/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15494/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16464/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23167c0289bdb0326dcfe48903cd1bae905e9b5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has abandoned this change. Change subject: DONTMERGE: virt: log device changes .. Abandoned -- To view, visit https://gerrit.ovirt.org/33641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Raise an exception if missing physical volume
Idan Shaby has posted comments on this change. Change subject: lvm: Raise an exception if missing physical volume .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/27442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9932b044c8b439dc8b1f09191a5d89f4bc44c38a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: factor out common fields in vm stats
Francesco Romani has abandoned this change. Change subject: vm: factor out common fields in vm stats .. Abandoned too little gains, let's save this for a future deeper refactoring -- To view, visit https://gerrit.ovirt.org/37698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ifb9e8acf3a872e34ed0a2b90e99111a63606e64d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
Idan Shaby has posted comments on this change. Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby ish...@redhat.com Gerrit-Reviewer: Idan Shaby ish...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: make usage of doneCode uniform
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: make usage of doneCode uniform .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16302/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16472/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib782500fe24a4dcc948bf52558bcd7b0d93b6f9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: streamline and make setLogLevel correct
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: streamline and make setLogLevel correct .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16304/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15504/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16474/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: introduce the 'response' module
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: introduce the 'response' module .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/535/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2641/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16293/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1101/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15493/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16463/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1084/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: bootstrap changeBlockDev tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: bootstrap changeBlockDev tests .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16296/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16466/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906ae55f6582833f5f023ce64bdd28c02ede33b2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: allow setLogLevel to tune a specific logger
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: allow setLogLevel to tune a specific logger .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16475/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f40488fac04031552f36b9de026a0062ab81db0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: remove obfuscated use of errCode
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: remove obfuscated use of errCode .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2644/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16297/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15497/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16467/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5944a3ac9433fa3c85879f4a16b5b6730c2b50b6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
oVirt Jenkins CI Server has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16298/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15498/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16468/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16300/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15500/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16470/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby ish...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: Handle image end offset on different lines of output
Ala Hino has posted comments on this change. Change subject: qemu-img: Handle image end offset on different lines of output .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6610baf1702c9075d8512bdb1da0e05527a0060 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Add number of in/out migrations
Francesco Romani has posted comments on this change. Change subject: host stats: Add number of in/out migrations .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7d333a34503701b998c656c72d67790c9f58af Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Peřina mper...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 6: (1 comment) good enough for me now. Was that verified? https://gerrit.ovirt.org/#/c/37075/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3032: self._attachLibvirtDomainAfterMigration( Line 3033: self._incomingMigrationFinished.isSet(), usedTimeout) Line 3034: # else domain connection already established earlier Line 3035: self._domDependentInit() Line 3036: self._handleActualDowntime() _getActualDowntime? Quite minor thing however Line 3037: del self.conf['migrationDest'] Line 3038: hooks.after_vm_migrate_destination(self._dom.XMLDesc(0), self.conf) Line 3039: Line 3040: for dev in self._customDevices(): -- To view, visit https://gerrit.ovirt.org/37075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Update qemu requirement in EL7
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Update qemu requirement in EL7
..
spec: Update qemu requirement in EL7
Update the required qemu-kvm and qemu-img packages to consume a bugfix
which prevents running VMs with more than 23 snapshots.
Change-Id: Iea5a0fea7631fc9128eac49ea2cdda24a42de352
Bug-Url: https://bugzilla.redhat.com/1199014
Signed-off-by: Allon Mureinik amure...@redhat.com
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/38408/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0740530..aadf43a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -260,8 +260,8 @@
%if 0%{?rhel}
%if 0%{?rhel} = 7
-Requires: qemu-kvm%{?rhev_suffix}
-Requires: qemu-img%{?rhev_suffix}
+Requires: qemu-kvm%{?rhev_suffix} = 2.1.2-23
+Requires: qemu-img%{?rhev_suffix} = 2.1.2-23
%else
Requires: qemu-kvm%{?rhev_suffix} = 2:0.12.1.2-2.422
Requires: qemu-img%{?rhev_suffix} = 2:0.12.1.2-2.422
--
To view, visit https://gerrit.ovirt.org/38408
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea5a0fea7631fc9128eac49ea2cdda24a42de352
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik amure...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Properly log and return an error if the threadFacto...
Yeela Kaplan has posted comments on this change. Change subject: jsonrpc: Properly log and return an error if the threadFactory fails .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/35936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b579fa0e95397f1dc3b3e939a9040dc5bdef36d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Skip netdev probe from sessions missing iscsi sysfs (i.e. us...
Amador Pahim has posted comments on this change. Change subject: Skip netdev probe from sessions missing iscsi sysfs (i.e. using hardware iSCSI) .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f273fddff2235f15197c6689de5e6374fda6f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmdevices: remove duplicate slot in audio device
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: remove duplicate slot in audio device .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/299/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/676/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/303/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/293/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6522/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/708/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40e78734eb12798d801f66a9e85ac53034568902 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
