Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..


Patch Set 2:

(12 comments)

A lot of suggestions make sense for different patch series - the removal of 
Architecture class, getting rid of CPU_MAP.xml parsing etc. do make sense AFTER 
we have the code untangled and sitting in it's own module. Only the most 
essential code changes are included in this series.

https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:

Line 25:__init__.py \
Line 26:cmdutils.py \
Line 27:compat.py \
Line 28:concurrent.py \
Line 29:cpuarch.py \
> Why not arch.py?  This is the term used in the kernel and in packaging, and
Too many name clashes at this point - the term is too generic e.g. arch = 
Architecture.x86_64...
Line 30:define.py \
Line 31:dmidecodeUtil.py \
Line 32:exception.py \
Line 33:executor.py \


https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:

Line 22: 
Line 23: from .config import config
Line 24: 
Line 25: 
Line 26: class Architecture:
> This class useless, we have 4 constants, putting them under a class does no
Good point for future patch (series) to refactor the bits.
Line 27: X86_64 = 'x86_64'
Line 28: PPC64 = 'ppc64'
Line 29: PPC64LE = 'ppc64le'
Line 30: POWER = (PPC64, PPC64LE)


Line 26: class Architecture:
Line 27: X86_64 = 'x86_64'
Line 28: PPC64 = 'ppc64'
Line 29: PPC64LE = 'ppc64le'
Line 30: POWER = (PPC64, PPC64LE)
> Having different types for enums is a bad idea, make the user code inconsis
Something I (and afaik fromani) would like to eventually add - it would fit 
into the patch series mentioned above.
Line 31: 
Line 32: 
Line 33: class UnsupportedArchitecture(Exception):
Line 34: def __init__(self, target_arch):


Line 34: def __init__(self, target_arch):
Line 35: self._target_arch = target_arch
Line 36: 
Line 37: def __str__(self):
Line 38: return '{}'.format(self._target_arch)
> This is not very helpful message. Is this part of vdsm api, or internal err
Internal error, not really used outside of cpuarch.
Line 39: 
Line 40: 
Line 41: def arch_to_cpu_map(target_arch=None):
Line 42: '''


Line 37: def __str__(self):
Line 38: return '{}'.format(self._target_arch)
Line 39: 
Line 40: 
Line 41: def arch_to_cpu_map(target_arch=None):
> cpu_map is not good name, since this returns a single value, not a map.
It is still translation to libvirt's CPU_MAP and should be removed as soon as 
possible as we shouldn't touch that file at all. Not sure if there are any 
benefits for the time being of different name, and if yes I'd rather see 
arch_to_libvirt_cpu_map.
Line 42: '''
Line 43: Convert the CPU architecture to a libvirt's cpu_map representation.
Line 44: 
Line 45: Arguments:


Line 85: '''
Line 86: return _cpu_arch_to_architecture(platform.machine())
Line 87: 
Line 88: 
Line 89: def target():
> And this is the effective architecture. current and target are very confusi
Mostly agree. 'real' and 'effective' sound somewhat better.
Line 90: '''
Line 91: Get the target VM runtime architecture. This function exists to 
modify the
Line 92: architecture reported in vds capabilities and VMs. It is required 
because
Line 93: some functions require to know the real architecture, while the 
others are


Line 98: The runtime architecture of VDSM
Line 99: or
Line 100: raises UnsupportedArchitecture exception.
Line 101: '''
Line 102: if config.getboolean('vars', 'fake_kvm_support'):
> Is this a new config? rename it to fake_kvm_enable if new.
It is not, for the sake of backwards compatibility.
Line 103: return _cpu_arch_to_architecture(
Line 104: config.get('vars', 'fake_kvm_architecture'))
Line 105: else:
Line 106: return current()


Line 109: def _cpu_arch_to_architecture(target_arch):
Line 110: mapping = {
Line 111: 'x86_64': Architecture.X86_64,
Line 112: 'ppc64': Architecture.PPC64,
Line 113: 'ppc64le': Architecture.PPC64LE
> Looks like the input and the output of this function are the same. Do we re
The input is a string while output is class attribute - the mapping exists as 
we lack the predicates.
Line 114: }
Line 115: 
Line 116: try:
Line 117: arch = mapping[target_arch]


https://gerrit.ovirt.org/#/c/49972/2/tests/vmTests.py
File tests/vmTests.py:

Line 212: 
Line 213: for vmConf, osXML in zip(vmConfs, expectedXMLs):
Line 214: vmConf.update(self.conf)
Line 215: domxml = vmxml.Domain(vmConf, self.log,
Line 216:   cpuarch.Architecture.X86_64)
> Are you sure you need to break this line? other lines around look the same.
See the first argument - vmConf pushes the line 

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 6:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: move libvirt configuration into a separate module

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: move libvirt configuration into a separate module
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I775edc776c738822ed955ffb0b7885dae450b667
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: remove unused parameter

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: remove unused parameter
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: fix getVdsCaps and getVdsStats

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49698
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc8298a737fccea626b4419bd7d462cc830afc2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Only report progress if set

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jobs: Only report progress if set
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50355/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 98: ret = {'status': self.status,
Line 99:'description': self.description,
Line 100:'job_type': self.job_type}
Line 101: 
Line 102: if self.progress is not None:
Please make sure to reflect this change in the schema.
Line 103: ret['progress'] = self.progress
Line 104: 
Line 105: if self.error:
Line 106: ret['error'] = self.error.response()


-- 
To view, visit https://gerrit.ovirt.org/50355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 8:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Mapping bonding option value names to numerics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
..


Patch Set 1:

Eliminating the default MTU from engine:
https://gerrit.ovirt.org/#/c/28097/

Therefore setupNetwork will always have the network MTU set when coming from 
Engine.

-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2: Code-Review+2

huge patch, trusting you guys!

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49694

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Verified+1

re-verified on branch, subset of tests done for master patch

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
..


Patch Set 1:

IMO, having independent guards on both Engine and VDSM is preferred.
Either handle defaults at the VDSM side (like in the current patch) or to 
validate the network command and assure MTU exist, otherwise to fail the setup.

-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add run_async helper

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add run_async helper
..


Patch Set 5: Code-Review-1

(1 comment)

will simplify a bit more, let's save changes for the next patches.

https://gerrit.ovirt.org/#/c/49570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 680: self.updateDriveIndex(drv)
Line 681: 
Line 682: return [drv for order, drv in drives]
Line 683: 
Line 684: def run(self, spawn=run_async):
> this method didn't return anything before (it seems), do you utilize this n
Yes, I'd like to use this in cif/API.py.
The alternative is to let the exception bubble up.
For this patch maybe better just having the latter way, let me update this.
Line 685: try:
Line 686: spawn(self._startUnderlyingVm)
Line 687: except AsyncStartError as ex:
Line 688: return response.error(ex.error)


-- 
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfb405389c465d2a8b8fc8b6f958926d58167a26
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: 
hostdev.detach_detachable(params.get(hwclass.HOSTDEV))
> Why get()? If hostdev is missing from a hostdev device, we should explode h
Done
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


Line 2273: 
Line 2274: try:
Line 2275: self._dom.detachDevice(nicXml)
Line 2276: self._waitForDeviceRemoval(nic)
Line 2277: if nic and nic.is_hostdevice:
> Same issue: can nic ever be None here?
Done
Line 2278: hostdev.reattach_detachable(nic.hostdev)
Line 2279: except HotunplugTimeout as e:
Line 2280: self.log.error("%s", e)
Line 2281: return response.error('hotunplugNic', "%s" % e)


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: better rollback
..


hooks: ovs: better rollback

Until now, OVS hook was not able to rollback after failed
setup of non-OVS networks.

Now it uses after_network_setup and after_network_setup_fail
hook points to handle general rollback for all failures
(both OVS and non-OVS).

Before OVS setup we save initial OVS configuration to a temporary
file via pickle. If an exception occurs during setupNetworks,
API.py does the standard rollback. Then after_network_setup_fail
is executed and runs setupNetworks with a special option _inOVSRollback
which triggers OVS-only rollback. OVS-only rollback removes all
OVS networks and recreates them according to configuration saved in
the temprorary file. When everything is done, temporary file is
removed.

Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/46907
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49693
Reviewed-by: Francesco Romani 
Continuous-Integration: Dan Kenigsberg 
---
M debian/vdsm-hook-ovs.install
M vdsm.spec.in
M vdsm_hooks/ovs/Makefile.am
M vdsm_hooks/ovs/README
A vdsm_hooks/ovs/ovs_after_network_setup.py
A vdsm_hooks/ovs/ovs_after_network_setup_fail.py
M vdsm_hooks/ovs/ovs_before_network_setup.py
M vdsm_hooks/ovs/ovs_utils.py
8 files changed, 243 insertions(+), 94 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 2: Continuous-Integration+1

Unrelated error

 11:59:44 ERROR: testSymlinkMount (mountTests.MountTests)
11:59:44 --
11:59:44 Traceback (most recent call last):
11:59:44   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/mountTests.py",
 line 150, in testSymlinkMount
11:59:44 m.mount(mntOpts="loop")
11:59:44   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 225, in mount
11:59:44 return self._runcmd(cmd, timeout)
11:59:44   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 241, in _runcmd
11:59:44 raise MountError(rc, ";".join((out, err)))
11:59:44 MountError: (32, ';mount: /var/tmp/tmp_U8agE/backing.img: failed to 
setup loop device: No such file or directory\n')

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: tests: More testVideoXML tests

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: tests: More testVideoXML tests
..


Patch Set 1: Verified+1

Verified by running the tests.

-- 
To view, visit https://gerrit.ovirt.org/50420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: tests: More testVideoXML tests

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: tests: More testVideoXML tests
..

virt: tests: More testVideoXML tests

As suggested in
https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py@296, we should
try various combinations of presence and non-presence of video device
attributes in the related test.

Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229
Signed-off-by: Milan Zamazal 
---
M tests/deviceTests.py
1 file changed, 21 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/50420/1

diff --git a/tests/deviceTests.py b/tests/deviceTests.py
index 977ec23..8f0bac9 100644
--- a/tests/deviceTests.py
+++ b/tests/deviceTests.py
@@ -286,16 +286,27 @@
 sound = vmdevices.core.Sound(self.conf, self.log, **dev)
 self.assertXMLEqual(sound.getXML().toxml(), soundXML)
 
-def testVideoXML(self):
-videoXML = """
-
-
-"""
-
-dev = {'device': 'vga',
-   'specParams': {'vram': '32768', 'heads': '2', 'vgamem': '8192'}}
-video = vmdevices.core.Video(self.conf, self.log, **dev)
-self.assertXMLEqual(video.getXML().toxml(), videoXML)
+@permutations([
+[{'device': 'vga',
+  'specParams': {'vram': '32768', 'heads': '2'}},
+ """
+ 
+ """],
+[{'device': 'qxl',
+  'specParams': {'vram': '65536', 'heads': '2', 'ram': '131072'}},
+ """
+ 
+ """],
+[{'device': 'qxl',
+  'specParams': {'vram': '32768', 'heads': '2',
+ 'ram': '65536', 'vgamem': '8192'}},
+ """
+ 
+ """]
+])
+def testVideoXML(self, dev_spec, video_xml):
+video = vmdevices.core.Video(self.conf, self.log, **dev_spec)
+self.assertXMLEqual(video.getXML().toxml(), video_xml)
 
 def testInterfaceXML(self):
 interfaceXML = """


-- 
To view, visit https://gerrit.ovirt.org/50420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: tests: More testVideoXML tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: tests: More testVideoXML tests
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 5:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/50363/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-12 17:40:31 +0200
Line 4: Commit: Ala Hino 
Line 5: CommitDate: 2015-12-13 16:51:52 +0200
Line 6: 
Line 7: gluster: Warn about missing glusterfs-cli package
> Please update the commit message - this is not about the warning, but about
Done
Line 8: 
Line 9: In 3.6 we introduced a dependency to glusterfs-cli. This is required in
Line 10: order to get gluster volume info needed to get gluster backup servers
Line 11: and replica related logic. Howevre, we found tht during upgrade, if


https://gerrit.ovirt.org/#/c/50363/4/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1588: except OSError as e:
Line 1589: if e.errno != os.errno.ENOENT:
Line 1590: raise
Line 1591: return False
Line 1592: return True
> This means that gluster was found in the first time _glusterCommandPath.cmd
Done


https://gerrit.ovirt.org/#/c/50363/4/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 338
Line 339
Line 340
Line 341
Line 342
> We should check here if gluster exists. If it does not, log a big warning a
Done


Line 359: def _get_gluster_volinfo(self):
Line 360: if not gluster_cli.gluster_exists():
Line 361: self.log.warning("Required glusterfs-cli package is 
missing "
Line 362:  "on this host. Please install the 
package "
Line 363:  "in order to use gluster storage")
> This check must be done earlier. If gluster is not installed, there is no p
Done
Line 364: 
Line 365: volinfo = 
supervdsm.getProxy().glusterVolumeInfo(self._volname,
Line 366:  
self._volfileserver)
Line 367: return volinfo[self._volname]


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 2:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49688

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: reformat __set_cpu_affinity
..


Patch Set 3: Verified+1

verified like (and with) 49614

-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: sysctl: enable ipv6
..


net: sysctl: enable ipv6

Enable sysctl.py:disable_ipv6(dev) to set /pro/sys/.../disable_ipv6
also to '0'. This is needed in following Open vSwitch hook patch.

Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/44992
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49687
Reviewed-by: Ido Barkan 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/sysctl.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: multicast snooping is not supported by ovs until 2.4.0

[fromani]

Francesco Romani has posted comments on this change.

Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5a2987fb71b8e5d5f5ffb0f2bc141b6c9c7af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: executor: report worker status in __repr__

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: executor: report worker status in __repr__
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/49722/4//COMMIT_MSG
Commit Message:

Line 7: lib: executor: report worker status in __repr__
Line 8: 
Line 9: To make the troubleshooting of stuck workers
Line 10: easier, we extend Worker.__repr__ to report the
Line 11: state, which could be 'discarded' or 'available'.
Please update to reflect the current implementation. I think it will be useful 
to show the various logs we can get here.
Line 12: 
Line 13: Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42
Line 14: Backport-To: 3.6


https://gerrit.ovirt.org/#/c/49722/4/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 218: def __repr__(self):
Line 219: return "" % (
Line 220: self.name,
Line 221: ("waiting" if self._callable is None
Line 222:   else "running %s" % self._callable),
This is a good example when the ternary operation should not be used. It is 
better to create the string "waiting" and "running "  before formatting.
Line 223: " discarded" if self._discarded else "",
Line 224: id(self)
Line 225: )
Line 226: 


-- 
To view, visit https://gerrit.ovirt.org/49722
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
..


Patch Set 7:

* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Check Product::#1290997::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Enable xunit report

[nsoffer]

Nir Soffer has restored this change.

Change subject: automation: Enable xunit report
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/46640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Ie8c09cf21e7cf4a97b7b006f2b3ebe4943ed72b9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: daemon: reformat __set_cpu_affinity
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:

Line 105: else:
Line 106: return current()
Line 107: 
Line 108: 
Line 109: def _cpu_arch_to_architecture(target_arch):
> This is confusing. In this module (cpuarch), you are using the term arch an
It does not come from platform.machine(); the architecture is used to refer to 
the Architecture class and arch/cpu_arch to the real architecture.
Line 110: mapping = {
Line 111: 'x86_64': Architecture.X86_64,
Line 112: 'ppc64': Architecture.PPC64,
Line 113: 'ppc64le': Architecture.PPC64LE


-- 
To view, visit https://gerrit.ovirt.org/49972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46bb51769562fbb9d816d190c2aebfd0660cc3b0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/49505/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 52: 
Line 53: _V2V_DIR = os.path.join(P_VDSM_RUN, 'v2v')
Line 54: _VIRT_V2V = CommandPath('virt-v2v', '/usr/bin/virt-v2v')
Line 55: _SSH_AGENT = CommandPath('ssh-agent', '/usr/bin/ssh-agent')
Line 56: _SSH_ADD = CommandPath('ssh-add', '/usr/bin/ssh-add')
> are these hard dependencies? If so we need additions to vdsm.spec (and debi
yes, I will add dependencies.
Line 57: _XEN_SSH_PROTOCOL = 'xen+ssh'
Line 58: _SSH_AUTH_RE = '(SSH_AUTH_SOCK)=([^;]+).*'
Line 59: _OVF_RESOURCE_CPU = 3
Line 60: _OVF_RESOURCE_MEMORY = 4


Line 541: raise V2VError('Error killing ssh-agent, exit code: %r, 
msg: %s' %
Line 542:proc.returncode, err)
Line 543: 
Line 544: def environments(self):
Line 545: return super.environments.update(self.env)
> maybe super() ?
Done
Line 546: 
Line 547: 
Line 548: class ImportVm(object):
Line 549: TERM_DELAY = 30


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Add error property

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jobs: Add error property
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50354/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 99:'progress': self.progress,
Line 100:'job_type': self.job_type}
Line 101: 
Line 102: if self.error:
Line 103: ret['error'] = self.error.response()
It looks like this is api change but schema is not updated.
Line 104: 
Line 105: return ret
Line 106: 
Line 107: def abort(self):


-- 
To view, visit https://gerrit.ovirt.org/50354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f6e27bcd69db1673e5168524b0ce94f2e9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pablo Iranzo Gómez
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: after_network_setup_fail

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: after_network_setup_fail
..


Patch Set 2:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49689

-- 
To view, visit https://gerrit.ovirt.org/49688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: after_network_setup_fail

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hooks: after_network_setup_fail
..


hooks: after_network_setup_fail

When an exception occurs during network setup, rollback is executed
and after_network_setup is never triggered.

This hook point triggers hooks right after setupNetworks fails and
finishes its rollback.

We need this for Open vSwitch hook. However, this hook point might
be useful for other cases as well.

Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/45085
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49688
Continuous-Integration: Dan Kenigsberg 
Reviewed-by: Francesco Romani 
---
M debian/vdsm.dirs
M vdsm.spec.in
M vdsm/API.py
M vdsm/hooks.py
M vdsm/vdsmd.8.in
M vdsm_hooks/Makefile.am
6 files changed, 33 insertions(+), 8 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: after_network_setup_fail

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: after_network_setup_fail
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49688
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5d086b15b72c13d2b390c1310c2279446ac14f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: use six.iteritems and six.itervalues

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: use six.iteritems and six.itervalues
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49697
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d098a3142f61e927e047058424d2bd6f6955145
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 2:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: reformat __set_cpu_affinity
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: daemon: reformat __set_cpu_affinity
..


daemon: reformat __set_cpu_affinity

Reformat the code to use the 'early return' idiom.
No intended changes in functionality.

Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1286462
Bug-Url: https://bugzilla.redhat.com/1279431
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/49561
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/49613
Reviewed-by: Milan Zamazal 
---
M vdsm/vdsm
1 file changed, 15 insertions(+), 13 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[automation]

gerrit-hooks has posted comments on this change.

Change subject: daemon: reformat __set_cpu_affinity
..


Patch Set 4:

* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1286462#1286462FAILED, illegal change from VERIFIED
* Set MODIFIED::bug 1286462bug 1279431#1279431IGNORE, not all 
related patches are closed, check 49614

-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

[fromani]

Francesco Romani has posted comments on this change.

Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..


Patch Set 8: Code-Review+1

gerrit hides Nir's score, temporary changing mine (but I don't have further 
comments yet).

-- 
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd032471396a97999c2cea5c88ae04ec8ca4028
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
..


Patch Set 1:

(12 comments)

-1 for code, +1 for this approach.
We cannot change the API. If we currently allow MTU to be None we should keep 
allowing it. However, from the very beginning of the setupNetworks API call, 
the code is a lot easier to handle if it can assume as many predicates on the 
input as possible. This solution adds the first one and this is good.

https://gerrit.ovirt.org/#/c/50397/1//COMMIT_MSG
Commit Message:

Line 8: 
IMO you should explain that because of the default behaviour of vdsm- letting 
the OS to determine the default MTU for created devices causes it to not keep 
the supremum MTU needed. Moreover, expecting a default MTU and discovering a 
non-default MTU  during networks restoration will cause unnecessary restoration 
of networks.


Line 14: us
is


https://gerrit.ovirt.org/#/c/50397/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 268: if mtu:
: mtu = int(mtu)
this transformation is not needed anymore


Line 323: if mtu:
This also need to be reconsidered now. We should update the bridges and the 
existing tap devices if their current MTU is different then the requested one.


Line 899: _compliment_net_defaults(networks)
after this call- I think kernelconfig._normalize_mtu is not needed anymore, as 
we will always persist some mtu.


Line 967: compliment
complement


Line 969: a network
networks


Line 972: net
it is idiomatic to call unneeded variables '_'. Moreover, if you don't need the 
keys, call
  six.itervalues(nets)


Line 972: _nets_attr
the convention is to not prefix method variables with '_'.


Line 973:   if 'remove' not in att or att['remove'] is not True)
Line 974: for attr in _nets_attr:
Line 975: if 'mtu' not in attr:
Line 976: attr['mtu'] = DEFAULT_MTU
Line 977: 
I prefer a functional approach:
  netowrks = _compliment_net_defaults(networks)
treating parameters as immutable. This makes it easy to test later.
Line 978: 
Line 979: def setSafeNetworkConfig():
Line 980: """Declare current network configuration as 'safe'"""
Line 981: utils.execCmd([constants.EXT_VDSM_STORE_NET_CONFIG,


https://gerrit.ovirt.org/#/c/50397/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 43: from vdsm.netinfo.mtus
we try to keep import statements sorted alphabetically (it make sit easier to 
find them later)


Line 1045: # Add additional nic to the bond
 : # Expect to see nics MTU to be DEFAULT.
 : status, msg = self.setupNetworks(
 : {}, {BONDING_NAME: dict(nics=nics)}, NOCHK)
 : 
 : self.assertEquals(status, SUCCESS, msg)
 : 
 : self.assertMtu(DEFAULT_MTU, BONDING_NAME,
 :nics[0], nics[1], nics[2])
this part should come at a stage when the expected MTU of the bond+slaves is 
different than the default (earlier).


-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Correctly apply MTU values on networks

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
..


Patch Set 1: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: multicast snooping is not supported by ovs until 2.4.0

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..


net: multicast snooping is not supported by ovs until 2.4.0

Change-Id: Ie1b5a2987fb71b8e5d5f5ffb0f2bc141b6c9c7af
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/46633
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49690
Reviewed-by: Francesco Romani 
---
M vdsm_hooks/ovs/README
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1b5a2987fb71b8e5d5f5ffb0f2bc141b6c9c7af
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: move libvirt configuration into a separate module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: move libvirt configuration into a separate module
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49692

-- 
To view, visit https://gerrit.ovirt.org/49691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I775edc776c738822ed955ffb0b7885dae450b667
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hooks: Open vSwitch configurator
..


hooks: Open vSwitch configurator

This patch introduces new hook which allows us to configure OVS network
instead of standard linux network.

Configuration is done by one big ovs-vsctl command executed at once, it
apply the whole configuration iff all commands are correct.

Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/40312
Reviewed-by: Ido Barkan 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49689
Continuous-Integration: Dan Kenigsberg 
Reviewed-by: Francesco Romani 
---
M .gitignore
M configure.ac
A debian/vdsm-hook-ovs.docs
A debian/vdsm-hook-ovs.install
M tests/functional/Makefile.am
A tests/functional/networkTestsOVS.py
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/ovs/Makefile.am
A vdsm_hooks/ovs/README
A vdsm_hooks/ovs/ovs_after_get_caps.py
A vdsm_hooks/ovs/ovs_after_get_stats.py
A vdsm_hooks/ovs/ovs_before_device_create.py
A vdsm_hooks/ovs/ovs_before_network_setup.py
A vdsm_hooks/ovs/ovs_before_network_setup_ip.py
A vdsm_hooks/ovs/ovs_before_network_setup_mtu.py
A vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
A vdsm_hooks/ovs/ovs_utils.py
A vdsm_hooks/ovs/sudoers.in
19 files changed, 1,901 insertions(+), 0 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49690

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: executor: report worker status in __repr__

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: executor: report worker status in __repr__
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49722
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: remove unused parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: remove unused parameter
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49693

-- 
To view, visit https://gerrit.ovirt.org/49692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: better rollback
..


Patch Set 2:

waiting for another jenkins run

-- 
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: move libvirt configuration into a separate module

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hooks: ovs: move libvirt configuration into a separate module
..


hooks: ovs: move libvirt configuration into a separate module

Libvirt configuration has nothing to do with OVS configuration.

The main reason is to move creation of new libvirt networks to a place
where almost all configuration is completed, so an eventual rollback
doesn't have to do any extra work. This is necessary for the following
'improve ovs rollback' patch.

Change-Id: I775edc776c738822ed955ffb0b7885dae450b667
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/46910
Reviewed-by: Ondřej Svoboda 
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49691
Continuous-Integration: Dan Kenigsberg 
Reviewed-by: Francesco Romani 
---
M debian/vdsm-hook-ovs.install
M vdsm.spec.in
M vdsm_hooks/ovs/Makefile.am
M vdsm_hooks/ovs/ovs_before_network_setup.py
A vdsm_hooks/ovs/ovs_before_network_setup_libvirt.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
6 files changed, 73 insertions(+), 38 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I775edc776c738822ed955ffb0b7885dae450b667
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: remove unused parameter

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hooks: ovs: remove unused parameter
..


hooks: ovs: remove unused parameter

Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/48267
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan 
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49692
Reviewed-by: Francesco Romani 
---
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: multicast snooping is not supported by ovs until 2.4.0

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49691

-- 
To view, visit https://gerrit.ovirt.org/49690
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5a2987fb71b8e5d5f5ffb0f2bc141b6c9c7af
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: spec: Require newer qemu version for el7
..

spec: Require newer qemu version for el7

Bumping qemu version to 2.3.0-31.el7_2.4 in order to avoid
a potential assertion error after lvextend caused by a memory
corruption in the block sub-system.

For more details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1277922
* http://marc.info/?l=qemu-devel=144740716414450=2

We don't require the package on CentOS, since it is not available yet.

Bug-Url: https://bugzilla.redhat.com/1279052

Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Signed-off-by: Daniel Erez 
---
M vdsm.spec.in
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/50435/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index d7b6ae8..4ca82cb 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -234,9 +234,15 @@
 %endif
 
 %if 0%{?rhel}
+%if 0%{?centos}
+# TODO: Remove when qemu-kvm-rhev 2.3.0-31.el7_2.4 is available
 Requires: qemu-kvm-rhev >= 10:2.3.0-13.el7
 Requires: qemu-img-rhev >= 10:2.3.0-13.el7
 %else
+Requires: qemu-kvm-rhev >= 10:2.3.0-31.el7_2.4
+Requires: qemu-img-rhev >= 10:2.3.0-31.el7_2.4
+%endif # centos
+%else
 Requires: qemu-kvm >= 2:2.3.0
 Requires: qemu-img >= 2:2.3.0
 %endif # rhel


-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 1:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: reformat __set_cpu_affinity

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: daemon: reformat __set_cpu_affinity
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a433c8c6706ae4a1224870312f7256efda8a54
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: Added VDSM verb to stop gluster related processes
..


Patch Set 2: Code-Review+1

looks OK, waiting for one more review (Dan?)

-- 
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: daemon: keep running without affinity.
..


daemon: keep running without affinity.

The cpu affinity is one (important) performance setting,
but Vdsm should keep running even if it fails to set it.

To run without affinity doesn't harm the functionality.

Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/49562
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/49614
---
M vdsm/vdsm
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 3:

* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431OK

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: vm: Update time on VM after resume

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 10: Code-Review+2

nicer this way, next time I'll push a bit more in this direction :)

-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add get_volume_artifacts_class to the domain manifest
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50339
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iade716f7487f502243aaf280a7a8c147f501307d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: define file extension for volume artifacts metadata
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id14e79d400d6936c8bb0da5dec39e3f9fb60c803
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: add create_volume_container API stub

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: add create_volume_container API stub
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5253b6692b8c58967bbd2c421abcce05c584d769
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storagefakelib: Add FakeResourceManager
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50340
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0302b48d984ce7eb8ce2326ab4bb033430c032f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Code-Review-1

+1 for the concept
-1 for the implementation because as Allon pointed out in 
d60db71036d4c47b71fc519c2497ac4be7ba70e2
since oVirt projects provides -ev package, we don't need the split anymore. Or 
do we?

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: extract specific classes for libvirt and ova
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/49951/4/tests/v2vTests.py
File tests/v2vTests.py:

Line 354: self.assertEquals(network['macAddr'], 
_mac_from_uuid(spec.vmid))
Line 355: self.assertEquals(network['bridge'], 'VM Network')
Line 356: 
Line 357: @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
Line 358: @MonkeyPatch(v2v, '_V2V_DIR', '/tmp/')
> please check if elsewhere we use NamedTemporaryDir(). If so, please use it 
Done
Line 359: def testSuccessfulImport(self):
Line 360: vminfo = {'vmName': self.vm_name,
Line 361:   'poolID': self.pool_id,
Line 362:   'domainID': self.domain_id,


https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:

Line 159: 
Line 160: 
Line 161: def convert_external_vm(uri, username, password, vminfo, job_id, irs):
Line 162: command = LibvirtCommand(uri, username, password, vminfo, job_id, 
irs)
Line 163: job = ImportVm(command)
> job_id belongs to the job, not to the LibvirtCommand.
both need it.
The job id represent the job id in our v2v.py 
and its actually the VM id which needed by the command
the parameter --vdsm-vm-uuid.
I will add it as a member to ImportVM,
We can add it to the BaseCommmand as well or we can pass it via execute.
Line 164: job.start()
Line 165: _add_job(job_id, job)
Line 166: return {'status': doneCode}
Line 167: 


-- 
To view, visit https://gerrit.ovirt.org/49951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2:

* #1279052::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279052::OK, public bug
* Check Product::#1279052::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Introduce VolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Introduce VolumeArtifacts
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[derez]

Daniel Erez has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: All outstanding VolumeMetadata changes squashed
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db8bb8bdf405b8760ecbe103dcbb1a1907ca1db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

[automation]

gerrit-hooks has posted comments on this change.

Change subject: XXX: Add _getDeletedImagePath until patch merged
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50218
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd67cacc58da27ffda7286582e263195dac96894
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: jobs: Only report progress if set

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jobs: Only report progress if set
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Add tests for get_ova_info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Add tests for get_ova_info
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id73516164e81e609c70caeac20fb819eaf04a56b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: image: Make progress report interval configurable

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: image: Make progress report interval configurable
..


image: Make progress report interval configurable

Previously we logged a progress report every 60 seconds during qemu-img
operations. This seems too long, in particular when watching the logs
during testing. Decrease the interval to 30 seconds, and make it
configurable (irs:progress_interval).

Here is an example, using 10 seconds progress interval:

2015-12-14 00:15:39,042 waiting for qemu-img operation to complete
2015-12-14 00:15:49,045 qemu-img operation progress: 9.11%
2015-12-14 00:15:59,041 qemu-img operation progress: 20.25%
2015-12-14 00:16:09,042 qemu-img operation progress: 29.36%
2015-12-14 00:16:19,043 qemu-img operation progress: 39.48%
2015-12-14 00:16:29,043 qemu-img operation progress: 50.62%
2015-12-14 00:16:39,039 qemu-img operation progress: 60.74%
2015-12-14 00:16:49,038 qemu-img operation progress: 69.85%
2015-12-14 00:16:59,042 qemu-img operation progress: 79.97%
2015-12-14 00:17:09,044 qemu-img operation progress: 91.11%
2015-12-14 00:17:17,828 qemu-img operation progress: 100.0%
2015-12-14 00:17:17,829 qemu-img operation has completed

Change-Id: Ice27c49cc4902c24325e0d96eadec50532dfe40f
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/50405
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M lib/vdsm/config.py.in
M vdsm/storage/image.py
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice27c49cc4902c24325e0d96eadec50532dfe40f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: image: Make progress report interval configurable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Make progress report interval configurable
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice27c49cc4902c24325e0d96eadec50532dfe40f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: extract specific classes for libvirt and ova

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: v2v: extract specific classes for libvirt and ova
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:

Line 303: def execute(self):
Line 304: self._generate_disk_parameters()
Line 305: self._prepare_volumes()
Line 306: try:
Line 307: self._proc = execCmd(self._command(), sync=False,
> VERY minor nit
Done
Line 308:  deathSignal=signal.SIGTERM,
Line 309:  nice=NICENESS.HIGH,
Line 310:  ioclass=IOCLASS.IDLE,
Line 311:  env=self.environments())


Line 309:  nice=NICENESS.HIGH,
Line 310:  ioclass=IOCLASS.IDLE,
Line 311:  env=self.environments())
Line 312: 
Line 313: yield
> Why not:
The proc is accessible from other methods such as abort().
If we yeild the proc we need a proc member in the importVM.
Line 314: finally:
Line 315: self._teardown_volumes()
Line 316: 
Line 317: def _get_disk_format(self):


-- 
To view, visit https://gerrit.ovirt.org/49951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
..


Patch Set 1:

* #1287620::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287620::OK, public bug
* Check Product::#1287620::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1287620::OK, correct target milestone ovirt-3.5.7
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50456
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer qemu version for el7

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: spec: Require newer qemu version for el7
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: vm: Update time on VM after resume
..

virt: vm: Update time on VM after resume

When a VM is resumed from suspension and/or migrated, its clock
continues from the time of suspension, i.e. it's delayed.  Even when NTP
is running on the VM, it may refuse to correct the time after a long
pause.  This needs to be fixed.

There was some discussion whether libvirt should be automatically
responsible for correcting the time inside its VM operations such as
virDomainResume, see the bug below.  The conclusion is that whatever the
right approach is, we currently have to handle the time correction
outside libvirt.

This change asks libvirt to correct the time after a VM is resumed.
It's not guaranteed that the call succeeds, e.g. it doesn't work without
QEMU guest agent running on the VM.  So the time may still be incorrect
after our effort but we shouldn't make the original VM operation fail
just because of that.

Note that the libvirt call currently waits for about 5 seconds before
giving up when qemu-guest-agent is not running in the guest.  That
should be harmless in theory as it doesn't make the VM non-operable, it
just delays finishing the requested operation.  But we want to be safe
so we update time just on resume after pausing, as requested in the bug
referenced below, which is the more important (possibly very long time
shifts) and more safe case.  We should handle migrations or situations
such as recovery after temporary suspension due to I/O errors as well,
but we are going to do that later, after discussing the delay issues
with libvirt developers.

Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Bug-Url: https://bugzilla.redhat.com/1287620
Signed-off-by: Milan Zamazal 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 53 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/50456/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index a403415..3499814 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -121,6 +121,9 @@
 self._io_tune[name] = io_tune
 return 1
 
+def setTime(self, time={}):
+self._failIfRequested()
+
 
 class TestVm(TestCaseBase):
 
@@ -1773,3 +1776,19 @@
 self.assertEqual(vm.status()['status'], vmstatus.SAVING_STATE)
 # state must not change even after we are sure the event was
 # handled
+
+
+@expandPermutations
+class SyncGuestTimeTests(TestCaseBase):
+
+def _make_dom(self, virt_error=None):
+return FakeDomain(virtError=virt_error)
+
+@permutations([[libvirt.VIR_ERR_AGENT_UNRESPONSIVE],
+   [libvirt.VIR_ERR_NO_SUPPORT],
+   [libvirt.VIR_ERR_INTERNAL_ERROR]])
+def test_swallow_expected_errors(self, virt_error):
+with FakeVM() as vm:
+vm._dom = self._make_dom(virt_error=virt_error)
+with self.assertNotRaises():
+vm._syncGuestTime()
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7256680..04e2e1d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2760,6 +2760,33 @@
 if not guestCpuLocked:
 self._guestCpuLock.release()
 
+def _syncGuestTime(self):
+"""
+Try to set VM time to the current value.  This is typically useful when
+clock wasn't running on the VM for some time (e.g. during suspension or
+migration), especially if the time delay exceeds NTP tolerance.
+
+It is not guaranteed that the time is actually set (it depends on guest
+environment, especially QEMU agent presence) or that the set time is
+very precise (NTP in the guest should take care of it if needed).
+"""
+t = time.time()
+seconds = int(t)
+nseconds = int((t - seconds) * 10**9)
+try:
+self._dom.setTime(time={'seconds': seconds, 'nseconds': nseconds})
+except libvirt.libvirtError as e:
+template = "Failed to set time: %s"
+code = e.get_error_code()
+if code == libvirt.VIR_ERR_AGENT_UNRESPONSIVE:
+self.log.debug(template, "QEMU agent unresponsive")
+elif code == libvirt.VIR_ERR_NO_SUPPORT:
+self.log.debug(template, "Not supported")
+else:
+self.log.error(template, e)
+else:
+self.log.debug('Time updated to: %d.%09d', seconds, nseconds)
+
 def shutdown(self, delay, message, reboot, timeout, force):
 if self.lastStatus == vmstatus.DOWN:
 return errCode['noVM']
@@ -4212,6 +4239,7 @@
 fromSnapshot = self.conf.pop('restoreFromSnapshot', False)
 hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf,
{'FROM_SNAPSHOT': fromSnapshot})
+self._syncGuestTime()
 

Change in vdsm[master]: schema: introduce HostJobInfo type

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: introduce HostJobInfo type
..


Patch Set 2:

(6 comments)

overall seems OK, suggested possible improvements, a few minor questions inside

https://gerrit.ovirt.org/#/c/49450/2//COMMIT_MSG
Commit Message:

Line 10: host. We support multiple job types (v2v, storage, etc.) and all job
Line 11: types will be reported via the same Host.getJobs API call. There will
Line 12: also be a standard interface for aborting and/or deleting them.
Line 13: 
Line 14: This patch adds new "pending" job status, used as the default state.
this could be a separate change
Line 15: This is needed for storage jobs which are executed in a thread pool.
Line 16: The jobs module and tests were updated to support the new status.
Line 17: 
Line 18: This schema specify job "progress" property as optional and add a new


Line 14: This patch adds new "pending" job status, used as the default state.
Line 15: This is needed for storage jobs which are executed in a thread pool.
Line 16: The jobs module and tests were updated to support the new status.
Line 17: 
Line 18: This schema specify job "progress" property as optional and add a new
same, this could be a separate change
Line 19: optional "error" property. These changes are implemented in the next
Line 20: patches.
Line 21: 
Line 22: Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009


https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 4055: 
Line 4056: ##
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
Surprising, don't we have the error response already described elsewhere?
Line 4060: #
Line 4061: # @code: An error code
Line 4062: #
Line 4063: # @message:  A free-form description of the error


Line 4074: # on a host.
Line 4075: #
Line 4076: # @id:   The job UUID
Line 4077: #
Line 4078: # @description:  A description of the job or the current status of 
the job
if this is for debug purposes, and meant not for client (Engine) consumption, 
maybe make it optional?
Line 4079: #(for debugging purposes)
Line 4080: #
Line 4081: # @job_type: The specific job type
Line 4082: #


https://gerrit.ovirt.org/#/c/49450/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28: 
Line 29: 
Line 30: class STATUS:
minor: I see you added "PENDING" - which is fine. The other fields looks 
reordered, could you explain why the reordering is needed? Is the new order of 
states the expected lifecycle of a Job?
Line 31: '''
Line 32: PENDING: Job is has not started yet
Line 33: RUNNING: Job is running
Line 34: DONE: Job has finished successfully


Line 112: if self.status != STATUS.DONE:
Line 113: raise JobNotDone("Job %r is %s" % (self.id, self.status))
Line 114: 
Line 115: def validate_not_active(self):
Line 116: if self.status not in (STATUS.DONE, STATUS.ABORTED, 
STATUS.FAILED):
again, not that important, but why this ordering?
Line 117: raise JobNotDone("Job %r is %s" % (self.id, self.status))
Line 118: 
Line 119: def _abort(self):
Line 120: """


-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011: self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013: try:
Line 2014: if nic.is_hostdevice:
Line 2015: hostdev.detach_detachable(params[hwclass.HOSTDEV])
> jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,571::__init__::509::jsonrpc.
silly me.
Line 2016: self._dom.attachDevice(nicXml)
Line 2017: except libvirt.libvirtError as e:
Line 2018: self.log.exception("Hotplug failed")
Line 2019: nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: introduce HostJobInfo type

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: schema: introduce HostJobInfo type
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49450/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28: 
Line 29: 
Line 30: class STATUS:
> minor: I see you added "PENDING" - which is fine. The other fields looks re
Pending may be used in v2v as well, the time that the job start until the 
actual copy take place.
Line 31: '''
Line 32: PENDING: Job is has not started yet
Line 33: RUNNING: Job is running
Line 34: DONE: Job has finished successfully


-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: config: Resolve crash when IPv6 disabled in kernel

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
..


Patch Set 1: Verified+1

Tested just like the patch from master:

Booted up with ipv6.disabled=1 and succeeded to set up a bridged network with 
no IPv6 configuration.

-- 
To view, visit https://gerrit.ovirt.org/50457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: refactor get_external_vms

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: refactor get_external_vms
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49636
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5c331b3136b61b0ee81829d7e71eedbbc1fa6b9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
..


Patch Set 3: Continuous-Integration+1

07:42:47 ERROR: Tests mkimage.mkFloppyFs creating an image and checking its 
content.
07:42:47 --
07:42:47 Traceback (most recent call last):
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py",
 line 73, in wrapper
07:42:47 return f(self, *args)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
 line 97, in wrapper
07:42:47 return f(*args, **kwargs)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/mkimageTests.py",
 line 172, in test_mkFloppyFs
07:42:47 m.mount(mntOpts='loop')
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 225, in mount
07:42:47 return self._runcmd(cmd, timeout)
07:42:47   File 
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
 line 241, in _runcmd
07:42:47 raise MountError(rc, ";".join((out, err)))
07:42:47 MountError: (32, ';mount: 
/tmp/vdsm-mkimage-testswqsKjg/images/vmId_floppy.0478bd99cc3b39a408d863d4babd70bd.img:
 failed to setup loop device: No such file or directory\n')

-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Alona Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: config: Resolve crash when IPv6 disabled in kernel

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: config: Resolve crash when IPv6 disabled in kernel
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774cac868ddee08ac072adf2104a811594779052
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ollie Armstrong 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: introduce HostJobInfo type

[shavivi]

Shahar Havivi has posted comments on this change.

Change subject: schema: introduce HostJobInfo type
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches