Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011:         self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013:         try:
Line 2014:             if nic.is_hostdevice:
Line 2015:                 hostdev.detach_detachable(params[hwclass.HOSTDEV])
> jsonrpc.Executor/7::DEBUG::2015-12-14 17:57:49,571::__init__::509::jsonrpc.
silly me.
Line 2016:             self._dom.attachDevice(nicXml)
Line 2017:         except libvirt.libvirtError as e:
Line 2018:             self.log.exception("Hotplug failed")
Line 2019:             nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to