Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 5:

Ignore the rebases, please. It's the result of unsuccessful attempt to 
cherry-pick the change onto another branch. I have reverted it to state at PS3.

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 5:

* #1367839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367839::OK, public bug
* Check Product::#1367839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Running virt-v2v with some sane environment

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Running virt-v2v with some sane environment
..


Patch Set 4:

* #1367839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367839::OK, public bug
* Check Product::#1367839::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6455c3189b7fbbf0d9d3ad5369a06b3cd6017e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Report the default route flag through caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Report the default route flag through caps
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Report the default route flag through caps

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Report the default route flag through caps
..


Patch Set 14: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/58351/13/lib/vdsm/network/kernelconfig.py
File lib/vdsm/network/kernelconfig.py:

PS13, Line 116: v4defaultroute')
> we set this via defaultRoute and read it via ipv4defaultgateway.
Changing all references to default route for consistency.


-- 
To view, visit https://gerrit.ovirt.org/58351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 691: ' > lowmark (%sMiB).'
Line 692: ' Refer to RHBZ#919201.',
Line 693: progress.data_remaining / Mbytes, lowmark / 
Mbytes)
Line 694: 
Line 695: if not self._in_post_copy and\
> Nobody, in post-copy _next_action is not called after the migration finishe
Actually not: Post-copy migration, once successfully started, can finish in 
only two ways: a) success, b) hard failure.  In both the cases the migration is 
finished, as well as the monitor thread.  So it's no longer possible to 
continue with the convergence schedule.

The only case where the convergence schedule still proceeds after the post-copy 
switch is if switching to post-copy mode fails. This is the case handled at 
lines 755-757; _in_post_copy flag is not set in that case and we proceed with 
the convergence schedule normally (aborting the migration is probably the right 
followup schedule action).
Line 696: lastDataRemaining is not None and\
Line 697: lastDataRemaining < progress.data_remaining:
Line 698: iterationCount += 1
Line 699: self._vm.log.debug('new iteration detected: %i',


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 669: 
Line 670: now = time.time()
Line 671: if self._in_post_copy:
Line 672: self._vm.log.debug('Post-copy migration still in 
progress: %d',
Line 673:progress.data_remaining)
> No, libvirt isn't that kind, we must fetch it from the destination ourselve
To be clear: We need to fetch stats, progress is available here.
Line 674: elif not self._use_conv_schedule and\
Line 675: (0 < migrationMaxTime < now - self._startTime):
Line 676: self._vm.log.warn('The migration took %d seconds 
which is '
Line 677:   'exceeding the configured maximum 
time '


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: support configuring nameservers by ovs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: support configuring nameservers by ovs
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe4f82fe88e24b43e5f40e96ae4292ebf933a8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: move name resolver functions from netinfo to ip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move name resolver functions from netinfo to ip
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc6732a4c0ab5aa6afd63b167834cc3942a62c15
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 669: 
Line 670: now = time.time()
Line 671: if self._in_post_copy:
Line 672: self._vm.log.debug('Post-copy migration still in 
progress: %d',
Line 673:progress.data_remaining)
> I guess this is the part on which we need data transfer from dest, right?
No, libvirt isn't that kind, we must fetch it from the destination ourselves.
Line 674: elif not self._use_conv_schedule and\
Line 675: (0 < migrationMaxTime < now - self._startTime):
Line 676: self._vm.log.warn('The migration took %d seconds 
which is '
Line 677:   'exceeding the configured maximum 
time '


Line 691: ' > lowmark (%sMiB).'
Line 692: ' Refer to RHBZ#919201.',
Line 693: progress.data_remaining / Mbytes, lowmark / 
Mbytes)
Line 694: 
Line 695: if not self._in_post_copy and\
> so in post copy mode who's taking care of the convergence schedule?
Nobody, in post-copy _next_action is not called after the migration finishes 
and that must be fixed.
Line 696: lastDataRemaining is not None and\
Line 697: lastDataRemaining < progress.data_remaining:
Line 698: iterationCount += 1
Line 699: self._vm.log.debug('new iteration detected: %i',


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: separate a resolv.conf test from NetInfo tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: separate a resolv.conf test from NetInfo tests
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I566f3450f849df65e8b0c427ff883d7e6c9223d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: add a resolv.conf writer

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: add a resolv.conf writer
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: add a resolv.conf writer

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: net: add a resolv.conf writer
..


Patch Set 3:

(9 comments)

https://gerrit.ovirt.org/#/c/62705/3/lib/vdsm/network/ip/resolv.py
File lib/vdsm/network/ip/resolv.py:

PS3, Line 33: , 'r'
> 'r' is default, we can drop it.
Done


PS3, Line 38: nameservers = []
: for words in _parse_lines(file_text):
: if words[0] == 'nameserver':
: nameservers.append(words[1])
: return nameservers
> return [words[1] for words in _parse_lines(file_test) if words[0] == 'names
I still have domains in mind and want to generalize this into 
_parse_resolver_configuration, which returns two lists: 
https://gerrit.ovirt.org/#/c/61794/


Line 51: yield words
Line 52: 
Line 53: 
Line 54: def update(nameservers):
Line 55: lines = [_conf_header()]
> header_lines
No need to treat a header in a special way.
Line 56: for ns in nameservers:
Line 57: lines.append('nameserver ' + ns)
Line 58: 
Line 59: for words in _parse_lines(_read_resolv_conf()):


PS3, Line 56: for ns in nameservers:
: lines.append('nameserver ' + ns)
> ns_lines = ['nameserver ' + ns for ns in nameservers]
Done


PS3, Line 59: for words in _parse_lines(_read_resolv_conf()):
: if words[0] != 'nameserver':
: lines.append(' '.join(words))
> other_lines = [' '.join(words) for words in _parse_lines(...) if words[0] !
Done


Line 59: for words in _parse_lines(_read_resolv_conf()):
Line 60: if words[0] != 'nameserver':
Line 61: lines.append(' '.join(words))
Line 62: 
Line 63: with open(DNS_CONF_FILE, 'w') as f:
> lines = + itertools.chain.from_iterable([header_lines, ns_lines, other_line
Lists can be simply concatenated.
Line 64: f.writelines(line + '\n' for line in lines)
Line 65: 
Line 66: 
Line 67: def _conf_header():


Line 63: with open(DNS_CONF_FILE, 'w') as f:
Line 64: f.writelines(line + '\n' for line in lines)
Line 65: 
Line 66: 
Line 67: def _conf_header():
> it can be defined as a constant or memoized.
I went for a constant.


https://gerrit.ovirt.org/#/c/62705/3/tests/network/resolv_test.py
File tests/network/resolv_test.py:

PS3, Line 56: test_update
> Please describe what is being tested: Replacing existing, appending new one
For now, we test replacement, to keep it simple. 

Resolver uses up to MAXNS (3) nameservers and ignores any extra nameservers.

One nameserver is in now way special currently (only zero is, in that case 
current nameservers are used).


In a separate patch, we could support initscripts-style 'update' (like in 
ifup-post), but for 3, not 2 entries:

In addition to defined nameservers, and up to MAXNS, append current nameservers 
which differ from the defined ones (as fallback nameservers). I had this in 
patch set 1 (_extend_with_unique).


PS3, Line 68: [
: resolv._conf_header() + '\n'] +
: ['nameserver {}\n'.format(ns) for ns in 
nameservers] +
: self.RESOLV_CONF[1:3])
> can we define it in another constant?
Done


-- 
To view, visit https://gerrit.ovirt.org/62705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41b81b04fbe3e3e2398f28cb16fb0dbbc0382249
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 3: Code-Review-1

please check my comments to PS2

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 2:

(3 comments)

I'm obviously fine with the idea, and the general approach seems OK;
I want to make sure we cover all sides, so few comments inside and -1 for 
visbility

https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS2, Line 466: flags = (libvirt.VIR_MIGRATE_LIVE |
 :  libvirt.VIR_MIGRATE_PEER2PEER |
 :  (libvirt.VIR_MIGRATE_TUNNELLED if
 :  self._tunneled else 0) |
 :  (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if
 :  self._abortOnError else 0) |
 :  (libvirt.VIR_MIGRATE_COMPRESSED if
 :  self._compressed else 0) |
 :  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
 :  self._autoConverge else 0))
 : if self._autoConverge:
 : try:
 : flags |= libvirt.VIR_MIGRATE_POSTCOPY
 : except AttributeError:
 : # Not present in libvirt < 1.3.3
 : pass
this code is begging for a cleanup, but I'll leave entirely to your good will :)


Line 669: 
Line 670: now = time.time()
Line 671: if self._in_post_copy:
Line 672: self._vm.log.debug('Post-copy migration still in 
progress: %d',
Line 673:progress.data_remaining)
I guess this is the part on which we need data transfer from dest, right?
Or is libvirt kind enough to let us have updated information on source side?
Line 674: elif not self._use_conv_schedule and\
Line 675: (0 < migrationMaxTime < now - self._startTime):
Line 676: self._vm.log.warn('The migration took %d seconds 
which is '
Line 677:   'exceeding the configured maximum 
time '


Line 691: ' > lowmark (%sMiB).'
Line 692: ' Refer to RHBZ#919201.',
Line 693: progress.data_remaining / Mbytes, lowmark / 
Mbytes)
Line 694: 
Line 695: if not self._in_post_copy and\
so in post copy mode who's taking care of the convergence schedule?
Line 696: lastDataRemaining is not None and\
Line 697: lastDataRemaining < progress.data_remaining:
Line 698: iterationCount += 1
Line 699: self._vm.log.debug('new iteration detected: %i',


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 3:

* #1354343::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 2:

* #1354343::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: separate a resolv.conf test from NetInfo tests

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: net tests: separate a resolv.conf test from NetInfo tests
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/62723/1/tests/network/resolv_test.py
File tests/network/resolv_test.py:

Line 17: # 02110-1301  USA
Line 18: #
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: from __future__ import absolute_import
> empty line after __future__
Done
Line 22: import os
Line 23: 
Line 24: from nose.plugins.attrib import attr
Line 25: 


PS1, Line 29: as TestCaseBase
> redundant
Done


-- 
To view, visit https://gerrit.ovirt.org/62723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I566f3450f849df65e8b0c427ff883d7e6c9223d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Report the default gateway flag through caps

[sbonazzo]

Sandro Bonazzola has posted comments on this change.

Change subject: net: Report the default gateway flag through caps
..


Patch Set 13:

Chance that this patch will be merged soon? It's mentioned as required in 
https://gerrit.ovirt.org/#/c/58931/1/src/ovirt_hosted_engine_setup/vds_info.py 
and we're currently blocked on deploying hosted engine on Fedora 24.

-- 
To view, visit https://gerrit.ovirt.org/58351
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfbdd71310cbbb672a185e2f1ac6fdd9b495906
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: move name resolver functions from netinfo to ip

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: net: move name resolver functions from netinfo to ip
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/62704/2/lib/vdsm/network/ip/resolv.py
File lib/vdsm/network/ip/resolv.py:

> Why the name change? Please convince us that the name needs to change.
This module affects the client-side part of DNS, and that is name resolution. 
If it included, some day, other means of name resolution (configured in 
/etc/nsswitch.conf), e.g. file-based (/etc/hosts) or LAN-based (Avahi), its 
name would still be fitting.
Line 1: #
Line 2: # Copyright 2016 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


PS2, Line 2: 2016
> 2015-2016
Done


-- 
To view, visit https://gerrit.ovirt.org/62704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc6732a4c0ab5aa6afd63b167834cc3942a62c15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org