Change in vdsm[master]: ngn: provide release according with os-release

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 2: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ngn: provide release according with os-release

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/72829/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 82: NORMAL = 0
Line 83: HIGH = 19
Line 84: 
Line 85: 
Line 86: def isNextGenNode():
is there any need to place it outside of osversion module?

I prefer to keep things private, unless they are universally needed.

please use pep8-compliate function_names for new functions.
Line 87: """
Line 88: Return:
Line 89: True if it's oVirt Node Next or RHV Node
Line 90: """


-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ngn: provide release according with os-release

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: ngn: provide release according with os-release
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/72829/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: ngn: provide release according with os-release
Line 8: 
Line 9: Previously in ngn nodes we grab the release based on rpm.
Line 10: Now, we will provide release field to engine from /etc/os-release
please add a bz#
Line 11: 
Line 12: Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a


-- 
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmxml: append only etree.Elements

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vmxml: append only etree.Elements
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/72089/7/lib/vdsm/virt/vmxml.py
File lib/vdsm/virt/vmxml.py:

PS7, Line 228: isinstance
does the type of "child" ever change? or can we check for the python version 
instead?


-- 
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: gluster: avoid over allocation in lvs

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: avoid over allocation in lvs
..


gluster: avoid over allocation in lvs

While provisioning gluster bricks, 16GB or 0.005% is reserved
for thin pool meta data. But lvs is created with actual disk size.
It results in over allocation of LV than what is available in
thinpool. This configuration can lead to storage corruption when
thinpool is fully utilized and xfs thinks still there is a space in lv.

Fixing this issue by avoiding over allocation. Now thin lv
will be created with the size same as thin pool without
over commiting.

Change-Id: I421401246b77c33e3ad02d08b3c0c06335c71446
Bug-Url: https://bugzilla.redhat.com/1412455
Signed-off-by: Ramesh Nachimuthu 
---
M lib/vdsm/gluster/storagedev.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Sahina Bose: Looks good to me, but someone else must approve
  Ramesh N: Verified



-- 
To view, visit https://gerrit.ovirt.org/72691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I421401246b77c33e3ad02d08b3c0c06335c71446
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: gluster: avoid over allocation in lvs

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: avoid over allocation in lvs
..


Patch Set 2: Code-Review+2

raising Sahina's score

-- 
To view, visit https://gerrit.ovirt.org/72691
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421401246b77c33e3ad02d08b3c0c06335c71446
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: migration: add test to exercise retry

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: migration: add test to exercise retry
..


tests: migration: add test to exercise retry

Due the shape of the code, it is hard to test the migration
retry logic, we require a good chunk of boilerplate and faking.

This patch tries to be minimal and add those tests.

Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Related-To: https://bugzilla.redhat.com/1414626
Signed-off-by: Francesco Romani 
---
M tests/vmmigration_test.py
1 file changed, 110 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/71300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: migration: add test to exercise retry

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: tests: migration: add test to exercise retry
..


Patch Set 9: Code-Review+2

raising milan's opinion.

-- 
To view, visit https://gerrit.ovirt.org/71300
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt-net: attempt to unset port mirroring only if the VM was...

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has uploaded a new change for review.

Change subject: virt-net: attempt to unset port mirroring only if the VM was 
properly initialized
..

virt-net: attempt to unset port mirroring only if the VM was properly 
initialized

If qemu crashed before we read the libvirt-allocated device names, the
VM moves to Down state. However, when we are asked to destroy() the VM
object, we attempt to unset port mirroring on a vNIC that was never
properly initialized.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1419931
Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a
Signed-off-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/72742/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index d69d364..078c6eb 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4119,7 +4119,7 @@
 # unsetting mirror network will clear both mirroring
 # (on the same network).
 for nic in self._devices[hwclass.NIC]:
-if hasattr(nic, 'portMirroring'):
+if hasattr(nic, 'portMirroring') and hasattr(nic, 'name'):
 for network in nic.portMirroring[:]:
 supervdsm.getProxy().unsetPortMirroring(network,
 nic.name)


-- 
To view, visit https://gerrit.ovirt.org/72742
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: clientIF: drop xmlrpc support

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: clientIF: drop xmlrpc support
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/72476/3/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 247
Line 248
Line 249
Line 250
Line 251
this is the only functional import of bindingxmlrpc. We should eliminate it as 
a module. we should start the bindingxmlrpc http server unconditionally, but 
keep only OVS_STORE-related code there.

xmlrpc_enable should be deleted too.


-- 
To view, visit https://gerrit.ovirt.org/72476
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15df578860f3276ffcc005800d6b03996900b2bb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: update man page

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: update man page
..


vdsm: update man page

updated reference to vdsm wiki and the updated license
file.

Change-Id: Ic71ad17922c780e99d8275e02d8a2915d5c32681
Signed-off-by: Irit Goihman 
---
M static/usr/share/man/man8/vdsmd.8.in
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/71067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic71ad17922c780e99d8275e02d8a2915d5c32681
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: update man page

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: update man page
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/71067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic71ad17922c780e99d8275e02d8a2915d5c32681
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: api: move vdsmapi to lib

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: api: move vdsmapi to lib
..


Patch Set 1:

Sorry Francesco I missed your request to run ovirt-system-tests..

-- 
To view, visit https://gerrit.ovirt.org/72496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: m2c: reduce log level for ssl errors

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: m2c: reduce log level for ssl errors
..


m2c: reduce log level for ssl errors

m2crypto tends to be verbose when a client closes connection. I tested
this behavior using ssl debug and noticed that those error messages are
harmless. They only appear when using m2crypto. We want to reduce
confusion so it is better to log those in debug.


Bug-Url: https://bugzilla.redhat.com/1412583
Change-Id: I5624643b659ba5e97436b2c0f42a5f43420d50db
Signed-off-by: Piotr Kliczewski 
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/72506
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5624643b659ba5e97436b2c0f42a5f43420d50db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: m2c: reduce log level for ssl errors

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: m2c: reduce log level for ssl errors
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/72506
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5624643b659ba5e97436b2c0f42a5f43420d50db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: api: move vdsmapi to lib

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: api: move vdsmapi to lib
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/72496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: api: move vdsmapi to lib

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: api: move vdsmapi to lib
..


api: move vdsmapi to lib

We are going to move all the files from lib/api to lib/vdsm/api.


Bug-Url: https://bugzilla.redhat.com/1376116
Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Signed-off-by: Piotr Kliczewski 
---
M automation/build-artifacts.sh
M configure.ac
M lib/Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/api/Makefile.am
R lib/vdsm/api/__init__.py
R lib/vdsm/api/schema_to_html.py
R lib/vdsm/api/vdsm-api-gluster.yml
R lib/vdsm/api/vdsm-api.yml
R lib/vdsm/api/vdsm-events.yml
R lib/vdsm/api/vdsmapi.py
M lib/vdsm/client.py
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
M tests/schemaValidationTest.py
M tests/vdsmapi_test.py
M tests/vmApiTests.py
M vdsm.spec.in
18 files changed, 32 insertions(+), 32 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/72496
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org