Change in vdsm[master]: build: remove constants.py from dist package

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged. ( 
https://gerrit.ovirt.org/79925 )

Change subject: build: remove constants.py from dist package
..


build: remove constants.py from dist package

Recently constants.py was moved to lib/vdsm/common. This was done by
commit f63269e9fa2b1a31e6d9673f8e3337eeacbd0332. However, because of
existing rule in Makefile.am this file was mistakenly included into
dist package. As a result constants.py was not recreated during RPM
builds which resulted in broken RPMs (constants.py contained invalid
paths).

lib/vdsm/common/Makefile.am contained dist_* rule that includes all
'*.py' into dist package. Note that files listed in the nodist_* rule
are not taken into account during 'make dist'.

This change does two things:

1)  it modifies the dist_* rule to contain all '*.py' minus the files
listed in nodist_* rule

2)  test is added to check-patch.sh to make sure no file generated from
.in file is included in the dist package

ad 2) There are several exceptions that we seem to include in dist
package on purpose. I don't really believe that including any of those
files (except maybe vdsm.spec) is necessary, but I did not investigate.
This can be improved in subsequent patches.

Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Signed-off-by: Tomáš Golembiovský 
---
M automation/check-patch.sh
M lib/vdsm/common/Makefile.am
2 files changed, 44 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Tomas Golembiovsky: Verified



-- 
To view, visit https://gerrit.ovirt.org/79925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: ssl: handle handshake errors

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: ssl: handle handshake errors
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: remove constants.py from dist package

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: build: remove constants.py from dist package
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/79925/3/automation/check-patch.sh
File automation/check-patch.sh:

PS3, Line 10: Check if
-> "Verify that" would be much clearer


-- 
To view, visit https://gerrit.ovirt.org/79925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: api: ping2 and confirmConnectivity

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: api: ping2 and confirmConnectivity
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/80119/5/tests/functional/utils.py
File tests/functional/utils.py:

Line 173: def pinger(self):
Line 174: """Keeps pinging vdsm for operations that need it"""
Line 175: def ping():
Line 176: while not done:
Line 177: self.vdscli.ping2()
why do we need the ping2 call? can we drop it (and rename the function 
accordingly)?
Line 178: self.vdscli.confirmConnectivity()
Line 179: time.sleep(1)
Line 180: try:
Line 181: done = False


-- 
To view, visit https://gerrit.ovirt.org/80119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f93e88e37288ae1689b6a43014817af655f191e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: net: Report lldp through new getLldp command
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/80194/1/lib/vdsm/api/vdsm-api.yml
File lib/vdsm/api/vdsm-api.yml:

PS1, Line 692: 4.2
> Dear reviewer,
too bad Piotr is away, but I think that 4.1.5 is not a valid value here. IMHO 
since we sneak this API change to 4.1 clusters, we should put 4.1 here and in 
master as well.


-- 
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org