Change in vdsm[master]: stomp: simplified client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 13: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 603: """
Line 604: reactor = Reactor()
Line 605: 
Line 606: def start():
Line 607: thread = concurrent.thread(reactor.process_requests,
> this also doesn't change anything. daemon=True is the deafult in out concur
it's a rebase problem
Line 608:name='Client %s:%s' % (host, port))
Line 609: thread.start()
Line 610: 
Line 611: client = StompClient(utils.create_connected_socket(host, port, 
sslctx),


-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 14: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 13: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/64502/10/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
> you repeat the errors description twice (here and in the call method). I gu
It is intentional. This description is the more informative one, with 
guidelines for developers who are willing to use this module, and the 
description in the call method is part of the method description. The next 
update should be responsible and update both places.
Line 113: 
Line 114: Please note that if the client isn't a context manager, it should be
Line 115: closed at the end of the run:
Line 116: 


Line 192: if args is None:
Line 193: args = {}
Line 194: req = yajsonrpc.JsonRpcRequest(method, args, 
reqId=str(uuid.uuid4()))
Line 195: try:
Line 196: responses = self._client.call(req, timeout=timeout)
> why not just have it as default values? like "def call(self, method, args={
Done
Line 197: except EnvironmentError as e:
Line 198: raise ClientError(e)
Line 199: 
Line 200: if not responses:


Line 224: if t is None:
Line 225: raise
Line 226
Line 227
Line 228
> why is this type check ?
__exit__ should only raise exception if it was raised during exit. So if t 
(type) is None it means an exception wasn't raised during the execution of the 
context manager and we have to handle the exception raised in __exit__. t,v, tb 
represent the exception that was raised before exiting the context manager and 
if they're not None, the raised exception from __exit__ will override it.


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 10: Verified+1

(3 comments)

https://gerrit.ovirt.org/#/c/64502/8/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 43: cli.call(method, args, timeout)
Line 44: 
Line 45: Examples:
Line 46: 
Line 47: cli.call('Host.getVMList')
> This is not very clear, lets show an example request with complex parameter
Done
Line 48: 
Line 49: result:
Line 50: [u'd7207614-38e3-43c4-b8f2-6086867d0a84',
Line 51: u'2c73bed5-cd2a-4d01-9095-97c0d71c831b']


https://gerrit.ovirt.org/#/c/64502/9/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 95: "display": "qxl", "maxvcpus": "16", "maxmemslots": 16},
Line 96: "vmid": "d7207614-38e3-43c4-b8f2-6086867d0a84"}))
Line 97: 
Line 98: ClientError will be raised in case of a protocol error:
Line 99: 
> args is optional now (good), but you are using mutable default argument, me
Done
Line 100: vdsm.client.ClientError: Error sending request: [Errno 111]
Line 101: Connection refused
Line 102: 
Line 103: TimeoutError will be raised when preconfigured amount of time has 
passed with


Line 105: 
Line 106: vdsm.client.TimeoutError: timeout waiting for a response
Line 107: 
Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
> I think we need to introduce a Timeout error, otherwise the user cannot tel
Done
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
Line 113: 


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 15:

http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/297/
job ended successfully

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has abandoned this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Remove build requires needed for the tests

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build: Remove build requires needed for the tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65500
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c385b0abeb2657a26215ce5b96976cc290734bb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Remove cPopenTests.py

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: Remove cPopenTests.py
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc384d6e84ce5f09573be32ea6247c6ef834836
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Run the tests with tox

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build: Run the tests with tox
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I245a171940a5e869fd719a6410024ee77e8ad86c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: wip: jsonrpc: introduce new client
..


Patch Set 9:

(10 comments)

https://gerrit.ovirt.org/#/c/64502/8/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: '''
Line 21: vdsm client
> This is not a jsonrpc client (generic client for server using jsonrpc) but 
Done
Line 22: 
Line 23: This is a simple client which uses jsonrpc protocol introduced on 
ovirt 3.5.
Line 24: This client is not aware of the available methods and parameters.
Line 25: 


Line 26: The user should consult the schema to construct the wanted command.
Line 27: 
Line 28: The client is invoked with:
Line 29: 
Line 30: cli = client.connect(host, port, ssl)
> The common way to show code examples is to indent them with 4 spaces, the #
Done
Line 31: 
Line 32: For example:
Line 33: 
Line 34: cli = client.connect('localhost', 54321, True)


Line 36: Failure will result in ClientError exception.
Line 37: 
Line 38: Invoking commands:
Line 39: 
Line 40: cli.call('Host.getVMList')
> Maybe we can make args optional to make it nicer to call methods without ar
Done
Line 41: 
Line 42: cli.call('VM.getStats', {'vmID': 
'bc26bd11-ee3b-4a56-80d4-770f383a47b9'})
Line 43: 
Line 44: The call method expects method name and a dictionary (optional) 
containing all


Line 44: The call method expects method name and a dictionary (optional) 
containing all
Line 45: mandatory parameters, as they appear in the schema.
Line 46: 
Line 47: Complex parameters are also supported and share the same behavior.
Line 48: 
> We need to see an example result, and explain about getting the exact resul
I will address this comment in the next change
Line 49: '''
Line 50: 
Line 51: 
Line 52: from __future__ import absolute_import


Line 47: Complex parameters are also supported and share the same behavior.
Line 48: 
Line 49: '''
Line 50: 
Line 51: 
> One empty line here is enough.
Done
Line 52: from __future__ import absolute_import
Line 53: 
Line 54: import uuid
Line 55: 


Line 90: self.code = code
Line 91: self.message = message
Line 92: 
Line 93: 
Line 94: class _Client(object):
> These should come after the public apis.
Done
Line 95: def __init__(self, client):
Line 96: self._client = client
Line 97: self.default_timeout = yajsonrpc.CALL_TIMEOUT
Line 98: 


Line 110: 
Line 111: resp = responses[0]
Line 112: if resp.error:
Line 113: raise ServerError(resp.error['code'], 
resp.error['message'])
Line 114: 
> Let document if we may get here multiple responses, when I see this code I 
same
Line 115: return resp.result
Line 116: 
Line 117: def close(self):
Line 118: self._client.close()


Line 113: raise ServerError(resp.error['code'], 
resp.error['message'])
Line 114: 
Line 115: return resp.result
Line 116: 
Line 117: def close(self):
> Let keep empty line after raising/returning - the rest of the function is h
Done
Line 118: self._client.close()
Line 119: 
Line 120: def __enter__(self):
Line 121: return self


Line 118: self._client.close()
Line 119: 
Line 120: def __enter__(self):
Line 121: return self
Line 122: 
> Here is a good place for the context manager interface.
Done
Line 123: def __exit__(self, t, v, tb):
Line 124: try:
Line 125: self.close()
Line 126: except Exception:


Line 120: def __enter__(self):
Line 121: return self
Line 122: 
Line 123: def __exit__(self, t, v, tb):
Line 124: try:
> This and the exceptions are the only public apis, so they should be at the 
Done
Line 125: self.close()
Line 126: except Exception:
Line 127: if t is None:


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/61186/14/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

PS14, Line 40: 4.17.10.1-0
> why to downgrade to this specific version?
There isn't any specific reason, I just wanted to make sure that a package from 
3.6 version will be installed.


-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: wip: jsonrpc: introduce new client
..


Patch Set 6:

(17 comments)

https://gerrit.ovirt.org/#/c/64502/4/lib/vdsm/jsonrpcapi.py
File lib/vdsm/jsonrpcapi.py:

Line 15
Line 16
Line 17
Line 18
Line 19
> How about vdsm.client?
Done


Line 19
Line 20
Line 21
Line 22
Line 23
> Don't import functions, only modules. This make the dependencies easier to 
Done


Line 25
Line 26
Line 27
Line 28
Line 29
> Better just to import yajsonrpc and use yajsonrpc.Xxx when needed.
Done


Line 28
Line 29
Line 30
Line 31
Line 32
> Vdsm config may not be avilable.
Done


Line 31
Line 32
Line 33
Line 34
Line 35
> This is a client, not a server.
Done


Line 34
Line 35
Line 36
Line 37
Line 38
> You cannot use vdsm configuration here, the library may be used on another 
Done


Line 36
Line 37
Line 38
Line 39
Line 40
> Please avoid using the schema here, we don't want to pay for parsing the sc
Done


Line 44
Line 45
Line 46
Line 47
Line 48
> We don't need setters like this in python. just make default_timeout public
Done


Line 57
Line 58
Line 59
Line 60
Line 61
> Can you explain why we need both *args and **kwargs? To send a request we n
Done


Line 66
Line 67
Line 68
Line 69
Line 70
> Please don't do that, no hidden arguments in kwargs. If you want to support
Done


Line 70
Line 71
Line 72
Line 73
Line 74
> Use the happy pass idiom:
Yes, it means we reached the timeout and got no response. Usually it's because 
there is an error in the method name/arguments or the basic case in which we 
lost connection to vdsm.


Line 73
Line 74
Line 75
Line 76
Line 77
> You never want to raise Exception, the user of this api cannot do anything 
Done


Line 76
Line 77
Line 78
Line 79
Line 80
> We don't need this.
Done


Line 82
Line 83
Line 84
Line 85
Line 86
> Or this
Done


Line 88
Line 89
Line 90
Line 91
Line 92
> Never use __del__.
Done


Line 96
Line 97
Line 98
Line 99
Line 100
> Do not assume you have vdsm config here.
Done


Line 99
Line 100
Line 101
Line 102
Line 103
> Same.
Done


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new cli

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: wip: jsonrpc: introduce new cli
..

wip: jsonrpc: introduce new cli

Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Signed-off-by: Irit goihman 
---
M lib/vdsm/Makefile.am
A lib/vdsm/jsonrpccli.py
M vdsm.spec.in
3 files changed, 200 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/64502/1

diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index d248d30..1022380 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -35,6 +35,7 @@
hooks.py \
hostdev.py \
jobs.py \
+   jsonrpccli.py \
jsonrpcvdscli.py \
kaxmlrpclib.py \
libvirtconnection.py \
diff --git a/lib/vdsm/jsonrpccli.py b/lib/vdsm/jsonrpccli.py
new file mode 100644
index 000..13d4d55
--- /dev/null
+++ b/lib/vdsm/jsonrpccli.py
@@ -0,0 +1,198 @@
+#
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+
+from functools import partial
+from uuid import uuid4
+
+from yajsonrpc import stompreactor
+from yajsonrpc import \
+JsonRpcRequest, \
+JsonRpcNoResponseError, \
+CALL_TIMEOUT
+
+from api import vdsmapi
+from .config import config
+
+
+_COMMAND_CONVERTER = {
+'activateStorageDomain': 'StorageDomain.activate',
+'connectStoragePool': 'StoragePool.connect',
+'connectStorageServer': 'StoragePool.connectStorageServer',
+'cont': 'VM.cont',
+'clearTask': 'Task.clear',
+'create': 'VM.create',
+'createStorageDomain': 'StorageDomain.create',
+'createStoragePool': 'StoragePool.create',
+'createVG': 'LVMVolumeGroup.create',
+'createVolume': 'Volume.create',
+'destroy': 'VM.destroy',
+'destroyStoragePool': 'StoragePool.destroy',
+'detachStorageDomain': 'StorageDomain.detach',
+'disconnectStoragePool': 'StoragePool.disconnect',
+'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
+'discoverSendTargets': 'ISCSIConnection.discoverSendTargets',
+'extendVolumeSize': 'Volume.extendSize',
+'formatStorageDomain': 'StorageDomain.format',
+'fullList': 'Host.getVMFullList',
+'getAllTasksInfo': 'Host.getAllTasksInfo',
+'getAllTasksStatuses': 'Host.getAllTasksStatuses',
+'getAllVmStats': 'Host.getAllVmStats',
+'getConnectedStoragePoolsList': 'Host.getConnectedStoragePools',
+'getDeviceList': 'Host.getDeviceList',
+'getImagesList': 'StorageDomain.getImages',
+'getIoTunePolicy': 'VM.getIoTunePolicy',
+'getIoTune': 'VM.getIoTune',
+'getSpmStatus': 'StoragePool.getSpmStatus',
+'getStorageDomainInfo': 'StorageDomain.getInfo',
+'getStorageDomainsList': 'Host.getStorageDomains',
+'getStorageDomainStats': 'StorageDomain.getStats',
+'getStoragePoolInfo': 'StoragePool.getInfo',
+'getTaskInfo': 'Task.getInfo',
+'getTaskStatus': 'Task.getStatus',
+'getVdsCapabilities': 'Host.getCapabilities',
+'getVdsHardwareInfo': 'Host.getHardwareInfo',
+'getVdsStats': 'Host.getStats',
+'getVGInfo': 'LVMVolumeGroup.getInfo',
+'getVolumeInfo': 'Volume.getInfo',
+'getVmStats': 'VM.getStats',
+'getVolumeSize': 'Volume.getSize',
+'getVolumesList': 'StorageDomain.getVolumes',
+'glusterTasksList': 'GlusterTask.list',
+'glusterVolumeCreate': 'GlusterVolume.create',
+'glusterVolumeSet': 'GlusterVolume.set',
+'glusterVolumesList': 'GlusterVolume.list',
+'glusterVolumeStart': 'GlusterVolume.start',
+'glusterTasksList': 'GlusterTask.list',
+'hotplugDisk': 'VM.hotplugDisk',
+'hotplugNic': 'VM.hotplugNic',
+'hotunplugDisk': 'VM.hotunplugDisk',
+'hotunplugNic': 'VM.hotunplugNic',
+'list': 'Host.getVMList',
+'migrate': 'VM.migrate',
+'migrateStatus': 'VM.getMigrationStatus',
+'migrationCreate': 'VM.migrationCreate',
+'ping': 'Host.ping',
+'prepareImage': 'Image.prepare',
+'repoStats': 'Host.getStorageRepoStats',
+'setBalloonTarget': 'VM.setBalloonTarget',
+'setCpuTunePeriod': 'VM.setCpuTunePeriod',
+'setCpuTuneQuota': 'VM.setCpuTuneQuota',
+'setKsmTune': 

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/13/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt'
Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@'
Line 156: 
Line 157: # location of the certificates
Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki', 'vdsm')
> Good idea, let's do it
I'm sorry to tell you guys that this is not possible, it's causing circular 
imports. we'll have to keep it here...
Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem')
Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem')


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 14: Verified+1

passes in jenkins

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 11:

(11 comments)

https://gerrit.ovirt.org/#/c/61186/10/tests/functional/Makefile.am
File tests/functional/Makefile.am:

Line 1: #
Line 2: # Copyright 2012-2016 Red Hat, Inc.
> 6 ?
Done
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/61186/8/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

Line 43: def upgrade_vdsm():
Line 44: run_command(['yum-config-manager', '--enable', 'localsync'])
Line 45: run_command(['yum', 'update', '-y', 'vdsm'])
Line 46: 
Line 47: 
> why? if it didn't start after the upgrade, it won't start on tearDown
Done
Line 48: class UpgradeTest(VdsmTestCase):
Line 49: def setUp(self):
Line 50: run_command(['yum-config-manager', '--disable', 'localsync'])
Line 51: 


Line 45: run_command(['yum', 'update', '-y', 'vdsm'])
Line 46: 
Line 47: 
Line 48: class UpgradeTest(VdsmTestCase):
Line 49: def setUp(self):
> Do a test also that verifies that if vdsmd was down, after upgrade it's sti
Done
Line 50: run_command(['yum-config-manager', '--disable', 'localsync'])
Line 51: 
Line 52: def tearDown(self):
Line 53: run_command(['yum-config-manager', '--disable', '*ovirt-3.6*'])


https://gerrit.ovirt.org/#/c/61186/10/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

Line 21: from vdsm.tool.service import service_start, service_status, 
service_stop
Line 22: 
Line 23: from testlib import VdsmTestCase
Line 24: 
Line 25: el7_ovirt36_repo = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/'
> f22_ovirt36_repo.. already asked for renaming the global to something more 
Done
Line 26: 
Line 27: 
Line 28: def run_command(command):
Line 29: p = subprocess.Popen(command, stdout=subprocess.PIPE,


Line 24: 
Line 25: el7_ovirt36_repo = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/'
Line 26: 
Line 27: 
Line 28: def run_command(command):
> Using same arguments names as the underlying api (stdout, stderr) is better
Done
Line 29: p = subprocess.Popen(command, stdout=subprocess.PIPE,
Line 30:  stderr=subprocess.PIPE)
Line 31: out, err = p.communicate()
Line 32: if p.returncode != 0:


Line 28: def run_command(command):
Line 29: p = subprocess.Popen(command, stdout=subprocess.PIPE,
Line 30:  stderr=subprocess.PIPE)
Line 31: out, err = p.communicate()
Line 32: if p.returncode != 0:
> Include rc, out, and err in the exception, we want to see all the available
Done
Line 33: raise Exception(command, p.returncode, out, err)
Line 34: return out
Line 35: 
Line 36: 


Line 33: raise Exception(command, p.returncode, out, err)
Line 34: return out
Line 35: 
Line 36: 
Line 37: def downgrade_vdsm(url):
> This must also be reverted after the test.
Done
Line 38: run_command(['yum-config-manager', '--add-repo', url])
Line 39: run_command(['yum', 'swap', '--', 'erase', '-y', 'vdsm\*',
Line 40:  '--', 'install', '-y', 
'vdsm-4.17.10.1-0.el7.centos.noarch'])
Line 41: 


Line 35: 
Line 36: 
Line 37: def downgrade_vdsm(url):
Line 38: run_command(['yum-config-manager', '--add-repo', url])
Line 39: run_command(['yum', 'swap', '--', 'erase', '-y', 'vdsm\*',
> Why not vdsm-4.17? can work on any platform.
it didn't work for me
Line 40:  '--', 'install', '-y', 
'vdsm-4.17.10.1-0.el7.centos.noarch'])
Line 41: 
Line 42: 
Line 43: def upgrade_vdsm():


Line 48: class UpgradeTest(VdsmTestCase):
Line 49: def setUp(self):
Line 50: run_command(['yum-config-manager', '--disable', 'localsync'])
Line 51: 
Line 52: def tearDown(self):
> This will change the host state after running these tests, bad idea. We wan
Done
Line 53: run_command(['yum-config-manager', '--disable', '*ovirt-3.6*'])
Line 54: run_command(['yum-config-manager', '--enable', 'localsync'])
Line 55: # make sure vdsm is installed and running
Line 56: run_command(['yum', 'install', '-y', 'vdsm'])


Line 50: run_command(['yum-config-manager', '--disable', 'localsync'])
Line 51: 
Line 52: def tearDown(self):
Line 53: run_command(['yum-config-manager', '--disable', '*ovirt-3.6*'])
Line 54: run_command(['yum-config-manager', '--enable', 'localsync'])
> Not needed, setUp will fail without catching and raising again the exceptio
Done
Line 55: # make sure vdsm is installed and running
Line 56: run_command(['yum', 'install', '-y', 'vdsm'])
Line 57: service_start('vdsmd')
Line 58: 


Line 65: 

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 13: Verified+1

no errors in vdsm, created a new vm and sos report shows the wanted data

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6: -Verified

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 3: -Verified

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 6:

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: -Verified

please ignore the jsonrpc migration patches until we will have the fixed cli. 
The current version depends on an abandoned patch.

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrateStatus

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: add migrateStatus
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 10: Verified+1

verified by running  jsonrpc Host.getVMList

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 104: self.addCopySpec("/tmp/vds_bootstrap*")
Line 105: self.addCopySpec("/etc/vdsm/*")
Line 106: logsize = self.getOption('logsize')
Line 107: self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize)
Line 108: self._addVdsmRunDir()
> I'm working on a change now, I only rebased the patch and didn't refer the 
Done
Line 109: self.addCopySpec("/etc/pki/vdsm")
Line 110: self.addCopySpec("@HOOKSDIR@")
Line 111: self.addCopySpec("@VDSMLIBDIR@")
Line 112: self.addCopySpec("/var/log/ovirt.log")


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vdsm: drop the warnings module configuration

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: vdsm: drop the warnings module configuration
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62212
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I791882a2dd8ba2dda9135b087bca33610db8a20d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: build: Allow tox to run all checkers in one shot.

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build: Allow tox to run all checkers in one shot.
..


Patch Set 1: Code-Review+1

I agree with this approach, merging the two style validation checks to one 
target will shorten make check time and I don't see a reason separating them

-- 
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3efc6e2d6318841892f3cf5bfa27a621922ed025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 104: self.addCopySpec("/tmp/vds_bootstrap*")
Line 105: self.addCopySpec("/etc/vdsm/*")
Line 106: logsize = self.getOption('logsize')
Line 107: self.__addCopySpecLogLimit("/var/log/vdsm/*", logsize)
Line 108: self._addVdsmRunDir()
> key is still not collected. is it intentional?
I'm working on a change now, I only rebased the patch and didn't refer the 
comments.
Line 109: self.addCopySpec("@HOOKSDIR@")
Line 110: self.addCopySpec("@VDSMLIBDIR@")
Line 111: self.addCopySpec("/var/log/ovirt.log")
Line 112: self.addCopySpec("/var/log/sanlock.log")


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 20: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 20:

(2 comments)

https://gerrit.ovirt.org/#/c/35181/18//COMMIT_MSG
Commit Message:

Line 27: # jsonrpc StorageDomain.activate -f sd-activate
Line 28: ...
Line 29: 
Line 30: where sd-activate file content is:
Line 31: {
> Now we use json in the file. please update here as well.
thanks, I lost the updated commit message during rebase
Line 32: "storagedomainID": "75ab40e3-06b1-4a54-a825-2df7a40b93b2",
Line 33: "storagepoolID": "b3f6fa00-b315-4ad4-8108-f73da817b5c5"
Line 34: }
Line 35: 


Line 34: }
Line 35: 
Line 36: It is also possible to read parameters from standard input, creating
Line 37: complex parameters interactively:
Line 38: 
> and here
Done
Line 39: # jsonrpc StorageDomain.activate -f -
Line 40: {
Line 41: "storagedomainID": "75ab40e3-06b1-4a54-a825-2df7a40b93b2",
Line 42: "storagepoolID": "b3f6fa00-b315-4ad4-8108-f73da817b5c5"


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 10:

I rebased the patch, please verify the changes

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 12:

I rebased the patch, please verify the changes

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Verified+1

[root@rhevh-25 sos]# ll 
sosreport-rhevh-25.gsslab.rdu2.redhat.com-20160921153154/sos_commands/vdsm/
total 84
-rw-r--r--. 1 root root 2610 Sep 21 15:31 fdisk_-l
-rw-r--r--. 1 root root   27 Sep 21 15:31 iscsiadm_-m_node
-rw-r--r--. 1 root root   30 Sep 21 15:31 iscsiadm_-m_session
-rw-r--r--. 1 root root   65 Sep 21 15:31 ls_-ldZ_.etc.vdsm
-rw-r--r--. 1 root root8 Sep 21 15:31 ls_-l_.var.log.core
-rw-r--r--. 1 root root 1971 Sep 21 15:31 lvm_lvs_-v_-o_tags
-rw-r--r--. 1 root root 1322 Sep 21 15:31 lvm_pvs_-v_-o_all
-rw-r--r--. 1 root root  526 Sep 21 15:31 lvm_vgs_-v_-o_tags
-rw-r--r--. 1 root root 1162 Sep 21 15:31 nodectl_info
-rw-r--r--. 1 root root 1207 Sep 21 15:31 service_vdsmd_status
-rw-r--r--. 1 root root   27 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.bin.ls_-lR_.rhev.data-center
-rw-r--r--. 1 root root   42 Sep 21 15:31 
su_vdsm_-s_.bin.sh_-c_.usr.bin.tree_-l_.rhev.data-center
-rw-r--r--. 1 root root  537 Sep 21 15:31 
su_vdsm_-s_.usr.bin.python_.usr.share.vdsm.dumpStorageTable.pyc
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksInfo
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllTasksStatuses
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getAllVmStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getDeviceList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsCapabilities
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVdsStats
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_getVGList
-rw-r--r--. 1 root root  650 Sep 21 15:31 vdsClient_-s_0_list

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1:

ping

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

[igoihman]

Irit Goihman has abandoned this change.

Change subject: wip: tests: change testing framework to pytest
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Abandoned

as we agreed

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: shorten py3 blacklist

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: shorten py3 blacklist
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1826df637f6ccad5eed4e555153dcada7052ec8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: automation: add a repo with a fresh nose

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: automation: add a repo with a fresh nose
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic862433638be19ea770868b1cd5f0461b2ff6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/61902/19/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:

Line 24: from pwd import getpwnam
Line 25: import os
Line 26: 
Line 27: 
Line 28: def dropPrivileges():
> This change is not needed to fix the issue, but is nice, so I'll ignore it.
sorry, it bothered me... :)
Line 29: vdsm_uid, vdsm_gid = getpwnam(VDSM_USER)[2:4:]
Line 30: os.setgroups([])
Line 31: os.setgid(vdsm_gid)
Line 32: os.setuid(vdsm_uid)


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63765/1/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 131: self.collectExtOutput("/sbin/fdisk -l")
Line 132: self.collectExtOutput("/usr/bin/iostat")
Line 133: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 134: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 135: self.collectExtOutput("/usr/sbin/nodectl info")
> I don't have /usr/sbin/nodectl over my f24 and centos7 .. should we run it 
it runs only over rhv-h. sos report ignores the command if it doesn't exist.
Line 136: 
Line 137: with closing(_connectToVdsm()) as cli:
Line 138: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 139: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

[igoihman]

Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: move the api.py module in the common subtree

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: virt: move the api.py module in the common subtree
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd4c38ebaa120c617c7f0065cd5d93f134827893
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: functional tests: fix supervdsmServer test

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
..


Patch Set 19: Verified+1

(1 comment)

nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
09:37:08 functional.supervdsmFuncTests.TestSuperVdsmRemotly
09:37:08 testKsmAction   OK
09:37:08 testPingCallOK
09:37:08 
09:37:08 --
09:37:08 XML: /tmp/nosetests-el7.xml
09:37:08 --
09:37:08 Ran 2 tests in 0.052s

https://gerrit.ovirt.org/#/c/61902/16/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:

Line 34: 
Line 35: class TestSuperVdsmRemotly(TestCaseBase):
Line 36: 
Line 37: @forked
Line 38: @testValidation.ValidateRunningAsRoot
> You don't need this, we have @forked decorator for running tests in a child
Done
Line 39: def testPingCall(self):
Line 40: dropPrivileges()
Line 41: proxy = supervdsm.getProxy()
Line 42: self.assertTrue(proxy.ping())


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpc: revert Host.getVMList command result change
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: collect 'nodectl info' output
..

sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/63775/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index d3a5c38..24b5886 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -1,5 +1,5 @@
 #
-# Copyright 2008-2014 Red Hat, Inc.
+# Copyright 2008-2016 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -112,6 +112,7 @@
 self.collectExtOutput("/usr/bin/iostat")
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
+self.collectExtOutput("/usr/sbin/nodectl info")
 sslopt = ['', '-s '][config.getboolean('vars', 'ssl')]
 vdsclient = "/usr/bin/vdsClient " + sslopt + "0 "
 self.collectExtOutput(vdsclient + "getVdsCapabilities")


-- 
To view, visit https://gerrit.ovirt.org/63775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: collect 'nodectl info' output
..

sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/63765/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index dd3ae91..cc73faf 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -132,6 +132,7 @@
 self.collectExtOutput("/usr/bin/iostat")
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
+self.collectExtOutput("/usr/sbin/nodectl info")
 
 with closing(_connectToVdsm()) as cli:
 self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")


-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: move the api.py module in the common subtree

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: virt: move the api.py module in the common subtree
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd4c38ebaa120c617c7f0065cd5d93f134827893
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: revert Host.getVMList command result change

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: jsonrpc: revert Host.getVMList command result change
..

jsonrpc: revert Host.getVMList command result change

patch https://gerrit.ovirt.org/#/c/63408/ changes the result
representation of Host.getVMList and Host.getFullVMList but it
can cause inconsistency of these commands, therefore the change
is removed

Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 2 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/61/63761/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index f264e8d..bd180e0 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -326,14 +326,6 @@
 return {'path': ret['path']}
 
 
-def remove_status_from_ret(ret):
-"""
-seprate status from the actual result
-"""
-del ret['status']
-return ret
-
-
 ##
 # Possible ways to override a command:
 # - Supply a custom call function if the function name doesn't map directly to
@@ -359,10 +351,8 @@
 'Host_getStorageDomains': {'ret': 'domlist'},
 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
 'Host_hostdevListByCaps': {'ret': 'deviceList'},
-'Host_getVMList': {'call': Host_getVMList_Call,
-   'ret': remove_status_from_ret},
-'Host_getVMFullList': {'call': Host_getVMFullList_Call,
-   'ret': remove_status_from_ret},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
 'Host_getAllVmStats': {'ret': 'statsList'},
 'Host_setupNetworks': {'ret': 'status'},
 'Host_setKsmTune': {'ret': 'status'},


-- 
To view, visit https://gerrit.ovirt.org/63761
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ed615acfce50d07aa52af740e4963677c6de7cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: revert vmList change

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: net libvirt hook: revert vmList change
..

net libvirt hook: revert vmList change

Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 is reverted so the
vmList key change is also reverted.

Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Signed-off-by: Irit Goihman 
---
M tests/network/vm_migrate_hook_test.py
M vdsm/virt/vm_migrate_hook.py
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/63762/1

diff --git a/tests/network/vm_migrate_hook_test.py 
b/tests/network/vm_migrate_hook_test.py
index 7f11995..7294734 100644
--- a/tests/network/vm_migrate_hook_test.py
+++ b/tests/network/vm_migrate_hook_test.py
@@ -31,7 +31,7 @@
 class MockVdscli(object):
 @staticmethod
 def fullList(*args, **kwargs):
-return {'vmList': [VM_FULL_LIST]}
+return {'items': [VM_FULL_LIST]}
 
 
 class MockJsonrpcvdscli(object):
diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 5379cef..633e4f0 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -179,7 +179,7 @@
 
 def _vm_item(vdscli, vm_uuid):
 result = vdscli.fullList(fullStatus=True, vmList=(vm_uuid,))
-return result['vmList'][0] if len(result['vmList']) else None
+return result['items'][0] if len(result['items']) else None
 
 
 def _vdscli():


-- 
To view, visit https://gerrit.ovirt.org/63762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifec8f641276d3f48b6a60a14ee6d3b8a3abd6359
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Disable the builtin check target.

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build tests: Disable the builtin check target.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa413c5c176b1b6411a0bfb743670eaedfa549a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/62628/5/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 57
Line 58
Line 59
Line 60
Line 61
> how is this removal related to the use of dump-volume-chains?
Done


Line 126: self.collectExtOutput("/usr/bin/iostat")
Line 127: self.collectExtOutput("/sbin/iscsiadm -m node")
Line 128: self.collectExtOutput("/sbin/iscsiadm -m session")
Line 129: 
Line 130: with closing(jsonrpcvdscli.connect()) as cli:
> this change can be done in different patch
Done
Line 131: self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
Line 132: self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
Line 133: self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")
Line 134: self.addObjectAsFile(cli.list(), "list")


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: remove jsonrpcvdscli.connect parameters

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: remove jsonrpcvdscli.connect parameters
..

sos: remove jsonrpcvdscli.connect parameters

patch https://gerrit.ovirt.org/#/c/62730/ added default value to
requestQueue parameter in jsonrpcvdscli.connect() function.
This patch removes the creation of requestQueue parameter when
connecting to jsonrpcvdscli

Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/63728/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 5939d58..3a55ef9 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -53,12 +53,6 @@
 search = os.path.join(search, name)
 return module
 
-def _connectToVdsm():
-requestQueues = config.get("addresses", "request_queues")
-requestQueue = requestQueues.split(",")[0]
-return jsonrpcvdscli.connect(requestQueue=requestQueue)
-
-config = _importVdsmPylibModule("vdsm.config").config
 jsonrpcvdscli = _importVdsmPylibModule("vdsm.jsonrpcvdscli")
 
 
@@ -133,7 +127,7 @@
 self.collectExtOutput("/sbin/iscsiadm -m node")
 self.collectExtOutput("/sbin/iscsiadm -m session")
 
-with closing(_connectToVdsm()) as cli:
+with closing(jsonrpcvdscli.connect()) as cli:
 self.addObjectAsFile(cli.getVdsCapabilities(), 
"getVdsCapabilities")
 self.addObjectAsFile(cli.getVdsStats(), "getVdsStats")
 self.addObjectAsFile(cli.getAllVmStats(), "getAllVmStats")


-- 
To view, visit https://gerrit.ovirt.org/63728
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09dd50729ad0b964f08a13b2a648d375babc11bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build tests: Require NOSE 1.3.7 and up for running tests

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3:

> This looks correct, if https://gerrit.ovirt.org/63408 was correcdt,
 > but
 > I think it was wrong, changing the return value from list of vms to
 > dict with a vmList key, conflicting the schema and possibly
 > breaking engine.

Nir, can we talk about it offline? I don't see any conflict in the schema and a 
dict is returned now and before (just with different keys). We can test it 
further if you'd like.

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/62324/14/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 121: 
Line 122: 
Line 123: def _get_volume_info(server, vol_uuid, img_uuid, sd_uuid, sp_uuid):
Line 124: res = _call_server(
Line 125: server.getVolumeInfo, vol_uuid, sp_uuid, sd_uuid, img_uuid)
> why do you change this line? please mention it in the commit msg .
Done
Line 126: return res['info']
Line 127: 
Line 128: 
Line 129: def _get_volumes_chains(server, sd_uuid):


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: introducting broken_on_ci decorator

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: change getConnectedStoragePoolsList result key
..

sos: change getConnectedStoragePoolsList result key

patch https://gerrit.ovirt.org/#/c/63483 fixes
getConnectedStoragePoolsList result so it's needs to be updated in
sos report which uses the old wrong 'items' key.

Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/63557/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index dd3ae91..5939d58 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -143,8 +143,8 @@
 self.addObjectAsFile(
 cli.getAllTasksStatuses(), "getAllTasksStatuses")
 
-if "items" in cli.getConnectedStoragePoolsList():
-pools_list = cli.getConnectedStoragePoolsList()["items"]
+if "poollist" in cli.getConnectedStoragePoolsList():
+pools_list = cli.getConnectedStoragePoolsList()["poollist"]
 for pool in pools_list:
 self.addObjectAsFile(
 cli.getSpmStatus(pool), "getSpmStatus " + pool)


-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix results of several commands
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 13: Verified+1

[root@lochte vdsm]# vdsm-tool dump-volume-chains 
'05558ceb-52c6-4bf4-ab8d-e4d94416eaf0'

Images volume chains (base volume first)

   image:5d5c6bdf-6b03-4daf-9b60-3e0056320c0d

 - 447756a0-950d-4950-ad7e-512bca6fe47c
   status: OK, voltype: LEAF, format: RAW, legality: LEGAL, type: 
SPARSE


   image:e03de708-a020-405c-9a36-28b6b93f69a4

 - 9a2b3226-47f9-4ded-9107-4ebdfcf32029
   status: OK, voltype: LEAF, format: RAW, legality: LEGAL, type: 
PREALLOCATED


   image:589ce3f8-8e66-4e00-a64e-eab2d5e93f71

 - 95c768bd-75af-4134-a3e3-bcea47c1bc8b
   status: OK, voltype: LEAF, format: RAW, legality: LEGAL, type: 
PREALLOCATED


   image:e5527f3c-9664-41ef-a279-09f8875764ac

 - 05a1ee7d-75b2-4a73-bee3-2981bdd73982
   status: OK, voltype: LEAF, format: RAW, legality: LEGAL, type: 
SPARSE

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 13:

(2 comments)

https://gerrit.ovirt.org/#/c/62324/11/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

PS11, Line 160: image
> Please make sure that we do not change the key names. It creates inconsiste
Done


PS11, Line 165: uuidl
> same here
Done


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix results of several commands

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: fix results of several commands
..

jsonrpcvdscli: fix results of several commands

There are some commands that return result in a bad format that is
not backword compatible with xmlrpc results.
The result contains an inner dictionary or a list that should be
saved in a dictionary under a certain key, but until now only the
inner dictionary/list were in the result. This caused overriding of
several fields and bad formatting.
It is impossible to change all the commands results since it breaks the
engine so only some commands results have been changed.

Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/63483/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index f264e8d..b281be8 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -346,7 +346,7 @@
 'Host_getAllTasksInfo': {'ret': 'allTasksInfo'},
 'Host_getAllTasksStatuses': {'ret': 'allTasksStatus'},
 'Host_getCapabilities': {'ret': Host_getCapabilities_Ret},
-'Host_getConnectedStoragePools': {'ret': 'poollist'},
+'Host_getConnectedStoragePools': {'ret': remove_status_from_ret},
 'Host_getDeviceList': {'ret': 'devList'},
 'Host_getDevicesVisibility': {'ret': 'visible'},
 'Host_getExternalVMs': {'ret': 'vmList'},
@@ -381,10 +381,10 @@
 'LVMVolumeGroup_create': {'ret': 'uuid'},
 'LVMVolumeGroup_getInfo': {'ret': 'info'},
 'StorageDomain_getFileStats': {'ret': 'fileStats'},
-'StorageDomain_getImages': {'ret': 'imageslist'},
+'StorageDomain_getImages': {'ret': remove_status_from_ret},
 'StorageDomain_getInfo': {'ret': 'info'},
 'StorageDomain_getStats': {'ret': 'stats'},
-'StorageDomain_getVolumes': {'ret': 'uuidlist'},
+'StorageDomain_getVolumes': {'ret': remove_status_from_ret},
 'StorageDomain_resizePV': {'ret': 'size'},
 'StoragePool_connectStorageServer': {'ret': 'statuslist'},
 'StoragePool_disconnectStorageServer': {'ret': 'statuslist'},
@@ -428,7 +428,7 @@
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 'uuid'},
 'Volume_delete': {'ret': 'uuid'},
-'Volume_getInfo': {'ret': 'info'},
+'Volume_getInfo': {'ret': remove_status_from_ret},
 'Volume_getPath': {'ret': 'path'},
 'Volume_getSize': {'ret': Volume_getsize_Ret},
 'Volume_extendSize': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f6b5862a69ea3d5140352fce7dda51bb95bab9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: stomp: use socket pending

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: stomp: use socket pending
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf0e2bfccd10bc825514677f054c3850100a713
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 5: Verified+1

passes on jenkins
http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/24/

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/63408/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 360: 'Host_getStorageDomains': {'ret': 'domlist'},
Line 361: 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
Line 362: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 363: 'Host_getVMList': {'call': Host_getVMList_Call,
Line 364:'ret': Host_getVMList_Ret},
> Please keep formatting as it is in this module.
Done
Line 365: 'Host_getVMFullList': {'call': Host_getVMFullList_Call,
Line 366:'ret': Host_getVMList_Ret},
Line 367: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 368: 'Host_setupNetworks': {'ret': 'status'},


-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 1:

In [3]: server.list()
Out[3]: 
{'status': {'code': 0, 'message': 'Done'},
 u'vmList': [u'7fbcda8e-847c-449a-a25d-105a1de02cb8']}
In [5]: server.fullList()
Out[5]: 
{'status': {'code': 0, 'message': 'Done'},
 u'vmList': [{u'acpiEnable': u'true',
   u'bootMenuEnable': u'false',
   u'clientIp': u'',
   u'cpuType': u'Penryn',
...

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

[igoihman]

Irit Goihman has abandoned this change.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/63052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I985db6344fa7e34d78d38d7c6fe96a6b91839604
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix getVolumeInfo command result

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: fix getVolumeInfo command result
..

jsonrpcvdscli: fix getVolumeInfo command result

getVolumeInfo command returns a dictionary with volume info stats.
The result should hold all the data in 'info' key but instead it
stores the inner dictionary as the main one and 'status' field of
the dictionary is overriden by JsonRpcResponse status

Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/63410/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 62db38f..2c00dcf 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -102,7 +102,7 @@
 if member is None:
 return None
 try:
-return {member: response[member]}
+return response[member]
 except KeyError:
 raise VdsmError(5, "Response is missing '%s' member" % member)
 
@@ -315,6 +315,15 @@
 return {'params': ret['params'], 'migrationPort': ret['migrationPort']}
 
 
+def Volume_getInfo_Ret(ret):
+"""
+The returned dictionary doesn't separate the info from the status code
+so we need to rebuild the result.
+"""
+del ret['status']
+return ret
+
+
 def Volume_getsize_Ret(ret):
 """
 Merge the two sizes into a single dictionary result.
@@ -418,7 +427,7 @@
 'Volume_copy': {'ret': 'uuid'},
 'Volume_create': {'ret': 'uuid'},
 'Volume_delete': {'ret': 'uuid'},
-'Volume_getInfo': {'ret': 'info'},
+'Volume_getInfo': {'ret': Volume_getInfo_Ret},
 'Volume_getPath': {'ret': 'path'},
 'Volume_getSize': {'ret': Volume_getsize_Ret},
 'Volume_extendSize': {'ret': 'uuid'},


-- 
To view, visit https://gerrit.ovirt.org/63410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2befe845b1d9885638cc4254e60cebd66eb6f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..

jsonrpcvdscli: fix Host.getVMList command result

Host.getVMList and Host.getFullVMList are similar commands that differ in
their verbosity level. Their result should be represented as a value inside
a dictionary with 'vmList' key. Instead of that, it was represented as
a list and during the creation of JsonRPCResponse it was re constructed
inside a dictionary holding the result inside 'items' key.

Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Signed-off-by: Irit Goihman 
---
M lib/vdsm/rpc/Bridge.py
1 file changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/63408/1

diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index bd180e0..79c4bc0 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -270,6 +270,15 @@
 return API.Global().getVMList(False, vmList, onlyUUID)
 
 
+def Host_getVMList_Ret(ret):
+"""
+The returned dictionary doesn't separate the vmList from the status code
+so we need to rebuild the result.
+"""
+del ret['status']
+return ret
+
+
 def Host_getVMFullList_Call(api, args):
 """
 This call is interested in returning full status.
@@ -351,8 +360,16 @@
 'Host_getStorageDomains': {'ret': 'domlist'},
 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
 'Host_hostdevListByCaps': {'ret': 'deviceList'},
-'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
-'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
+'Host_getVMList':
+{
+'call': Host_getVMList_Call,
+'ret': Host_getVMList_Ret
+},
+'Host_getVMFullList':
+{
+'call': Host_getVMFullList_Call,
+'ret': Host_getVMList_Ret
+},
 'Host_getAllVmStats': {'ret': 'statsList'},
 'Host_setupNetworks': {'ret': 'status'},
 'Host_setKsmTune': {'ret': 'status'},


-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: wip: py3: port storage misc.py file to python3

[igoihman]

Irit Goihman has abandoned this change.

Change subject: wip: py3: port storage misc.py file to python3
..


Abandoned

duplicate

-- 
To view, visit https://gerrit.ovirt.org/60001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1adec40146967965329024718c6ff48d0fa089fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10:

seems like the rebase is fine.
you can add another patch with makefile change on top of this patch.

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 4: Verified-1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 7:

> (1 comment)
 > 
 > I am not at all certain logSkip change is entirely safe. The
 > supposed change seems to pass all tests using misc.py for both
 > versions, and that's all I can account for.

you accidentally removed the Makefile. Also, please change the commit message 
so it will explain the removal of alignment scan tests also (if you intend to 
remove it in this patch).

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonvdscli: change hostname default

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: added VM cont verb

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: added VM cont verb
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f740c83517850251f2ed3f6fd64c87a263e404f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: added VM cont verb

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: jsonrpcvdscli: added VM cont verb
..

jsonrpcvdscli: added VM cont verb

VM.cont is needed in order to resume paused VMs

Change-Id: I0f740c83517850251f2ed3f6fd64c87a263e404f
Signed-off-by: Irit Goihman 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/63310/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index e82d970..d725a6b 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -40,6 +40,7 @@
 'activateStorageDomain': 'StorageDomain.activate',
 'connectStoragePool': 'StoragePool.connect',
 'connectStorageServer': 'StoragePool.connectStorageServer',
+'cont': 'VM.cont',
 'clearTask': 'Task.clear',
 'create': 'VM.create',
 'createStorageDomain': 'StorageDomain.create',


-- 
To view, visit https://gerrit.ovirt.org/63310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f740c83517850251f2ed3f6fd64c87a263e404f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonvdscli: change hostname default

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 6: Code-Review+1

rebased and verified

-- 
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 4: Verified+1

passes on jenkins 
http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/11/console

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 4:

(2 comments)

sorry for the delayed response, I'm currently working on a fix to the jsonrpc 
command result representation, thus this patch isn't ready yet.

https://gerrit.ovirt.org/#/c/62628/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 58: 
Line 59: class vdsm(Plugin, RedHatPlugin):
Line 60: """VDSM server related information
Line 61: """
Line 62: 
> do we still need this?
Done
Line 63: optionList = [("logsize", 'max size (MiB) to collect per log 
file', '',
Line 64:False)]
Line 65: 
Line 66: # Make compatible com sos version >= 3


Line 149: self.collectExtOutput("vdsm-tool dump-volume-chains %s" % 
sd_uuid)
Line 150: 
Line 151: def _addVdsmRunDir(self):
Line 152: """Add everything under /var/run/vdsm except possibly 
confidential
Line 153: sysprep vfds and sockets"""
> I think this would explode if you have multiple storage domains in the data
Done
Line 154: 
Line 155: import glob
Line 156: 
Line 157: for f in glob.glob("@VDSMRUNDIR@/*"):


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 11:

> Irit - can you answer Piotr?

Oved, I already talked with Piotr offline, I'm currently working on a fix of 
the jsonrpc returned result and I'll rebase this patch when I'm done 
researching for impacts of this change.

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 2: Verified+1

passes on jenkins 
http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/5/

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix makefile - move config.log to right location

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: Fix makefile - move config.log to right location
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60615fbc75162dd686b5f40e525a790a6330f80
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/63192/5/tests/Makefile.am
File tests/Makefile.am:

PS5, Line 164: 
> I actually like it here, because it proves that misc.py has actually been f
as you wish, I think there are more tests that pass after this change so they 
can also be removed


-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/63192/5/tests/Makefile.am
File tests/Makefile.am:

PS5, Line 164: 
better push it in a different patch since this patch is only about porting 
misc.py to py3


-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: certificates: remove config.read call

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: certificates: remove config.read call
..


Patch Set 1:

ping?

-- 
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: spec: Obsolete actual vdsm-infra packages

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: spec: Obsolete actual vdsm-infra packages
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63215
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a832fa02f0538ac9a22dfabfd291928ca4db7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc.py py3 compliance via six

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: misc.py py3 compliance via six
..


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/63192/2//COMMIT_MSG
Commit Message:

PS2, Line 7: misc.py py3 compliance via six
please use this commit message format:
topic: short summary

longer description (if needed)


https://gerrit.ovirt.org/#/c/63192/2/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:

PS2, Line 70: six.moves.imap
i think it's six.moves.map, please check again


PS2, Line 668: six.moves.queue
it will be more readable to import six.moves.queue and six.moves.map than call 
the full name of the module.


PS2, Line 698: xrange
xrange is removed in python 3, please replace it also


-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org