Irit Goihman has posted comments on this change. Change subject: sos: replace dumpStorageTable with dump_volume_chains ......................................................................
Patch Set 4: (2 comments) sorry for the delayed response, I'm currently working on a fix to the jsonrpc command result representation, thus this patch isn't ready yet. https://gerrit.ovirt.org/#/c/62628/3/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 58: Line 59: class vdsm(Plugin, RedHatPlugin): Line 60: """VDSM server related information Line 61: """ Line 62: > do we still need this? Done Line 63: optionList = [("logsize", 'max size (MiB) to collect per log file', '', Line 64: False)] Line 65: Line 66: # Make compatible com sos version >= 3 Line 149: self.collectExtOutput("vdsm-tool dump-volume-chains %s" % sd_uuid) Line 150: Line 151: def _addVdsmRunDir(self): Line 152: """Add everything under /var/run/vdsm except possibly confidential Line 153: sysprep vfds and sockets""" > I think this would explode if you have multiple storage domains in the data Done Line 154: Line 155: import glob Line 156: Line 157: for f in glob.glob("@VDSMRUNDIR@/*"): -- To view, visit https://gerrit.ovirt.org/62628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marina Kalinin <m...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
