Change in vdsm[master]: Add an option to create a watchdog device.
Dan Kenigsberg has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add an option to create a watchdog device.
..
Add an option to create a watchdog device.
A support for a watchdog device was added to the devices
configuration.
Also add the watchdog event callback to log the watchdog action
of VM.
model of watchdog:
'i6300esb' default model, emulating a PCI Intel 6300ESB
'ib700'emulating an ISA iBase IB700
Only one watchdog device is supported for each VM.
action of watchdog timeout:
'reset' forcefully reset the guest
'shutdown' gracefully shutdown the guest (not recommended)
'poweroff' forcefully power off the guest
'pause' pause the guest
'none' default, do nothing
'dump' automatically dump the guest
the parameter of 'watchdog' device as follow:
{'device': 'watchdog', 'type': 'watchdog',
'specParams': {'model': 'i6300esb', 'action': 'none'}}
The watchdog device can be used to detect guest crash or hang, and
if 'dump' is chosen for the action of watchdog timeout, libvirt will
dump guest's memory on timeout automatically.
The directory to save dump files can be configured by auto_dump_path
in file /etc/libvirt/qemu.conf.
The watchdog device requires an additional driver and management
daemon in the guest. Just enabling the watchdog in the vdsm
devices configuration does not do anything useful on its own.
Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Signed-off-by: ShaoHe Feng shao...@linux.vnet.ibm.com
---
M tests/libvirtvmTests.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.init.in
M vdsm/vm.py
M vdsm_api/vdsmapi-schema.json
6 files changed, 182 insertions(+), 5 deletions(-)
Approvals:
ShaoHe Feng: Verified
Vinzenz Feenstra: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Michal Skrivanek has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Looks good to me, but someone else must approve My only concern/question is about not filling /var partition when dumping the vm. We need some protection for that or at least some kind of alarm/warning. Doron? -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Doron Fediuck has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Generally speaking this would be the standard location for vdsm-related dumps. it's configured accordingly in ovirt-node as well as Fedora/RHEL. IIRC we should get low disk warnings, but this needs verification. Still, even if no such warning we can open a relevant RFE for VDSM to report host low-space. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Dan Kenigsberg has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Looks good to me, but someone else must approve (Waiting for Michal's PoV) -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 12: (1 inline comment)
File vdsm/libvirtvm.py
Line 2200: self.startDisksStatsCollection()
Line 2201:
Line 2202: return {'status': doneCode}
Line 2203:
Line 2204: def _onWatchdogEvent(self, name, vmid, action):
yes, agree.
Line 2205: def actionToString(action):
Line 2206: # the following action strings come from the comments of
Line 2207: # virDomainEventWatchdogAction in
include/libvirt/libvirt.h
Line 2208: # of libvirt source.
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Verified -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Vinzenz Feenstra has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 13: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Dan Kenigsberg has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
Thanks!
Only a minor comment on excessive callback arguments.
File vdsm_api/vdsmapi-schema.json
Line 2208: # An enumeration of VM watchdog device types.
Line 2209: #
Line 2210: # @watchdog: Device type watchdog
Line 2211: #
Line 2212: # Since: 4.10.0
we're 4.10.1 already, not that anyone cares
Line 2213: ##
Line 2214: {'enum': 'VmWatchdogDeviceType', 'data': ['watchdog']}
Line 2215:
Line 2216: ##
File vdsm/libvirtvm.py
Line 2200: self.startDisksStatsCollection()
Line 2201:
Line 2202: return {'status': doneCode}
Line 2203:
Line 2204: def _onWatchdogEvent(self, name, vmid, action):
why do we need name and vmid as args to this callback? aren't they already in
self.conf[vmId] and [vmName]?
ps. vmId is already logged by our SimpleLogAdapter.
Line 2205: def actionToString(action):
Line 2206: # the following action strings come from the comments of
Line 2207: # virDomainEventWatchdogAction in
include/libvirt/libvirt.h
Line 2208: # of libvirt source.
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Michal Skrivanek has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 12: Are you following up with engine-side patch to get a proper support? Then the hook can be removed, right? -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 12: Verified; No score -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 12: Looks good to me, but someone else must approve the engine can add a watchdog device easily， the same way as other device. there is a wiki about it. http://wiki.ovirt.org/wiki/Add_an_option_to_create_a_watchdog_device which hook? -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Mark Wu has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 12: Looks good to me, but someone else must approve With this patch, engine can't find a watchdog event is triggered. Perhaps you need add a flag to vm stats to indicate the event happened and what action was taken. Then engine could find it by polling vm's stats. I am fine with that you submit another patch to resolve that. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Vinzenz Feenstra has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 12: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Mark Wu has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 10: I would prefer that you didn't submit this
(3 inline comments)
File vdsm/libvirtvm.py
Line 1170: watchdog model='i6300esb' action='reset'
Line 1171: address type='pci' domain='0x' bus='0x00' slot='0x05'
Line 1172:function='0x0'/
Line 1173: /watchdog
Line 1174:
also add a test case for it to tests/libvirtvmTests.py ?
Line 1175: m = self.createXmlElem(self.type, None, ['address'])
Line 1176: m.setAttribute('model', self.specParams['model'])
Line 1177: m.setAttribute('action', self.specParams['action'])
Line 1178: return m
Line 2440: dev.specParams['action'] = action
Line 2441: for dev in self.conf['devices']:
Line 2442: if ((dev['type'] == vm.WATCHDOG_DEVICES) and
Line 2443: not action in dev['specParams']):
Line 2444: dev['specParams']['action'] = action
you have give a default action 'none' to it, so you needn't fetch it from
libvirt again. so you should remove lines from 2438 to 2444
Line 2445:
Line 2446: def _getUnderlyingVideoDeviceInfo(self):
Line 2447:
Line 2448: Obtain video devices info from libvirt.
File vdsm/vdsmd.init.in
Line 332: set_if_default $qlconf auto_disk_leases 0
Line 333: set_if_default $qlconf require_lease_for_disks 0
Line 334:
Line 335: # Configuring auto dump path
Line 336: set_if_default $qconf auto_dump_path \$QEMU_DUMP_PATH\
To make the configuration change apply after upgrading vdsm, you also need bump
by_vdsm_vers
Line 337:
Line 338: # Write to all conf files the *end* message of vdsm changes
Line 339: for arg in ${lconf} ${qconf} ${ldconf} ${qlconf}
Line 340: do
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 11: Verified
how to verified this patch.
Maybe there is no a UI in engine to add a watchdog device.
you can start a vm directly by vdsm with a wathdog device parameter.
http://wiki.ovirt.org/wiki/Vdsm_Standalone
add a wathdog device parameter
dev_list = [{'device': 'watchdog', 'type': 'watchdog', 'specParams': {'model':
'ib700', 'action': dump}}
vdsOK(
s.create(dict(vmId=vmId,
drives=[dict(poolID=spUUID, domainID=sdUUID, imageID=imgUUID,
volumeID=volUUID)],
memSize=256,
display=vnc,
vmName=vm1,
devices = dev_list,
)
)
)
after the vm start up, you can use virsh to watch the watchdog device in xml.
# virsh -c qemu:///system sudo virsh -c qemu:///system dumpxml vm1.
you can also log on vm1
# ls /dev/watchdog
but some os such as ubuntu will add the watchdog automatically for the udev
rule.
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 11: sorry, but some os version such as ubuntu will not add the watchdog automatically. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 11: some format error with my last Message. after the vm start up, you can use virsh to watch the watchdog device in xml on host. # virsh -c qemu:///system sudo virsh -c qemu:///system dumpxml vm1. you can also log on guest to check: # ls /dev/watchdog* Some guest OS such as ubuntu will not add the watchdog automatically for the udev rule. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Doron Fediuck has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe,
Thanks for sorting out the path issue, and for submitting this patch.
There are other issues I just noticed we need to verify:
1. Default action should not be reset, as this may be harmful. We should
default to none. So unless the user specified he wants to reset, no harm will
be caused.
2. Just to make sure I fully understand, by default a VM will not have a
Watchdog device, unless given by the engine. Is this correct? We need to ensure
users will not get new devices unless they specifically ask for it.
File vdsm/libvirtvm.py
Line 1174:
Line 1175: m = self.createXmlElem(self.type, None, ['address'])
Line 1176: m.setAttribute('model', self.specParams['model'])
Line 1177: if 'action' in self.specParams:
Line 1178: m.setAttribute('action', self.specParams['action'])
Please set default action to None.
We do not want see VMs reseting just because the device was accidentally
attached.
I expect the users of the watchdog device to specify it explicitly as well as
the desired action, as this has harmful implications.
Line 1179: return m
Line 1180:
Line 1181:
Line 1182: class RedirDevice(LibvirtVmDevice):
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 9: Doron Thank you for your review. 1. Default action will be set 'none' in the next patch. 2. A VM does not have a watchdog device, unless given by the engine. the engine should specify the watchdog device when create a VM. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Doron Fediuck has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 10: Looks good to me, but someone else must approve ShaoHe, good job! -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Adam Litke has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 10: (3 inline comments)
Just some minor formatting issues in the schema. Looks good otherwise. Have
you verified it?
File vdsm_api/vdsmapi-schema.json
Line 2220: #
Line 2221: # @i6300esb: the recommended device, emulating a PCI Intel 6300ESB
Line : #
Line 2223: # @IB700: emulating an ISA iBase IB700 as watchdog
Line 2224: #
Please align the descriptions so they all start at the same column. See the
rest of the file for how it's done. Sorry to be pedantic, but the rest of the
file looks so nice :)
Line 2225: # Since: 4.10.0
Line 2226: ##
Line 2227: {'enum': 'VmWatchdogDeviceModel', 'data': ['i6300esb', 'IB700']}
Line 2228:
Line 2233: #
Line 2234: # @reset: default, forcefully reset the guest
Line 2235: #
Line 2236: # @shutdown: gracefully shutdown the guest (not recommended)
Line 2237: #
alignment.
Line 2238: # @poweroff: forcefully power off the guest
Line 2239: #
Line 2240: # @pause: pause the guest
Line 2241: #
Line 2277: #
Line 2278: # @specParams: #optional Additional device parameters
Line 2279: #
Line 2280: # @deviceId:A unique ID for this device
Line 2281: #
These are aligned the way they should be.
Line 2282: # Since: 4.10.0
Line 2283: ##
Line 2284: {'type': 'VmWatchdogDevice',
Line 2285: 'data': {'deviceType': 'VmDeviceType', 'device':
'VmWatchdogDeviceType',
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Michael Burns has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 8: I would prefer that you didn't submit this (1 inline comment) File vdsm/vdsmd.init.in Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH=/var/lib/vdsm/dump Any reason we can't send this to /var/log/core? We persist that to /data so it's not in-memory and persists across reboots. The location does exist and would *work*, but you'd be consuming available memory every time this happens and a reboot would wipe the file out. Also worth noting that there is no facility to read or retrieve this dump on ovirt-node Line 36: NEEDED_SERVICES=iscsid multipathd ntpd wdmd sanlock Line 37: CONFLICTING_SERVICES=libvirt-guests Line 38: Line 39: LCONF=/etc/libvirt/libvirtd.conf -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
ShaoHe Feng has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 8: (1 inline comment) File vdsm/vdsmd.init.in Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH=/var/lib/vdsm/dump how can we get the dump file in /var/log/core? scp or other way? Line 36: NEEDED_SERVICES=iscsid multipathd ntpd wdmd sanlock Line 37: CONFLICTING_SERVICES=libvirt-guests Line 38: Line 39: LCONF=/etc/libvirt/libvirtd.conf -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Doron Fediuck has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 8: I would prefer that you didn't submit this (1 inline comment) ShaoHe, since vdsm is included in ovirt-node, you need to verify the patch you chose to hold the dump files exists and is capable of holding these files. Please contact mbu...@redhat.com or any of the node dev's to make sure this will not break the node integration. File vdsm/vdsmd.init.in Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH=/var/lib/vdsm/dump You need to verify this path exists in ovirt node and has a capacity to hold the expected output. Line 36: NEEDED_SERVICES=iscsid multipathd ntpd wdmd sanlock Line 37: CONFLICTING_SERVICES=libvirt-guests Line 38: Line 39: LCONF=/etc/libvirt/libvirtd.conf -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Shu Ming has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
File vdsm/vm.py
Line 426: else:
Line 427: devices = self.getConfDevices()
Line 428:
Line 429: # libvirt only support one watchdog device
Line 430: if len(devices[BALLOON_DEVICES]) 1:
Do you mean 'devices[WATCHDOG_DEVICES}' instead of 'devices[BALOON_DEVICES]'
here? And the same questions as lines below.
Line 431: raise ValueError(only a single watchdog device is
supported)
Line 432: if len(devices[BALLOON_DEVICES]) == 1:
Line 433: if not 'specParams' in devices[BALLOON_DEVICES][0]:
Line 434: devices[BALLOON_DEVICES][0]['specParams'] = {}
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add an option to create a watchdog device.
Mark Wu has posted comments on this change.
Change subject: Add an option to create a watchdog device.
..
Patch Set 4: I would prefer that you didn't submit this
(13 inline comments)
Commit Message
Line 8:
Line 9: A support for a watchdog device was added to the devices
Line 10: configuration.
Line 11:
Line 12: Also add the watchdog event callback.
Add a description for what you do in the callback function.
Line 13:
Line 14: model of watchdog:
Line 15: 'i6300esb' default model, emulating a PCI Intel 6300ESB
Line 16: 'ib700'emulating an ISA iBase IB700
Line 13:
Line 14: model of watchdog:
Line 15: 'i6300esb' default model, emulating a PCI Intel 6300ESB
Line 16: 'ib700'emulating an ISA iBase IB700
Line 17: only one watchdog device was support.
Only one watchdog device is supported for each VM.
Line 18:
Line 19: action of watchdog:
Line 20: 'reset' default, forcefully reset the guest
Line 21: 'shutdown' gracefully shutdown the guest (not recommended)
Line 15: 'i6300esb' default model, emulating a PCI Intel 6300ESB
Line 16: 'ib700'emulating an ISA iBase IB700
Line 17: only one watchdog device was support.
Line 18:
Line 19: action of watchdog:
action of watchdog timeout ?
Line 20: 'reset' default, forcefully reset the guest
Line 21: 'shutdown' gracefully shutdown the guest (not recommended)
Line 22: 'poweroff' forcefully power off the guest
Line 23: 'pause' pause the guest
Line 26:
Line 27: the parameter of 'watchdog' device as follow:
Line 28: {'device': 'watchdog', 'type': 'watchdog',
Line 29: 'specParams': {'model': 'i6300esb', 'action': 'reset'}}
Line 30:
Move line 14 to line 30 to api schema
Line 31: The watchdog device can used to detect guest crash, and if choose
Line 32: 'dump' action, the libvirt will dump the guest automatically.
Line 33: The directory to save dump files can be configured by auto_dump_path
Line 34: in file /etc/libvirt/qemu.conf.
Line 27: the parameter of 'watchdog' device as follow:
Line 28: {'device': 'watchdog', 'type': 'watchdog',
Line 29: 'specParams': {'model': 'i6300esb', 'action': 'reset'}}
Line 30:
Line 31: The watchdog device can used to detect guest crash, and if choose
can be used ... guest crash or hang, and if 'dump' is chosen for the action of
watchdog timeout
Line 32: 'dump' action, the libvirt will dump the guest automatically.
Line 33: The directory to save dump files can be configured by auto_dump_path
Line 34: in file /etc/libvirt/qemu.conf.
Line 35:
Line 28: {'device': 'watchdog', 'type': 'watchdog',
Line 29: 'specParams': {'model': 'i6300esb', 'action': 'reset'}}
Line 30:
Line 31: The watchdog device can used to detect guest crash, and if choose
Line 32: 'dump' action, the libvirt will dump the guest automatically.
'dump' action, libvirt will dump guest's memory on timeout automatically.
Line 33: The directory to save dump files can be configured by auto_dump_path
Line 34: in file /etc/libvirt/qemu.conf.
Line 35:
Line 36: The watchdog device requires an additional driver and management
File vdsm/libvirtconnection.py
Line 63: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_BLOCK_JOB:
Line 64: path, type, status = args[:-1]
Line 65: v._onBlockJobEvent(path, type, status)
Line 66: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_WATCHDOG:
Line 67: wdargs = args[:-1]
why introduce a new variable? Can you use agrs directly?
Line 68: action = libvirtev.watchdogActionToString(wdargs[0])
Line 69: cif.log.debug(watchdog event: Domain %s(%s). Action: %s,
Line 70: dom.name(), dom.ID(), action)
Line 71: v._onWatchdogEvent(dom.name(), dom.ID(), action)
Line 66: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_WATCHDOG:
Line 67: wdargs = args[:-1]
Line 68: action = libvirtev.watchdogActionToString(wdargs[0])
Line 69: cif.log.debug(watchdog event: Domain %s(%s). Action: %s,
Line 70: dom.name(), dom.ID(), action)
Why not using UUID?
Move the log into _onWatchdogEvent ?
Line 71: v._onWatchdogEvent(dom.name(), dom.ID(), action)
Line 72: else:
Line 73: v.log.warning('unknown eventid %s args %s', eventid, args)
Line 74: except:
File vdsm/libvirtev.py
Line 452: Guest is requested to gracefully shutdown,
Line 453: No action, a debug message logged)
Line 454: return actionStrings[action]
Line 455:
Line 456:
Move this convert function to libvirtvm.py, and it should be only used for
onWatchdogEvent()
Line 457: def myDomainEventCallback1(conn, dom, event, detail, opaque):
Line 458: print
Change in vdsm[master]: Add an option to create a watchdog device.
Ryan Harper has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 4: I would prefer that you didn't submit this Before you add a new API to list debuging core dump files, at least configure the qemu.conf auto_dump_path so we can have a common location where the dumps will be avaiable. You can later post a series on a new API call to fetch debugging info which may include more data than just the watchdog dump file. -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
