Change in vdsm[master]: Add deathSignal options to better popen

2013-11-17 Thread danken 
Dan Kenigsberg has abandoned this change.

Change subject: Add deathSignal options to better popen
..


Abandoned

merged out of vdsm's tree.

-- 
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-10-07 Thread shuming 
Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 13: No score

(1 inline comment)


File vdsm/betterPopen/createprocess.c
Line 315: rv = read(errnofd[0], childErrno, sizeof(int));
Line 316: if (rv  0) {
Line 317: switch (errno) {
Line 318: case EINTR:
Line 319: case EAGAIN:
I am Okay with that.
Line 320: break;
Line 321: default:
Line 322: PyErr_SetString(PyExc_OSError, 
strerror(childErrno));
Line 323: goto fail;


--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-09-25 Thread smizrahi 
Saggi Mizrahi has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 13: (1 inline comment)


File vdsm/betterPopen/createprocess.c
Line 315: rv = read(errnofd[0], childErrno, sizeof(int));
Line 316: if (rv  0) {
Line 317: switch (errno) {
Line 318: case EINTR:
Line 319: case EAGAIN:
I already knew that EAGAIN is impossible. I just thought I'll put it here and 
be done with it. I don't think this fix merits another iteration.
Line 320: break;
Line 321: default:
Line 322: PyErr_SetString(PyExc_OSError, 
strerror(childErrno));
Line 323: goto fail;


--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-09-24 Thread shuming 
Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 12: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/betterPopen/createprocess.c
Line 310: 
Line 311: if (deathSignal) {
Line 312: /* death signal sync point */
Line 313: if (read(errnofd[0], childErrno, sizeof(int)) != 
sizeof(int)) {
Line 314: PyErr_SetString(PyExc_OSError, strerror(childErrno));
It is more robust to check the return code of  read() to know what the status 
of read() system is.  Normally, EAGIN and EINTR should be checked.
Line 315: goto fail;
Line 316: }
Line 317: 
Line 318: if (childErrno != 0) {


--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-09-24 Thread shuming 
Shu Ming has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/betterPopen/createprocess.c
Line 315: rv = read(errnofd[0], childErrno, sizeof(int));
Line 316: if (rv  0) {
Line 317: switch (errno) {
Line 318: case EINTR:
Line 319: case EAGAIN:
errnofd[] are blocking  IO fds here, see the code line 226.  pipe() system call 
should return non-blocking fds without O_NONBLOCK set manually.  So EAGAIN is 
not a possible error value for the read() call here, EAGAIN is only for 
non-blocking fds.  Tough it is not harmful to handle  EAGAIN case here, I would 
suggest to remove EAGAIN in case of  confusing.  Please ignore my previous 
comments about EAGAIN.  So you only need handle EINTR here.
Line 320: break;
Line 321: default:
Line 322: PyErr_SetString(PyExc_OSError, 
strerror(childErrno));
Line 323: goto fail;


--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-09-23 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 11: Fails

(3 inline comments)

`make check-local` fails.


File tests/betterPopenTests.py
Line 150: p.wait()
Line 151: self.assertTrue(p.returncode == 0,
Line 152: Process failed: %s % os.strerror(p.returncode))
Line 153: 
Line 154: self.assertEquals(p.stdout.read(), data)
a pep8 fairy just died.
Line 155: def testDeathSignal(self):
Line 156: procPtr = [None]
Line 157: def spawn():
Line 158: procPtr[0] = BetterPopen([sleep, 10], 
deathSignal=signal.SIGKILL)


Line 152: Process failed: %s % os.strerror(p.returncode))
Line 153: 
Line 154: self.assertEquals(p.stdout.read(), data)
Line 155: def testDeathSignal(self):
Line 156: procPtr = [None]
this pointer trick should have an auto-completion rule for adding a comment...
Line 157: def spawn():
Line 158: procPtr[0] = BetterPopen([sleep, 10], 
deathSignal=signal.SIGKILL)
Line 159: t = threading.Thread(target=spawn)
Line 160: t.start()


Line 154: self.assertEquals(p.stdout.read(), data)
Line 155: def testDeathSignal(self):
Line 156: procPtr = [None]
Line 157: def spawn():
Line 158: procPtr[0] = BetterPopen([sleep, 10], 
deathSignal=signal.SIGKILL)
and another one here.
Line 159: t = threading.Thread(target=spawn)
Line 160: t.start()
Line 161: t.join()
Line 162: start = time.time()


--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-08-19 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 10: Looks good to me, but someone else must approve

I would have expected that you, of all people, would add a unit test for the 
new functionality.

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add deathSignal options to better popen

2012-08-13 Thread Gerrit Code Review 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Add deathSignal options to better popen
..


Patch Set 10:

Build Failed 

http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/424/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches