Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has abandoned this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:

Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8: 
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
> I trust Bronheim that he picked the best tool for the job and considered be
So in this case I tend to agree that we need a maintainer to stop such changes 
as I did here. I agree that someone might remove it in the future, so its 
really not the right way to handle such requirements from the system.. I'll 
check if I can install grub2-tool as part of the host-deploy process. 
meanwhile, i abandon the change.
Line 12: 
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd


-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:

Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8: 
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
> host-deploy installs vdsm (and other ovirt related packages) on the host an
you can add this package to src/plugins/ovirt-host-deploy/kernel/kernel.py

That o-h-d module needs grubby, so it should include its dependent package in 
stage=plugin.Stages.STAGE_PACKAGES.

That is the puritan way.
Line 12: 
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd


-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/69462/2//COMMIT_MSG
Commit Message:

Line 7: Adding grub2-tool requirement which host-deploy requires
Line 8: 
Line 9: In some environments this package is not installed by default, and
Line 10: is needed to allow running:
Line 11: "/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.
> If host-deploy is using it, why it does not install the package?
host-deploy installs vdsm (and other ovirt related packages) on the host and 
assume the host is ready for the rest it does.. problem. its either do it in 
host-deploy using vdsm-tool which will lead us to require that or just require 
it and leave it as is. do you see another alternative?
Line 12: 
Line 13: Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd


-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding grub2-tool requirement which host-deploy requires
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Adding grub2-tool requirement which host-deploy requires

[Code Review]

From Yaniv Bronhaim :

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Adding grub2-tool requirement which host-deploy requires
..

Adding grub2-tool requirement which host-deploy requires

In some environments this package is not installed by default, and
is needed to allow running:
"/sbin/grubby --update-kernel DEFAULT" which host-deploy uses.

Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Signed-off-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/69462/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index c005191..b9e81f9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -89,6 +89,7 @@
 
 Requires: dbus-python
 Requires: ethtool
+Requires: grub2-tools
 Requires: which
 Requires: sudo >= 1.7.3
 Requires: logrotate


-- 
To view, visit https://gerrit.ovirt.org/69462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb3b3b525df25a1affc1583d573409cdb28b31bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org