Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6: Verified+1

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
I saw that and wondered, but without courage as alonbl has, I didn't want to 
touch yet.. maybe Zhou has an answer for that.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
there is none, please remove it.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
it looks quite intentional .. but if there is such reason, it should be claimed 
in how the separate patch that I'll submit.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Changing return method from vdsmd start function
..


Changing return method from vdsmd start function

Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/19884
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M init/sysvinit/vdsmd.init.in
1 file changed, 9 insertions(+), 13 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
the following two lists are equivalent (except for the return value on X 
failure)

  ( ! X ) || Y

  X  Y

but I was too lazy to comment on that to Zhou.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-10 Thread zhshzhou 
Zhou Zheng Sheng has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
I see. Thanks.

I use the form ! X || Y because I think if a service is not existing or is 
not running, the overall stop conflicting operation should be considered 
successful.

I just have a vague memory that I add those parentheses to make operator 
precedence explicit, but it proves the parentheses are redundant.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 4:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4788/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4864/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3979/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 4:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 70:elif [ -x /etc/init.d/${srv} ]; then
Line 71:(! service ${srv} status /dev/null 21) ||
Line 72:service ${srv} stop
Line 73:else
Line 74:continue
true?
Line 75:fi
Line 76: fi
Line 77: ret_val=$?
Line 78: if [ ${ret_val} -ne 0 ]; then


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 5:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4794/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4870/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3985/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4800/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4876/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3991/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
why subshell here?


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-09 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 6:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 67
Line 68
Line 69
Line 70
Line 71
Good question, but please fix in another patch.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-08 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 3:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4770/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4846/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3961/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-08 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 3:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 54: local ret_val
Line 55: local conflicting_services=$1
Line 56: 
Line 57: for srv in ${conflicting_services}; do
Line 58: [ -x /etc/inid.d/${srv} ]  continue
|| continue? but this should be only for sysv bellow...
Line 59: if [ $srv == libvirt-guests ]; then
Line 60:# `service libvirt-guests stop` tries to access libvirtd and
Line 61:# requires sasl authentication. Instead, removing the 
lockfile
Line 62:# signifies to libvirt-guests that it has stopped.


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-07 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4731/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4808/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3923/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-07 Thread Alon Bar-Lev 
Alon Bar-Lev has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 2:

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 73:fi
Line 74: fi
Line 75: ret_val=$?
Line 76: # Only if service exists and stop failed, fail the operation
Line 77: if which ${srv} /dev/null  [ ${ret_val} -ne 0 ]; then
which? I do not understand... first it should be [ -x ${srv} ] as you check 
for file existence at /etc/init.d/, second it should be tested before you 
attempt to even start or stop it.
Line 78: log_failure_msg ${prog}: Stop conflicting ${srv}
Line 79: return ${ret_val}
Line 80: fi
Line 81: done


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-06 Thread ybronhei 
Yaniv Bronhaim has uploaded a new change for review.

Change subject: Changing return method from vdsmd start function
..

Changing return method from vdsmd start function

Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M init/sysvinit/vdsmd.init.in
1 file changed, 6 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/19884/1

diff --git a/init/sysvinit/vdsmd.init.in b/init/sysvinit/vdsmd.init.in
index 2fd222d..5ccdc3d 100755
--- a/init/sysvinit/vdsmd.init.in
+++ b/init/sysvinit/vdsmd.init.in
@@ -120,28 +120,22 @@
 }
 
 start() {
-local ret_val
-
 test_already_running  return 0
 
 if [ ${is_coredump} = true ]; then
 export DAEMON_COREFILE_LIMIT=unlimited
 echo ${CORE_DUMP_PATH}  ${CORE_PATTERN}
 fi
-
-shutdown_conflicting_srv ${CONFLICTING_SERVICES}
-
-start_needed_srv ${NEEDED_SERVICES}
-
-${VDSMD_INIT_COMMON} --pre-start
+shutdown_conflicting_srv ${CONFLICTING_SERVICES} || return 1
+start_needed_srv ${NEEDED_SERVICES} || return 1
+${VDSMD_INIT_COMMON} --pre-start || return 1
 
 echo $Starting up vdsm daemon: 
 NICELEVEL=${NICE_LOWEST} daemon --user=vdsm @VDSMDIR@/daemonAdapter \
 -0 /dev/null -1 /dev/null -2 /dev/null --syslog @VDSMDIR@/respawn 
--minlifetime 10 \
---daemon --masterpid ${RESPAWNPIDFILE} ${VDSM_BIN} --pidfile 
${PIDFILE}
-RETVAL=$?
-[ $RETVAL = 0 ]  touch ${LOCK_FILE}
-return $RETVAL
+--daemon --masterpid ${RESPAWNPIDFILE} ${VDSM_BIN} --pidfile 
${PIDFILE} || return 1
+touch ${LOCK_FILE}
+return 0
 }
 
 stop() {


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-06 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4714/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4790/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3905/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Changing return method from vdsmd start function

2013-10-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Changing return method from vdsmd start function
..


Patch Set 1: Code-Review+1

(1 comment)


File init/sysvinit/vdsmd.init.in
Line 125: if [ ${is_coredump} = true ]; then
Line 126: export DAEMON_COREFILE_LIMIT=unlimited
Line 127: echo ${CORE_DUMP_PATH}  ${CORE_PATTERN}
Line 128: fi
Line 129: shutdown_conflicting_srv ${CONFLICTING_SERVICES} || return 1
good, there is a dormant bug in shutdown_conflicting_srv: if a conflicting 
service is missing completely, that function (and now start) would fail.

better fix it, too.
Line 130: start_needed_srv ${NEEDED_SERVICES} || return 1
Line 131: ${VDSMD_INIT_COMMON} --pre-start || return 1
Line 132: 
Line 133: echo $Starting up vdsm daemon: 


-- 
To view, visit http://gerrit.ovirt.org/19884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24985450addd3feb26687d42be741d9f357dc8c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches