Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: build net tests: Create a test target for networking tests.
..


build net tests: Create a test target for networking tests.

It is usefull to run only the networking test during development,
speeding the test run and allowing the developer to run them frequently
in a few seconds.

Before pushing changes, all tests should be run, including functional
ones.

Run example:
./autogen.sh --system && make pep8 pyflakes && make -C tests/ check-net

Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63649
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:

PS2, Line 9: networking
> Well, I prefer not to wait for all before moving forward, or at least I do 
OK. we agreed to have it done in separate patch.


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:

PS2, Line 9: networking
> Splitting the tests is required. Not sure whether we should with logical (g
Well, I prefer not to wait for all before moving forward, or at least I do not 
see the need to wait for other verticals.

We can just do it in steps, when all have their tests split we can go for the 
next level and generalize it a bit.
I do not see how we collide with any future change in this regard: I mean, we 
can easily change this to something else if there will be an agreement.


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:

PS2, Line 9: networking
> That would be great.
Splitting the tests is required. Not sure whether we should with logical (group 
of tests) or physical (move to folder). Once we have the groups we could use 
name of a group or folder to run check.


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-13 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:

PS2, Line 9: networking
> What do you think about providing generic mechanism for other verticals to 
That would be great.
Do you have a specific suggestion?

Splitting the tests into local variables and preparing for each its own target, 
is a good start.
Then we can continue and move each group to its folder (or just do it as part 
of the previous step).
Then we can move the test run to the individual folder, so each can hack it 
without affecting other verticals and eventually allowing splitting the 
vertical from the mother ship.


https://gerrit.ovirt.org/#/c/63649/2/tests/Makefile.am
File tests/Makefile.am:

Line 375:   @true
Line 376: 
Line 377: check-net:
Line 378:   @echo '*** Running networking tests. ***'
Line 379:   @$(top_srcdir)/tests/run_tests_local.sh $(args) 
$(network_modules)
> is it possible to run functional tests via run_tests_local?
No, and it does not belong in here.
Makefiles are for the building part which usually includes everything until 
installation, including tests that do not need the app running.
Line 380: 
Line 381: # crossImportsTests.py has to be run separate due to different tests 
which
Line 382: # load modules first, making the env dirty. Unloading python modules
Line 383: # is not supported, see http://bugs.python.org/issue9072 .


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-12 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG
Commit Message:

PS2, Line 9: networking
What do you think about providing generic mechanism for other verticals to use.


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-12 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Code-Review-1

(1 comment)

-1 for attention

https://gerrit.ovirt.org/#/c/63649/2/tests/Makefile.am
File tests/Makefile.am:

Line 375:   @true
Line 376: 
Line 377: check-net:
Line 378:   @echo '*** Running networking tests. ***'
Line 379:   @$(top_srcdir)/tests/run_tests_local.sh $(args) 
$(network_modules)
is it possible to run functional tests via run_tests_local?
Line 380: 
Line 381: # crossImportsTests.py has to be run separate due to different tests 
which
Line 382: # load modules first, making the env dirty. Unloading python modules
Line 383: # is not supported, see http://bugs.python.org/issue9072 .


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-11 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-11 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: build net tests: Create a test target for networking tests.
..

build net tests: Create a test target for networking tests.

It is usefull to run only the networking test during development,
speeding the test run and allowing the developer to run them frequently
in a few seconds.

Before pushing changes, all tests should be run, including functional
ones.

Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Signed-off-by: Edward Haas 
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/63649/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 2ff09a4..35c7b25 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -374,6 +374,10 @@
 check-recursive:
@true
 
+check-net:
+   @echo '*** Running networking tests. ***'
+   @$(top_srcdir)/tests/run_tests_local.sh $(args) $(network_modules)
+
 # crossImportsTests.py has to be run separate due to different tests which
 # load modules first, making the env dirty. Unloading python modules
 # is not supported, see http://bugs.python.org/issue9072 .


-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: build net tests: Create a test target for networking tests.

2016-09-11 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: build net tests: Create a test target for networking tests.
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org