Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-18 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3:

Francesco, Piotr, one on of you should approve this.

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-18 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: executor: Fix the task-callable mismtach
..


executor: Fix the task-callable mismtach

Executor is executing queue tasks, but the public api is dealing with
callable and timeout. These leak into the executor internals, and cause
confusion when we log the executor state.

Now we pack the callable and the timeout in a Task namedtuple, fixing
the mismatch, and providing more information when logging the task in
Worker.__repr__.

Task(callable=, timeout=7)

Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/50228
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/executor.py
1 file changed, 16 insertions(+), 13 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-18 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3: Code-Review+2

Raising score

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-17 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-17 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3:

Nobody wants to approve?

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-16 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3: Verified+1

Verified using the tests and manhole:

 Python 2.7.5 (default, Oct 11 2015, 17:47:16) 
 [GCC 4.8.3 20140911 (Red Hat 4.8.3-9)] on linux2
 Type "help", "copyright", "credits" or "license" for more information.
 (ManholeConsole)
 >>> from virt import periodic
 >>> import pprint
 >>> import time
 >>> while True:
 ...pprint.pprint(periodic._executor._workers)
 ...time.sleep(5)
 ... 
 set([,
 ,
 ,
 ])
 ...
 set([,
 , timeout=7.5) at 
0x7ff97c038f10>,
 ,
  at 
0x7ff97c041c50>, timeout=7.5) at 0x7ff97c041510>])

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-16 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-16 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-16 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-15 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 2: Code-Review+1

I had an (unpublished) patch almost identical to this, so of course I support 
this change

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-10 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-10 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50228/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-10 02:40:24 +0200
Line 4: Commit: Nir Soffer 
Line 5: CommitDate: 2015-12-10 02:40:24 +0200
Line 6: 
Line 7: executor: Rename self._callabale to self._task
> typo: should be "callable"
Thanks, fixed.
Line 8: 
Line 9: We are using this term in this module, so lets be consistent.
Line 10: 
Line 11: Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8


-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: executor: Fix the task-callable mismtach

2015-12-10 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: executor: Fix the task-callable mismtach
..


Patch Set 2: Verified+1

Piotr, I think this version addresses your concerns.

Verified by the tests (we have good coverage):

$ ./run_tests_local.sh executorTests.py --enable-slow-tests --cover-package 
vdsm --with-coverage 2>/dev/null | grep vdsm/executor
vdsm/executor.py   138  199%   213

-- 
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches