Change in vdsm[master]: hsm: check volume existence in prepareImage
Nir Soffer has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31937/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3217: :type sdUUID: UUID Line 3218: :param spUUID: The UUID of the storage pool that owns the volume. Line 3219: :type spUUID: UUID Line 3220: :param imgUUID: The UUID of the image contained on the volume. Line 3221: :type imgUUID: UUID For another patch: document the leafUUID parameter Line 3222: Line 3223: vars.task.getSharedLock(STORAGE, sdUUID) Line 3224: Line 3225: imgVolumesInfo = [] -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: check volume existence in prepareImage .. hsm: check volume existence in prepareImage This patch introduces a check in prepareImage to return a consistent error (VolumeDoesNotExist) when the volume to prepare is not found. Before this patch the error was: UnboundLocalError: local variable 'leafInfo' referenced before assignment Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133617 Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/31937 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Dan Kenigsberg has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5781/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/147/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3940/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1806/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Federico Simoncelli has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Allon Mureinik has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12187/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12034/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Dan Kenigsberg has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Allon Mureinik has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
Federico Simoncelli has uploaded a new change for review. Change subject: hsm: check volume existence in prepareImage .. hsm: check volume existence in prepareImage Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133617 Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/31937/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 6a53ca7..ab48be8 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -3227,6 +3227,10 @@ allVols = dom.getAllVolumes() # Filter volumes related to this image imgVolumes = sd.getVolsOfImage(allVols, imgUUID).keys() + +if leafUUID not in imgVolumes: +raise se.VolumeDoesNotExist(leafUUID) + imgPath = dom.activateVolumes(imgUUID, imgVolumes) if spUUID and spUUID != sd.BLANK_UUID: runImgPath = dom.linkBCImage(imgPath, imgUUID) -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: check volume existence in prepareImage
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: check volume existence in prepareImage .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11124/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12066/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11913/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
