Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/21789/26//COMMIT_MSG
Commit Message:
Line 39:
Line 40: Tested:
Line 41: * setup: Host RHEL 6.5 and Guest 6.5 qemu-guest-agent installed
Line 42: * able to hot add CPUs. Guest online them immediatly
Line 43: * unplug fails with Operation not supported: qemu didn't unplug the
vCPUs properly
Keep lines shorter, please.
Done
Line 44:
Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 46:vcpu set as the above mentioned.
Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
Line 42: * able to hot add CPUs. Guest online them immediatly
Line 43: * unplug fails with Operation not supported: qemu didn't unplug the
vCPUs properly
Line 44:
Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 46:vcpu set as the above mentioned.
is this line here in purpose ?
Done
Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
http://gerrit.ovirt.org/#/c/21789/26/vdsm/API.py
File vdsm/API.py:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
you can print:
Done
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
Line 466: 'parameters: vmId,
numberOfCpus'}}
Line 467: try:
Line 469: except KeyError:
Line 470: self.log.warning(vm %s doesn't exist, self._UUID)
Line 471: return errCode['noVM']
Line 472:
Line 473: return curVm.setNumberOfCpus(int(numberOfCpus))
if numberOfCpus is not valid integer you'll get here ValueError that you do
I think its very reasonable to let it blow in the face of a careless client.
Line 474:
Line 475: def migrate(self, params):
Line 476:
Line 477: Migrate a VM to a remote host.
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: * addressed comments * added an update to the vm container to reflect changes when migrating etc -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/243/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5813/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Michal Skrivanek has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has submitted this change and it was merged. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. set the # of vcpus for a VM (hot plug/unplug) Introducing new API for setting the number of cpus of a running VM. setNumOfCpus(vmId, number) http://www.ovirt.org/Hot_plug_cpu Prerequisite Vm must be Running state. libvirt xml: * To add cpus a VM must have the max number configured. * Both topology and vcpu elements must exist. snip from a domxml: vcpu current='3'160/vcpu cpu mode='custom' match='exact' topology sockets='160' cores='1' threads='1'/ /cpu this means there is a total of 160 cpus and the current num is 3 The underlying API being used is libvirt's setVCpus. The result of hot plug/unplug a cpu to a RHEL, for instance, is a new device under: /sys/devices/system/cpu/cpuX Notes: * guest OS support and behavior may(and probably will) vary on trying to to hot plug/unplug. * Upgrade: VMs that have been started on hosts before this patch can not plug more CPU than the number of CPUs they started up with. Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492 Signed-off-by: Roy Golan rgo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21789 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M debian/vdsm.dirs M lib/vdsm/define.py M tests/vmTests.py M tests/vmTestsData.py M vdsm.spec.in M vdsm/API.py M vdsm/BindingXMLRPC.py M vdsm/hooks.py M vdsm/vdsmd.8.in M vdsm/vm.py M vdsm_api/Bridge.py M vdsm_api/vdsmapi-schema.json M vdsm_hooks/Makefile.am 14 files changed, 119 insertions(+), 18 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Roy Golan: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 27: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/245/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 25: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 25: Verified+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 26: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6691/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6604/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5798/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/238/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26: Code-Review+1
(3 comments)
Commit Message
Line 42: * able to hot add CPUs. Guest online them immediatly
Line 43: * unplug fails with Operation not supported: qemu didn't unplug the
vCPUs properly
Line 44:
Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 46:vcpu set as the above mentioned.
is this line here in purpose ?
Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
File vdsm/API.py
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
you can print:
log.error('Missing one of required parameters: vmId (%s), numberOfCpus (%s)',
vmId, numberOfCpus)
it'll be easier to know which value is missing
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
Line 466: 'parameters: vmId,
numberOfCpus'}}
Line 467: try:
Line 469: except KeyError:
Line 470: self.log.warning(vm %s doesn't exist, self._UUID)
Line 471: return errCode['noVM']
Line 472:
Line 473: return curVm.setNumberOfCpus(int(numberOfCpus))
if numberOfCpus is not valid integer you'll get here ValueError that you don't
handle. I think its find, but just alerting..
Line 474:
Line 475: def migrate(self, params):
Line 476:
Line 477: Migrate a VM to a remote host.
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 26: (2 comments) Commit Message Line 39: Line 40: Tested: Line 41: * setup: Host RHEL 6.5 and Guest 6.5 qemu-guest-agent installed Line 42: * able to hot add CPUs. Guest online them immediatly Line 43: * unplug fails with Operation not supported: qemu didn't unplug the vCPUs properly Keep lines shorter, please. Line 44: Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Line 46:vcpu set as the above mentioned. Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492 Line 42: * able to hot add CPUs. Guest online them immediatly Line 43: * unplug fails with Operation not supported: qemu didn't unplug the vCPUs properly Line 44: Line 45: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Line 46:vcpu set as the above mentioned. Most probably not... Line 47: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 26: Verified-1 I think I missed updating the vmcontainer. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 25: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5797/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/236/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 895: self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 896: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 897: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
I would not obfuscate the code more. I'd leave this the way it was without
helper functions; and similarly for vcpus just use a variable vcpu holding the
number (and use again at line 1057) and call the xml snippet on the next line
vcpuelem instead (as is the convention elsewhere)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
Line 903:
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 19: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6656/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5763/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6569/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/220/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6657/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6570/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/221/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5766/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/222/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 20:
(5 comments)
File vdsm/vm.py
Line 896: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 897: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
Line 900: vcpu = self.dom.appendChildWithArgs(
nit: lines could be joined
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
Line 903:
Line 904: memSizeGuaranteedKB = str(1024 * int(
Line 898: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 899: smp = self._getSmp()
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self._getMaxVCpus())
Line 902: vcpu.setAttrs(**{'current': smp})
so now there's no real need of the smp variable.
Line 903:
Line 904: memSizeGuaranteedKB = str(1024 * int(
Line 905: self.conf.get('memGuaranteedSize', '0')
Line 906: ))
Line 1150: def toxml(self):
Line 1151: return self.doc.toprettyxml(encoding='utf-8')
Line 1152:
Line 1153: def _getSmp(self):
Line 1154: return self.conf.get('smp', 1)
make sure the type of the return value is int. Currently, _getMaxVCpus() can be
either int or str, which can get you into troubles.
Line 1155:
Line 1156: def _getMaxVCpus(self):
Line 1157: return self.conf.get('maxVCpus', self._getSmp())
Line 1158:
File vdsm_api/vdsmapi-schema.json
Line 2809: # @kvmEnable: Indicates if KVM hardware acceleration is
enabled
Line 2810: #
Line 2811: # @memSize: The amount of memory assigned to the VM in
MB
Line 2812: #
Line 2813: # @maxVCpus Maximum number of CPU available for the
guest
mark as #optional, keep in alphabetic order.
Line 2814: # It is the upper boundry for hot plug CPU
action
Line 2815: #
Line 2816: # @memGuaranteedSize: The amount of memory guaranteed to the VM
in MB
Line 2817: #
Line 2856: 'displayPort': 'int', 'displaySecurePort': 'int',
Line 2857: '*emulatedMachine': 'str', '*keyboardLayout': 'str',
Line 2858: 'kvmEnable': 'bool', 'memSize': 'uint',
'memGuaranteedSize': 'uint',
Line 2859: 'nicModel': 'str', 'nice': 'int', '*pauseCode': 'str',
Line 2860: 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
Add *maxVCpus to this dict, too.
Line 2861: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
Line 2862: 'timeOffset': 'uint', 'transparentHugePages': 'bool',
Line 2863: 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
Line 2864: '*exitCode': 'int', '*exitMessage': 'str'}}
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 23: Code-Review-1 please see my comments to ps20. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 22: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6660/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6573/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/223/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 23: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/224/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 23:
(1 comment)
(sorry)
File vdsm_api/vdsmapi-schema.json
Line 6726: #
Line 6727: # Returns:
Line 6728: # The VM definition, as updated
Line 6729: #
Line 6730: # Since: 4.14.0
as we've been too late for 4.14, this should be updated to 4.15.0
Line 6731: ##
Line 6732: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6733: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int'},
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 24: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/225/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 24: Code-Review-1 (1 comment) one last documentation nit, and we're good to go. File vdsm_api/vdsmapi-schema.json Line 2854: '*cpuType': 'str', '*custom': 'StringMap', '*devices': ['VmDevice'], Line 2855: 'display': 'VmDisplayType', 'displayIp': 'str', Line 2856: 'displayPort': 'int', 'displaySecurePort': 'int', Line 2857: '*emulatedMachine': 'str', '*keyboardLayout': 'str', Line 2858: 'kvmEnable': 'bool', '*maxVCpus': 'str', 'memSize': 'uint', it should be a 'uint' (even though it is encoded as a string due to xmlrpc limitations - much like smp. Line 2859: 'memGuaranteedSize': 'uint', 'nicModel': 'str', 'nice': 'int', Line 2860: '*pauseCode': 'str', 'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint', Line 2861: '*smpThreadsPerCore': 'uint', 'status': 'VmStatus', Line 2862: 'timeOffset': 'uint', 'transparentHugePages': 'bool', -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review-1
(14 comments)
Commit Message
Line 4: Commit: Roy Golan rgo...@redhat.com
Line 5: CommitDate: 2014-01-02 13:51:18 +0200
Line 6:
Line 7: set the # of vcpus for a VM (hot plug/unplug)
Line 8:
We have bug-url. This line is redundant.
This is a new important feature. It deserves a better explanation and reasoning.
Line 9: RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
Line 10:
Line 11: Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036492
File debian/vdsm.dirs
Line 51: usr/libexec/vdsm/hooks/before_vm_migrate_source
Line 52: usr/libexec/vdsm/hooks/before_vm_pause
Line 53: usr/libexec/vdsm/hooks/before_vm_set_ticket
Line 54: usr/libexec/vdsm/hooks/before_vm_start
Line 55: usr/libexec/vdsm/hooks/before_set_num_of_cpus
Keep sorted
Line 56: usr/libexec/vdsm/hooks/after_set_num_of_cpus
Line 57: var/lib/libvirt/qemu/channels
Line 58: var/lib/vdsm
Line 59: var/lib/vdsm/netconfback
File lib/vdsm/define.py
Line 131: 'message': 'Wrong resize disk parameter'}},
Line 132: 'transientErr': {'status': {
Line 133: 'code': 59,
Line 134: 'message': 'Action not permitted on a VM with transient
disks'}},
Line 135: 'setNumberOfCpus': {'status': {
All the error names end with err. Please conform.
Line 136: 'code': 60,
Line 137: 'message': 'Failed to set the number of cpus'}},
Line 138: 'recovery': {'status': {
Line 139: 'code': 99,
File tests/vmTests.py
Line 55: converted = element.toprettyxml()
Line 56: else:
Line 57: elem = ET.fromstring(element.toprettyxml())
Line 58: converted = re.sub(' /', '/',
Line 59:ET.tostring(elem.find(./%s % path)))
Unrelated, it seems.
Line 60: self.assertEqual(
Line 61: re.sub('\n\s*', ' ', converted).strip(' '),
Line 62: re.sub('\n\s*', ' ', expectedXML).strip(' '))
Line 63:
File tests/vmTestsData.py
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: CONF_TO_DOMXML = ({
Why was this changed? I'd like to see further elements added to this list.
Line 22: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 23: 'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512',
Line 24: 'displayPort': '-1', 'vmName': 'testVm',
Line 25: 'display': 'vnc', 'emulatedMachine': 'pc',
File vdsm/API.py
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
How can any of them be None? None cannot be transported over xmlrpc.
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
Line 464: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 465:'message': 'Missing one of required '
File vdsm/hooks.py
Line 297:
Line 298:
Line 299: def before_set_num_of_cpus(vmconf={}, params={}):
Line 300: return _runHooksDir(None, 'before_set_num_of_cpus', vmconf=vmconf,
Line 301: params=params, raiseError=False)
Before Hooke *should* raise errors.
Line 302:
Line 303:
Line 304: def after_set_num_of_cpus(vmconf={}, params={}):
Line 305: return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
File vdsm/vm.py
Line 77: RNG_DEVICES = 'rng'
Line 78: WATCHDOG_DEVICES = 'watchdog'
Line 79: CONSOLE_DEVICES = 'console'
Line 80: SMARTCARD_DEVICES = 'smartcard'
Line 81: CPU_DEVICES = 'cpu'
Is this ever used?
Line 82:
Line 83:
Line 84: def isVdsmImage(drive):
Line 85: return all(k in drive.keys() for k in ('volumeID', 'domainID',
'imageID',
Line 897: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 898: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 899: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', '160'))
Please define 160 as a CONSTANT. Is there any side effect of always using the
greatest maximum?
Line 902: # hotplug cpu requires a maximum number which is
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Francesco Romani has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Vinzenz Feenstra has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Francesco Romani has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 14: hook supported isn't verified -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 14: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/190/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/191/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6392/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 13: * reverted the use of EqualsMultiLine which doesn't exist in the 2.6 * following Edu's comments on buildCmdLine test case -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Francesco Romani has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 9: Looks good to me except for the failed test. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 10: * test wasn't fixed yet -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6447/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5554/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6360/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6457/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5564/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6370/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
just noticed a couple of minor things.
File tests/vmTests.py
Line 45: 'function': '0x0', 'type': 'pci'}
Line 46:
Line 47: def __init__(self, *args, **kwargs):
Line 48: TestCaseBase.__init__(self, *args, **kwargs)
Line 49: self.maxDiff = None
stray? seems unused.
Line 50: self.conf = {'vmName': 'testVm',
Line 51: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 52: 'smp': '8', 'memSize': '1024',
'memGuaranteedSize': '512'}
Line 53:
File vdsm/API.py
Line 455: return errCode['noVM']
Line 456:
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
`vmId` is consumed by the wrapping method in BindingXMLRPC so it seems useless
in this method
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
File tests/vmTests.py
Line 45: 'function': '0x0', 'type': 'pci'}
Line 46:
Line 47: def __init__(self, *args, **kwargs):
Line 48: TestCaseBase.__init__(self, *args, **kwargs)
Line 49: self.maxDiff = None
this is for the assertMultiLineEqual to show the full diff of xml incase there
is a mismatch
Line 50: self.conf = {'vmName': 'testVm',
Line 51: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 52: 'smp': '8', 'memSize': '1024',
'memGuaranteedSize': '512'}
Line 53:
File vdsm/API.py
Line 455: return errCode['noVM']
Line 456:
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
I use it only for input parameter validation here for this section is shared
with vdsClient.py and BinfingXMLRPC and potentially every other client.
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId,
numberOfCpus')
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 12: no change just a rebase. on my side all the tests run OK when I make rpm. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5581/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6387/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 9: it fails (FAIL: testCpuXML (vmTests.TestVm)). except that it looks quite complete to me -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: the libvirt xml is changed now to allow adding more cpus this means we have a topology element and a vcpu element to reflect the current placement of cpus vcpu placement='static' current='2'160/vcpu topology sockets='160' cores='1' threads='1'/ this means we currently use 2 VCPU and we can grow by hot adding up to 160 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6393/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5500/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6296/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified+1 Verified * the vm is up and running with 2 cpus * can call setVcpus Not verified * the libvirt call still says the domain couldn't hot add cpus probably an OS issue -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6397/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5504/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6300/ : UNSTABLE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6400/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5507/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6303/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Saggi Mizrahi has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 6: One of SaggiMizrahi's automated scripts discovered this patch might require his approval. Please wait until he had time to check it out. -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5062/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5938/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5050/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(5 comments)
File client/vdsClient.py
Line 245: params = {'vmId': args[0], 'drive': drive}
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def setNumberOfCpus(self, args):
Line 249: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
Done
Line 250:
Line 251: def do_changeCD(self, args):
Line 252: vmId = args[0]
Line 253: file = self._parseDriveSpec(args[1])
File vdsm/API.py
Line 456: def setNumberOfCpus(self, params):
Line 457: try:
Line 458: utils.validateMinimalKeySet(params, ('vmId',
'numberOfCpus'))
Line 459: except ValueError:
Line 460: self.log.error('Missing one of required parameters: vmId,
drive')
will the backtrace include the missing params? otherwise I don't see the real
value
Line 461: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 462:'message': 'Missing one of required '
Line 463: 'parameters: vmId,
numberOfCpus'}}
Line 464: try:
File vdsm/vm.py
Line 3309: if self.isMigrating():
Line 3310: return errCode['migInProgress']
Line 3311:
Line 3312: self.log.debug(Setting number of cpus to : %s %
Line 3313:params.get['numberOfCpus'])
Done
Line 3314:
Line 3315: try:
Line 3316: self._dom.setVcpu(params.get('numberOfCpus'))
Line 3317: except libvirt.libvirtError as e:
File vdsm_api/Bridge.py
Line 339: 'Volume_getInfo': {'ret': 'info'},
Line 340: 'Volume_getPath': {'ret': 'path'},
Line 341: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 342: 'Host_getAllTasks': {'ret': 'tasks'},
Line 343: 'VM_setNumberOfCpus': {'ret': 'vmList'},
Done
Line 344: }
Line 345:
Line 346:
Line 347: def fieldClone(oldName, newName, obj):
File vdsm_api/vdsmapi-schema.json
Line 6694: #
Line 6695: # Since: 4.10.0
Line 6696: ##
Line 6697: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6698: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int' },
Done
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 3: * addressed comments * rename the new vdsClient verb to plural: setNumberOfCpu - setNumberOfCpus -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4950/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5840/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4972/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5862/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 4: (1 comment) looks good to me. File client/vdsClient.py Line 2558: Line 2559: try: Line 2560: serv.do_connect(hostPort) Line 2561: try: Line 2562: commandArgs = args[2:] not related i guess.. Line 2563: except: Line 2564: commandArgs = [] Line 2565: code, message = commands[command][0](commandArgs) Line 2566: if code != 0: -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Roy Golan has uploaded a new change for review.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
RFE https://bugzilla.redhat.com/show_bug.cgi?id=833102
Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=833102
Signed-off-by: Roy Golan rgo...@redhat.com
---
M client/vdsClient.py
M lib/vdsm/define.py
M tests/vmTests.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/vm.py
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
8 files changed, 82 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/21789/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 67ce3b7..097e21f 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -245,6 +245,9 @@
params = {'vmId': args[0], 'drive': drive}
return self.ExecAndExit(self.s.hotunplugDisk(params))
+def setNumberOfCpus(self, args):
+return self.ExecAndExit(self.s.setNumberOfCpus(args[0], args[1]))
+
def do_changeCD(self, args):
vmId = args[0]
file = self._parseDriveSpec(args[1])
@@ -2511,6 +2514,11 @@
'vmId spUUID sdUUID imgUUID volUUID newSize',
'Extends the virtual size of a disk'
)),
+'setNumberOfCpu': (
+serv.setNumberOfCpus, (
+'vmId numberOfCpus',
+'set the number of cpus for a running VM'
+)),
}
if _glusterEnabled:
commands.update(ge.getGlusterCmdDict(serv))
@@ -2550,7 +2558,7 @@
try:
serv.do_connect(hostPort)
try:
-commandArgs = args[2:]
+commandArgs = args[2:]
except:
commandArgs = []
code, message = commands[command][0](commandArgs)
diff --git a/lib/vdsm/define.py b/lib/vdsm/define.py
index eb78633..389a5ba 100644
--- a/lib/vdsm/define.py
+++ b/lib/vdsm/define.py
@@ -132,6 +132,9 @@
'transientErr': {'status': {
'code': 59,
'message': 'Action not permitted on a VM with transient disks'}},
+'setNumberOfCpus': {'status': {
+'code': 60,
+'message': 'Failed to set the number of cpus'}},
'recovery': {'status': {
'code': 99,
'message': 'Recovering from crash or Initializing'}},
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 1f69f0a..8d5fbd3 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -67,7 +67,7 @@
uuid9ffe28b6-6134-4b1e-8804-1185f49c436f/uuid
memory1048576/memory
currentMemory1048576/currentMemory
- vcpu8/vcpu
+ vcpu placement=static current='8'160/vcpu
memtune
min_guarantee524288/min_guarantee
/memtune
diff --git a/vdsm/API.py b/vdsm/API.py
index 48eecc6..40d641c 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -453,6 +453,22 @@
return curVm.hotunplugDisk(params)
+def setNumberOfCpus(self, params):
+try:
+utils.validateMinimalKeySet(params, ('vmId', 'numberOfCpus'))
+except ValueError:
+self.log.error('Missing one of required parameters: vmId, drive')
+return {'status': {'code': errCode['MissParam']['status']['code'],
+ 'message': 'Missing one of required '
+ 'parameters: vmId, numberOfCpus'}}
+try:
+curVm = self._cif.vmContainer[self._UUID]
+except KeyError:
+self.log.warning(vm %s doesn't exist, self._UUID)
+return errCode['noVM']
+
+return curVm.setNumberOfCpus(params)
+
def migrate(self, params):
Migrate a VM to a remote host.
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 1602c5c..fc5d926 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -283,6 +283,10 @@
vm = API.VM(vmId)
return vm.vmUpdateDevice(params)
+def setNumberOfCpus(self, vmId, numberOfCpus):
+vm = API.VM(vmId)
+return vm.setNumberOfCpus(vmId, numberOfCpus)
+
def vmSnapshot(self, vmId, snapDrives, snapMemVolHandle=''):
Take snapshot of VM
@@ -867,7 +871,8 @@
(self.vmHotunplugDisk, 'hotunplugDisk'),
(self.vmHotplugNic, 'hotplugNic'),
(self.vmHotunplugNic, 'hotunplugNic'),
-(self.vmUpdateDevice, 'vmUpdateDevice'))
+(self.vmUpdateDevice, 'vmUpdateDevice'),
+(self.vmSetNumberOfCpus, 'setNumberOfCpus'))
def getIrsMethods(self):
return ((self.domainActivate, 'activateStorageDomain'),
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 10eb54b..a2aa92a 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -77,6 +77,7 @@
WATCHDOG_DEVICES = 'watchdog'
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4930/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5819/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4944/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5834/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Vinzenz Feenstra has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(2 comments)
File vdsm/vm.py
Line 3309: if self.isMigrating():
Line 3310: return errCode['migInProgress']
Line 3311:
Line 3312: self.log.debug(Setting number of cpus to : %s %
Line 3313:params.get['numberOfCpus'])
self.log.debug(Setting number of cpus to : %s, params.get['numberOfCpus'])
without the % - we let the logger decide to apply the formatting or not
(depends on the log level)
Line 3314:
Line 3315: try:
Line 3316: self._dom.setVcpu(params.get('numberOfCpus'))
Line 3317: except libvirt.libvirtError as e:
File vdsm_api/Bridge.py
Line 339: 'Volume_getInfo': {'ret': 'info'},
Line 340: 'Volume_getPath': {'ret': 'path'},
Line 341: 'Volume_getSize': {'ret': Volume_getsize_Ret},
Line 342: 'Host_getAllTasks': {'ret': 'tasks'},
Line 343: 'VM_setNumberOfCpus': {'ret': 'vmList'},
please put it in the VM_ section, the entries are sorted
Line 344: }
Line 345:
Line 346:
Line 347: def fieldClone(oldName, newName, obj):
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(3 comments)
File client/vdsClient.py
Line 245: params = {'vmId': args[0], 'drive': drive}
Line 246: return self.ExecAndExit(self.s.hotunplugDisk(params))
Line 247:
Line 248: def setNumberOfCpus(self, args):
Line 249: return self.ExecAndExit(self.s.setNumberOfCpus(args[0],
args[1]))
you can do just *args
Line 250:
Line 251: def do_changeCD(self, args):
Line 252: vmId = args[0]
Line 253: file = self._parseDriveSpec(args[1])
File vdsm/API.py
Line 456: def setNumberOfCpus(self, params):
Line 457: try:
Line 458: utils.validateMinimalKeySet(params, ('vmId',
'numberOfCpus'))
Line 459: except ValueError:
Line 460: self.log.error('Missing one of required parameters: vmId,
drive')
better to add backtrace print also.. no?
Line 461: return {'status': {'code':
errCode['MissParam']['status']['code'],
Line 462:'message': 'Missing one of required '
Line 463: 'parameters: vmId,
numberOfCpus'}}
Line 464: try:
File vdsm_api/vdsmapi-schema.json
Line 6694: #
Line 6695: # Since: 4.10.0
Line 6696: ##
Line 6697: {'command': {'class': 'VM', 'name': 'setNumberOfCpus'},
Line 6698: 'data': {'vmID': 'UUID', 'numberOfCpus': 'int' },
whitespace after 'init', I think it fails the validation of the scheme
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan rgo...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
