Change in vdsm[master]: static: move man under static
gerrit-hooks has posted comments on this change. Change subject: static: move man under static .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
Dan Kenigsberg has submitted this change and it was merged. Change subject: static: move man under static .. static: move man under static Part of the move of static files to new directory. The files are moved to corresponding *expected* path under static (static/usr/share/man/man8). Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Signed-off-by: Martin PolednikReviewed-on: https://gerrit.ovirt.org/62549 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M .gitignore M static/Makefile.am R static/usr/share/man/man8/vdsmd.8.in M vdsm/Makefile.am 4 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
Francesco Romani has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: Code-Review+2 same answer as per parent patch, no reason to hold +2 -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
Martin Polednik has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am File static/Makefile.am: PS5, Line 24: usr > same comment as parent patch about hardcoded paths. Same as parent patch, this is path within source tree, not the distribution target. PS5, Line 33: etc > hardcoding /etc is kinda fine, a lot of thing can broke otherwise, but stuf Ditto. PS5, Line 93: ./usr/lib/systemd > (yes, I noticed too late) Ditto. -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
Francesco Romani has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: Code-Review+1 (3 comments) https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am File static/Makefile.am: PS5, Line 24: usr same comment as parent patch about hardcoded paths. Not really sure this is relevant, but still this rings a bell PS5, Line 33: etc hardcoding /etc is kinda fine, a lot of thing can broke otherwise, but stuff under /usr has a greater degree of flexibility, thus seems worth a bit more discussion. PS5, Line 93: ./usr/lib/systemd (yes, I noticed too late) this seems kinda ok, because I think systemd is not that flexible. But still, under the same caregory of /usr paths (obviously) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
gerrit-hooks has posted comments on this change. Change subject: static: move man under static .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
Martin Polednik has posted comments on this change. Change subject: static: move man under static .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
gerrit-hooks has posted comments on this change. Change subject: static: move man under static .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: static: move man under static
gerrit-hooks has posted comments on this change. Change subject: static: move man under static .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: static: move man
Yaniv Bronhaim has posted comments on this change. Change subject: static: move man .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62549/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-08-18 15:36:21 +0200 Line 4: Commit: Martin PolednikLine 5: CommitDate: 2016-09-06 13:09:06 +0200 Line 6: Line 7: static: move man please give better description here :) and explain why do you do this move Line 8: Line 9: Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: static: move man
gerrit-hooks has posted comments on this change. Change subject: static: move man .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: static: move man
gerrit-hooks has posted comments on this change. Change subject: static: move man .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin PolednikGerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: static: move man
Martin Polednik has uploaded a new change for review. Change subject: static: move man .. static: move man Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Signed-off-by: Martin Polednik--- M static/Makefile.am R static/usr/share/man/man8/vdsmd.8.in M vdsm/Makefile.am 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/62549/1 diff --git a/static/Makefile.am b/static/Makefile.am index 5024d63..360ed54 100644 --- a/static/Makefile.am +++ b/static/Makefile.am @@ -20,6 +20,9 @@ include $(top_srcdir)/build-aux/Makefile.subs +man8_MANS = \ + ./usr/share/man/man8/vdsmd.8 + vdsm_DATA = \ ./usr/share/vdsm/bonding-defaults.json \ ./usr/share/vdsm/bonding-name2numeric.json \ @@ -98,6 +101,7 @@ $(sudoers_DATA) \ $(systemdunit_DATA) \ $(vdsmconf_DATA) \ + $(man8_MANS) \ $(NULL) EXTRA_DIST = \ @@ -116,4 +120,5 @@ ./usr/lib/systemd/system/supervdsmd.service.in \ ./usr/lib/systemd/system/vdsm-network.service.in \ ./usr/lib/systemd/system/vdsmd.service.in \ + ./usr/share/man/man8/vdsmd.8.in \ $(NULL) diff --git a/vdsm/vdsmd.8.in b/static/usr/share/man/man8/vdsmd.8.in similarity index 100% rename from vdsm/vdsmd.8.in rename to static/usr/share/man/man8/vdsmd.8.in diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index 734c900..9077ddc 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -54,9 +54,6 @@ vdsm-restore-net-config \ $(NULL) -nodist_man8_MANS = \ - vdsmd.8 - CLEANFILES = \ config.log \ $(nodist_vdsm_SCRIPTS) \ @@ -76,7 +73,6 @@ vdsm-libvirt-access.rules \ vdsm-logrotate \ vdsm-store-net-config.in \ - vdsmd.8.in \ $(NULL) all-local: \ -- To view, visit https://gerrit.ovirt.org/62549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org