Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 7: I would prefer that you didn't submit this (1 inline comment) Thanks Royce, but now that this flag is defined in libvirt, let us use it. File vdsm/libvirtvm.py Line 40: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm' Line 41: # This device name is used as default both in the qemu-guest-agent Line 42: # service/daemon and in libvirtd (to be used with the quiesce flag). Line 43: _QEMU_GA_DEVICE_NAME = 'org.qemu.guest_agent.0' Line 44: _TYPED_PARAM_STRING_OKAY = 4 why not use libvirt.VIR_TYPED_PARAM_STRING_OKAY instead? Line 45: Line 46: Line 47: class MERGESTATUS: Line 48: NOT_STARTED = Not Started -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 8: Looks good to me, approved thanks! -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has submitted this change and it was merged. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. using blockStatsFlags to collect disk latency instead of qemu cmd in libvirtvm.py using blockStatsFlags to collect disk latency instead of qemu cmd to avoid keyError and parse results our own Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Signed-off-by: Royce Lvlvro...@linux.vnet.ibm.com --- M vdsm.spec.in M vdsm/libvirtvm.py 2 files changed, 25 insertions(+), 73 deletions(-) Approvals: Royce Lv: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: (1 inline comment) File vdsm.spec.in Line 65: Requires: python = 2.7.3 Line 66: Requires: qemu-kvm = 2:0.15.0-4 Line 67: Requires: qemu-img = 2:0.15.0-4 Line 68: #readonly lease ignored by default on 0.9.11.4-3 Line 69: Requires: libvirt = 0.9.13-1 Igor, As this package is a rel one, I will bump the rhel version. I checked the community release for fc, 0.9.13 does not include patch: fix key error for qemuMonitorGetBlockStatsInfo as changelog mentioned, this patch is included in 0.10.0, so I'll use this version Line 70: Requires: libvirt-python, libvirt-lock-sanlock Line 71: Requires: iscsi-initiator-utils = 6.2.0.872-14 Line 72: Requires: device-mapper-multipath = 0.4.9-18 Line 73: Requires: e2fsprogs = 1.41.14 -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Igor Lvovsky has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) Thanks for the patch Royce. Just a minor comment File vdsm.spec.in Line 65: Requires: python = 2.7.3 Line 66: Requires: qemu-kvm = 2:0.15.0-4 Line 67: Requires: qemu-img = 2:0.15.0-4 Line 68: #readonly lease ignored by default on 0.9.11.4-3 Line 69: Requires: libvirt = 0.9.13-1 I think 0.9.13-3 is better. * Fri Jul 20 2012 Daniel Veillard veill...@redhat.com - libvirt-0.9.13-3.el6 - fix the package split to be similar to 6.3 one instead of upstream * Tue Jul 03 2012 Daniel Veillard veill...@redhat.com - libvirt-0.9.13-2.el6 - fix a package dependency problem making -1 uninstallable Line 70: Requires: libvirt-python, libvirt-lock-sanlock Line 71: Requires: iscsi-initiator-utils = 6.2.0.872-14 Line 72: Requires: device-mapper-multipath = 0.4.9-18 Line 73: Requires: e2fsprogs = 1.41.14 -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: I would prefer that you didn't submit this note: this would require some manual rebasing, now that libvirtvm conforms to pep8. -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
oVirt Jenkins CI Server has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: No score Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/196/ -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
oVirt Jenkins CI Server has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 6: Build Successful http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/196/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Royce Lv has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 4: Due to bug of libvirt, this patch will not be fully functional until my patch(http://www.redhat.com/archives/libvir-list/2012-June/msg00879.html) accepted by libvirt -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: using blockStatsFlags to collect disk latency instead of qem...
Dan Kenigsberg has posted comments on this change. Change subject: using blockStatsFlags to collect disk latency instead of qemu cmd .. Patch Set 4: I would prefer that you didn't submit this (2 inline comments) thank you very much for this patch, and the libvirt work (I saw that Osier invited you to go a level lower and send a qemu patch)! you would also have to require a newer libvirt version in the spec file, once it is ready. File vdsm/libvirtvm.py Line 131: diskLatency[vmDrive.name] = self._vm._dom.blockStatsFlags(vmDrive.name, flags=4) please keep lines shorter, and use well-named CONSTANTS instead of magical numbers like 4. Line 132: self._log.info(Disk latency available:%s, diskLatency[vmDrive.name]) no need to log the positive flow. it would fill up our logs too quickly. (I think that logging the negative flow here was not very helpful, too) -- To view, visit http://gerrit.ovirt.org/4304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie x...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
