Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Hardware information about POWER hosts .. vdsm: Hardware information about POWER hosts This introduces information about the hardware of IBM POWER hosts. In these machines the dmidecode cannot be used. This patch also creates a module used by functions that need to retrieve information about PPC64 hosts. It includes a function to get hardware platform information about the host. Change-Id: Ice513b9386273a44146852944741578023c1e17a Signed-off-by: Vitor de Lima vitor.l...@eldorado.org.br Reviewed-on: http://gerrit.ovirt.org/19395 Reviewed-by: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Tested-by: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M AUTHORS M debian/vdsm.install M vdsm.spec.in M vdsm/Makefile.am A vdsm/ppc64HardwareInfo.py M vdsm/supervdsmServer 6 files changed, 59 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Zhou Zheng Sheng: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/122/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 8: Verified+1 Code-Review+1 Test build on Ubuntu. It seems the Jenkins RPM failure is not related to this patch. It's because the dependency packages (glusterfs) are not ready in the Jenkins slave. http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/90/label=fedora19/console -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 8: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5929/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5133/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/90/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6021/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Vitor de Lima has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 7: (1 comment) File configure.ac Line 43: AC_PROG_CC Line 44: AC_PROG_LN_S Line 45: AM_PATH_PYTHON([2.6]) Line 46: Line 47: AC_CANONICAL_HOST Done Line 48: Line 49: AM_CONDITIONAL(ARCH_PPC64, test x$host_cpu = xpowerpc64) Line 50: Line 51: AC_ARG_ENABLE( -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 4:
(3 comments)
Fixed packaging issues.
File vdsm.spec.in
Line 1055: %{python_sitearch}/%{vdsm_name}/define.py*
Line 1056: %{python_sitearch}/%{vdsm_name}/exception.py*
Line 1057: %{python_sitearch}/%{vdsm_name}/ipwrapper.py*
Line 1058: %{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
Line 1059: %{python_sitearch}/%{vdsm_name}/netinfo.py*
Done
Line 1060:
Line 1061: %{python_sitearch}/%{vdsm_name}/qemuImg.py*
Line 1062: %{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
Line 1063: %{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
File vdsm/Makefile.am
Line 31:clientIF.py \
Line 32:configNetwork.py \
Line 33:debugPluginClient.py \
Line 34:dmidecodeUtil.py \
Line 35:ppc64HardwareInfo.py \
Done
Line 36:guestIF.py \
Line 37:hooking.py \
Line 38:hooks.py \
Line 39:kaxmlrpclib.py \
Line 31:clientIF.py \
Line 32:configNetwork.py \
Line 33:debugPluginClient.py \
Line 34:dmidecodeUtil.py \
Line 35:ppc64HardwareInfo.py \
Done
Line 36:guestIF.py \
Line 37:hooking.py \
Line 38:hooks.py \
Line 39:kaxmlrpclib.py \
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5917/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5121/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/83/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6009/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5920/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5124/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/85/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6012/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 6: Code-Review-1 (3 comments) Do not misunderstand me - I'd really like to take ppc64 support in, but it's important (to me at least) that I understand it. File build-aux/config.sub Line 1: #! /bin/sh Line 2: # Configuration validation subroutine script. Line 3: # Copyright 1992-2013 Free Software Foundation, Inc. Why do we suddenly need this file? I'd love to see a word about it in the commit message. Since it has a different author, it may well merit a separate patch altogether. Line 4: Line 5: timestamp='2013-04-24' Line 6: Line 7: # This file is free software; you can redistribute it and/or modify it File debian/vdsm.install Line 131: ./usr/share/vdsm/vdsm-store-net-config Line 132: ./usr/share/vdsm/vdsmDebugPlugin.py Line 133: ./usr/share/vdsm/vdsmapi-schema.json Line 134: ./usr/share/vdsm/vm.py Line 135: #TODO: add ppc64HardwareInfo.py for ppc64 If this is still a TODO, why have you added the big config.guess and config.sub files? Line 136: ./usr/share/vdsm/vmChannels.py File vdsm/Makefile.am Line 57: if ARCH_PPC64 Line 58: dist_vdsm_PYTHON += ppc64HardwareInfo.py Line 59: endif Line 60: Line 61: dist_vdsm_PYTHON += $(NULL) NULL is a textual hack, to let us keep a backslash on the last element on the list. It has no functionality as used here, please move it back to right after vm.py. Line 62: Line 63: dist_vdsmexec_SCRIPTS = \ Line 64:ovirt_functions.sh Line 65: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Vitor de Lima has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 6: (2 comments) File build-aux/config.sub Line 1: #! /bin/sh Line 2: # Configuration validation subroutine script. Line 3: # Copyright 1992-2013 Free Software Foundation, Inc. The automatic script that builds and installs RPMs required these two files because of the AC_CANONICAL_HOST in the configure.ac file. The strange thing is that they weren't needed in my Fedora 19 setup. Should these files be redistributed with the VDSM source code? The autogen.sh script populates the source tree with these files in my machines. Line 4: Line 5: timestamp='2013-04-24' Line 6: Line 7: # This file is free software; you can redistribute it and/or modify it File debian/vdsm.install Line 131: ./usr/share/vdsm/vdsm-store-net-config Line 132: ./usr/share/vdsm/vdsmDebugPlugin.py Line 133: ./usr/share/vdsm/vdsmapi-schema.json Line 134: ./usr/share/vdsm/vm.py Line 135: #TODO: add ppc64HardwareInfo.py for ppc64 I have no idea how to include this file in the debian package only when building for ppc64 hosts. If someone can point out how to do this, I will be thankful. Line 136: ./usr/share/vdsm/vmChannels.py -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5921/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5125/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/86/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6013/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 6: (2 comments) File build-aux/config.sub Line 1: #! /bin/sh Line 2: # Configuration validation subroutine script. Line 3: # Copyright 1992-2013 Free Software Foundation, Inc. Letting autogen generate them seems logical. But please verify that your parch works on f19 f20 and el6. Line 4: Line 5: timestamp='2013-04-24' Line 6: Line 7: # This file is free software; you can redistribute it and/or modify it File debian/vdsm.install Line 131: ./usr/share/vdsm/vdsm-store-net-config Line 132: ./usr/share/vdsm/vdsmDebugPlugin.py Line 133: ./usr/share/vdsm/vdsmapi-schema.json Line 134: ./usr/share/vdsm/vm.py Line 135: #TODO: add ppc64HardwareInfo.py for ppc64 Please contact Zhou Zheng Sheng on the vdsm-devel list. We can keep this as a TODO for Line 136: ./usr/share/vdsm/vmChannels.py -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 7: Code-Review-1 (1 comment) File configure.ac Line 43: AC_PROG_CC Line 44: AC_PROG_LN_S Line 45: AM_PATH_PYTHON([2.6]) Line 46: Line 47: AC_CANONICAL_HOST As it stands, this causes build failure, unless you run autoreconf to create .guess and .sub files. Please get the architecture detection and condtioning sorted in another patch. On the mean while, you may ship the ppc code on all architectures. Line 48: Line 49: AM_CONDITIONAL(ARCH_PPC64, test x$host_cpu = xpowerpc64) Line 50: Line 51: AC_ARG_ENABLE( -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 7: Code-Review-1 (1 comment) File vdsm/Makefile.am Line 55:vm.py \ Line 56:$(NULL) Line 57: Line 58: if ARCH_PPC64 Line 59: dist_vdsm_PYTHON += ppc64HardwareInfo.py Usually Python code is portable. In supervdsm server, it also detects the architecture and imports the respective hardware info modules. I think ppc64HardwareInfo.py can be shipped in VDSM regardless the targeted architecture, so as to make the packaging scripts simpler, and you can just add ppc64HardwareInfo.py to vdsm.install. Line 60: endif Line 61: Line 62: dist_vdsmexec_SCRIPTS = \ Line 63:ovirt_functions.sh -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 4: Verified-1 Code-Review-1 (1 comment) fails to build rpm on x86_64 File vdsm/Makefile.am Line 31:clientIF.py \ Line 32:configNetwork.py \ Line 33:debugPluginClient.py \ Line 34:dmidecodeUtil.py \ Line 35:ppc64HardwareInfo.py \ Worse issue: according to vdsm.spec.in, this should not be installed on x86_64 hosts - but currently it does. Line 36:guestIF.py \ Line 37:hooking.py \ Line 38:hooks.py \ Line 39:kaxmlrpclib.py \ -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 4: Code-Review+1
(2 comments)
Minor nits remain. Please add yourself as an AUTHOR, too.
File vdsm.spec.in
Line 1055: %{python_sitearch}/%{vdsm_name}/define.py*
Line 1056: %{python_sitearch}/%{vdsm_name}/exception.py*
Line 1057: %{python_sitearch}/%{vdsm_name}/ipwrapper.py*
Line 1058: %{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
Line 1059: %{python_sitearch}/%{vdsm_name}/netinfo.py*
Intentional?
Line 1060:
Line 1061: %{python_sitearch}/%{vdsm_name}/qemuImg.py*
Line 1062: %{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
Line 1063: %{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
File vdsm/Makefile.am
Line 31:clientIF.py \
Line 32:configNetwork.py \
Line 33:debugPluginClient.py \
Line 34:dmidecodeUtil.py \
Line 35:ppc64HardwareInfo.py \
Please keep sorted.
Line 36:guestIF.py \
Line 37:hooking.py \
Line 38:hooks.py \
Line 39:kaxmlrpclib.py \
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5817/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5909/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5021/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils Yaniv, the last thing I want is third parties starting to use lib/vdsm, forcing us to maintain our imperfect APIs. My mantra is: keep private what you do not have to expose. Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils third-party will use it if we'll make it a separate package, but locate it under /lib/vdsm doesn't mean we expose it. what's the different between this and netinfo.py ? Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils why ? its a utility\package that unrelated to vdsm and might be used as external python package in the future. vdsm just uses it, exactly like dmidecode_util . I prefer all of those move to lib/vdsm, as ipwrapper, netinfo, libvirtconnection ... don't you agree? Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: (1 comment) File lib/vdsm/ppc64HardwareInfo.py Line 15: # Line 16: # Refer to the README and COPYING files for full details of the license Line 17: # Line 18: Line 19: from vdsm import utils For packaging sake and time to release I agree with Yaniv. But as how it should be, I would very much prefer to have this code in a python library in pypi that is packaged in Fedora/EPEL and we just import (like the ipwrapper, and the lower level bits of netinfo). Line 20: Line 21: import os Line 22: Line 23: -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: just a suggestion: to have unique uuid for the host during deploy process, i recommend to modify also lib/vdsm/utils.py:getHostUUID that uses dmidecode command explicitly -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 3: Code-Review-1
(3 comments)
Thanks!
File lib/vdsm/ppc64HardwareInfo.py
Line 15: #
Line 16: # Refer to the README and COPYING files for full details of the license
Line 17: #
Line 18:
Line 19: from vdsm import utils
exposing another module in lib/vdsm is a liability we'd rather avoid. I do not
see a reason not to keep this module under /usr/share/vdsm/, just like caps.py.
Line 20:
Line 21: import os
Line 22:
Line 23:
File vdsm.spec.in
Line 1039: %{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
Line 1040: %{python_sitearch}/%{vdsm_name}/netinfo.py*
Line 1041:
Line 1042: %ifarch ppc64
Line 1043: %{python_sitearch}/%{vdsm_name}/ppc64HardwareInfo.py*
please add this new file to the debian package. At least as a
#TODO: add ppc64HardwareInfo.py for ppc64
Line 1044: %endif
Line 1045:
Line 1046: %{python_sitearch}/%{vdsm_name}/qemuImg.py*
Line 1047: %{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
File vdsm/supervdsmServer
Line 117: def getHardwareInfo(self, *args, **kwargs):
Line 118: if platform.machine() in ('x86_64', 'i686'):
Line 119: from dmidecodeUtil import getHardwareInfoStructure
Line 120: return getHardwareInfoStructure()
Line 121: elif platform.machine() in ('ppc64'):
this condition would evaluate to True even for platform.machine() == 'p'.
I do not suppose this is going to happen, but this is a bad practice. Please
have add a coma
elif platform.machine() in ('ppc64', ):
or move to
elif platform.machine() == 'ppc64'
Line 122: from vdsm.ppc64HardwareInfo import
getHardwareInfoStructure
Line 123: return getHardwareInfoStructure()
Line 124: else:
Line 125: # not implemented over other architecture
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Vitor de Lima has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4536/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5414/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 2: Code-Review-1
(1 comment)
just comment for arrangement .. you removed this code from later patch, so
clean it from the core
File lib/vdsm/ppc64HardwareInfo.py
Line 50:
Line 51: return infoStructure
Line 52:
Line 53:
Line 54: @utils.memoized
remove this getCpuModel from here if its not in use
Line 55: def getCpuModel():
Line 56: for line in file('/proc/cpuinfo'):
Line 57: if line.strip() == '':
Line 58: continue
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Code-Review+1 Sorry misclick -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5037/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5111/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 821: %{_datadir}/%{vdsm_name}/caps.py*
Line 822: %{_datadir}/%{vdsm_name}/clientIF.py*
Line 823: %{_datadir}/%{vdsm_name}/daemonAdapter
Line 824: %{_datadir}/%{vdsm_name}/dmidecodeUtil.py*
Line 825: %{_datadir}/%{vdsm_name}/ppc64HardwareInfo.py*
I think this should only be packed for the appropriate arch.
Line 826: %{_datadir}/%{vdsm_name}/API.py*
Line 827: %{_datadir}/%{vdsm_name}/hooking.py*
Line 828: %{_datadir}/%{vdsm_name}/hooks.py*
Line 829: %{_datadir}/%{vdsm_name}/lsblk.py*
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 1:
(3 comments)
File vdsm/ppc64HardwareInfo.py
Line 19: from vdsm import utils
Line 20:
Line 21: import os
Line 22:
Line 23:
you can locate this file under lib/vdsm - I know dmidecode.py is under
vdsm/vdsm too, and I'll move
Line 24: @utils.memoized
Line 25: def getHardwareInfoStructure():
Line 26: infoStructure = {'systemProductName': 'unavailable',
Line 27: 'systemSerialNumber': 'unavailable',
File vdsm/supervdsmServer
Line 117: def getHardwareInfo(self, *args, **kwargs):
Line 118: if platform.machine() in ('x86_64', 'i686'):
Line 119: from dmidecodeUtil import getHardwareInfoStructure
Line 120: return getHardwareInfoStructure()
Line 121: elif platform.machine() == 'ppc64':
I prefer platform.machine() in ('ppc64'):
not a must, but maybe we'll use more options here to specify ppc64 archs
Line 122: from ppc64HardwareInfo import getHardwareInfoStructure
Line 123: return getHardwareInfoStructure()
Line 124: else:
Line 125: # not implemented over other architecture
Line 119: from dmidecodeUtil import getHardwareInfoStructure
Line 120: return getHardwareInfoStructure()
Line 121: elif platform.machine() == 'ppc64':
Line 122: from ppc64HardwareInfo import getHardwareInfoStructure
Line 123: return getHardwareInfoStructure()
just a thinking, we can have an interface for hardwareInfo classes
Line 124: else:
Line 125: # not implemented over other architecture
Line 126: return {}
Line 127:
--
To view, visit http://gerrit.ovirt.org/19395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4441/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3625/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice513b9386273a44146852944741578023c1e17a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Vitor de Lima has abandoned this change. Change subject: vdsm: Hardware information about POWER hosts .. Abandoned I had a problem and forgot to keep the change id for a new patch set of this change. The new version is in change #19395. -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3611/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 2: Code-Review-1
(1 comment)
File vdsm/supervdsmServer
Line 101: KB = 2 ** 10
Line 102: TEST_BUFF_LEN = 4 * KB
Line 103:
Line 104:
Line 105: def getHardwareInfoStructurePPC64():
Here is not the location for specific implementation, as we don't put the
dmidecodeUtil code and other api logic in this file. This file is dedicated
only to declare supervdsm api and startup logic, please move it to external
package.
I prefer adding it to dmidecodeUtil.py and change the name to hardwareInfoUtil
or something in that direction
Line 106: infoStructure = {'systemProductName': 'unavailable',
Line 107: 'systemSerialNumber': 'unavailable',
Line 108: 'systemFamily': 'unavailable',
Line 109: 'systemVersion': 'unavailable',
--
To view, visit http://gerrit.ovirt.org/17417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4227/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4148/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 2: Code-Review+1 Looks OK for me... but I am not familiar with vdsm logics. -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Hardware information about POWER hosts
Alon Bar-Lev has posted comments on this change. Change subject: vdsm: Hardware information about POWER hosts .. Patch Set 1: It looks ok, although I have no ability to review vdsm... -- To view, visit http://gerrit.ovirt.org/17417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec8c92dbca5837aacd299555d34d97931d7a1f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
