Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
automat...@ovirt.org has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/19389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Jenkins CI RO has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 14: Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/19389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Jenkins CI RO has abandoned this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/19389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 14: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10210/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1259/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/107/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/138/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/117/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11152/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 13: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10208/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1258/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11150/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 12: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10093/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10878/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1203/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11035/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 12: consider this as a draft for async call, currently missing specfiles -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 11: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9961/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/819/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10116/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5043/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3200/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1241/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Michal Skrivanek has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 11: Code-Review-1 the actual hibernate call needs to be async -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 10: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9942/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/815/ : The patch does not pass the virt functional tests http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10097/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5024/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3181/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1233/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9156/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1494/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9941/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/814/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10096/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5023/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3180/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage-functional-tests-localfs_gerrit/1232/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Itamar Heim has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 8: ping -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2304: def pmWakeup(self):
Line 2305: self.log.debug('pmWakeup Called')
Line 2306: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf)
Line 2307: try:
Line 2308: self._dom.pMWakeup()
> libvirt.virDomain has pMWakeup(self, flags) atleast in my version, could yo
yep pMWakeup is correct. Strange naming, but however. problem solved :)
Line 2309: except:
Line 2310: self.log.error("pmWakeup failed", exc_info=True)
Line 2311: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2312: 'message': 'Failed to wake up VM.'}}
Line 2339: self.log.error("pmSuspend failed", exc_info=True)
Line 2340: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2341: 'message': 'Failed to suspend VM.'}}
Line 2342: else:
Line 2343: # We have to treat hybrid as standard S3
> false, the comment is only to reflect that if hybrid was called, we treat i
OK, fine for me. Maybe then it is a bit clearer if you move the comment down a
line so it is near to the if () below.
Line 2344: self.log.debug('pmSuspend succeeded')
Line 2345: if target in ('mem', 'hybrid'):
Line 2346: self.lastStatus = 'Paused'
Line 2347: self.conf['pauseCode'] = targets[target]['reason']
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2304: def pmWakeup(self):
Line 2305: self.log.debug('pmWakeup Called')
Line 2306: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf)
Line 2307: try:
Line 2308: self._dom.pMWakeup()
> This looks suspicious. AFAIK is PMWakeup(); however below you use pmWakeup(
libvirt.virDomain has pMWakeup(self, flags) atleast in my version, could you
verify that this is wrong? pmWakeup() is to reflect the name of function we use
in order to keep conventions (imho pmWakeup is correct)
Line 2309: except:
Line 2310: self.log.error("pmWakeup failed", exc_info=True)
Line 2311: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2312: 'message': 'Failed to wake up VM.'}}
Line 2339: self.log.error("pmSuspend failed", exc_info=True)
Line 2340: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2341: 'message': 'Failed to suspend VM.'}}
Line 2342: else:
Line 2343: # We have to treat hybrid as standard S3
> So it is impossible we get here if target is S4?
false, the comment is only to reflect that if hybrid was called, we treat it
the same way as suspend (it's a bit tricky as hybrid should never fallback to
hibernate in virtual environment)
Line 2344: self.log.debug('pmSuspend succeeded')
Line 2345: if target in ('mem', 'hybrid'):
Line 2346: self.lastStatus = 'Paused'
Line 2347: self.conf['pauseCode'] = targets[target]['reason']
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/API.py
File vdsm/API.py:
Line 379: def hibernate(self, target):
Line 380: """
Line 381: Hibernate a VM.
Line 382:
Line 383: :param mode: mem/disk/hybrid/hiberVolHandle
typo: target, not mode (either fix the docstring or the parameter naming)
Line 384: """
Line 385: if target in ('disk', 'mem', 'hybrid'):
Line 386: try:
Line 387: v = self._cif.vmContainer[self._UUID]
http://gerrit.ovirt.org/#/c/19389/8/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 5970: #
Line 5971: # Since: 4.12.0
Line 5972: ##
Line 5973: {'command': {'class': 'VM', 'name': 'hibernate'},
Line 5974: 'data': {'vmID': 'UUID', 'target': 'hibernationTarget'}}
Maybe I miss something, but this doesn't look backward compatible.
Line 5975:
Line 5976: ##
Line 5977: # @vmUpdateDeviceParams:
Line 5978: #
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Francesco Romani has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8: Code-Review-1
(10 comments)
Mostly minor things and a few questions
http://gerrit.ovirt.org/#/c/19389/8/client/vdsClient.py
File client/vdsClient.py:
Line 2461:'channel'
Line 2462:)),
Line 2463: 'wakeup': (serv.wakeup,
Line 2464:('',
Line 2465: 'Wakes up the desktop'
I guess 'desktop' here is for consistency with the hibernate verb below, right?
Unrelated to this patch: I think we should change the naming.
Line 2466: )),
Line 2467: 'hibernate': (serv.hibernate,
Line 2468: (' ',
Line 2469:'Hibernates the desktop'
http://gerrit.ovirt.org/#/c/19389/8/tests/functional/utils.py
File tests/functional/utils.py:
Line 226:
Line 227: def getVmList(self, vmId):
Line 228: result = self.vdscli.list('true', [vmId])
Line 229: return result['status']['code'], result['status']['message'],\
Line 230: result['vmList'][0]
Why do we need this? looks like a clone of the method above...
http://gerrit.ovirt.org/#/c/19389/8/vdsm/API.py
File vdsm/API.py:
Line 387: v = self._cif.vmContainer[self._UUID]
Line 388: response = v.pmSuspend(target)
Line 389: except KeyError:
Line 390: return errCode['noVM']
Line 391: else:
I'd like to see an explicit check for 'hiberVolHandle' here, just to be safe.
Line 392: params = {'vmId': self._UUID, 'mode': 'file',
Line 393: 'hiberVolHandle': target}
Line 394:
Line 395: response = self.migrate(params)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2302: return errCode['noVM']
Line 2303:
Line 2304: def pmWakeup(self):
Line 2305: self.log.debug('pmWakeup Called')
Line 2306: hooks.after_vm_dehibernate(self._dom.XMLDesc(0), self.conf)
Is this right? after_vm_dehibernate *before* wakeup?
If so please add one-line comment to reduce/avoid future confusion.
Line 2307: try:
Line 2308: self._dom.pMWakeup()
Line 2309: except:
Line 2310: self.log.error("pmWakeup failed", exc_info=True)
Line 2308: pMWakeup
This looks suspicious. AFAIK is PMWakeup(); however below you use pmWakeup().
Line 2311: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2312: 'message': 'Failed to wake up VM.'}}
Line 2313: else:
Line 2314: self.log.debug('pmWakeup successful')
Line 2315: self.lastStatus = 'Up'
this needs rebase.
self.lastStatus = vmstatus.UP
Line 2316: hooks.before_vm_dehibernate(self._dom.XMLDesc(0),
self.conf)
Line 2317:
Line 2318: return {'status': {'code': doneCode['code'],
Line 2319: 'message': 'Machine woken up'}}
Line 2339: self.log.error("pmSuspend failed", exc_info=True)
Line 2340: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2341: 'message': 'Failed to suspend VM.'}}
Line 2342: else:
Line 2343: # We have to treat hybrid as standard S3
So it is impossible we get here if target is S4?
Line 2344: self.log.debug('pmSuspend succeeded')
Line 2345: if target in ('mem', 'hybrid'):
Line 2346: self.lastStatus = 'Paused'
Line 2347: self.conf['pauseCode'] = targets[target]['reason']
Line 2342: else:
Line 2343: # We have to treat hybrid as standard S3
Line 2344: self.log.debug('pmSuspend succeeded')
Line 2345: if target in ('mem', 'hybrid'):
Line 2346: self.lastStatus = 'Paused'
same here for vmstatus
Line 2347: self.conf['pauseCode'] = targets[target]['reason']
Line 2348: else:
Line 2349: self.setDownStatus(NORMAL, targets[target]['reason'])
Line 2350: hooks.after_vm_hibernate(self._dom.XMLDesc(0), self.conf,
http://gerrit.ovirt.org/#/c/19389/8/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi-schema.json:
Line 5924: # Wake up suspended VM
Line 5925: #
Line 5926: # @vmID: The UUID of the VM
Line 5927: #
Line 5928: # Since: 4.10.0
4.15.0 I guess
Line 5929: ##
Line 5930: {'command': {'class': 'VM', 'name': 'wakeup'},
Line 5931: 'data': {'vmID': 'UUID'}}
Line 5932:
Line 5967: # @vmID: The UUID of the VM
Line 5968: #
Line 5969: # @target:Target suspension mode
Line 5970: #
Line 5971: # Since: 4.12.0
same here
Line 5972: ##
Line 5973: {'command': {'class': 'VM', 'name': 'hibernate'},
Line 5974: 'data': {'vmID': 'UUID', 'target': 'hibernationTarget'}}
Line 5975:
--
To view, v
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/7050/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7952/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1219/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 7: Verified+1 Jenkins messages seem unrelated; tested by functional test and on oVirt setup with GA installed. -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/135/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/74/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7053/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 6: considered as a code preview, still needs functional tests added -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6208/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7098/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_localfs/123/ : FAILURE http://jenkins.ovirt.org/job/vdsm_storage_functional_tests_nfs/62/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/6987/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line 357: stats = v.getStats().copy()
Line 358: stats['vmId'] = self._UUID
Line 359: return {'status': doneCode, 'statsList': [stats]}
Line 360:
Line 361: def wakeup(self):
> I've spoken to Michal about this: adding new state is not desired, therefor
"Paused" with additional reason (which we have) should be fine.
Line 362: try:
Line 363: v = self._cif.vmContainer[self._UUID]
Line 364: response = v.pmWakeup()
Line 365: except KeyError:
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line 357: stats = v.getStats().copy()
Line 358: stats['vmId'] = self._UUID
Line 359: return {'status': doneCode, 'statsList': [stats]}
Line 360:
Line 361: def wakeup(self):
> From the point of view of VDSM the VM will be still running (qemu process).
I've spoken to Michal about this: adding new state is not desired, therefore
I'm left to work the state 'paused'.
Discovery should be based on whether the engine currently handles state such as
hibernation on its side or relies on VDSM: if it's on engine side, we only need
to change the state internally based on response of API calls.
If we depend solely on what VDSM reports, I propose adding states 'S3' and 'S4'
and I'd look into mechanism of discovering these on recovery.
Line 362: try:
Line 363: v = self._cif.vmContainer[self._UUID]
Line 364: response = v.pmWakeup()
Line 365: except KeyError:
Line 365: except KeyError:
Line 366: return errCode['noVM']
Line 367: return response
Line 368:
Line 369: def hibernate(self, target):
> This behaves like shutdown. Should it become an additional option for shutd
The verb 'hibernate' already exists (for our migrate to file 'hibernate').
Line 370: """
Line 371: Hibernate a VM.
Line 372:
Line 373: :param mode: mem/disk/hybrid/hiberVolHandle
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line 357: stats = v.getStats().copy()
Line 358: stats['vmId'] = self._UUID
Line 359: return {'status': doneCode, 'statsList': [stats]}
Line 360:
Line 361: def wakeup(self):
From the point of view of VDSM the VM will be still running (qemu process). Do
you think to (can you) report a different VM status?
Can you share some info on how a client should discover this? (engine side).
Line 362: try:
Line 363: v = self._cif.vmContainer[self._UUID]
Line 364: response = v.pmWakeup()
Line 365: except KeyError:
Line 365: except KeyError:
Line 366: return errCode['noVM']
Line 367: return response
Line 368:
Line 369: def hibernate(self, target):
This behaves like shutdown. Should it become an additional option for shutdown?
(instead of a new verb).
Line 370: """
Line 371: Hibernate a VM.
Line 372:
Line 373: :param mode: mem/disk/hybrid/hiberVolHandle
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Michal Skrivanek has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 5: Code-Review-1 I think we have to run through the suspend hooks as well -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 5: Verified+1 Verified by testing on real VMs with QGA installed -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6059/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6162/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 4: Code-Review-1
(2 comments)
File vdsm/vm.py
Line 2451: 'message': 'Machine shut down'}}
Line 2452:
Line 2453: def pmWakeup(self):
Line 2454: try:
Line 2455: self._connection.virDomainPMWakeup()
shouldn't this be something like:
self._dom.pMWakeup(...)
Line 2456: except:
Line 2457: self.log.error("Wake up failed", exc_info=True)
Line 2458: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2459: 'message': 'Failed to wake up VM.'}}
Line 2465: targets = {'mem': libvirt.VIR_NODE_SUSPEND_TARGET_MEM,
Line 2466:'disk': libvirt.VIR_NODE_SUSPEND_TARGET_DISK,
Line 2467:'hybrid':
libvirt.VIR_NODE_SUSPEND_TARGET_HYBRID}
Line 2468:
Line 2469:
self._connection.virDomainPMSuspendForDuration(targets[target],
shouldn't this be something like:
self._dom.pMSuspendForDuration(...)
Line 2470:0, 0)
Line 2471: except:
Line 2472: self.log.error("Suspend failed", exc_info=True)
Line 2473: return {'status': {'code':
errCode['exist']['status']['code'],
--
To view, visit http://gerrit.ovirt.org/19389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Ayal Baron has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: -Code-Review Please verify this with a complete engine setup that it still works. I might be wrong about the backwards compatibility (therefore removing my -1) -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: Backwards compatibility is also taken into account: old calls with hiberVolHandle will be served by standard migrate to file while 'ram', 'sleep' or 'hybrid' uses guest OS S3/S4 capabilities -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: Code-Review-1 This patch is breaking the previously existing API Please look at this patchset: http://gerrit.ovirt.org/#/c/1121/16 This already started the implementation and took the backwards compatibility into account -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4596/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3711/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4575/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3690/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
