Change in vdsm[master]: xmlrpc: Parsing error logging enhancement
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5070/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4266/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5144/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057162c45ba09e4f48d73dda73ce9e77f6d72295 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4267/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5145/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057162c45ba09e4f48d73dda73ce9e77f6d72295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4268/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5146/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057162c45ba09e4f48d73dda73ce9e77f6d72295 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More explicit octal values (pep-3127)
Antoni Segura Puimedon has posted comments on this change. Change subject: More explicit octal values (pep-3127) .. Patch Set 2: Verified+1 ➜ vdsm git:(9370bb0) gitpydiff checking lib/vdsm/tool/transient.py checking tests/fileUtilTests.py checking tests/functional/storageTests.py checking tests/functional/virtTests.py checking tests/hooksTests.py checking tests/miscTests.py checking vds_bootstrap/vds_bootstrap.py checking vdsm/netconf/ifcfg.py checking vdsm/storage/blockVolume.py checking vdsm/storage/fileSD.py checking vdsm/storage/fileUtils.py checking vdsm/storage/fileVolume.py checking vdsm/storage/storageServer.py checking vdsm/vm.py checking vdsm_reg/createDaemon.py ➜ vdsm git:(9370bb0) -- To view, visit http://gerrit.ovirt.org/20534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc81c0ac52cc779511e49133aa669defeb47a3f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More explicit octal values (pep-3127)
oVirt Jenkins CI Server has posted comments on this change. Change subject: More explicit octal values (pep-3127) .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5073/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4269/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5147/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/742/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc81c0ac52cc779511e49133aa669defeb47a3f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Parsing error logging enhancement
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5074/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4270/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5148/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057162c45ba09e4f48d73dda73ce9e77f6d72295 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
Antoni Segura Puimedon has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 1:
(8 comments)
Thanks a lot for the fast review Dan!
File tests/functional/networkTests.py
Line 376: NET_VLANS = [(NETWORK_NAME + str(index), str(index))
Line 377: for index in range(VLAN_COUNT)]
Line 378: with dummyIf(1) as nics:
Line 379: firstVlan, firstVlanId = NET_VLANS[0]
Line 380: _ = self.vdsm_net.addNetwork(firstVlan, vlan=firstVlanId,
Done
Line 381:bond=BONDING_NAME,
Line 382:nics=nics,
opts=opts)
Line 383: with nonChangingOperstate(BONDING_NAME):
Line 384: for netVlan, vlanId in NET_VLANS[1:]:
File tests/functional/virtTests.py
Line 82:
Line 83: def _genInitramfs():
Line 84: fd, path = tempfile.mkstemp()
Line 85: cmd = [_mkinitrd.cmd, -f, path, _kernelVer]
Line 86: _ = execCmd(cmd, sudo=False)
Done
Line 87: os.chmod(path, 0o644)
Line 88: return path
Line 89:
Line 90:
File tests/miscTests.py
Line 431: dstFd, dstPath = tempfile.mkstemp()
Line 432: os.chmod(dstPath, 0o666)
Line 433:
Line 434: #Copy
Line 435: _ = misc.ddWatchCopy(srcPath, dstPath, None, len(data))
Done
Line 436:
Line 437: #Get copied data
Line 438: readData = open(dstPath).read()
Line 439:
File tests/vmTests.py
Line 389: # Negative flow, unsupported value
Line 390: driveInput.update({'shared': 'UNKNOWN-VALUE'})
Line 391:
Line 392: with self.assertRaises(ValueError):
Line 393: _ = vm.Drive({}, self.log, **driveInput)
Done
Line 394:
Line 395: def testDriveXML(self):
Line 396: SERIAL = '54-a672-23e5b495a9ea'
Line 397: devConfs = [
File vdsm/storage/hsm.py
Line 1860:
Line 1861: self.log.info(spUUID=%s master=%s, spUUID, masterDom)
Line 1862:
Line 1863: try:
Line 1864: _ = self.getPool(spUUID)
Done
Line 1865: except se.StoragePoolUnknown:
Line 1866: pool = sp.StoragePool(spUUID, self.domainMonitor,
self.taskMng)
Line 1867: else:
Line 1868: raise se.StoragePoolConnected(spUUID)
File vdsm/storage/iscsi.py
Line 428: else:
Line 429: time.sleep(1)
Line 430: else:
Line 431: log.warning(Still waiting for scsi scan of hbas: %s,
Line 432: tuple(hba for _ in processes))
Done
Line 433:
Line 434:
Line 435: def devIsiSCSI(dev):
Line 436: hostdir = os.path.realpath(os.path.join(/sys/block, dev,
File vdsm/storage/resourceManager.py
Line 925: req = self.requests[fullName]
Line 926: return req.wait(timeout)
Line 927:
Line 928: # req not found - check that it is not granted
Line 929: for _ in self.resources:
I have to say that in these modules I found more weird stuff that I didn't dare
touch. I'll move them to a separate patch.
Line 930: return True
Line 931:
Line 932: # Note that there is a risk of another thread that is racing
with us
Line 933: # and releases this resource - but this should be synced
above us
File vdsm/vm.py
Line 3057: try:
Line 3058: self._dom.attachDevice(nicXml)
Line 3059: except libvirt.libvirtError as e:
Line 3060: self.log.error(Hotplug failed, exc_info=True)
Line 3061: _ = hooks.after_nic_hotplug_fail(
Done
Line 3062: nicXml, self.conf, params=customProps)
Line 3063: if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 3064: return errCode['noVM']
Line 3065: return {'status': {'code':
errCode['hotplugNic']['status']['code'],
--
To view, visit http://gerrit.ovirt.org/20535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Add additional vgck.
Pavel Zhukov has uploaded a new change for review. Change subject: Add additional vgck. .. Add additional vgck. vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). As a result domainMonitorThread has outdated metadata (with filtered PVs). Bugzilla-Url: https://bugzilla.redhat.com/1022976 Change-Id: Ia9b54bc0563735300a688c297f0f7605dc815018 Signed-off-by: Pavel Zhukov pzhu...@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/20546/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 0c2964e..c604e4e 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -410,6 +410,8 @@ vgsFields[uuid][pvNameIdx].append(pv_name) for fields in vgsFields.itervalues(): vg = makeVG(*fields) +if not chkVG(vg.name): +log.warning(vgck failed: %s check filters, vg.name) if vg.pv_count != len(vg.pv_name): log.error(vg %s has pv_count %d but pv_names %s, vg.name, vg.pv_count, vg.pv_name) -- To view, visit http://gerrit.ovirt.org/20546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9b54bc0563735300a688c297f0f7605dc815018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Add debug level option
Nir Soffer has posted comments on this change. Change subject: iscsiadm: Add debug level option .. Patch Set 3: I am wondering why you don't want to move step by step, I mean writing this log to another file first. Writing to separate log file means means additional code to create and maintain those logs, and then additional effort to cleanup and rotate old logs. And the resulting log is hard to correlate with vdsm log. So this would waste of effort for little value. It probably will reduce the resistance to this RFE by half and you will be able to evaluate how helpful this log on the real customer environment. I don't see any reason to waste time in this direction if the community does not like this RFE. I understand from that RFE (Lev's comment) that original problem was corrupted iscsi DB, do you know how it happened in the first place? The RFE does not mention an original problem. The purpose of the patch is to make debugging iscsiadm issues easier by providing debug log messages, as requested by the RFE. Please review this patch in this scope. -- To view, visit http://gerrit.ovirt.org/20338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lev Veyde lve...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5075/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4271/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5149/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/743/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgck.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add additional vgck. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5076/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4272/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5150/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9b54bc0563735300a688c297f0f7605dc815018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5077/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4273/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5151/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/744/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Add debug level option
Eduardo has posted comments on this change. Change subject: iscsiadm: Add debug level option .. Patch Set 3: There is no necessity for this RFE or this way is questionable IMHO. (As I wrote there.) The bottom line is that cluttering the vdsm logs with this info is making vdsm log worse. vdsm is not a tool for iscsi debuging. -- To view, visit http://gerrit.ovirt.org/20338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lev Veyde lve...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgck.
Pavel Zhukov has abandoned this change. Change subject: Add additional vgck. .. Abandoned need to resubmit the patch -- To view, visit http://gerrit.ovirt.org/20546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia9b54bc0563735300a688c297f0f7605dc815018 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
Pavel Zhukov has uploaded a new change for review. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Bugzilla-Url: https://bugzilla.redhat.com/1022976 Signed-off-by: Pavel Zhukov pzhu...@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/20552/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index b95be21..4b21c35 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -846,7 +846,7 @@ self._lastUncachedSelftest = now lvm.chkVG(self.sdUUID) elif lvm.getVG(self.sdUUID).partial != lvm.VG_OK: -raise se.StorageDomainAccessError(self.sdUUID) +lvm.chkVG(self.sdUUID) def validate(self): -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5078/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4274/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5152/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Networking code logging and docstring fixes
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: cleanup: Networking code logging and docstring fixes
..
cleanup: Networking code logging and docstring fixes
Change-Id: Ia50c60e6cd4aab0a4ef49d1d9a2d43b52b187ce2
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M vdsm/netmodels.py
M vdsm/sourceRoute.py
2 files changed, 19 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/20553/1
diff --git a/vdsm/netmodels.py b/vdsm/netmodels.py
index 554ce4b..e6feeb5 100644
--- a/vdsm/netmodels.py
+++ b/vdsm/netmodels.py
@@ -139,7 +139,7 @@
class Bridge(NetDevice):
-'''This class represents traditional kernel bridges.'''
+This class represents traditional kernel bridges.
MAX_NAME_LEN = 15
ILLEGAL_CHARS = frozenset(':. \t')
@@ -270,7 +270,7 @@
@classmethod
def validateOptions(cls, bonding, bondingOptions):
-'Example: BONDING_OPTS=mode=802.3ad miimon=150'
+Example: BONDING_OPTS=mode=802.3ad miimon=150\
with cls._validationBond(bonding) as bond:
try:
for option in bondingOptions.split():
@@ -348,7 +348,7 @@
@classmethod
def validateGateway(cls, gateway):
-'''Validates the gateway form.'''
+Validates the gateway form.
try:
cls.validateAddress(gateway)
except ConfigNetworkError as cne:
diff --git a/vdsm/sourceRoute.py b/vdsm/sourceRoute.py
index 73fe075..72519d9 100644
--- a/vdsm/sourceRoute.py
+++ b/vdsm/sourceRoute.py
@@ -65,7 +65,7 @@
def configure(self, ipaddr, mask, gateway):
if gateway in (None, '0.0.0.0') or not ipaddr or not mask:
-logging.error(ipaddr, mask or gateway not received)
+logging.error('ipaddr, mask or gateway not received')
return
self.ipaddr = ipaddr
@@ -75,10 +75,10 @@
network = netaddr.IPNetwork(str(self.ipaddr) + '/' + str(self.mask))
self.network = %s/%s % (network.network, network.prefixlen)
-logging.info((Configuring gateway - ip: %s, network: %s, +
- subnet: %s, gateway: %s, table: %s, device: %s) %
- (self.ipaddr, self.network, self.mask, self.gateway,
- self.table, self.device))
+logging.info('Configuring gateway - ip: %s, network: %s, subnet: %s, '
+ 'gateway: %s, table: %s, device: %s', self.ipaddr,
+ self.network, self.mask, self.gateway, self.table,
+ self.device)
self.routes = self._buildRoutes()
self.rules = self._buildRules()
@@ -87,8 +87,8 @@
self.configurator.configureSourceRoute(self.routes, self.rules,
self.device)
except IPRoute2Error as e:
-logging.error('ip binary failed during source route configuration',
- ': %s' % e.message)
+logging.error('ip binary failed during source route configuration'
+ ': %s', e.message)
def remove(self):
self.configurator.removeSourceRoute(None, None, self.device)
@@ -116,13 +116,11 @@
try:
route = Route.fromText(entry)
except ValueError:
-logging.debug(Could not parse route %s % entry)
+logging.debug('Could not parse route %s', entry)
else:
if route.device == device:
-
-When displaying routes from a table, the table is omitted,
-so add it back again
-
+# When displaying routes from a table, the table is
+# omitted, so add it back again
route.table = table
routes.append(route)
@@ -133,7 +131,7 @@
if rules:
return rules[0].table
else:
-logging.error(Table not found)
+logging.error('Table not found')
return None
@staticmethod
@@ -151,7 +149,7 @@
try:
rule = Rule.fromText(entry)
except ValueError:
-logging.debug(Could not parse rule %s % entry)
+logging.debug('Could not parse rule %s', entry)
else:
allRules.append(rule)
@@ -159,7 +157,7 @@
rules = [rule for rule in allRules if rule.srcDevice == device]
if not rules:
-logging.error(Routing rules not found for device %s % device)
+logging.error('Routing rules not found for device %s', device)
return
# Extract its destination network
@@ -172,7 +170,7 @@
return rules
def remove(self):
-logging.info(Removing gateway - device: %s % self.device)
+logging.info('Removing gateway
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
Tomáš Došek has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 1: Nack - we need also to reset self._lastUncachedSelftest = now in the elif branch to avoid the whole section being repeated until infinity (possible race). -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
Tomáš Došek has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5080/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4276/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5154/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Networking code logging and docstring fixes
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Networking code logging and docstring fixes .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5079/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4275/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5153/ : ABORTED http://jenkins.ovirt.org/job/vdsm_network_functional_tests/745/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia50c60e6cd4aab0a4ef49d1d9a2d43b52b187ce2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5081/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4277/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5155/ : ABORTED -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: cleanup: Improve networking imports (PEP328)
..
cleanup: Improve networking imports (PEP328)
PEP328 ( http://www.python.org/dev/peps/pep-0328/ ) does away with
the ambiguity of where the modules that are being imported reside
making the codebase much more browsable.
With a codebase of:
package/
__init__.py
subpackage1/
__init__.py
moduleX.py
moduleY.py
subpackage2/
__init__.py
moduleZ.py
moduleA.py
this (moduleY.py):
import moduleX
import moduleZ
becomes
from . import moduleX
from ..subpackage2 import moduleZ
Which makes it much more evident where things are and avoids possible
shadowing of packages in site-packages.
Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netconfpersistence.py
M lib/vdsm/netinfo.py
M vdsm/configNetwork.py
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
M vdsm/netconf/iproute2.py
M vdsm/netconf/libvirtCfg.py
M vdsm/netmodels.py
M vdsm/sourceRoute.py
M vdsm/sourceRouteThread.py
M vdsm/tc.py
M vdsm/vdsm-restore-net-config
13 files changed, 77 insertions(+), 71 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/20555/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index cf0c069..a3455de 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -16,6 +16,7 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
from collections import namedtuple
@@ -23,8 +24,8 @@
from netaddr import IPAddress
from netaddr import IPNetwork
-from utils import CommandPath
-from utils import execCmd
+from .utils import CommandPath
+from .utils import execCmd
_IP_BINARY = CommandPath('ip', '/sbin/ip')
diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 633cb94..34c9ea8 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -17,16 +17,17 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
import errno
import json
import logging
import os
-from config import config
-from tool.restore_nets import restore
-import constants
-import utils
+from .config import config
+from .tool.restore_nets import restore
+from . import constants
+from . import utils
CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/'
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 60088d4..1c41802 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -17,27 +17,26 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
from collections import namedtuple
-import errno
from fnmatch import fnmatch
from glob import iglob
from itertools import chain
+from xml.dom import minidom
+import errno
import logging
import os
import shlex
import socket
import struct
-from xml.dom import minidom
import ethtool
-from config import config
-import constants
-from ipwrapper import Route
-from ipwrapper import routeShowAllDefaultGateways
-import libvirtconnection
-from ipwrapper import linkShowDev
+from .config import config
+from . import constants
+from . import libvirtconnection
+from .ipwrapper import linkShowDev, Route, routeShowAllDefaultGateways
NET_CONF_DIR = '/etc/sysconfig/network-scripts/'
# ifcfg persistence directories
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 3894691..06a7e9e 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -16,32 +16,24 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from __future__ import absolute_import
from functools import wraps
import inspect
-import sys
-import os
-import traceback
-import time
import logging
+import os
+import sys
+import time
+import traceback
+from . import hooks
+from . import neterrors as ne
+from .netconf.ifcfg import ConfigWriter, Ifcfg
+from .neterrors import ConfigNetworkError
+from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan
from vdsm.config import config
-from vdsm import constants
-from vdsm import utils
-from storage.misc import execCmd
-import neterrors as ne
-from neterrors import ConfigNetworkError
-from vdsm import netinfo
-from netconf.ifcfg import ConfigWriter
-from netconf.ifcfg import Ifcfg
-from netmodels import Bond
-from netmodels import Bridge
-from netmodels import IPv4
-from netmodels import IPv6
-from netmodels import IpConfig
-from netmodels import Nic
-from netmodels import Vlan
-import hooks
+from vdsm import constants, netinfo, utils
+from vdsm.utils import execCmd
CONNECTIVITY_TIMEOUT_DEFAULT = 4
diff --git a/vdsm/netconf/__init__.py
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
Nir Soffer has posted comments on this change. Change subject: cleanup: Improve networking imports (PEP328) .. Patch Set 1: Code-Review-1 (16 comments) Important cleanup - but mixes many unrelated cleanups. This patch does much more than promised in the commit message: - Merge multiple imports into one line - this change is wrong, as it makes reviewing import changes harder. If you want to push this evil practice, do this in another patch. - Change import order - not sure why this was done - Add missing copyright - Fix the years in another copyright Please remove anything which is not related to absolute imports. Commit Message Line 29: from . import moduleX Line 30: from ..subpackage2 import moduleZ Line 31: Line 32: Which makes it much more evident where things are and avoids possible Line 33: shadowing of packages in site-packages. Great commit message! I wish we have more like this. Line 34: Line 35: Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 File lib/vdsm/netinfo.py Line 28: import logging Line 29: import os Line 30: import shlex Line 31: import socket Line 32: import struct Why did you change the order of imports? How is this related to absolute imports? Line 33: Line 34: import ethtool Line 35: Line 36: from .config import config Line 35: Line 36: from .config import config Line 37: from . import constants Line 38: from . import libvirtconnection Line 39: from .ipwrapper import linkShowDev, Route, routeShowAllDefaultGateways How is merging multiple imports to one line import related to the purpose of this patch? Line 40: Line 41: NET_CONF_DIR = '/etc/sysconfig/network-scripts/' Line 42: # ifcfg persistence directories Line 43: NET_CONF_BACK_DIR = constants.P_VDSM_LIB + 'netconfback/' File vdsm/configNetwork.py Line 29: from . import hooks Line 30: from . import neterrors as ne Line 31: from .netconf.ifcfg import ConfigWriter, Ifcfg Line 32: from .neterrors import ConfigNetworkError Line 33: from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan How is merging multiple import lines to one import line related to the purpose of this patch? Line 34: from vdsm.config import config Line 35: from vdsm import constants, netinfo, utils Line 36: from vdsm.utils import execCmd Line 37: Line 31: from .netconf.ifcfg import ConfigWriter, Ifcfg Line 32: from .neterrors import ConfigNetworkError Line 33: from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan Line 34: from vdsm.config import config Line 35: from vdsm import constants, netinfo, utils How is merging multiple import lines to one import line related to the purpose of this patch? Line 36: from vdsm.utils import execCmd Line 37: Line 38: CONNECTIVITY_TIMEOUT_DEFAULT = 4 Line 39: Line 32: from .neterrors import ConfigNetworkError Line 33: from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan Line 34: from vdsm.config import config Line 35: from vdsm import constants, netinfo, utils Line 36: from vdsm.utils import execCmd vdsm.utils.execCmd is *not* storage.misc.execCmd! Line 37: Line 38: CONNECTIVITY_TIMEOUT_DEFAULT = 4 Line 39: Line 40: File vdsm/netconf/__init__.py Line 20: Line 21: import logging Line 22: Line 23: from ..netmodels import Bond, Bridge Line 24: from ..sourceRoute import DynamicSourceRoute, StaticSourceRoute How is merging multiple import lines to one import line related to the purpose of this patch? Line 25: from vdsm.config import config Line 26: from vdsm import netinfo Line 27: from vdsm.netconfpersistence import RunningConfig Line 28: Line 22: Line 23: from ..netmodels import Bond, Bridge Line 24: from ..sourceRoute import DynamicSourceRoute, StaticSourceRoute Line 25: from vdsm.config import config Line 26: from vdsm import netinfo Why did you change the order of imports? Line 27: from vdsm.netconfpersistence import RunningConfig Line 28: Line 29: Line 30: class Configurator(object): File vdsm/netconf/iproute2.py Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: Line 21: from vdsm.ipwrapper import routeAdd, routeDel, ruleAdd, ruleDel This style makes it harder to review when import are changed. One import per line is a better strategy. Line 22: Line 23: Line 24: class Iproute2(object): Line 25: @staticmethod File vdsm/netconf/libvirtCfg.py Line 19: import libvirt Line 20: from xml.dom.minidom import Document Line 21: from xml.sax.saxutils import escape Line 22: Line 23: from vdsm import libvirtconnection, netinfo How is merging multiple import lines to one import line
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5082/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4278/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5156/ : ABORTED -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Improve networking imports (PEP328) .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5084/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4280/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5158/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/747/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Networking code logging and docstring fixes
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: Networking code logging and docstring fixes .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5083/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4279/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5157/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/746/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia50c60e6cd4aab0a4ef49d1d9a2d43b52b187ce2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5085/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4281/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5159/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Nir Soffer has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: (1 comment) Must warn when finding unexpected active lvs. File vdsm/storage/lvm.py Line 1133: Line 1134: if toActivate: Line 1135: _setLVAvailability(vgName, toActivate, y) Line 1136: Line 1137: if toRefresh: Please log warning here - we do not expect to find such lvs in normal conditions. Line 1138: refreshLV(vgName, toRefresh) Line 1139: Line 1140: Line 1141: def deactivateLVs(vgName, lvNames): -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 4: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5086/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4282/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5160/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/748/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getFileList() filters files in case incensitive manner
Nir Soffer has posted comments on this change. Change subject: getFileList() filters files in case incensitive manner .. Patch Set 1: Sergey, Dan and me discussed the wanted api, and agreed that: - Change the name to getFileStats. - Use the options argument for the caseSensitive option, so we can add more options later. Sergey will check how much work is needed for this, as options are never sent from the engine to vdsm. -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
Antoni Segura Puimedon has posted comments on this change. Change subject: cleanup: Improve networking imports (PEP328) .. Patch Set 1: (4 comments) Thanks a lot for the review Nir! Important cleanup - but mixes many unrelated cleanups. This patch does much more than promised in the commit message: - Merge multiple imports into one line - this change is wrong, as it makes reviewing import changes harder. If you want to push this evil practice, do this in another patch. I can very well move it to a separate patch so devs can vote on this specific issue alone. - Change import order - not sure why this was done I'll update the commit message to reflect that I'm fixing the imports in general, and part of that is to keep them properly sorted. - Add missing copyright Totally right, will move that into a separate patch. - Fix the years in another copyright This is necessary for the patch. When you touch a file you are supposed to make sure the the copyright is updated to include the current year in the range. Please remove anything which is not related to absolute imports. File vdsm/configNetwork.py Line 32: from .neterrors import ConfigNetworkError Line 33: from .netmodels import Bond, Bridge, IPv4, IPv6, IpConfig, Nic, Vlan Line 34: from vdsm.config import config Line 35: from vdsm import constants, netinfo, utils Line 36: from vdsm.utils import execCmd storage.misc.execCmd only puts a storage specific logger on top of utils execCmd (we moved the original there). Line 37: Line 38: CONNECTIVITY_TIMEOUT_DEFAULT = 4 Line 39: Line 40: File vdsm/sourceRouteThread.py Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: from __future__ import absolute_import Line 20: Yeah. This one is unrelated, just my laziness to make an extra patch for that :P Line 21: import logging Line 22: import os Line 23: Line 24: import pyinotify File vdsm/tc.py Line 26: Line 27: import ethtool Line 28: Line 29: from vdsm.constants import EXT_TC Line 30: from vdsm.utils import execCmd answered in another file. Line 31: Line 32: ERR_DEV_NOEXIST = 2 Line 33: Line 34: QDISC_INGRESS = ':' File vdsm/vdsm-restore-net-config Line 1: #! /usr/bin/python Line 2: # Line 3: # Copyright 2011-2013 Red Hat, Inc. If I modify the file in 2013 I should update the year in the header. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 6: # it under the terms of the GNU General Public License as published by Line 7: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vgscan doesn't return nonzero return code if one or more phi...
Dan Kenigsberg has posted comments on this change. Change subject: vgscan doesn't return nonzero return code if one or more phisycal volumes are filtered (missed). We should check vg before raising of the exception. chkVG itself raises storageAccessError if failed, so selftest doesn't have to it second time. .. Patch Set 5: Code-Review-1 (1 comment) Commit Message Line 3: AuthorDate: 2013-10-25 11:10:39 +0200 Line 4: Commit: Pavel Zhukov pzhu...@redhat.com Line 5: CommitDate: 2013-10-25 13:00:55 +0200 Line 6: Line 7: vgscan doesn't return nonzero return code if one or more phisycal please have a short line at the top, separated by a newline. your current subject has double negation and is hard to comprehend. Please explain the problem at hand and how this patch solves it. Line 8: volumes are filtered (missed). We should check vg before raising of Line 9: the exception. chkVG itself raises storageAccessError if failed, so Line 10: selftest doesn't have to it second time. Line 11: -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
Antoni Segura Puimedon has posted comments on this change. Change subject: cleanup: Improve networking imports (PEP328) .. Patch Set 1: Thanks a lot for the review Nir! Important cleanup - but mixes many unrelated cleanups. This patch does much more than promised in the commit message: - Merge multiple imports into one line - this change is wrong, as it makes reviewing import changes harder. If you want to push this evil practice, do this in another patch. I can very well move it to a separate patch so devs can vote on this specific issue alone. - Change import order - not sure why this was done I'll update the commit message to reflect that I'm fixing the imports in general, and part of that is to keep them properly sorted. - Add missing copyright Totally right, will move that into a separate patch. - Fix the years in another copyright This is necessary for the patch. When you touch a file you are supposed to make sure the the copyright is updated to include the current year in the range. Please remove anything which is not related to absolute imports. -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: Improve networking imports (PEP328)
Nir Soffer has posted comments on this change. Change subject: cleanup: Improve networking imports (PEP328) .. Patch Set 1: Please do not change import order in this patch - it is not related to absolute imports and just make it harder to review. -- To view, visit http://gerrit.ovirt.org/20555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I249cfa0ad734ea45ecbbecbade9daeed6c3adc12 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
oVirt Jenkins CI Server has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5087/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4283/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5161/ : FAILURE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/749/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add additional vgcheck. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5088/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4284/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5162/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add additional vgcheck. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5089/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4285/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5163/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck.
Tomáš Došek has posted comments on this change. Change subject: Add additional vgcheck. .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.
Pavel Zhukov has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 8: I'm sorry for the push flooding. Added the main reason of the patch (vgextend workflow) to the subject. -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5090/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4286/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5164/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.
Tomáš Došek has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bz#831938 raise exception when error occurs in connectStorag...
Itamar Heim has posted comments on this change. Change subject: bz#831938 raise exception when error occurs in connectStorageServer .. Patch Set 1: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/6137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c363f41d08669eec022797eb1eb440fe193f9c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adjust width for usage_command in vdsm-tool
Itamar Heim has posted comments on this change. Change subject: Adjust width for usage_command in vdsm-tool .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/4648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I800384e77452a76f651b73205b3335905274077c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reorganized host network APIs in API bridge
Itamar Heim has posted comments on this change. Change subject: Reorganized host network APIs in API bridge .. Patch Set 3: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/2663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64771991c3db09247f7689e6b5ddffa8adbf6745 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] rest-api: Model Networks
Itamar Heim has posted comments on this change. Change subject: [WIP] rest-api: Model Networks .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/5881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7eca74c16699a5cc35c4077192fb6ecfe706470 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minimalistic (incomplete) test for mkimage.py with fail for ...
Itamar Heim has posted comments on this change. Change subject: minimalistic (incomplete) test for mkimage.py with fail for non-64base data .. Patch Set 1: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/6275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a7656359beb5d116ad1919e237fe084a1208d71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Josef Pacula josef.pac...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: avoid redundant domain produce() in createStoragePool
Itamar Heim has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/7347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add functions getNetworkList and getNetworkInfo to API
Itamar Heim has posted comments on this change. Change subject: Add functions getNetworkList and getNetworkInfo to API .. Patch Set 4: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/2664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6689b31541fc98ff7a7951eedbb99270c60a0738 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
Itamar Heim has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 4: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/9655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86977c1b717d63de21ba4818c6b66e43976d65de Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Kaul yk...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move and encapsulate preun section into vdsm-tool
Itamar Heim has posted comments on this change. Change subject: Move and encapsulate preun section into vdsm-tool .. Patch Set 8: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/4526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Lei Li li...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: get max_tasks and thread_pool_size from config by getint()
Itamar Heim has posted comments on this change. Change subject: get max_tasks and thread_pool_size from config by getint() .. Patch Set 1: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/9035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fc719b1b4238b0df2d9c882777cb75d7a27d4df Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool
Itamar Heim has posted comments on this change. Change subject: Move start_needed_srv and shutdown_conflicting_srv to vdsm-tool .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/8759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54eca4b2cc3a17e9819a0188e5dc4c8bd28161da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix vm block stats lost after recovery
Itamar Heim has posted comments on this change. Change subject: Fix vm block stats lost after recovery .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/6056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a90cf909a07967f642d348e47b4928f7516c61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Source image exception when querying source image
Itamar Heim has posted comments on this change. Change subject: Source image exception when querying source image .. Patch Set 2: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/8479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6abb905f1042477aa6757d6e10d6989923e955b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Include vds_name parameter for node registration
Itamar Heim has posted comments on this change. Change subject: Include vds_name parameter for node registration .. Patch Set 3: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/8036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b0bcc473ef1a034736f80e1424e211ddf02946 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michael Burns mbu...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Misc storage exception class name style
Itamar Heim has posted comments on this change. Change subject: Misc storage exception class name style .. Patch Set 1: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/8847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6f279d13b92bbb8f573a0d772d7504860bbbe3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: move get-conf-item/set-conf-item to vdsm-tool
Itamar Heim has posted comments on this change. Change subject: move get-conf-item/set-conf-item to vdsm-tool .. Patch Set 5: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/7695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c64de097bbaea6a8cf862b43243377e10e00391 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Bing Bu Cao m...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: persist state in _changeBlockDev
Itamar Heim has posted comments on this change. Change subject: persist state in _changeBlockDev .. Patch Set 1: still relevant or should be abandoned? -- To view, visit http://gerrit.ovirt.org/8617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I220b72ebb360356092a2dccc25dfb9f63f638607 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minimalistic (incomplete) test for mkimage.py with fail for ...
Dan Kenigsberg has abandoned this change. Change subject: minimalistic (incomplete) test for mkimage.py with fail for non-64base data .. Abandoned -- To view, visit http://gerrit.ovirt.org/6275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1a7656359beb5d116ad1919e237fe084a1208d71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Josef Pacula josef.pac...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More explicit octal values (pep-3127)
Dan Kenigsberg has submitted this change and it was merged. Change subject: More explicit octal values (pep-3127) .. More explicit octal values (pep-3127) Change 0XXX to 0oXXX so that that these values are more visibly octal and forwards compatible with Python 3.3+. This change follows the spirit of: http://www.python.org/dev/peps/pep-3127/ The default octal representation of integers is silently confusing to people unfamiliar with C-like languages. It is extremely easy to inadvertently create an integer object with the wrong value, because '013' means 'decimal 11', not 'decimal 13', to the Python language itself, which is not the meaning that most humans would assign to this literal. Change-Id: Icc81c0ac52cc779511e49133aa669defeb47a3f1 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20534 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/tool/transient.py M tests/fileUtilTests.py M tests/functional/storageTests.py M tests/functional/virtTests.py M tests/hooksTests.py M tests/miscTests.py M vds_bootstrap/setup M vds_bootstrap/vds_bootstrap.py M vdsm/netconf/ifcfg.py M vdsm/storage/blockVolume.py M vdsm/storage/fileSD.py M vdsm/storage/fileUtils.py M vdsm/storage/fileVolume.py M vdsm/storage/storageServer.py M vdsm/vdsm M vdsm/vm.py M vdsm_reg/createDaemon.py M vdsm_reg/vdsm-reg-setup.in 18 files changed, 38 insertions(+), 38 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc81c0ac52cc779511e49133aa669defeb47a3f1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: More explicit octal values (pep-3127)
Dan Kenigsberg has posted comments on this change. Change subject: More explicit octal values (pep-3127) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc81c0ac52cc779511e49133aa669defeb47a3f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
Dan Kenigsberg has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 5: Code-Review-1 (1 comment) This patch is growing too quickly and produces too frequent risks. Could you slow down or break it to sub components? File vdsm/storage/blockVolume.py Line 602: def newVolumeLease(cls, metaId, sdUUID, volUUID): Line 603: cls.log.debug(Initializing volume lease volUUID=%s sdUUID=%s, Line 604: metaId=%s, volUUID, sdUUID, metaId) Line 605: dom = sdCache.produce(sdUUID) Line 606: mdSlot = metaId ? Line 607: Line 608: leasePath = dom.getLeasesFilePath() Line 609: leaseOffset = ((mdSlot + RESERVED_LEASES) Line 610:* dom.logBlkSize * sd.LEASE_BLOCKS) -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getFileList() filters files in case incensitive manner
Sergey Gotliv has posted comments on this change. Change subject: getFileList() filters files in case incensitive manner .. Patch Set 1: Dan, getFileList() is exposed in vdsClient. Does it mean that customer potentially can use it? -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
Antoni Segura Puimedon has posted comments on this change. Change subject: cleanup: drop several unused local variables .. Patch Set 5: (1 comment) Will split it in smaller parts. File vdsm/storage/blockVolume.py Line 602: def newVolumeLease(cls, metaId, sdUUID, volUUID): Line 603: cls.log.debug(Initializing volume lease volUUID=%s sdUUID=%s, Line 604: metaId=%s, volUUID, sdUUID, metaId) Line 605: dom = sdCache.produce(sdUUID) Line 606: mdSlot = metaId Good catch, I misread it as: metaSdUUID = mdSlot = metaId Line 607: Line 608: leasePath = dom.getLeasesFilePath() Line 609: leaseOffset = ((mdSlot + RESERVED_LEASES) Line 610:* dom.logBlkSize * sd.LEASE_BLOCKS) -- To view, visit http://gerrit.ovirt.org/20535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib81c292f900154819e8852c21ae389c323034999 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cleanup: drop several unused local variables
Nir Soffer has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5: Code-Review-1
(33 comments)
Most of these changes do not improve the code.
Place where unused variables are define are obvious - good cleanup.
In places where tuples or lists are split to variables, such in:
rc, out, err = execCmd(...)
I don't see much value in replacing unused variables with _. I prefer to see
all the returned values even if they are not used now. When we need to add a
log or print for debugging, it is nice to have the variable there.
In such places, if you need only rc or rc, out, using slice is cleaner:
rc, out = execCmd(...)[:2]
Although I suspect that all these places should have used err to raise an
exception. So better leave them until we fix error handling.
I also don't see value in replacing temporary vars in for loops with _:
for _ in xrange(count):
pass
Is not better then:
for n in xrange(count):
pass
The fact that that n is not used is not very important, and the readability is
worse.
I did not commented all places with these changes since the amount of changes
was huge.
Must most worries me is that this patch changes lot of possibly untested code,
and stupid error may change the behavior without being noticed in the review. I
would fill more confident about such patch if all changed functions had 100%
test coverage.
File tests/functional/virtTests.py
Line 84: fd, path = tempfile.mkstemp()
Line 85: cmd = [_mkinitrd.cmd, -f, path, _kernelVer]
Line 86: rc, _, err = execCmd(cmd, sudo=False)
Line 87: if rc:
Line 88: raise SkipTest('Cannot generate the initramfs: %s' % err)
We do not use out, but renaming it to _ does not help.
Line 89: os.chmod(path, 0o644)
Line 90: return path
Line 91:
Line 92:
File tests/hookValidation.py
Line 68: cookie_file = _createHookScript(hook_path, hook_name,
hook_script)
Line 69:
Line 70: try:
Line 71: kwargs['hook_cookiefile'] = cookie_file
Line 72: output = test_function(*args, **kwargs)
You can remove output completely if you return here:
return test_function(*args, **kwargs)
Not sure if this should be done in this patch.
Line 73: finally:
Line 74: if directory_existed:
Line 75: os.unlink(cookie_file)
Line 76: else:
File tests/hooksTests.py
Line 41: code = #! /bin/bash
Line 42: echo -n %s $_hook_domxml
Line 43:
Line 44: scripts = [tempfile.NamedTemporaryFile(dir=dirName,
delete=False)
Line 45:for _ in xrange(Q)]
I don't think _ is better then n here.
Line 46: scripts.sort(key=lambda f: f.name)
Line 47: for n, script in enumerate(scripts):
Line 48: script.write(code % n)
Line 49: os.chmod(os.path.join(dirName, script.name), 0o775)
File tests/miscTests.py
Line 448: fd, path = tempfile.mkstemp()
Line 449:
Line 450: try:
Line 451: for _ in xrange(repetitions):
Line 452: os.write(fd, data)
I don't see why _ is better then i.
Line 453: self.assertEquals(os.stat(path).st_size, misc.MEGA)
Line 454: except:
Line 455: os.unlink(path)
Line 456: raise
File tests/testValidation.py
Line 109: @wraps(f)
Line 110: def wrapper(*args, **kwargs):
Line 111: if not os.path.exists('/sys/module/dummy'):
Line 112: cmd_modprobe = [modprobe.cmd, dummy]
Line 113: rc, _, err = utils.execCmd(cmd_modprobe, sudo=True)
I don't see why _ is better then out here.
Line 114: if rc:
Line 115: raise SkipTest('Failed to load the required dummy
module: %s' %
Line 116:err)
Line 117: return f(*args, **kwargs)
File vdsm/blkid.py
Line 42: return self.message
Line 43:
Line 44:
Line 45: def getDeviceByUuid(uuid):
Line 46: rc, out, _ = utils.execCmd([constants.EXT_BLKID, '-U', uuid])
I don't see how _ is better then err here.
Line 47: if rc:
Line 48: raise BlockIdException(rc, uuid)
File vdsm/configNetwork.py
Line 423:
Line 424: def _validateNetworkSetup(networks, bondings):
Line 425: _netinfo = netinfo.NetInfo()
Line 426:
Line 427: for _, networkAttrs in networks.iteritems():
If you don't care about the keys, iterate on networks.values().
Line 428: if networkAttrs.get('remove', False):
Line 429:
Change in vdsm[master]: Network functional tests assertion improvements
Dan Kenigsberg has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 8: Code-Review+1 Toni, do you understand why this fails on el6? -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: getFileList() filters files in case incensitive manner
Dan Kenigsberg has posted comments on this change. Change subject: getFileList() filters files in case incensitive manner .. Patch Set 1: Theoretically speaking, there might exist a hermit that uses the getFileList API in its current implementation. I do not consider this as a real risk, but I would not nack keeping getFileList as an undocumented alias to getFileStats. -- To view, visit http://gerrit.ovirt.org/20476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add additional vgcheck to fix vgextend workflow on HSMs.
Sergey Gotliv has posted comments on this change. Change subject: Add additional vgcheck to fix vgextend workflow on HSMs. .. Patch Set 8: (2 comments) Commit Message Line 6: Line 7: Add additional vgcheck to fix vgextend workflow on HSMs. Line 8: Line 9: vgscan doesn't return nonzero return code if one or more physical Line 10: volumes are missed during the _reloadvgs opration. As a result Can you rephrase doesn't return nonzero with something like return zero even if one..., please. Line 11: LvmCache doesn't invalidate stale filters and volume group is Line 12: marked as partial and sefttest fails (host goes to non-operational status). Line 13: We should call vgck before raising of the exception, because vgck Line 14: returns error code 5 in case of missed PVs, as a result filters Line 8: Line 9: vgscan doesn't return nonzero return code if one or more physical Line 10: volumes are missed during the _reloadvgs opration. As a result Line 11: LvmCache doesn't invalidate stale filters and volume group is Line 12: marked as partial and sefttest fails (host goes to non-operational status). selftest Line 13: We should call vgck before raising of the exception, because vgck Line 14: returns error code 5 in case of missed PVs, as a result filters Line 15: are rebuilded with correct uuids. chkVG itself raises Line 16: storageAccessError if failed, so selftest doesn't have to do it second time. -- To view, visit http://gerrit.ovirt.org/20552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1eeed1c203f2c8c73370987048565d665932299 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Pavel Zhukov pzhu...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Tomáš Došek tdo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
