Re: Patch 8.1.1705
Hi, 2019/7/17 Wed 5:04:31 UTC+9 Bram Moolenaar wrote: > Patch 8.1.1705 > Problem:Using ~{} for a literal dict is not nice. > Solution: Use #{} instead. > Files:runtime/doc/eval.txt runtime/doc/popup.txt, src/eval.c, > src/testdir/test_listdict.vim src/testdir/test_popupwin.vim Thank you for adopting my idea. BTW, the following changes are also needed. --- a/src/dict.c +++ b/src/dict.c @@ -709,7 +709,7 @@ dict2string(typval_T *tv, int copyID, in } /* - * Get the key for *{key: val} into "tv" and advance "arg". + * Get the key for #{key: val} into "tv" and advance "arg". * Return FAIL when there is no valid key. */ static int @@ -731,7 +731,7 @@ get_literal_key(char_u **arg, typval_T * /* * Allocate a variable for a Dictionary and fill it from "*arg". - * "literal" is TRUE for *{key: val} + * "literal" is TRUE for #{key: val} * Return OK or FAIL. Returns NOTDONE for {expr}. */ int Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/98107b45-a15c-4c1b-82cb-571ee5f253f1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1648
> ! #if defined(FEAT_BEVAL) || defined(FEAT_TEXT_PROP) || defined(PROT) This was meant to check "PROTO" instead of "PROT", wasn't it? Tom -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/530ba884-32c4-4467-ac60-105ea77107f0%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1705
Patch 8.1.1705 Problem:Using ~{} for a literal dict is not nice. Solution: Use #{} instead. Files: runtime/doc/eval.txt runtime/doc/popup.txt, src/eval.c, src/testdir/test_listdict.vim src/testdir/test_popupwin.vim *** ../vim-8.1.1704/runtime/doc/eval.txt2019-07-14 18:22:53.789089005 +0200 --- runtime/doc/eval.txt2019-07-16 21:53:00.085639968 +0200 *** *** 60,66 value. |Dictionary| Examples: {'blue': "#ff", 'red': "#ff"} ! ~{blue: "#ff", red: "#ff"} Funcref A reference to a function |Funcref|. Example: function("strlen") --- 60,66 value. |Dictionary| Examples: {'blue': "#ff", 'red': "#ff"} ! #{blue: "#ff", red: "#ff"} Funcref A reference to a function |Funcref|. Example: function("strlen") *** *** 482,492 Number will be converted to the String '4'. The empty string can also be used as a key. *literal-Dict* ! To avoid having to put quotes around every key the ~{} form can be used. This does require the key to consist only of ASCII letters, digits, '-' and '_'. Example: > ! let mydict = ~{zero: 0, one_key: 1, two-key: 2, 333: 3} ! Note that 333 here is the string "333". Empty keys are not possible here. A value can be any expression. Using a Dictionary for a value creates a nested Dictionary: > --- 482,492 Number will be converted to the String '4'. The empty string can also be used as a key. *literal-Dict* ! To avoid having to put quotes around every key the #{} form can be used. This does require the key to consist only of ASCII letters, digits, '-' and '_'. Example: > ! let mydict = #{zero: 0, one_key: 1, two-key: 2, 333: 3} ! Note that 333 here is the string "333". Empty keys are not possible with #{}. A value can be any expression. Using a Dictionary for a value creates a nested Dictionary: > *** ../vim-8.1.1704/runtime/doc/popup.txt 2019-07-14 18:22:53.789089005 +0200 --- runtime/doc/popup.txt 2019-07-16 21:53:20.965547639 +0200 *** *** 178,184 popup_atcursor({what}, {options}) *popup_atcursor()* Show the {what} above the cursor, and close it when the cursor moves. This works like: > ! call popup_create({what}, ~{ \ pos: 'botleft', \ line: 'cursor-1', \ col: 'cursor', --- 178,184 popup_atcursor({what}, {options}) *popup_atcursor()* Show the {what} above the cursor, and close it when the cursor moves. This works like: > ! call popup_create({what}, #{ \ pos: 'botleft', \ line: 'cursor-1', \ col: 'cursor', *** *** 191,197 Show the {what} above the position from 'ballooneval' and close it when the mouse moves. This works like: > let pos = screenpos(v:beval_winnr, v:beval_lnum, v:beval_col) ! call popup_create({what}, ~{ \ pos: 'botleft', \ line: pos.row - 1, \ col: pos.col, --- 191,197 Show the {what} above the position from 'ballooneval' and close it when the mouse moves. This works like: > let pos = screenpos(v:beval_winnr, v:beval_lnum, v:beval_col) ! call popup_create({what}, #{ \ pos: 'botleft', \ line: pos.row - 1, \ col: pos.col, *** *** 240,246 popup_dialog({what}, {options}) *popup_dialog()* Just like |popup_create()| but with these default options: > ! call popup_create({what}, ~{ \ pos: 'center', \ zindex: 200, \ drag: 1, --- 240,246 popup_dialog({what}, {options}) *popup_dialog()* Just like |popup_create()| but with these default options: > ! call popup_create({what}, #{ \ pos: 'center', \ zindex: 200, \ drag: 1, *** *** 249,255 \}) < Use {options} to change the properties. E.g. add a 'filter' option with value
Patch 8.1.1704
Patch 8.1.1704 Problem:C-R C-W does not work after C-G when using 'incsearch'. Solution: Put cursor at end of the match. (Yasuhiro Matsumoto, closes #4664) Files: src/ex_getln.c, src/testdir/test_search.vim *** ../vim-8.1.1703/src/ex_getln.c 2019-07-12 17:57:54.836524031 +0200 --- src/ex_getln.c 2019-07-16 21:35:58.894173141 +0200 *** *** 713,718 --- 713,719 save_viewstate(_state->old_viewstate); update_screen(NOT_VALID); redrawcmdline(); + curwin->w_cursor = is_state->match_end; } else vim_beep(BO_ERROR); *** ../vim-8.1.1703/src/testdir/test_search.vim 2019-06-06 16:12:05.923134646 +0200 --- src/testdir/test_search.vim 2019-07-16 21:35:58.894173141 +0200 *** *** 240,245 --- 240,249 " go to previous match (on line 2) call feedkeys("/the\\\", 'tx') call assert_equal(' 2 these', getline('.')) + 1 + " go to previous match (on line 2) + call feedkeys("/the", 'tx') + call assert_equal('theother', @/) " Test 2: keep the view, " after deleting a character from the search cmd *** *** 251,257 call assert_equal({'lnum': 10, 'leftcol': 0, 'col': 4, 'topfill': 0, 'topline': 6, 'coladd': 0, 'skipcol': 0, 'curswant': 4}, winsaveview()) " remove all history entries ! for i in range(10) call histdel('/') endfor --- 255,261 call assert_equal({'lnum': 10, 'leftcol': 0, 'col': 4, 'topfill': 0, 'topline': 6, 'coladd': 0, 'skipcol': 0, 'curswant': 4}, winsaveview()) " remove all history entries ! for i in range(11) call histdel('/') endfor *** *** 477,490 " Do not call test_override("char_avail", 1) so that and work " regardless char_avail. new ! call setline(1, [' 1 the first', ' 2 the second', ' 3 the third']) set incsearch 1 call feedkeys("/the\\\", 'tx') call assert_equal(' 3 the third', getline('.')) $ call feedkeys("?the", 'tx') ! call assert_equal(' 2 the second', getline('.')) " clean up set noincsearch bw! --- 481,494 " Do not call test_override("char_avail", 1) so that and work " regardless char_avail. new ! call setline(1, [' 1 the first', ' 2 the second', ' 3 the third', '']) set incsearch 1 call feedkeys("/the\\\", 'tx') call assert_equal(' 3 the third', getline('.')) $ call feedkeys("?the", 'tx') ! call assert_equal(' 1 the first', getline('.')) " clean up set noincsearch bw! *** ../vim-8.1.1703/src/version.c 2019-07-16 21:19:51.502239956 +0200 --- src/version.c 2019-07-16 21:38:38.889472420 +0200 *** *** 779,780 --- 779,782 { /* Add new patch number below this line */ + /**/ + 1704, /**/ -- BRIDGEKEEPER: What is the air-speed velocity of an unladen swallow? ARTHUR: What do you mean? An African or European swallow? BRIDGEKEEPER: Er ... I don't know that ... Arrggghhh! BRIDGEKEEPER is cast into the gorge. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161939.x6GJd5oW015697%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1703
Patch 8.1.1703 Problem:Breaking out of loop by checking window pointer is insufficient. Solution: Check the window ID and the buffer number. (closes #4683) Files: src/misc2.c *** ../vim-8.1.1702/src/misc2.c 2019-07-07 14:05:18.097959237 +0200 --- src/misc2.c 2019-07-16 21:10:15.936319460 +0200 *** *** 4442,4448 void parse_queued_messages(void) { ! win_T *old_curwin = curwin; int i; int save_may_garbage_collect = may_garbage_collect; --- 4442,4449 void parse_queued_messages(void) { ! int old_curwin_id = curwin->w_id; ! int old_curbuf_fnum = curbuf->b_fnum; int i; int save_may_garbage_collect = may_garbage_collect; *** *** 4494,4502 may_garbage_collect = save_may_garbage_collect; ! // If the current window changed we need to bail out of the waiting loop. ! // E.g. when a job exit callback closes the terminal window. ! if (curwin != old_curwin) ins_char_typebuf(K_IGNORE); } #endif --- 4495,4503 may_garbage_collect = save_may_garbage_collect; ! // If the current window or buffer changed we need to bail out of the ! // waiting loop. E.g. when a job exit callback closes the terminal window. ! if (curwin->w_id != old_curwin_id || curbuf->b_fnum != old_curbuf_fnum) ins_char_typebuf(K_IGNORE); } #endif *** ../vim-8.1.1702/src/version.c 2019-07-16 20:12:41.461172432 +0200 --- src/version.c 2019-07-16 21:14:47.363400880 +0200 *** *** 779,780 --- 779,782 { /* Add new patch number below this line */ + /**/ + 1703, /**/ -- Q: What kind of stuff do you do? A: I collect hobbies. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161920.x6GJKC24011976%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1702
Patch 8.1.1702 Problem:Compiler warning for uninitialized variable. Solution: Initialize it. (Christian Brabandt) Files: src/gui.c *** ../vim-8.1.1701/src/gui.c 2019-07-12 19:22:19.463117807 +0200 --- src/gui.c 2019-07-16 20:10:39.369696938 +0200 *** *** 2253,2259 int col = gui.col; #ifdef FEAT_SIGN_ICONS int draw_sign = FALSE; ! int signcol; char_uextra[18]; # ifdef FEAT_NETBEANS_INTG int multi_sign = FALSE; --- 2253,2259 int col = gui.col; #ifdef FEAT_SIGN_ICONS int draw_sign = FALSE; ! int signcol = 0; char_uextra[18]; # ifdef FEAT_NETBEANS_INTG int multi_sign = FALSE; *** ../vim-8.1.1701/src/version.c 2019-07-16 20:00:08.548414886 +0200 --- src/version.c 2019-07-16 20:11:39.169439996 +0200 *** *** 779,780 --- 779,782 { /* Add new patch number below this line */ + /**/ + 1702, /**/ -- ARTHUR: No, hang on! Just answer the five questions ... GALAHAD: Three questions ... ARTHUR: Three questions ... And we shall watch ... and pray. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161813.x6GID0g6025276%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1670
Christian wrote: > On Fr, 12 Jul 2019, Bram Moolenaar wrote: > > > > > Patch 8.1.1670 > > Problem:Sign column not always properly aligned. > > Solution: Use "col" only after it was calculated. (Yee Cheng Chin, > > closes #4649) > > Files: src/gui.c > > After this patch I see a warning when compiling with > -Wmaybe-uninitialized: > > gui.c: In function ‘gui_outstr_nowrap’: > gui.c:2621:2: warning: ‘signcol’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > gui_mch_drawsign(gui.row, signcol, gui.highlight_mask); > ^~ > > > I don't really see, how signcol can be used uninitialized, but to shut > up the compiler, I suggest this patch: Thanks, I'll include it. -- Sorry, no fortune today. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161813.x6GID0Cp025270%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Patch 8.1.1701
Patch 8.1.1701 Problem:Appveyor build with MSVC fails puts progress bar in log. Solution: Adjust the sed command. (Ken Takata) Files: ci/appveyor.bat *** ../vim-8.1.1700/ci/appveyor.bat 2019-07-15 22:03:36.274725437 +0200 --- ci/appveyor.bat 2019-07-16 20:00:02.172442468 +0200 *** *** 22,40 ) .\gvim -u NONE -c "redir @a | ver |0put a | wq" ver_ming.txt echo "Building MSVC 64bit console Version" ! :: This doesn't work with @<< ! :: sed -e "s/\$(LINKARGS2)/\$(LINKARGS2) | sed -e 's#.*r.*##'/" Make_mvc.mak > Make_mvc2.mak ! nmake -f Make_mvc.mak CPU=AMD64 OLE=no GUI=no IME=yes ICONV=yes DEBUG=no FEATURES=%FEATURE% || exit 1 ! nmake -f Make_mvc.mak clean :: build MSVC huge version with python and channel support :: GUI needs to be last, so that testing works echo "Building MSVC 64bit GUI Version" if "%FEATURE%" == "HUGE" ( ! nmake -f Make_mvc.mak DIRECTX=yes CPU=AMD64 CHANNEL=yes OLE=no GUI=yes IME=yes ICONV=yes DEBUG=no PYTHON_VER=27 DYNAMIC_PYTHON=yes PYTHON=C:\Python27-x64 PYTHON3_VER=35 DYNAMIC_PYTHON3=yes PYTHON3=C:\Python35-x64 FEATURES=%FEATURE% || exit 1 ) ELSE ( ! nmake -f Make_mvc.mak CPU=AMD64 OLE=no GUI=yes IME=yes ICONV=yes DEBUG=no FEATURES=%FEATURE% || exit 1 ) .\gvim -u NONE -c "redir @a | ver |0put a | wq" ver_msvc.txt --- 22,41 ) .\gvim -u NONE -c "redir @a | ver |0put a | wq" ver_ming.txt + :: Filter out the progress bar from the build log + sed -e "s/@<<$/@<< | sed -e 's#.*r.*##'/" Make_mvc.mak > Make_mvc2.mak + echo "Building MSVC 64bit console Version" ! nmake -f Make_mvc2.mak CPU=AMD64 OLE=no GUI=no IME=yes ICONV=yes DEBUG=no FEATURES=%FEATURE% || exit 1 ! nmake -f Make_mvc2.mak clean :: build MSVC huge version with python and channel support :: GUI needs to be last, so that testing works echo "Building MSVC 64bit GUI Version" if "%FEATURE%" == "HUGE" ( ! nmake -f Make_mvc2.mak DIRECTX=yes CPU=AMD64 CHANNEL=yes OLE=no GUI=yes IME=yes ICONV=yes DEBUG=no PYTHON_VER=27 DYNAMIC_PYTHON=yes PYTHON=C:\Python27-x64 PYTHON3_VER=35 DYNAMIC_PYTHON3=yes PYTHON3=C:\Python35-x64 FEATURES=%FEATURE% || exit 1 ) ELSE ( ! nmake -f Make_mvc2.mak CPU=AMD64 OLE=no GUI=yes IME=yes ICONV=yes DEBUG=no FEATURES=%FEATURE% || exit 1 ) .\gvim -u NONE -c "redir @a | ver |0put a | wq" ver_msvc.txt *** ../vim-8.1.1700/src/version.c 2019-07-15 23:02:10.039954907 +0200 --- src/version.c 2019-07-16 19:58:26.964854681 +0200 *** *** 779,780 --- 779,782 { /* Add new patch number below this line */ + /**/ + 1701, /**/ -- ROBIN: (warily) And if you get a question wrong? ARTHUR: You are cast into the Gorge of Eternal Peril. ROBIN: Oh ... wacho! "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161800.x6GI0cS1022330%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1670
On Fr, 12 Jul 2019, Bram Moolenaar wrote: > > Patch 8.1.1670 > Problem:Sign column not always properly aligned. > Solution: Use "col" only after it was calculated. (Yee Cheng Chin, > closes #4649) > Files:src/gui.c After this patch I see a warning when compiling with -Wmaybe-uninitialized: gui.c: In function ‘gui_outstr_nowrap’: gui.c:2621:2: warning: ‘signcol’ may be used uninitialized in this function [-Wmaybe-uninitialized] gui_mch_drawsign(gui.row, signcol, gui.highlight_mask); ^~ I don't really see, how signcol can be used uninitialized, but to shut up the compiler, I suggest this patch: diff --git a/src/gui.c b/src/gui.c index e66581f52..2d5f80fd2 100644 --- a/src/gui.c +++ b/src/gui.c @@ -2253,7 +2253,7 @@ gui_outstr_nowrap( intcol = gui.col; #ifdef FEAT_SIGN_ICONS intdraw_sign = FALSE; -intsigncol; +intsigncol = 0; // shut up unitialized warning char_u extra[18]; # ifdef FEAT_NETBEANS_INTG intmulti_sign = FALSE; Best, Christian -- Niemand urteilt schärfer als der Ungebildete, er kennt weder Gründe noch Gegengründe. -- Anselm Feuerbach -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190716151446.GA21013%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1698
Ken Takata wrote: > 2019/7/16 Tue 15:27:48 UTC+9 Christian Brabandt wrote: > > On Mo, 15 Jul 2019, Bram Moolenaar wrote: > > > > > > > > I wrote: > > > > > > > Patch 8.1.1698 > > > > Problem:Appveyor build with MSVC fails. > > > > Solution: Remove the sed command > > > > Files: ci/appveyor.bat > > > > > > This solved the problem, but now we have the ugly progress bar output > > > back. Can this be disabled somehow? > > > > Pipe the linker output to the sed command, something like this: > > > > sed -e '/^< Make_mvc2.mak > > I suggest the following instead: > > sed -e "s/@<<$/@<< | sed -e 's#.*r.*##'/" Make_mvc.mak > Make_mvc2.mak > > The sed workaround should be added just after "link @<<". Ah, that's the part I was missing. The "link" command is supposed to only show progress with the /verbose flag, but apparently it happens anyway and I don't see a flags for "not verbose". -- VOICE OVER: As the horrendous Black Beast lunged forward, escape for Arthur and his knights seemed hopeless, when, suddenly ... the animator suffered a fatal heart attack. ANIMATOR: Agh! VOICE OVER: The cartoon peril was no more ... The Quest for Holy Grail could continue. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161501.x6GF1pXx024278%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1692
Ken Takata wrote: > 2019/7/15 Mon 1:23:21 UTC+9 Bram Moolenaar wrote: > > Patch 8.1.1692 > > Problem:Using *{} for literal dict is not backwards compatible. > > (Yasuhiro > > Matsumoto) > > Solution: Use ~{} instead. > > Files: runtime/doc/eval.txt runtime/doc/popup.txt, src/eval.c, > > src/testdir/test_listdict.vim src/testdir/test_popupwin.vim, > > src/testdir/dumps/Test_popupwin_07.dump, > > src/testdir/dumps/Test_popupwin_mask_2.dump, > > src/testdir/dumps/Test_popupwin_mask_3.dump, > > src/testdir/dumps/Test_popupwin_mask_4.dump, > > src/testdir/dumps/Test_popupwin_mask_5.dump, > > src/testdir/dumps/Test_popupwin_scroll_2.dump, > > src/testdir/dumps/Test_popupwin_scroll_3.dump, > > src/testdir/dumps/Test_popupwin_scroll_4.dump > > I personally prefer #{} than ~{}. > '~' is used as a bitwise not operator in C. So, when I see ~{}, I would doubt > if it is a bitwise not of {}. (Vim script doesn't have a ~ operator, though.) > Dictionary is called as hash in some other languages, and # is also called > hash. So, #{} might be easy to remember. And I don't think that #{} have a > compatibility problem. I like the connection with # being "hash", used for a hashtable. Only downside is that it is used as a comment marker in other languages. Well, I suppose we'll never use # for a comment in Vim (considering it being used for the alternate file: ":e #"). -- BEDEVERE: Look! It's the old man from scene 24 - what's he Doing here? ARTHUR: He is the keeper of the Bridge. He asks each traveler five questions ... GALAHAD: Three questions. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/201907161501.x6GF1pIU024284%40masaka.moolenaar.net. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1698
Hi, 2019/7/16 Tue 16:26:55 UTC+9 Ken Takata wrote: > Hi, > > 2019/7/16 Tue 15:27:48 UTC+9 Christian Brabandt wrote: > > On Mo, 15 Jul 2019, Bram Moolenaar wrote: > > > > > > > > I wrote: > > > > > > > Patch 8.1.1698 > > > > Problem:Appveyor build with MSVC fails. > > > > Solution: Remove the sed command > > > > Files: ci/appveyor.bat > > > > > > This solved the problem, but now we have the ugly progress bar output > > > back. Can this be disabled somehow? > > > > Pipe the linker output to the sed command, something like this: > > > > sed -e '/^< Make_mvc2.mak > > I suggest the following instead: > > sed -e "s/@<<$/@<< | sed -e 's#.*r.*##'/" Make_mvc.mak > Make_mvc2.mak > > The sed workaround should be added just after "link @<<". > > > > However Ken just mentioned, that the sed workaround isn't needed > > anymore, so I am confused whether this is still a problem? > > > > https://github.com/vim/vim-win32-installer/pull/139/commits/7212b47f60a58531b80b2edd6c146dc1f4b9bba7 > > The progress counter is not shown on the AppVeyor's Web interface, but it > remains in the log file downloaded from AppVeyor. I created a PR for this to see if this actually works: https://github.com/vim/vim/pull/4684 Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/f1bbde50-5ad5-4072-befd-3c1e9ad83bd5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1698
Hi, 2019/7/16 Tue 15:27:48 UTC+9 Christian Brabandt wrote: > On Mo, 15 Jul 2019, Bram Moolenaar wrote: > > > > > I wrote: > > > > > Patch 8.1.1698 > > > Problem:Appveyor build with MSVC fails. > > > Solution: Remove the sed command > > > Files:ci/appveyor.bat > > > > This solved the problem, but now we have the ugly progress bar output > > back. Can this be disabled somehow? > > Pipe the linker output to the sed command, something like this: > > sed -e '/^< Make_mvc2.mak I suggest the following instead: sed -e "s/@<<$/@<< | sed -e 's#.*r.*##'/" Make_mvc.mak > Make_mvc2.mak The sed workaround should be added just after "link @<<". > However Ken just mentioned, that the sed workaround isn't needed > anymore, so I am confused whether this is still a problem? > > https://github.com/vim/vim-win32-installer/pull/139/commits/7212b47f60a58531b80b2edd6c146dc1f4b9bba7 The progress counter is not shown on the AppVeyor's Web interface, but it remains in the log file downloaded from AppVeyor. Regards, Ken Takata -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/cd3c87ca-1dc1-4aa3-bbdf-f46a3a4cdb47%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Patch 8.1.1698
On Mo, 15 Jul 2019, Bram Moolenaar wrote: > > I wrote: > > > Patch 8.1.1698 > > Problem:Appveyor build with MSVC fails. > > Solution: Remove the sed command > > Files: ci/appveyor.bat > > This solved the problem, but now we have the ugly progress bar output > back. Can this be disabled somehow? Pipe the linker output to the sed command, something like this: sed -e '/^< Make_mvc2.mak However Ken just mentioned, that the sed workaround isn't needed anymore, so I am confused whether this is still a problem? https://github.com/vim/vim-win32-installer/pull/139/commits/7212b47f60a58531b80b2edd6c146dc1f4b9bba7 Best, Christian -- Der Zuschauer ist nur eine begrenzte Zeit verarschbar. -- Oliver Kalkofe -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20190716062746.GP31610%40256bit.org. For more options, visit https://groups.google.com/d/optout.
Re: Popup window functionality implemented
Great, this is going to be useful! Thanks for this great work! On Thursday, 4 July 2019 20:34:47 UTC+5:30, Bram Moolenaar wrote: > Most of the popup window support has now been implemented. There are a > few things to improve and add, but it should be good enough to use. > > Please give it a try and look out for things that don't work properly. > We can still make some changes where needed, but soon making changes > that are not backwards compatible will cause trouble. > > I decided to keep the details about the popup window functions in > popup.txt, instead of moving them to eval.txt. That file has become too > big and listing all the functions there does not make much sense. The > alphabetical list can still be used to search for something, and the > index by functionality is at ":help function-list". > > I'll also move the terminal functions. We can do more, but some > functions don't have a good help file to move to. > > -- > What the word 'politics' means: 'Poli' in Latin meaning 'many' and 'tics' > meaning 'bloodsucking creatures'. > > /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ > ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ > \\\ an exciting new programming language -- http://www.Zimbu.org/// > \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/2e1c615e-a1bb-4468-a91b-cf08eb2f74e1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.