Re: Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)

2023-08-15 Fir de Conversatie Christian Brabandt


On Mo, 14 Aug 2023, Adri Verhoef wrote:

> > Op 13-08-2023 10:45 CEST schreef Christian Brabandt :
> [..]
> > diff --git a/runtime/doc/intro.txt b/runtime/doc/intro.txt
> [..]
> > @@ -216,7 +217,7 @@ Vim would never have become what it is now, without the 
> > help of these people!
> > Bill Foster Athena GUI port (later removed)
> > Google  Lets me work on Vim one day a week
> 
> I noticed this: "Lets me work".  Bram worked for Google for 15 years, until 
> September 2021.
> Shouldn't this "Lets me" be past tense then, like "Let Bram"?  Alternatively: 
> "Letting Bram".

Fixed in https://github.com/vim/vim/pull/12790

> 
> > diff --git a/LICENSE b/LICENSE
> [..]
> > @@ -21,8 +21,8 @@ II) It is allowed to distribute a modified (or extended) 
> > version of Vim,
> >maintainer will do with your changes and under what license they
> >will be distributed is negotiable.  If there has been no 
> > negotiation
> >then this license, or a later version, also applies to your 
> > changes.
> > -  The current maintainer is Bram Moolenaar .  If this
> > -  changes it will be announced in appropriate places (most likely
> > +  The current maintainers are listed here: 
> > https://github.com/orgs/vim/people.
> > +  If this changes it will be announced in appropriate places (most 
> > likely
> >vim.sf.net, www.vim.org and/or comp.editors). When it is 
> > completely
> >impossible to contact the maintainer, the obligation to send him
> >your changes ceases.  Once the maintainer has confirmed that he 
> > has
> 
> Above it says: "The current maintainers are listed".
> 
> As we can see, that's plural.  Let's watch out for the word "maintainer" then.
> 
> Let's also have another look at the lines above.
> 
> "It is allowed to distribute a modified (or extended) version of Vim",
> that's singular ("version of Vim").  Then the next lines: "maintainer will do
> with your changes and under what license they will be distributed is 
> negotiable".
> I think this can be split into two parts: the part where the changes are 
> mentioned
> and the part where the license of the version is discussed.  'The changes'
> might be plural, but 'the version' is singular.  So shouldn't this be "the
> maintainers will do with your changes and under what license that version"
> (trying to avoid the word 'it' or 'they' after "under what license") then?
> 
> Possibly, the following lines:
> 
> "impossible to contact the maintainer, the obligation to send him
> your changes ceases.  Once the maintainer has confirmed that he has"
> 
> should then be changed into:
> 
> "impossible to contact the maintainers, the obligation to send them
> your changes ceases.  Once the maintainers have confirmed that they have"
> 
> There are more locations where "maintainer" is mentioned.  Should I list them?
> 
> The same text appears in file uganda.txt:

Yes, uganda.txt is basically a copy of the license files. I am a bit 
hesitant to change this, as I don't want to change the license more than 
necessary. https://github.com/vim/vim/pull/12749#issuecomment-1678066341

> 
> > diff --git a/runtime/doc/uganda.txt b/runtime/doc/uganda.txt
> [..]
> > @@ -46,8 +46,8 @@ II) It is allowed to distribute a modified (or extended) 
> > version of Vim,
> >   maintainer will do with your changes and under what license they
> >   will be distributed is negotiable.  If there has been no negotiation
> >   then this license, or a later version, also applies to your changes.
> > - The current maintainer is Bram Moolenaar .  If this
> > - changes it will be announced in appropriate places (most likely
> > + The current maintainers are listed here: 
> > https://github.com/orgs/vim/people.
> > + If this changes it will be announced in appropriate places (most 
> > likely
> >   vim.sf.net, www.vim.org and/or comp.editors).  When it is completely
> >   impossible to contact the maintainer, the obligation to send him
> >   your changes ceases.  Once the maintainer has confirmed that he has
> 
> So the same remarks apply. :-)
> 
> This wasn't changed yet:
> 
> > diff --git a/runtime/indent/README.txt b/runtime/indent/README.txt
> [..]
> >  If you have remarks about an existing file, send them to the maintainer of
> >  that file.  Only when you get no response send a message to b...@vim.org.

fixed in 
https://github.com/vim/vim/commit/96d6c4aabed15266bc4acfa66f9b35c2820dfa59

> 
> That should possibly be changed into:
> "get no response send a message to the vim-dev mailing list 
> ."
> 
> The word "me" is also 'suspect':
> 
> > diff --git a/runtime/syntax/model.vim b/runtime/syntax/model.vim
> [..]
> > -" Maintainer:  Bram Moolenaar 
> > -" Last Change: 2005 Jun 20
> > +" Maintainer:  The Vim Project 
> > +" Last Change: 2023 Aug 10
> > +" Former Maintainer:   Bram 

Re: Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)

2023-08-14 Fir de Conversatie Adri Verhoef
> Op 13-08-2023 10:45 CEST schreef Christian Brabandt :
[..]
> diff --git a/runtime/doc/intro.txt b/runtime/doc/intro.txt
[..]
> @@ -216,7 +217,7 @@ Vim would never have become what it is now, without the 
> help of these people!
>   Bill Foster Athena GUI port (later removed)
>   Google  Lets me work on Vim one day a week

I noticed this: "Lets me work".  Bram worked for Google for 15 years, until 
September 2021.
Shouldn't this "Lets me" be past tense then, like "Let Bram"?  Alternatively: 
"Letting Bram".

> diff --git a/LICENSE b/LICENSE
[..]
> @@ -21,8 +21,8 @@ II) It is allowed to distribute a modified (or extended) 
> version of Vim,
>maintainer will do with your changes and under what license they
>will be distributed is negotiable.  If there has been no 
> negotiation
>then this license, or a later version, also applies to your 
> changes.
> -  The current maintainer is Bram Moolenaar .  If this
> -  changes it will be announced in appropriate places (most likely
> +  The current maintainers are listed here: 
> https://github.com/orgs/vim/people.
> +  If this changes it will be announced in appropriate places (most 
> likely
>vim.sf.net, www.vim.org and/or comp.editors). When it is completely
>impossible to contact the maintainer, the obligation to send him
>your changes ceases.  Once the maintainer has confirmed that he has

Above it says: "The current maintainers are listed".

As we can see, that's plural.  Let's watch out for the word "maintainer" then.

Let's also have another look at the lines above.

"It is allowed to distribute a modified (or extended) version of Vim",
that's singular ("version of Vim").  Then the next lines: "maintainer will do
with your changes and under what license they will be distributed is 
negotiable".
I think this can be split into two parts: the part where the changes are 
mentioned
and the part where the license of the version is discussed.  'The changes'
might be plural, but 'the version' is singular.  So shouldn't this be "the
maintainers will do with your changes and under what license that version"
(trying to avoid the word 'it' or 'they' after "under what license") then?

Possibly, the following lines:

"impossible to contact the maintainer, the obligation to send him
your changes ceases.  Once the maintainer has confirmed that he has"

should then be changed into:

"impossible to contact the maintainers, the obligation to send them
your changes ceases.  Once the maintainers have confirmed that they have"

There are more locations where "maintainer" is mentioned.  Should I list them?

The same text appears in file uganda.txt:

> diff --git a/runtime/doc/uganda.txt b/runtime/doc/uganda.txt
[..]
> @@ -46,8 +46,8 @@ II) It is allowed to distribute a modified (or extended) 
> version of Vim,
> maintainer will do with your changes and under what license they
> will be distributed is negotiable.  If there has been no negotiation
> then this license, or a later version, also applies to your changes.
> -   The current maintainer is Bram Moolenaar .  If this
> -   changes it will be announced in appropriate places (most likely
> +   The current maintainers are listed here: 
> https://github.com/orgs/vim/people.
> +   If this changes it will be announced in appropriate places (most 
> likely
> vim.sf.net, www.vim.org and/or comp.editors).  When it is completely
> impossible to contact the maintainer, the obligation to send him
> your changes ceases.  Once the maintainer has confirmed that he has

So the same remarks apply. :-)

This wasn't changed yet:

> diff --git a/runtime/indent/README.txt b/runtime/indent/README.txt
[..]
>  If you have remarks about an existing file, send them to the maintainer of
>  that file.  Only when you get no response send a message to b...@vim.org.

That should possibly be changed into:
"get no response send a message to the vim-dev mailing list ."

The word "me" is also 'suspect':

> diff --git a/runtime/syntax/model.vim b/runtime/syntax/model.vim
[..]
> -" Maintainer:Bram Moolenaar 
> -" Last Change:   2005 Jun 20
> +" Maintainer:The Vim Project 
> +" Last Change:   2023 Aug 10
> +" Former Maintainer: Bram Moolenaar 
>  
>  " very basic things only (based on the vgrindefs file).
>  " If you use this language, please improve it, and send me the patches!

Maybe change "me" into "us"?

> diff --git a/src/po/README.txt b/src/po/README.txt
[..]
>  You should include your name and E-mail address instead, for example:

Shouldn't this just be "e-mail" instead of "E-mail"?

The same applies here:

> diff --git a/src/po/README_mingw.txt b/src/po/README_mingw.txt
[..]
>  You should include your name and E-mail address instead, for example:

Adri
PS Great that you've taken up the project!

Re: Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)

2023-08-13 Fir de Conversatie Christ van Willegen
Hi,

Whilst scrolling through the patch, my eye fell on:

index 649870636..8628ecccb 100644
--- a/runtime/indent/README.txt
+++ b/runtime/indent/README.txt
@@ -6,9 +6,9 @@ at ":help indent-expression".  Looking at the existing
files should give you
 inspiration.

 If you make a new indent file which would be useful for others, please
send it
-to b...@vim.org.  Include instructions for detecting the file type for this
-language, by file name extension or by checking a few lines in the file.
-And please stick to the rules below.
+to the vim-dev mailing list .  Include instructions for
+detecting the file type for this language, by file name extension or by
+checking a few lines in the file. And please stick to the rules below.

 If you have remarks about an existing file, send them to the maintainer of
 that file.  Only when you get no response send a message to b...@vim.org.



A similar message is in the syntax/README, IIRC...

Christ van Willegen

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CA%2BOt1OzxY0XFs7YfA1_G-g%2B88pQ7cVyeQbWwnE19DEqZOMBvhQ%40mail.gmail.com.


Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)

2023-08-13 Fir de Conversatie Christian Brabandt
Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)

Commit: 
https://github.com/vim/vim/commit/e978b4534a5e10471108259118c0ef791106fd92
Author: Christian Brabandt 
Date:   Sun Aug 13 10:33:05 2023 +0200

Farewell to Bram and dedicate upcoming Vim 9.1 to him 
(https://github.com/vim/vim/issues/12749)

* Dedicate upcoming Vim 9.1 to Bram

Also replace in a few more places Brams email address and mention new
maintainers.

* Remove Bram from any Maintainer role

* runtime: Align Header

* it's mailing list not mailinglist

diff --git a/LICENSE b/LICENSE
index ecfbe5534..6c5c05b01 100644
--- a/LICENSE
+++ b/LICENSE
@@ -21,8 +21,8 @@ II) It is allowed to distribute a modified (or extended) 
version of Vim,
   maintainer will do with your changes and under what license they
   will be distributed is negotiable.  If there has been no negotiation
   then this license, or a later version, also applies to your changes.
-  The current maintainer is Bram Moolenaar .  If this
-  changes it will be announced in appropriate places (most likely
+  The current maintainers are listed here: 
https://github.com/orgs/vim/people.
+  If this changes it will be announced in appropriate places (most 
likely
   vim.sf.net, www.vim.org and/or comp.editors). When it is completely
   impossible to contact the maintainer, the obligation to send him
   your changes ceases.  Once the maintainer has confirmed that he has
diff --git a/README.md b/README.md
index 5a11cf007..8fec70917 100644
--- a/README.md
+++ b/README.md
@@ -141,14 +141,14 @@ If you still have problems or any other questions, use 
one of the mailing
 lists to discuss them with Vim users and developers:
https://www.vim.org/maillist.php
 
-If nothing else works, report bugs directly:
-   Bram Moolenaar 
+If nothing else works, report bugs directly to the vim-dev mailing list:
+   
 
 
 ## Main author ##
 
-Send any other comments, patches, flowers and suggestions to:
-   Bram Moolenaar 
+Send any other comments, patches, flowers and suggestions to the vim-dev 
mailing list:
+   
 
 
 This is `README.md` for version 9.0 of Vim: Vi IMproved.
diff --git a/README.txt b/README.txt
index ce3ed73bc..2c692f0a3 100644
--- a/README.txt
+++ b/README.txt
@@ -122,12 +122,12 @@ If you still have problems or any other questions, use 
one of the mailing
 lists to discuss them with Vim users and developers:
https://www.vim.org/maillist.php
 
-If nothing else works, report bugs directly:
-   Bram Moolenaar 
+If nothing else works, report bugs directly to the vim-dev mailing list:
+   
 
 
 MAIN AUTHOR
 
-Send any other comments, patches, flowers and suggestions to:
+Send any other comments, patches, flowers and suggestions to the vim-dev 
mailing list:
 
-   Bram Moolenaar  E-mail: b...@vim.org
+   
diff --git a/runtime/autoload/ccomplete.vim b/runtime/autoload/ccomplete.vim
index 3bddba7a9..7096dcf4a 100644
--- a/runtime/autoload/ccomplete.vim
+++ b/runtime/autoload/ccomplete.vim
@@ -1,10 +1,11 @@
 vim9script noclear
 
 # Vim completion script
-# Language: C
-# Maintainer:   Bram Moolenaar 
+# Language:C
+# Maintainer:  The Vim Project 
+# Last Change: 2023 Aug 10
 #  Rewritten in Vim9 script by github user lacygoill
-# Last Change:  2022 Jan 31
+# Former Maintainer:   Bram Moolenaar 
 
 var prepended: string
 var grepCache: dict>>
diff --git a/runtime/autoload/dist/ft.vim b/runtime/autoload/dist/ft.vim
index 173588393..9f53f6846 100644
--- a/runtime/autoload/dist/ft.vim
+++ b/runtime/autoload/dist/ft.vim
@@ -2,8 +2,9 @@ vim9script
 
 # Vim functions for file type detection
 #
-# Maintainer:  Bram Moolenaar 
-# Last Change: 2023 Jun 09
+# Maintainer:  The Vim Project 
+# Last Change: 2023 Aug 10
+# Former Maintainer:   Bram Moolenaar 
 
 # These functions are moved here from runtime/filetype.vim to make startup
 # faster.
diff --git a/runtime/autoload/dist/script.vim b/runtime/autoload/dist/script.vim
index fa4b6e842..5f3ae4aec 100644
--- a/runtime/autoload/dist/script.vim
+++ b/runtime/autoload/dist/script.vim
@@ -3,8 +3,9 @@ vim9script
 # Vim function for detecting a filetype from the file contents.
 # Invoked from "scripts.vim" in 'runtimepath'
 #
-# Maintainer:  Bram Moolenaar 
-# Last Change: 2023 Jun 09
+# Maintainer:  The Vim Project 
+# Last Change: 2023 Aug 10
+# Former Maintainer:   Bram Moolenaar 
 
 export def DetectFiletype()
   var line1 = getline(1)
diff --git a/runtime/autoload/gzip.vim b/runtime/autoload/gzip.vim
index e4adec094..95dd90679 100644
--- a/runtime/autoload/gzip.vim
+++ b/runtime/autoload/gzip.vim
@@ -1,6 +1,7 @@
 " Vim autoload file for editing compressed files.
-" Maintainer: Bram Moolenaar 
-" Last Change: 2016 Sep 28
+" Maintainer:  The Vim Project