Re: Type conflicts when using --with-x on Mac OS X
Björn wrote: On 9 October 2010 19:24, Rainer Müller rai...@codingfarm.de wrote: Hello, as maintainer of vim in MacPorts I got a build failure report [1] when using './configure --with-x' (our +x11 variant): snip In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:49, from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:39, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:7, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:279: error: conflicting types for 'Boolean' /opt/local/include/X11/Intrinsic.h:158: error: previous declaration of 'Boolean' was here In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QD.h:42, from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:31, from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:9, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:115, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QuickdrawTypes.h:267: error: conflicting types for 'Cursor' /opt/local/include/X11/X.h:103: error: previous declaration of 'Cursor' was here make[1]: *** [objects/os_macosx.o] Error 1 snap This snippet is from my system with Mac OS X 10.6.4 (Snow Leopard) with xorg-libXt @1.0.8 and vim @7.3.11 As a solution for this, I added #define NO_X11_INCLUDES at the top of os_macosx.m to avoid the type conflict. Patch attached. I haven't got much to say about this except I have no objections against this patch, but it is up to Bram to merge it since os_macosx.m belongs to Vim and not MacVim. I asked Rainer to send this to the vim-mac list to get feedback if this was a good solution. I find it strange to not include X11 files when configure was run with --with-x. Also, building some .c files with different header files may lead to problems. Isn't there a better solution? -- Place mark here -[ ]- if you want a dirty monitor. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- You received this message from the vim_mac maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
Re: Type conflicts when using --with-x on Mac OS X
On 10 October 2010 11:34, Bram Moolenaar b...@moolenaar.net wrote: Björn wrote: On 9 October 2010 19:24, Rainer Müller rai...@codingfarm.de wrote: as maintainer of vim in MacPorts I got a build failure report [1] when using './configure --with-x' (our +x11 variant): snip As a solution for this, I added #define NO_X11_INCLUDES at the top of os_macosx.m to avoid the type conflict. Patch attached. I haven't got much to say about this except I have no objections against this patch, but it is up to Bram to merge it since os_macosx.m belongs to Vim and not MacVim. I asked Rainer to send this to the vim-mac list to get feedback if this was a good solution. I find it strange to not include X11 files when configure was run with --with-x. Also, building some .c files with different header files may lead to problems. Isn't there a better solution? I probably don't fully understand this issue, but my take is that nothing inside os_macosx.m does (or should) depend on X11 include files so it seems perfectly safe (and correct) not to include them. Am I missing something? Björn -- You received this message from the vim_mac maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
Re: Type conflicts when using --with-x on Mac OS X
Björn wrote: On 9 October 2010 19:24, Rainer Müller rai...@codingfarm.de wrote: as maintainer of vim in MacPorts I got a build failure report [1] when using './configure --with-x' (our +x11 variant): snip As a solution for this, I added #define NO_X11_INCLUDES at the top of os_macosx.m to avoid the type conflict. Patch attached. I haven't got much to say about this except I have no objections against this patch, but it is up to Bram to merge it since os_macosx.m belongs to Vim and not MacVim. I asked Rainer to send this to the vim-mac list to get feedback if this was a good solution. I find it strange to not include X11 files when configure was run with --with-x. Also, building some .c files with different header files may lead to problems. Isn't there a better solution? I probably don't fully understand this issue, but my take is that nothing inside os_macosx.m does (or should) depend on X11 include files so it seems perfectly safe (and correct) not to include them. Am I missing something? It's also in the _conv file. I'll make a patch, let me know if it causes any problems. -- hundred-and-one symptoms of being an internet addict: 258. When you want to see your girlfriend, you surf to her homepage. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\download, build and distribute -- http://www.A-A-P.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- You received this message from the vim_mac maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
Type conflicts when using --with-x on Mac OS X
Hello, as maintainer of vim in MacPorts I got a build failure report [1] when using './configure --with-x' (our +x11 variant): snip In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:49, from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:39, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:7, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:279: error: conflicting types for 'Boolean' /opt/local/include/X11/Intrinsic.h:158: error: previous declaration of 'Boolean' was here In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QD.h:42, from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:31, from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:9, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:115, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QuickdrawTypes.h:267: error: conflicting types for 'Cursor' /opt/local/include/X11/X.h:103: error: previous declaration of 'Cursor' was here make[1]: *** [objects/os_macosx.o] Error 1 snap This snippet is from my system with Mac OS X 10.6.4 (Snow Leopard) with xorg-libXt @1.0.8 and vim @7.3.11 As a solution for this, I added #define NO_X11_INCLUDES at the top of os_macosx.m to avoid the type conflict. Patch attached. Rainer [1] Original report: http://trac.macports.org/ticket/26744 -- You received this message from the vim_mac maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- src/os_macosx.m.orig2010-10-08 01:53:04.0 +0200 +++ src/os_macosx.m 2010-10-08 01:53:18.0 +0200 @@ -15,6 +15,7 @@ Error: MACOS 9 is no longer supported in Vim 7 #endif +#define NO_X11_INCLUDES #include vim.h #import Cocoa/Cocoa.h
Re: Type conflicts when using --with-x on Mac OS X
On 9 October 2010 19:24, Rainer Müller rai...@codingfarm.de wrote: Hello, as maintainer of vim in MacPorts I got a build failure report [1] when using './configure --with-x' (our +x11 variant): snip In file included from /System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:49, from /System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:39, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:7, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:279: error: conflicting types for 'Boolean' /opt/local/include/X11/Intrinsic.h:158: error: previous declaration of 'Boolean' was here In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QD.h:42, from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:31, from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:9, from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:115, from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:13, from os_macosx.m:20: /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QuickdrawTypes.h:267: error: conflicting types for 'Cursor' /opt/local/include/X11/X.h:103: error: previous declaration of 'Cursor' was here make[1]: *** [objects/os_macosx.o] Error 1 snap This snippet is from my system with Mac OS X 10.6.4 (Snow Leopard) with xorg-libXt @1.0.8 and vim @7.3.11 As a solution for this, I added #define NO_X11_INCLUDES at the top of os_macosx.m to avoid the type conflict. Patch attached. I haven't got much to say about this except I have no objections against this patch, but it is up to Bram to merge it since os_macosx.m belongs to Vim and not MacVim. Björn -- You received this message from the vim_mac maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
