Re: [PATCH 0/2] virtio_ccw: minor enhancements
"Michael S. Tsirkin" writes: > Hi Rusty, I guess you are busy. > > I'd like to send all these patch series combined to Linus. To see what > I have queued, you can check the vhost-next branch in my tree. > > Will wait until tomorrow to give you a chance to respond. Hi Michael, Indeed, this is the last week of my sabbatical. I am back full time next week. See my Ack on your patches. Thanks. Rusty. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [PATCH 0/2] virtio_ccw: minor enhancements
On Tue, 9 Dec 2014 20:50:35 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 09, 2014 at 06:27:53PM +0100, Cornelia Huck wrote: > > On Tue, 9 Dec 2014 15:53:32 +0200 > > "Michael S. Tsirkin" wrote: > > > > > Two enhancements for virtio_ccw, on top of latest 1.0 patchset > > > > > > Cornelia Huck (1): > > > virtio_ccw: finalize_features error handling > > > > > > Michael S. Tsirkin (1): > > > virtio_ccw: future-proof finalize_features > > > > > > drivers/s390/kvm/virtio_ccw.c | 18 +++--- > > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > > > > I tried to run this as a guest kernel with my virtio-1 qemu branch + > > your revision patch on top and it at least boots :) More testing > > tomorrow. > > It's best if you pick my tree from git. > vhost-next branch. > FWIW: Your current vhost-next branch + my qemu with the known bugs seems to hold up well so far; the endianness swap does not seem to cause a noticeable performance hit (the problems come from my qemu code dropping feature bits...) Take this with a grain of salt as current qemu virtio-1 has known problems, but I don't think there are major reasons speaking against inclusion. At least, I don't think there's anything in there we can't easily fix up later. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH RFC v5 18/19] virtio: support revision-specific features
On Tue, 2 Dec 2014 14:00:26 +0100 Cornelia Huck wrote: > Devices may support different sets of feature bits depending on which > revision they're operating at. Let's give the transport a way to > re-query the device about its features when the revision has been > changed. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw.c | 12 ++-- > hw/virtio/virtio-bus.c | 14 -- > include/hw/virtio/virtio-bus.h |3 +++ > include/hw/virtio/virtio.h |3 +++ > 4 files changed, 28 insertions(+), 4 deletions(-) There seems to be something wrong with this patch - I noticed when I fixed prop_bit64. Needs debugging. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Re: [Qemu-devel] [PATCH RFC v5 05/19] virtio: support more feature bits
On Tue, 2 Dec 2014 14:00:13 +0100
Cornelia Huck wrote:
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 070006c..23d713b 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -51,6 +51,17 @@ extern PropertyInfo qdev_prop_arraylen;
> .defval= (bool)_defval, \
> }
>
> +#define DEFINE_PROP_BIT64(_name, _state, _field, _bit, _defval) { \
> +.name = (_name),\
> +.info = &(qdev_prop_bit), \
> +.bitnr= (_bit), \
> +.offset= offsetof(_state, _field)\
> ++ type_check(uint64_t,typeof_field(_state, _field)), \
> +.qtype = QTYPE_QBOOL,\
> +.defval= (bool)_defval, \
> +}
> +
> +
> #define DEFINE_PROP_BOOL(_name, _state, _field, _defval) { \
> .name = (_name),\
> .info = &(qdev_prop_bool), \
This one is of course broken. I'll send an updated patch tomorrow.
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
