Re: [PATCH libinput] fix spelling mistakes

2016-04-05 Thread Peter Hutterer 
On Sun, Apr 03, 2016 at 01:47:43AM +0100, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom 

applied, thanks.

Cheers,
   Peter

> ---
>  doc/t440-support.dox | 2 +-
>  src/evdev-tablet.c   | 2 +-
>  src/evdev.c  | 2 +-
>  src/filter.c | 2 +-
>  src/libinput.h   | 8 
>  5 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/t440-support.dox b/doc/t440-support.dox
> index 652a6d0..f4ce3ed 100644
> --- a/doc/t440-support.dox
> +++ b/doc/t440-support.dox
> @@ -70,7 +70,7 @@ digraph top_button_routing
>   touchpad -> libinput_tp [color="red4"]
>  
>   events_tp [label="other touchpad events"];
> - events_topbutton [label="top sofware button events"];
> + events_topbutton [label="top software button events"];
>  
>   libinput_tp -> events_tp [arrowhead="none"]
>   libinput_ts -> events_topbutton [color="red4"]
> diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c
> index 7359881..9a1ac52 100644
> --- a/src/evdev-tablet.c
> +++ b/src/evdev-tablet.c
> @@ -516,7 +516,7 @@ tablet_check_notify_axes(struct tablet_dispatch *tablet,
>   axes.tilt.x = 0;
>   axes.tilt.y = 0;
>  
> - /* tilt is already coverted to left-handed, so mouse
> + /* tilt is already converted to left-handed, so mouse
>* rotation is converted to left-handed automatically */
>   } else {
>   axes.rotation = tablet_handle_artpen_rotation(tablet, device);
> diff --git a/src/evdev.c b/src/evdev.c
> index a5c965d..6bb8986 100644
> --- a/src/evdev.c
> +++ b/src/evdev.c
> @@ -1306,7 +1306,7 @@ fallback_dispatch_create(struct libinput_device *device)
>   evdev_init_sendevents(evdev_device, dispatch);
>  
>   /* BTN_MIDDLE is set on mice even when it's not present. So
> -  * we can only use the absense of BTN_MIDDLE to mean something, i.e.
> +  * we can only use the absence of BTN_MIDDLE to mean something, i.e.
>* we enable it by default on anything that only has L
>* If we have L and no middle, we don't expose it as config
>* option */
> diff --git a/src/filter.c b/src/filter.c
> index 4c39b0e..cf8996d 100644
> --- a/src/filter.c
> +++ b/src/filter.c
> @@ -690,7 +690,7 @@ touchpad_lenovo_x230_accel_profile(struct motion_filter 
> *filter,
>* trial-and-error. No other meaning should be interpreted.
>* The calculation is a compressed form of
>* pointer_accel_profile_linear(), look at the git history of that
> -  * function for an explaination of what the min/max/etc. does.
> +  * function for an explanation of what the min/max/etc. does.
>*/
>   speed_in *= X230_MAGIC_SLOWDOWN / X230_TP_MAGIC_LOW_RES_FACTOR;
>  
> diff --git a/src/libinput.h b/src/libinput.h
> index 819efa8..3449611 100644
> --- a/src/libinput.h
> +++ b/src/libinput.h
> @@ -1340,7 +1340,7 @@ libinput_event_gesture_get_scale(struct 
> libinput_event_gesture *event);
>   *
>   * The angle delta is defined as the change in angle of the line formed by
>   * the 2 fingers of a pinch gesture. Clockwise rotation is represented
> - * by a postive delta, counter-clockwise by a negative delta. If e.g. the
> + * by a positive delta, counter-clockwise by a negative delta. If e.g. the
>   * fingers are on the 12 and 6 location of a clock face plate and they move
>   * to the 1 resp. 7 location in a single event then the angle delta is
>   * 30 degrees.
> @@ -2308,7 +2308,7 @@ libinput_get_event(struct libinput *libinput);
>   *
>   * @param libinput A previously initialized libinput context
>   * @return The event type of the next available event or @ref
> - * LIBINPUT_EVENT_NONE if no event is availble.
> + * LIBINPUT_EVENT_NONE if no event is available.
>   */
>  enum libinput_event_type
>  libinput_next_event_type(struct libinput *libinput);
> @@ -3590,7 +3590,7 @@ enum libinput_config_accel_profile {
>   *
>   * @param device The device to configure
>   *
> - * @return A bitmask of all configurable modes availble on this device.
> + * @return A bitmask of all configurable modes available on this device.
>   */
>  uint32_t
>  libinput_device_config_accel_get_profiles(struct libinput_device *device);
> @@ -4234,7 +4234,7 @@ enum libinput_config_dwt_state {
>   * @ingroup config
>   *
>   * Check if this device supports configurable disable-while-typing feature.
> - * This feature is usally available on built-in touchpads and disables the
> + * This feature is usually available on built-in touchpads and disables the
>   * touchpad while typing. See @ref disable-while-typing for details.
>   *
>   * @param device The device to configure
> -- 
> 2.8.0
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Pekka Paalanen 
On Tue, 5 Apr 2016 09:28:11 -0500
Yong Bakos <j...@humanoriented.com> wrote:

> > On Apr 5, 2016, at 3:52 AM, Pekka Paalanen <ppaala...@gmail.com> wrote:
> > 
> > On Mon, 4 Apr 2016 17:55:29 -0500
> > Yong Bakos <j...@humanoriented.com> wrote:
> >   
> >>> Date: Sun,  3 Apr 2016 01:47:43 +0100
> >>> From: Eric Engestrom <e...@engestrom.ch>
> >>> To: wayland-devel@lists.freedesktop.org
> >>> Cc: Eric Engestrom <e...@engestrom.ch>
> >>> Subject: [PATCH libinput] fix spelling mistakes
> >>> Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch>
> >>> 
> >>> Signed-off-by: Eric Engestrom <e...@engestrom.ch>
> >>> ---
> >>> doc/t440-support.dox | 2 +-
> >>> src/evdev-tablet.c   | 2 +-
> >>> src/evdev.c  | 2 +-
> >>> src/filter.c | 2 +-
> >>> src/libinput.h   | 8 
> >>> 5 files changed, 8 insertions(+), 8 deletions(-)
> >>>   
> >   
> >> 
> >> Looks good, thanks. (Note that I am a novice reviewer.)  
> > 
> > Hi Yong,
> > 
> > thank you for participating!
> > 
> > When you review things, you should include a line like this:
> > 
> > Reviewed-by: Real Name <my@email.address>
> > 
> > People pushing patches upstream will collect that and make it part of
> > the commit message, like this:
> > https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa
> >   
> 
> Got it, thank you. I've added this short instruction to
> wayland-web/reviewing.html and will send the patch shortly.

Cool.

> > We also use Acked-by when a particular person accepts the change in
> > principle, but has not properly reviewed the changes. This is usually
> > when that person's acceptance is important somehow.
> > 
> > Btw. your recent review emails do not appear as replies to the patch
> > emails. This makes matching them to the particular (revision of) the
> > patch quite hard.  
> 
> It's my fault due to trying to reconstruct the original emails from the
> digests I receive, and I noticed this when seeing my unthreaded replies
> on the list archive. Don't laugh! :) I've since switched to normal emails
> rather than the digest. Of course, I can't receive the original PATCH emails,
> but assuming that replies are matched by accurate subject lines, would you
> like me to correct and re-send? (Let's please do what's easiest for
> you / others.)

Replies get matched by proper Message-id strings in In-Reply-To and
References email headers I believe, not by subject.

No need to resend, I think.


Thanks,
pq


pgplAicPdxbp3.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Yong Bakos 
> On Apr 5, 2016, at 3:52 AM, Pekka Paalanen <ppaala...@gmail.com> wrote:
> 
> On Mon, 4 Apr 2016 17:55:29 -0500
> Yong Bakos <j...@humanoriented.com> wrote:
> 
>>> Date: Sun,  3 Apr 2016 01:47:43 +0100
>>> From: Eric Engestrom <e...@engestrom.ch>
>>> To: wayland-devel@lists.freedesktop.org
>>> Cc: Eric Engestrom <e...@engestrom.ch>
>>> Subject: [PATCH libinput] fix spelling mistakes
>>> Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch>
>>> 
>>> Signed-off-by: Eric Engestrom <e...@engestrom.ch>
>>> ---
>>> doc/t440-support.dox | 2 +-
>>> src/evdev-tablet.c   | 2 +-
>>> src/evdev.c  | 2 +-
>>> src/filter.c | 2 +-
>>> src/libinput.h   | 8 
>>> 5 files changed, 8 insertions(+), 8 deletions(-)
>>> 
> 
>> 
>> Looks good, thanks. (Note that I am a novice reviewer.)
> 
> Hi Yong,
> 
> thank you for participating!
> 
> When you review things, you should include a line like this:
> 
> Reviewed-by: Real Name <my@email.address>
> 
> People pushing patches upstream will collect that and make it part of
> the commit message, like this:
> https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa

Got it, thank you. I've added this short instruction to
wayland-web/reviewing.html and will send the patch shortly.


> We also use Acked-by when a particular person accepts the change in
> principle, but has not properly reviewed the changes. This is usually
> when that person's acceptance is important somehow.
> 
> Btw. your recent review emails do not appear as replies to the patch
> emails. This makes matching them to the particular (revision of) the
> patch quite hard.

It's my fault due to trying to reconstruct the original emails from the
digests I receive, and I noticed this when seeing my unthreaded replies
on the list archive. Don't laugh! :) I've since switched to normal emails
rather than the digest. Of course, I can't receive the original PATCH emails,
but assuming that replies are matched by accurate subject lines, would you
like me to correct and re-send? (Let's please do what's easiest for
you / others.)

yong


> 
> Thanks,
> pq


___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-05 Thread Pekka Paalanen 
On Mon, 4 Apr 2016 17:55:29 -0500
Yong Bakos <j...@humanoriented.com> wrote:

> > Date: Sun,  3 Apr 2016 01:47:43 +0100
> > From: Eric Engestrom <e...@engestrom.ch>
> > To: wayland-devel@lists.freedesktop.org
> > Cc: Eric Engestrom <e...@engestrom.ch>
> > Subject: [PATCH libinput] fix spelling mistakes
> > Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch>
> > 
> > Signed-off-by: Eric Engestrom <e...@engestrom.ch>
> > ---
> > doc/t440-support.dox | 2 +-
> > src/evdev-tablet.c   | 2 +-
> > src/evdev.c  | 2 +-
> > src/filter.c | 2 +-
> > src/libinput.h   | 8 
> > 5 files changed, 8 insertions(+), 8 deletions(-)
> > 

> 
> Looks good, thanks. (Note that I am a novice reviewer.)

Hi Yong,

thank you for participating!

When you review things, you should include a line like this:

Reviewed-by: Real Name <my@email.address>

People pushing patches upstream will collect that and make it part of
the commit message, like this:
https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa

We also use Acked-by when a particular person accepts the change in
principle, but has not properly reviewed the changes. This is usually
when that person's acceptance is important somehow.

Btw. your recent review emails do not appear as replies to the patch
emails. This makes matching them to the particular (revision of) the
patch quite hard.


Thanks,
pq


pgpNNKGC2GDpu.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH libinput] fix spelling mistakes (Eric Engestrom)

2016-04-04 Thread Yong Bakos 
> Date: Sun,  3 Apr 2016 01:47:43 +0100
> From: Eric Engestrom <e...@engestrom.ch>
> To: wayland-devel@lists.freedesktop.org
> Cc: Eric Engestrom <e...@engestrom.ch>
> Subject: [PATCH libinput] fix spelling mistakes
> Message-ID: <1459644463-5419-1-git-send-email-e...@engestrom.ch>
> 
> Signed-off-by: Eric Engestrom <e...@engestrom.ch>
> ---
> doc/t440-support.dox | 2 +-
> src/evdev-tablet.c   | 2 +-
> src/evdev.c  | 2 +-
> src/filter.c | 2 +-
> src/libinput.h   | 8 
> 5 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/t440-support.dox b/doc/t440-support.dox
> index 652a6d0..f4ce3ed 100644
> --- a/doc/t440-support.dox
> +++ b/doc/t440-support.dox
> @@ -70,7 +70,7 @@ digraph top_button_routing
>   touchpad -> libinput_tp [color="red4"]
> 
>   events_tp [label="other touchpad events"];
> - events_topbutton [label="top sofware button events"];
> + events_topbutton [label="top software button events"];
> 
>   libinput_tp -> events_tp [arrowhead="none"]
>   libinput_ts -> events_topbutton [color="red4"]
> diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c
> index 7359881..9a1ac52 100644
> --- a/src/evdev-tablet.c
> +++ b/src/evdev-tablet.c
> @@ -516,7 +516,7 @@ tablet_check_notify_axes(struct tablet_dispatch *tablet,
>   axes.tilt.x = 0;
>   axes.tilt.y = 0;
> 
> - /* tilt is already coverted to left-handed, so mouse
> + /* tilt is already converted to left-handed, so mouse
>* rotation is converted to left-handed automatically */
>   } else {
>   axes.rotation = tablet_handle_artpen_rotation(tablet, device);
> diff --git a/src/evdev.c b/src/evdev.c
> index a5c965d..6bb8986 100644
> --- a/src/evdev.c
> +++ b/src/evdev.c
> @@ -1306,7 +1306,7 @@ fallback_dispatch_create(struct libinput_device *device)
>   evdev_init_sendevents(evdev_device, dispatch);
> 
>   /* BTN_MIDDLE is set on mice even when it's not present. So
> -  * we can only use the absense of BTN_MIDDLE to mean something, i.e.
> +  * we can only use the absence of BTN_MIDDLE to mean something, i.e.
>* we enable it by default on anything that only has L
>* If we have L and no middle, we don't expose it as config
>* option */
> diff --git a/src/filter.c b/src/filter.c
> index 4c39b0e..cf8996d 100644
> --- a/src/filter.c
> +++ b/src/filter.c
> @@ -690,7 +690,7 @@ touchpad_lenovo_x230_accel_profile(struct motion_filter 
> *filter,
>* trial-and-error. No other meaning should be interpreted.
>* The calculation is a compressed form of
>* pointer_accel_profile_linear(), look at the git history of that
> -  * function for an explaination of what the min/max/etc. does.
> +  * function for an explanation of what the min/max/etc. does.
>*/
>   speed_in *= X230_MAGIC_SLOWDOWN / X230_TP_MAGIC_LOW_RES_FACTOR;
> 
> diff --git a/src/libinput.h b/src/libinput.h
> index 819efa8..3449611 100644
> --- a/src/libinput.h
> +++ b/src/libinput.h
> @@ -1340,7 +1340,7 @@ libinput_event_gesture_get_scale(struct 
> libinput_event_gesture *event);
>  *
>  * The angle delta is defined as the change in angle of the line formed by
>  * the 2 fingers of a pinch gesture. Clockwise rotation is represented
> - * by a postive delta, counter-clockwise by a negative delta. If e.g. the
> + * by a positive delta, counter-clockwise by a negative delta. If e.g. the
>  * fingers are on the 12 and 6 location of a clock face plate and they move
>  * to the 1 resp. 7 location in a single event then the angle delta is
>  * 30 degrees.
> @@ -2308,7 +2308,7 @@ libinput_get_event(struct libinput *libinput);
>  *
>  * @param libinput A previously initialized libinput context
>  * @return The event type of the next available event or @ref
> - * LIBINPUT_EVENT_NONE if no event is availble.
> + * LIBINPUT_EVENT_NONE if no event is available.
>  */
> enum libinput_event_type
> libinput_next_event_type(struct libinput *libinput);
> @@ -3590,7 +3590,7 @@ enum libinput_config_accel_profile {
>  *
>  * @param device The device to configure
>  *
> - * @return A bitmask of all configurable modes availble on this device.
> + * @return A bitmask of all configurable modes available on this device.
>  */
> uint32_t
> libinput_device_config_accel_get_profiles(struct libinput_device *device);
> @@ -4234,7 +4234,7 @@ enum libinput_config_dwt_state {
>  * @ingroup config
>  *
>  * Check if this device supports configurable disable-while-typing feature.
> - * This feature is usally ava

[PATCH libinput] fix spelling mistakes

2016-04-04 Thread Eric Engestrom 
Signed-off-by: Eric Engestrom 
---
 doc/t440-support.dox | 2 +-
 src/evdev-tablet.c   | 2 +-
 src/evdev.c  | 2 +-
 src/filter.c | 2 +-
 src/libinput.h   | 8 
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/doc/t440-support.dox b/doc/t440-support.dox
index 652a6d0..f4ce3ed 100644
--- a/doc/t440-support.dox
+++ b/doc/t440-support.dox
@@ -70,7 +70,7 @@ digraph top_button_routing
touchpad -> libinput_tp [color="red4"]
 
events_tp [label="other touchpad events"];
-   events_topbutton [label="top sofware button events"];
+   events_topbutton [label="top software button events"];
 
libinput_tp -> events_tp [arrowhead="none"]
libinput_ts -> events_topbutton [color="red4"]
diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c
index 7359881..9a1ac52 100644
--- a/src/evdev-tablet.c
+++ b/src/evdev-tablet.c
@@ -516,7 +516,7 @@ tablet_check_notify_axes(struct tablet_dispatch *tablet,
axes.tilt.x = 0;
axes.tilt.y = 0;
 
-   /* tilt is already coverted to left-handed, so mouse
+   /* tilt is already converted to left-handed, so mouse
 * rotation is converted to left-handed automatically */
} else {
axes.rotation = tablet_handle_artpen_rotation(tablet, device);
diff --git a/src/evdev.c b/src/evdev.c
index a5c965d..6bb8986 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1306,7 +1306,7 @@ fallback_dispatch_create(struct libinput_device *device)
evdev_init_sendevents(evdev_device, dispatch);
 
/* BTN_MIDDLE is set on mice even when it's not present. So
-* we can only use the absense of BTN_MIDDLE to mean something, i.e.
+* we can only use the absence of BTN_MIDDLE to mean something, i.e.
 * we enable it by default on anything that only has L
 * If we have L and no middle, we don't expose it as config
 * option */
diff --git a/src/filter.c b/src/filter.c
index 4c39b0e..cf8996d 100644
--- a/src/filter.c
+++ b/src/filter.c
@@ -690,7 +690,7 @@ touchpad_lenovo_x230_accel_profile(struct motion_filter 
*filter,
 * trial-and-error. No other meaning should be interpreted.
 * The calculation is a compressed form of
 * pointer_accel_profile_linear(), look at the git history of that
-* function for an explaination of what the min/max/etc. does.
+* function for an explanation of what the min/max/etc. does.
 */
speed_in *= X230_MAGIC_SLOWDOWN / X230_TP_MAGIC_LOW_RES_FACTOR;
 
diff --git a/src/libinput.h b/src/libinput.h
index 819efa8..3449611 100644
--- a/src/libinput.h
+++ b/src/libinput.h
@@ -1340,7 +1340,7 @@ libinput_event_gesture_get_scale(struct 
libinput_event_gesture *event);
  *
  * The angle delta is defined as the change in angle of the line formed by
  * the 2 fingers of a pinch gesture. Clockwise rotation is represented
- * by a postive delta, counter-clockwise by a negative delta. If e.g. the
+ * by a positive delta, counter-clockwise by a negative delta. If e.g. the
  * fingers are on the 12 and 6 location of a clock face plate and they move
  * to the 1 resp. 7 location in a single event then the angle delta is
  * 30 degrees.
@@ -2308,7 +2308,7 @@ libinput_get_event(struct libinput *libinput);
  *
  * @param libinput A previously initialized libinput context
  * @return The event type of the next available event or @ref
- * LIBINPUT_EVENT_NONE if no event is availble.
+ * LIBINPUT_EVENT_NONE if no event is available.
  */
 enum libinput_event_type
 libinput_next_event_type(struct libinput *libinput);
@@ -3590,7 +3590,7 @@ enum libinput_config_accel_profile {
  *
  * @param device The device to configure
  *
- * @return A bitmask of all configurable modes availble on this device.
+ * @return A bitmask of all configurable modes available on this device.
  */
 uint32_t
 libinput_device_config_accel_get_profiles(struct libinput_device *device);
@@ -4234,7 +4234,7 @@ enum libinput_config_dwt_state {
  * @ingroup config
  *
  * Check if this device supports configurable disable-while-typing feature.
- * This feature is usally available on built-in touchpads and disables the
+ * This feature is usually available on built-in touchpads and disables the
  * touchpad while typing. See @ref disable-while-typing for details.
  *
  * @param device The device to configure
-- 
2.8.0

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel