[webkit-changes] [159836] trunk/Source/JavaScriptCore
Title: [159836] trunk/Source/_javascript_Core Revision 159836 Author o...@webkit.org Date 2013-11-28 02:28:04 -0800 (Thu, 28 Nov 2013) Log Message Typo fix after r159834 to fix 32 bit builds. Patch by Peter Gal galpe...@inf.u-szeged.hu on 2013-11-28 Reviewed by Csaba Osztrogonác. * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (159835 => 159836) --- trunk/Source/_javascript_Core/ChangeLog 2013-11-28 07:40:03 UTC (rev 159835) +++ trunk/Source/_javascript_Core/ChangeLog 2013-11-28 10:28:04 UTC (rev 159836) @@ -1,3 +1,12 @@ +2013-11-28 Peter Gal galpe...@inf.u-szeged.hu + +Typo fix after r159834 to fix 32 bit builds. + +Reviewed by Csaba Osztrogonác. + +* dfg/DFGSpeculativeJIT32_64.cpp: +(JSC::DFG::SpeculativeJIT::compile): + 2013-11-27 Nadav Rotem nro...@apple.com Add a bunch of early exits and local optimizations to the x86 assembler. Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (159835 => 159836) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2013-11-28 07:40:03 UTC (rev 159835) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2013-11-28 10:28:04 UTC (rev 159836) @@ -3690,7 +3690,7 @@ GPRTemporary result(this); GPRReg resultGPR = result.gpr(); m_jit.move(TrustedImmPtr(registers), resultGPR); -storageResult(resultGPR); +storageResult(resultGPR, node); break; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159837] trunk
Title: [159837] trunk Revision 159837 Author g...@gnome.org Date 2013-11-28 04:40:59 -0800 (Thu, 28 Nov 2013) Log Message [GTK] Support custom types for drag and drop data https://bugs.webkit.org/show_bug.cgi?id=124659 Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2013-11-27 Reviewed by Martin Robinson. Source/WebCore: Covered by fast/events/drag-customData.html. * platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set. (WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types. * platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set. (WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type. (WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type. * platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeString): handle unknown types as custom. (WebCore::Pasteboard::writePasteboard): ditto. (WebCore::Pasteboard::hasData): also check for custom types. (WebCore::Pasteboard::types): also obtain the list of custom types. (WebCore::Pasteboard::readString): handle unknown types as custom. * platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): new unknown atom. (WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets. (WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which is in turn serialized to a single string for GtkSelectionData to hold. (WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is set. (WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data from the serialized GVariant string held by GtkSelectionData. (WebCore::PasteboardHelper::dropAtomsForContext): handle custom types. Source/WebKit2: * Shared/gtk/ArgumentCodersGtk.cpp: (CoreIPC::encodeDataObject): encode the unknown types data. (CoreIPC::decodeDataObject): decode the unknown types data. LayoutTests: * platform/gtk/TestExpectations: remove failure expectation for test that now passes. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/DataObjectGtk.cpp trunk/Source/WebCore/platform/gtk/DataObjectGtk.h trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp Diff Modified: trunk/LayoutTests/ChangeLog (159836 => 159837) --- trunk/LayoutTests/ChangeLog 2013-11-28 10:28:04 UTC (rev 159836) +++ trunk/LayoutTests/ChangeLog 2013-11-28 12:40:59 UTC (rev 159837) @@ -1,3 +1,12 @@ +2013-11-27 Gustavo Noronha Silva gustavo.noro...@collabora.com + +[GTK] Support custom types for drag and drop data +https://bugs.webkit.org/show_bug.cgi?id=124659 + +Reviewed by Martin Robinson. + +* platform/gtk/TestExpectations: remove failure expectation for test that now passes. + 2013-11-27 Filip Pizlo fpi...@apple.com Infer one-time scopes Modified: trunk/LayoutTests/platform/gtk/TestExpectations (159836 => 159837) --- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-28 10:28:04 UTC (rev 159836) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-28 12:40:59 UTC (rev 159837) @@ -220,14 +220,15 @@ webkit.org/b/98940 fast/events/drag-dataTransferItemList.html [ Skip ] webkit.org/b/98940 fast/events/drag-dataTransferItemList-file-handling.html [ Skip ] +# Custom MIME type support in DataTransfer is not yet implemented; this test was added +# by Google while implementing a different pasteboard API that was only being used by +# Chromium and Qt, might make sense to remove. +webkit.org/b/99068 editing/pasteboard/clipboard-customData.html [ Failure ] + # setAutomaticLinkDetectionEnabled is not yet implemented. webkit.org/b/99069 editing/inserting/typing-space-to-trigger-smart-link.html [ Failure ] webkit.org/b/85463 editing/inserting/smart-link-when-caret-is-moved-before-URL.html [ Failure ] -# Custom MIME type support in DataTransfer is not yet implemented. -webkit.org/b/99068 editing/pasteboard/clipboard-customData.html [ Failure ] -webkit.org/b/99068 fast/events/drag-customData.html [ Failure ] - # PasteBoard::plainText() does not support file names. webkit.org/b/99070 editing/pasteboard/drag-files-to-editable-element.html [ Failure ] Modified: trunk/Source/WebCore/ChangeLog (159836 => 159837) --- trunk/Source/WebCore/ChangeLog 2013-11-28 10:28:04 UTC (rev 159836) +++ trunk/Source/WebCore/ChangeLog 2013-11-28 12:40:59 UTC (rev 159837) @@ -1,3 +1,36 @@ +2013-11-27 Gustavo Noronha Silva gustavo.noro...@collabora.com + +[GTK] Support custom types for drag and drop data +https://bugs.webkit.org/show_bug.cgi?id=124659 + +Reviewed by Martin Robinson. + +
[webkit-changes] [159838] trunk/Tools
Title: [159838] trunk/Tools Revision 159838 Author commit-qu...@webkit.org Date 2013-11-28 05:46:26 -0800 (Thu, 28 Nov 2013) Log Message Checkout should own the scm object in Host https://bugs.webkit.org/show_bug.cgi?id=124943 Patch by Dániel Bátyai batyai.dan...@stud.u-szeged.hu on 2013-11-28 Reviewed by Ryosuke Niwa. * Scripts/webkitpy/common/host.py: (Host.__init__): (Host.initialize_scm): (Host.scm): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/host.py Diff Modified: trunk/Tools/ChangeLog (159837 => 159838) --- trunk/Tools/ChangeLog 2013-11-28 12:40:59 UTC (rev 159837) +++ trunk/Tools/ChangeLog 2013-11-28 13:46:26 UTC (rev 159838) @@ -1,3 +1,15 @@ +2013-11-28 Dániel Bátyai batyai.dan...@stud.u-szeged.hu + +Checkout should own the scm object in Host +https://bugs.webkit.org/show_bug.cgi?id=124943 + +Reviewed by Ryosuke Niwa. + +* Scripts/webkitpy/common/host.py: +(Host.__init__): +(Host.initialize_scm): +(Host.scm): + 2013-11-26 Filip Pizlo fpi...@apple.com Do bytecode validation as part of testing Modified: trunk/Tools/Scripts/webkitpy/common/host.py (159837 => 159838) --- trunk/Tools/Scripts/webkitpy/common/host.py 2013-11-28 12:40:59 UTC (rev 159837) +++ trunk/Tools/Scripts/webkitpy/common/host.py 2013-11-28 13:46:26 UTC (rev 159838) @@ -48,8 +48,6 @@ SystemHost.__init__(self) self.web = web.Web() -# FIXME: Checkout should own the scm object. -self._scm = None self._checkout = None # Everything below this line is WebKit-specific and belongs on a higher-level object. @@ -80,11 +78,10 @@ def initialize_scm(self, patch_directories=None): detector = SCMDetector(self.filesystem, self.executive) -self._scm = detector.default_scm(patch_directories) -self._checkout = Checkout(self.scm()) +self._checkout = Checkout(detector.default_scm(patch_directories)) def scm(self): -return self._scm +return self._checkout._scm def checkout(self): return self._checkout ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159839] trunk/Tools
Title: [159839] trunk/Tools Revision 159839 Author commit-qu...@webkit.org Date 2013-11-28 07:14:42 -0800 (Thu, 28 Nov 2013) Log Message Move PrettyPatch related code to prettypatch.py https://bugs.webkit.org/show_bug.cgi?id=124937 Patch by Dániel Bátyai batyai.dan...@stud.u-szeged.hu on 2013-11-28 Reviewed by Ryosuke Niwa. This code seems to have a better place here than in Port, since PrettyPatch already knows pretty_patch_path, and this also unifies the usage of PrettyPatch * Scripts/webkitpy/common/prettypatch.py: (PrettyPatch.__init__): (PrettyPatch.pretty_diff): (PrettyPatch): (PrettyPatch.pretty_patch_available): (PrettyPatch.check_pretty_patch): (PrettyPatch.pretty_patch_text): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.create_text_diff_and_write_result): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.wdiff_available): (Port.check_image_diff): (Port.wdiff_text): * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_pretty_patch_os_error): (PortTest.test_pretty_patch_script_error): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/prettypatch.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/port/base_unittest.py Diff Modified: trunk/Tools/ChangeLog (159838 => 159839) --- trunk/Tools/ChangeLog 2013-11-28 13:46:26 UTC (rev 159838) +++ trunk/Tools/ChangeLog 2013-11-28 15:14:42 UTC (rev 159839) @@ -1,5 +1,35 @@ 2013-11-28 Dániel Bátyai batyai.dan...@stud.u-szeged.hu +Move PrettyPatch related code to prettypatch.py +https://bugs.webkit.org/show_bug.cgi?id=124937 + +Reviewed by Ryosuke Niwa. + +This code seems to have a better place here than in Port, since PrettyPatch already knows +pretty_patch_path, and this also unifies the usage of PrettyPatch + +* Scripts/webkitpy/common/prettypatch.py: +(PrettyPatch.__init__): +(PrettyPatch.pretty_diff): +(PrettyPatch): +(PrettyPatch.pretty_patch_available): +(PrettyPatch.check_pretty_patch): +(PrettyPatch.pretty_patch_text): +* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: +(TestResultWriter.create_text_diff_and_write_result): +* Scripts/webkitpy/layout_tests/models/test_run_results.py: +(summarize_results): +* Scripts/webkitpy/port/base.py: +(Port.__init__): +(Port.wdiff_available): +(Port.check_image_diff): +(Port.wdiff_text): +* Scripts/webkitpy/port/base_unittest.py: +(PortTest.test_pretty_patch_os_error): +(PortTest.test_pretty_patch_script_error): + +2013-11-28 Dániel Bátyai batyai.dan...@stud.u-szeged.hu + Checkout should own the scm object in Host https://bugs.webkit.org/show_bug.cgi?id=124943 Modified: trunk/Tools/Scripts/webkitpy/common/prettypatch.py (159838 => 159839) --- trunk/Tools/Scripts/webkitpy/common/prettypatch.py 2013-11-28 13:46:26 UTC (rev 159838) +++ trunk/Tools/Scripts/webkitpy/common/prettypatch.py 2013-11-28 15:14:42 UTC (rev 159839) @@ -26,15 +26,25 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +import errno +import logging import os import tempfile +from webkitpy.common.system.executive import ScriptError +_log = logging.getLogger(__name__) + class PrettyPatch(object): # FIXME: PrettyPatch should not require checkout_root. -def __init__(self, executive, checkout_root): +def __init__(self, executive, checkout_root, filesystem=None): self._executive = executive +self._filesystem = filesystem self._checkout_root = checkout_root +self._pretty_patch_path = os.path.join(self._checkout_root, Websites, bugs.webkit.org, PrettyPatch) +self._prettify_path = os.path.join(self._pretty_patch_path, prettify.rb) +self.pretty_patch_error_html = Failed to run PrettyPatch, see error log. +self.ppatch_available = None def pretty_diff_file(self, diff): # Diffs can contain multiple text files of different encodings @@ -52,16 +62,59 @@ if not diff: return -pretty_patch_path = os.path.join(self._checkout_root, - Websites, bugs.webkit.org, - PrettyPatch) -prettify_path = os.path.join(pretty_patch_path, prettify.rb) args = [ ruby, -I, -pretty_patch_path, -prettify_path, +self._pretty_patch_path, +self._prettify_path, ] # PrettyPatch does not modify the encoding of the
[webkit-changes] [159840] trunk/Source/WebCore
Title: [159840] trunk/Source/WebCore
Revision 159840
Author commit-qu...@webkit.org
Date 2013-11-28 07:15:49 -0800 (Thu, 28 Nov 2013)
Log Message
Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947
Patch by Thiago de Barros Lacerda thiago.lace...@openbossa.org on 2013-11-28
Reviewed by Philippe Normand.
Adding its create function back, in order to run RTCPeerConnection LayoutTests.
No new tests needed.
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::create):
* platform/mock/RTCPeerConnectionHandlerMock.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp
trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (159839 => 159840)
--- trunk/Source/WebCore/ChangeLog 2013-11-28 15:14:42 UTC (rev 159839)
+++ trunk/Source/WebCore/ChangeLog 2013-11-28 15:15:49 UTC (rev 159840)
@@ -1,3 +1,18 @@
+2013-11-28 Thiago de Barros Lacerda thiago.lace...@openbossa.org
+
+Updating RTCPeerConnectionHandlerMock after r159769
+https://bugs.webkit.org/show_bug.cgi?id=124947
+
+Reviewed by Philippe Normand.
+
+Adding its create function back, in order to run RTCPeerConnection LayoutTests.
+
+No new tests needed.
+
+* platform/mock/RTCPeerConnectionHandlerMock.cpp:
+(WebCore::RTCPeerConnectionHandlerMock::create):
+* platform/mock/RTCPeerConnectionHandlerMock.h:
+
2013-11-27 Gustavo Noronha Silva gustavo.noro...@collabora.com
[GTK] Support custom types for drag and drop data
Modified: trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp (159839 => 159840)
--- trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp 2013-11-28 15:14:42 UTC (rev 159839)
+++ trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp 2013-11-28 15:15:49 UTC (rev 159840)
@@ -41,6 +41,11 @@
namespace WebCore {
+std::unique_ptrRTCPeerConnectionHandler RTCPeerConnectionHandlerMock::create(RTCPeerConnectionHandlerClient* client)
+{
+return std::make_uniqueRTCPeerConnectionHandlerMock(client);
+}
+
RTCPeerConnectionHandlerMock::RTCPeerConnectionHandlerMock(RTCPeerConnectionHandlerClient* client)
: m_client(client)
{
Modified: trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h (159839 => 159840)
--- trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h 2013-11-28 15:14:42 UTC (rev 159839)
+++ trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h 2013-11-28 15:15:49 UTC (rev 159840)
@@ -36,6 +36,8 @@
class RTCPeerConnectionHandlerMock FINAL : public RTCPeerConnectionHandler, public TimerEventBasedMock {
public:
+static std::unique_ptrRTCPeerConnectionHandler create(RTCPeerConnectionHandlerClient*);
+
virtual ~RTCPeerConnectionHandlerMock() { }
virtual bool initialize(PassRefPtrRTCConfiguration, PassRefPtrMediaConstraints) OVERRIDE;
@@ -55,7 +57,6 @@
virtual std::unique_ptrRTCDTMFSenderHandler createDTMFSender(PassRefPtrMediaStreamSource) OVERRIDE;
virtual void stop() OVERRIDE;
-protected:
explicit RTCPeerConnectionHandlerMock(RTCPeerConnectionHandlerClient*);
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159841] trunk/LayoutTests
Title: [159841] trunk/LayoutTests
Revision 159841
Author commit-qu...@webkit.org
Date 2013-11-28 07:27:04 -0800 (Thu, 28 Nov 2013)
Log Message
[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124879
Unreviewed, EFL rebaseline.
EFL tests need to be rebaselined after r159747
Patch by Jongwoo Choi jw0330.c...@samsung.com on 2013-11-28
* platform/efl/fast/table/011-expected.txt:
* platform/efl/fast/table/border-collapsing/004-expected.txt:
* platform/efl/fast/table/tableInsideCaption-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/table/011-expected.txt
trunk/LayoutTests/platform/efl/fast/table/border-collapsing/004-expected.txt
trunk/LayoutTests/platform/efl/fast/table/tableInsideCaption-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (159840 => 159841)
--- trunk/LayoutTests/ChangeLog 2013-11-28 15:15:49 UTC (rev 159840)
+++ trunk/LayoutTests/ChangeLog 2013-11-28 15:27:04 UTC (rev 159841)
@@ -1,3 +1,16 @@
+2013-11-28 Jongwoo Choi jw0330.c...@samsung.com
+
+[EFL] Layout tests need to be rebaselined.
+https://bugs.webkit.org/show_bug.cgi?id=124879
+
+Unreviewed, EFL rebaseline.
+
+EFL tests need to be rebaselined after r159747
+
+* platform/efl/fast/table/011-expected.txt:
+* platform/efl/fast/table/border-collapsing/004-expected.txt:
+* platform/efl/fast/table/tableInsideCaption-expected.txt:
+
2013-11-27 Gustavo Noronha Silva gustavo.noro...@collabora.com
[GTK] Support custom types for drag and drop data
Modified: trunk/LayoutTests/platform/efl/fast/table/011-expected.txt (159840 => 159841)
--- trunk/LayoutTests/platform/efl/fast/table/011-expected.txt 2013-11-28 15:15:49 UTC (rev 159840)
+++ trunk/LayoutTests/platform/efl/fast/table/011-expected.txt 2013-11-28 15:27:04 UTC (rev 159841)
@@ -1,9 +1,9 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x88
- RenderBlock {HTML} at (0,0) size 800x88
-RenderBody {BODY} at (8,8) size 784x72
- RenderTable {TABLE} at (0,0) size 66x72
+layer at (0,0) size 800x80
+ RenderBlock {HTML} at (0,0) size 800x80
+RenderBody {BODY} at (8,8) size 784x64
+ RenderTable {TABLE} at (0,0) size 66x64
RenderTableSection {THEAD} at (0,0) size 66x24
RenderTableRow {TR} at (0,2) size 66x20
RenderTableCell {TH} at (2,2) size 14x20 [color=#FF] [r=0 c=0 rs=1 cs=1]
@@ -18,31 +18,31 @@
RenderTableCell {TH} at (50,2) size 14x20 [color=#FF] [r=0 c=3 rs=1 cs=1]
RenderText {#text} at (1,1) size 12x17
text run at (1,1) width 12: D
-RenderTableSection {TFOOT} at (0,48) size 66x24
- RenderTableRow {TR} at (0,2) size 66x20
-RenderTableCell {TH} at (2,2) size 14x20 [color=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableSection {TFOOT} at (0,44) size 66x20
+ RenderTableRow {TR} at (0,0) size 66x18
+RenderTableCell {TH} at (2,-1) size 14x20 [color=#FF] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,1) size 10x17
text run at (2,1) width 10: F
-RenderTableCell {TH} at (18,2) size 14x20 [color=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCell {TH} at (18,-1) size 14x20 [color=#FF] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (1,1) size 12x17
text run at (1,1) width 12: O
-RenderTableCell {TH} at (34,2) size 14x20 [color=#FF] [r=0 c=2 rs=1 cs=1]
+RenderTableCell {TH} at (34,-1) size 14x20 [color=#FF] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (1,1) size 12x17
text run at (1,1) width 12: O
-RenderTableCell {TH} at (50,2) size 14x20 [color=#FF] [r=0 c=3 rs=1 cs=1]
+RenderTableCell {TH} at (50,-1) size 14x20 [color=#FF] [r=0 c=3 rs=1 cs=1]
RenderText {#text} at (1,1) size 12x17
text run at (1,1) width 12: T
-RenderTableSection {TBODY} at (0,24) size 66x24
- RenderTableRow {TR} at (0,2) size 66x20
-RenderTableCell {TD} at (2,2) size 14x20 [color=#008000] [r=0 c=0 rs=1 cs=1]
+RenderTableSection {TBODY} at (0,24) size 66x20
+ RenderTableRow {TR} at (0,0) size 66x18
+RenderTableCell {TD} at (2,-1) size 14x20 [color=#008000] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (1,1) size 8x17
text run at (1,1) width 8: b
-RenderTableCell {TD} at (18,2) size 14x20 [color=#008000] [r=0 c=1 rs=1 cs=1]
+RenderTableCell {TD} at (18,-1) size 14x20 [color=#008000] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (1,1) size 8x17
text run at (1,1) width 8: o
-RenderTableCell {TD} at (34,2) size 14x20 [color=#008000] [r=0 c=2 rs=1 cs=1]
+RenderTableCell {TD} at (34,-1) size 14x20
[webkit-changes] [159843] trunk/Source/WebKit/gtk
Title: [159843] trunk/Source/WebKit/gtk
Revision 159843
Author g...@gnome.org
Date 2013-11-28 08:02:34 -0800 (Thu, 28 Nov 2013)
Log Message
REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954
Patch by Gustavo Noronha Silva gustavo.noro...@collabora.com on 2013-11-28
Reviewed by Carlos Garcia Campos.
* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testwebview.c
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (159842 => 159843)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-11-28 15:46:53 UTC (rev 159842)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-11-28 16:02:34 UTC (rev 159843)
@@ -1,3 +1,14 @@
+2013-11-28 Gustavo Noronha Silva gustavo.noro...@collabora.com
+
+REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
+https://bugs.webkit.org/show_bug.cgi?id=124954
+
+Reviewed by Carlos Garcia Campos.
+
+* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
+* webkit/webkitwebview.cpp:
+(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.
+
2013-11-18 Carlos Garcia Campos cgar...@igalia.com
Unreviewed. Update NEWS and Versions.m4 for 2.3.2 release.
Modified: trunk/Source/WebKit/gtk/tests/testwebview.c (159842 => 159843)
--- trunk/Source/WebKit/gtk/tests/testwebview.c 2013-11-28 15:46:53 UTC (rev 159842)
+++ trunk/Source/WebKit/gtk/tests/testwebview.c 2013-11-28 16:02:34 UTC (rev 159843)
@@ -687,6 +687,27 @@
gtk_widget_destroy(window);
}
+static void test_webkit_web_view_source_mode()
+{
+GtkWidget* web_view;
+
+web_view = webkit_web_view_new();
+
+webkit_web_view_load_string(WEBKIT_WEB_VIEW(web_view), htmlbody/body/html, NULL, NULL, NULL);
+
+g_assert(!webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+webkit_web_view_set_view_source_mode(WEBKIT_WEB_VIEW(web_view), TRUE);
+
+g_assert(webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+webkit_web_view_set_view_source_mode(WEBKIT_WEB_VIEW(web_view), FALSE);
+
+g_assert(!webkit_web_view_get_view_source_mode(WEBKIT_WEB_VIEW(web_view)));
+
+gtk_widget_destroy(web_view);
+}
+
int main(int argc, char** argv)
{
SoupServer* server;
@@ -719,6 +740,7 @@
g_test_add_data_func(/webkit/webview/fullscreen, GINT_TO_POINTER(FALSE), test_webkit_web_view_fullscreen);
g_test_add_data_func(/webkit/webview/fullscreen-blocked, GINT_TO_POINTER(TRUE), test_webkit_web_view_fullscreen);
g_test_add_func(/webkit/webview/file-chooser, test_webkit_web_view_file_chooser);
+g_test_add_func(/webkit/webview/source-mode, test_webkit_web_view_source_mode);
return g_test_run ();
}
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (159842 => 159843)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-11-28 15:46:53 UTC (rev 159842)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2013-11-28 16:02:34 UTC (rev 159843)
@@ -5191,9 +5191,7 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
-core(webView)-mainFrame().inViewSourceMode();
-
-return FALSE;
+return core(webView)-mainFrame().inViewSourceMode();
}
// Internal subresource management
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159844] trunk/LayoutTests
Title: [159844] trunk/LayoutTests Revision 159844 Author an...@apple.com Date 2013-11-28 08:19:30 -0800 (Thu, 28 Nov 2013) Log Message No need to skip css variables tests as they were removed. * platform/mac/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (159843 => 159844) --- trunk/LayoutTests/ChangeLog 2013-11-28 16:02:34 UTC (rev 159843) +++ trunk/LayoutTests/ChangeLog 2013-11-28 16:19:30 UTC (rev 159844) @@ -1,5 +1,12 @@ 2013-11-28 Antti Koivisto an...@apple.com +No need to skip css variables tests as they were removed. + +* platform/mac/TestExpectations: +* platform/win/TestExpectations: + +2013-11-28 Antti Koivisto an...@apple.com + Remove feature: CSS variables https://bugs.webkit.org/show_bug.cgi?id=114119 Modified: trunk/LayoutTests/platform/mac/TestExpectations (159843 => 159844) --- trunk/LayoutTests/platform/mac/TestExpectations 2013-11-28 16:02:34 UTC (rev 159843) +++ trunk/LayoutTests/platform/mac/TestExpectations 2013-11-28 16:19:30 UTC (rev 159844) @@ -793,9 +793,6 @@ # ENABLE(CUSTOM_ELEMENTS) is disabled. fast/dom/custom -# CSS Variables are not yet enabled. -webkit.org/b/85580 fast/css/variables - # CSS image-resolution is not yet enabled. webkit.org/b/85262 fast/css/image-resolution Modified: trunk/LayoutTests/platform/win/TestExpectations (159843 => 159844) --- trunk/LayoutTests/platform/win/TestExpectations 2013-11-28 16:02:34 UTC (rev 159843) +++ trunk/LayoutTests/platform/win/TestExpectations 2013-11-28 16:19:30 UTC (rev 159844) @@ -2595,21 +2595,6 @@ webkit.org/b/117322 fast/backgrounds/background-opaque-images-over-color.html [ ImageOnlyFailure ] webkit.org/b/117322 fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ] webkit.org/b/117322 fast/css/text-indent-first-line-006.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/border-width.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/calc.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/colors-test.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/computed-style.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/inherited-values.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/inline-styles.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/redefinition.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/shorthand.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/transform-test.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/use-before-defined.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/var-inside-box-reflect.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/var-inside-pair.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/var-inside-quad.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/var-inside-shorthand.html [ ImageOnlyFailure ] -webkit.org/b/117322 fast/css/variables/variable-chain.html [ ImageOnlyFailure ] webkit.org/b/117322 fast/css/word-spacing-characters-complex-text.html [ ImageOnlyFailure ] webkit.org/b/117322 fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ] webkit.org/b/117322 fast/text/hyphen-min-preferred-width.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159845] trunk/Source/WebKit2
Title: [159845] trunk/Source/WebKit2
Revision 159845
Author commit-qu...@webkit.org
Date 2013-11-28 08:20:01 -0800 (Thu, 28 Nov 2013)
Log Message
Buildfix after r159824 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=124968
Patch by Éva Balázsfalvi balazsfalvi@stud.u-szeged.hu on 2013-11-28
Reviewed by Csaba Osztrogonác.
Added explicit friend class, because GCC 4.6 doesn't support extended friend declaration (c++11)
* Shared/APIObject.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/APIObject.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159844 => 159845)
--- trunk/Source/WebKit2/ChangeLog 2013-11-28 16:19:30 UTC (rev 159844)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-28 16:20:01 UTC (rev 159845)
@@ -1,3 +1,14 @@
+2013-11-28 Éva Balázsfalvi balazsfalvi@stud.u-szeged.hu
+
+Buildfix after r159824 for GCC 4.6
+https://bugs.webkit.org/show_bug.cgi?id=124968
+
+Reviewed by Csaba Osztrogonác.
+
+Added explicit friend class, because GCC 4.6 doesn't support extended friend declaration (c++11)
+
+* Shared/APIObject.h:
+
2013-11-28 Antti Koivisto an...@apple.com
Remove feature: CSS variables
Modified: trunk/Source/WebKit2/Shared/APIObject.h (159844 => 159845)
--- trunk/Source/WebKit2/Shared/APIObject.h 2013-11-28 16:19:30 UTC (rev 159844)
+++ trunk/Source/WebKit2/Shared/APIObject.h 2013-11-28 16:20:01 UTC (rev 159845)
@@ -207,7 +207,7 @@
}
protected:
-friend Object;
+friend class Object;
TypedObject()
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159846] trunk/LayoutTests
Title: [159846] trunk/LayoutTests
Revision 159846
Author m.pak...@samsung.com
Date 2013-11-28 08:35:28 -0800 (Thu, 28 Nov 2013)
Log Message
Unreviewed EFL gardening
* platform/efl/TestExpectations: Added test expectations for failing tests.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
Added Paths
trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.png
trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (159845 => 159846)
--- trunk/LayoutTests/ChangeLog 2013-11-28 16:20:01 UTC (rev 159845)
+++ trunk/LayoutTests/ChangeLog 2013-11-28 16:35:28 UTC (rev 159846)
@@ -1,3 +1,11 @@
+2013-11-28 Michał Pakuła vel Rutka m.pak...@samsung.com
+
+Unreviewed EFL gardening
+
+* platform/efl/TestExpectations: Added test expectations for failing tests.
+* platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
+* platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.
+
2013-11-28 Antti Koivisto an...@apple.com
No need to skip css variables tests as they were removed.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (159845 => 159846)
--- trunk/LayoutTests/platform/efl/TestExpectations 2013-11-28 16:20:01 UTC (rev 159845)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2013-11-28 16:35:28 UTC (rev 159846)
@@ -1754,3 +1754,9 @@
# QuickTime plug-in not relevant to this port
plugins/quicktime-plugin-replacement.html [ Skip ]
+
+webkit.org/b/124970 compositing/geometry/fixed-position-flipped-writing-mode.html [ Failure ]
+
+webkit.org/b/124971 compositing/repaint/repaint-on-layer-grouping-change.html [ Failure ]
+
+webkit.org/b/124971 fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html [ ImageOnlyFailure ]
Added: trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.txt (0 => 159846)
--- trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/forms/search/search-size-with-decorations-expected.txt 2013-11-28 16:35:28 UTC (rev 159846)
@@ -0,0 +1,81 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x240
+ RenderBlock {HTML} at (0,0) size 800x240
+RenderBody {BODY} at (8,8) size 784x224
+ RenderTextControl {INPUT} at (2,2) size 208x28 [bgcolor=#FF]
+RenderFlexibleBox {DIV} at (4,6) size 201x18
+ RenderBlock {DIV} at (0,9) size 0x0
+ RenderBlock {DIV} at (0,0) size 185x18
+ RenderBlock {DIV} at (185,1) size 16x16
+ RenderText {#text} at (212,8) size 4x17
+text run at (212,8) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderTextControl {INPUT} at (2,34) size 208x28 [bgcolor=#FF]
+RenderFlexibleBox {DIV} at (4,6) size 201x18
+ RenderBlock {DIV} at (0,9) size 0x0
+ RenderBlock {DIV} at (0,0) size 185x18
+ RenderBlock {DIV} at (185,1) size 16x16
+ RenderText {#text} at (212,40) size 4x17
+text run at (212,40) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderTextControl {INPUT} at (2,66) size 226x28 [bgcolor=#FF]
+RenderFlexibleBox {DIV} at (4,6) size 219x18
+ RenderBlock {DIV} at (0,1) size 18x16
+ RenderBlock {DIV} at (18,0) size 185x18
+ RenderBlock {DIV} at (203,1) size 16x16
+ RenderText {#text} at (230,72) size 4x17
+text run at (230,72) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderTextControl {INPUT} at (2,98) size 226x28 [bgcolor=#FF]
+RenderFlexibleBox {DIV} at (4,6) size 219x18
+ RenderBlock {DIV} at (0,1) size 18x16
+ RenderBlock {DIV} at (18,0) size 185x18
+ RenderBlock {DIV} at (203,1) size 16x16
+ RenderText {#text} at (230,104) size 4x17
+text run at (230,104) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderTextControl {INPUT} at (2,130) size 226x28 [bgcolor=#FF]
+RenderFlexibleBox {DIV} at (4,6) size 219x18
+ RenderBlock {DIV} at (0,1) size 18x16
+ RenderBlock {DIV} at (18,0) size 185x18
+ RenderBlock {DIV} at (203,1) size 16x16
+ RenderText {#text} at (230,136) size 4x17
+text run at (230,136) width 4:
+ RenderBR
[webkit-changes] [159847] trunk/Tools
Title: [159847] trunk/Tools Revision 159847 Author commit-qu...@webkit.org Date 2013-11-28 08:55:28 -0800 (Thu, 28 Nov 2013) Log Message Unreviewed, rolling out r159839. http://trac.webkit.org/changeset/159839 https://bugs.webkit.org/show_bug.cgi?id=124974 run-webkit-tests doesn't generate pretty diff (Requested by Ossy on #webkit). * Scripts/webkitpy/common/prettypatch.py: (PrettyPatch.__init__): (PrettyPatch.pretty_diff): * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: (TestResultWriter.create_text_diff_and_write_result): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): * Scripts/webkitpy/port/base.py: (Port.__init__): (Port.pretty_patch_available): (Port.check_pretty_patch): (Port.variable): (Port.variable.pretty_patch_text): * Scripts/webkitpy/port/base_unittest.py: (PortTest.test_pretty_patch_os_error): (PortTest.test_pretty_patch_script_error): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/prettypatch.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/port/base_unittest.py Diff Modified: trunk/Tools/ChangeLog (159846 => 159847) --- trunk/Tools/ChangeLog 2013-11-28 16:35:28 UTC (rev 159846) +++ trunk/Tools/ChangeLog 2013-11-28 16:55:28 UTC (rev 159847) @@ -1,3 +1,29 @@ +2013-11-28 Commit Queue commit-qu...@webkit.org + +Unreviewed, rolling out r159839. +http://trac.webkit.org/changeset/159839 +https://bugs.webkit.org/show_bug.cgi?id=124974 + +run-webkit-tests doesn't generate pretty diff (Requested by +Ossy on #webkit). + +* Scripts/webkitpy/common/prettypatch.py: +(PrettyPatch.__init__): +(PrettyPatch.pretty_diff): +* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: +(TestResultWriter.create_text_diff_and_write_result): +* Scripts/webkitpy/layout_tests/models/test_run_results.py: +(summarize_results): +* Scripts/webkitpy/port/base.py: +(Port.__init__): +(Port.pretty_patch_available): +(Port.check_pretty_patch): +(Port.variable): +(Port.variable.pretty_patch_text): +* Scripts/webkitpy/port/base_unittest.py: +(PortTest.test_pretty_patch_os_error): +(PortTest.test_pretty_patch_script_error): + 2013-11-28 Antti Koivisto an...@apple.com Remove feature: CSS variables Modified: trunk/Tools/Scripts/webkitpy/common/prettypatch.py (159846 => 159847) --- trunk/Tools/Scripts/webkitpy/common/prettypatch.py 2013-11-28 16:35:28 UTC (rev 159846) +++ trunk/Tools/Scripts/webkitpy/common/prettypatch.py 2013-11-28 16:55:28 UTC (rev 159847) @@ -26,25 +26,15 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -import errno -import logging import os import tempfile -from webkitpy.common.system.executive import ScriptError -_log = logging.getLogger(__name__) - class PrettyPatch(object): # FIXME: PrettyPatch should not require checkout_root. -def __init__(self, executive, checkout_root, filesystem=None): +def __init__(self, executive, checkout_root): self._executive = executive -self._filesystem = filesystem self._checkout_root = checkout_root -self._pretty_patch_path = os.path.join(self._checkout_root, Websites, bugs.webkit.org, PrettyPatch) -self._prettify_path = os.path.join(self._pretty_patch_path, prettify.rb) -self.pretty_patch_error_html = Failed to run PrettyPatch, see error log. -self.ppatch_available = None def pretty_diff_file(self, diff): # Diffs can contain multiple text files of different encodings @@ -62,59 +52,16 @@ if not diff: return +pretty_patch_path = os.path.join(self._checkout_root, + Websites, bugs.webkit.org, + PrettyPatch) +prettify_path = os.path.join(pretty_patch_path, prettify.rb) args = [ ruby, -I, -self._pretty_patch_path, -self._prettify_path, +pretty_patch_path, +prettify_path, ] # PrettyPatch does not modify the encoding of the diff output # so we can't expect it to be utf-8. return self._executive.run_command(args, input=diff, decode_output=False) - -def pretty_patch_available(self): -if self.ppatch_available is None: -self.ppatch_available = self.check_pretty_patch(logging=False) -return self.ppatch_available - -def check_pretty_patch(self, logging=True): -Checks whether we can use the PrettyPatch ruby script. -try: -_ =
[webkit-changes] [159848] trunk
Title: [159848] trunk Revision 159848 Author o...@webkit.org Date 2013-11-28 09:40:59 -0800 (Thu, 28 Nov 2013) Log Message RenderTableSection Blink merge asserting https://bugs.webkit.org/show_bug.cgi?id=124857 Patch by Laszlo Vidacs l...@inf.u-szeged.hu on 2013-11-28 Reviewed by Csaba Osztrogonác. Source/WebCore: Use border spacing at the end of all sections. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowLogicalHeight): LayoutTests: Skipped tests enabled. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTableSection.cpp Diff Modified: trunk/LayoutTests/ChangeLog (159847 => 159848) --- trunk/LayoutTests/ChangeLog 2013-11-28 16:55:28 UTC (rev 159847) +++ trunk/LayoutTests/ChangeLog 2013-11-28 17:40:59 UTC (rev 159848) @@ -1,3 +1,14 @@ +2013-11-28 Laszlo Vidacs l...@inf.u-szeged.hu + +RenderTableSection Blink merge asserting +https://bugs.webkit.org/show_bug.cgi?id=124857 + +Reviewed by Csaba Osztrogonác. + +Skipped tests enabled. + +* TestExpectations: + 2013-11-28 Michał Pakuła vel Rutka m.pak...@samsung.com Unreviewed EFL gardening Modified: trunk/LayoutTests/TestExpectations (159847 => 159848) --- trunk/LayoutTests/TestExpectations 2013-11-28 16:55:28 UTC (rev 159847) +++ trunk/LayoutTests/TestExpectations 2013-11-28 17:40:59 UTC (rev 159848) @@ -69,7 +69,3 @@ # The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track # Skipping it for now, then put it again when the spec decides it fast/mediastream/MediaStream-onended.html [ Skip ] - -# Recent Blink merge has caused these tests to crash -webkit.org/b/124857 tables/mozilla/bugs/bug46268-3.html [ Skip ] -webkit.org/b/124857 tables/mozilla_expected_failures/bugs/bug46268-4.html [ Skip ] Modified: trunk/Source/WebCore/ChangeLog (159847 => 159848) --- trunk/Source/WebCore/ChangeLog 2013-11-28 16:55:28 UTC (rev 159847) +++ trunk/Source/WebCore/ChangeLog 2013-11-28 17:40:59 UTC (rev 159848) @@ -1,3 +1,15 @@ +2013-11-28 Laszlo Vidacs l...@inf.u-szeged.hu + +RenderTableSection Blink merge asserting +https://bugs.webkit.org/show_bug.cgi?id=124857 + +Reviewed by Csaba Osztrogonác. + +Use border spacing at the end of all sections. + +* rendering/RenderTableSection.cpp: +(WebCore::RenderTableSection::calcRowLogicalHeight): + 2013-11-28 Antti Koivisto an...@apple.com Remove feature: CSS variables Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (159847 => 159848) --- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-11-28 16:55:28 UTC (rev 159847) +++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-11-28 17:40:59 UTC (rev 159848) @@ -366,6 +366,8 @@ } // Add the border-spacing to our final position. +// Use table border-spacing even in non-top sections +spacing = table()-vBorderSpacing(); m_rowPos[r + 1] += m_grid[r].rowRenderer ? spacing : 0; m_rowPos[r + 1] = std::max(m_rowPos[r + 1], m_rowPos[r]); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159849] trunk/Source/WebCore
Title: [159849] trunk/Source/WebCore Revision 159849 Author zol...@webkit.org Date 2013-11-28 09:43:06 -0800 (Thu, 28 Nov 2013) Log Message [Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line https://bugs.webkit.org/show_bug.cgi?id=124959 Reviewed by Brent Fulgham. Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line. No new tests, no behavior change. * WebCore.vcxproj/WebCore.vcxproj.filters: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters Diff Modified: trunk/Source/WebCore/ChangeLog (159848 => 159849) --- trunk/Source/WebCore/ChangeLog 2013-11-28 17:40:59 UTC (rev 159848) +++ trunk/Source/WebCore/ChangeLog 2013-11-28 17:43:06 UTC (rev 159849) @@ -1,3 +1,16 @@ +2013-11-28 Zoltan Horvath zol...@webkit.org + +[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line +https://bugs.webkit.org/show_bug.cgi?id=124959 + +Reviewed by Brent Fulgham. + +Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line. + +No new tests, no behavior change. + +* WebCore.vcxproj/WebCore.vcxproj.filters: + 2013-11-28 Laszlo Vidacs l...@inf.u-szeged.hu RenderTableSection Blink merge asserting Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (159848 => 159849) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2013-11-28 17:40:59 UTC (rev 159848) +++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2013-11-28 17:43:06 UTC (rev 159849) @@ -14669,6 +14669,12 @@ ClInclude Include=..\rendering\RenderElement.h Filterrendering/Filter /ClInclude +ClInclude Include=..\rendering\line\LineInfo.h + Filterrendering/Filter +/ClInclude +ClInclude Include=..\rendering\line\LineLayoutState.h + Filterrendering/Filter +/ClInclude ClInclude Include=..\rendering\line\LineWidth.h Filterrendering\line/Filter /ClInclude @@ -14702,12 +14708,6 @@ ClInclude Include=..\rendering\shapes\RectangleShape.h Filterrendering\shapes/Filter /ClInclude -ClInclude Include=..\rendering\LineLayoutState.h - Filterrendering/Filter -/ClInclude -ClInclude Include=..\rendering\LineInfo.h - Filterrendering/Filter -/ClInclude ClInclude Include=$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\$(ProjectName)\DerivedSources\HTMLElementTypeHelpers.h FilterDerivedSources/Filter /ClInclude ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159852] trunk/Source/WebKit
Title: [159852] trunk/Source/WebKit
Revision 159852
Author commit-qu...@webkit.org
Date 2013-11-28 11:33:27 -0800 (Thu, 28 Nov 2013)
Log Message
Building EFL Webkit again with mediastream enabled
https://bugs.webkit.org/show_bug.cgi?id=124930
Patch by Thiago de Barros Lacerda thiago.lace...@openbossa.org on 2013-11-28
Reviewed by Csaba Osztrogonác.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
Diff
Modified: trunk/Source/WebKit/CMakeLists.txt (159851 => 159852)
--- trunk/Source/WebKit/CMakeLists.txt 2013-11-28 19:03:10 UTC (rev 159851)
+++ trunk/Source/WebKit/CMakeLists.txt 2013-11-28 19:33:27 UTC (rev 159852)
@@ -4,6 +4,7 @@
${WEBKIT_DIR}
${WEBCORE_DIR}
${WEBCORE_DIR}/Modules/filesystem
+${WEBCORE_DIR}/Modules/mediastream
${WEBCORE_DIR}/Modules/networkinfo
${WEBCORE_DIR}/Modules/webdatabase
${WEBCORE_DIR}/accessibility
@@ -36,6 +37,7 @@
${WEBCORE_DIR}/platform/graphics/harfbuzz/ng
${WEBCORE_DIR}/platform/graphics/opengl
${WEBCORE_DIR}/platform/graphics/transforms
+${WEBCORE_DIR}/platform/mediastream
${WEBCORE_DIR}/platform/network
${WEBCORE_DIR}/platform/sql
${WEBCORE_DIR}/platform/text
Modified: trunk/Source/WebKit/ChangeLog (159851 => 159852)
--- trunk/Source/WebKit/ChangeLog 2013-11-28 19:03:10 UTC (rev 159851)
+++ trunk/Source/WebKit/ChangeLog 2013-11-28 19:33:27 UTC (rev 159852)
@@ -1,3 +1,12 @@
+2013-11-28 Thiago de Barros Lacerda thiago.lace...@openbossa.org
+
+Building EFL Webkit again with mediastream enabled
+https://bugs.webkit.org/show_bug.cgi?id=124930
+
+Reviewed by Csaba Osztrogonác.
+
+* CMakeLists.txt:
+
2013-11-27 Sam Weinig s...@webkit.org
Fix the iOS build.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159854] trunk/Source/WebCore
Title: [159854] trunk/Source/WebCore
Revision 159854
Author commit-qu...@webkit.org
Date 2013-11-28 11:43:50 -0800 (Thu, 28 Nov 2013)
Log Message
Nix Upstream: Adding EditorNix to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124984
Patch by Thiago de Barros Lacerda thiago.lace...@openbossa.org on 2013-11-28
Reviewed by Csaba Osztrogonác.
No new tests needed.
* PlatformNix.cmake:
* editing/nix/EditorNix.cpp: Added.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformNix.cmake
Added Paths
trunk/Source/WebCore/editing/nix/
trunk/Source/WebCore/editing/nix/EditorNix.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (159853 => 159854)
--- trunk/Source/WebCore/ChangeLog 2013-11-28 19:35:24 UTC (rev 159853)
+++ trunk/Source/WebCore/ChangeLog 2013-11-28 19:43:50 UTC (rev 159854)
@@ -1,3 +1,15 @@
+2013-11-28 Thiago de Barros Lacerda thiago.lace...@openbossa.org
+
+Nix Upstream: Adding EditorNix to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=124984
+
+Reviewed by Csaba Osztrogonác.
+
+No new tests needed.
+
+* PlatformNix.cmake:
+* editing/nix/EditorNix.cpp: Added.
+
2013-11-28 Zoltan Horvath zol...@webkit.org
[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
Modified: trunk/Source/WebCore/PlatformNix.cmake (159853 => 159854)
--- trunk/Source/WebCore/PlatformNix.cmake 2013-11-28 19:35:24 UTC (rev 159853)
+++ trunk/Source/WebCore/PlatformNix.cmake 2013-11-28 19:43:50 UTC (rev 159854)
@@ -24,6 +24,8 @@
editing/SmartReplaceICU.cpp
+editing/nix/EditorNix.cpp
+
html/shadow/MediaControlsNix.cpp
page/TouchAdjustment.cpp
Added: trunk/Source/WebCore/editing/nix/EditorNix.cpp (0 => 159854)
--- trunk/Source/WebCore/editing/nix/EditorNix.cpp (rev 0)
+++ trunk/Source/WebCore/editing/nix/EditorNix.cpp 2013-11-28 19:43:50 UTC (rev 159854)
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies).
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include Editor.h
+
+#include NotImplemented.h
+
+namespace WebCore {
+
+void Editor::writeSelectionToPasteboard(Pasteboard)
+{
+notImplemented();
+}
+
+void Editor::writeImageToPasteboard(Pasteboard, Element, const URL, const String)
+{
+notImplemented();
+}
+
+void Editor::pasteWithPasteboard(Pasteboard*, bool)
+{
+notImplemented();
+}
+
+} // namespace WebCore
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159855] trunk/Source/JavaScriptCore
Title: [159855] trunk/Source/_javascript_Core
Revision 159855
Author nro...@apple.com
Date 2013-11-28 12:33:44 -0800 (Thu, 28 Nov 2013)
Log Message
Revert the X86 assembler peephole changes
https://bugs.webkit.org/show_bug.cgi?id=124988
Reviewed by Csaba Osztrogonác.
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (159854 => 159855)
--- trunk/Source/_javascript_Core/ChangeLog 2013-11-28 19:43:50 UTC (rev 159854)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-11-28 20:33:44 UTC (rev 159855)
@@ -1,3 +1,25 @@
+2013-11-28 Nadav Rotem nro...@apple.com
+
+Revert the X86 assembler peephole changes
+https://bugs.webkit.org/show_bug.cgi?id=124988
+
+Reviewed by Csaba Osztrogonác.
+
+* assembler/MacroAssemblerX86.h:
+(JSC::MacroAssemblerX86::add32):
+(JSC::MacroAssemblerX86::add64):
+(JSC::MacroAssemblerX86::or32):
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::add32):
+(JSC::MacroAssemblerX86Common::or32):
+(JSC::MacroAssemblerX86Common::branchAdd32):
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::add32):
+(JSC::MacroAssemblerX86_64::or32):
+(JSC::MacroAssemblerX86_64::add64):
+(JSC::MacroAssemblerX86_64::or64):
+(JSC::MacroAssemblerX86_64::xor64):
+
2013-11-28 Antti Koivisto an...@apple.com
Remove feature: CSS variables
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h (159854 => 159855)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h 2013-11-28 19:43:50 UTC (rev 159854)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h 2013-11-28 20:33:44 UTC (rev 159855)
@@ -62,14 +62,12 @@
void add32(TrustedImm32 imm, RegisterID src, RegisterID dest)
{
-if (imm.m_value)
-m_assembler.leal_mr(imm.m_value, src, dest);
+m_assembler.leal_mr(imm.m_value, src, dest);
}
void add32(TrustedImm32 imm, AbsoluteAddress address)
{
-if (imm.m_value)
-m_assembler.addl_im(imm.m_value, address.m_ptr);
+m_assembler.addl_im(imm.m_value, address.m_ptr);
}
void add32(AbsoluteAddress address, RegisterID dest)
@@ -79,8 +77,6 @@
void add64(TrustedImm32 imm, AbsoluteAddress address)
{
-if (!imm.m_value)
-return;
m_assembler.addl_im(imm.m_value, address.m_ptr);
m_assembler.adcl_im(imm.m_value 31, reinterpret_castconst char*(address.m_ptr) + sizeof(int32_t));
}
@@ -92,8 +88,7 @@
void or32(TrustedImm32 imm, AbsoluteAddress address)
{
-if (imm.m_value)
-m_assembler.orl_im(imm.m_value, address.m_ptr);
+m_assembler.orl_im(imm.m_value, address.m_ptr);
}
void or32(RegisterID reg, AbsoluteAddress address)
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (159854 => 159855)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2013-11-28 19:43:50 UTC (rev 159854)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2013-11-28 20:33:44 UTC (rev 159855)
@@ -114,14 +114,11 @@
void add32(TrustedImm32 imm, Address address)
{
-if (imm.m_value)
-m_assembler.addl_im(imm.m_value, address.offset, address.base);
+m_assembler.addl_im(imm.m_value, address.offset, address.base);
}
void add32(TrustedImm32 imm, RegisterID dest)
{
-if (!imm.m_value)
-return;
if (imm.m_value == 1)
m_assembler.inc_r(dest);
else
@@ -140,8 +137,7 @@
void add32(TrustedImm32 imm, RegisterID src, RegisterID dest)
{
-if (imm.m_value)
-m_assembler.leal_mr(imm.m_value, src, dest);
+m_assembler.leal_mr(imm.m_value, src, dest);
}
void and32(RegisterID src, RegisterID dest)
@@ -256,8 +252,7 @@
void or32(TrustedImm32 imm, RegisterID dest)
{
-if (imm.m_value)
-m_assembler.orl_ir(imm.m_value, dest);
+m_assembler.orl_ir(imm.m_value, dest);
}
void or32(RegisterID src, Address dest)
@@ -272,8 +267,7 @@
void
[webkit-changes] [159857] trunk/Source/WTF
Title: [159857] trunk/Source/WTF Revision 159857 Author commit-qu...@webkit.org Date 2013-11-28 12:55:19 -0800 (Thu, 28 Nov 2013) Log Message Nix Upstream: Updating Nix WTF files https://bugs.webkit.org/show_bug.cgi?id=124980 Patch by Thiago de Barros Lacerda thiago.lace...@openbossa.org on 2013-11-28 Reviewed by Csaba Osztrogonác. Just to sync our private repo files and the trunk, as part of the upstream process. * wtf/DisallowCType.h: * wtf/PlatformNix.cmake: * wtf/nix/FeatureDefinesNix.h: * wtf/nix/PlatformNix.h: * wtf/nix/RunLoopNix.cpp: Added. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/DisallowCType.h trunk/Source/WTF/wtf/PlatformNix.cmake trunk/Source/WTF/wtf/nix/FeatureDefinesNix.h trunk/Source/WTF/wtf/nix/PlatformNix.h Added Paths trunk/Source/WTF/wtf/nix/RunLoopNix.cpp Diff Modified: trunk/Source/WTF/ChangeLog (159856 => 159857) --- trunk/Source/WTF/ChangeLog 2013-11-28 20:53:22 UTC (rev 159856) +++ trunk/Source/WTF/ChangeLog 2013-11-28 20:55:19 UTC (rev 159857) @@ -1,3 +1,18 @@ +2013-11-28 Thiago de Barros Lacerda thiago.lace...@openbossa.org + +Nix Upstream: Updating Nix WTF files +https://bugs.webkit.org/show_bug.cgi?id=124980 + +Reviewed by Csaba Osztrogonác. + +Just to sync our private repo files and the trunk, as part of the upstream process. + +* wtf/DisallowCType.h: +* wtf/PlatformNix.cmake: +* wtf/nix/FeatureDefinesNix.h: +* wtf/nix/PlatformNix.h: +* wtf/nix/RunLoopNix.cpp: Added. + 2013-11-28 Antti Koivisto an...@apple.com Remove feature: CSS variables Modified: trunk/Source/WTF/wtf/DisallowCType.h (159856 => 159857) --- trunk/Source/WTF/wtf/DisallowCType.h 2013-11-28 20:53:22 UTC (rev 159856) +++ trunk/Source/WTF/wtf/DisallowCType.h 2013-11-28 20:55:19 UTC (rev 159857) @@ -41,7 +41,7 @@ // or glib/gi18n-lib.h, which in turn include xlocale/_ctype.h which uses // isacii(). #include wtf/Platform.h -#if !(OS(DARWIN) PLATFORM(GTK)) !OS(QNX) !PLATFORM(EFL) !defined(_LIBCPP_VERSION) +#if !(OS(DARWIN) PLATFORM(GTK)) !OS(QNX) !PLATFORM(EFL) !defined(_LIBCPP_VERSION) !PLATFORM(NIX) #include ctype.h Modified: trunk/Source/WTF/wtf/PlatformNix.cmake (159856 => 159857) --- trunk/Source/WTF/wtf/PlatformNix.cmake 2013-11-28 20:53:22 UTC (rev 159856) +++ trunk/Source/WTF/wtf/PlatformNix.cmake 2013-11-28 20:55:19 UTC (rev 159857) @@ -4,6 +4,8 @@ gobject/GlibUtilities.cpp gtk/MainThreadGtk.cpp + +nix/RunLoopNix.cpp ) list(APPEND WTF_LIBRARIES Modified: trunk/Source/WTF/wtf/nix/FeatureDefinesNix.h (159856 => 159857) --- trunk/Source/WTF/wtf/nix/FeatureDefinesNix.h 2013-11-28 20:53:22 UTC (rev 159856) +++ trunk/Source/WTF/wtf/nix/FeatureDefinesNix.h 2013-11-28 20:55:19 UTC (rev 159857) @@ -1,16 +1,16 @@ /* -* Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). -* -* Redistribution and use in source and binary forms, with or without -* modification, are permitted provided that the following conditions -* are met: -* 1. Redistributions of source code must retain the above copyright -*notice, this list of conditions and the following disclaimer. -* 2. Redistributions in binary form must reproduce the above copyright -*notice, this list of conditions and the following disclaimer in the -*documentation and/or other materials provided with the distribution. -* -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT @@ -30,6 +30,10 @@ #define ENABLE_3D_RENDERING 1 #endif +#if !defined(ENABLE_8BIT_TEXTRUN) +#define ENABLE_8BIT_TEXTRUN 1 +#endif + #if !defined(ENABLE_ACCELERATED_2D_CANVAS) #define ENABLE_ACCELERATED_2D_CANVAS 0 #endif @@ -150,6 +154,10 @@ #define ENABLE_INSPECTOR_SERVER 1 #endif +#if !defined(ENABLE_INPUT_SPEECH) +#define ENABLE_INPUT_SPEECH 1 +#endif + #if !defined(ENABLE_JAVASCRIPT_DEBUGGER) #define ENABLE_JAVASCRIPT_DEBUGGER 1 #endif @@ -174,6 +182,10 @@ #define ENABLE_MATHML 1 #endif +#if !defined(ENABLE_MEDIA_STREAM) +#define ENABLE_MEDIA_STREAM 0 +#endif + #if
[webkit-changes] [159858] trunk/LayoutTests
Title: [159858] trunk/LayoutTests
Revision 159858
Author an...@apple.com
Date 2013-11-28 12:59:06 -0800 (Thu, 28 Nov 2013)
Log Message
Remove an oddly named css variables test
Rubber-stamped by Andreas Kling.
* css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
* css3/filters/reference-filter-update-after-remove.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Removed Paths
trunk/LayoutTests/css3/filters/reference-filter-update-after-remove-expected.txt
trunk/LayoutTests/css3/filters/reference-filter-update-after-remove.html
Diff
Modified: trunk/LayoutTests/ChangeLog (159857 => 159858)
--- trunk/LayoutTests/ChangeLog 2013-11-28 20:55:19 UTC (rev 159857)
+++ trunk/LayoutTests/ChangeLog 2013-11-28 20:59:06 UTC (rev 159858)
@@ -1,3 +1,12 @@
+2013-11-28 Antti Koivisto an...@apple.com
+
+Remove an oddly named css variables test
+
+Rubber-stamped by Andreas Kling.
+
+* css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
+* css3/filters/reference-filter-update-after-remove.html: Removed.
+
2013-11-28 Laszlo Vidacs l...@inf.u-szeged.hu
RenderTableSection Blink merge asserting
Deleted: trunk/LayoutTests/css3/filters/reference-filter-update-after-remove-expected.txt (159857 => 159858)
--- trunk/LayoutTests/css3/filters/reference-filter-update-after-remove-expected.txt 2013-11-28 20:55:19 UTC (rev 159857)
+++ trunk/LayoutTests/css3/filters/reference-filter-update-after-remove-expected.txt 2013-11-28 20:59:06 UTC (rev 159858)
@@ -1 +0,0 @@
-If you can read this, the test passed.
Deleted: trunk/LayoutTests/css3/filters/reference-filter-update-after-remove.html (159857 => 159858)
--- trunk/LayoutTests/css3/filters/reference-filter-update-after-remove.html 2013-11-28 20:55:19 UTC (rev 159857)
+++ trunk/LayoutTests/css3/filters/reference-filter-update-after-remove.html 2013-11-28 20:59:06 UTC (rev 159858)
@@ -1,35 +0,0 @@
-script
-internals.settings.setCSSVariablesEnabled(true);
-/script
-style
-body {
--webkit-var-a: url(1);
--webkit-filter: -webkit-var(a);
-}
-body::first-letter {
-cursor: inherit;
-}
-/style
-script
-if (window.testRunner) {
-testRunner.waitUntilDone();
-testRunner.dumpAsText(false);
-}
-function init() {
- var docElement = document.documentElement;
- rect = document.createElementNS(http://www.w3.org/2000/svg, rect);
- docElement.appendChild(rect);
- text = document.createTextNode(If you can read this, the test passed.);
- docElement.appendChild(text);
- setTimeout(edit();, 20);
-}
-document.addEventListener(DOMContentLoaded, init, false);
-function edit() {
- document.designMode = on;
- r = document.createRange();
- r.selectNodeContents(rect);
- window.getSelection().addRange(r);
- window.getSelection().deleteFromDocument();
- if (window.testRunner) testRunner.notifyDone();
-}
-/script
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159859] trunk/Source/WebKit2
Title: [159859] trunk/Source/WebKit2 Revision 159859 Author wei...@apple.com Date 2013-11-28 13:01:11 -0800 (Thu, 28 Nov 2013) Log Message Perform some spring cleaning to WKContentView and WKView https://bugs.webkit.org/show_bug.cgi?id=124961 Reviewed by Dan Bernstein. - Store the PageClientImpl in a std::unique_ptr. - Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame. - Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame - contentViewDidCommitLoadForMainFrame. - Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner. - Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef). - Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView. - Remove incorrect implementations of initWithCoder. - Make WKContentView lazily create its WKBrowsingContextController wrapper. * UIProcess/API/ios/PageClientImplIOS.h: * UIProcess/API/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::PageClientImpl): (WebKit::PageClientImpl::didCommitLoadForMainFrame): (WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType): * UIProcess/API/ios/WKContentView.h: * UIProcess/API/ios/WKContentView.mm: (-[WKContentView initWithCoder:]): (-[WKContentView initWithFrame:processGroup:browsingContextGroup:]): (-[WKContentView browsingContextController]): (-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): (-[WKContentView _didCommitLoadForMainFrame]): (-[WKContentView _didReceiveMobileDocTypeForMainFrame]): (-[WKContentView _didChangeViewportArguments:WebCore::]): (-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]): (-[WKContentView _pageRef]): (-[WKContentView initWithFrame:contextRef:pageGroupRef:]): (-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/ios/WKContentViewInternal.h: * UIProcess/API/ios/WKContentViewPrivate.h: Added. * UIProcess/API/ios/WKView.mm: (-[WKView initWithFrame:processGroup:browsingContextGroup:]): (-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]): (-[WKView contentViewDidCommitLoadForMainFrame:]): (-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): (-[WKView pageRef]): (-[WKView initWithFrame:contextRef:pageGroupRef:]): (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didCommitLoadForMainFrame): * UIProcess/API/mac/WKBrowsingContextController.mm: (didCommitLoadForFrame): * UIProcess/API/mac/WKBrowsingContextControllerInternal.h: * UIProcess/API/mac/WKViewPrivate.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.h trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h trunk/Source/WebKit2/UIProcess/API/ios/WKView.mm trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h trunk/Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp Added Paths trunk/Source/WebKit2/UIProcess/API/ios/WKContentViewPrivate.h Diff Modified: trunk/Source/WebKit2/ChangeLog (159858 => 159859) --- trunk/Source/WebKit2/ChangeLog 2013-11-28 20:59:06 UTC (rev 159858) +++ trunk/Source/WebKit2/ChangeLog 2013-11-28 21:01:11 UTC (rev 159859) @@ -1,3 +1,60 @@ +2013-11-27 Sam Weinig s...@webkit.org + +Perform some spring cleaning to WKContentView and WKView +https://bugs.webkit.org/show_bug.cgi?id=124961 + +Reviewed by Dan Bernstein. + +- Store the PageClientImpl in a std::unique_ptr. +- Remove the WKBrowsingContextController internal load delegate. Replace its use with + a new PageClient function, didCommitLoadForMainFrame. +- Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame - contentViewDidCommitLoadForMainFrame. +- Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. + These are needed for WebKitTestRunner. +- Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef). +- Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView. +- Remove
[webkit-changes] [159862] trunk/Source/WebKit2
Title: [159862] trunk/Source/WebKit2
Revision 159862
Author commit-qu...@webkit.org
Date 2013-11-28 17:35:45 -0800 (Thu, 28 Nov 2013)
Log Message
[GTK] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124992
Patch by Nick Diego Yamane nick.yam...@openbossa.org on 2013-11-28
Reviewed by Gyuyoung Kim.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.
* UIProcess/API/gtk/PageClientImpl.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159861 => 159862)
--- trunk/Source/WebKit2/ChangeLog 2013-11-29 01:02:20 UTC (rev 159861)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-29 01:35:45 UTC (rev 159862)
@@ -1,3 +1,14 @@
+2013-11-28 Nick Diego Yamane nick.yam...@openbossa.org
+
+[GTK] Build fix after r159859
+https://bugs.webkit.org/show_bug.cgi?id=124992
+
+Reviewed by Gyuyoung Kim.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.
+* UIProcess/API/gtk/PageClientImpl.h:
+
2013-11-28 Jinwoo Song jinwoo7.s...@samsung.com
[EFL] Build fix after r159859
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (159861 => 159862)
--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2013-11-29 01:02:20 UTC (rev 159861)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2013-11-29 01:35:45 UTC (rev 159862)
@@ -284,4 +284,9 @@
return webkitWebViewBaseIsWindowVisible(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
}
+void PageClientImpl::didCommitLoadForMainFrame()
+{
+notImplemented();
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (159861 => 159862)
--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2013-11-29 01:02:20 UTC (rev 159861)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2013-11-29 01:35:45 UTC (rev 159862)
@@ -99,6 +99,7 @@
#endif
virtual void handleDownloadRequest(DownloadProxy*) OVERRIDE;
+virtual void didCommitLoadForMainFrame() OVERRIDE;
// Members of PageClientImpl class
GtkWidget* m_viewWidget;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [159864] trunk/Source/WebKit2
Title: [159864] trunk/Source/WebKit2
Revision 159864
Author commit-qu...@webkit.org
Date 2013-11-28 23:51:24 -0800 (Thu, 28 Nov 2013)
Log Message
[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
https://bugs.webkit.org/show_bug.cgi?id=118548
Patch by Eunmi Lee eunmi15@samsung.com on 2013-11-28
Reviewed by Noam Rosenthal.
CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159863 => 159864)
--- trunk/Source/WebKit2/ChangeLog 2013-11-29 03:42:04 UTC (rev 159863)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-29 07:51:24 UTC (rev 159864)
@@ -1,3 +1,20 @@
+2013-11-28 Eunmi Lee eunmi15@samsung.com
+
+[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
+https://bugs.webkit.org/show_bug.cgi?id=118548
+
+Reviewed by Noam Rosenthal.
+
+CoordinatedGraphics uses its own scaling logic - contents scaling - and
+WebView of CoordinatedGraphics maintains contents position by scaling
+with contents scaling factor.
+However transformToScene() and updateViewportSize() of WebView regard
+the contents position as a non-scaled value, so it should be fixed.
+
+* UIProcess/CoordinatedGraphics/WebView.cpp:
+(WebKit::WebView::transformToScene):
+(WebKit::WebView::updateViewportSize):
+
2013-11-28 Ryuan Choi ryuan.c...@samsung.com
[EFL] PageViewportController does not need to be unique_ptr instance
Modified: trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp (159863 => 159864)
--- trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp 2013-11-29 03:42:04 UTC (rev 159863)
+++ trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp 2013-11-29 07:51:24 UTC (rev 159864)
@@ -236,7 +236,7 @@
{
FloatPoint position = -m_contentPosition;
float effectiveScale = m_contentScaleFactor * m_page-deviceScaleFactor();
-position.scale(effectiveScale, effectiveScale);
+position.scale(m_page-deviceScaleFactor(), m_page-deviceScaleFactor());
TransformationMatrix transform = m_userViewportTransform;
transform.translate(position.x(), position.y());
@@ -258,7 +258,9 @@
if (CoordinatedDrawingAreaProxy* drawingArea = static_castCoordinatedDrawingAreaProxy*(page()-drawingArea())) {
// Web Process expects sizes in UI units, and not raw device units.
drawingArea-setSize(roundedIntSize(dipSize()), IntSize(), IntSize());
-FloatRect visibleContentsRect(contentPosition(), visibleContentsSize());
+FloatPoint position = contentPosition();
+position.scale(1 / m_contentScaleFactor, 1 / m_contentScaleFactor);
+FloatRect visibleContentsRect(position, visibleContentsSize());
visibleContentsRect.intersect(FloatRect(FloatPoint(), contentsSize()));
drawingArea-setVisibleContentsRect(visibleContentsRect, FloatPoint());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
