date:20131207

[webkit-changes] [160273] trunk/Source/WebCore

2013-12-07 Thread changseok . oh

Title: [160273] trunk/Source/WebCore








Revision 160273
Author changseok...@collabora.com
Date 2013-12-07 08:50:25 -0800 (Sat, 07 Dec 2013)


Log Message
Unreviewed. Build fix for gtk port after r160260.

* loader/cache/CachedImage.h: Add missing a header.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (160272 => 160273)

--- trunk/Source/WebCore/ChangeLog	2013-12-07 16:33:39 UTC (rev 160272)
+++ trunk/Source/WebCore/ChangeLog	2013-12-07 16:50:25 UTC (rev 160273)
@@ -1,3 +1,9 @@
+2013-12-07  ChangSeok Oh  
+
+Unreviewed. Build fix for gtk port after r160260.
+
+* loader/cache/CachedImage.h: Add missing a header.
+
 2013-12-07  Gustavo Noronha Silva  
 
 ubuntu software center hits _XReadEvents() error


Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (160272 => 160273)

--- trunk/Source/WebCore/loader/cache/CachedImage.h	2013-12-07 16:33:39 UTC (rev 160272)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h	2013-12-07 16:50:25 UTC (rev 160273)
@@ -24,6 +24,7 @@
 #define CachedImage_h
 
 #include "CachedResource.h"
+#include "Image.h"
 #include "ImageObserver.h"
 #include "IntRect.h"
 #include "IntSizeHash.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160272] trunk/Source/JavaScriptCore

2013-12-07 Thread commit-queue

Title: [160272] trunk/Source/_javascript_Core








Revision 160272
Author commit-qu...@webkit.org
Date 2013-12-07 08:33:39 -0800 (Sat, 07 Dec 2013)


Log Message
[Win][64-bit] Hitting breakpoint assembler instruction in callToJavaScript.
https://bugs.webkit.org/show_bug.cgi?id=125382

Patch by pe...@outlook.com  on 2013-12-07
Reviewed by Michael Saboff.

The WinCairo results from run-_javascript_core-tests are the same as the WinCairo 32-bits results, when removing these breakpoints.

* jit/JITStubsMSVC64.asm: Remove breakpoint instructions.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (160271 => 160272)

--- trunk/Source/_javascript_Core/ChangeLog	2013-12-07 14:54:15 UTC (rev 160271)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-12-07 16:33:39 UTC (rev 160272)
@@ -1,3 +1,14 @@
+2013-12-07  pe...@outlook.com  
+
+[Win][64-bit] Hitting breakpoint assembler instruction in callToJavaScript.
+https://bugs.webkit.org/show_bug.cgi?id=125382
+
+Reviewed by Michael Saboff.
+
+The WinCairo results from run-_javascript_core-tests are the same as the WinCairo 32-bits results, when removing these breakpoints.
+
+* jit/JITStubsMSVC64.asm: Remove breakpoint instructions.
+
 2013-12-06  Filip Pizlo  
 
 FTL should support all of Branch/LogicalNot


Modified: trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm (160271 => 160272)

--- trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm	2013-12-07 14:54:15 UTC (rev 160271)
+++ trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm	2013-12-07 16:33:39 UTC (rev 160272)
@@ -32,10 +32,8 @@
 _TEXT   SEGMENT
 
 callToJavaScript PROC
-;; FIXME: This function has not been tested as the Win 64 port doesn't currently use the JIT.
-;; It is believed to be an accurate adaptation of the assembly created by the llint stub of the
-;; same name with changes for agrument register differences.
-int 3
+;; This function is believed to be an accurate adaptation of the assembly created by the llint stub of the
+;; same name with changes for argument register differences.
 mov r10, qword ptr[rsp]
 push rbp
 mov rax, rbp ; Save previous frame pointer
@@ -132,10 +130,8 @@
 callToJavaScript ENDP
 
 callToNativeFunction PROC
-;; FIXME: This function has not been tested as the Win 64 port doesn't currently use the JIT.
-;; It is believed to be an accurate adaptation of the assembly created by the llint stub of the
-;; same name with changes for agrument register differences.
-int 3
+;; This function is believed to be an accurate adaptation of the assembly created by the llint stub of the
+;; same name with changes for argument register differences.
 mov r10, qword ptr[rsp]
 push rbp
 mov rax, rbp ; Save previous frame pointer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160271] trunk/Tools

2013-12-07 Thread commit-queue

Title: [160271] trunk/Tools








Revision 160271
Author commit-qu...@webkit.org
Date 2013-12-07 06:54:15 -0800 (Sat, 07 Dec 2013)


Log Message
Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai  on 2013-12-07
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

* Scripts/webkitpy/common/prettypatch.py:
(PrettyPatch.__init__):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/prettypatch.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/base_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (160270 => 160271)

--- trunk/Tools/ChangeLog	2013-12-07 13:03:10 UTC (rev 160270)
+++ trunk/Tools/ChangeLog	2013-12-07 14:54:15 UTC (rev 160271)
@@ -1,3 +1,33 @@
+2013-12-07  Dániel Bátyai  
+
+Move PrettyPatch related code to prettypatch.py
+https://bugs.webkit.org/show_bug.cgi?id=124937
+
+Reviewed by Ryosuke Niwa.
+
+This code seems to have a better place here than in Port, since PrettyPatch already knows
+pretty_patch_path, and this also unifies the usage of PrettyPatch
+
+* Scripts/webkitpy/common/prettypatch.py:
+(PrettyPatch.__init__):
+(PrettyPatch.pretty_diff):
+(PrettyPatch):
+(PrettyPatch.pretty_patch_available):
+(PrettyPatch.check_pretty_patch):
+(PrettyPatch.pretty_patch_text):
+* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+(TestResultWriter.create_text_diff_and_write_result):
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(summarize_results):
+* Scripts/webkitpy/port/base.py:
+(Port.__init__):
+(Port.wdiff_available):
+(Port.check_image_diff):
+(Port.wdiff_text):
+* Scripts/webkitpy/port/base_unittest.py:
+(PortTest.test_pretty_patch_os_error):
+(PortTest.test_pretty_patch_script_error):
+
 2013-12-06  Dan Bernstein  
 
 [Mac] MiniBrowser Debug builds are compiled with -Os


Modified: trunk/Tools/Scripts/webkitpy/common/prettypatch.py (160270 => 160271)

--- trunk/Tools/Scripts/webkitpy/common/prettypatch.py	2013-12-07 13:03:10 UTC (rev 160270)
+++ trunk/Tools/Scripts/webkitpy/common/prettypatch.py	2013-12-07 14:54:15 UTC (rev 160271)
@@ -26,15 +26,25 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import errno
+import logging
 import os
 import tempfile
+from webkitpy.common.system.executive import ScriptError
 
+_log = logging.getLogger(__name__)
 
+
 class PrettyPatch(object):
 # FIXME: PrettyPatch should not require checkout_root.
-def __init__(self, executive, checkout_root):
+def __init__(self, executive, checkout_root, filesystem=None):
 self._executive = executive
+self._filesystem = filesystem
 self._checkout_root = checkout_root
+self._pretty_patch_path = os.path.join(self._checkout_root, "Websites", "bugs.webkit.org", "PrettyPatch")
+self._prettify_path = os.path.join(self._pretty_patch_path, "prettify.rb")
+self.pretty_patch_error_html = "Failed to run PrettyPatch, see error log."
+self.ppatch_available = None
 
 def pretty_diff_file(self, diff):
 # Diffs can contain multiple text files of different encodings
@@ -52,16 +62,59 @@
 if not diff:
 return ""
 
-pretty_patch_path = os.path.join(self._checkout_root,
- "Websites", "bugs.webkit.org",
- "PrettyPatch")
-prettify_path = os.path.join(pretty_patch_path, "prettify.rb")
 args = [
 "ruby",
 "-I",
-pretty_patch_path,
-prettify_path,
+self._pretty_patch_path,
+self._prettify_path,
 ]
 # PrettyPatch does not modify the encoding of the diff output
 # so we can't expect it to be utf-8.
 return self._executive.run_command(args, input=di

[webkit-changes] [160270] trunk/Source

2013-12-07 Thread gns

Title: [160270] trunk/Source








Revision 160270
Author g...@gnome.org
Date 2013-12-07 05:03:10 -0800 (Sat, 07 Dec 2013)


Log Message
Fix API test expectation following 160220.

Rubber-stamped by Martin Robinson.

Source/WebKit/gtk:

* tests/testatkroles.c:
(finish_loading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
ATK_ROLE_DOCUMENT_FRAME.
(test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_image): ditto.
(test_webkit_atk_get_role_link): ditto.
(test_webkit_atk_get_role_list_and_item): ditto.
(test_webkit_atk_get_role_paragraph): ditto.
(test_webkit_atk_get_role_section): ditto.
(test_webkit_atk_get_role_table): ditto.
(test_webkit_atk_get_role_separator): ditto.
(test_webkit_atk_get_role_combobox): ditto.
(test_webkit_atk_get_role_form): ditto.
(test_webkit_atk_get_role_check_box): ditto.
(test_webkit_atk_get_role_entry): ditto.
(test_webkit_atk_get_role_label): ditto.
(test_webkit_atk_get_role_listbox): ditto.
(test_webkit_atk_get_role_password_text): ditto.
(test_webkit_atk_get_role_push_button): ditto.
(test_webkit_atk_get_role_radio_button): ditto.

Source/WebKit2:

* UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
(testAtspiBasicHierarchy): check for ATK_ROLE_DOCUMENT_WEB instead of ATK_ROLE_DOCUMENT_FRAME.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatkroles.c
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (160269 => 160270)

--- trunk/Source/WebKit/gtk/ChangeLog	2013-12-07 11:50:34 UTC (rev 160269)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-12-07 13:03:10 UTC (rev 160270)
@@ -1,3 +1,31 @@
+2013-12-07  Gustavo Noronha Silva  
+
+Fix API test expectation following 160220.
+
+Rubber-stamped by Martin Robinson.
+
+* tests/testatkroles.c:
+(finish_loading): rename variable documentFrame -> document.
+(test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
+ATK_ROLE_DOCUMENT_FRAME.
+(test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
+(test_webkit_atk_get_role_image): ditto.
+(test_webkit_atk_get_role_link): ditto.
+(test_webkit_atk_get_role_list_and_item): ditto.
+(test_webkit_atk_get_role_paragraph): ditto.
+(test_webkit_atk_get_role_section): ditto.
+(test_webkit_atk_get_role_table): ditto.
+(test_webkit_atk_get_role_separator): ditto.
+(test_webkit_atk_get_role_combobox): ditto.
+(test_webkit_atk_get_role_form): ditto.
+(test_webkit_atk_get_role_check_box): ditto.
+(test_webkit_atk_get_role_entry): ditto.
+(test_webkit_atk_get_role_label): ditto.
+(test_webkit_atk_get_role_listbox): ditto.
+(test_webkit_atk_get_role_password_text): ditto.
+(test_webkit_atk_get_role_push_button): ditto.
+(test_webkit_atk_get_role_radio_button): ditto.
+
 2013-12-05  Carlos Garcia Campos  
 
 [GTK] Fix GObject introspection warnings in webkitspellchecker


Modified: trunk/Source/WebKit/gtk/tests/testatkroles.c (160269 => 160270)

--- trunk/Source/WebKit/gtk/tests/testatkroles.c	2013-12-07 11:50:34 UTC (rev 160269)
+++ trunk/Source/WebKit/gtk/tests/testatkroles.c	2013-12-07 13:03:10 UTC (rev 160270)
@@ -45,7 +45,7 @@
 #define HTML_RADIO_BUTTON "This is a test."
 
 typedef struct {
-AtkObject* documentFrame;
+AtkObject* document;
 AtkObject* obj;
 AtkRole role;
 GtkWidget* webView;
@@ -64,12 +64,12 @@
 // bug 72390 for more details on this change.
 // https://bugs.webkit.org/show_bug.cgi?id=72390
 AtkObject* rootObject = gtk_widget_get_accessible(fixture->webView);
-fixture->documentFrame = atk_object_ref_accessible_child(rootObject, 0);
-g_assert(fixture->documentFrame);
+fixture->document = atk_object_ref_accessible_child(rootObject, 0);
+g_assert(fixture->document);
 
 // Remove the reference added by ref_accessible_child() and
 // return, since we don't need to keep that extra ref at all.
-g_object_unref(fixture->documentFrame);
+g_object_unref(fixture->document);
 return FALSE;
 }
 
@@ -110,24 +110,24 @@
 
 static void test_webkit_atk_get_role_document_frame(AtkRolesFixture* fixture, gconstpointer data)
 {
-fixture->role = atk_object_get_role(fixture->documentFrame);
-g_assert(fixture->role == ATK_ROLE_DOCUMENT_FRAME);
+fixture->role = atk_object_get_role(fixture->document);
+g_assert(fixture->role == ATK_ROLE_DOCUMENT_WEB);
 }
 
 static void test_webkit_atk_get_role_heading(AtkRolesFixture* fixture, gconstpointer data)
 {
-get_child_and_test_role(fixture->documentFrame, 0, ATK_ROLE_HEADING);
-get_child_and_test_role(fixture->documentFrame, 1, ATK_ROLE_HEADING);
-get_child_and_tes

[webkit-changes] [160269] trunk/Source/WebCore

2013-12-07 Thread gns

Title: [160269] trunk/Source/WebCore








Revision 160269
Author g...@gnome.org
Date 2013-12-07 03:50:34 -0800 (Sat, 07 Dec 2013)


Log Message
ubuntu software center hits _XReadEvents() error
https://bugs.webkit.org/show_bug.cgi?id=123480

Reviewed by Martin Robinson.

* platform/gtk/WidgetBackingStoreGtkX11.cpp:
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
before freeing the associated pixmap.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (160268 => 160269)

--- trunk/Source/WebCore/ChangeLog	2013-12-07 06:41:33 UTC (rev 160268)
+++ trunk/Source/WebCore/ChangeLog	2013-12-07 11:50:34 UTC (rev 160269)
@@ -1,3 +1,14 @@
+2013-12-07  Gustavo Noronha Silva  
+
+ubuntu software center hits _XReadEvents() error
+https://bugs.webkit.org/show_bug.cgi?id=123480
+
+Reviewed by Martin Robinson.
+
+* platform/gtk/WidgetBackingStoreGtkX11.cpp:
+(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
+before freeing the associated pixmap.
+
 2013-12-06  Tim Horton  
 
 [mac] Keep around more decoded image data, since it's purgeable


Modified: trunk/Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp (160268 => 160269)

--- trunk/Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp	2013-12-07 06:41:33 UTC (rev 160268)
+++ trunk/Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp	2013-12-07 11:50:34 UTC (rev 160269)
@@ -51,6 +51,8 @@
 
 WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11()
 {
+// The pixmap needs to exist when the surface is destroyed, so begin by clearing it.
+m_surface.clear();
 XFreePixmap(m_display, m_pixmap);
 XFreeGC(m_display, m_gc);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [160273] trunk/Source/WebCore

[webkit-changes] [160272] trunk/Source/JavaScriptCore

[webkit-changes] [160271] trunk/Tools

[webkit-changes] [160270] trunk/Source

[webkit-changes] [160269] trunk/Source/WebCore

5 matches

Site Navigation

Mail list logo

Footer information