[webkit-changes] [161487] branches/jsCStack/Source/JavaScriptCore
Title: [161487] branches/jsCStack/Source/_javascript_Core
Revision 161487
Author fpi...@apple.com
Date 2014-01-07 23:59:37 -0800 (Tue, 07 Jan 2014)
Log Message
Disable AVX in the FTL
https://bugs.webkit.org/show_bug.cgi?id=126620
Not yet reviewed.
* ftl/FTLAbbreviations.h:
(JSC::FTL::addTargetDependentFunctionAttr):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLAbbreviations.h
branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161486 => 161487)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 07:50:49 UTC (rev 161486)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 07:59:37 UTC (rev 161487)
@@ -1,5 +1,17 @@
2014-01-07 Filip Pizlo
+Disable AVX in the FTL
+https://bugs.webkit.org/show_bug.cgi?id=126620
+
+Not yet reviewed.
+
+* ftl/FTLAbbreviations.h:
+(JSC::FTL::addTargetDependentFunctionAttr):
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::lower):
+
+2014-01-07 Filip Pizlo
+
CStack: Call linking should log call linking for DFG and FTL code blocks if --showDFGDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=126617
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLAbbreviations.h (161486 => 161487)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLAbbreviations.h 2014-01-08 07:50:49 UTC (rev 161486)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLAbbreviations.h 2014-01-08 07:59:37 UTC (rev 161487)
@@ -133,6 +133,7 @@
static inline LValue addFunction(LModule module, const char* name, LType type) { return llvm->AddFunction(module, name, type); }
static inline void setLinkage(LValue global, LLinkage linkage) { llvm->SetLinkage(global, linkage); }
static inline void setFunctionCallingConv(LValue function, LCallConv convention) { llvm->SetFunctionCallConv(function, convention); }
+static inline void addTargetDependentFunctionAttr(LValue function, const char* key, const char* value) { llvm->AddTargetDependentFunctionAttr(function, key, value); }
static inline LValue addExternFunction(LModule module, const char* name, LType type)
{
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (161486 => 161487)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-08 07:50:49 UTC (rev 161486)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-08 07:59:37 UTC (rev 161487)
@@ -98,6 +98,11 @@
m_ftlState.function = addFunction(
m_ftlState.module, name.data(), functionType(m_out.int64));
setFunctionCallingConv(m_ftlState.function, LLVMCCallConv);
+if (isX86()) {
+// AVX makes V8/raytrace 80% slower. It makes Kraken/audio-oscillator 4.5x
+// slower. It should be disabled.
+addTargetDependentFunctionAttr(m_ftlState.function, "target-features", "-avx");
+}
m_out.initialize(m_ftlState.module, m_ftlState.function, m_heaps);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161486] branches/safari-537.74-branch/Source
Title: [161486] branches/safari-537.74-branch/Source Revision 161486 Author matthew_han...@apple.com Date 2014-01-07 23:50:49 -0800 (Tue, 07 Jan 2014) Log Message Versioning. Modified Paths branches/safari-537.74-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-537.74-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-537.74-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-537.74-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-537.74-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-537.74-branch/Source/_javascript_Core/Configurations/Version.xcconfig (161485 => 161486) --- branches/safari-537.74-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-08 07:47:18 UTC (rev 161485) +++ branches/safari-537.74-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-08 07:50:49 UTC (rev 161486) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 74; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.74-branch/Source/WebCore/Configurations/Version.xcconfig (161485 => 161486) --- branches/safari-537.74-branch/Source/WebCore/Configurations/Version.xcconfig 2014-01-08 07:47:18 UTC (rev 161485) +++ branches/safari-537.74-branch/Source/WebCore/Configurations/Version.xcconfig 2014-01-08 07:50:49 UTC (rev 161486) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 74; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.74-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (161485 => 161486) --- branches/safari-537.74-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-08 07:47:18 UTC (rev 161485) +++ branches/safari-537.74-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-08 07:50:49 UTC (rev 161486) @@ -1,6 +1,6 @@ MAJOR_VERSION = 537; MINOR_VERSION = 74; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-537.74-branch/Source/WebKit/mac/Configurations/Version.xcconfig (161485 => 161486) --- branches/safari-537.74-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-08 07:47:18 UTC (rev 161485) +++ branches/safari-537.74-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-08 07:50:49 UTC (rev 161486) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 74; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-537.74-branch/Source/WebKit2/Configurations/Version.xcconfig (161485 => 161486) --- branches/safari-537.74-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-01-08 07:47:18 UTC (rev 161485) +++ branches/safari-537.74-branch/Source/WebKit2/Configurations/Version.xcconfig 2014-01-08 07:50:49 UTC (rev 161486) @@ -23,7 +23,7 @@ MAJOR_VERSION = 537; MINOR_VERSION = 74; -TINY_VERSION = 5; +TINY_VERSION = 6; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161485] tags/Safari-537.74.5/
Title: [161485] tags/Safari-537.74.5/ Revision 161485 Author matthew_han...@apple.com Date 2014-01-07 23:47:18 -0800 (Tue, 07 Jan 2014) Log Message New tag. Added Paths tags/Safari-537.74.5/ Diff Property changes: tags/Safari-537.74.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161484] trunk
Title: [161484] trunk Revision 161484 Author an...@apple.com Date 2014-01-07 23:33:10 -0800 (Tue, 07 Jan 2014) Log Message REGRESSION (r161195): Acid2 regression tests frequently fail https://bugs.webkit.org/show_bug.cgi?id=126432 Source/WebCore: Reviewed by Anders Carlsson. We would occasionally dump the render tree before the actual last resource on the page was loaded. The problematic resource is an image loaded by an tag nested as fallback of another . * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent): Force style recalc when rendering fallback content. The current mechanism for triggering the fallback content load requires a style recalc. LayoutTests: Reviewed by Anders Carlsson. * TestExpectations: acid2 is no longer flaky. * fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: whitespace change. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLObjectElement.cpp Diff Modified: trunk/LayoutTests/ChangeLog (161483 => 161484) --- trunk/LayoutTests/ChangeLog 2014-01-08 07:02:54 UTC (rev 161483) +++ trunk/LayoutTests/ChangeLog 2014-01-08 07:33:10 UTC (rev 161484) @@ -1,3 +1,13 @@ +2014-01-07 Antti Koivisto + +REGRESSION (r161195): Acid2 regression tests frequently fail +https://bugs.webkit.org/show_bug.cgi?id=126432 + +Reviewed by Anders Carlsson. + +* TestExpectations: acid2 is no longer flaky. +* fast/overflow/overflow-height-float-not-removed-crash3-expected.txt: whitespace change. + 2014-01-07 Eric Carlson Teach MediaSessionManager to manage interruptions Modified: trunk/LayoutTests/TestExpectations (161483 => 161484) --- trunk/LayoutTests/TestExpectations 2014-01-08 07:02:54 UTC (rev 161483) +++ trunk/LayoutTests/TestExpectations 2014-01-08 07:33:10 UTC (rev 161484) @@ -69,8 +69,3 @@ webkit.org/b/124660 inspector-protocol/model/highlight-shape-outside.html [ Failure ] webkit.org/b/126142 css3/calc/transitions-dependent.html [ Pass Failure ] - -webkit.org/b/126432 fast/css/acid2-pixel.html [ Pass Failure ] -webkit.org/b/126432 fast/css/acid2.html [ Pass Failure ] -webkit.org/b/126432 http/tests/misc/acid2-pixel.html [ Pass Failure ] -webkit.org/b/126432 http/tests/misc/acid2.html [ Pass Failure ] Modified: trunk/LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt (161483 => 161484) --- trunk/LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt 2014-01-08 07:02:54 UTC (rev 161483) +++ trunk/LayoutTests/fast/overflow/overflow-height-float-not-removed-crash3-expected.txt 2014-01-08 07:33:10 UTC (rev 161484) @@ -1,3 +1,3 @@ Test passes if it does not crash. sometextsometextsometextsometextsometextsometext - + Modified: trunk/Source/WebCore/ChangeLog (161483 => 161484) --- trunk/Source/WebCore/ChangeLog 2014-01-08 07:02:54 UTC (rev 161483) +++ trunk/Source/WebCore/ChangeLog 2014-01-08 07:33:10 UTC (rev 161484) @@ -1,3 +1,19 @@ +2014-01-07 Antti Koivisto + +REGRESSION (r161195): Acid2 regression tests frequently fail +https://bugs.webkit.org/show_bug.cgi?id=126432 + +Reviewed by Anders Carlsson. + +We would occasionally dump the render tree before the actual last resource on the page was loaded. +The problematic resource is an image loaded by an tag nested as fallback of another . + +* html/HTMLObjectElement.cpp: +(WebCore::HTMLObjectElement::renderFallbackContent): + +Force style recalc when rendering fallback content. The current mechanism for triggering the fallback content load +requires a style recalc. + 2014-01-07 Andreas Kling createAnonymousMathMLBlock() should return RenderPtr. Modified: trunk/Source/WebCore/html/HTMLObjectElement.cpp (161483 => 161484) --- trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-01-08 07:02:54 UTC (rev 161483) +++ trunk/Source/WebCore/html/HTMLObjectElement.cpp 2014-01-08 07:33:10 UTC (rev 161484) @@ -386,6 +386,11 @@ } m_useFallbackContent = true; + +// This is here mainly to keep acid2 non-flaky. A style recalc is required to make fallback resources to load. Without forcing +// this may happen after all the other resources have been loaded and the document is already considered complete. +// FIXME: Disentangle fallback content handling from style recalcs. +document().updateStyleIfNeeded(); } // FIXME: This should be removed, all callers are almost certainly wrong. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161483] branches/jsCStack/Source/JavaScriptCore
Title: [161483] branches/jsCStack/Source/_javascript_Core
Revision 161483
Author fpi...@apple.com
Date 2014-01-07 23:02:54 -0800 (Tue, 07 Jan 2014)
Log Message
CStack: Call linking should log call linking for DFG and FTL code blocks if --showDFGDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=126617
Not yet reviewed.
* jit/Repatch.cpp:
(JSC::linkFor):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/jit/Repatch.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161482 => 161483)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 06:42:50 UTC (rev 161482)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 07:02:54 UTC (rev 161483)
@@ -1,5 +1,15 @@
2014-01-07 Filip Pizlo
+CStack: Call linking should log call linking for DFG and FTL code blocks if --showDFGDisassembly=true
+https://bugs.webkit.org/show_bug.cgi?id=126617
+
+Not yet reviewed.
+
+* jit/Repatch.cpp:
+(JSC::linkFor):
+
+2014-01-07 Filip Pizlo
+
Merge trunk r161465.
2014-01-07 Filip Pizlo
Modified: branches/jsCStack/Source/_javascript_Core/jit/Repatch.cpp (161482 => 161483)
--- branches/jsCStack/Source/_javascript_Core/jit/Repatch.cpp 2014-01-08 06:42:50 UTC (rev 161482)
+++ branches/jsCStack/Source/_javascript_Core/jit/Repatch.cpp 2014-01-08 07:02:54 UTC (rev 161483)
@@ -1298,7 +1298,7 @@
ASSERT(!callLinkInfo.isLinked());
callLinkInfo.callee.set(exec->callerFrame()->vm(), callLinkInfo.hotPathBegin, callerCodeBlock->ownerExecutable(), callee);
callLinkInfo.lastSeenCallee.set(exec->callerFrame()->vm(), callerCodeBlock->ownerExecutable(), callee);
-if (Options::showDisassembly())
+if (shouldShowDisassemblyFor(callerCodeBlock))
dataLog("Linking call in ", *callerCodeBlock, " at ", callLinkInfo.codeOrigin, " to ", pointerDump(calleeCodeBlock), ", entrypoint at ", codePtr, "\n");
repatchBuffer.relink(callLinkInfo.hotPathOther, codePtr);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161482] trunk/Source/WebCore
Title: [161482] trunk/Source/WebCore
Revision 161482
Author akl...@apple.com
Date 2014-01-07 22:42:50 -0800 (Tue, 07 Jan 2014)
Log Message
createAnonymousMathMLBlock() should return RenderPtr.
Reviewed by Antti Koivisto.
* rendering/mathml/RenderMathMLBlock.h:
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
Make this return a RenderPtr and removed the
EDisplay argument since it was always using the default (FLEX.)
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::addChild):
Updated for the new createAnonymousMathMLBlock() signature.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161481 => 161482)
--- trunk/Source/WebCore/ChangeLog 2014-01-08 05:45:55 UTC (rev 161481)
+++ trunk/Source/WebCore/ChangeLog 2014-01-08 06:42:50 UTC (rev 161482)
@@ -1,3 +1,22 @@
+2014-01-07 Andreas Kling
+
+createAnonymousMathMLBlock() should return RenderPtr.
+
+
+Reviewed by Antti Koivisto.
+
+* rendering/mathml/RenderMathMLBlock.h:
+* rendering/mathml/RenderMathMLBlock.cpp:
+(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
+
+Make this return a RenderPtr and removed the
+EDisplay argument since it was always using the default (FLEX.)
+
+* rendering/mathml/RenderMathMLFraction.cpp:
+(WebCore::RenderMathMLFraction::addChild):
+
+Updated for the new createAnonymousMathMLBlock() signature.
+
2014-01-07 Eric Carlson
Teach MediaSessionManager to manage interruptions
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp (161481 => 161482)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp 2014-01-08 05:45:55 UTC (rev 161481)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp 2014-01-08 06:42:50 UTC (rev 161482)
@@ -60,9 +60,9 @@
return child.node() && isElement(*child.node());
}
-RenderMathMLBlock* RenderMathMLBlock::createAnonymousMathMLBlock(EDisplay display)
+RenderPtr RenderMathMLBlock::createAnonymousMathMLBlock()
{
-RenderMathMLBlock* newBlock = new RenderMathMLBlock(document(), RenderStyle::createAnonymousStyleWithDisplay(&style(), display));
+RenderPtr newBlock = createRenderer(document(), RenderStyle::createAnonymousStyleWithDisplay(&style(), FLEX));
newBlock->initializeStyle();
return newBlock;
}
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h (161481 => 161482)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h 2014-01-08 05:45:55 UTC (rev 161481)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h 2014-01-08 06:42:50 UTC (rev 161482)
@@ -62,7 +62,7 @@
#endif
// Create a new RenderMathMLBlock, with a new style inheriting from this->style().
-RenderMathMLBlock* createAnonymousMathMLBlock(EDisplay = FLEX);
+RenderPtr createAnonymousMathMLBlock();
void setIgnoreInAccessibilityTree(bool flag) { m_ignoreInAccessibilityTree = flag; }
bool ignoreInAccessibilityTree() const { return m_ignoreInAccessibilityTree; }
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp (161481 => 161482)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp 2014-01-08 05:45:55 UTC (rev 161481)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp 2014-01-08 06:42:50 UTC (rev 161482)
@@ -90,13 +90,13 @@
void RenderMathMLFraction::addChild(RenderObject* child, RenderObject* /* beforeChild */)
{
if (isEmpty()) {
-RenderMathMLBlock* numeratorWrapper = createAnonymousMathMLBlock();
-RenderMathMLBlock::addChild(numeratorWrapper);
-fixChildStyle(numeratorWrapper);
+RenderPtr numeratorWrapper = createAnonymousMathMLBlock();
+fixChildStyle(numeratorWrapper.get());
+RenderMathMLBlock::addChild(numeratorWrapper.leakPtr());
-RenderMathMLBlock* denominatorWrapper = createAnonymousMathMLBlock();
-RenderMathMLBlock::addChild(denominatorWrapper);
-fixChildStyle(denominatorWrapper);
+RenderPtr denominatorWrapper = createAnonymousMathMLBlock();
+fixChildStyle(denominatorWrapper.get());
+RenderMathMLBlock::addChild(denominatorWrapper.leakPtr());
}
if (firstChild()->isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161480] trunk/PerformanceTests
Title: [161480] trunk/PerformanceTests Revision 161480 Author rn...@webkit.org Date 2014-01-07 19:58:16 -0800 (Tue, 07 Jan 2014) Log Message DoYouEvenBench: Turn BenchmarkRunner into a real class https://bugs.webkit.org/show_bug.cgi?id=126613 Reviewed by Stephanie Lewis. Made BenchmarkRunner an instantiatable class. Made tests.js simply create an array of suite objects instead of calling BenchmarkRunner.Suite now that we can have mulitple instances of BenchmarkRunner. * DoYouEvenBench/benchmark.html: (formatTestName): Moved and renamed from BenchmarkRunner._testName. (createUIForSuites): Extracted from a giant blob of code. (startTest): Ditto. * DoYouEvenBench/resources/benchmark-runner.js: (BenchmarkRunner): Added. (BenchmarkRunner.prototype.waitForElement): (BenchmarkRunner.prototype._removeFrame): (BenchmarkRunner.prototype._appendFrame): (BenchmarkRunner.prototype._waitAndWarmUp): (BenchmarkRunner.prototype._runTest): (BenchmarkState.prototype.prepareCurrentSuite): (BenchmarkRunner.prototype.step): (BenchmarkRunner.prototype._runTestAndRecordResults): (BenchmarkRunner.prototype._finalize): * DoYouEvenBench/resources/tests.js: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/DoYouEvenBench/benchmark.html trunk/PerformanceTests/DoYouEvenBench/resources/benchmark-runner.js trunk/PerformanceTests/DoYouEvenBench/resources/tests.js Diff Modified: trunk/PerformanceTests/ChangeLog (161479 => 161480) --- trunk/PerformanceTests/ChangeLog 2014-01-08 03:26:02 UTC (rev 161479) +++ trunk/PerformanceTests/ChangeLog 2014-01-08 03:58:16 UTC (rev 161480) @@ -1,5 +1,32 @@ 2014-01-07 Ryosuke Niwa +DoYouEvenBench: Turn BenchmarkRunner into a real class +https://bugs.webkit.org/show_bug.cgi?id=126613 + +Reviewed by Stephanie Lewis. + +Made BenchmarkRunner an instantiatable class. Made tests.js simply create an array of suite objects +instead of calling BenchmarkRunner.Suite now that we can have mulitple instances of BenchmarkRunner. + +* DoYouEvenBench/benchmark.html: +(formatTestName): Moved and renamed from BenchmarkRunner._testName. +(createUIForSuites): Extracted from a giant blob of code. +(startTest): Ditto. +* DoYouEvenBench/resources/benchmark-runner.js: +(BenchmarkRunner): Added. +(BenchmarkRunner.prototype.waitForElement): +(BenchmarkRunner.prototype._removeFrame): +(BenchmarkRunner.prototype._appendFrame): +(BenchmarkRunner.prototype._waitAndWarmUp): +(BenchmarkRunner.prototype._runTest): +(BenchmarkState.prototype.prepareCurrentSuite): +(BenchmarkRunner.prototype.step): +(BenchmarkRunner.prototype._runTestAndRecordResults): +(BenchmarkRunner.prototype._finalize): +* DoYouEvenBench/resources/tests.js: + +2014-01-07 Ryosuke Niwa + DoYouEvenBench: Extract tests and runner code from benchmark.js/html https://bugs.webkit.org/show_bug.cgi?id=126596 Modified: trunk/PerformanceTests/DoYouEvenBench/benchmark.html (161479 => 161480) --- trunk/PerformanceTests/DoYouEvenBench/benchmark.html 2014-01-08 03:26:02 UTC (rev 161479) +++ trunk/PerformanceTests/DoYouEvenBench/benchmark.html 2014-01-08 03:58:16 UTC (rev 161480) @@ -16,11 +16,12 @@-window.addEventListener('load', function () { -var self = BenchmarkRunner;+function formatTestName(suiteName, testName) { +return suiteName + (testName ? '/' + testName : ''); +} + +function createUIForSuites(suites, onstep, onrun) { var control = document.createElement('nav');- -var suites = BenchmarkRunner._suites;var ol = document.createElement('ol'); var checkboxes = []; for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { @@ -36,7 +37,7 @@ li.appendChild(checkbox); var label = document.createElement('label');-label.appendChild(document.createTextNode(self._testName(suite)));+label.appendChild(document.createTextNode(formatTestName(suite.name))); li.appendChild(label); label.htmlFor = checkbox.id; @@ -47,7 +48,7 @@ var anchor = document.createElement('a'); anchor.id = suite.name + '-' + test.name; test.anchor = anchor;-anchor.appendChild(document.createTextNode(self._testName(suite, test.name)));+anchor.appendChild(document.createTextNode(formatTestName(suite.name, test.name)));
[webkit-changes] [161479] trunk/Source/WebKit/mac
Title: [161479] trunk/Source/WebKit/mac Revision 161479 Author aes...@apple.com Date 2014-01-07 19:26:02 -0800 (Tue, 07 Jan 2014) Log Message [iOS] Clean up some exported headers https://bugs.webkit.org/show_bug.cgi?id=126403 Reviewed by Simon Fraser. Public header files that are completely excluded on iOS don't need !TARGET_OS_IPHONE guards since they are already listed in EXCLUDED_SOURCE_FILE_NAMES. I also took the opportunity to sort EXCLUDED_SOURCE_FILE_NAMES and to clean up some #imports. * Configurations/WebKit.xcconfig: * Misc/WebCache.h: * Misc/WebIconDatabasePrivate.h: * Misc/WebLocalizableStrings.h: * Misc/WebNSEventExtras.h: * Misc/WebNSPasteboardExtras.h: * Misc/WebNSWindowExtras.h: * Panels/WebPanelAuthenticationHandler.h: * Plugins/WebPluginsPrivate.h: * Storage/WebDatabaseManagerPrivate.h: * WebCoreSupport/WebJavaScriptTextInputPanel.h: * WebCoreSupport/WebKeyGenerator.h: * WebCoreSupport/WebSecurityOriginPrivate.h: * WebView/WebDashboardRegion.h: * WebView/WebDynamicScrollBarsView.h: * WebView/WebFrameView.h: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebResourceLoadDelegatePrivate.h: * WebView/WebView.h: Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig trunk/Source/WebKit/mac/Misc/WebIconDatabasePrivate.h trunk/Source/WebKit/mac/Misc/WebNSEventExtras.h trunk/Source/WebKit/mac/Misc/WebNSPasteboardExtras.h trunk/Source/WebKit/mac/Misc/WebNSWindowExtras.h trunk/Source/WebKit/mac/Panels/WebPanelAuthenticationHandler.h trunk/Source/WebKit/mac/Plugins/WebPluginsPrivate.h trunk/Source/WebKit/mac/Storage/WebDatabaseManagerPrivate.h trunk/Source/WebKit/mac/WebCoreSupport/WebJavaScriptTextInputPanel.h trunk/Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.h trunk/Source/WebKit/mac/WebView/WebDashboardRegion.h trunk/Source/WebKit/mac/WebView/WebFrameView.h trunk/Source/WebKit/mac/WebView/WebView.h Diff Modified: trunk/Source/WebKit/mac/ChangeLog (161478 => 161479) --- trunk/Source/WebKit/mac/ChangeLog 2014-01-08 02:41:59 UTC (rev 161478) +++ trunk/Source/WebKit/mac/ChangeLog 2014-01-08 03:26:02 UTC (rev 161479) @@ -1,3 +1,37 @@ +2014-01-02 Andy Estes + +[iOS] Clean up some exported headers +https://bugs.webkit.org/show_bug.cgi?id=126403 + +Reviewed by Simon Fraser. + +Public header files that are completely excluded on iOS don't need +!TARGET_OS_IPHONE guards since they are already listed in +EXCLUDED_SOURCE_FILE_NAMES. + +I also took the opportunity to sort EXCLUDED_SOURCE_FILE_NAMES and to +clean up some #imports. + +* Configurations/WebKit.xcconfig: +* Misc/WebCache.h: +* Misc/WebIconDatabasePrivate.h: +* Misc/WebLocalizableStrings.h: +* Misc/WebNSEventExtras.h: +* Misc/WebNSPasteboardExtras.h: +* Misc/WebNSWindowExtras.h: +* Panels/WebPanelAuthenticationHandler.h: +* Plugins/WebPluginsPrivate.h: +* Storage/WebDatabaseManagerPrivate.h: +* WebCoreSupport/WebJavaScriptTextInputPanel.h: +* WebCoreSupport/WebKeyGenerator.h: +* WebCoreSupport/WebSecurityOriginPrivate.h: +* WebView/WebDashboardRegion.h: +* WebView/WebDynamicScrollBarsView.h: +* WebView/WebFrameView.h: +* WebView/WebPreferenceKeysPrivate.h: +* WebView/WebResourceLoadDelegatePrivate.h: +* WebView/WebView.h: + 2014-01-07 Seokju Kwon Web Inspector: Remove leftover 'device metrics' code Modified: trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig (161478 => 161479) --- trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig 2014-01-08 02:41:59 UTC (rev 161478) +++ trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig 2014-01-08 03:26:02 UTC (rev 161479) @@ -25,9 +25,9 @@ #include "Version.xcconfig" EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_SOURCE_FILE_NAMES_$(PLATFORM_NAME)); -EXCLUDED_SOURCE_FILE_NAMES_iphoneos = *.nib *.pdf *.tiff WebIconDatabase.h WebIconDatabasePrivate.h WebNSEventExtras.h WebNSPasteboardExtras.h WebNSWindowExtras.h WebPanelAuthenticationHandler.h WebPluginsPrivate.h WebJavaScriptTextInputPanel.h WebKeyGenerator.h WebDashboardRegion.h WebDynamicScrollBarsView.h; +EXCLUDED_SOURCE_FILE_NAMES_iphoneos = *.nib *.pdf *.tiff WebDashboardRegion.h WebDynamicScrollBarsView.h WebIconDatabase.h WebIconDatabasePrivate.h WebJavaScriptTextInputPanel.h WebKeyGenerator.h WebNSEventExtras.h WebNSPasteboardExtras.h WebNSWindowExtras.h WebPanelAuthenticationHandler.h WebPluginsPrivate.h; EXCLUDED_SOURCE_FILE_NAMES_iphonesimulator = $(EXCLUDED_SOURCE_FILE_NAMES_iphoneos); -EXCLUDED_SOURCE_FILE_NAMES_macosx = *IOS.mm MemoryMeasure.h WebGeolocationCoreLocationProvider.h WebGeolocationProviderIOS.h WebNSStringDrawing.h WebNSStringExtrasIOS.h WebNSStringExtrasIPhone.h WebUIKitSupport.h WebCaretChangeListener.h WebFixedPositionContent.h WebFrameIOS.h WebFrameIPhone.h WebGeolocationPrivate.h WebMIMETypeRegistry.h WebSelectionR
[webkit-changes] [161477] trunk
Title: [161477] trunk
Revision 161477
Author seo...@webkit.org
Date 2014-01-07 18:20:46 -0800 (Tue, 07 Jan 2014)
Log Message
Web Inspector: Remove leftover 'device metrics' code
https://bugs.webkit.org/show_bug.cgi?id=126607
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, No changes in behavior.
Removes unused code related to 'device metrics'.
* css/MediaQueryEvaluator.cpp:
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
* inspector/InspectorClient.h:
* inspector/InspectorInstrumentation.cpp:
* inspector/InspectorInstrumentation.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::didLayout):
* inspector/InspectorPageAgent.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
* page/Screen.cpp:
(WebCore::Screen::height):
(WebCore::Screen::width):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processSubtree):
Source/WebKit/blackberry:
Clean up after removing InspectorClient::overrideDeviceMetrics().
* WebCoreSupport/InspectorClientBlackBerry.cpp:
* WebCoreSupport/InspectorClientBlackBerry.h:
Source/WebKit/mac:
* WebKit.order: Update after removing InspectorClient::overrideDeviceMetrics().
Source/WebKit2:
* mac/WebKit2.order: Update after removing InspectorClient::overrideDeviceMetrics().
LayoutTests:
* inspector/styles/override-screen-size-expected.txt: Removed.
* inspector/styles/override-screen-size.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/MediaQueryEvaluator.cpp
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/Screen.cpp
trunk/Source/WebCore/rendering/TextAutosizer.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebKit.order
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/mac/WebKit2.order
Removed Paths
trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt
trunk/LayoutTests/inspector/styles/override-screen-size.html
Diff
Modified: trunk/LayoutTests/ChangeLog (161476 => 161477)
--- trunk/LayoutTests/ChangeLog 2014-01-08 01:35:35 UTC (rev 161476)
+++ trunk/LayoutTests/ChangeLog 2014-01-08 02:20:46 UTC (rev 161477)
@@ -1,3 +1,13 @@
+2014-01-07 Seokju Kwon
+
+Web Inspector: Remove leftover 'device metrics' code
+https://bugs.webkit.org/show_bug.cgi?id=126607
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/styles/override-screen-size-expected.txt: Removed.
+* inspector/styles/override-screen-size.html: Removed.
+
2014-01-07 Brent Fulgham
Unreviewed test fix: Correct whitespace around ]
Deleted: trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt (161476 => 161477)
--- trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt 2014-01-08 01:35:35 UTC (rev 161476)
+++ trunk/LayoutTests/inspector/styles/override-screen-size-expected.txt 2014-01-08 02:20:46 UTC (rev 161477)
@@ -1,49 +0,0 @@
-Tests that screen dimension overrides affect media rules, body dimensions, and window.screen.
-
-Override: 480x800
-Screen from page: 480x800
-Window from page: 480x800
-Body from page: 480x800
-Main style:
-[expanded]
-element.style { ()
-
- Matched CSS Rules
-[expanded]
-media="screen" (override-screen-size.html)
-@media (max-device-height: 960px) and (max-device-width: 480px) (override-screen-size.html:9)
-#main { (override-screen-size.html:10)
-background: green;
-
-[expanded]
-div { (user agent stylesheet)
-display: block;
-
-
-Override: 800x480
-Screen from page: 800x480
-Window from page: 800x480
-Body from page: 800x480
-Main style:
-[expanded]
-element.style { ()
-
- Matched CSS Rules
-[expanded]
-div { (user agent stylesheet)
-display: block;
-
-
-Override: 1001x800 => ERROR
-Override: -1x800 => ERROR
-Override: 480x1001 => ERROR
-Override: 480x-1 => ERROR
-Current dimensions:
-Screen from page: 800x480
-Window from page: 800x480
-Body from page: 800x480
-Disable PageAgent:
-Screen size same as original - OK
-Enable PageAgent:
-Screen size same as original - OK
-
Deleted: trunk/LayoutTests/inspector/styles/override-screen-size.html (161476 => 161477)
--- trunk/LayoutTests/inspector/styles/override-screen-size.html 2014-01-08 01:35:35 UTC (rev 161476)
+++ trunk/LayoutTests/inspector/styles/override-screen-size.html 2014-01-08 02:20:46 UTC (rev 161477)
@@ -1,219 +0,0 @@
[webkit-changes] [161476] trunk/Source/WebKit2
Title: [161476] trunk/Source/WebKit2
Revision 161476
Author simon.fra...@apple.com
Date 2014-01-07 17:35:35 -0800 (Tue, 07 Jan 2014)
Log Message
Fix the build. The WebKit2 project copied all of WebKit2/Scripts/webkit2 into WebKit2.framework/PrivateHeaders,
but that's bad because there are test result files in there now. Fix by having the project copy specific
.py files into rivateHeaders/webkit2
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161475 => 161476)
--- trunk/Source/WebKit2/ChangeLog 2014-01-08 01:16:01 UTC (rev 161475)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-08 01:35:35 UTC (rev 161476)
@@ -1,5 +1,13 @@
2014-01-07 Simon Fraser
+Fix the build. The WebKit2 project copied all of WebKit2/Scripts/webkit2 into WebKit2.framework/PrivateHeaders,
+but that's bad because there are test result files in there now. Fix by having the project copy specific
+.py files into rivateHeaders/webkit2
+
+* WebKit2.xcodeproj/project.pbxproj:
+
+2014-01-07 Simon Fraser
+
Make it possible for MessageReceivers to pass messages to their superclass, and use it for RemoteLayerTreeDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=126558
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (161475 => 161476)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-01-08 01:16:01 UTC (rev 161475)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-01-08 01:35:35 UTC (rev 161476)
@@ -60,6 +60,10 @@
0F5947A7187B517600437857 /* RemoteScrollingCoordinatorMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F5947A5187B517600437857 /* RemoteScrollingCoordinatorMessageReceiver.cpp */; };
0F5947A8187B517600437857 /* RemoteScrollingCoordinatorMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F5947A6187B517600437857 /* RemoteScrollingCoordinatorMessages.h */; };
0FB659231208B4DB0044816C /* DrawingAreaInfo.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FB659221208B4DB0044816C /* DrawingAreaInfo.h */; };
+ 0FC08572187CE0B100780D86 /* __init__.py in Copy Message Generation Scripts */ = {isa = PBXBuildFile; fileRef = 0FC0856E187CE0A900780D86 /* __init__.py */; };
+ 0FC08573187CE0B300780D86 /* messages.py in Copy Message Generation Scripts */ = {isa = PBXBuildFile; fileRef = 0FC0856F187CE0A900780D86 /* messages.py */; };
+ 0FC08574187CE0B400780D86 /* model.py in Copy Message Generation Scripts */ = {isa = PBXBuildFile; fileRef = 0FC08570187CE0A900780D86 /* model.py */; };
+ 0FC08575187CE0B600780D86 /* parser.py in Copy Message Generation Scripts */ = {isa = PBXBuildFile; fileRef = 0FC08571187CE0A900780D86 /* parser.py */; };
0FF24A2D1879E4BC003ABF0C /* RemoteLayerTreeDrawingAreaProxyMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FF24A2B1879E4BC003ABF0C /* RemoteLayerTreeDrawingAreaProxyMessageReceiver.cpp */; };
0FF24A2E1879E4BC003ABF0C /* RemoteLayerTreeDrawingAreaProxyMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FF24A2C1879E4BC003ABF0C /* RemoteLayerTreeDrawingAreaProxyMessages.h */; };
1A043976124D034800FFBFB5 /* PluginProcess.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A043974124D034800FFBFB5 /* PluginProcess.h */; };
@@ -736,7 +740,6 @@
51FD18B61651FBAD00DBE1CE /* NetworkResourceLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 51FD18B41651FBAD00DBE1CE /* NetworkResourceLoader.h */; };
5272B28A1406985D0096A5D0 /* StatisticsData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5272B2881406985D0096A5D0 /* StatisticsData.cpp */; };
5272B28B1406985D0096A5D0 /* StatisticsData.h in Headers */ = {isa = PBXBuildFile; fileRef = 5272B2891406985D0096A5D0 /* StatisticsData.h */; };
- 5D1A239115E75B220023E981 /* webkit2 in Copy Message Generation Scripts */ = {isa = PBXBuildFile; fileRef = 5D1A238E15E75AD50023E981 /* webkit2 */; };
5DA6ED0A1490606900B41D12 /* DynamicLinkerEnvironmentExtractor.h in Headers */ = {isa = PBXBuildFile; fileRef = 5DA6ED081490606900B41D12 /* DynamicLinkerEnvironmentExtractor.h */; };
5DA6ED0B1490606900B41D12 /* DynamicLinkerEnvironmentExtractor.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5DA6ED091490606900B41D12 /* DynamicLinkerEnvironmentExtractor.mm */; };
6501BD1A12F1243400E9F248 /* WKBundleInspector.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 65B86F1712F11D7B00B7DD8A /* WKBundleInspector.cpp */; };
@@ -1543,10 +1546,13 @@
5D1A239015E75B100023E981 /* Copy Message Generation Scripts */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
- dstPath = PrivateHeaders;
+ dstPath = PrivateHeaders/webkit2;
dstSubfolderSpec = 1;
files = (
-5D1A239115E75B220023E981 /* webkit2 in Copy Message Generation Scripts */,
+0FC08572187CE0B100780D86 /* __init__.py in Copy Message Generation Scripts */,
+0FC085
[webkit-changes] [161475] trunk/LayoutTests
Title: [161475] trunk/LayoutTests Revision 161475 Author bfulg...@apple.com Date 2014-01-07 17:16:01 -0800 (Tue, 07 Jan 2014) Log Message Unreviewed test fix: Correct whitespace around ] * platform/mac/TestExpectations: "Debug]" should be "Debug ]" Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (161474 => 161475) --- trunk/LayoutTests/ChangeLog 2014-01-08 01:03:48 UTC (rev 161474) +++ trunk/LayoutTests/ChangeLog 2014-01-08 01:16:01 UTC (rev 161475) @@ -1,3 +1,9 @@ +2014-01-07 Brent Fulgham + +Unreviewed test fix: Correct whitespace around ] + +* platform/mac/TestExpectations: "Debug]" should be "Debug ]" + 2014-01-07 Victor Costan createElementNS handles element name 'xmlns' correctly. Modified: trunk/LayoutTests/platform/mac/TestExpectations (161474 => 161475) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-01-08 01:03:48 UTC (rev 161474) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-01-08 01:16:01 UTC (rev 161475) @@ -1312,7 +1312,7 @@ # GL Scissors don't work properly in Mountain Lion. webkit.org/b/126455 [ MountainLion ] webgl/1.0.2/conformance/rendering/gl-scissor-test.html [ Failure ] -webkit.org/b/126586 [ Mavericks Debug] webgl/1.0.2/conformance/rendering/gl-scissor-test.html [ Pass Failure ] +webkit.org/b/126586 [ Mavericks Debug ] webgl/1.0.2/conformance/rendering/gl-scissor-test.html [ Pass Failure ] # HTTP Auth in Media is not supported in Mavericks and Mountain Lion webkit.org/b/40382 http/tests/media/video-auth.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161473] trunk/Source/WebKit2
Title: [161473] trunk/Source/WebKit2 Revision 161473 Author simon.fra...@apple.com Date 2014-01-07 17:03:46 -0800 (Tue, 07 Jan 2014) Log Message Add message-generation test for non-legacy message receiver https://bugs.webkit.org/show_bug.cgi?id=126603 Reviewed by Anders Carlsson. Add expected output files for a non-legacy message receiver, and add testing for same. * Scripts/webkit2/LegacyMessageReceiver-expected.cpp: Copied from Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp. * Scripts/webkit2/LegacyMessages-expected.h: Added. * Scripts/webkit2/MessageReceiver-expected.cpp: (WebKit::WebPage::didReceiveMessage): (WebKit::WebPage::didReceiveSyncMessage): * Scripts/webkit2/messages_unittest.py: (MessagesTest.setUp): (ParsingTest.test_receiver): (HeaderTest.test_header): (ReceiverImplementationTest.test_receiver_implementation): * Scripts/webkit2/test-legacy-messages.in: Copied from Source/WebKit2/Scripts/webkit2/test-messages.in. * Scripts/webkit2/test-messages.in: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py trunk/Source/WebKit2/Scripts/webkit2/test-messages.in Added Paths trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h trunk/Source/WebKit2/Scripts/webkit2/test-legacy-messages.in Diff Modified: trunk/Source/WebKit2/ChangeLog (161472 => 161473) --- trunk/Source/WebKit2/ChangeLog 2014-01-08 01:03:44 UTC (rev 161472) +++ trunk/Source/WebKit2/ChangeLog 2014-01-08 01:03:46 UTC (rev 161473) @@ -1,5 +1,28 @@ 2014-01-07 Simon Fraser +Add message-generation test for non-legacy message receiver +https://bugs.webkit.org/show_bug.cgi?id=126603 + +Reviewed by Anders Carlsson. + +Add expected output files for a non-legacy message receiver, and add +testing for same. + +* Scripts/webkit2/LegacyMessageReceiver-expected.cpp: Copied from Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp. +* Scripts/webkit2/LegacyMessages-expected.h: Added. +* Scripts/webkit2/MessageReceiver-expected.cpp: +(WebKit::WebPage::didReceiveMessage): +(WebKit::WebPage::didReceiveSyncMessage): +* Scripts/webkit2/messages_unittest.py: +(MessagesTest.setUp): +(ParsingTest.test_receiver): +(HeaderTest.test_header): +(ReceiverImplementationTest.test_receiver_implementation): +* Scripts/webkit2/test-legacy-messages.in: Copied from Source/WebKit2/Scripts/webkit2/test-messages.in. +* Scripts/webkit2/test-messages.in: + +2014-01-07 Simon Fraser + Move expected results out of messages_unittest.py into separate files https://bugs.webkit.org/show_bug.cgi?id=126602 Copied: trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp (from rev 161472, trunk/Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp) (0 => 161473) --- trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp (rev 0) +++ trunk/Source/WebKit2/Scripts/webkit2/LegacyMessageReceiver-expected.cpp 2014-01-08 01:03:46 UTC (rev 161473) @@ -0,0 +1,218 @@ +/* + * Copyright (C) 2010 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "config.h" + +#if (ENABLE(WEBKIT2) && (NESTED_MASTER_CONDITION || MASTER_OR && MASTER_AND)) + +#include "WebPage.h" + +#include "ArgumentCoders.h" +#include "Connection.h" +#if ENABLE(DEPRECATED_FEATURE) || ENABLE(EXPERIMENTAL_FEATURE) +#include "DummyType.h" +#endif +#include "HandleMessage.h" +#if
[webkit-changes] [161474] trunk/Source/WebKit2
Title: [161474] trunk/Source/WebKit2
Revision 161474
Author simon.fra...@apple.com
Date 2014-01-07 17:03:48 -0800 (Tue, 07 Jan 2014)
Log Message
Make it possible for MessageReceivers to pass messages to their superclass, and use it for RemoteLayerTreeDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=126558
Reviewed by Anders Carlsson.
In a message.in file it's now possible to say:
messages -> Subclass : Superclass { ... } and the generated code will
call Superclass::didReceiveMessage().
Use this to have RemoteLayerTreeDrawingAreaProxy pass messages up to
DrawingAreaProxy.
* Scripts/webkit2/messages.py:
(generate_message_handler):
* Scripts/webkit2/model.py:
(MessageReceiver.__init__):
* Scripts/webkit2/parser.py:
(parse):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/webkit2/messages.py
trunk/Source/WebKit2/Scripts/webkit2/messages_unittest.py
trunk/Source/WebKit2/Scripts/webkit2/model.py
trunk/Source/WebKit2/Scripts/webkit2/parser.py
trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in
Added Paths
trunk/Source/WebKit2/Scripts/webkit2/MessageReceiverSuperclass-expected.cpp
trunk/Source/WebKit2/Scripts/webkit2/MessagesSuperclass-expected.h
trunk/Source/WebKit2/Scripts/webkit2/test-superclass-messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161473 => 161474)
--- trunk/Source/WebKit2/ChangeLog 2014-01-08 01:03:46 UTC (rev 161473)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-08 01:03:48 UTC (rev 161474)
@@ -1,5 +1,29 @@
2014-01-07 Simon Fraser
+Make it possible for MessageReceivers to pass messages to their superclass, and use it for RemoteLayerTreeDrawingAreaProxy
+https://bugs.webkit.org/show_bug.cgi?id=126558
+
+Reviewed by Anders Carlsson.
+
+In a message.in file it's now possible to say:
+
+messages -> Subclass : Superclass { ... } and the generated code will
+call Superclass::didReceiveMessage().
+
+Use this to have RemoteLayerTreeDrawingAreaProxy pass messages up to
+DrawingAreaProxy.
+
+* Scripts/webkit2/messages.py:
+(generate_message_handler):
+* Scripts/webkit2/model.py:
+(MessageReceiver.__init__):
+* Scripts/webkit2/parser.py:
+(parse):
+* UIProcess/DrawingAreaProxy.h:
+* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
+
+2014-01-07 Simon Fraser
+
Add message-generation test for non-legacy message receiver
https://bugs.webkit.org/show_bug.cgi?id=126603
Added: trunk/Source/WebKit2/Scripts/webkit2/MessageReceiverSuperclass-expected.cpp (0 => 161474)
--- trunk/Source/WebKit2/Scripts/webkit2/MessageReceiverSuperclass-expected.cpp (rev 0)
+++ trunk/Source/WebKit2/Scripts/webkit2/MessageReceiverSuperclass-expected.cpp 2014-01-08 01:03:48 UTC (rev 161474)
@@ -0,0 +1,46 @@
+/*
+ * Copyright (C) 2010 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#include "WebPage.h"
+
+#include "ArgumentCoders.h"
+#include "HandleMessage.h"
+#include "MessageDecoder.h"
+#include "WebPageMessages.h"
+#include
+
+namespace WebKit {
+
+void WebPage::didReceiveMessage(IPC::Connection* connection, IPC::MessageDecoder& decoder)
+{
+if (decoder.messageName() == Messages::WebPage::LoadURL::name()) {
+IPC::handleMessage(decoder, this, &WebPage::loadURL);
+return;
+}
+WebPageBase::didReceiveMessage(connection, decoder);
+}
+
+} // namespace WebKit
[webkit-changes] [161471] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Title: [161471] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Revision 161471
Author lforsch...@apple.com
Date 2014-01-07 16:51:30 -0800 (Tue, 07 Jan 2014)
Log Message
Add a scheduler for the CLoop bot.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (161470 => 161471)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-08 00:42:20 UTC (rev 161470)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-08 00:51:30 UTC (rev 161471)
@@ -195,7 +195,7 @@
"builderNames": ["Apple MountainLion Release (Build)", "Apple MountainLion Debug (Build)", "Apple MountainLion Release (32-bit Build)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "mac-mavericks", "branch": "trunk", "treeStableTimer": 45.0,
- "builderNames": ["Apple Mavericks Release (Build)", "Apple Mavericks Debug (Build)"]
+ "builderNames": ["Apple Mavericks Release (Build)", "Apple Mavericks Debug (Build)", "Apple Mavericks CLOOP (BuildAndTest)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "win", "branch": "trunk", "treeStableTimer": 45.0,
"builderNames": ["Apple Win Release (Build)", "Apple Win Debug (Build)"]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161469] trunk/Source/WebKit/mac
Title: [161469] trunk/Source/WebKit/mac
Revision 161469
Author aes...@apple.com
Date 2014-01-07 16:42:18 -0800 (Tue, 07 Jan 2014)
Log Message
[iOS] Upstream a bug fix for plugin-backed media elements
https://bugs.webkit.org/show_bug.cgi?id=126412
Reviewed by Eric Carlson.
Media elements backed by plug-ins should outlive being removed from the
document, like their native counterparts do.
* Plugins/WebPluginController.h:
* Plugins/WebPluginController.mm:
(-[NSView isMediaPlugInProxyView]):
(-[NSView setIsMediaPlugInProxyView:]):
(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(-[WebPluginController mediaPlugInProxyViewCreated:]):
(-[WebPluginController destroyPlugin:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(pluginView):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Plugins/WebPluginController.h
trunk/Source/WebKit/mac/Plugins/WebPluginController.mm
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (161468 => 161469)
--- trunk/Source/WebKit/mac/ChangeLog 2014-01-08 00:42:15 UTC (rev 161468)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-08 00:42:18 UTC (rev 161469)
@@ -1,3 +1,23 @@
+2014-01-02 Andy Estes
+
+[iOS] Upstream a bug fix for plugin-backed media elements
+https://bugs.webkit.org/show_bug.cgi?id=126412
+
+Reviewed by Eric Carlson.
+
+Media elements backed by plug-ins should outlive being removed from the
+document, like their native counterparts do.
+
+* Plugins/WebPluginController.h:
+* Plugins/WebPluginController.mm:
+(-[NSView isMediaPlugInProxyView]):
+(-[NSView setIsMediaPlugInProxyView:]):
+(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
+(-[WebPluginController mediaPlugInProxyViewCreated:]):
+(-[WebPluginController destroyPlugin:]):
+* WebCoreSupport/WebFrameLoaderClient.mm:
+(pluginView):
+
2014-01-07 Mark Rowe
DOMProgressEvent has unspecified availability
Modified: trunk/Source/WebKit/mac/Plugins/WebPluginController.h (161468 => 161469)
--- trunk/Source/WebKit/mac/Plugins/WebPluginController.h 2014-01-08 00:42:15 UTC (rev 161468)
+++ trunk/Source/WebKit/mac/Plugins/WebPluginController.h 2014-01-08 00:42:18 UTC (rev 161469)
@@ -50,7 +50,7 @@
#endif
}
-+ (NSView *)plugInViewWithArguments:(NSDictionary *)arguments fromPluginPackage:(WebPluginPackage *)plugin;
+- (NSView *)plugInViewWithArguments:(NSDictionary *)arguments fromPluginPackage:(WebPluginPackage *)plugin;
+ (BOOL)isPlugInView:(NSView *)view;
- (id)initWithDocumentView:(NSView *)view;
@@ -60,7 +60,7 @@
- (void)addPlugin:(NSView *)view;
- (void)destroyPlugin:(NSView *)view;
#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
-- (void)pluginViewCreated:(NSView *)view;
+- (void)mediaPlugInProxyViewCreated:(NSView *)view;
+ (void)pluginViewHidden:(NSView *)view;
#endif
Modified: trunk/Source/WebKit/mac/Plugins/WebPluginController.mm (161468 => 161469)
--- trunk/Source/WebKit/mac/Plugins/WebPluginController.mm 2014-01-08 00:42:15 UTC (rev 161468)
+++ trunk/Source/WebKit/mac/Plugins/WebPluginController.mm 2014-01-08 00:42:18 UTC (rev 161469)
@@ -30,6 +30,7 @@
#import "WebPluginController.h"
#import "DOMNodeInternal.h"
+#import "WebBasePluginPackage.h"
#import "WebDataSourceInternal.h"
#import "WebFrameInternal.h"
#import "WebFrameView.h"
@@ -117,17 +118,36 @@
}
#endif
+#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
+@interface NSView (WebPluginControllerAdditions)
+@property (nonatomic) BOOL isMediaPlugInProxyView;
+@end
+
+@implementation NSView (WebPluginControllerAdditions)
+
+- (BOOL)isMediaPlugInProxyView
+{
+return [(NSNumber *)objc_getAssociatedObject(self, @selector(isMediaPlugInProxyView)) boolValue];
+}
+
+- (void)setIsMediaPlugInProxyView:(BOOL)isMediaPlugInProxyView
+{
+objc_setAssociatedObject(self, @selector(isMediaPlugInProxyView), [NSNumber numberWithBool:isMediaPlugInProxyView], OBJC_ASSOCIATION_RETAIN_NONATOMIC);
+}
+
+@end
+#endif // ENABLE(PLUGIN_PROXY_FOR_VIDEO)
+
@implementation WebPluginController
-+ (NSView *)plugInViewWithArguments:(NSDictionary *)arguments fromPluginPackage:(WebPluginPackage *)pluginPackage
+- (NSView *)plugInViewWithArguments:(NSDictionary *)arguments fromPluginPackage:(WebPluginPackage *)pluginPackage
{
#if PLATFORM(IOS)
initializeAudioSession();
#endif
[pluginPackage load];
-Class viewFactory = [pluginPackage viewFactory];
-
+
NSView *view = nil;
#if PLATFORM(IOS)
@@ -137,6 +157,7 @@
view = [[webView _UIKitDelegateForwarder] webView:webView plugInViewWithArguments:arguments fromPlugInPackage:pluginPackage];
}
#else
+Class viewFactory = [pluginPackage viewFactory];
if ([viewFactory respondsToSelector:@selector(plugInViewWithArguments:)]) {
JSC::JSLock::DropAllLocks dropAllLocks(JSDOMWindowBase::commonVM());
view = [viewFactory pl
[webkit-changes] [161470] trunk/Source/WebKit/mac
Title: [161470] trunk/Source/WebKit/mac
Revision 161470
Author aes...@apple.com
Date 2014-01-07 16:42:20 -0800 (Tue, 07 Jan 2014)
Log Message
[iOS] Upstream WebKit support for various features
https://bugs.webkit.org/show_bug.cgi?id=126413
Reviewed by Sam Weinig.
Upstream iOS WebKit changes needed for these features:
- ENABLE(DELETION_UI)
- ENABLE(TOUCH_EVENTS)
- USE(QUICK_LOOK)
- USE(UIKIT_EDITING)
- ENABLE(DISK_IMAGE_CACHE)
- ENABLE(IOS_TEXT_AUTOSIZING)
- ENABLE(ICONDATABASE)
- ENABLE(DASHBOARD_SUPPORT)
* DefaultDelegates/WebDefaultEditingDelegate.m:
* Misc/WebCache.mm:
* WebCoreSupport/WebChromeClient.h:
* WebView/WebDataSource.mm:
(-[WebDataSource dealloc]):
* WebView/WebEditingDelegatePrivate.h:
* WebView/WebFrame.mm:
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView maintainsInactiveSelection]):
(-[WebHTMLView touch:]):
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _cacheFrameLoadDelegateImplementations]):
(-[WebView quickLookContentForURL:]):
(-[WebView _touchEventRegions]):
* WebView/WebViewPrivate.h:
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultEditingDelegate.m
trunk/Source/WebKit/mac/Misc/WebCache.mm
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/mac/WebView/WebDataSource.mm
trunk/Source/WebKit/mac/WebView/WebEditingDelegatePrivate.h
trunk/Source/WebKit/mac/WebView/WebFrame.mm
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewPrivate.h
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (161469 => 161470)
--- trunk/Source/WebKit/mac/ChangeLog 2014-01-08 00:42:18 UTC (rev 161469)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-08 00:42:20 UTC (rev 161470)
@@ -1,5 +1,44 @@
2014-01-02 Andy Estes
+[iOS] Upstream WebKit support for various features
+https://bugs.webkit.org/show_bug.cgi?id=126413
+
+Reviewed by Sam Weinig.
+
+Upstream iOS WebKit changes needed for these features:
+
+- ENABLE(DELETION_UI)
+- ENABLE(TOUCH_EVENTS)
+- USE(QUICK_LOOK)
+- USE(UIKIT_EDITING)
+- ENABLE(DISK_IMAGE_CACHE)
+- ENABLE(IOS_TEXT_AUTOSIZING)
+- ENABLE(ICONDATABASE)
+- ENABLE(DASHBOARD_SUPPORT)
+
+* DefaultDelegates/WebDefaultEditingDelegate.m:
+* Misc/WebCache.mm:
+* WebCoreSupport/WebChromeClient.h:
+* WebView/WebDataSource.mm:
+(-[WebDataSource dealloc]):
+* WebView/WebEditingDelegatePrivate.h:
+* WebView/WebFrame.mm:
+(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
+* WebView/WebHTMLView.mm:
+(-[WebHTMLView maintainsInactiveSelection]):
+(-[WebHTMLView touch:]):
+* WebView/WebPreferences.mm:
+(+[WebPreferences initialize]):
+* WebView/WebPreferencesPrivate.h:
+* WebView/WebView.mm:
+(-[WebView _preferencesChanged:]):
+(-[WebView _cacheFrameLoadDelegateImplementations]):
+(-[WebView quickLookContentForURL:]):
+(-[WebView _touchEventRegions]):
+* WebView/WebViewPrivate.h:
+
+2014-01-02 Andy Estes
+
[iOS] Upstream a bug fix for plugin-backed media elements
https://bugs.webkit.org/show_bug.cgi?id=126412
Modified: trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultEditingDelegate.m (161469 => 161470)
--- trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultEditingDelegate.m 2014-01-08 00:42:18 UTC (rev 161469)
+++ trunk/Source/WebKit/mac/DefaultDelegates/WebDefaultEditingDelegate.m 2014-01-08 00:42:20 UTC (rev 161470)
@@ -45,10 +45,12 @@
return sharedDelegate;
}
+#if ENABLE(DELETION_UI)
- (BOOL)webView:(WebView *)webView shouldShowDeleteInterfaceForElement:(DOMHTMLElement *)element
{
return NO;
}
+#endif
- (BOOL)webView:(WebView *)webView shouldBeginEditingInDOMRange:(DOMRange *)range
{
Modified: trunk/Source/WebKit/mac/Misc/WebCache.mm (161469 => 161470)
--- trunk/Source/WebKit/mac/Misc/WebCache.mm 2014-01-08 00:42:18 UTC (rev 161469)
+++ trunk/Source/WebKit/mac/Misc/WebCache.mm 2014-01-08 00:42:20 UTC (rev 161470)
@@ -47,6 +47,10 @@
#import
#endif
+#if ENABLE(CACHE_PARTITIONING)
+#import
+#endif
+
@implementation WebCache
+ (void)initialize
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h (161469 => 161470)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-01-08 00:42:18 UTC (rev 161469)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.h 2014-01-08 00:42:20 UTC (rev 161470)
@@ -152,6 +152,10 @@
virtual void enableSuddenTermination() OVERRIDE;
virtual void disa
[webkit-changes] [161468] trunk/Source
Title: [161468] trunk/Source
Revision 161468
Author aes...@apple.com
Date 2014-01-07 16:42:15 -0800 (Tue, 07 Jan 2014)
Log Message
[iOS] Upstream remainder of minimal-ui viewport changes
https://bugs.webkit.org/show_bug.cgi?id=126410
Reviewed by Sam Weinig.
Source/WebCore:
* dom/ViewportArguments.h:
Source/WebKit/ios:
* WebCoreSupport/WebChromeClientIOS.mm:
(dictionaryForViewportArguments):
* WebKit.iOS.exp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ViewportArguments.h
trunk/Source/WebKit/ios/ChangeLog
trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm
trunk/Source/WebKit/ios/WebKit.iOS.exp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161467 => 161468)
--- trunk/Source/WebCore/ChangeLog 2014-01-08 00:35:15 UTC (rev 161467)
+++ trunk/Source/WebCore/ChangeLog 2014-01-08 00:42:15 UTC (rev 161468)
@@ -1,3 +1,12 @@
+2014-01-02 Andy Estes
+
+[iOS] Upstream remainder of minimal-ui viewport changes
+https://bugs.webkit.org/show_bug.cgi?id=126410
+
+Reviewed by Sam Weinig.
+
+* dom/ViewportArguments.h:
+
2014-01-07 Victor Costan
createElementNS handles element name 'xmlns' correctly.
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (161467 => 161468)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2014-01-08 00:35:15 UTC (rev 161467)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2014-01-08 00:42:15 UTC (rev 161468)
@@ -51,9 +51,6 @@
float userScalable;
float orientation;
-#if PLATFORM(IOS)
-bool minimalUI;
-#endif
};
struct ViewportArguments {
@@ -115,6 +112,9 @@
float maxZoom;
float userZoom;
float orientation;
+#if PLATFORM(IOS)
+bool minimalUI;
+#endif
bool operator==(const ViewportArguments& other) const
{
Modified: trunk/Source/WebKit/ios/ChangeLog (161467 => 161468)
--- trunk/Source/WebKit/ios/ChangeLog 2014-01-08 00:35:15 UTC (rev 161467)
+++ trunk/Source/WebKit/ios/ChangeLog 2014-01-08 00:42:15 UTC (rev 161468)
@@ -1,3 +1,14 @@
+2014-01-02 Andy Estes
+
+[iOS] Upstream remainder of minimal-ui viewport changes
+https://bugs.webkit.org/show_bug.cgi?id=126410
+
+Reviewed by Sam Weinig.
+
+* WebCoreSupport/WebChromeClientIOS.mm:
+(dictionaryForViewportArguments):
+* WebKit.iOS.exp:
+
2013-12-31 Andy Estes
[iOS] Upstream PLATFORM(IOS) changes to Source/WebKit/
Modified: trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm (161467 => 161468)
--- trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2014-01-08 00:35:15 UTC (rev 161467)
+++ trunk/Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm 2014-01-08 00:42:15 UTC (rev 161468)
@@ -162,7 +162,8 @@
@"maximum-scale":@(arguments.maxZoom),
@"user-scalable":@(arguments.userZoom),
@"width":@(arguments.width),
- @"height":@(arguments.height) };
+ @"height":@(arguments.height),
+ @"minimal-ui":@(arguments.minimalUI) };
}
void WebChromeClientIOS::dispatchViewportPropertiesDidChange(const WebCore::ViewportArguments& arguments) const
Modified: trunk/Source/WebKit/ios/WebKit.iOS.exp (161467 => 161468)
--- trunk/Source/WebKit/ios/WebKit.iOS.exp 2014-01-08 00:35:15 UTC (rev 161467)
+++ trunk/Source/WebKit/ios/WebKit.iOS.exp 2014-01-08 00:42:15 UTC (rev 161468)
@@ -20,6 +20,7 @@
_WebViewportHeightKey
_WebViewportInitialScaleKey
_WebViewportMaximumScaleKey
+_WebViewportMinimalUIKey
_WebViewportMinimumScaleKey
_WebViewportUserScalableKey
_WebViewportWidthKey
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161467] branches/jsCStack/Source/JavaScriptCore
Title: [161467] branches/jsCStack/Source/_javascript_Core
Revision 161467
Author fpi...@apple.com
Date 2014-01-07 16:35:15 -0800 (Tue, 07 Jan 2014)
Log Message
Merge trunk r161465.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
Added Paths
branches/jsCStack/Source/_javascript_Core/tests/stress/bit-op-value-to-int32-input-liveness.js
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161466 => 161467)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 00:30:07 UTC (rev 161466)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 00:35:15 UTC (rev 161467)
@@ -1,5 +1,9 @@
2014-01-07 Filip Pizlo
+Merge trunk r161465.
+
+2014-01-07 Filip Pizlo
+
Add a test that got lost in some merge.
* tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp (161466 => 161467)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2014-01-08 00:30:07 UTC (rev 161466)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2014-01-08 00:35:15 UTC (rev 161467)
@@ -114,8 +114,7 @@
case BitOr:
case BitXor:
-case BitLShift:
-case ValueToInt32: {
+case BitLShift: {
return power > 31;
}
@@ -205,13 +204,6 @@
break;
}
-case ValueToInt32: {
-flags |= NodeBytecodeUsesAsInt;
-flags &= ~(NodeBytecodeUsesAsNumber | NodeBytecodeNeedsNegZero | NodeBytecodeUsesAsOther);
-node->child1()->mergeFlags(flags);
-break;
-}
-
case StringCharCodeAt: {
node->child1()->mergeFlags(NodeBytecodeUsesAsValue);
node->child2()->mergeFlags(NodeBytecodeUsesAsValue | NodeBytecodeUsesAsInt);
Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (161466 => 161467)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-01-08 00:30:07 UTC (rev 161466)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2014-01-08 00:35:15 UTC (rev 161467)
@@ -505,30 +505,6 @@
flush(m_inlineStackTop);
}
-// Get an operand, and perform a ToInt32/ToNumber conversion on it.
-Node* getToInt32(int operand)
-{
-return toInt32(get(VirtualRegister(operand)));
-}
-
-// Perform an ES5 ToInt32 operation - returns a node of type NodeResultInt32.
-Node* toInt32(Node* node)
-{
-if (node->hasInt32Result())
-return node;
-
-// Check for numeric constants boxed as JSValues.
-if (canFold(node)) {
-JSValue v = valueOfJSConstant(node);
-if (v.isInt32())
-return getJSConstant(node->constantNumber());
-if (v.isNumber())
-return getJSConstantForValue(JSValue(JSC::toInt32(v.asNumber(;
-}
-
-return addToGraph(ValueToInt32, node);
-}
-
// NOTE: Only use this to construct constants that arise from non-speculative
// constant folding. I.e. creating constants using this if we had constant
// field inference would be a bad idea, since the bytecode parser's folding
@@ -1579,9 +1555,9 @@
if (argumentCountIncludingThis != 2)
return false;
-int thisOperand = virtualRegisterForArgument(0, registerOffset).offset();
-int indexOperand = virtualRegisterForArgument(1, registerOffset).offset();
-Node* charCode = addToGraph(StringCharCodeAt, OpInfo(ArrayMode(Array::String).asWord()), get(VirtualRegister(thisOperand)), getToInt32(indexOperand));
+VirtualRegister thisOperand = virtualRegisterForArgument(0, registerOffset);
+VirtualRegister indexOperand = virtualRegisterForArgument(1, registerOffset);
+Node* charCode = addToGraph(StringCharCodeAt, OpInfo(ArrayMode(Array::String).asWord()), get(thisOperand), get(indexOperand));
set(VirtualRegister(resultOperand), charCode);
return true;
@@ -1591,9 +1567,9 @@
if (argumentCountIncludingThis != 2)
return false;
-int thisOperand = virtualRegisterForArgument(0, registerOffset).offset();
-int indexOperand = virtualRegisterForArgument(1, registerOffset).offset();
-Node* charCode = addToGraph(StringCharAt, OpInfo(ArrayMode(Array::String).asWord()), get(VirtualRegister(thisOperand)), getToInt32(indexOperand));
+VirtualRegister thisOperand = virtualRegisterForArgument(0, registerOf
[webkit-changes] [161466] branches/jsCStack/Source/JavaScriptCore
Title: [161466] branches/jsCStack/Source/_javascript_Core
Revision 161466
Author fpi...@apple.com
Date 2014-01-07 16:30:07 -0800 (Tue, 07 Jan 2014)
Log Message
Add a test that got lost in some merge.
* tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
Added Paths
branches/jsCStack/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161465 => 161466)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 00:27:06 UTC (rev 161465)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-08 00:30:07 UTC (rev 161466)
@@ -1,5 +1,11 @@
2014-01-07 Filip Pizlo
+Add a test that got lost in some merge.
+
+* tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
+
+2014-01-07 Filip Pizlo
+
--showDFGDisassembly=true shouldn't show baseline JIT stubs
https://bugs.webkit.org/show_bug.cgi?id=126593
Added: branches/jsCStack/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js (0 => 161466)
--- branches/jsCStack/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js (rev 0)
+++ branches/jsCStack/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js 2014-01-08 00:30:07 UTC (rev 161466)
@@ -0,0 +1,17 @@
+function foo(o) {
+var a = arguments;
+var result = o.f;
+for (var i = 1; i < a.length; ++i)
+result += a[i];
+return result;
+}
+
+noInline(foo);
+
+for (var i = 0; i < 100; ++i)
+foo({f:42}, 1, 2, 3);
+
+var result = foo({g:40, f:41}, 1, 2.5, 3);
+if (result != 47.5)
+throw "Bad result: " + result;
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161465] trunk/Source/JavaScriptCore
Title: [161465] trunk/Source/_javascript_Core Revision 161465 Author fpi...@apple.com Date 2014-01-07 16:27:06 -0800 (Tue, 07 Jan 2014) Log Message DFG fixup phase should be responsible for inserting ValueToInt32's as needed and it should use Phantom to keep the original values alive in case of OSR exit https://bugs.webkit.org/show_bug.cgi?id=126600 Reviewed by Michael Saboff. This fixes an embarrassing OSR exit liveness bug. It also simplifies the code. We were already using FixupPhase as the place where conversion nodes get inserted. ValueToInt32 was the only exception to that rule, and that was one of the reasons why we had this bug. Henceforth ValueToInt32 is only inserted by FixupPhase, and only when it is necessary: we have a BitOp that will want a ToInt32 conversion and the operand is not predicted to already be an int32. If FixupPhase inserts any ValueToInt32's then the BitOp will no longer appear to use the original operand, which will make OSR exit think that the original operand is dead. We work around this they way we always do: insert a Phantom on the original operands right after the BitOp. This ensures that any OSR exit in any of the ValueToInt32's or in the BitOp itself will have values for the original inputs. * dfg/DFGBackwardsPropagationPhase.cpp: (JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo): (JSC::DFG::BackwardsPropagationPhase::propagate): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleIntrinsic): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::fixIntEdge): (JSC::DFG::FixupPhase::fixBinaryIntEdges): * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): * tests/stress/bit-op-value-to-int32-input-liveness.js: Added. (foo): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp Added Paths trunk/Source/_javascript_Core/tests/stress/bit-op-value-to-int32-input-liveness.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (161464 => 161465) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-08 00:12:03 UTC (rev 161464) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-08 00:27:06 UTC (rev 161465) @@ -1,3 +1,37 @@ +2014-01-07 Filip Pizlo + +DFG fixup phase should be responsible for inserting ValueToInt32's as needed and it should use Phantom to keep the original values alive in case of OSR exit +https://bugs.webkit.org/show_bug.cgi?id=126600 + +Reviewed by Michael Saboff. + +This fixes an embarrassing OSR exit liveness bug. It also simplifies the code. We were +already using FixupPhase as the place where conversion nodes get inserted. ValueToInt32 +was the only exception to that rule, and that was one of the reasons why we had this bug. + +Henceforth ValueToInt32 is only inserted by FixupPhase, and only when it is necessary: +we have a BitOp that will want a ToInt32 conversion and the operand is not predicted to +already be an int32. If FixupPhase inserts any ValueToInt32's then the BitOp will no +longer appear to use the original operand, which will make OSR exit think that the +original operand is dead. We work around this they way we always do: insert a Phantom on +the original operands right after the BitOp. This ensures that any OSR exit in any of the +ValueToInt32's or in the BitOp itself will have values for the original inputs. + +* dfg/DFGBackwardsPropagationPhase.cpp: +(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo): +(JSC::DFG::BackwardsPropagationPhase::propagate): +* dfg/DFGByteCodeParser.cpp: +(JSC::DFG::ByteCodeParser::handleIntrinsic): +(JSC::DFG::ByteCodeParser::parseBlock): +* dfg/DFGFixupPhase.cpp: +(JSC::DFG::FixupPhase::fixupNode): +(JSC::DFG::FixupPhase::fixIntEdge): +(JSC::DFG::FixupPhase::fixBinaryIntEdges): +* dfg/DFGPredictionPropagationPhase.cpp: +(JSC::DFG::PredictionPropagationPhase::propagate): +* tests/stress/bit-op-value-to-int32-input-liveness.js: Added. +(foo): + 2014-01-07 Mark Hahnenberg Repatch write barrier slow path call doesn't align the stack in the presence of saved registers Modified: trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp (161464 => 161465) --- trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2014-01-08 00:12:03 UTC (rev 161464) +++ trunk/Source/_javascript_Core/dfg/DFGBackwardsPropagationPhase.cpp 2014-01-08 00:27:06 UTC (rev 161465) @@ -114,8 +114,7 @@ case BitOr: case BitXor: -c
[webkit-changes] [161464] trunk
Title: [161464] trunk
Revision 161464
Author commit-qu...@webkit.org
Date 2014-01-07 16:12:03 -0800 (Tue, 07 Jan 2014)
Log Message
createElementNS handles element name 'xmlns' correctly.
https://bugs.webkit.org/show_bug.cgi?id=126553
Patch by Victor Costan on 2014-01-07
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: fast/dom/createElementNS-namespace-errors.html
fast/dom/setAttributeNS-namespace-errors.html
* dom/Document.cpp:
(WebCore::Document::hasValidNamespaceForElements): updated to match DOM3/DOM4 spec.
(WebCore::Document::hasValidNamespaceForAttributes): updated to match DOM3/DOM4 spec.
LayoutTests:
* fast/dom/createElementNS-namespace-errors-expected.txt: Added.
* fast/dom/createElementNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
* fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
* fast/dom/setAttributeNS-expected.txt: Updated to match cleaned up test.
* fast/dom/setAttributeNS-namespace-errors-expected.txt: Added.
* fast/dom/setAttributeNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
* fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
* fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed. Subsumed by setAttributeNS-namespace-errors.
* fast/dom/setAttributeNS.html: Cleaned up.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/setAttributeNS-expected.txt
trunk/LayoutTests/fast/dom/setAttributeNS.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Added Paths
trunk/LayoutTests/fast/dom/createElementNS-namespace-errors-expected.txt
trunk/LayoutTests/fast/dom/createElementNS-namespace-errors.html
trunk/LayoutTests/fast/dom/setAttributeNS-namespace-errors-expected.txt
trunk/LayoutTests/fast/dom/setAttributeNS-namespace-errors.html
Removed Paths
trunk/LayoutTests/fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js
trunk/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt
trunk/LayoutTests/fast/dom/setAttributeNS-prefix-and-null-namespace.html
Diff
Modified: trunk/LayoutTests/ChangeLog (161463 => 161464)
--- trunk/LayoutTests/ChangeLog 2014-01-08 00:09:44 UTC (rev 161463)
+++ trunk/LayoutTests/ChangeLog 2014-01-08 00:12:03 UTC (rev 161464)
@@ -1,3 +1,20 @@
+2014-01-07 Victor Costan
+
+createElementNS handles element name 'xmlns' correctly.
+https://bugs.webkit.org/show_bug.cgi?id=126553
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/dom/createElementNS-namespace-errors-expected.txt: Added.
+* fast/dom/createElementNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
+* fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Removed.
+* fast/dom/setAttributeNS-expected.txt: Updated to match cleaned up test.
+* fast/dom/setAttributeNS-namespace-errors-expected.txt: Added.
+* fast/dom/setAttributeNS-namespace-errors.html: Added. Covers all the corner cases in the DOM4 spec.
+* fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Removed.
+* fast/dom/setAttributeNS-prefix-and-null-namespace.html: Removed. Subsumed by setAttributeNS-namespace-errors.
+* fast/dom/setAttributeNS.html: Cleaned up.
+
2014-01-06 Jer Noble
HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory
Added: trunk/LayoutTests/fast/dom/createElementNS-namespace-errors-expected.txt (0 => 161464)
--- trunk/LayoutTests/fast/dom/createElementNS-namespace-errors-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/createElementNS-namespace-errors-expected.txt 2014-01-08 00:12:03 UTC (rev 161464)
@@ -0,0 +1,30 @@
+Test that calling createElementNS() throws an error when the DOM spec says it should.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS document.createElementNS(null, 'foo:bar') threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createElementNS('http://www.w3.org/XML/1998/namespace', 'xml:abc') did not throw exception.
+PASS document.createElementNS('http://www.w3.org/XML/1998/namespace', 'xml:abc').namespaceURI is "http://www.w3.org/XML/1998/namespace"
+PASS document.createElementNS('http://www.w3.org/XML/1998/namespace', 'xml:abc').nodeName is "xml:abc"
+PASS document.createElementNS('http://www.w3.org/XML/1998/namespace', 'xml:abc').prefix is "xml"
+PASS document.createElementNS('http://www.w3.org/XML/1998/namespace', 'xml:abc').localName is "abc"
+PASS document.createElementNS('http://www.w3.org/not-XML/1998/namespace', 'xml:abc') threw exception Error: NamespaceError: DOM Exception 14.
+PASS document.createElementNS('http://www.w3.org/2000/xmlns/', 'xmlns') did not throw exception.
+PASS document.createElementNS('http://www.w3.org/2000/xmlns/', 'xmlns').namespaceURI is "http://www.w3.org/2000/xmlns/"
+PASS docume
[webkit-changes] [161463] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Title: [161463] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Revision 161463
Author lforsch...@apple.com
Date 2014-01-07 16:09:44 -0800 (Tue, 07 Jan 2014)
Log Message
Update buiddir to be unique.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (161462 => 161463)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-08 00:08:42 UTC (rev 161462)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-08 00:09:44 UTC (rev 161463)
@@ -93,7 +93,7 @@
"platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
"slavenames": ["apple-mini-142", "apple-mini-211"]
},
-{ "name": "Apple Mavericks CLOOP (BuildAndTest)", "type": "BuildAndTestCLOOP", "builddir": "mavericks-debug",
+{ "name": "Apple Mavericks CLOOP (BuildAndTest)", "type": "BuildAndTestCLOOP", "builddir": "mavericks-cloop-debug",
"platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
"slavenames": ["apple-mini-180"]
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161462] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
Title: [161462] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Revision 161462 Author lforsch...@apple.com Date 2014-01-07 16:08:42 -0800 (Tue, 07 Jan 2014) Log Message fix Typo. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (161461 => 161462) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-08 00:04:27 UTC (rev 161461) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-08 00:08:42 UTC (rev 161462) @@ -838,7 +838,7 @@ self.addStep(UploadBuiltProduct()) self.addStep(trigger.Trigger(schedulerNames=triggers)) -class BuildAndTestCLOOP(BuildAndTestFactory): +class BuildAndTestCLOOPFactory(BuildAndTestFactory): CompileClass = CompileCLOOP LayoutTestClass = RunCLOOPTests ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161461] trunk/Tools
Title: [161461] trunk/Tools
Revision 161461
Author lforsch...@apple.com
Date 2014-01-07 16:04:27 -0800 (Tue, 07 Jan 2014)
Log Message
Add buildbot infrasctructure for building and testing JSC cloop
https://bugs.webkit.org/show_bug.cgi?id=126604
Reviewed by Geoffrey Garen.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileCLOOP):
(RunCLOOPTests):
(RunCLOOPTests.countFailures):
(BuildAndTestCLOOP):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (161460 => 161461)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-07 23:46:26 UTC (rev 161460)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-08 00:04:27 UTC (rev 161461)
@@ -20,6 +20,7 @@
{ "name": "apple-mini-142", "platform": "mac-mavericks"},
{ "name": "apple-mini-178", "platform": "mac-mavericks"},
{ "name": "apple-mini-179", "platform": "mac-mavericks"},
+{ "name": "apple-mini-180", "platform": "mac-mavericks"},
{ "name": "apple-mini-211", "platform": "mac-mavericks" },
{ "name": "apple-mini-212", "platform": "mac-mavericks" },
{ "name": "apple-mini-213", "platform": "mac-mavericks" },
@@ -92,6 +93,10 @@
"platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
"slavenames": ["apple-mini-142", "apple-mini-211"]
},
+{ "name": "Apple Mavericks CLOOP (BuildAndTest)", "type": "BuildAndTestCLOOP", "builddir": "mavericks-debug",
+ "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
+ "slavenames": ["apple-mini-180"]
+},
{ "name": "Apple Mavericks Release (Build)", "type": "Build", "builddir": "mavericks-release",
"platform": "mac-mavericks", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["mavericks-release-tests-wk1", "mavericks-release-tests-wk2", "mavericks-release-perf"],
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (161460 => 161461)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-07 23:46:26 UTC (rev 161460)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-08 00:04:27 UTC (rev 161461)
@@ -225,6 +225,10 @@
self.addCompleteLog('errors', "".join(errors))
+class CompileCLOOP(CompileWebKit):
+command = ["perl", "./Tools/Scripts/build-jsc", "--cloop", WithProperties("--%(configuration)s")]
+
+
class CompileWebKit1Only(CompileWebKit):
command = ["perl", "./Tools/Scripts/build-webkit", "--no-webkit2", WithProperties("--%(configuration)s")]
@@ -552,6 +556,25 @@
return 0
+class RunCLOOPTests(TestWithFailureCount):
+name = "webkit-jsc-cloop-test"
+description = ["cloop-tests running"]
+descriptionDone = ["cloop-tests"]
+command = ["perl", "./Tools/Scripts/run-_javascript_core-tests", "--cloop", "--no-build", "--no-jsc-stress", WithProperties("--%(configuration)s")]
+failedTestsFormatString = "%d regressions found."
+
+def countFailures(self, cmd):
+logText = cmd.logs['stdio'].getText()
+# We're looking for the line that looks like this: 0 regressions found.\n0 tests fixed.
+regex = re.compile(r'(?P\d+) regressions found.')
+for line in logText.splitlines():
+match = regex.match(line)
+if not match:
+continue
+return int(match.group('count'))
+return 0
+
+
class RunBindingsTests(shell.Test):
name = "bindings-generation-tests"
description = ["bindings-tests running"]
@@ -815,6 +838,10 @@
self.addStep(UploadBuiltProduct())
self.addStep(trigger.Trigger(schedulerNames=triggers))
+class BuildAndTestCLOOP(BuildAndTestFactory):
+CompileClass = CompileCLOOP
+LayoutTestClass = RunCLOOPTests
+
class BuildAndTestWebKit2Factory(BuildAndTestFactory):
CompileClass = CompileWebKit
LayoutTestClass = RunWebKit2Tests
Modified: trunk/Tools/ChangeLog (161460 => 161461)
--- trunk/Tools/ChangeLog 2014-01-07 23:46:26 UTC (rev 161460)
+++ trunk/Tools/ChangeLog 2014-01-08 00:04:27 UTC (rev 161461)
@@ -1,3 +1,17 @@
+2014-01-07 Lucas Forschler
+
+Add buildbot infrasctructure for building and testing JSC cloop
+https://bugs.webkit.org/show_bug.cgi?id=126604
+
+Reviewed by Geoffrey Garen.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/bui
[webkit-changes] [161460] trunk/Source/WebInspectorUI
Title: [161460] trunk/Source/WebInspectorUI
Revision 161460
Author commit-qu...@webkit.org
Date 2014-01-07 15:46:26 -0800 (Tue, 07 Jan 2014)
Log Message
Web Inspector: Typo "clipboarPrefixString"
https://bugs.webkit.org/show_bug.cgi?id=126595
Patch by Joseph Pecoraro on 2014-01-07
Reviewed by Sam Weinig.
* UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
(WebInspector.ConsoleCommandResult.prototype.get clipboardPrefixString):
* UserInterface/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype.get clipboardPrefixString):
(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js
trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (161459 => 161460)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 23:37:03 UTC (rev 161459)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-07 23:46:26 UTC (rev 161460)
@@ -1,3 +1,17 @@
+2014-01-07 Joseph Pecoraro
+
+Web Inspector: Typo "clipboarPrefixString"
+https://bugs.webkit.org/show_bug.cgi?id=126595
+
+Reviewed by Sam Weinig.
+
+* UserInterface/ConsoleCommandResult.js:
+(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
+(WebInspector.ConsoleCommandResult.prototype.get clipboardPrefixString):
+* UserInterface/ConsoleMessageImpl.js:
+(WebInspector.ConsoleMessageImpl.prototype.get clipboardPrefixString):
+(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
+
2014-01-06 Seokju Kwon
Web Inspector: Remove canOverrideDeviceMetrics and setDeviceMetricsOverride from protocol
Modified: trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js (161459 => 161460)
--- trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js 2014-01-07 23:37:03 UTC (rev 161459)
+++ trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js 2014-01-07 23:46:26 UTC (rev 161460)
@@ -46,12 +46,12 @@
{
var element = WebInspector.ConsoleMessageImpl.prototype.toMessageElement.call(this);
element.classList.add("console-user-command-result");
-if (!element.getAttribute("data-labelprefix"))
+if (!element.getAttribute("data-labelprefix"))
element.setAttribute("data-labelprefix", WebInspector.UIString("Output: "));
return element;
},
-get clipboarPrefixString ()
+get clipboardPrefixString()
{
return "< ";
}
Modified: trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js (161459 => 161460)
--- trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js 2014-01-07 23:37:03 UTC (rev 161459)
+++ trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js 2014-01-07 23:46:26 UTC (rev 161460)
@@ -664,7 +664,7 @@
}
},
-get clipboarPrefixString ()
+get clipboardPrefixString()
{
return "[" + this.levelString + "] ";
},
@@ -680,7 +680,7 @@
clipboardString = this.type === WebInspector.ConsoleMessage.MessageType.Trace ? "console.trace()" : this._message || this._messageText;
if (!isPrefixOptional || this.enforcesClipboardPrefixString)
-clipboardString = this.clipboarPrefixString + clipboardString;
+clipboardString = this.clipboardPrefixString + clipboardString;
if (isTrace) {
this._stackTrace.forEach(function(frame) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161459] trunk/Tools
Title: [161459] trunk/Tools
Revision 161459
Author bb...@apple.com
Date 2014-01-07 15:37:03 -0800 (Tue, 07 Jan 2014)
Log Message
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (161458 => 161459)
--- trunk/Tools/ChangeLog 2014-01-07 23:22:22 UTC (rev 161458)
+++ trunk/Tools/ChangeLog 2014-01-07 23:37:03 UTC (rev 161459)
@@ -1,3 +1,9 @@
+2014-01-07 Brian Burg
+
+Unreviewed. Add myself as a committer.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2014-01-07 Alexey Proskuryakov
Popovers at build.webkit.org/dashboard could have titles
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (161458 => 161459)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-01-07 23:22:22 UTC (rev 161458)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2014-01-07 23:37:03 UTC (rev 161459)
@@ -411,6 +411,17 @@
"brettx"
]
},
+ "Brian Burg" : {
+ "emails" : [
+"bb...@apple.com",
+"b...@cs.washington.edu"
+ ],
+ "expertise" : "Developer Tools, Web Inspector",
+ "nicks" : [
+"bburg",
+"brrian"
+ ]
+ },
"Brian Holt" : {
"emails" : [
"brian.h...@samsung.com"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161457] trunk/Source/WebCore
Title: [161457] trunk/Source/WebCore Revision 161457 Author jer.no...@apple.com Date 2014-01-07 14:31:49 -0800 (Tue, 07 Jan 2014) Log Message PlatformLayer containing scrollbars does not disappear when setting overflow:hidden on page root, until resize. https://bugs.webkit.org/show_bug.cgi?id=116051 Reviewed by Simon Fraser. Move the pre-existing call to addedOrRemovedScrollbar() outside of the else-statement in updateScrollbars() so that changes made in the if-statement cause the scrollbar layers to be updated. The scrollbarAddedOrRemoved local variable guarding access to addedOrRemovedScrollbar() is already being set (but never checked) inside the if-statement. * platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (161456 => 161457) --- trunk/Source/WebCore/ChangeLog 2014-01-07 22:27:44 UTC (rev 161456) +++ trunk/Source/WebCore/ChangeLog 2014-01-07 22:31:49 UTC (rev 161457) @@ -1,3 +1,18 @@ +2014-01-07 Jer Noble + +PlatformLayer containing scrollbars does not disappear when setting overflow:hidden on page root, until resize. +https://bugs.webkit.org/show_bug.cgi?id=116051 + +Reviewed by Simon Fraser. + +Move the pre-existing call to addedOrRemovedScrollbar() outside of the else-statement +in updateScrollbars() so that changes made in the if-statement cause the scrollbar +layers to be updated. The scrollbarAddedOrRemoved local variable guarding access to +addedOrRemovedScrollbar() is already being set (but never checked) inside the if-statement. + +* platform/ScrollView.cpp: +(WebCore::ScrollView::updateScrollbars): + 2014-01-06 Jer Noble HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory Modified: trunk/Source/WebCore/platform/ScrollView.cpp (161456 => 161457) --- trunk/Source/WebCore/platform/ScrollView.cpp 2014-01-07 22:27:44 UTC (rev 161456) +++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-01-07 22:31:49 UTC (rev 161457) @@ -607,11 +607,11 @@ } m_updateScrollbarsPass--; } +} -if (scrollbarAddedOrRemoved) -addedOrRemovedScrollbar(); -} - +if (scrollbarAddedOrRemoved) +addedOrRemovedScrollbar(); + // Set up the range (and page step/line step), but only do this if we're not in a nested call (to avoid // doing it multiple times). if (m_updateScrollbarsPass) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161456] branches/safari-537.74-branch
Title: [161456] branches/safari-537.74-branch
Revision 161456
Author lforsch...@apple.com
Date 2014-01-07 14:27:44 -0800 (Tue, 07 Jan 2014)
Log Message
Merged r160479.
Modified Paths
branches/safari-537.74-branch/LayoutTests/ChangeLog
branches/safari-537.74-branch/Source/WebCore/ChangeLog
branches/safari-537.74-branch/Source/WebCore/css/CSSCursorImageValue.cpp
branches/safari-537.74-branch/Source/WebCore/css/CSSCursorImageValue.h
branches/safari-537.74-branch/Source/WebCore/css/CSSImageSetValue.cpp
branches/safari-537.74-branch/Source/WebCore/css/CSSImageSetValue.h
branches/safari-537.74-branch/Source/WebCore/css/CSSImageValue.cpp
branches/safari-537.74-branch/Source/WebCore/css/CSSImageValue.h
branches/safari-537.74-branch/Source/WebCore/rendering/style/StylePendingImage.h
Added Paths
branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash-expected.txt
branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash.xhtml
Diff
Modified: branches/safari-537.74-branch/LayoutTests/ChangeLog (161455 => 161456)
--- branches/safari-537.74-branch/LayoutTests/ChangeLog 2014-01-07 22:24:37 UTC (rev 161455)
+++ branches/safari-537.74-branch/LayoutTests/ChangeLog 2014-01-07 22:27:44 UTC (rev 161456)
@@ -1,3 +1,17 @@
+2014-01-07 Lucas Forschler
+
+Merge r160479
+
+2013-12-11 Darin Adler
+
+StylePendingImage needs to correctly manage the CSSValue pointer lifetime
+https://bugs.webkit.org/show_bug.cgi?id=125468
+
+Reviewed by Andreas Kling.
+
+* fast/css/pending-image-crash-expected.txt: Added.
+* fast/css/pending-image-crash.xhtml: Added.
+
2013-12-19 Matthew Hanson
Merge r160826:
Copied: branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash-expected.txt (from rev 160479, trunk/LayoutTests/fast/css/pending-image-crash-expected.txt) (0 => 161456)
--- branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash-expected.txt (rev 0)
+++ branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash-expected.txt 2014-01-07 22:27:44 UTC (rev 161456)
@@ -0,0 +1,5 @@
+PASS test did not crash
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash.xhtml (from rev 160479, trunk/LayoutTests/fast/css/pending-image-crash.xhtml) (0 => 161456)
--- branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash.xhtml (rev 0)
+++ branches/safari-537.74-branch/LayoutTests/fast/css/pending-image-crash.xhtml 2014-01-07 22:27:44 UTC (rev 161456)
@@ -0,0 +1,24 @@
+
+
+
+
+window.jsTestIsAsync = true;
+var count = 0;
+for (i = 0; i != 50; i++) {
+setTimeout(function() {
+var head = document.getElementsByTagName("head")[0];
+var style = document.createElement("style");
+style.innerHTML=":first-of-type {-webkit-border-image:-webkit-cross-fade(url(#head), url(#head), 100%);}";
+head.appendChild(style);
+count++;
+if (count == 50) {
+testPassed("test did not crash");
+finishJSTest();
+}
+}, 36);
+}
+
+
[webkit-changes] [161455] trunk
Title: [161455] trunk
Revision 161455
Author jer.no...@apple.com
Date 2014-01-07 14:24:37 -0800 (Tue, 07 Jan 2014)
Log Message
HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory
https://bugs.webkit.org/show_bug.cgi?id=40382
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/video-auth.html
Adopt a new AVFoundation API to handle authentication challenge generated while loading
media through an AVAsset. The authentication request comes through as a
NSURLAuthenticationChallenge, and is wrapped in a WebCore::AuthenticationChallenge
by MediaPlayerPrivateAVFoundationObjC, and is sent up to the HTMLMediaElement to handle.
The HTMLMediaElement creates a ResourceRequest, and passes the challenge up to the
ResourceLoadNotifier.
To allow the HTMLMediaElement to initiate handling an AuthenticationChallenge without
actually creating a ResourceLoader, allow ResourceLoaderDelegate to accept a unique
identifier and a DocumentLoader in lieu of a ResourceLoader.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
(WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
* loader/ResourceLoadNotifier.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::shouldWaitForResponseToAuthenticationChallenge):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerShouldWaitForResponseToAuthenticationChallenge):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
LayoutTests:
* http/tests/media/resources/video-auth.php: Added.
* http/tests/media/video-auth-expected.txt: Added.
* http/tests/media/video-auth.html: Added.
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp
trunk/Source/WebCore/loader/ResourceLoadNotifier.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Added Paths
trunk/LayoutTests/http/tests/media/resources/video-auth.php
trunk/LayoutTests/http/tests/media/video-auth-expected.txt
trunk/LayoutTests/http/tests/media/video-auth.html
Diff
Modified: trunk/LayoutTests/ChangeLog (161454 => 161455)
--- trunk/LayoutTests/ChangeLog 2014-01-07 22:06:08 UTC (rev 161454)
+++ trunk/LayoutTests/ChangeLog 2014-01-07 22:24:37 UTC (rev 161455)
@@ -1,3 +1,15 @@
+2014-01-06 Jer Noble
+
+HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory
+https://bugs.webkit.org/show_bug.cgi?id=40382
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/resources/video-auth.php: Added.
+* http/tests/media/video-auth-expected.txt: Added.
+* http/tests/media/video-auth.html: Added.
+* platform/mac/TestExpectations:
+
2014-01-07 Brent Fulgham
Unreviewed test expectation update.
Added: trunk/LayoutTests/http/tests/media/resources/video-auth.php (0 => 161455)
--- trunk/LayoutTests/http/tests/media/resources/video-auth.php (rev 0)
+++ trunk/LayoutTests/http/tests/media/resources/video-auth.php 2014-01-07 22:24:37 UTC (rev 161455)
@@ -0,0 +1,20 @@
+
Added: trunk/LayoutTests/http/tests/media/video-auth-expected.txt (0 => 161455)
--- trunk/LayoutTests/http/tests/media/video-auth-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/video-auth-expected.txt 2014-01-07 22:24:37 UTC (rev 161455)
@@ -0,0 +1,6 @@
+http://127.0.0.1:8000/media/resources/video-auth.php?name=test.mp4&type=video/mp4 - didReceiveAuthenticationChallenge - Responding with username:password
+
+Tests that the media player sends authorization credentials when requesting a media file.
+EVENT(canplay)
+END OF TEST
+
Added: trunk/LayoutTests/http/tests/media/video-auth.html (0 => 161455)
--- trunk/LayoutTests/http/tests/media/video-auth.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/video-auth.html 2014-01-07 22:24:37 UTC (rev 161455)
@@ -0,0 +1,45 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.setHandlesAuthenticationChallenges(true);
+testRunner.setAuthenticationUsername("username");
+testRunner.setAuthenticat
[webkit-changes] [161454] trunk/Tools
Title: [161454] trunk/Tools
Revision 161454
Author a...@apple.com
Date 2014-01-07 14:06:08 -0800 (Tue, 07 Jan 2014)
Log Message
Popovers at build.webkit.org/dashboard could have titles
https://bugs.webkit.org/show_bug.cgi?id=126495
Reviewed by Timothy Hatcher.
Added titles to all popovers except for pending revisions one, which I would like
to improve more (probably add an ETA).
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for
adding a title to base class.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
a divider to a separate function.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
(BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
title from above function.
(BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
variable to "content" to match all other code.
(BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
(BuildbotQueueView.prototype._addDividerToPopover): Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
(BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
(BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (161453 => 161454)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-07 21:50:49 UTC (rev 161453)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-07 22:06:08 UTC (rev 161454)
@@ -143,18 +143,9 @@
content.appendChild(line);
}
-var title = document.createElement("div");
-title.className = "build-logs-popover-title";
-title.textContent = iteration.queue.id;
-content.appendChild(title);
+this._addIterationHeadingToPopover(iteration, content);
+this._addDividerToPopover(content);
-var builderPageLine = document.createElement("a");
-builderPageLine.className = "build-page-link";
-builderPageLine.href = ""
-builderPageLine.textContent = "build #" + iteration.id;
-builderPageLine.target = "_blank";
-content.appendChild(builderPageLine);
-
var logsHeadingLine = document.createElement("div");
logsHeadingLine.className = "build-logs-heading";
logsHeadingLine.textContent = iteration.firstFailedStepName + " failed";
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (161453 => 161454)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2014-01-07 21:50:49 UTC (rev 161453)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2014-01-07 22:06:08 UTC (rev 161454)
@@ -166,11 +166,8 @@
if (latestProductiveIteration.internalRevision && internalTrac.latestRecordedRevisionNumber)
var linesForInternal = this._popoverLinesForCommitRange(internalTrac, latestProductiveIteration.internalRevision + 1, internalTrac.latestRecordedRevisionNumber);
-if (linesForOpenSource.length && linesForInternal.length) {
-var divider = document.createElement("div");
-divider.className = "divider";
-content.appendChild(divider);
-}
+if (linesForOpenSource.length && linesForInternal.length)
+this._addDividerToPopover(content);
for (var i = 0; i != linesForInternal.length; ++i)
content.appendChild(linesForInternal[i]);
@@ -191,6 +188,12 @@
if (!linesForCommits.length)
return false;
+var line = document.createElement("div");
+line.className = "title";
+line.textContent = "new commits in this build";
+content.appendChild(li
[webkit-changes] [161453] branches/jsCStack/Source/JavaScriptCore
Title: [161453] branches/jsCStack/Source/_javascript_Core
Revision 161453
Author fpi...@apple.com
Date 2014-01-07 13:50:49 -0800 (Tue, 07 Jan 2014)
Log Message
--showDFGDisassembly=true shouldn't show baseline JIT stubs
https://bugs.webkit.org/show_bug.cgi?id=126593
Not yet reviewed.
* assembler/LinkBuffer.cpp:
(JSC::shouldShowDisassemblyFor):
* assembler/LinkBuffer.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):
* jit/JITStubRoutine.h:
* jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp
branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.h
branches/jsCStack/Source/_javascript_Core/jit/JITPropertyAccess.cpp
branches/jsCStack/Source/_javascript_Core/jit/JITStubRoutine.h
branches/jsCStack/Source/_javascript_Core/jit/Repatch.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161452 => 161453)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 21:27:10 UTC (rev 161452)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 21:50:49 UTC (rev 161453)
@@ -1,5 +1,28 @@
2014-01-07 Filip Pizlo
+--showDFGDisassembly=true shouldn't show baseline JIT stubs
+https://bugs.webkit.org/show_bug.cgi?id=126593
+
+Not yet reviewed.
+
+* assembler/LinkBuffer.cpp:
+(JSC::shouldShowDisassemblyFor):
+* assembler/LinkBuffer.h:
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::privateCompileGetByVal):
+(JSC::JIT::privateCompilePutByVal):
+* jit/JITStubRoutine.h:
+* jit/Repatch.cpp:
+(JSC::generateProtoChainAccessStub):
+(JSC::tryCacheGetByID):
+(JSC::tryBuildGetByIDList):
+(JSC::emitPutReplaceStub):
+(JSC::emitPutTransitionStub):
+(JSC::tryRepatchIn):
+(JSC::linkClosureCall):
+
+2014-01-07 Filip Pizlo
+
Merge trunk r161438.
2014-01-07 Filip Pizlo
Modified: branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp (161452 => 161453)
--- branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp 2014-01-07 21:27:10 UTC (rev 161452)
+++ branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp 2014-01-07 21:50:49 UTC (rev 161453)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -28,11 +28,20 @@
#if ENABLE(ASSEMBLER)
+#include "CodeBlock.h"
+#include "JITCode.h"
#include "Options.h"
#include
namespace JSC {
+bool shouldShowDisassemblyFor(CodeBlock* codeBlock)
+{
+if (JITCode::isOptimizingJIT(codeBlock->jitType()) && Options::showDFGDisassembly())
+return true;
+return Options::showDisassembly();
+}
+
LinkBuffer::CodeRef LinkBuffer::finalizeCodeWithoutDisassembly()
{
performFinalization();
Modified: branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.h (161452 => 161453)
--- branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.h 2014-01-07 21:27:10 UTC (rev 161452)
+++ branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.h 2014-01-07 21:50:49 UTC (rev 161453)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2009, 2010, 2012, 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -42,6 +42,7 @@
namespace JSC {
+class CodeBlock;
class VM;
// LinkBuffer:
@@ -302,6 +303,11 @@
? ((linkBufferReference).finalizeCodeWithDisassembly dataLogFArgumentsForHeading) \
: (linkBufferReference).finalizeCodeWithoutDisassembly())
+bool shouldShowDisassemblyFor(CodeBlock* codeBlock);
+
+#define FINALIZE_CODE_FOR(codeBlock, linkBufferReference, dataLogFArgumentsForHeading) \
+FINALIZE_CODE_IF(shouldShowDisassemblyFor(codeBlock), linkBufferReference, dataLogFArgumentsForHeading)
+
// Use this to finalize code, like so:
//
// CodeRef code = FINALIZE_CODE(linkBuffer, ("my super thingy number %d", number));
Modified: branches/jsCStack/Source/_javascript_Core/jit/JITPropertyAccess.cpp (161452 => 161453)
--- branches/jsCStack/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2014-01-07 21:27:10 UTC (rev 161452)
+++ branches/jsCStack/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2014-01-07 21:50:49 UTC (rev 161453)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 200
[webkit-changes] [161450] trunk/Source/JavaScriptCore
Title: [161450] trunk/Source/_javascript_Core
Revision 161450
Author mhahnenb...@apple.com
Date 2014-01-07 13:05:30 -0800 (Tue, 07 Jan 2014)
Log Message
Repatch write barrier slow path call doesn't align the stack in the presence of saved registers
https://bugs.webkit.org/show_bug.cgi?id=126093
Reviewed by Geoffrey Garen.
* jit/Repatch.cpp: Reworked the stack alignment code for calling out to C code on the write barrier slow path.
We need to properly account for the number of reused registers that were saved to the stack, so we have to
pass the ScratchRegisterAllocator around.
(JSC::storeToWriteBarrierBuffer):
(JSC::writeBarrier):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
* jit/ScratchRegisterAllocator.h: Previously the ScratchRegisterAllocator only knew whether or not it had
reused registers, but not how many. In order to correctly align the stack for calls to C slow paths for
the write barriers in inline caches we need to know how the stack is aligned. So now ScratchRegisterAllocator
tracks how many registers it has reused.
(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::didReuseRegisters):
(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
* llint/LowLevelInterpreter64.asm: Random typo fix.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/jit/ScratchRegisterAllocator.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161449 => 161450)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 20:59:43 UTC (rev 161449)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 21:05:30 UTC (rev 161450)
@@ -1,3 +1,29 @@
+2014-01-07 Mark Hahnenberg
+
+Repatch write barrier slow path call doesn't align the stack in the presence of saved registers
+https://bugs.webkit.org/show_bug.cgi?id=126093
+
+Reviewed by Geoffrey Garen.
+
+* jit/Repatch.cpp: Reworked the stack alignment code for calling out to C code on the write barrier slow path.
+We need to properly account for the number of reused registers that were saved to the stack, so we have to
+pass the ScratchRegisterAllocator around.
+(JSC::storeToWriteBarrierBuffer):
+(JSC::writeBarrier):
+(JSC::emitPutReplaceStub):
+(JSC::emitPutTransitionStub):
+* jit/ScratchRegisterAllocator.h: Previously the ScratchRegisterAllocator only knew whether or not it had
+reused registers, but not how many. In order to correctly align the stack for calls to C slow paths for
+the write barriers in inline caches we need to know how the stack is aligned. So now ScratchRegisterAllocator
+tracks how many registers it has reused.
+(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
+(JSC::ScratchRegisterAllocator::allocateScratch):
+(JSC::ScratchRegisterAllocator::didReuseRegisters):
+(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
+(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
+(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
+* llint/LowLevelInterpreter64.asm: Random typo fix.
+
2014-01-07 Mark Lam
r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows).
Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (161449 => 161450)
--- trunk/Source/_javascript_Core/jit/Repatch.cpp 2014-01-07 20:59:43 UTC (rev 161449)
+++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2014-01-07 21:05:30 UTC (rev 161450)
@@ -774,7 +774,7 @@
}
#if ENABLE(GGC)
-static MacroAssembler::Call storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2, ScratchRegisterAllocator& allocator)
+static MacroAssembler::Call storeToWriteBarrierBuffer(CCallHelpers& jit, GPRReg cell, GPRReg scratch1, GPRReg scratch2, GPRReg callFrameRegister, ScratchRegisterAllocator& allocator)
{
ASSERT(scratch1 != scratch2);
WriteBarrierBuffer* writeBarrierBuffer = &jit.vm()->heap.writeBarrierBuffer();
@@ -795,17 +795,23 @@
ScratchBuffer* scratchBuffer = jit.vm()->scratchBufferForSize(allocator.desiredScratchBufferSize());
allocator.preserveUsedRegistersToScratchBuffer(jit, scratchBuffer, scratch1);
-// We need these extra slots because setupArgumentsWithExecState will use poke on x86.
+unsigned bytesFromBase = allocator.numberOfReusedRegisters() * sizeof(void*);
+unsigned bytesToSubtract = 0;
#if CPU(X86)
-jit.subPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 3), MacroAssembler::stackPointerRegister);
+bytesToSubtract += 2 * sizeof(void*);
+bytesFromBase += bytesToSubtract;
#en
[webkit-changes] [161451] trunk/Source/WTF
Title: [161451] trunk/Source/WTF Revision 161451 Author dfar...@apple.com Date 2014-01-07 13:07:03 -0800 (Tue, 07 Jan 2014) Log Message [ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h https://bugs.webkit.org/show_bug.cgi?id=124532 Reviewed by David Kilzer. * wtf/Compiler.h: Remove this quirk - it does nothing. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Compiler.h Diff Modified: trunk/Source/WTF/ChangeLog (161450 => 161451) --- trunk/Source/WTF/ChangeLog 2014-01-07 21:05:30 UTC (rev 161450) +++ trunk/Source/WTF/ChangeLog 2014-01-07 21:07:03 UTC (rev 161451) @@ -1,3 +1,13 @@ +2014-01-07 David Farler + +[ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h +https://bugs.webkit.org/show_bug.cgi?id=124532 + +Reviewed by David Kilzer. + +* wtf/Compiler.h: +Remove this quirk - it does nothing. + 2014-01-06 Filip Pizlo Get rid of ENABLE(VALUE_PROFILER). It's on all the time now. Modified: trunk/Source/WTF/wtf/Compiler.h (161450 => 161451) --- trunk/Source/WTF/wtf/Compiler.h 2014-01-07 21:05:30 UTC (rev 161450) +++ trunk/Source/WTF/wtf/Compiler.h 2014-01-07 21:07:03 UTC (rev 161451) @@ -56,14 +56,8 @@ #define WTF_COMPILER_SUPPORTS_CXX_AUTO_TYPE __has_feature(cxx_auto_type) #define WTF_COMPILER_SUPPORTS_CXX_GENERALIZED_INITIALIZERS __has_feature(cxx_generalized_initializers) -/* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ -#if defined(__APPLE__) && (__clang_major__ < 4 || (__clang_major__ == 4 && __clang_minor__ < 2)) -#define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY 1 -// #error "Please use a newer version of Xcode, this version has code generation bugs when using 'final' in C++ code" #endif -#endif - /* COMPILER(MSVC) - Microsoft Visual C++ */ #if defined(_MSC_VER) #if _MSC_VER < 1800 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161449] branches/jsCStack/Source/JavaScriptCore
Title: [161449] branches/jsCStack/Source/_javascript_Core
Revision 161449
Author fpi...@apple.com
Date 2014-01-07 12:59:43 -0800 (Tue, 07 Jan 2014)
Log Message
Merge trunk r161438.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161448 => 161449)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:52:56 UTC (rev 161448)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:59:43 UTC (rev 161449)
@@ -1,5 +1,9 @@
2014-01-07 Filip Pizlo
+Merge trunk r161438.
+
+2014-01-07 Filip Pizlo
+
FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values
https://bugs.webkit.org/show_bug.cgi?id=126587
Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (161448 => 161449)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2014-01-07 20:52:56 UTC (rev 161448)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2014-01-07 20:59:43 UTC (rev 161449)
@@ -2947,7 +2947,7 @@
GPRReg resultGPR = result.gpr();
m_jit.move(op1GPR, resultGPR);
m_jit.neg64(resultGPR);
-if (!shouldCheckNegativeZero(node->arithMode())) {
+if (shouldCheckNegativeZero(node->arithMode())) {
speculationCheck(
NegativeZero, JSValueRegs(), 0,
m_jit.branchTest64(MacroAssembler::Zero, resultGPR));
@@ -2964,7 +2964,7 @@
speculationCheck(
Int52Overflow, JSValueRegs(), 0,
m_jit.branchNeg64(MacroAssembler::Overflow, resultGPR));
-if (!shouldCheckNegativeZero(node->arithMode())) {
+if (shouldCheckNegativeZero(node->arithMode())) {
speculationCheck(
NegativeZero, JSValueRegs(), 0,
m_jit.branchTest64(MacroAssembler::Zero, resultGPR));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161448] branches/jsCStack/Source/JavaScriptCore/ChangeLog
Title: [161448] branches/jsCStack/Source/_javascript_Core/ChangeLog Revision 161448 Author fpi...@apple.com Date 2014-01-07 12:52:56 -0800 (Tue, 07 Jan 2014) Log Message Indicate that r161445 has been reviewed. Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161447 => 161448) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:52:20 UTC (rev 161447) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:52:56 UTC (rev 161448) @@ -3,7 +3,7 @@ FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values https://bugs.webkit.org/show_bug.cgi?id=126587 -Not yet reviewed. +Reviewed by Geoffrey Garen. At the prologue of OSR entry, DFG IR knows where the arguments are but has no idea where the locals are. So, before OSR entry starts doing speculation checks, it ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161446] trunk/Source/JavaScriptCore
Title: [161446] trunk/Source/_javascript_Core
Revision 161446
Author mark@apple.com
Date 2014-01-07 12:47:50 -0800 (Tue, 07 Jan 2014)
Log Message
r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows).
https://bugs.webkit.org/show_bug.cgi?id=126589.
Reviewed by Filip Pizlo.
After the removal of ENABLE(VALUE_PROFILER), the LLINT is now expecting the
relevant opcode operands to point to ValueProfiler data structures and will
write profiling data into them. Hence, we need to allocate these data
structures even though the profiling data won't be used in non-DFG builds.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161445 => 161446)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 20:16:37 UTC (rev 161445)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 20:47:50 UTC (rev 161446)
@@ -1,3 +1,18 @@
+2014-01-07 Mark Lam
+
+r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows).
+https://bugs.webkit.org/show_bug.cgi?id=126589.
+
+Reviewed by Filip Pizlo.
+
+After the removal of ENABLE(VALUE_PROFILER), the LLINT is now expecting the
+relevant opcode operands to point to ValueProfiler data structures and will
+write profiling data into them. Hence, we need to allocate these data
+structures even though the profiling data won't be used in non-DFG builds.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+
2014-01-07 Filip Pizlo
ASSERT in compileArithNegate on pdfjs
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (161445 => 161446)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-01-07 20:16:37 UTC (rev 161445)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2014-01-07 20:47:50 UTC (rev 161446)
@@ -1644,14 +1644,12 @@
if (size_t size = unlinkedCodeBlock->numberOfLLintCallLinkInfos())
m_llintCallLinkInfos.resizeToFit(size);
#endif
-#if ENABLE(DFG_JIT)
if (size_t size = unlinkedCodeBlock->numberOfArrayProfiles())
m_arrayProfiles.grow(size);
if (size_t size = unlinkedCodeBlock->numberOfArrayAllocationProfiles())
m_arrayAllocationProfiles.resizeToFit(size);
if (size_t size = unlinkedCodeBlock->numberOfValueProfiles())
m_valueProfiles.resizeToFit(size);
-#endif
if (size_t size = unlinkedCodeBlock->numberOfObjectAllocationProfiles())
m_objectAllocationProfiles.resizeToFit(size);
@@ -1668,7 +1666,6 @@
instructions[i + j].u.operand = pc[i + j].u.operand;
}
switch (pc[i].u.opcode) {
-#if ENABLE(DFG_JIT)
case op_get_by_val:
case op_get_argument_by_val: {
int arrayProfileIndex = pc[i + opLength - 2].u.operand;
@@ -1705,7 +1702,6 @@
instructions[i + opLength - 1] = &m_arrayAllocationProfiles[arrayAllocationProfileIndex];
break;
}
-#endif
case op_new_object: {
int objectAllocationProfileIndex = pc[i + opLength - 1].u.operand;
ObjectAllocationProfile* objectAllocationProfile = &m_objectAllocationProfiles[objectAllocationProfileIndex];
@@ -1719,7 +1715,6 @@
case op_call:
case op_call_eval: {
-#if ENABLE(DFG_JIT)
ValueProfile* profile = "" + opLength - 1].u.operand];
ASSERT(profile->m_bytecodeOffset == -1);
profile->m_bytecodeOffset = i;
@@ -1727,7 +1722,6 @@
int arrayProfileIndex = pc[i + opLength - 2].u.operand;
m_arrayProfiles[arrayProfileIndex] = ArrayProfile(i);
instructions[i + opLength - 2] = &m_arrayProfiles[arrayProfileIndex];
-#endif
#if ENABLE(LLINT)
instructions[i + 5] = &m_llintCallLinkInfos[pc[i + 5].u.operand];
#endif
@@ -1737,12 +1731,10 @@
#if ENABLE(LLINT)
instructions[i + 5] = &m_llintCallLinkInfos[pc[i + 5].u.operand];
#endif
-#if ENABLE(DFG_JIT)
ValueProfile* profile = "" + opLength - 1].u.operand];
ASSERT(profile->m_bytecodeOffset == -1);
profile->m_bytecodeOffset = i;
instructions[i + opLength - 1] = profile;
-#endif
break;
}
case op_get_by_id_out_of_line:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161445] branches/jsCStack/Source/JavaScriptCore
Title: [161445] branches/jsCStack/Source/_javascript_Core
Revision 161445
Author fpi...@apple.com
Date 2014-01-07 12:16:37 -0800 (Tue, 07 Jan 2014)
Log Message
FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values
https://bugs.webkit.org/show_bug.cgi?id=126587
Not yet reviewed.
At the prologue of OSR entry, DFG IR knows where the arguments are but has no idea
where the locals are. So, before OSR entry starts doing speculation checks, it
should establish (via MovHints) where the locals are. Then it can do the checks
(namely, the SetArgument/SetLocal's).
Also make things a bit easier to debug by making verboseOSR() print OSR exit
disassemblies.
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
* dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
* dfg/DFGOSRExitCompiler.cpp:
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGOSREntrypointCreationPhase.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGOSRExitCompiler.cpp
branches/jsCStack/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp
branches/jsCStack/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161444 => 161445)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:03:55 UTC (rev 161444)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 20:16:37 UTC (rev 161445)
@@ -1,3 +1,30 @@
+2014-01-07 Filip Pizlo
+
+FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values
+https://bugs.webkit.org/show_bug.cgi?id=126587
+
+Not yet reviewed.
+
+At the prologue of OSR entry, DFG IR knows where the arguments are but has no idea
+where the locals are. So, before OSR entry starts doing speculation checks, it
+should establish (via MovHints) where the locals are. Then it can do the checks
+(namely, the SetArgument/SetLocal's).
+
+Also make things a bit easier to debug by making verboseOSR() print OSR exit
+disassemblies.
+
+* assembler/LinkBuffer.cpp:
+(JSC::LinkBuffer::finalizeCodeWithDisassembly):
+* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
+(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
+* dfg/DFGOSREntrypointCreationPhase.cpp:
+(JSC::DFG::OSREntrypointCreationPhase::run):
+* dfg/DFGOSRExitCompiler.cpp:
+* ftl/FTLOSRExitCompiler.cpp:
+(JSC::FTL::compileStub):
+* runtime/CommonSlowPaths.cpp:
+(JSC::SLOW_PATH_DECL):
+
2014-01-07 Michael Saboff
CStack Branch: ARM64 Crash running ecma/FunctionObjects/15.3.1.1-3.js
Modified: branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp (161444 => 161445)
--- branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp 2014-01-07 20:03:55 UTC (rev 161444)
+++ branches/jsCStack/Source/_javascript_Core/assembler/LinkBuffer.cpp 2014-01-07 20:16:37 UTC (rev 161445)
@@ -46,8 +46,6 @@
LinkBuffer::CodeRef LinkBuffer::finalizeCodeWithDisassembly(const char* format, ...)
{
-ASSERT(Options::showDisassembly() || Options::showDFGDisassembly());
-
CodeRef result = finalizeCodeWithoutDisassembly();
#if ENABLE(DISASSEMBLER)
Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp (161444 => 161445)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp 2014-01-07 20:03:55 UTC (rev 161444)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp 2014-01-07 20:16:37 UTC (rev 161445)
@@ -61,15 +61,13 @@
Availability::unavailable().withFlush(
FlushedAt(FlushedJSValue, virtualRegisterForArgument(argument)));
}
-for (unsigned local = root->ssa->availabilityAtHead.numberOfLocals(); local--;)
-root->ssa->availabilityAtHead.local(local) = Availability::unavailable();
-
+
if (m_graph.m_plan.mode == FTLForOSREntryMode) {
-for (unsigned local = m_graph.m_profiledBlock->m_numCalleeRegisters; local--;) {
-root->ssa->availabilityAtHead.local(local) =
-Availability::unavailable().withFlush(
-FlushedAt(FlushedJSValue, virtualRegisterForLocal(local)));
-}
+for (unsigned local = m_graph.m_profiledBlock->m_nu
[webkit-changes] [161444] trunk/LayoutTests
Title: [161444] trunk/LayoutTests Revision 161444 Author bfulg...@apple.com Date 2014-01-07 12:03:55 -0800 (Tue, 07 Jan 2014) Log Message Unreviewed test expectation update. * platform/mac/TestExpectations: Mark webgl/1.0.2/conformance/rendering/gl-scissor-test.html as flaky on Mavericks Debug. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (161443 => 161444) --- trunk/LayoutTests/ChangeLog 2014-01-07 20:01:31 UTC (rev 161443) +++ trunk/LayoutTests/ChangeLog 2014-01-07 20:03:55 UTC (rev 161444) @@ -1,3 +1,10 @@ +2014-01-07 Brent Fulgham + +Unreviewed test expectation update. + +* platform/mac/TestExpectations: Mark webgl/1.0.2/conformance/rendering/gl-scissor-test.html as flaky on +Mavericks Debug. + 2014-01-07 Gabor Rapcsanyi pushFinallyContext saves wrong m_labelScopes size Modified: trunk/LayoutTests/platform/mac/TestExpectations (161443 => 161444) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-01-07 20:01:31 UTC (rev 161443) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-01-07 20:03:55 UTC (rev 161444) @@ -1312,3 +1312,4 @@ # GL Scissors don't work properly in Mountain Lion. webkit.org/b/126455 [ MountainLion ] webgl/1.0.2/conformance/rendering/gl-scissor-test.html [ Failure ] +webkit.org/b/126586 [ Mavericks Debug] webgl/1.0.2/conformance/rendering/gl-scissor-test.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161443] trunk/Source/WebCore
Title: [161443] trunk/Source/WebCore
Revision 161443
Author carlo...@webkit.org
Date 2014-01-07 12:01:31 -0800 (Tue, 07 Jan 2014)
Log Message
REGRESSION(r161381): [GTK] Rendering is broken in GTK after r161381
https://bugs.webkit.org/show_bug.cgi?id=126570
Reviewed by Tim Horton.
Use LayoutRect::infiniteRect() instead of IntRect::infiniteRect()
when a LayoutRect is expected.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::fragmentsBoundingBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayerBacking.cpp:
(WebCore::clipBox):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::clippedByAncestor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161442 => 161443)
--- trunk/Source/WebCore/ChangeLog 2014-01-07 19:39:50 UTC (rev 161442)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 20:01:31 UTC (rev 161443)
@@ -1,3 +1,23 @@
+2014-01-07 Carlos Garcia Campos
+
+REGRESSION(r161381): [GTK] Rendering is broken in GTK after r161381
+https://bugs.webkit.org/show_bug.cgi?id=126570
+
+Reviewed by Tim Horton.
+
+Use LayoutRect::infiniteRect() instead of IntRect::infiniteRect()
+when a LayoutRect is expected.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::fragmentsBoundingBox):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::collectFragments):
+(WebCore::RenderLayer::calculateClipRects):
+* rendering/RenderLayerBacking.cpp:
+(WebCore::clipBox):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::clippedByAncestor):
+
2014-01-07 Bear Travis
[CSS Shapes] Change default value from 'auto' to 'none'
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (161442 => 161443)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-01-07 19:39:50 UTC (rev 161442)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-01-07 20:01:31 UTC (rev 161443)
@@ -1089,7 +1089,7 @@
for (auto iter = m_regionList.begin(), end = m_regionList.end(); iter != end; ++iter) {
RenderRegion* region = *iter;
LayerFragments fragments;
-region->collectLayerFragments(fragments, layerBoundingBox, IntRect::infiniteRect());
+region->collectLayerFragments(fragments, layerBoundingBox, LayoutRect::infiniteRect());
for (size_t i = 0; i < fragments.size(); ++i) {
const LayerFragment& fragment = fragments.at(i);
LayoutRect fragmentRect(layerBoundingBox);
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (161442 => 161443)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-01-07 19:39:50 UTC (rev 161442)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-01-07 20:01:31 UTC (rev 161443)
@@ -4280,7 +4280,7 @@
ClipRect backgroundRectInFlowThread;
ClipRect foregroundRectInFlowThread;
ClipRect outlineRectInFlowThread;
-calculateRects(paginationClipRectsContext, IntRect::infiniteRect(), layerBoundsInFlowThread, backgroundRectInFlowThread, foregroundRectInFlowThread,
+calculateRects(paginationClipRectsContext, LayoutRect::infiniteRect(), layerBoundsInFlowThread, backgroundRectInFlowThread, foregroundRectInFlowThread,
outlineRectInFlowThread, &offsetWithinPaginatedLayer);
// Take our bounding box within the flow thread and clip it.
@@ -5346,7 +5346,7 @@
{
if (!parent()) {
// The root layer's clip rect is always infinite.
-clipRects.reset(IntRect::infiniteRect());
+clipRects.reset(LayoutRect::infiniteRect());
return;
}
@@ -5372,7 +5372,7 @@
parentLayer->calculateClipRects(parentContext, clipRects);
}
} else
-clipRects.reset(IntRect::infiniteRect());
+clipRects.reset(LayoutRect::infiniteRect());
// A fixed object is essentially the root of its containing block hierarchy, so when
// we encounter such an object, we reset our clip rects to the fixedClipRect.
@@ -5465,7 +5465,7 @@
RenderView& view = renderer().view();
// Note: infinite clipRects should not be scrolled here, otherwise they will accidentally no longer be considered infinite.
-if (parentRects.fixed() && &clipRectsContext.rootLayer->renderer() == &view && backgroundClipRect != IntRect::infiniteRect())
+if (parentRects.fixed() && &clipRectsContext.rootLayer->renderer() == &view && backgroundClipRect != LayoutRect::infiniteRect())
backgroundClipRect.move(view.frameView().scrollOffsetForFixedPosition());
return backgroundClipRect;
@@ -5596,10 +5596,10 @@
Lay
[webkit-changes] [161442] branches/safari-537.74-branch/Source/WebCore
Title: [161442] branches/safari-537.74-branch/Source/WebCore
Revision 161442
Author matthew_han...@apple.com
Date 2014-01-07 11:39:50 -0800 (Tue, 07 Jan 2014)
Log Message
Merge 161050:
Modified Paths
branches/safari-537.74-branch/Source/WebCore/ChangeLog
branches/safari-537.74-branch/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Diff
Modified: branches/safari-537.74-branch/Source/WebCore/ChangeLog (161441 => 161442)
--- branches/safari-537.74-branch/Source/WebCore/ChangeLog 2014-01-07 19:36:11 UTC (rev 161441)
+++ branches/safari-537.74-branch/Source/WebCore/ChangeLog 2014-01-07 19:39:50 UTC (rev 161442)
@@ -1,5 +1,22 @@
2013-12-23 Matthew Hanson
+Merge 161050:
+
+2013-12-23 Ryosuke Niwa
+
+Crash in ReplaceSelectionCommand
+https://bugs.webkit.org/show_bug.cgi?id=126107
+
+Reviewed by Benjamin Poulain.
+
+Merge https://chromium.googlesource.com/chromium/blink/+/c1ebe5c1e808daf9db5e348a8d0ab32570b9f7a5
+except the test since it doesn't reproduce the crash in WebKit.
+
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::doApply):
+
+2013-12-23 Matthew Hanson
+
Merge 161003:
2013-12-23 Lucas Forschler
Modified: branches/safari-537.74-branch/Source/WebCore/editing/ReplaceSelectionCommand.cpp (161441 => 161442)
--- branches/safari-537.74-branch/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2014-01-07 19:36:11 UTC (rev 161441)
+++ branches/safari-537.74-branch/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2014-01-07 19:39:50 UTC (rev 161442)
@@ -988,22 +988,22 @@
// NOTE: This would be an incorrect usage of downstream() if downstream() were changed to mean the last position after
// p that maps to the same visible position as p (since in the case where a br is at the end of a block and collapsed
// away, there are positions after the br which map to the same visible position as [br, 0]).
-Node* endBR = insertionPos.downstream().deprecatedNode()->hasTagName(brTag) ? insertionPos.downstream().deprecatedNode() : 0;
+RefPtr endBR = insertionPos.downstream().deprecatedNode()->hasTagName(brTag) ? insertionPos.downstream().deprecatedNode() : nullptr;
VisiblePosition originalVisPosBeforeEndBR;
if (endBR)
-originalVisPosBeforeEndBR = VisiblePosition(positionBeforeNode(endBR), DOWNSTREAM).previous();
+originalVisPosBeforeEndBR = VisiblePosition(positionBeforeNode(endBR.get()), DOWNSTREAM).previous();
-startBlock = enclosingBlock(insertionPos.deprecatedNode());
+RefPtr insertionBlock = enclosingBlock(insertionPos.deprecatedNode());
// Adjust insertionPos to prevent nesting.
// If the start was in a Mail blockquote, we will have already handled adjusting insertionPos above.
-if (m_preventNesting && startBlock && !isTableCell(startBlock) && !startIsInsideMailBlockquote) {
-ASSERT(startBlock != currentRoot);
+if (m_preventNesting && insertionBlock && !isTableCell(insertionBlock.get()) && !startIsInsideMailBlockquote) {
+ASSERT(insertionBlock != currentRoot);
VisiblePosition visibleInsertionPos(insertionPos);
if (isEndOfBlock(visibleInsertionPos) && !(isStartOfBlock(visibleInsertionPos) && fragment.hasInterchangeNewlineAtEnd()))
-insertionPos = positionInParentAfterNode(startBlock);
+insertionPos = positionInParentAfterNode(insertionBlock.get());
else if (isStartOfBlock(visibleInsertionPos))
-insertionPos = positionInParentBeforeNode(startBlock);
+insertionPos = positionInParentBeforeNode(insertionBlock.get());
}
// Paste at start or end of link goes outside of link.
@@ -1114,14 +1114,14 @@
VisiblePosition startOfInsertedContent = firstPositionInOrBeforeNode(insertedNodes.firstNodeInserted());
-// We inserted before the startBlock to prevent nesting, and the content before the startBlock wasn't in its own block and
+// We inserted before the insertionBlock to prevent nesting, and the content before the insertionBlock wasn't in its own block and
// didn't have a br after it, so the inserted content ended up in the same paragraph.
-if (startBlock && insertionPos.deprecatedNode() == startBlock->parentNode() && (unsigned)insertionPos.deprecatedEditingOffset() < startBlock->nodeIndex() && !isStartOfParagraph(startOfInsertedContent))
+if (insertionBlock && insertionPos.deprecatedNode() == insertionBlock->parentNode() && (unsigned)insertionPos.deprecatedEditingOffset() < insertionBlock->nodeIndex() && !isStartOfParagraph(startOfInsertedContent))
insertNodeAt(createBreakElement(document()).get(), startOfInsertedContent.deepEquivalent());
-if (endBR && (plainTextFragment || shouldRemoveEndBR(endBR, originalVisPosBeforeEndBR))) {
+if (endBR && (plainTextFragment || shouldRemoveEndBR(endBR.get(), originalVisP
[webkit-changes] [161441] trunk/Tools
Title: [161441] trunk/Tools
Revision 161441
Author a...@apple.com
Date 2014-01-07 11:36:11 -0800 (Tue, 07 Jan 2014)
Log Message
There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126472
Reviewed by Timothy Hatcher.
Added a delay when quickly switching to a different popover, making it easier to
move mouse pointer from active element to its popover without accidentally opening
a different popover.
Used this code to add a delay before creating a popover. This doesn't change UI
behavior, as there was alerady a delay before it became visible, but it avoids
flooding buildbot server with http requests when quickly moving the mouse over
dashboard page.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
Fixed a case where popover could get stuck. If content was updated while fade-out
transition was already in place, the transition was removed for no good reason.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
(.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
popover delay from 1s to 800ms.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js (161440 => 161441)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js 2014-01-07 19:36:11 UTC (rev 161441)
@@ -208,12 +208,9 @@
var targetFrame = this._targetFrame;
var preferredEdges = this._preferredEdges;
-// Ensure our element is on display so that its metrics can be resolved
-// or interrupt any pending transition to remove it from display.
+// Ensure our element is on display so that its metrics can be resolved.
if (this._element.parentNode !== document.body)
document.body.appendChild(this._element);
-else
-this._element.classList.remove(Dashboard.Popover.FadeOutClassName);
if (this._contentNeedsUpdate) {
// Reset CSS properties on element so that the element may be sized to fit its content.
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js (161440 => 161441)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-07 19:35:29 UTC (rev 161440)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js 2014-01-07 19:36:11 UTC (rev 161441)
@@ -28,7 +28,7 @@
BaseObject.call(this);
console.assert(element);
-console.assert(presentPopoverCallback && typeof presentPopoverCallback == "function");
+console.assert(presentPopoverCallback && typeof presentPopoverCallback === "function");
this._element = element;
this._presentPopover = presentPopoverCallback;
@@ -40,46 +40,116 @@
element.addEventListener("mouseleave", this._mouseExitedPopoverOrElement.bind(this), true);
};
-PopoverTracker._popover = null; // Only one popover may be active at any time.
+// Only one popover may be active at any time. An active popover is not necessarily visible already.
+PopoverTracker._popover = null;
+// A candidate timer may be active whether we have an active popover or not.
+PopoverTracker._candidateTracker = null;
+PopoverTracker._candidateTimer = null;
+PopoverTracker.CandidateSwitchDelay = 200;
+
BaseObject.addConstructorFunctions(PopoverTracker);
+PopoverTracker._setCandidatePopoverTracker = function(popoverTracker)
+{
+console.assert(!popoverTracker || !popoverTracker._active);
+
+if (PopoverTracker._candidateTracker) {
+clearTimeout(PopoverTracker._candidateTimer);
+PopoverTracker._candidateTimer = null;
+}
+
+console.assert(!PopoverTracker._candidateTimer);
+
+PopoverTracker._candidateTracker = popoverTracker;
+
+if (popoverTracker)
+PopoverTracker._candidateTimer = setTimeout(PopoverTracker._candidatePopoverTrackerTimerFired, PopoverTracker.CandidateSwitchDelay);
+}
+
+PopoverTracker._candidatePopoverTrackerTimerFired = function()
+{
+var hadPopover = !!PopoverTracker._popover;
+if (hadPopover) {
+console.assert(PopoverTracker._popover.visible);
+
[webkit-changes] [161440] trunk/Tools
Title: [161440] trunk/Tools
Revision 161440
Author a...@apple.com
Date 2014-01-07 11:35:29 -0800 (Tue, 07 Jan 2014)
Log Message
Improve display of failed builds at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=126542
Reviewed by Timothy Hatcher.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
Instead of hardcoding step name, look for the first step that failed.
While at it, added a popover with more links. There are multiple, and it's good
to have a choice of which one to look at in each situation.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.get successful): Being successful is not the opposite
of having failed. Many iterations are interrupted for whatever reason internal to
Buildbot, and these are suppoed to be orange, not red.
(BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
not only WillRetry ones.
(BuildbotIteration.prototype.get failed): Changed to only include iterations that
actually failed, more likely indicating a problem with code base.
(BuildbotIteration.prototype.get firstFailedStepName):
(BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
(BuildbotIteration.prototype.get failureLogs): Ditto.
(BuildbotIteration.prototype.update): Store complete results for the failed step.
Not every failure stops the iteration, so we could have multiple failed steps,
but let's see if seeing just the first one will be enough.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
terms of successful iterations.
(BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
terms of successful iterations.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
Removed code to create a path to build output, we now take it from results JSON.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
Added styles for the new popover.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (161439 => 161440)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-07 19:30:34 UTC (rev 161439)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2014-01-07 19:35:29 UTC (rev 161440)
@@ -62,36 +62,43 @@
{
this._appendPendingRevisionCount(queue);
-var firstRecentFailedIteration = queue.firstRecentFailedIteration;
-if (firstRecentFailedIteration && firstRecentFailedIteration.loaded) {
+var firstRecentUnsuccessfulIteration = queue.firstRecentUnsuccessfulIteration;
+if (firstRecentUnsuccessfulIteration && firstRecentUnsuccessfulIteration.loaded) {
var failureCount = queue.recentFailedIterationCount;
-var message = this.revisionContentForIteration(firstRecentFailedIteration);
-if (firstRecentFailedIteration.webkitCompilationFailed) {
-// Link directly to compiler output.
-// FIXME: Results JSON may contain multiple log links, including one for nicely filtered result.
-// Which one is best to use? Do we want the filtered one in a popover?
-var url = ""
+var message = this.revisionContentForIteration(firstRecentUnsuccessfulIteration);
+if (firstRecentUnsuccessfulIteration.failed) {
+// Assume it was a build step that failed, and link directly to output.
+var url = "" log");
+if (!url)
+url = ""
var status = StatusLineView.Status.Bad;
-} else {
-// Some other step failed, link to main buildbot
[webkit-changes] [161439] branches/jsCStack/Source/JavaScriptCore
Title: [161439] branches/jsCStack/Source/_javascript_Core
Revision 161439
Author msab...@apple.com
Date 2014-01-07 11:30:34 -0800 (Tue, 07 Jan 2014)
Log Message
CStack Branch: ARM64 Crash running ecma/FunctionObjects/15.3.1.1-3.js
https://bugs.webkit.org/show_bug.cgi?id=126585
Reviewed by Geoffrey Garen.
We were improperly using a shifted add/subtract for operations with the stack
pointer as the destination. Broadened the cases where we use the extended
register version of add/subtract to include when the destination is the
stack pointer. In the ARM64 documentation, the immediate and extended register
forms of add and subtract are the right variants to manipulate the stack pointer.
* assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::add):
(JSC::ARM64Assembler::sub):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/assembler/ARM64Assembler.h
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161438 => 161439)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 19:14:59 UTC (rev 161438)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 19:30:34 UTC (rev 161439)
@@ -1,3 +1,20 @@
+2014-01-07 Michael Saboff
+
+CStack Branch: ARM64 Crash running ecma/FunctionObjects/15.3.1.1-3.js
+https://bugs.webkit.org/show_bug.cgi?id=126585
+
+Reviewed by Geoffrey Garen.
+
+We were improperly using a shifted add/subtract for operations with the stack
+pointer as the destination. Broadened the cases where we use the extended
+register version of add/subtract to include when the destination is the
+stack pointer. In the ARM64 documentation, the immediate and extended register
+forms of add and subtract are the right variants to manipulate the stack pointer.
+
+* assembler/ARM64Assembler.h:
+(JSC::ARM64Assembler::add):
+(JSC::ARM64Assembler::sub):
+
2014-01-07 Filip Pizlo
Merge trunk r161411.
Modified: branches/jsCStack/Source/_javascript_Core/assembler/ARM64Assembler.h (161438 => 161439)
--- branches/jsCStack/Source/_javascript_Core/assembler/ARM64Assembler.h 2014-01-07 19:14:59 UTC (rev 161438)
+++ branches/jsCStack/Source/_javascript_Core/assembler/ARM64Assembler.h 2014-01-07 19:30:34 UTC (rev 161439)
@@ -929,8 +929,9 @@
ALWAYS_INLINE void add(RegisterID rd, RegisterID rn, RegisterID rm, ShiftType shift, int amount)
{
CHECK_DATASIZE();
-if (isSp(rn)) {
+if (isSp(rd) || isSp(rn)) {
ASSERT(shift == LSL);
+ASSERT(!isSp(rm));
add(rd, rn, rm, UXTX, amount);
} else
insn(addSubtractShiftedRegister(DATASIZE, AddOp_ADD, setFlags, shift, rm, amount, rn, rd));
@@ -1962,8 +1963,9 @@
ALWAYS_INLINE void sub(RegisterID rd, RegisterID rn, RegisterID rm, ShiftType shift, int amount)
{
CHECK_DATASIZE();
-if (isSp(rn)) {
+if (isSp(rd) || isSp(rn)) {
ASSERT(shift == LSL);
+ASSERT(!isSp(rm));
sub(rd, rn, rm, UXTX, amount);
} else
insn(addSubtractShiftedRegister(DATASIZE, AddOp_SUB, setFlags, shift, rm, amount, rn, rd));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161438] trunk/Source/JavaScriptCore
Title: [161438] trunk/Source/_javascript_Core
Revision 161438
Author fpi...@apple.com
Date 2014-01-07 11:14:59 -0800 (Tue, 07 Jan 2014)
Log Message
ASSERT in compileArithNegate on pdfjs
https://bugs.webkit.org/show_bug.cgi?id=126584
Reviewed by Mark Hahnenberg.
Check negative zero when we should check it, not when we shouldn't check it. :-/
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithNegate):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161437 => 161438)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 19:10:51 UTC (rev 161437)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 19:14:59 UTC (rev 161438)
@@ -1,3 +1,15 @@
+2014-01-07 Filip Pizlo
+
+ASSERT in compileArithNegate on pdfjs
+https://bugs.webkit.org/show_bug.cgi?id=126584
+
+Reviewed by Mark Hahnenberg.
+
+Check negative zero when we should check it, not when we shouldn't check it. :-/
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileArithNegate):
+
2014-01-07 Gabor Rapcsanyi
pushFinallyContext saves wrong m_labelScopes size
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (161437 => 161438)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2014-01-07 19:10:51 UTC (rev 161437)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2014-01-07 19:14:59 UTC (rev 161438)
@@ -2900,7 +2900,7 @@
GPRReg resultGPR = result.gpr();
m_jit.move(op1GPR, resultGPR);
m_jit.neg64(resultGPR);
-if (!shouldCheckNegativeZero(node->arithMode())) {
+if (shouldCheckNegativeZero(node->arithMode())) {
speculationCheck(
NegativeZero, JSValueRegs(), 0,
m_jit.branchTest64(MacroAssembler::Zero, resultGPR));
@@ -2917,7 +2917,7 @@
speculationCheck(
Int52Overflow, JSValueRegs(), 0,
m_jit.branchNeg64(MacroAssembler::Overflow, resultGPR));
-if (!shouldCheckNegativeZero(node->arithMode())) {
+if (shouldCheckNegativeZero(node->arithMode())) {
speculationCheck(
NegativeZero, JSValueRegs(), 0,
m_jit.branchTest64(MacroAssembler::Zero, resultGPR));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161437] trunk
Title: [161437] trunk
Revision 161437
Author rga...@webkit.org
Date 2014-01-07 11:10:51 -0800 (Tue, 07 Jan 2014)
Log Message
pushFinallyContext saves wrong m_labelScopes size
https://bugs.webkit.org/show_bug.cgi?id=124529
Remove free label scopes before saving finally context.
Reviewed by Geoffrey Garen.
Source/_javascript_Core:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::pushFinallyContext):
LayoutTests:
* js/script-tests/try-return-finally-break.js: Added.
(foo):
* js/try-return-finally-break-expected.txt: Added.
* js/try-return-finally-break.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
Added Paths
trunk/LayoutTests/js/script-tests/try-return-finally-break.js
trunk/LayoutTests/js/try-return-finally-break-expected.txt
trunk/LayoutTests/js/try-return-finally-break.html
Diff
Modified: trunk/LayoutTests/ChangeLog (161436 => 161437)
--- trunk/LayoutTests/ChangeLog 2014-01-07 18:59:32 UTC (rev 161436)
+++ trunk/LayoutTests/ChangeLog 2014-01-07 19:10:51 UTC (rev 161437)
@@ -1,3 +1,17 @@
+2014-01-07 Gabor Rapcsanyi
+
+pushFinallyContext saves wrong m_labelScopes size
+https://bugs.webkit.org/show_bug.cgi?id=124529
+
+Remove free label scopes before saving finally context.
+
+Reviewed by Geoffrey Garen.
+
+* js/script-tests/try-return-finally-break.js: Added.
+(foo):
+* js/try-return-finally-break-expected.txt: Added.
+* js/try-return-finally-break.html: Added.
+
2014-01-07 Bear Travis
[CSS Shapes] Change default value from 'auto' to 'none'
Added: trunk/LayoutTests/js/script-tests/try-return-finally-break.js (0 => 161437)
--- trunk/LayoutTests/js/script-tests/try-return-finally-break.js (rev 0)
+++ trunk/LayoutTests/js/script-tests/try-return-finally-break.js 2014-01-07 19:10:51 UTC (rev 161437)
@@ -0,0 +1,21 @@
+description(
+"Tests what would happen if you have a break in the finally block. The correct outcome is for this test to not crash during bytecompilation."
+);
+
+function foo() {
+do {
+do {} while (false);
+
+try {
+do {
+return null;
+} while (false);
+} finally {
+break;
+}
+} while (false);
+}
+
+foo();
+testPassed("It worked.");
+
Added: trunk/LayoutTests/js/try-return-finally-break-expected.txt (0 => 161437)
--- trunk/LayoutTests/js/try-return-finally-break-expected.txt (rev 0)
+++ trunk/LayoutTests/js/try-return-finally-break-expected.txt 2014-01-07 19:10:51 UTC (rev 161437)
@@ -0,0 +1,10 @@
+Tests what would happen if you have a break in the finally block. The correct outcome is for this test to not crash during bytecompilation.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS It worked.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/js/try-return-finally-break.html (0 => 161437)
--- trunk/LayoutTests/js/try-return-finally-break.html (rev 0)
+++ trunk/LayoutTests/js/try-return-finally-break.html 2014-01-07 19:10:51 UTC (rev 161437)
@@ -0,0 +1,10 @@
+
+
+
+
[webkit-changes] [161435] branches/jsCStack/Source/JavaScriptCore
Title: [161435] branches/jsCStack/Source/_javascript_Core Revision 161435 Author fpi...@apple.com Date 2014-01-07 10:47:31 -0800 (Tue, 07 Jan 2014) Log Message Merge trunk r161411. Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161434 => 161435) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 18:30:23 UTC (rev 161434) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 18:47:31 UTC (rev 161435) @@ -1,5 +1,9 @@ 2014-01-07 Filip Pizlo +Merge trunk r161411. + +2014-01-07 Filip Pizlo + Really merge r161399. * dfg/DFGArithMode.cpp: Added. Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (161434 => 161435) --- branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2014-01-07 18:30:23 UTC (rev 161434) +++ branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2014-01-07 18:47:31 UTC (rev 161435) @@ -1943,7 +1943,7 @@ m_jit.store32(value.payloadGPR(), JITCompiler::payloadFor(node->machineLocal())); m_jit.store32(value.tagGPR(), JITCompiler::tagFor(node->machineLocal())); noResult(node); -recordSetLocal(DataFormatJS); +recordSetLocal(dataFormatFor(node->variableAccessData()->flushFormat())); break; } Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (161434 => 161435) --- branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-07 18:30:23 UTC (rev 161434) +++ branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-07 18:47:31 UTC (rev 161435) @@ -2256,7 +2256,7 @@ JSValueOperand value(this, node->child1()); m_jit.store64(value.gpr(), JITCompiler::addressFor(node->machineLocal())); noResult(node); -recordSetLocal(DataFormatJS); +recordSetLocal(dataFormatFor(node->variableAccessData()->flushFormat())); break; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161433] branches/jsCStack/Source/JavaScriptCore
Title: [161433] branches/jsCStack/Source/_javascript_Core
Revision 161433
Author fpi...@apple.com
Date 2014-01-07 10:29:21 -0800 (Tue, 07 Jan 2014)
Log Message
Really merge r161399.
* dfg/DFGArithMode.cpp: Added.
* dfg/DFGArithMode.h: Added.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
Added Paths
branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.cpp
branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.h
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161432 => 161433)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 18:04:44 UTC (rev 161432)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 18:29:21 UTC (rev 161433)
@@ -1,3 +1,10 @@
+2014-01-07 Filip Pizlo
+
+Really merge r161399.
+
+* dfg/DFGArithMode.cpp: Added.
+* dfg/DFGArithMode.h: Added.
+
2014-01-07 Michael Saboff
CStack Branch: Disable JIT stack alignment check for ARM64
Added: branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.cpp (0 => 161433)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.cpp (rev 0)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.cpp 2014-01-07 18:29:21 UTC (rev 161433)
@@ -0,0 +1,60 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "DFGArithMode.h"
+
+#if ENABLE(DFG_JIT)
+
+#include
+
+namespace WTF {
+
+void printInternal(PrintStream& out, JSC::DFG::Arith::Mode mode)
+{
+switch (mode) {
+case JSC::DFG::Arith::NotSet:
+out.print("NotSet");
+return;
+case JSC::DFG::Arith::Unchecked:
+out.print("Unchecked");
+return;
+case JSC::DFG::Arith::CheckOverflow:
+out.print("CheckOverflow");
+return;
+case JSC::DFG::Arith::CheckOverflowAndNegativeZero:
+out.print("CheckOverflowAndNegativeZero");
+return;
+case JSC::DFG::Arith::DoOverflow:
+out.print("DoOverflow");
+return;
+}
+RELEASE_ASSERT_NOT_REACHED();
+}
+
+} // namespace WTF
+
+#endif // ENABLE(DFG_JIT)
+
Added: branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.h (0 => 161433)
--- branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.h (rev 0)
+++ branches/jsCStack/Source/_javascript_Core/dfg/DFGArithMode.h 2014-01-07 18:29:21 UTC (rev 161433)
@@ -0,0 +1,109 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY W
[webkit-changes] [161432] trunk/Source/WebCore
Title: [161432] trunk/Source/WebCore
Revision 161432
Author a...@apple.com
Date 2014-01-07 10:04:44 -0800 (Tue, 07 Jan 2014)
Log Message
Debug biuld fix.
Replace actionTag with mactionTag in assertions.
* mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/mathml/MathMLSelectElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161431 => 161432)
--- trunk/Source/WebCore/ChangeLog 2014-01-07 17:57:17 UTC (rev 161431)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 18:04:44 UTC (rev 161432)
@@ -1,3 +1,13 @@
+2014-01-07 Alexey Proskuryakov
+
+Debug biuld fix.
+
+Replace actionTag with mactionTag in assertions.
+
+* mathml/MathMLSelectElement.cpp:
+(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
+(WebCore::MathMLSelectElement::getSelectedActionChild):
+
2014-01-07 Frédéric Wang
Add Support for the semantics element.
@@ -3,5 +13,4 @@
https://bugs.webkit.org/show_bug.cgi?id=100626
-
Reviewed by Chris Fleizach.
Modified: trunk/Source/WebCore/mathml/MathMLSelectElement.cpp (161431 => 161432)
--- trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2014-01-07 17:57:17 UTC (rev 161431)
+++ trunk/Source/WebCore/mathml/MathMLSelectElement.cpp 2014-01-07 18:04:44 UTC (rev 161432)
@@ -79,7 +79,7 @@
int MathMLSelectElement::getSelectedActionChildAndIndex(Element*& selectedChild)
{
-ASSERT(hasLocalName(actionTag));
+ASSERT(hasLocalName(mactionTag));
// We "round up or down to the closest allowable value" of the selection attribute, as suggested by the MathML specification.
selectedChild = firstElementChild();
@@ -100,7 +100,7 @@
Element* MathMLSelectElement::getSelectedActionChild()
{
-ASSERT(hasLocalName(actionTag));
+ASSERT(hasLocalName(mactionTag));
Element* child = firstElementChild();
if (!child)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161431] branches/jsCStack/Source/JavaScriptCore
Title: [161431] branches/jsCStack/Source/_javascript_Core
Revision 161431
Author msab...@apple.com
Date 2014-01-07 09:57:17 -0800 (Tue, 07 Jan 2014)
Log Message
CStack Branch: Disable JIT stack alignment check for ARM64
https://bugs.webkit.org/show_bug.cgi?id=126550
Unreviewed comment only change.
Added comment to checkStackPointerAlignment() suggested by Darin Adler.
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161430 => 161431)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 17:49:04 UTC (rev 161430)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 17:57:17 UTC (rev 161431)
@@ -1,3 +1,12 @@
+2014-01-07 Michael Saboff
+
+CStack Branch: Disable JIT stack alignment check for ARM64
+https://bugs.webkit.org/show_bug.cgi?id=126550
+
+Unreviewed comment only change.
+
+Added comment to checkStackPointerAlignment() suggested by Darin Adler.
+
2014-01-06 Filip Pizlo
Merge trunk r161072, r161126, r161218, r161353, r161356, r161364, 161399.
Modified: branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h (161430 => 161431)
--- branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h 2014-01-07 17:49:04 UTC (rev 161430)
+++ branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h 2014-01-07 17:57:17 UTC (rev 161431)
@@ -61,6 +61,7 @@
void checkStackPointerAlignment()
{
+// This check is both unneeded and harder to write correctly for ARM64
#if !defined(NDEBUG) && !CPU(ARM64)
Jump stackPointerAligned = branchTestPtr(Zero, stackPointerRegister, TrustedImm32(0xf));
breakpoint();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161430] trunk
Title: [161430] trunk Revision 161430 Author commit-qu...@webkit.org Date 2014-01-07 09:49:04 -0800 (Tue, 07 Jan 2014) Log Message Add Support for the semantics element. https://bugs.webkit.org/show_bug.cgi?id=100626 Source/WebCore: Patch by Frédéric Wang on 2014-01-07 Reviewed by Chris Fleizach. Tests: mathml/presentation/semantics-2.html mathml/presentation/semantics-3.html mathml/presentation/semantics-4.html This provides a complete support for the semantics element. When the first child is a content MathML, an annotation can be selected and displayed. The selection algorithm is identical to Gecko's one. The recognized annotations are text (e.g. LaTeX), presentation MathML, SVG and HTML. * mathml/MathMLElement.cpp: (WebCore::MathMLElement::childShouldCreateRenderer): (WebCore::MathMLElement::attributeChanged): (WebCore::MathMLElement::isPresentationMathML): * mathml/MathMLElement.h: (WebCore::MathMLElement::isMathMLToken): (WebCore::MathMLElement::isSemanticAnnotation): (WebCore::MathMLElement::isPresentationMathML): (WebCore::MathMLElement::updateSelectedChild): * mathml/MathMLInlineContainerElement.h: * mathml/MathMLSelectElement.cpp: (WebCore::MathMLSelectElement::getSelectedActionChildAndIndex): (WebCore::MathMLSelectElement::getSelectedActionChild): (WebCore::MathMLSelectElement::getSelectedSemanticsChild): (WebCore::MathMLSelectElement::updateSelectedChild): (WebCore::MathMLSelectElement::toggle): * mathml/MathMLSelectElement.h: * mathml/MathMLTextElement.h: * mathml/mathattrs.in: * mathml/mathtags.in: LayoutTests: Patch by Frédéric Wang on 2014-01-07 Reviewed by Chris Fleizach. * TestExpectations: * mathml/presentation/semantics-2-expected.html: Added. * mathml/presentation/semantics-2.html: Added. * mathml/presentation/semantics-3-expected.html: Added. * mathml/presentation/semantics-3.html: Added. * mathml/presentation/semantics-4-expected.html: Added. * mathml/presentation/semantics-4.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/mathml/MathMLElement.cpp trunk/Source/WebCore/mathml/MathMLElement.h trunk/Source/WebCore/mathml/MathMLInlineContainerElement.h trunk/Source/WebCore/mathml/MathMLSelectElement.cpp trunk/Source/WebCore/mathml/MathMLSelectElement.h trunk/Source/WebCore/mathml/MathMLTextElement.h trunk/Source/WebCore/mathml/mathattrs.in trunk/Source/WebCore/mathml/mathtags.in Added Paths trunk/LayoutTests/mathml/presentation/semantics-2-expected.html trunk/LayoutTests/mathml/presentation/semantics-2.html trunk/LayoutTests/mathml/presentation/semantics-3-expected.html trunk/LayoutTests/mathml/presentation/semantics-3.html trunk/LayoutTests/mathml/presentation/semantics-4-expected.html trunk/LayoutTests/mathml/presentation/semantics-4.html Diff Modified: trunk/LayoutTests/ChangeLog (161429 => 161430) --- trunk/LayoutTests/ChangeLog 2014-01-07 17:39:52 UTC (rev 161429) +++ trunk/LayoutTests/ChangeLog 2014-01-07 17:49:04 UTC (rev 161430) @@ -1,3 +1,18 @@ +2014-01-07 Frédéric Wang + +Add Support for the semantics element. +https://bugs.webkit.org/show_bug.cgi?id=100626 + +Reviewed by Chris Fleizach. + +* TestExpectations: +* mathml/presentation/semantics-2-expected.html: Added. +* mathml/presentation/semantics-2.html: Added. +* mathml/presentation/semantics-3-expected.html: Added. +* mathml/presentation/semantics-3.html: Added. +* mathml/presentation/semantics-4-expected.html: Added. +* mathml/presentation/semantics-4.html: Added. + 2014-01-07 Manuel Rego Casasnovas [GTK] fast/repaint/repaint-regions-overflow.html is failing Modified: trunk/LayoutTests/TestExpectations (161429 => 161430) --- trunk/LayoutTests/TestExpectations 2014-01-07 17:39:52 UTC (rev 161429) +++ trunk/LayoutTests/TestExpectations 2014-01-07 17:49:04 UTC (rev 161430) @@ -21,9 +21,6 @@ webkit.org/b/57700 mathml/presentation/row.xhtml [ Failure ] webkit.org/b/57700 mathml/presentation/mo.xhtml [ Failure ] -# MathML regression with foreign objects -webkit.org/b/124128 mathml/presentation/semantics.html [ Skip ] - # These conformace tests are no longer in sync with the latest specification # and expect compareDocumentPosition() to return: # DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC | DOCUMENT_POSITION_DISCONNECTED Added: trunk/LayoutTests/mathml/presentation/semantics-2-expected.html (0 => 161430) --- trunk/LayoutTests/mathml/presentation/semantics-2-expected.html (rev 0) +++ trunk/LayoutTests/mathml/presentation/semantics-2-expected.html 2014-01-07 17:49:04 UTC (rev 161430) @@ -0,0 +1,15 @@ + + + + Semantics + + + + presentation MathML (no annotations): presentation MathML + content MathML (no annotations): content MathML + presentation MathML ; annotation: presentation MathML + presentation MathML ; annotation-xml: presentation MathML + content
[webkit-changes] [161429] trunk/Source/JavaScriptCore
Title: [161429] trunk/Source/_javascript_Core
Revision 161429
Author mhahnenb...@apple.com
Date 2014-01-07 09:39:52 -0800 (Tue, 07 Jan 2014)
Log Message
Heap::collect shouldn't be responsible for sweeping
https://bugs.webkit.org/show_bug.cgi?id=126556
Reviewed by Geoffrey Garen.
Sweeping happens at an awkward time during collection due to the fact that destructors can
cause arbitrary reentry into the VM. This patch separates collecting and sweeping, and delays
sweeping until after collection has completely finished.
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectIfNecessaryOrDefer):
* heap/Heap.h:
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep):
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/MarkedSpace.cpp
trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161428 => 161429)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 17:34:59 UTC (rev 161428)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 17:39:52 UTC (rev 161429)
@@ -1,3 +1,24 @@
+2014-01-06 Mark Hahnenberg
+
+Heap::collect shouldn't be responsible for sweeping
+https://bugs.webkit.org/show_bug.cgi?id=126556
+
+Reviewed by Geoffrey Garen.
+
+Sweeping happens at an awkward time during collection due to the fact that destructors can
+cause arbitrary reentry into the VM. This patch separates collecting and sweeping, and delays
+sweeping until after collection has completely finished.
+
+* heap/Heap.cpp:
+(JSC::Heap::collectAllGarbage):
+(JSC::Heap::collect):
+(JSC::Heap::collectIfNecessaryOrDefer):
+* heap/Heap.h:
+* heap/MarkedSpace.cpp:
+(JSC::MarkedSpace::sweep):
+* runtime/GCActivityCallback.cpp:
+(JSC::DefaultGCActivityCallback::doWork):
+
2014-01-07 Mark Rowe
Remove the legacy WebKit availability macros
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (161428 => 161429)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2014-01-07 17:34:59 UTC (rev 161428)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2014-01-07 17:39:52 UTC (rev 161429)
@@ -727,14 +727,18 @@
{
if (!m_isSafeToCollect)
return;
-
+
+collect();
+
+SamplingRegion samplingRegion("Garbage Collection: Sweeping");
DelayedReleaseScope delayedReleaseScope(m_objectSpace);
-collect(DoSweep);
+m_objectSpace.sweep();
+m_objectSpace.shrink();
}
static double minute = 60.0;
-void Heap::collect(SweepToggle sweepToggle)
+void Heap::collect()
{
#if ENABLE(ALLOCATION_LOGGING)
dataLogF("JSC GC starting collection.\n");
@@ -742,7 +746,7 @@
double before = 0;
if (Options::logGC()) {
-dataLog("[GC", sweepToggle == DoSweep ? " (eager sweep)" : "", ": ");
+dataLog("[GC: ");
before = currentTimeMS();
}
@@ -815,13 +819,6 @@
m_vm->clearSourceProviderCaches();
}
-if (sweepToggle == DoSweep) {
-SamplingRegion samplingRegion("Garbage Collection: Sweeping");
-GCPHASE(Sweeping);
-m_objectSpace.sweep();
-m_objectSpace.shrink();
-}
-
m_sweeper->startSweeping(m_blockSnapshot);
m_bytesAbandoned = 0;
@@ -880,7 +877,7 @@
if (!shouldCollect())
return false;
-collect(DoNotSweep);
+collect();
return true;
}
Modified: trunk/Source/_javascript_Core/heap/Heap.h (161428 => 161429)
--- trunk/Source/_javascript_Core/heap/Heap.h 2014-01-07 17:34:59 UTC (rev 161428)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2014-01-07 17:39:52 UTC (rev 161429)
@@ -139,9 +139,8 @@
bool isSafeToCollect() const { return m_isSafeToCollect; }
JS_EXPORT_PRIVATE void collectAllGarbage();
-enum SweepToggle { DoNotSweep, DoSweep };
bool shouldCollect();
-void collect(SweepToggle);
+void collect();
bool collectIfNecessaryOrDefer(); // Returns true if it did collect.
void reportExtraMemoryCost(size_t cost);
Modified: trunk/Source/_javascript_Core/heap/MarkedSpace.cpp (161428 => 161429)
--- trunk/Source/_javascript_Core/heap/MarkedSpace.cpp 2014-01-07 17:34:59 UTC (rev 161428)
+++ trunk/Source/_javascript_Core/heap/MarkedSpace.cpp 2014-01-07 17:39:52 UTC (rev 161429)
@@ -120,6 +120,8 @@
void MarkedSpace::sweep()
{
+if (Options::logGC())
+dataLog("Eagerly sweeping...");
m_heap->sweeper()->willFinishSweeping();
forEachBlock();
}
Modified: trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp (161428 => 161429)
--- trunk/Source/_javascript_Core/runtime/GCActivityCallback.cpp 2014-01-07 17:34:59 UTC (rev 161428)
+++ trunk/Source/_javascript_Cor
[webkit-changes] [161428] trunk/Source/WebCore
Title: [161428] trunk/Source/WebCore Revision 161428 Author commit-qu...@webkit.org Date 2014-01-07 09:34:59 -0800 (Tue, 07 Jan 2014) Log Message Fix compilation issue with GLES2 after http://webkit.org/b/126548 https://bugs.webkit.org/show_bug.cgi?id=126578 Patch by Pascal Jacquemart on 2014-01-07 Reviewed by Brent Fulgham * platform/graphics/opengl/TemporaryOpenGLSetting.cpp: added GLES2/gl2.h include Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (161427 => 161428) --- trunk/Source/WebCore/ChangeLog 2014-01-07 16:59:16 UTC (rev 161427) +++ trunk/Source/WebCore/ChangeLog 2014-01-07 17:34:59 UTC (rev 161428) @@ -1,3 +1,12 @@ +2014-01-07 Pascal Jacquemart + +Fix compilation issue with GLES2 after http://webkit.org/b/126548 +https://bugs.webkit.org/show_bug.cgi?id=126578 + +Reviewed by Brent Fulgham + +* platform/graphics/opengl/TemporaryOpenGLSetting.cpp: added GLES2/gl2.h include + 2014-01-07 László Langó Remove some extra includes from XML. Modified: trunk/Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp (161427 => 161428) --- trunk/Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp 2014-01-07 16:59:16 UTC (rev 161427) +++ trunk/Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp 2014-01-07 17:34:59 UTC (rev 161428) @@ -30,6 +30,7 @@ #include "TemporaryOpenGLSetting.h" #if USE(OPENGL_ES_2) +#include #include "OpenGLESShims.h" #elif PLATFORM(MAC) #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161427] trunk/Tools
Title: [161427] trunk/Tools
Revision 161427
Author commit-qu...@webkit.org
Date 2014-01-07 08:59:16 -0800 (Tue, 07 Jan 2014)
Log Message
defined constants should use all uppercase names with words separated by underscores.
https://bugs.webkit.org/show_bug.cgi?id=126055
Patch by Gergo Balogh on 2014-01-07
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_style):
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_define_constants):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (161426 => 161427)
--- trunk/Tools/ChangeLog 2014-01-07 15:29:17 UTC (rev 161426)
+++ trunk/Tools/ChangeLog 2014-01-07 16:59:16 UTC (rev 161427)
@@ -1,3 +1,16 @@
+2014-01-07 Gergo Balogh
+
+defined constants should use all uppercase names with words separated by underscores.
+https://bugs.webkit.org/show_bug.cgi?id=126055
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_style):
+(CppChecker):
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_define_constants):
+
2014-01-07 Brian Holt
Unreviewed. Add myself as a committer.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (161426 => 161427)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2014-01-07 15:29:17 UTC (rev 161426)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2014-01-07 16:59:16 UTC (rev 161427)
@@ -2719,7 +2719,15 @@
check_indentation_amount(clean_lines, line_number, error)
check_enum_casing(clean_lines, line_number, enum_state, error)
+# #defined constants should use all uppercase names with words separated by underscores.
+define_check = match(r'#define\s(?P[\w_]+)(\s.*|\s?)$', line)
+if define_check:
+name = define_check.group('name')
+if not match(r'^[0-9A-Z_]+$', name):
+error(line_number, 'readability/naming/define/constants', 4,
+name + " is incorrect. #defined constants should use all uppercase names with words separated by underscores.")
+
_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"')
_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
# Matches the first component of a filename delimited by -s and _s. That is:
@@ -3700,6 +3708,7 @@
'readability/parameter_name',
'readability/naming',
'readability/naming/underscores',
+'readability/naming/define/constants',
'readability/null',
'readability/pass_ptr',
'readability/streams',
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (161426 => 161427)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2014-01-07 15:29:17 UTC (rev 161426)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2014-01-07 16:59:16 UTC (rev 161427)
@@ -5026,7 +5026,20 @@
# FIXME: Implement this.
pass
+def test_define_constants(self):
+bad_name_error = " is incorrect. #defined constants should use all uppercase names with words separated by underscores. [readability/naming/define/constants] [4]"
+self.assert_lint('#define lower1case', 'lower1case' + bad_name_error)
+self.assert_lint('#define UPPER1CASE', '')
+self.assert_lint('#define mixed1CASE', 'mixed1CASE' + bad_name_error)
+self.assert_lint('#define lower_1case', 'lower_1case' + bad_name_error)
+self.assert_lint('#define UPPER_1CASE', '')
+self.assert_lint('#define mixed_1CASE', 'mixed_1CASE' + bad_name_error)
+self.assert_lint('#define dlower1case some(bla)', 'dlower1case' + bad_name_error)
+self.assert_lint('#define DUPPER1CASE dd(foo)', '')
+self.assert_lint('#define Dmixed1CASE dkjgh[sdf]', 'Dmixed1CASE' + bad_name_error)
+
+
class CppCheckerTest(unittest.TestCase):
"""Tests CppChecker class."""
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161425] trunk/Source/WebCore
Title: [161425] trunk/Source/WebCore
Revision 161425
Author commit-qu...@webkit.org
Date 2014-01-07 07:24:52 -0800 (Tue, 07 Jan 2014)
Log Message
Remove some extra includes from XML.
https://bugs.webkit.org/show_bug.cgi?id=126572
Patch by László Langó on 2014-01-07
Reviewed by Anders Carlsson.
No new tests, no functionality changed.
* xml/XMLHttpRequest.cpp:
* xml/XMLHttpRequestUpload.cpp:
* xml/XMLHttpRequestUpload.h:
* xml/XPathEvaluator.cpp:
* xml/XPathExpression.cpp:
* xml/XPathExpressionNode.cpp:
* xml/XPathFunctions.cpp:
* xml/XPathNodeSet.cpp:
* xml/XPathParser.cpp:
* xml/XPathPath.cpp:
* xml/XPathPredicate.cpp:
* xml/XPathPredicate.h:
* xml/XPathResult.cpp:
* xml/XPathValue.cpp:
* xml/XPathVariableReference.cpp:
* xml/XSLImportRule.cpp:
* xml/XSLStyleSheetLibxslt.cpp:
* xml/XSLTProcessorLibxslt.cpp:
* xml/parser/XMLDocumentParser.cpp:
* xml/parser/XMLDocumentParserLibxml2.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequestUpload.cpp
trunk/Source/WebCore/xml/XMLHttpRequestUpload.h
trunk/Source/WebCore/xml/XPathEvaluator.cpp
trunk/Source/WebCore/xml/XPathExpression.cpp
trunk/Source/WebCore/xml/XPathExpressionNode.cpp
trunk/Source/WebCore/xml/XPathFunctions.cpp
trunk/Source/WebCore/xml/XPathNodeSet.cpp
trunk/Source/WebCore/xml/XPathParser.cpp
trunk/Source/WebCore/xml/XPathPath.cpp
trunk/Source/WebCore/xml/XPathPredicate.cpp
trunk/Source/WebCore/xml/XPathPredicate.h
trunk/Source/WebCore/xml/XPathResult.cpp
trunk/Source/WebCore/xml/XPathValue.cpp
trunk/Source/WebCore/xml/XPathVariableReference.cpp
trunk/Source/WebCore/xml/XSLImportRule.cpp
trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp
trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (161424 => 161425)
--- trunk/Source/WebCore/ChangeLog 2014-01-07 15:10:16 UTC (rev 161424)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 15:24:52 UTC (rev 161425)
@@ -1,3 +1,33 @@
+2014-01-07 László Langó
+
+Remove some extra includes from XML.
+https://bugs.webkit.org/show_bug.cgi?id=126572
+
+Reviewed by Anders Carlsson.
+
+No new tests, no functionality changed.
+
+* xml/XMLHttpRequest.cpp:
+* xml/XMLHttpRequestUpload.cpp:
+* xml/XMLHttpRequestUpload.h:
+* xml/XPathEvaluator.cpp:
+* xml/XPathExpression.cpp:
+* xml/XPathExpressionNode.cpp:
+* xml/XPathFunctions.cpp:
+* xml/XPathNodeSet.cpp:
+* xml/XPathParser.cpp:
+* xml/XPathPath.cpp:
+* xml/XPathPredicate.cpp:
+* xml/XPathPredicate.h:
+* xml/XPathResult.cpp:
+* xml/XPathValue.cpp:
+* xml/XPathVariableReference.cpp:
+* xml/XSLImportRule.cpp:
+* xml/XSLStyleSheetLibxslt.cpp:
+* xml/XSLTProcessorLibxslt.cpp:
+* xml/parser/XMLDocumentParser.cpp:
+* xml/parser/XMLDocumentParserLibxml2.cpp:
+
2014-01-07 Gyuyoung Kim
Add toHTMLTableSectionElement() functions, and use it
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (161424 => 161425)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-01-07 15:10:16 UTC (rev 161424)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2014-01-07 15:24:52 UTC (rev 161425)
@@ -31,8 +31,6 @@
#include "DOMImplementation.h"
#include "Event.h"
#include "EventException.h"
-#include "EventListener.h"
-#include "EventNames.h"
#include "ExceptionCode.h"
#include "File.h"
#include "HTMLDocument.h"
Modified: trunk/Source/WebCore/xml/XMLHttpRequestUpload.cpp (161424 => 161425)
--- trunk/Source/WebCore/xml/XMLHttpRequestUpload.cpp 2014-01-07 15:10:16 UTC (rev 161424)
+++ trunk/Source/WebCore/xml/XMLHttpRequestUpload.cpp 2014-01-07 15:24:52 UTC (rev 161425)
@@ -28,8 +28,6 @@
#include "Event.h"
#include "EventException.h"
-#include "EventNames.h"
-#include "XMLHttpRequest.h"
#include "XMLHttpRequestProgressEvent.h"
#include
#include
Modified: trunk/Source/WebCore/xml/XMLHttpRequestUpload.h (161424 => 161425)
--- trunk/Source/WebCore/xml/XMLHttpRequestUpload.h 2014-01-07 15:10:16 UTC (rev 161424)
+++ trunk/Source/WebCore/xml/XMLHttpRequestUpload.h 2014-01-07 15:24:52 UTC (rev 161425)
@@ -26,16 +26,11 @@
#ifndef XMLHttpRequestUpload_h
#define XMLHttpRequestUpload_h
-#include "EventListener.h"
-#include "EventNames.h"
-#include "EventTarget.h"
#include "XMLHttpRequest.h"
#include
#include
#include
#include
-#include
-#include
namespace WebCore {
Modified: trunk/Source/WebCore/xml/XPathEvaluator.cpp (161424 => 161425)
--- trunk/Source/WebCore/xml/XPathEvaluator.cpp 2014-01-07 15:10:16 UTC (rev 161424)
+++ trunk/Source/WebCore/xml/XPathEvaluator.cpp 2014-01-07 15:24:52 UTC (rev 161425)
@@ -29,7 +29,6 @@
#include "ExceptionCode.h"
#include "NativeXPathNSResolver.h"
-#include "Node.h"
#incl
[webkit-changes] [161426] trunk
Title: [161426] trunk
Revision 161426
Author g...@gnome.org
Date 2014-01-07 07:29:17 -0800 (Tue, 07 Jan 2014)
Log Message
Unreviewed GTK/CMake build fix: use the correct location for docs-build.stamp
in output and dependencies declarations, so docs are not built needlessly
every build.
Patch by Gustavo Noronha Silva on 2014-01-07
* Source/PlatformGTK.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/PlatformGTK.cmake
Diff
Modified: trunk/ChangeLog (161425 => 161426)
--- trunk/ChangeLog 2014-01-07 15:24:52 UTC (rev 161425)
+++ trunk/ChangeLog 2014-01-07 15:29:17 UTC (rev 161426)
@@ -1,3 +1,11 @@
+2014-01-07 Gustavo Noronha Silva
+
+Unreviewed GTK/CMake build fix: use the correct location for docs-build.stamp
+in output and dependencies declarations, so docs are not built needlessly
+every build.
+
+* Source/PlatformGTK.cmake:
+
2014-01-04 Carlos Garcia Campos
[GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
Modified: trunk/Source/PlatformGTK.cmake (161425 => 161426)
--- trunk/Source/PlatformGTK.cmake 2014-01-07 15:24:52 UTC (rev 161425)
+++ trunk/Source/PlatformGTK.cmake 2014-01-07 15:29:17 UTC (rev 161426)
@@ -30,7 +30,7 @@
endif ()
add_custom_command(
-OUTPUT docs-build.stamp
+OUTPUT "${CMAKE_BINARY_DIR}/docs-build.stamp"
DEPENDS ${DocumentationDependencies}
COMMAND CC="${CMAKE_C_COMPILER}" ${CMAKE_SOURCE_DIR}/Tools/gtk/generate-gtkdoc
COMMAND touch docs-build.stamp
@@ -38,7 +38,7 @@
)
add_custom_target(fake-docs-target ALL
-DEPENDS docs-build.stamp
+DEPENDS "${CMAKE_BINARY_DIR}/docs-build.stamp"
)
if (ENABLE_WEBKIT)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161423] trunk/Tools
Title: [161423] trunk/Tools
Revision 161423
Author o...@webkit.org
Date 2014-01-07 07:08:41 -0800 (Tue, 07 Jan 2014)
Log Message
Remove the WinCE buildbot from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=126517
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (161422 => 161423)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-07 15:00:29 UTC (rev 161422)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-01-07 15:08:41 UTC (rev 161423)
@@ -38,8 +38,6 @@
{ "name": "wincairo-1", "platform": "wincairo" },
-{ "name": "wince-1", "platform": "wince" },
-
{ "name": "efl-linux-slave-1", "platform": "efl" },
{ "name": "efl-linux-slave-2", "platform": "efl" },
{ "name": "efl-linux-slave-3", "platform": "efl" }
@@ -167,11 +165,6 @@
"slavenames": ["wincairo-1"]
},
{
- "name": "WinCE Release (Build)", "type": "Build", "builddir": "wince-release",
- "platform": "wince", "configuration": "release", "architectures": ["i386"],
- "slavenames": ["wince-1"]
-},
-{
"name": "EFL Linux 64-bit Release WK1", "type": "BuildAndTestWebKit1Only", "builddir": "efl-linux-64-release-wk1",
"platform": "efl", "configuration": "release", "architectures": ["x86_64"],
"slavenames": ["efl-linux-slave-1"]
@@ -191,7 +184,7 @@
"schedulers": [ { "type": "AnyBranchScheduler", "name": "trunk", "change_filter": "trunk_filter", "treeStableTimer": 45.0,
"builderNames": ["GTK Linux 32-bit Release", "GTK Linux 64-bit Release", "GTK Linux 64-bit Debug WK1",
"EFL Linux 64-bit Release WK1", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)",
- "WinCairo Release", "WinCE Release (Build)"]
+ "WinCairo Release"]
},
{ "type": "PlatformSpecificScheduler", "platform": "mac-mountainlion", "branch": "trunk", "treeStableTimer": 45.0,
"builderNames": ["Apple MountainLion Release (Build)", "Apple MountainLion Debug (Build)", "Apple MountainLion Release (32-bit Build)"]
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (161422 => 161423)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-07 15:00:29 UTC (rev 161422)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-01-07 15:08:41 UTC (rev 161423)
@@ -184,7 +184,7 @@
haltOnFailure = True
def appendCustomBuildFlags(step, platform, fullPlatform=""):
-if platform in ('efl', 'gtk', 'wincairo', 'wince', 'wx'):
+if platform in ('efl', 'gtk', 'wincairo', 'wx'):
step.setCommand(step.command + ['--' + platform])
class CompileWebKit(shell.Compile):
Modified: trunk/Tools/ChangeLog (161422 => 161423)
--- trunk/Tools/ChangeLog 2014-01-07 15:00:29 UTC (rev 161422)
+++ trunk/Tools/ChangeLog 2014-01-07 15:08:41 UTC (rev 161423)
@@ -1,3 +1,14 @@
+2014-01-07 Csaba Osztrogonác
+
+Remove the WinCE buildbot from build.webkit.org
+https://bugs.webkit.org/show_bug.cgi?id=126517
+
+Reviewed by Alexey Proskuryakov.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(appendCustomBuildFlags):
+
2014-01-07 Krzysztof Czech
[EFL] Change ATK version to 2.11.4
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161422] trunk/LayoutTests
Title: [161422] trunk/LayoutTests Revision 161422 Author r...@igalia.com Date 2014-01-07 07:00:29 -0800 (Tue, 07 Jan 2014) Log Message [GTK] fast/repaint/repaint-regions-overflow.html is failing https://bugs.webkit.org/show_bug.cgi?id=124835 Unreviewed gardening. Added new baseline for failing test. * platform/gtk/TestExpectations: Unskipped faling test. * platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/gtk/fast/regions/ trunk/LayoutTests/platform/gtk/fast/regions/repaint/ trunk/LayoutTests/platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (161421 => 161422) --- trunk/LayoutTests/ChangeLog 2014-01-07 14:55:49 UTC (rev 161421) +++ trunk/LayoutTests/ChangeLog 2014-01-07 15:00:29 UTC (rev 161422) @@ -1,3 +1,15 @@ +2014-01-07 Manuel Rego Casasnovas + +[GTK] fast/repaint/repaint-regions-overflow.html is failing +https://bugs.webkit.org/show_bug.cgi?id=124835 + +Unreviewed gardening. + +Added new baseline for failing test. + +* platform/gtk/TestExpectations: Unskipped faling test. +* platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt: Added. + 2014-01-07 Krzysztof Czech [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE Modified: trunk/LayoutTests/platform/gtk/TestExpectations (161421 => 161422) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-01-07 14:55:49 UTC (rev 161421) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-01-07 15:00:29 UTC (rev 161422) @@ -1522,8 +1522,6 @@ webkit.org/b/124834 fast/block/float/clear-negative-margin-top.html [ ImageOnlyFailure ] -webkit.org/b/124835 fast/regions/repaint/repaint-regions-overflow.html [ Failure ] - webkit.org/b/125071 fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html [ ImageOnlyFailure ] webkit.org/b/125348 accessibility/document-attributes.html [ Failure ] Added: trunk/LayoutTests/platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt (0 => 161422) --- trunk/LayoutTests/platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/fast/regions/repaint/repaint-regions-overflow-expected.txt 2014-01-07 15:00:29 UTC (rev 161422) @@ -0,0 +1,22 @@ +On success, no text should be clipped and you should see LAST LINE at the bottom of the text + +Above all, avoid lies, all lies, especially the lie to yourself. Keep watch on your own lie and examine it every hour, every minute. And avoid contempt, both of others and of yourself: what seems bad to you in yourself is purified by the very fact that you have noticed it in yourself. And avoid fear, though fear is simply the consequence of every lie. Never be frightened at your own faintheartedness in attaining love, and meanwhile do not even be very frightened by your own bad acts. + +LAST LINE + +(repaint rects + (rect 106 306 300 152) + (rect 14 71 300 203) + (rect 106 122 300 203) + (rect 14 290 300 17) + (rect 106 341 300 17) + (rect 14 55 300 252) + (rect 106 106 300 252) + (rect 60 150 312 258) + (rect 100 200 312 258) + (rect 14 55 300 252) + (rect 106 106 300 252) + (rect 14 55 300 252) + (rect 106 106 300 252) +) + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161419] trunk/Tools
Title: [161419] trunk/Tools
Revision 161419
Author be...@igalia.com
Date 2014-01-07 04:52:22 -0800 (Tue, 07 Jan 2014)
Log Message
[GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
https://bugs.webkit.org/show_bug.cgi?id=117275
Reviewed by Carlos Garcia Campos.
If we are not using the internal jhbuild we must not use the
jhbuild-wrapper script, else it will try to download and install
it.
* Scripts/run-launcher:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-launcher
Diff
Modified: trunk/Tools/ChangeLog (161418 => 161419)
--- trunk/Tools/ChangeLog 2014-01-07 11:59:46 UTC (rev 161418)
+++ trunk/Tools/ChangeLog 2014-01-07 12:52:22 UTC (rev 161419)
@@ -1,3 +1,16 @@
+2014-01-07 Alberto Garcia
+
+[GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
+https://bugs.webkit.org/show_bug.cgi?id=117275
+
+Reviewed by Carlos Garcia Campos.
+
+If we are not using the internal jhbuild we must not use the
+jhbuild-wrapper script, else it will try to download and install
+it.
+
+* Scripts/run-launcher:
+
2014-01-07 Krzysztof Czech
[ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
Modified: trunk/Tools/Scripts/run-launcher (161418 => 161419)
--- trunk/Tools/Scripts/run-launcher 2014-01-07 11:59:46 UTC (rev 161418)
+++ trunk/Tools/Scripts/run-launcher 2014-01-07 12:52:22 UTC (rev 161419)
@@ -38,7 +38,8 @@
setConfiguration();
my $productDir = productDir();
-my $launcherPath = productDir();
+my $launcherPath;
+my @jhbuildWrapper;
# Check to see that all the frameworks are built.
checkFrameworks();
@@ -46,25 +47,25 @@
# Set paths according to the build system used
if (isGtk()) {
if (isWK2()) {
-unshift(@ARGV, catdir($launcherPath, "Programs", "MiniBrowser"));
+$launcherPath = catdir($productDir, "Programs", "MiniBrowser");
} else {
-unshift(@ARGV, catdir($launcherPath, "Programs", "GtkLauncher"));
+$launcherPath = catdir($productDir, "Programs", "GtkLauncher");
}
-$launcherPath = catdir(sourceDir(), "Tools", "jhbuild", "jhbuild-wrapper");
-unshift(@ARGV, ("--gtk", "run"));
}
if (isEfl()) {
if (isWK2()) {
-unshift(@ARGV, catdir($launcherPath, "bin", "MiniBrowser"));
+$launcherPath = catdir($productDir, "bin", "MiniBrowser");
} else {
-unshift(@ARGV, catdir($launcherPath, "bin", "EWebLauncher"));
+$launcherPath = catdir($productDir, "bin", "EWebLauncher");
}
-$launcherPath = catdir(sourceDir(), "Tools", "jhbuild", "jhbuild-wrapper");
-unshift(@ARGV, ("--efl", "run"));
}
+$launcherPath && -x $launcherPath or die "Can't find the launcher command";
+
+@jhbuildWrapper = jhbuildWrapperPrefixIfNeeded();
+
print "Starting webkit launcher.\n";
-exec $launcherPath, @ARGV or die;
+exec @jhbuildWrapper, $launcherPath, @ARGV or die;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161416] trunk/Source/WebKit2
Title: [161416] trunk/Source/WebKit2
Revision 161416
Author carlo...@webkit.org
Date 2014-01-07 02:06:16 -0800 (Tue, 07 Jan 2014)
Log Message
Crash when trying to register a custom scheme before network process has been launched
https://bugs.webkit.org/show_bug.cgi?id=126385
Reviewed by Anders Carlsson.
WebContext::registerSchemeForCustomProtocol() uses
sendToNetworkingProcess() to send the message to the appropriate
networking process. In the case of using web process,
sendToNetworkingProcess() first checks if there's already a web
process, doing nothing otherwise, but when using the network
process it assumes there's already a network process. In both
cases it's safe to do nothing, because the schemes will be passed
as creation parameters to the process when launched.
* UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (161415 => 161416)
--- trunk/Source/WebKit2/ChangeLog 2014-01-07 09:46:36 UTC (rev 161415)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-07 10:06:16 UTC (rev 161416)
@@ -1,3 +1,22 @@
+2014-01-07 Carlos Garcia Campos
+
+Crash when trying to register a custom scheme before network process has been launched
+https://bugs.webkit.org/show_bug.cgi?id=126385
+
+Reviewed by Anders Carlsson.
+
+WebContext::registerSchemeForCustomProtocol() uses
+sendToNetworkingProcess() to send the message to the appropriate
+networking process. In the case of using web process,
+sendToNetworkingProcess() first checks if there's already a web
+process, doing nothing otherwise, but when using the network
+process it assumes there's already a network process. In both
+cases it's safe to do nothing, because the schemes will be passed
+as creation parameters to the process when launched.
+
+* UIProcess/WebContext.h:
+(WebKit::WebContext::sendToNetworkingProcess):
+
2014-01-07 Jinwoo Song
WebKit2 EFL build fix after r161387
Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (161415 => 161416)
--- trunk/Source/WebKit2/UIProcess/WebContext.h 2014-01-07 09:46:36 UTC (rev 161415)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2014-01-07 10:06:16 UTC (rev 161416)
@@ -512,7 +512,7 @@
case ProcessModelSharedSecondaryProcess:
#if ENABLE(NETWORK_PROCESS)
if (m_usesNetworkProcess) {
-if (m_networkProcess->canSendMessage())
+if (m_networkProcess && m_networkProcess->canSendMessage())
m_networkProcess->send(std::forward(message), 0);
return;
}
@@ -522,7 +522,7 @@
return;
case ProcessModelMultipleSecondaryProcesses:
#if ENABLE(NETWORK_PROCESS)
-if (m_networkProcess->canSendMessage())
+if (m_networkProcess && m_networkProcess->canSendMessage())
m_networkProcess->send(std::forward(message), 0);
return;
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161415] trunk/Source
Title: [161415] trunk/Source
Revision 161415
Author mr...@apple.com
Date 2014-01-07 01:46:36 -0800 (Tue, 07 Jan 2014)
Log Message
DOMProgressEvent has unspecified availability
Reviewed by Ryosuke Niwa.
Source/WebCore:
* bindings/objc/PublicDOMInterfaces.h: Add DOMProgressEvent. It first appeared in 10.6.
Source/WebKit/mac:
* MigrateHeaders.make: Ensure that public DOM headers do not have unspecified availability.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/MigrateHeaders.make
Diff
Modified: trunk/Source/WebCore/ChangeLog (161414 => 161415)
--- trunk/Source/WebCore/ChangeLog 2014-01-07 09:42:26 UTC (rev 161414)
+++ trunk/Source/WebCore/ChangeLog 2014-01-07 09:46:36 UTC (rev 161415)
@@ -1,5 +1,13 @@
2014-01-07 Mark Rowe
+ DOMProgressEvent has unspecified availability
+
+Reviewed by Ryosuke Niwa.
+
+* bindings/objc/PublicDOMInterfaces.h: Add DOMProgressEvent. It first appeared in 10.6.
+
+2014-01-07 Mark Rowe
+
Another Mountain Lion build fix.
The Mountain Lion version of NS_DEPRECATED_MAC generates a reference to a nonexistent
Modified: trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h (161414 => 161415)
--- trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h 2014-01-07 09:42:26 UTC (rev 161414)
+++ trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h 2014-01-07 09:46:36 UTC (rev 161415)
@@ -1216,6 +1216,12 @@
- (DOMXPathResult *)evaluate:(DOMNode *)contextNode :(unsigned short)type :(DOMXPathResult *)inResult WEBKIT_DEPRECATED_MAC(10_5, 10_5);
@end
+@interface DOMProgressEvent : DOMEvent 10_6
+@property (readonly) BOOL lengthComputable;
+@property (readonly) unsigned long long loaded;
+@property (readonly) unsigned long long total;
+@end
+
// Protocols
@protocol DOMEventListener 10_4
Modified: trunk/Source/WebKit/mac/ChangeLog (161414 => 161415)
--- trunk/Source/WebKit/mac/ChangeLog 2014-01-07 09:42:26 UTC (rev 161414)
+++ trunk/Source/WebKit/mac/ChangeLog 2014-01-07 09:46:36 UTC (rev 161415)
@@ -1,3 +1,11 @@
+2014-01-07 Mark Rowe
+
+ DOMProgressEvent has unspecified availability
+
+Reviewed by Ryosuke Niwa.
+
+* MigrateHeaders.make: Ensure that public DOM headers do not have unspecified availability.
+
2014-01-06 Mark Rowe
Mountain Lion build fix after r161332.
Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (161414 => 161415)
--- trunk/Source/WebKit/mac/MigrateHeaders.make 2014-01-07 09:42:26 UTC (rev 161414)
+++ trunk/Source/WebKit/mac/MigrateHeaders.make 2014-01-07 09:46:36 UTC (rev 161415)
@@ -192,14 +192,17 @@
REPLACE_RULES = -e s/\ HEADER_MIGRATE_CMD = sed $(REPLACE_RULES) $< > $@
+PUBLIC_HEADER_CHECK_CMD = @if grep -q "AVAILABLE.*TBD" "$<"; then line=$$(awk "/AVAILABLE.*TBD/ { print FNR; exit }" "$<" ); echo "$<:$$line: error: A class within a public header has unspecified availability."; false; fi
$(PUBLIC_HEADERS_DIR)/DOM% : DOMDOM% MigrateHeaders.make
+ $(PUBLIC_HEADER_CHECK_CMD)
$(HEADER_MIGRATE_CMD)
$(PRIVATE_HEADERS_DIR)/DOM% : DOMDOM% MigrateHeaders.make
$(HEADER_MIGRATE_CMD)
$(PUBLIC_HEADERS_DIR)/% : % MigrateHeaders.make
+ $(PUBLIC_HEADER_CHECK_CMD)
$(HEADER_MIGRATE_CMD)
$(PRIVATE_HEADERS_DIR)/% : % MigrateHeaders.make
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161414] trunk/Source/JavaScriptCore
Title: [161414] trunk/Source/_javascript_Core Revision 161414 Author mr...@apple.com Date 2014-01-07 01:42:26 -0800 (Tue, 07 Jan 2014) Log Message Remove the legacy WebKit availability macros They're no longer used. Reviewed by Ryosuke Niwa. * API/WebKitAvailability.h: Modified Paths trunk/Source/_javascript_Core/API/WebKitAvailability.h trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/WebKitAvailability.h (161413 => 161414) --- trunk/Source/_javascript_Core/API/WebKitAvailability.h 2014-01-07 09:36:46 UTC (rev 161413) +++ trunk/Source/_javascript_Core/API/WebKitAvailability.h 2014-01-07 09:42:26 UTC (rev 161414) @@ -1,5 +1,5 @@ /* - * Copyright (C) 2008, 2009, 2010 Apple Inc. All Rights Reserved. + * Copyright (C) 2008, 2009, 2010, 2014 Apple Inc. All Rights Reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -26,900 +26,11 @@ #ifndef __WebKitAvailability__ #define __WebKitAvailability__ -/* The structure of this header is based on AvailabilityMacros.h. The major difference is that the availability - macros are defined in terms of WebKit version numbers rather than Mac OS X system version numbers, as WebKit - releases span multiple versions of Mac OS X. -*/ - -#define WEBKIT_VERSION_1_00x0100 -#define WEBKIT_VERSION_1_10x0110 -#define WEBKIT_VERSION_1_20x0120 -#define WEBKIT_VERSION_1_30x0130 -#define WEBKIT_VERSION_2_00x0200 -#define WEBKIT_VERSION_3_00x0300 -#define WEBKIT_VERSION_3_10x0310 -#define WEBKIT_VERSION_4_00x0400 -#define WEBKIT_VERSION_LATEST 0x - #ifdef __APPLE__ #include #include #else #define CF_AVAILABLE(_mac, _ios) -/* - * For non-Mac platforms, require the newest version. - */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_LATEST -/* - * only certain compilers support __attribute__((deprecated)) - */ -#if defined(__GNUC__) && ((__GNUC__ >= 4) || ((__GNUC__ == 3) && (__GNUC_MINOR__ >= 1))) -#define DEPRECATED_ATTRIBUTE __attribute__((deprecated)) -#else -#define DEPRECATED_ATTRIBUTE #endif -#endif -/* The versions of GCC that shipped with Xcode prior to 3.0 (GCC build number < 5400) did not support attributes on methods. - If we are building with one of these versions, we need to omit the attribute. We achieve this by wrapping the annotation - in WEBKIT_OBJC_METHOD_ANNOTATION, which will remove the annotation when an old version of GCC is in use and will otherwise - expand to the annotation. The same is needed for protocol methods. -*/ -#if defined(__APPLE_CC__) && __APPLE_CC__ < 5400 -#define WEBKIT_OBJC_METHOD_ANNOTATION(ANNOTATION) -#else -#define WEBKIT_OBJC_METHOD_ANNOTATION(ANNOTATION) ANNOTATION -#endif - - -/* If minimum WebKit version is not specified, assume the version that shipped with the target Mac OS X version */ -#ifndef WEBKIT_VERSION_MIN_REQUIRED -#if !defined(MAC_OS_X_VERSION_10_2) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_2 -#error WebKit was not available prior to Mac OS X 10.2 -#elif !defined(MAC_OS_X_VERSION_10_3) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_3 -/* WebKit 1.0 is the only version available on Mac OS X 10.2. */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_1_0 -#elif !defined(MAC_OS_X_VERSION_10_4) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4 -/* WebKit 1.1 is the version that shipped on Mac OS X 10.3. */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_1_1 -#elif !defined(MAC_OS_X_VERSION_10_5) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5 -/* WebKit 2.0 is the version that shipped on Mac OS X 10.4. */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_2_0 -#elif !defined(MAC_OS_X_VERSION_10_6) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_6 -/* WebKit 3.0 is the version that shipped on Mac OS X 10.5. */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_3_0 -#elif !defined(MAC_OS_X_VERSION_10_7) || MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_7 -/* WebKit 4.0 is the version that shipped on Mac OS X 10.6. */ -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_4_0 -#else -#define WEBKIT_VERSION_MIN_REQUIRED WEBKIT_VERSION_LATEST -#endif -#endif - - -/* If maximum WebKit version is not specified, assume largerof(latest, minimum) */ -#ifndef WEBKIT_VERSION_MAX_ALLOWED -#if WEBKIT_VERSION_MIN_REQUIRED > WEBKIT_VERSION_LATEST -#define WEBKIT_VERSION_MAX_ALLOWED WEBKIT_VERSION_MIN_REQUIRED -#else -#define WEBKIT_VERSION_MAX_ALLOWED WEBKIT_VERSION_LATEST -#endif -#endif - - -/* Sanity check the configured values */ -#if WEBKIT_VERSION_MAX_ALLOWED < WEBKIT_VERSION_MIN_REQUIRED -#error WEBKIT_VERSION_MAX_ALLOWED must be >= WEBKIT_VERSION_MIN_REQUIRED -#endif -#if WEBKIT_VERSION_MIN
[webkit-changes] [161412] trunk/Source/WebCore
Title: [161412] trunk/Source/WebCore Revision 161412 Author mr...@apple.com Date 2014-01-07 00:46:53 -0800 (Tue, 07 Jan 2014) Log Message Another Mountain Lion build fix. The Mountain Lion version of NS_DEPRECATED_MAC generates a reference to a nonexistent availability macro when the introduced and deprecated versions are the same. Follow AppKit's lead in working around this by defining the macros that will be referenced for the various possible OS version numbers. This isn't an issue on newer versions of OS X as the Foundation availability macros expand directly in to __attributes__ rather than in to the legacy availability maros. * bindings/objc/WebKitAvailability.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/objc/WebKitAvailability.h Diff Modified: trunk/Source/WebCore/ChangeLog (161411 => 161412) --- trunk/Source/WebCore/ChangeLog 2014-01-07 08:22:04 UTC (rev 161411) +++ trunk/Source/WebCore/ChangeLog 2014-01-07 08:46:53 UTC (rev 161412) @@ -1,3 +1,16 @@ +2014-01-07 Mark Rowe + +Another Mountain Lion build fix. + +The Mountain Lion version of NS_DEPRECATED_MAC generates a reference to a nonexistent +availability macro when the introduced and deprecated versions are the same. Follow +AppKit's lead in working around this by defining the macros that will be referenced +for the various possible OS version numbers. This isn't an issue on newer versions of +OS X as the Foundation availability macros expand directly in to __attributes__ rather +than in to the legacy availability maros. + +* bindings/objc/WebKitAvailability.h: + 2014-01-06 Mark Rowe Mountain Lion build fix. Modified: trunk/Source/WebCore/bindings/objc/WebKitAvailability.h (161411 => 161412) --- trunk/Source/WebCore/bindings/objc/WebKitAvailability.h 2014-01-07 08:22:04 UTC (rev 161411) +++ trunk/Source/WebCore/bindings/objc/WebKitAvailability.h 2014-01-07 08:46:53 UTC (rev 161412) @@ -38,6 +38,17 @@ #define __AVAILABILITY_INTERNAL__MAC_TBD __attribute__((availability(macosx,introduced=9876.5))) +#ifndef AVAILABLE_MAC_OS_X_VERSION_10_0_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_0 +#define AVAILABLE_MAC_OS_X_VERSION_10_0_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_0 DEPRECATED_IN_MAC_OS_X_VERSION_10_0_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_1_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_1 DEPRECATED_IN_MAC_OS_X_VERSION_10_1_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_2_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_2 DEPRECATED_IN_MAC_OS_X_VERSION_10_2_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_3_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_3 DEPRECATED_IN_MAC_OS_X_VERSION_10_3_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_4_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_4 DEPRECATED_IN_MAC_OS_X_VERSION_10_4_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_5_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_5 DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_6_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_6 DEPRECATED_IN_MAC_OS_X_VERSION_10_6_AND_LATER +#define AVAILABLE_MAC_OS_X_VERSION_10_7_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_X_VERSION_10_7 DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER +#endif + #else #define WEBKIT_AVAILABLE_MAC(introduced) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [161411] trunk/Source/JavaScriptCore
Title: [161411] trunk/Source/_javascript_Core
Revision 161411
Author fpi...@apple.com
Date 2014-01-07 00:22:04 -0800 (Tue, 07 Jan 2014)
Log Message
SetLocal for a FlushedArguments should not claim that the dataFormat is DataFormatJS
https://bugs.webkit.org/show_bug.cgi?id=126563
Reviewed by Gavin Barraclough.
This was a rookie arguments simplification mistake: the SetLocal needs to record the fact
that although it set JSValue(), OSR should think it set Arguments. DataFormatArguments
conveys this, and dataFormatFor(FlushFormat) will do the right thing.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
(foo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (161410 => 161411)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-07 07:26:58 UTC (rev 161410)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-07 08:22:04 UTC (rev 161411)
@@ -1,3 +1,21 @@
+2014-01-07 Filip Pizlo
+
+SetLocal for a FlushedArguments should not claim that the dataFormat is DataFormatJS
+https://bugs.webkit.org/show_bug.cgi?id=126563
+
+Reviewed by Gavin Barraclough.
+
+This was a rookie arguments simplification mistake: the SetLocal needs to record the fact
+that although it set JSValue(), OSR should think it set Arguments. DataFormatArguments
+conveys this, and dataFormatFor(FlushFormat) will do the right thing.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js: Added.
+(foo):
+
2014-01-06 Filip Pizlo
Make the different flavors of integer arithmetic more explicit, and don't rely on (possibly stale) results of the backwards propagator to decide integer arithmetic semantics
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (161410 => 161411)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2014-01-07 07:26:58 UTC (rev 161410)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2014-01-07 08:22:04 UTC (rev 161411)
@@ -1958,7 +1958,7 @@
m_jit.store32(value.payloadGPR(), JITCompiler::payloadFor(node->machineLocal()));
m_jit.store32(value.tagGPR(), JITCompiler::tagFor(node->machineLocal()));
noResult(node);
-recordSetLocal(DataFormatJS);
+recordSetLocal(dataFormatFor(node->variableAccessData()->flushFormat()));
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (161410 => 161411)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-07 07:26:58 UTC (rev 161410)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-07 08:22:04 UTC (rev 161411)
@@ -2275,7 +2275,7 @@
JSValueOperand value(this, node->child1());
m_jit.store64(value.gpr(), JITCompiler::addressFor(node->machineLocal()));
noResult(node);
-recordSetLocal(DataFormatJS);
+recordSetLocal(dataFormatFor(node->variableAccessData()->flushFormat()));
break;
}
Added: trunk/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js (0 => 161411)
--- trunk/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/phantom-arguments-set-local-then-exit-in-same-block.js 2014-01-07 08:22:04 UTC (rev 161411)
@@ -0,0 +1,17 @@
+function foo(o) {
+var a = arguments;
+var result = o.f;
+for (var i = 1; i < a.length; ++i)
+result += a[i];
+return result;
+}
+
+noInline(foo);
+
+for (var i = 0; i < 100; ++i)
+foo({f:42}, 1, 2, 3);
+
+var result = foo({g:40, f:41}, 1, 2.5, 3);
+if (result != 47.5)
+throw "Bad result: " + result;
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
