[webkit-changes] [163008] trunk/Source/WebKit2
Title: [163008] trunk/Source/WebKit2
Revision 163008
Author zandober...@gmail.com
Date 2014-01-28 23:58:33 -0800 (Tue, 28 Jan 2014)
Log Message
Unreviewed followup to r163006. That change incorrectly modified
webkit_web_view_go_forward when webkit_web_view_can_go_forward needed fixing.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163007 => 163008)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 07:52:03 UTC (rev 163007)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 07:58:33 UTC (rev 163008)
@@ -1,5 +1,14 @@
2014-01-28 Zan Dobersek
+Unreviewed followup to r163006. That change incorrectly modified
+webkit_web_view_go_forward when webkit_web_view_can_go_forward needed fixing.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_go_forward):
+(webkit_web_view_can_go_forward):
+
+2014-01-28 Zan Dobersek
+
Unreviewed GTK build fix after r162967.
* UIProcess/API/gtk/WebKitWebView.cpp:
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (163007 => 163008)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-01-29 07:52:03 UTC (rev 163007)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-01-29 07:58:33 UTC (rev 163008)
@@ -2171,7 +2171,7 @@
{
g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
-getPage(webView)->backForwardList().forwardItem();
+getPage(webView)->goForward();
}
/**
@@ -2186,7 +2186,7 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
-return getPage(webView)->canGoForward();
+return getPage(webView)->backForwardList().forwardItem();
}
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163007] trunk/LayoutTests
Title: [163007] trunk/LayoutTests
Revision 163007
Author mmaxfi...@apple.com
Date 2014-01-28 23:52:03 -0800 (Tue, 28 Jan 2014)
Log Message
Rebaseline quote-text-around-iframe.html after r162972
https://bugs.webkit.org/show_bug.cgi?id=127822
Reviewed by Alexey Proskuryakov.
Forgot to rebaseline fast/table/quote-text-around-iframe.html
* platform/mac/fast/table/quote-text-around-iframe-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/table/quote-text-around-iframe-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (163006 => 163007)
--- trunk/LayoutTests/ChangeLog 2014-01-29 07:21:14 UTC (rev 163006)
+++ trunk/LayoutTests/ChangeLog 2014-01-29 07:52:03 UTC (rev 163007)
@@ -1,3 +1,14 @@
+2014-01-28 Myles C. Maxfield
+
+Rebaseline quote-text-around-iframe.html after r162972
+https://bugs.webkit.org/show_bug.cgi?id=127822
+
+Reviewed by Alexey Proskuryakov.
+
+Forgot to rebaseline fast/table/quote-text-around-iframe.html
+
+* platform/mac/fast/table/quote-text-around-iframe-expected.txt:
+
2014-01-28 Jinwoo Song
Unreviewed EFL gardening after r162972.
Modified: trunk/LayoutTests/platform/mac/fast/table/quote-text-around-iframe-expected.txt (163006 => 163007)
--- trunk/LayoutTests/platform/mac/fast/table/quote-text-around-iframe-expected.txt 2014-01-29 07:21:14 UTC (rev 163006)
+++ trunk/LayoutTests/platform/mac/fast/table/quote-text-around-iframe-expected.txt 2014-01-29 07:52:03 UTC (rev 163007)
@@ -8,8 +8,9 @@
RenderTableRow {Q} at (0,0) size 694x316
RenderTableCell (anonymous) at (0,0) size 694x316 [r=0 c=0 rs=1 cs=1]
RenderInline (generated) at (0,0) size 13x37
-RenderQuote at (0,279) size 13x37
- text run at (0,279) width 13: "\""
+RenderQuote at (0,0) size 13x37
+ RenderText at (0,279) size 13x37
+text run at (0,279) width 13: "\""
RenderText {#text} at (13,279) size 31x37
text run at (13,279) width 31: " A"
RenderIFrame {IFRAME} at (44,0) size 608x308 [border: (4px inset #00)]
@@ -21,5 +22,6 @@
RenderText {#text} at (652,279) size 29x37
text run at (652,279) width 29: "B "
RenderInline (generated) at (0,0) size 13x37
-RenderQuote at (681,279) size 13x37
- text run at (681,279) width 13: "\""
+RenderQuote at (0,0) size 13x37
+ RenderText at (681,279) size 13x37
+text run at (681,279) width 13: "\""
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163006] trunk/Source/WebKit2
Title: [163006] trunk/Source/WebKit2
Revision 163006
Author zandober...@gmail.com
Date 2014-01-28 23:21:14 -0800 (Tue, 28 Jan 2014)
Log Message
Unreviewed GTK build fix after r162967.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163005 => 163006)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 06:42:29 UTC (rev 163005)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 07:21:14 UTC (rev 163006)
@@ -1,3 +1,11 @@
+2014-01-28 Zan Dobersek
+
+Unreviewed GTK build fix after r162967.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_can_go_back):
+(webkit_web_view_go_forward):
+
2014-01-28 Tim Horton
Crashes in ViewGestureController::wheelEventWasNotHandledByWebCore
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (163005 => 163006)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-01-29 06:42:29 UTC (rev 163005)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-01-29 07:21:14 UTC (rev 163006)
@@ -2156,7 +2156,7 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
-return getPage(webView)->canGoBack();
+return getPage(webView)->backForwardList().backItem();
}
/**
@@ -2171,7 +2171,7 @@
{
g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
-getPage(webView)->goForward();
+getPage(webView)->backForwardList().forwardItem();
}
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163004] branches/jsCStack/Source/JavaScriptCore
Title: [163004] branches/jsCStack/Source/_javascript_Core
Revision 163004
Author fpi...@apple.com
Date 2014-01-28 22:29:22 -0800 (Tue, 28 Jan 2014)
Log Message
FTL should support ArrayPop
https://bugs.webkit.org/show_bug.cgi?id=127749
Reviewed by Geoffrey Garen.
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
* tests/stress/array-pop-contiguous.js: Added.
(foo):
* tests/stress/array-pop-double.js: Added.
(foo):
* tests/stress/array-pop-int32.js: Added.
(foo):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp
branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h
branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
branches/jsCStack/Source/_javascript_Core/tests/stress/array-pop-contiguous.js
branches/jsCStack/Source/_javascript_Core/tests/stress/array-pop-double.js
branches/jsCStack/Source/_javascript_Core/tests/stress/array-pop-int32.js
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (163003 => 163004)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-29 06:12:19 UTC (rev 163003)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-29 06:29:22 UTC (rev 163004)
@@ -1,5 +1,26 @@
2014-01-28 Filip Pizlo
+FTL should support ArrayPop
+https://bugs.webkit.org/show_bug.cgi?id=127749
+
+Reviewed by Geoffrey Garen.
+
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLIntrinsicRepository.h:
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileNode):
+(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
+(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
+* tests/stress/array-pop-contiguous.js: Added.
+(foo):
+* tests/stress/array-pop-double.js: Added.
+(foo):
+* tests/stress/array-pop-int32.js: Added.
+(foo):
+
+2014-01-28 Filip Pizlo
+
DFG ArrayPop double array mishandles the NaN hole installation
https://bugs.webkit.org/show_bug.cgi?id=127813
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp (163003 => 163004)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-29 06:12:19 UTC (rev 163003)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-29 06:29:22 UTC (rev 163004)
@@ -202,6 +202,7 @@
}
break;
case ArrayPush:
+case ArrayPop:
switch (node->arrayMode().type()) {
case Array::Int32:
case Array::Contiguous:
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h (163003 => 163004)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-29 06:12:19 UTC (rev 163003)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-29 06:29:22 UTC (rev 163004)
@@ -62,6 +62,7 @@
macro(C_JITOperation_ESt, functionType(intPtr, intPtr, intPtr)) \
macro(I_JITOperation_EJss, functionType(intPtr, intPtr, intPtr)) \
macro(J_JITOperation_E, functionType(int64, intPtr)) \
+macro(J_JITOperation_EA, functionType(int64, intPtr, intPtr)) \
macro(J_JITOperation_EAZ, functionType(int64, intPtr, intPtr, int32)) \
macro(J_JITOperation_EDA, functionType(int64, intPtr, doubleType, intPtr)) \
macro(J_JITOperation_EJA, functionType(int64, intPtr, int64, intPtr)) \
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (163003 => 163004)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-29 06:12:19 UTC (rev 163003)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-29 06:29:22 UTC (rev 163004)
@@ -419,6 +419,9 @@
case ArrayPush:
compileArrayPush();
break;
+case ArrayPop:
+compileArrayPop();
+break;
case NewObject:
compileNewObject();
break;
@@ -2215,9 +2218,9 @@
LValue prevLength = m_out.load32(storage, m_heaps.Butterfly_publicLength);
-LBasicBlock fastPath = FTL_NEW_BLOCK(m_out, ("ArrayPush int32/contiguous fast path"));
-LBasicBlock slowPath = FTL_NEW_BLOCK(m_out, ("ArrayPush int32/contiguous slow path"));
-LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("ArrayPush int32/contiguous continuation"));
+LBasicBlock fastPath = FTL_NEW_BLOCK(m_out, ("ArrayPush fast path"));
+LBasicBlock slowPath = FTL_NEW_BLOCK(m_out, ("ArrayPush slow path"));
+LBasicBlock continuation = FTL_NEW_BLOCK(m_out, ("ArrayPush continuation"));
m_out.branch(
m
[webkit-changes] [163003] trunk/Source/WebKit2
Title: [163003] trunk/Source/WebKit2
Revision 163003
Author timothy_hor...@apple.com
Date 2014-01-28 22:12:19 -0800 (Tue, 28 Jan 2014)
Log Message
Crashes in ViewGestureController::wheelEventWasNotHandledByWebCore
https://bugs.webkit.org/show_bug.cgi?id=127828
Reviewed by Dan Bernstein.
* UIProcess/API/mac/WKView.mm:
(-[WKView _wheelEventWasNotHandledByWebCore:]):
Null check. ViewGestureController only needs unhandled wheel events after it has been created.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163002 => 163003)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 06:03:52 UTC (rev 163002)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 06:12:19 UTC (rev 163003)
@@ -1,5 +1,17 @@
2014-01-28 Tim Horton
+Crashes in ViewGestureController::wheelEventWasNotHandledByWebCore
+https://bugs.webkit.org/show_bug.cgi?id=127828
+
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _wheelEventWasNotHandledByWebCore:]):
+Null check. ViewGestureController only needs unhandled wheel events after it has been created.
+
+2014-01-28 Tim Horton
+
Fix the Mountain Lion build if you have private headers.
* UIProcess/mac/ViewGestureController.mm:
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (163002 => 163003)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-29 06:03:52 UTC (rev 163002)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-29 06:12:19 UTC (rev 163003)
@@ -2566,7 +2566,8 @@
- (void)_wheelEventWasNotHandledByWebCore:(NSEvent *)event
{
-_data->_gestureController->wheelEventWasNotHandledByWebCore(event);
+if (_data->_gestureController)
+_data->_gestureController->wheelEventWasNotHandledByWebCore(event);
}
- (void)_setAccessibilityWebProcessToken:(NSData *)data
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163002] trunk/Source/WebKit2
Title: [163002] trunk/Source/WebKit2
Revision 163002
Author timothy_hor...@apple.com
Date 2014-01-28 22:03:52 -0800 (Tue, 28 Jan 2014)
Log Message
Fix the Mountain Lion build if you have private headers.
* UIProcess/mac/ViewGestureController.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163001 => 163002)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 05:22:38 UTC (rev 163001)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 06:03:52 UTC (rev 163002)
@@ -1,3 +1,10 @@
+2014-01-28 Tim Horton
+
+Fix the Mountain Lion build if you have private headers.
+
+* UIProcess/mac/ViewGestureController.mm:
+(WebKit::ViewGestureController::beginSwipeGesture):
+
2014-01-28 Ian Henderson
[iOS] UI process crashes whenever web process crashes
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm (163001 => 163002)
--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-29 05:22:38 UTC (rev 163001)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-29 06:03:52 UTC (rev 163002)
@@ -322,13 +322,15 @@
RetainPtr snapshot = ViewSnapshotStore::shared().snapshotAndRenderTreeSize(targetItem).first;
if (snapshot) {
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
uint32_t purgeabilityState = kIOSurfacePurgeableNonVolatile;
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
IOSurfaceSetPurgeable(snapshot.get(), kIOSurfacePurgeableNonVolatile, &purgeabilityState);
-#endif
if (purgeabilityState != kIOSurfacePurgeableEmpty)
[m_swipeSnapshotLayer setContents:(id)snapshot.get()];
+#else
+[m_swipeSnapshotLayer setContents:(id)snapshot.get()];
+#endif
}
[m_swipeSnapshotLayer setContentsGravity:kCAGravityTopLeft];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163001] trunk/Source/WebKit2
Title: [163001] trunk/Source/WebKit2
Revision 163001
Author commit-qu...@webkit.org
Date 2014-01-28 21:22:38 -0800 (Tue, 28 Jan 2014)
Log Message
[iOS] UI process crashes whenever web process crashes
https://bugs.webkit.org/show_bug.cgi?id=127826
Patch by Ian Henderson on 2014-01-28
Reviewed by Tim Horton.
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _updateFixedPositionRect]): Null-check the drawing
area before calling size() on it.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (163000 => 163001)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 05:14:06 UTC (rev 163000)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 05:22:38 UTC (rev 163001)
@@ -1,5 +1,16 @@
2014-01-28 Ian Henderson
+[iOS] UI process crashes whenever web process crashes
+https://bugs.webkit.org/show_bug.cgi?id=127826
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/ios/WKContentView.mm:
+(-[WKContentView _updateFixedPositionRect]): Null-check the drawing
+area before calling size() on it.
+
+2014-01-28 Ian Henderson
+
WKRemoteObjectCoder should support more argument types
https://bugs.webkit.org/show_bug.cgi?id=127824
Modified: trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm (163000 => 163001)
--- trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-29 05:14:06 UTC (rev 163000)
+++ trunk/Source/WebKit2/UIProcess/API/ios/WKContentView.mm 2014-01-29 05:22:38 UTC (rev 163001)
@@ -195,11 +195,12 @@
- (void)_updateFixedPositionRect
{
-FloatRect exposedRect(_currentExposedRectPosition, _page->drawingArea()->size());
+auto drawingArea = _page->drawingArea();
+if (!drawingArea)
+return;
+FloatRect exposedRect(_currentExposedRectPosition, drawingArea->size());
FloatRect fixedPosRect = [self fixedPositionRectFromExposedRect:exposedRect scale:_page->pageScaleFactor()];
-
-if (auto drawingArea = _page->drawingArea())
-drawingArea->setCustomFixedPositionRect(fixedPosRect);
+drawingArea->setCustomFixedPositionRect(fixedPosRect);
}
- (void)setViewportSize:(CGSize)size
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [163000] trunk/Source/WebKit2
Title: [163000] trunk/Source/WebKit2
Revision 163000
Author commit-qu...@webkit.org
Date 2014-01-28 21:14:06 -0800 (Tue, 28 Jan 2014)
Log Message
WKRemoteObjectCoder should support more argument types
https://bugs.webkit.org/show_bug.cgi?id=127824
Patch by Ian Henderson on 2014-01-28
Reviewed by Anders Carlsson.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation): Support encoding char values.
(decodeInvocationArguments): Support decoding char values.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162999 => 163000)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 04:44:56 UTC (rev 162999)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 05:14:06 UTC (rev 163000)
@@ -1,3 +1,14 @@
+2014-01-28 Ian Henderson
+
+WKRemoteObjectCoder should support more argument types
+https://bugs.webkit.org/show_bug.cgi?id=127824
+
+Reviewed by Anders Carlsson.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(encodeInvocation): Support encoding char values.
+(decodeInvocationArguments): Support decoding char values.
+
2014-01-28 Ryuan Choi
Unreviewed build fix on the cmake based port after r162981
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm (162999 => 163000)
--- trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-01-29 04:44:56 UTC (rev 162999)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm 2014-01-29 05:14:06 UTC (rev 163000)
@@ -146,6 +146,15 @@
break;
}
+// char
+case 'c': {
+char value;
+[invocation getArgument:&value atIndex:i];
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
// bool
case 'B': {
BOOL value;
@@ -403,6 +412,13 @@
break;
}
+// char
+case 'c': {
+char value = [decodeObjectFromObjectStream(decoder, [NSSet setWithObject:[NSNumber class]]) charValue];
+[invocation setArgument:&value atIndex:i];
+break;
+}
+
// bool
case 'B': {
bool value = [decodeObjectFromObjectStream(decoder, [NSSet setWithObject:[NSNumber class]]) boolValue];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162999] trunk/Source/WebCore
Title: [162999] trunk/Source/WebCore
Revision 162999
Author jer.no...@apple.com
Date 2014-01-28 20:44:56 -0800 (Tue, 28 Jan 2014)
Log Message
[Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
https://bugs.webkit.org/show_bug.cgi?id=127806
Reviewed by Eric Carlson.
In addition to the normal "user/password" NSURLAuthenticationChallenges, the
-resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
ask us to confirm server certificate chains. Rather than pop up an authentication
dialog (which won't work anyway) we will now just drop such requests and continue
on normally.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (162998 => 162999)
--- trunk/Source/WebCore/ChangeLog 2014-01-29 04:18:20 UTC (rev 162998)
+++ trunk/Source/WebCore/ChangeLog 2014-01-29 04:44:56 UTC (rev 162999)
@@ -1,3 +1,19 @@
+2014-01-28 Jer Noble
+
+[Mac] Handle NSURLAuthenticationMethodServerTrust challenges from -resourceLoader:shouldWaitForResponseToAuthenticationChallenge:
+https://bugs.webkit.org/show_bug.cgi?id=127806
+
+Reviewed by Eric Carlson.
+
+In addition to the normal "user/password" NSURLAuthenticationChallenges, the
+-resourceLoader:shouldWaitForResponseToAuthenticationChallenge: delegate method will
+ask us to confirm server certificate chains. Rather than pop up an authentication
+dialog (which won't work anyway) we will now just drop such requests and continue
+on normally.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
+
2014-01-28 Commit Queue
Unreviewed, rolling out r162987.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (162998 => 162999)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-01-29 04:18:20 UTC (rev 162998)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2014-01-29 04:44:56 UTC (rev 162999)
@@ -2101,6 +2101,9 @@
if (!m_callback)
return NO;
+if ([[[challenge protectionSpace] authenticationMethod] isEqualToString:NSURLAuthenticationMethodServerTrust])
+return NO;
+
RetainPtr strongSelf = self;
RetainPtr strongChallenge = challenge;
callOnMainThread([strongSelf, strongChallenge] {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162997] trunk/Source/WebCore
Title: [162997] trunk/Source/WebCore Revision 162997 Author enr...@apple.com Date 2014-01-28 20:09:12 -0800 (Tue, 28 Jan 2014) Log Message Add support for ActionSheets in WK2 for iOS. https://bugs.webkit.org/show_bug.cgi?id=127586 Reviewed by Benjamin Poulain. This patch contains some WebCore changes required to implement support for ActionSheets. It adds copyURL implementation for iOS in the Editor class and fixes some bugs in the iOS specific pasteboard writing code. The changes to Localizable.strings are the result of running update-webkit-localizedstrings script. * English.lproj/Localizable.strings: * WebCore.exp.in: * editing/Editor.cpp: * editing/Editor.h: * editing/ios/EditorIOS.mm: (WebCore::Editor::writeImageToPasteboard): * platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::write): * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::write): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/Localizable.strings trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/editing/Editor.h trunk/Source/WebCore/editing/ios/EditorIOS.mm trunk/Source/WebCore/platform/ios/PasteboardIOS.mm trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm Diff Modified: trunk/Source/WebCore/ChangeLog (162996 => 162997) --- trunk/Source/WebCore/ChangeLog 2014-01-29 03:24:01 UTC (rev 162996) +++ trunk/Source/WebCore/ChangeLog 2014-01-29 04:09:12 UTC (rev 162997) @@ -1,3 +1,30 @@ +2014-01-28 Enrica Casucci + +Add support for ActionSheets in WK2 for iOS. +https://bugs.webkit.org/show_bug.cgi?id=127586 + + +Reviewed by Benjamin Poulain. + +This patch contains some WebCore changes required to +implement support for ActionSheets. +It adds copyURL implementation for iOS in the Editor +class and fixes some bugs in the iOS specific pasteboard +writing code. +The changes to Localizable.strings are the result of +running update-webkit-localizedstrings script. + +* English.lproj/Localizable.strings: +* WebCore.exp.in: +* editing/Editor.cpp: +* editing/Editor.h: +* editing/ios/EditorIOS.mm: +(WebCore::Editor::writeImageToPasteboard): +* platform/ios/PasteboardIOS.mm: +(WebCore::Pasteboard::write): +* platform/ios/PlatformPasteboardIOS.mm: +(WebCore::PlatformPasteboard::write): + 2014-01-28 Andy Estes [iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (162996 => 162997) --- trunk/Source/WebCore/English.lproj/Localizable.strings 2014-01-29 03:24:01 UTC (rev 162996) +++ trunk/Source/WebCore/English.lproj/Localizable.strings 2014-01-29 04:09:12 UTC (rev 162997) @@ -64,6 +64,9 @@ /* window title for a standalone image (uses multiplication symbol, not x) */ " %d×%d pixels" = " %d×%d pixels"; +/* Title for Add to Reading List action button */ +"Add to Reading List" = "Add to Reading List"; + /* Undo action name */ "Align Left (Undo action name)" = "Align Left"; @@ -88,6 +91,9 @@ /* Undo action name */ "Bold (Undo action name)" = "Bold"; +/* Title for Cancel button label in button bar */ +"Cancel button label in button bar" = "Cancel"; + /* Capitalize context menu item */ "Capitalize" = "Capitalize"; @@ -112,11 +118,11 @@ /* title for a multiple file chooser button used in HTML forms. This title should be as short as possible. */ "Choose Files" = "Choose Files"; -/* PLATFORM(IOS) title for file button used in HTML forms for media files */ -"Choose Media (Single)" = "Choose Photo"; +/* Title for file button used in HTML5 forms for multiple media files */ +"Choose Media (Multiple)" = "Choose Media (Multiple)"; -/* PLATFORM(IOS) title for file button used in HTML5 forms for multiple media files */ -"Choose Media (Multiple)" = "Choose Photos"; +/* Title for file button used in HTML forms for media files */ +"Choose Media (Single)" = "Choose Media (Single)"; /* menu item in Recent Searches menu that empties menu's contents */ "Clear Recent Searches" = "Clear Recent Searches"; @@ -136,6 +142,9 @@ /* Copy context menu item */ "Copy" = "Copy"; +/* Title for Copy Link or Image action button */ +"Copy ActionSheet Link" = "Copy"; + /* Copy Audio Address Location context menu item */ "Copy Audio Address" = "Copy Audio Address"; @@ -163,15 +172,15 @@ /* Default writing direction context menu item */ "Default" = "Default"; -/* PLATFORM(IOS) Undo action name */ +/* Undo action name (Used only by PLATFORM(IOS) code) */ "Delete (Undo action name)" = "Delete"; -/* PLATFORM(IOS) Undo action name */ -"Dictation (Undo action name)" = "Dictation"; - /* text to display in tag when it has no child */ "Details" = "Details"; +/* Undo action name (Used only by PLATFORM(IOS) code) */ +"Dictation (Undo action name)
[webkit-changes] [162995] tags/Safari-538.14.1/Source/WebCore
Title: [162995] tags/Safari-538.14.1/Source/WebCore
Revision 162995
Author matthew_han...@apple.com
Date 2014-01-28 19:12:07 -0800 (Tue, 28 Jan 2014)
Log Message
Merge r162994:
Modified Paths
tags/Safari-538.14.1/Source/WebCore/ChangeLog
tags/Safari-538.14.1/Source/WebCore/platform/ScrollView.cpp
Diff
Modified: tags/Safari-538.14.1/Source/WebCore/ChangeLog (162994 => 162995)
--- tags/Safari-538.14.1/Source/WebCore/ChangeLog 2014-01-29 03:06:01 UTC (rev 162994)
+++ tags/Safari-538.14.1/Source/WebCore/ChangeLog 2014-01-29 03:12:07 UTC (rev 162995)
@@ -1,3 +1,18 @@
+2014-01-28 Matthew Hanson
+
+Merge r162994:
+
+2014-01-28 Andy Estes
+
+[iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries
+https://bugs.webkit.org/show_bug.cgi?id=127823
+
+Reviewed by Daniel Bates.
+
+Original patch by Simon Fraser.
+
+* platform/ScrollView.cpp: Specify LegacyIOSDocumentViewRect when calling visibleContentRect().
+
2014-01-28 Babak Shafiei
Merge r162885
Modified: tags/Safari-538.14.1/Source/WebCore/platform/ScrollView.cpp (162994 => 162995)
--- tags/Safari-538.14.1/Source/WebCore/platform/ScrollView.cpp 2014-01-29 03:06:01 UTC (rev 162994)
+++ tags/Safari-538.14.1/Source/WebCore/platform/ScrollView.cpp 2014-01-29 03:12:07 UTC (rev 162995)
@@ -382,7 +382,7 @@
{
// If no scrollbars are present, it does not indicate content is not be scrollable.
if (!m_horizontalScrollbar && !m_verticalScrollbar && !prohibitsScrolling()) {
-IntSize scrollSize = m_contentsSize - visibleContentRect().size();
+IntSize scrollSize = m_contentsSize - visibleContentRect(LegacyIOSDocumentVisibleRect).size();
scrollSize.clampNegativeToZero();
return orientation == HorizontalScrollbar ? scrollSize.width() : scrollSize.height();
}
@@ -1025,7 +1025,7 @@
{
IntRect paintRect = rect;
if (clipsRepaints() && !paintsEntireContents())
-paintRect.intersect(visibleContentRect());
+paintRect.intersect(visibleContentRect(LegacyIOSDocumentVisibleRect));
if (paintRect.isEmpty())
return;
@@ -1142,7 +1142,7 @@
IntRect documentDirtyRect = rect;
if (!paintsEntireContents()) {
-IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect().size());
+IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect(LegacyIOSDocumentVisibleRect).size());
documentDirtyRect.intersect(visibleAreaWithoutScrollbars);
}
@@ -1156,7 +1156,7 @@
context->translate(-scrollX(), -scrollY());
documentDirtyRect.moveBy(scrollPosition());
-context->clip(visibleContentRect());
+context->clip(visibleContentRect(LegacyIOSDocumentVisibleRect));
}
paintContents(context, documentDirtyRect);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162994] trunk/Source/WebCore
Title: [162994] trunk/Source/WebCore
Revision 162994
Author aes...@apple.com
Date 2014-01-28 19:06:01 -0800 (Tue, 28 Jan 2014)
Log Message
[iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries
https://bugs.webkit.org/show_bug.cgi?id=127823
Reviewed by Daniel Bates.
Original patch by Simon Fraser.
* platform/ScrollView.cpp: Specify LegacyIOSDocumentViewRect when calling visibleContentRect().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (162993 => 162994)
--- trunk/Source/WebCore/ChangeLog 2014-01-29 02:58:04 UTC (rev 162993)
+++ trunk/Source/WebCore/ChangeLog 2014-01-29 03:06:01 UTC (rev 162994)
@@ -1,3 +1,14 @@
+2014-01-28 Andy Estes
+
+[iOS] REGRESSION (r162663): Webpages have strange artifacts or corruption around tile boundaries
+https://bugs.webkit.org/show_bug.cgi?id=127823
+
+Reviewed by Daniel Bates.
+
+Original patch by Simon Fraser.
+
+* platform/ScrollView.cpp: Specify LegacyIOSDocumentViewRect when calling visibleContentRect().
+
2014-01-28 Zoltan Horvath
[CSS Shapes] Adjust inset sizing syntax to the latest specification
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (162993 => 162994)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2014-01-29 02:58:04 UTC (rev 162993)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2014-01-29 03:06:01 UTC (rev 162994)
@@ -382,7 +382,7 @@
{
// If no scrollbars are present, it does not indicate content is not be scrollable.
if (!m_horizontalScrollbar && !m_verticalScrollbar && !prohibitsScrolling()) {
-IntSize scrollSize = m_contentsSize - visibleContentRect().size();
+IntSize scrollSize = m_contentsSize - visibleContentRect(LegacyIOSDocumentVisibleRect).size();
scrollSize.clampNegativeToZero();
return orientation == HorizontalScrollbar ? scrollSize.width() : scrollSize.height();
}
@@ -1025,7 +1025,7 @@
{
IntRect paintRect = rect;
if (clipsRepaints() && !paintsEntireContents())
-paintRect.intersect(visibleContentRect());
+paintRect.intersect(visibleContentRect(LegacyIOSDocumentVisibleRect));
if (paintRect.isEmpty())
return;
@@ -1142,7 +1142,7 @@
IntRect documentDirtyRect = rect;
if (!paintsEntireContents()) {
-IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect().size());
+IntRect visibleAreaWithoutScrollbars(location(), visibleContentRect(LegacyIOSDocumentVisibleRect).size());
documentDirtyRect.intersect(visibleAreaWithoutScrollbars);
}
@@ -1156,7 +1156,7 @@
context->translate(-scrollX(), -scrollY());
documentDirtyRect.moveBy(scrollPosition());
-context->clip(visibleContentRect());
+context->clip(visibleContentRect(LegacyIOSDocumentVisibleRect));
}
paintContents(context, documentDirtyRect);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162992] branches/jsCStack/Source/JavaScriptCore
Title: [162992] branches/jsCStack/Source/_javascript_Core Revision 162992 Author fpi...@apple.com Date 2014-01-28 18:42:45 -0800 (Tue, 28 Jan 2014) Log Message DFG ArrayPop double array mishandles the NaN hole installation https://bugs.webkit.org/show_bug.cgi?id=127813 Reviewed by Mark Rowe. Our object model for arrays inferred double dictates that we use quiet NaN (QNaN) to mark holes. Holes, in this context, are any entries in the allocated array buffer (i.e. from index 0 up to the vectorLength) that don't currently hold a value. Popping creates a hole, since it deletes the value at publicLength - 1. But, because of some sloppy copy-and-paste, we were storing (int64_t)0 when creating the hole, instead of storing QNaN. That's likely because for other kinds of arrays, 64-bit zero is the hole marker, instead of QNaN. The attached test case illustrates the problem. In the LLInt and Baseline JIT, the result returned from foo() is "1.5,2.5,,4.5", since array.pop() removes 3.5 and replaces it with a hole and then the assignment "array[3] = 4.5" creates an element just beyond that hole. But, once we tier-up to the DFG, the result previously became "1.5,2.5,0,4.5", which is wrong. The 0 appeared because the IEEE double interpretation of 64-bit zero is simply zero. This patch fixes that problem. Now the DFG agrees with the other engines. This patch also fixes style. For some reason that copy-pasted code wasn't even indented correctly. * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * tests/stress/array-pop-double-hole.js: Added. (foo): Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Added Paths branches/jsCStack/Source/_javascript_Core/tests/stress/array-pop-double-hole.js Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162991 => 162992) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-29 01:44:47 UTC (rev 162991) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-29 02:42:45 UTC (rev 162992) @@ -1,5 +1,38 @@ 2014-01-28 Filip Pizlo +DFG ArrayPop double array mishandles the NaN hole installation +https://bugs.webkit.org/show_bug.cgi?id=127813 + +Reviewed by Mark Rowe. + +Our object model for arrays inferred double dictates that we use quiet NaN (QNaN) to +mark holes. Holes, in this context, are any entries in the allocated array buffer +(i.e. from index 0 up to the vectorLength) that don't currently hold a value. Popping +creates a hole, since it deletes the value at publicLength - 1. + +But, because of some sloppy copy-and-paste, we were storing (int64_t)0 when creating +the hole, instead of storing QNaN. That's likely because for other kinds of arrays, +64-bit zero is the hole marker, instead of QNaN. + +The attached test case illustrates the problem. In the LLInt and Baseline JIT, the +result returned from foo() is "1.5,2.5,,4.5", since array.pop() removes 3.5 and +replaces it with a hole and then the assignment "array[3] = 4.5" creates an element +just beyond that hole. But, once we tier-up to the DFG, the result previously became +"1.5,2.5,0,4.5", which is wrong. The 0 appeared because the IEEE double +interpretation of 64-bit zero is simply zero. + +This patch fixes that problem. Now the DFG agrees with the other engines. + +This patch also fixes style. For some reason that copy-pasted code wasn't even +indented correctly. + +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::compile): +* tests/stress/array-pop-double-hole.js: Added. +(foo): + +2014-01-28 Filip Pizlo + FTL should support ArrayPush https://bugs.webkit.org/show_bug.cgi?id=127748 Modified: branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (162991 => 162992) --- branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-29 01:44:47 UTC (rev 162991) +++ branches/jsCStack/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2014-01-29 02:42:45 UTC (rev 162992) @@ -3302,7 +3302,7 @@ // FIXME: This would not have to be here if changing the publicLength also zeroed the values between the old // length and the new length. m_jit.store64( -MacroAssembler::TrustedImm64((int64_t)0), MacroAssembler::BaseIndex(storageGPR, storageLengthGPR, MacroAssembler::TimesEight)); +MacroAssembler::TrustedImm64(bitwise_cast(QNaN)), MacroAssembler::BaseIndex(storageGPR, storageLengthGPR, MacroAssembler::TimesEight)); slowCase = m_jit.branchDouble(MacroAssembler::DoubleNotEqualOrUnordered, tempFPR, tempFPR); boxDouble(tempFPR, valueGPR);
[webkit-changes] [162991] trunk/Source/WebKit2
Title: [162991] trunk/Source/WebKit2
Revision 162991
Author ander...@apple.com
Date 2014-01-28 17:44:47 -0800 (Tue, 28 Jan 2014)
Log Message
Fix a thinko.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goBack):
Remove early return if isValid() is true.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162990 => 162991)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 01:39:32 UTC (rev 162990)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 01:44:47 UTC (rev 162991)
@@ -1,5 +1,13 @@
2014-01-28 Anders Carlsson
+Fix a thinko.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::goBack):
+Remove early return if isValid() is true.
+
+2014-01-28 Anders Carlsson
+
WebPage should be in charge of creating document loaders
https://bugs.webkit.org/show_bug.cgi?id=127818
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (162990 => 162991)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-29 01:39:32 UTC (rev 162990)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-29 01:44:47 UTC (rev 162991)
@@ -789,9 +789,6 @@
void WebPageProxy::goBack()
{
-if (isValid())
-return;
-
WebBackForwardListItem* backItem = m_backForwardList->backItem();
if (!backItem)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162990] trunk/Source/WebKit2
Title: [162990] trunk/Source/WebKit2
Revision 162990
Author ander...@apple.com
Date 2014-01-28 17:39:32 -0800 (Tue, 28 Jan 2014)
Log Message
WebPage should be in charge of creating document loaders
https://bugs.webkit.org/show_bug.cgi?id=127818
Reviewed by Dan Bernstein.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createDocumentLoader):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createDocumentLoader):
* WebProcess/WebPage/WebPage.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162989 => 162990)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 01:22:16 UTC (rev 162989)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 01:39:32 UTC (rev 162990)
@@ -1,3 +1,16 @@
+2014-01-28 Anders Carlsson
+
+WebPage should be in charge of creating document loaders
+https://bugs.webkit.org/show_bug.cgi?id=127818
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::createDocumentLoader):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::createDocumentLoader):
+* WebProcess/WebPage/WebPage.h:
+
2014-01-28 Carlos Alberto Lopez Perez
Unreviewed GTK build fix after r162951.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (162989 => 162990)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-29 01:22:16 UTC (rev 162989)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2014-01-29 01:39:32 UTC (rev 162990)
@@ -38,7 +38,6 @@
#include "WebBackForwardListProxy.h"
#include "WebContextMessages.h"
#include "WebCoreArgumentCoders.h"
-#include "WebDocumentLoader.h"
#include "WebErrors.h"
#include "WebEvent.h"
#include "WebFrame.h"
@@ -952,7 +951,7 @@
bool shouldGoToBackForwardListItem = webPage->injectedBundleLoaderClient().shouldGoToBackForwardListItem(webPage, bundleItem.get(), userData);
if (!shouldGoToBackForwardListItem)
return false;
-
+
webPage->send(Messages::WebPageProxy::WillGoToBackForwardListItem(itemID, InjectedBundleUserMessageEncoder(userData.get(;
return true;
}
@@ -1131,9 +1130,9 @@
notImplemented();
}
-PassRefPtr WebFrameLoaderClient::createDocumentLoader(const ResourceRequest& request, const SubstituteData& data)
+PassRefPtr WebFrameLoaderClient::createDocumentLoader(const ResourceRequest& request, const SubstituteData& substituteData)
{
-return WebDocumentLoader::create(request, data);
+return m_frame->page()->createDocumentLoader(*m_frame->coreFrame(), request, substituteData);
}
void WebFrameLoaderClient::setTitle(const StringWithDirection& title, const URL& url)
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (162989 => 162990)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-29 01:22:16 UTC (rev 162989)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2014-01-29 01:39:32 UTC (rev 162990)
@@ -61,6 +61,7 @@
#include "WebContextMenuClient.h"
#include "WebContextMessages.h"
#include "WebCoreArgumentCoders.h"
+#include "WebDocumentLoader.h"
#include "WebDragClient.h"
#include "WebEditorClient.h"
#include "WebEvent.h"
@@ -4163,4 +4164,13 @@
m_page->mainFrame().view()->setScrollPinningBehavior(m_scrollPinningBehavior);
}
+PassRefPtr WebPage::createDocumentLoader(Frame& frame, const ResourceRequest& request, const SubstituteData& substituteData)
+{
+RefPtr documentLoader = WebDocumentLoader::create(request, substituteData);
+
+// FIXME: Set the navigation ID if possible.
+
+return documentLoader.release();
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (162989 => 162990)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-29 01:22:16 UTC (rev 162989)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h 2014-01-29 01:39:32 UTC (rev 162990)
@@ -122,6 +122,7 @@
class ResourceResponse;
class ResourceRequest;
class SharedBuffer;
+class SubstituteData;
class TextCheckingRequest;
class VisibleSelection;
struct KeypressCommand;
@@ -689,7 +690,9 @@
WKTypeRef pageOverlayCopyAccessibilityAttributeValue(WKStringRef attribute, WKTypeRef parameter);
WKArrayRef pageOverlayCopyAccessibilityAttributesNames(bool parameterizedNames);
-
+
+PassRefPtr createDocumentLoader(WebCore::Frame&, const WebCore::ResourceRequest&, const WebCore::SubstituteData&);
+
private:
WebPage(uint64_t pageID, const WebPageCreationParameters&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webki
[webkit-changes] [162988] trunk/Source/WebKit2
Title: [162988] trunk/Source/WebKit2 Revision 162988 Author commit-qu...@webkit.org Date 2014-01-28 17:19:50 -0800 (Tue, 28 Jan 2014) Log Message Unreviewed GTK build fix after r162951. https://bugs.webkit.org/show_bug.cgi?id=127815 Patch by Carlos Alberto Lopez Perez on 2014-01-28 * GNUmakefile.list.am: Adding missing build targets. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.list.am Diff Modified: trunk/Source/WebKit2/ChangeLog (162987 => 162988) --- trunk/Source/WebKit2/ChangeLog 2014-01-29 01:13:02 UTC (rev 162987) +++ trunk/Source/WebKit2/ChangeLog 2014-01-29 01:19:50 UTC (rev 162988) @@ -1,3 +1,10 @@ +2014-01-28 Carlos Alberto Lopez Perez + +Unreviewed GTK build fix after r162951. +https://bugs.webkit.org/show_bug.cgi?id=127815 + +* GNUmakefile.list.am: Adding missing build targets. + 2014-01-28 Tim Horton WebKit2 View Gestures (Swipe): Give WebCore the first crack at scroll events if it needs it Modified: trunk/Source/WebKit2/GNUmakefile.list.am (162987 => 162988) --- trunk/Source/WebKit2/GNUmakefile.list.am 2014-01-29 01:13:02 UTC (rev 162987) +++ trunk/Source/WebKit2/GNUmakefile.list.am 2014-01-29 01:19:50 UTC (rev 162988) @@ -398,6 +398,8 @@ Source/WebKit2/Shared/NativeWebKeyboardEvent.h \ Source/WebKit2/Shared/NativeWebMouseEvent.h \ Source/WebKit2/Shared/NativeWebWheelEvent.h \ + Source/WebKit2/Shared/NavigationActionData.cpp \ + Source/WebKit2/Shared/NavigationActionData.h \ Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h \ Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h \ Source/WebKit2/Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162985] trunk/Source/WebCore
Title: [162985] trunk/Source/WebCore
Revision 162985
Author bfulg...@apple.com
Date 2014-01-28 16:59:52 -0800 (Tue, 28 Jan 2014)
Log Message
Improve latching behavior for wheel events
https://bugs.webkit.org/show_bug.cgi?id=127386
Reviewed by Simon Fraser.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::clearLatchedNode): Added
(WebCore::ScrollingTree::latchedNode): Added
(WebCore::ScrollingTree::removeDestroyedNodes): Clear latched node if it's being removed.
(WebCore::ScrollingTree::ScrollingTree): Initialize new value used for tracking
scroll latching state.
(WebCore::ScrollingTree::setLatchedNode): Added
(WebCore::ScrollingTree::setOrClearLatchedNode): Added
Set latched node when beginning a swipe event, or clear latched node when scroll/momentum ends.
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Check for an existing
latched node and stay in fast scrolling mode if possible. If the current event should
start a swipe event, clear the current latched node so we can correctly find and assign
the new latch node.
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::hasLatchedNode): Added
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent): Determine latching state
based on wheel event state and position of mouse pointer in the document.
* platform/ScrollAnimator.cpp:
(ScrollAnimator::handleWheelEvent): Always treat PlatformWheelEventPhaseMayBegin
as successfully handled so that it does not "bubble back up" to the root of
the scrolling tree.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm
trunk/Source/WebCore/platform/ScrollAnimator.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (162984 => 162985)
--- trunk/Source/WebCore/ChangeLog 2014-01-29 00:50:56 UTC (rev 162984)
+++ trunk/Source/WebCore/ChangeLog 2014-01-29 00:59:52 UTC (rev 162985)
@@ -1,3 +1,34 @@
+2014-01-28 Brent Fulgham
+
+Improve latching behavior for wheel events
+https://bugs.webkit.org/show_bug.cgi?id=127386
+
+
+Reviewed by Simon Fraser.
+
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::clearLatchedNode): Added
+(WebCore::ScrollingTree::latchedNode): Added
+(WebCore::ScrollingTree::removeDestroyedNodes): Clear latched node if it's being removed.
+(WebCore::ScrollingTree::ScrollingTree): Initialize new value used for tracking
+scroll latching state.
+(WebCore::ScrollingTree::setLatchedNode): Added
+(WebCore::ScrollingTree::setOrClearLatchedNode): Added
+Set latched node when beginning a swipe event, or clear latched node when scroll/momentum ends.
+(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Check for an existing
+latched node and stay in fast scrolling mode if possible. If the current event should
+start a swipe event, clear the current latched node so we can correctly find and assign
+the new latch node.
+* page/scrolling/ScrollingTree.h:
+(WebCore::ScrollingTree::hasLatchedNode): Added
+* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
+(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent): Determine latching state
+based on wheel event state and position of mouse pointer in the document.
+* platform/ScrollAnimator.cpp:
+(ScrollAnimator::handleWheelEvent): Always treat PlatformWheelEventPhaseMayBegin
+as successfully handled so that it does not "bubble back up" to the root of
+the scrolling tree.
+
2014-01-23 Myles C. Maxfield
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp (162984 => 162985)
--- trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp 2014-01-29 00:50:56 UTC (rev 162984)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp 2014-01-29 00:59:52 UTC (rev 162985)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013, 2014 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -48,6 +48,7 @@
, m_mainFramePinnedToTheBottom(false)
, m_mainFrameIsRubberBanding(false)
, m_scrollPinningBehavior(DoNotPin)
+, m_latchedNode(0)
, m_scrollingPerformanceLoggingEnabled(false)
, m_isHandlingProgrammaticScroll(false)
{
@@ -57,13 +58,39 @@
{
}
+static bool shouldConsiderLatching(const PlatformWheelEvent& wheelEvent)
+{
+return wheelEvent.phase() == PlatformWheelEventPhaseBegan
+|| wheelEvent.phase() == PlatformWheelEventPhaseMayBegin;
+}
+
+static bool eventShouldClear
[webkit-changes] [162984] trunk/Source/WebKit2
Title: [162984] trunk/Source/WebKit2 Revision 162984 Author timothy_hor...@apple.com Date 2014-01-28 16:50:56 -0800 (Tue, 28 Jan 2014) Log Message WebKit2 View Gestures (Swipe): Give WebCore the first crack at scroll events if it needs it https://bugs.webkit.org/show_bug.cgi?id=127396 Reviewed by Anders Carlsson. * UIProcess/API/ios/PageClientImplIOS.h: * UIProcess/API/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore): * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore): * UIProcess/API/mac/WKView.mm: (-[WKView _wheelEventWasNotHandledByWebCore:]): * UIProcess/API/mac/WKViewInternal.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): In addition to informing the page client about un-handled wheel events, inform the ViewGestureController, in a roundabout way. * UIProcess/mac/ViewGestureController.h: Add and use SwipeDirection enum instead of 'bool willSwipeLeft'. * UIProcess/mac/ViewGestureController.mm: (WebKit::ViewGestureController::ViewGestureController): (WebKit::ViewGestureController::handleScrollWheelEvent): If we get a Begin scroll wheel event, any previously deferred swipes are invalid. If the page has subframes or wheel handlers, defer starting the swipe until we get a wheelEventWasNotHandledByWebCore back from the WebProcess. (WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore): Start the swipe if the WebProcess didn't eat the event. (WebKit::ViewGestureController::trackSwipeGesture): (WebKit::ViewGestureController::beginSwipeGesture): (WebKit::ViewGestureController::handleSwipeGesture): Use SwipeDirection. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.h trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (162983 => 162984) --- trunk/Source/WebKit2/ChangeLog 2014-01-29 00:48:17 UTC (rev 162983) +++ trunk/Source/WebKit2/ChangeLog 2014-01-29 00:50:56 UTC (rev 162984) @@ -1,3 +1,45 @@ +2014-01-28 Tim Horton + +WebKit2 View Gestures (Swipe): Give WebCore the first crack at scroll events if it needs it +https://bugs.webkit.org/show_bug.cgi?id=127396 + +Reviewed by Anders Carlsson. + +* UIProcess/API/ios/PageClientImplIOS.h: +* UIProcess/API/ios/PageClientImplIOS.mm: +(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore): +* UIProcess/API/mac/PageClientImpl.h: +* UIProcess/API/mac/PageClientImpl.mm: +(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore): +* UIProcess/API/mac/WKView.mm: +(-[WKView _wheelEventWasNotHandledByWebCore:]): +* UIProcess/API/mac/WKViewInternal.h: +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::didReceiveEvent): +In addition to informing the page client about un-handled wheel events, +inform the ViewGestureController, in a roundabout way. + +* UIProcess/mac/ViewGestureController.h: +Add and use SwipeDirection enum instead of 'bool willSwipeLeft'. + +* UIProcess/mac/ViewGestureController.mm: +(WebKit::ViewGestureController::ViewGestureController): +(WebKit::ViewGestureController::handleScrollWheelEvent): +If we get a Begin scroll wheel event, any previously deferred +swipes are invalid. + +If the page has subframes or wheel handlers, defer starting the +swipe until we get a wheelEventWasNotHandledByWebCore back from the WebProcess. + +(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore): +Start the swipe if the WebProcess didn't eat the event. + +(WebKit::ViewGestureController::trackSwipeGesture): +(WebKit::ViewGestureController::beginSwipeGesture): +(WebKit::ViewGestureController::handleSwipeGesture): +Use SwipeDirection. + 2014-01-28 Anders Carlsson Fix build. Modified: trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h (162983 => 162984) --- trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h 2014-01-29 00:48:17 UTC (rev 162983) +++ trunk/Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h 2014-01-29 00:50:56 UTC (rev 162984) @@ -98,6 +98,7 @@ #endif virtual RetainPtr takeViewSnapshot() override; +virtual void wheelEventWasNotHandledByWebCore(const NativeWebWheelEvent&) override; vir
[webkit-changes] [162983] tags/Safari-538.14.1/Source/WebKit2
Title: [162983] tags/Safari-538.14.1/Source/WebKit2 Revision 162983 Author matthew_han...@apple.com Date 2014-01-28 16:48:17 -0800 (Tue, 28 Jan 2014) Log Message Merge r162977: Modified Paths tags/Safari-538.14.1/Source/WebKit2/ChangeLog tags/Safari-538.14.1/Source/WebKit2/Configurations/WebKit2.xcconfig Diff Modified: tags/Safari-538.14.1/Source/WebKit2/ChangeLog (162982 => 162983) --- tags/Safari-538.14.1/Source/WebKit2/ChangeLog 2014-01-29 00:42:12 UTC (rev 162982) +++ tags/Safari-538.14.1/Source/WebKit2/ChangeLog 2014-01-29 00:48:17 UTC (rev 162983) @@ -1,3 +1,16 @@ +2014-01-28 Matthew Hanson + +Merge r162977: + +2014-01-28 Andy Estes + +[iOS] Set INSTALL_PATH_ACTUAL when building WebKit2 for the iOS Simulator +https://bugs.webkit.org/show_bug.cgi?id=127811 + +Reviewed by Dan Bernstein. + +* Configurations/WebKit2.xcconfig: + 2014-01-28 Babak Shafiei Merge r162881 Modified: tags/Safari-538.14.1/Source/WebKit2/Configurations/WebKit2.xcconfig (162982 => 162983) --- tags/Safari-538.14.1/Source/WebKit2/Configurations/WebKit2.xcconfig 2014-01-29 00:42:12 UTC (rev 162982) +++ tags/Safari-538.14.1/Source/WebKit2/Configurations/WebKit2.xcconfig 2014-01-29 00:48:17 UTC (rev 162983) @@ -27,6 +27,8 @@ INFOPLIST_FILE = Info.plist; INSTALL_PATH = $(WEBKIT2_FRAMEWORKS_DIR); +INSTALL_PATH_ACTUAL = $(INSTALL_PATH_ACTUAL_$(PLATFORM_NAME)); +INSTALL_PATH_ACTUAL_iphonesimulator = $(NORMAL_WEBKIT2_FRAMEWORKS_DIR_iphoneos); DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBKIT2_FRAMEWORKS_DIR); FRAMEWORK_AND_LIBRARY_LDFLAGS = $(FRAMEWORK_AND_LIBRARY_LDFLAGS_$(PLATFORM_NAME)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162982] trunk/Source/WebKit2
Title: [162982] trunk/Source/WebKit2 Revision 162982 Author ander...@apple.com Date 2014-01-28 16:42:12 -0800 (Tue, 28 Jan 2014) Log Message Fix build. * WebProcess/WebPage/WebFrame.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (162981 => 162982) --- trunk/Source/WebKit2/ChangeLog 2014-01-29 00:39:42 UTC (rev 162981) +++ trunk/Source/WebKit2/ChangeLog 2014-01-29 00:42:12 UTC (rev 162982) @@ -1,5 +1,11 @@ 2014-01-28 Anders Carlsson +Fix build. + +* WebProcess/WebPage/WebFrame.cpp: + +2014-01-28 Anders Carlsson + Add WebDocumentLoader, a WebCore::DocumentLoader subclass https://bugs.webkit.org/show_bug.cgi?id=127817 Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (162981 => 162982) --- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-01-29 00:39:42 UTC (rev 162981) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-01-29 00:42:12 UTC (rev 162982) @@ -57,6 +57,7 @@ #include #include #include +#include #include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162981] trunk/Source/WebKit2
Title: [162981] trunk/Source/WebKit2
Revision 162981
Author ander...@apple.com
Date 2014-01-28 16:39:42 -0800 (Tue, 28 Jan 2014)
Log Message
Add WebDocumentLoader, a WebCore::DocumentLoader subclass
https://bugs.webkit.org/show_bug.cgi?id=127817
Reviewed by Tim Horton.
We need a place to store navigation IDs, and since they are per document loader, putting them
in a DocumentLoader subclass seems like a good idea.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createDocumentLoader):
* WebProcess/WebPage/WebDocumentLoader.cpp: Added.
(WebKit::WebDocumentLoader::WebDocumentLoader):
(WebKit::WebDocumentLoader::setNavigationID):
* WebProcess/WebPage/WebDocumentLoader.h: Added.
(WebKit::WebDocumentLoader::create):
(WebKit::WebDocumentLoader::navigationID):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Added Paths
trunk/Source/WebKit2/WebProcess/WebPage/WebDocumentLoader.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebDocumentLoader.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162980 => 162981)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 00:16:00 UTC (rev 162980)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 00:39:42 UTC (rev 162981)
@@ -1,5 +1,25 @@
2014-01-28 Anders Carlsson
+Add WebDocumentLoader, a WebCore::DocumentLoader subclass
+https://bugs.webkit.org/show_bug.cgi?id=127817
+
+Reviewed by Tim Horton.
+
+We need a place to store navigation IDs, and since they are per document loader, putting them
+in a DocumentLoader subclass seems like a good idea.
+
+* WebKit2.xcodeproj/project.pbxproj:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::createDocumentLoader):
+* WebProcess/WebPage/WebDocumentLoader.cpp: Added.
+(WebKit::WebDocumentLoader::WebDocumentLoader):
+(WebKit::WebDocumentLoader::setNavigationID):
+* WebProcess/WebPage/WebDocumentLoader.h: Added.
+(WebKit::WebDocumentLoader::create):
+(WebKit::WebDocumentLoader::navigationID):
+
+2014-01-28 Anders Carlsson
+
Simplify WebFrame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=127812
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (162980 => 162981)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-01-29 00:16:00 UTC (rev 162980)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-01-29 00:39:42 UTC (rev 162981)
@@ -179,6 +179,8 @@
1A594ABB112A1FB6009DE7C7 /* WebUIClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A594AB9112A1FB6009DE7C7 /* WebUIClient.h */; };
1A5B1C501898606F004FCF9B /* WKNavigation.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A5B1C4E1898606F004FCF9B /* WKNavigation.mm */; };
1A5B1C511898606F004FCF9B /* WKNavigation.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A5B1C4F1898606F004FCF9B /* WKNavigation.h */; settings = {ATTRIBUTES = (Public, ); }; };
+ 1A5B1C5418987EDF004FCF9B /* WebDocumentLoader.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A5B1C5218987EDF004FCF9B /* WebDocumentLoader.cpp */; };
+ 1A5B1C5518987EDF004FCF9B /* WebDocumentLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A5B1C5318987EDF004FCF9B /* WebDocumentLoader.h */; };
1A5E4DA412D3BD3D0099A2BB /* TextCheckerState.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A5E4DA312D3BD3D0099A2BB /* TextCheckerState.h */; };
1A6420E412DCE2FF00CAAE2C /* ShareableBitmap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A6420E212DCE2FF00CAAE2C /* ShareableBitmap.cpp */; };
1A6420E512DCE2FF00CAAE2C /* ShareableBitmap.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A6420E312DCE2FF00CAAE2C /* ShareableBitmap.h */; };
@@ -1807,6 +1809,8 @@
1A594AB9112A1FB6009DE7C7 /* WebUIClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebUIClient.h; sourceTree = ""; };
1A5B1C4E1898606F004FCF9B /* WKNavigation.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKNavigation.mm; sourceTree = ""; };
1A5B1C4F1898606F004FCF9B /* WKNavigation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNavigation.h; sourceTree = ""; };
+ 1A5B1C5218987EDF004FCF9B /* WebDocumentLoader.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebDocumentLoader.cpp; sourceTree = ""; };
+ 1A5B1C5318987EDF004FCF9B /* WebDocumentLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebDocumentLoader.h; sourceTree = ""; };
1A5E4DA312D3BD3D0099A2BB /* TextCheckerState.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextCheckerState.h;
[webkit-changes] [162980] trunk/Source/WebKit2
Title: [162980] trunk/Source/WebKit2
Revision 162980
Author ander...@apple.com
Date 2014-01-28 16:16:00 -0800 (Tue, 28 Jan 2014)
Log Message
Simplify WebFrame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=127812
Reviewed by Sam Weinig.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::isMainFrame):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162979 => 162980)
--- trunk/Source/WebKit2/ChangeLog 2014-01-29 00:11:15 UTC (rev 162979)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-29 00:16:00 UTC (rev 162980)
@@ -1,3 +1,13 @@
+2014-01-28 Anders Carlsson
+
+Simplify WebFrame::isMainFrame
+https://bugs.webkit.org/show_bug.cgi?id=127812
+
+Reviewed by Sam Weinig.
+
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::isMainFrame):
+
2014-01-28 Andy Estes
[iOS] Set INSTALL_PATH_ACTUAL when building WebKit2 for the iOS Simulator
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (162979 => 162980)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-01-29 00:11:15 UTC (rev 162979)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-01-29 00:16:00 UTC (rev 162980)
@@ -366,10 +366,10 @@
bool WebFrame::isMainFrame() const
{
-if (WebPage* p = page())
-return p->mainWebFrame() == this;
+if (!m_coreFrame)
+return false;
-return false;
+return m_coreFrame->isMainFrame();
}
String WebFrame::name() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162979] tags/Safari-538.14.1/Source
Title: [162979] tags/Safari-538.14.1/Source Revision 162979 Author matthew_han...@apple.com Date 2014-01-28 16:11:15 -0800 (Tue, 28 Jan 2014) Log Message Versioning. Modified Paths tags/Safari-538.14.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-538.14.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-538.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-538.14.1/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-538.14.1/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-538.14.1/Source/_javascript_Core/Configurations/Version.xcconfig (162978 => 162979) --- tags/Safari-538.14.1/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-29 00:07:24 UTC (rev 162978) +++ tags/Safari-538.14.1/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-29 00:11:15 UTC (rev 162979) @@ -23,8 +23,8 @@ MAJOR_VERSION = 538; MINOR_VERSION = 14; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-538.14.1/Source/WebCore/Configurations/Version.xcconfig (162978 => 162979) --- tags/Safari-538.14.1/Source/WebCore/Configurations/Version.xcconfig 2014-01-29 00:07:24 UTC (rev 162978) +++ tags/Safari-538.14.1/Source/WebCore/Configurations/Version.xcconfig 2014-01-29 00:11:15 UTC (rev 162979) @@ -23,8 +23,8 @@ MAJOR_VERSION = 538; MINOR_VERSION = 14; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-538.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig (162978 => 162979) --- tags/Safari-538.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-29 00:07:24 UTC (rev 162978) +++ tags/Safari-538.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-29 00:11:15 UTC (rev 162979) @@ -1,7 +1,7 @@ MAJOR_VERSION = 538; MINOR_VERSION = 14; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX = $(SYSTEM_VERSION_PREFIX_$(TARGET_MAC_OS_X_VERSION_MAJOR)); Modified: tags/Safari-538.14.1/Source/WebKit/mac/Configurations/Version.xcconfig (162978 => 162979) --- tags/Safari-538.14.1/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-29 00:07:24 UTC (rev 162978) +++ tags/Safari-538.14.1/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-29 00:11:15 UTC (rev 162979) @@ -23,8 +23,8 @@ MAJOR_VERSION = 538; MINOR_VERSION = 14; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-538.14.1/Source/WebKit2/Configurations/Version.xcconfig (162978 => 162979) --- tags/Safari-538.14.1/Source/WebKit2/Configurations/Version.xcconfig 2014-01-29 00:07:24 UTC (rev 162978) +++ tags/Safari-538.14.1/Source/WebKit2/Configurations/Version.xcconfig 2014-01-29 00:11:15 UTC (rev 162979) @@ -23,8 +23,8 @@ MAJOR_VERSION = 538; MINOR_VERSION = 14; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162978] trunk/LayoutTests
Title: [162978] trunk/LayoutTests Revision 162978 Author a...@apple.com Date 2014-01-28 16:07:24 -0800 (Tue, 28 Jan 2014) Log Message REGRESSION (r162947): Repaint test results are different between WK1 and WK2 https://bugs.webkit.org/show_bug.cgi?id=127814 * platform/mac-wk2/TestExpectations: Marking them as failing for now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (162977 => 162978) --- trunk/LayoutTests/ChangeLog 2014-01-28 23:55:40 UTC (rev 162977) +++ trunk/LayoutTests/ChangeLog 2014-01-29 00:07:24 UTC (rev 162978) @@ -1,5 +1,12 @@ 2014-01-28 Alexey Proskuryakov +REGRESSION (r162947): Repaint test results are different between WK1 and WK2 +https://bugs.webkit.org/show_bug.cgi?id=127814 + +* platform/mac-wk2/TestExpectations: Marking them as failing for now. + +2014-01-28 Alexey Proskuryakov + REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out https://bugs.webkit.org/show_bug.cgi?id=127809 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (162977 => 162978) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-01-28 23:55:40 UTC (rev 162977) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-01-29 00:07:24 UTC (rev 162978) @@ -364,6 +364,35 @@ # uiElementForSearchPredicate() is not returning an undefined object when the search returns no results webkit.org/b/125996 platform/mac/accessibility/search-when-element-starts-in-table.html [ Failure ] +webkit.org/b/127814 compositing/repaint/invalidations-on-composited-layers.html [ Failure ] +webkit.org/b/127814 compositing/repaint/resize-repaint.html [ Failure ] +webkit.org/b/127814 fast/box-shadow/shadow-repaint.html [ Failure ] +webkit.org/b/127814 fast/css-grid-layout/grid-element-change-columns-repaint.html [ Failure ] +webkit.org/b/127814 fast/css-grid-layout/grid-element-change-rows-repaint.html [ Failure ] +webkit.org/b/127814 fast/css-grid-layout/grid-item-change-column-repaint.html [ Failure ] +webkit.org/b/127814 fast/css-grid-layout/grid-item-change-row-repaint.html [ Failure ] +webkit.org/b/127814 fast/images/repaint-subrect-grid.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/element-inflow-fixed-from-outflow-static.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/element-outflow-static-from-inflow-fixed.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/invalid-region-repaint-crash.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/repaint-element-inside-relative-region.html [ Failure ] +webkit.org/b/127814 fast/regions/repaint/repaint-regions-overflow.html [ Failure ] +webkit.org/b/127814 fast/repaint/background-shorthand-with-gradient-and-height-changes.html [ Failure ] +webkit.org/b/127814 fast/repaint/horizontal-bt-overflow-child.html [ Failure ] +webkit.org/b/127814 fast/repaint/horizontal-bt-overflow-parent.html [ Failure ] +webkit.org/b/127814 fast/repaint/horizontal-bt-overflow-same.html [ Failure ] +webkit.org/b/127814 fast/repaint/negative-text-indent-with-overflow-hidden.html [ Failure ] +webkit.org/b/127814 fast/repaint/overflow-flipped-writing-mode-table.html [ Failure ] +webkit.org/b/127814 fast/repaint/reflection-table-layout.html [ Failure ] +webkit.org/b/127814 fast/repaint/transform-table-layout.html [ Failure ] +webkit.org/b/127814 fast/repaint/vertical-overflow-child.html [ Failure ] +webkit.org/b/127814 fast/repaint/vertical-overflow-parent.html [ Failure ] +webkit.org/b/127814 fast/repaint/vertical-overflow-same.html [ Failure ] +webkit.org/b/127814 svg/repaint/repaint-webkit-svg-shadow-container.html [ Failure ] + + ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162977] trunk/Source/WebKit2
Title: [162977] trunk/Source/WebKit2 Revision 162977 Author aes...@apple.com Date 2014-01-28 15:55:40 -0800 (Tue, 28 Jan 2014) Log Message [iOS] Set INSTALL_PATH_ACTUAL when building WebKit2 for the iOS Simulator https://bugs.webkit.org/show_bug.cgi?id=127811 Reviewed by Dan Bernstein. * Configurations/WebKit2.xcconfig: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/WebKit2.xcconfig Diff Modified: trunk/Source/WebKit2/ChangeLog (162976 => 162977) --- trunk/Source/WebKit2/ChangeLog 2014-01-28 23:51:30 UTC (rev 162976) +++ trunk/Source/WebKit2/ChangeLog 2014-01-28 23:55:40 UTC (rev 162977) @@ -1,3 +1,12 @@ +2014-01-28 Andy Estes + +[iOS] Set INSTALL_PATH_ACTUAL when building WebKit2 for the iOS Simulator +https://bugs.webkit.org/show_bug.cgi?id=127811 + +Reviewed by Dan Bernstein. + +* Configurations/WebKit2.xcconfig: + 2014-01-28 Jinwoo Song Unreviewed EFL WebKit2 build fix. Modified: trunk/Source/WebKit2/Configurations/WebKit2.xcconfig (162976 => 162977) --- trunk/Source/WebKit2/Configurations/WebKit2.xcconfig 2014-01-28 23:51:30 UTC (rev 162976) +++ trunk/Source/WebKit2/Configurations/WebKit2.xcconfig 2014-01-28 23:55:40 UTC (rev 162977) @@ -27,6 +27,8 @@ INFOPLIST_FILE = Info.plist; INSTALL_PATH = $(WEBKIT2_FRAMEWORKS_DIR); +INSTALL_PATH_ACTUAL = $(INSTALL_PATH_ACTUAL_$(PLATFORM_NAME)); +INSTALL_PATH_ACTUAL_iphonesimulator = $(NORMAL_WEBKIT2_FRAMEWORKS_DIR_iphoneos); DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBKIT2_FRAMEWORKS_DIR); FRAMEWORK_AND_LIBRARY_LDFLAGS = $(FRAMEWORK_AND_LIBRARY_LDFLAGS_$(PLATFORM_NAME)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162975] branches/jsCStack/Source/JavaScriptCore
Title: [162975] branches/jsCStack/Source/_javascript_Core
Revision 162975
Author fpi...@apple.com
Date 2014-01-28 15:49:32 -0800 (Tue, 28 Jan 2014)
Log Message
FTL should support ArrayPush
https://bugs.webkit.org/show_bug.cgi?id=127748
Not reviewed, remove some debug code.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162974 => 162975)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 23:46:30 UTC (rev 162974)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 23:49:32 UTC (rev 162975)
@@ -1,3 +1,13 @@
+2014-01-28 Filip Pizlo
+
+FTL should support ArrayPush
+https://bugs.webkit.org/show_bug.cgi?id=127748
+
+Not reviewed, remove some debug code.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
+
2014-01-27 Filip Pizlo
FTL should support ArrayPush
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (162974 => 162975)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-28 23:46:30 UTC (rev 162974)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-28 23:49:32 UTC (rev 162975)
@@ -2193,30 +2193,6 @@
case Array::Int32:
case Array::Contiguous:
case Array::Double: {
-if (true) {
-LValue value;
-if (m_node->arrayMode().type() != Array::Double) {
-value = lowJSValue(m_node->child2(), ManualOperandSpeculation);
-if (m_node->arrayMode().type() == Array::Int32) {
-FTL_TYPE_CHECK(
-jsValueValue(value), m_node->child2(), SpecInt32, isNotInt32(value));
-}
-} else {
-value = lowDouble(m_node->child2());
-FTL_TYPE_CHECK(
-doubleValue(value), m_node->child2(), SpecFullRealNumber,
-m_out.doubleNotEqualOrUnordered(value, value));
-}
-
-LValue operation;
-if (m_node->arrayMode().type() != Array::Double)
-operation = m_out.operation(operationArrayPush);
-else
-operation = m_out.operation(operationArrayPushDouble);
-setJSValue(vmCall(operation, m_callFrame, value, base));
-return;
-}
-
LValue value;
LType refType;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162974] trunk/LayoutTests
Title: [162974] trunk/LayoutTests Revision 162974 Author a...@apple.com Date 2014-01-28 15:46:30 -0800 (Tue, 28 Jan 2014) Log Message REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and css3/flexbox/position-absolute-child.html are timing out https://bugs.webkit.org/show_bug.cgi?id=127809 * platform/mac/TestExpectations: Skipping for now, Antti is going to take a look tomorrow. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (162973 => 162974) --- trunk/LayoutTests/ChangeLog 2014-01-28 23:43:06 UTC (rev 162973) +++ trunk/LayoutTests/ChangeLog 2014-01-28 23:46:30 UTC (rev 162974) @@ -1,3 +1,11 @@ +2014-01-28 Alexey Proskuryakov + +REGRESSION (r162947): css3/flexbox/multiline-justify-content.html and +css3/flexbox/position-absolute-child.html are timing out +https://bugs.webkit.org/show_bug.cgi?id=127809 + +* platform/mac/TestExpectations: Skipping for now, Antti is going to take a look tomorrow. + 2014-01-23 Myles C. Maxfield ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint Modified: trunk/LayoutTests/platform/mac/TestExpectations (162973 => 162974) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-01-28 23:43:06 UTC (rev 162973) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-01-28 23:46:30 UTC (rev 162974) @@ -1323,3 +1323,6 @@ webkit.org/b/35297 media/video-display-aspect-ratio.html [ Pass Failure ] webkit.org/b/127310 svg/filters/feComponentTransfer-style-crash.xhtml [ Pass Failure Timeout ] + +webkit.org/b/127809 css3/flexbox/multiline-justify-content.html [ Skip ] +webkit.org/b/127809 css3/flexbox/position-absolute-child.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162973] tags/Safari-538.14.1/
Title: [162973] tags/Safari-538.14.1/ Revision 162973 Author matthew_han...@apple.com Date 2014-01-28 15:43:06 -0800 (Tue, 28 Jan 2014) Log Message New Tag. Added Paths tags/Safari-538.14.1/ Diff Property changes: tags/Safari-538.14.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162972] trunk
Title: [162972] trunk
Revision 162972
Author mmaxfi...@apple.com
Date 2014-01-28 15:36:04 -0800 (Tue, 28 Jan 2014)
Log Message
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint
https://bugs.webkit.org/show_bug.cgi?id=114586
Reviewed by Dave Hyatt.
Taken mostly from https://chromium.googlesource.com/chromium/blink/+/cb2297db16f2e9328cb4dd8b552093d6b22340a8
If RenderQuote is a subclass of RenderObject, it can't be split by the first-letter CSS pseudoclass.
Instead, we should make it a subclass of RenderElement, so that it can be split properly.
Source/WebCore:
Test: fast/css-generated-content/quote-first-letter.html
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):
(WebCore::RenderQuote::willBeRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateText):
(WebCore::RenderQuote::computeText):
(WebCore::RenderQuote::updateDepth):
* rendering/RenderQuote.h:
* rendering/style/ContentData.cpp:
(WebCore::QuoteContentData::createContentRenderer):
LayoutTests:
This adds a test to make sure that the splitting behavior occurs, as well as updates existing tests that
didn't use the splitting behavior.
* fast/css-generated-content/quote-first-letter-expected.html: Added.
* fast/css-generated-content/quote-first-letter.html: Added.
* platform/mac/fast/css-generated-content/005-expected.txt:
* platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
* platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/css-generated-content/005-expected.txt
trunk/LayoutTests/platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt
trunk/LayoutTests/platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt
trunk/LayoutTests/platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/PseudoElement.cpp
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderImage.h
trunk/Source/WebCore/rendering/RenderQuote.cpp
trunk/Source/WebCore/rendering/RenderQuote.h
trunk/Source/WebCore/rendering/style/ContentData.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
Added Paths
trunk/LayoutTests/fast/css-generated-content/quote-first-letter-expected.html
trunk/LayoutTests/fast/css-generated-content/quote-first-letter.html
Diff
Modified: trunk/LayoutTests/ChangeLog (162971 => 162972)
--- trunk/LayoutTests/ChangeLog 2014-01-28 23:30:29 UTC (rev 162971)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 23:36:04 UTC (rev 162972)
@@ -1,3 +1,25 @@
+2014-01-23 Myles C. Maxfield
+
+ASSERT_WITH_SECURITY_IMPLICATION in WebCore::InlineTextBox::paint
+https://bugs.webkit.org/show_bug.cgi?id=114586
+
+Reviewed by Dave Hyatt.
+
+Taken mostly from https://chromium.googlesource.com/chromium/blink/+/cb2297db16f2e9328cb4dd8b552093d6b22340a8
+
+If RenderQuote is a subclass of RenderObject, it can't be split by the first-letter CSS pseudoclass.
+Instead, we should make it a subclass of RenderElement, so that it can be split properly.
+
+This adds a test to make sure that the splitting behavior occurs, as well as updates existing tests that
+didn't use the splitting behavior.
+
+* fast/css-generated-content/quote-first-letter-expected.html: Added.
+* fast/css-generated-content/quote-first-letter.html: Added.
+* platform/mac/fast/css-generated-content/005-expected.txt:
+* platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt:
+* platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
+* platform/mac/fast/css-generated-content/no-openclose-quote-expected.txt:
+
2014-01-28 Carlos Alberto Lopez Perez
Unreviewed GTK gardening.
Added: trunk/LayoutTests/fast/css-generated-content/quote-first-letter-expected.html (0 => 162972)
--- trunk/LayoutTests/fast/css-generated-content/quote-first-letter-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/quote-first-letter-expected.html 2014-01-28 23:36:04 UTC (rev 162972)
@@ -0,0 +1,11 @@
+
+
+.quote { color: red; }
+.line { position: absolute; top: 50px; left: 10px; }
+
+
+" "
+
+
+'Should not crash or assert and all four quotes should be displayed.'
+
Added: trunk/LayoutTests/fast/css-generated-content/quote-first-letter.html (0 => 162972)
--- trunk/LayoutTests/fast/css-generated-content/quote-first-letter.html (rev 0)
+++ trunk/LayoutTest
[webkit-changes] [162971] trunk/Tools
Title: [162971] trunk/Tools
Revision 162971
Author dba...@webkit.org
Date 2014-01-28 15:30:29 -0800 (Tue, 28 Jan 2014)
Log Message
Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561
Reviewed by Alexey Proskuryakov.
Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(isMultiCodebaseGotRevisionProperty): Added.
(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (162970 => 162971)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-28 23:29:30 UTC (rev 162970)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2014-01-28 23:30:29 UTC (rev 162971)
@@ -62,6 +62,20 @@
Updated: "updated"
};
+// See .
+function isMultiCodebaseGotRevisionProperty(property)
+{
+return property[0] === "got_revision" && typeof property[1] === "object";
+}
+
+function parseRevisionProperty(property, key)
+{
+if (!property)
+return null;
+var value = property[1];
+return parseInt(isMultiCodebaseGotRevisionProperty(property) ? value[key] : value, 10);
+}
+
BuildbotIteration.prototype = {
constructor: BuildbotIteration,
__proto__: BaseObject.prototype,
@@ -200,11 +214,25 @@
if (!data || !data.properties)
return;
+// The property got_revision may have the following forms:
+//
+// ["got_revision",{"Internal":"1357","WebKitOpenSource":"2468"},"Source"]
+// OR
+// ["got_revision","2468_1357","Source"]
+// OR
+// ["got_revision","2468","Source"]
+//
+// When extracting the OpenSource revision from property got_revision we don't need to check whether the
+// value of got_revision is a dictionary (represents multiple codebases) or a string literal because we
+// assume that got_revision contains the OpenSource revision. However, it may not have the Internal
+// revision. Therefore, we only look at got_revision to extract the Internal revision when it's
+// a dictionary.
+
var openSourceRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "got_revision" || property[0] === "revision" || property[0] === "opensource_got_revision"; });
-this.openSourceRevision = openSourceRevisionProperty ? parseInt(openSourceRevisionProperty[1], 10) : null;
+this.openSourceRevision = parseRevisionProperty(openSourceRevisionProperty, "WebKitOpenSource");
-var internalRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "internal_got_revision"; });
-this.internalRevision = internalRevisionProperty ? parseInt(internalRevisionProperty[1], 10) : null;
+var internalRevisionProperty = data.properties.findFirst(function(property) { return property[0] === "internal_got_revision" || isMultiCodebaseGotRevisionProperty(property); });
+this.internalRevision = parseRevisionProperty(internalRevisionProperty, "Internal");
var layoutTestResults = collectTestResults.call(this, data, "layout-test");
this.layoutTestResults = layoutTestResults ? new BuildbotTestResults(this, layoutTestResults) : null;
Modified: trunk/Tools/ChangeLog (162970 => 162971)
--- trunk/Tools/ChangeLog 2014-01-28 23:29:30 UTC (rev 162970)
+++ trunk/Tools/ChangeLog 2014-01-28 23:30:29 UTC (rev 162971)
@@ -1,3 +1,20 @@
+2014-01-28 Daniel Bates
+
+Teach Buildbot dashboard to parse alternative revision format
+https://bugs.webkit.org/show_bug.cgi?id=127561
+
+Reviewed by Alexey Proskuryakov.
+
+Add support for extracting the OpenSource and Internal revision numbers when Buildbot
+returns a dictionary for the value of property got_revision.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+(isMultiCodebaseGotRevisionProperty): Added.
+(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
+string or a dictionary.
+(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to dete
[webkit-changes] [162970] trunk/Source/JavaScriptCore
Title: [162970] trunk/Source/_javascript_Core Revision 162970 Author mark@apple.com Date 2014-01-28 15:29:30 -0800 (Tue, 28 Jan 2014) Log Message Remove some unneeded debugger code. https://bugs.webkit.org/show_bug.cgi?id=127805. Reviewed by Oliver Hunt. JSC will now always support the debugger. Hence, the #if ENABLE(_javascript__DEBUGGER) checks can be removed. DebuggerCallFrame::callFrame() is also unused and will be removed. * debugger/Breakpoint.h: * debugger/Debugger.cpp: * debugger/DebuggerCallFrame.h: * inspector/InjectedScript.cpp: (Inspector::InjectedScript::wrapCallFrames): * inspector/InjectedScript.h: * inspector/JSGlobalObjectScriptDebugServer.cpp: * inspector/JSGlobalObjectScriptDebugServer.h: * inspector/JSJavaScriptCallFrame.cpp: * inspector/JSJavaScriptCallFrame.h: * inspector/JSJavaScriptCallFramePrototype.cpp: * inspector/JSJavaScriptCallFramePrototype.h: * inspector/_javascript_CallFrame.cpp: * inspector/_javascript_CallFrame.h: * inspector/ScriptDebugListener.h: * inspector/ScriptDebugServer.cpp: * inspector/ScriptDebugServer.h: * inspector/agents/InspectorDebuggerAgent.cpp: * inspector/agents/InspectorDebuggerAgent.h: * inspector/agents/InspectorRuntimeAgent.cpp: (Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent): (Inspector::setPauseOnExceptionsState): (Inspector::InspectorRuntimeAgent::evaluate): (Inspector::InspectorRuntimeAgent::callFunctionOn): (Inspector::InspectorRuntimeAgent::getProperties): * inspector/agents/InspectorRuntimeAgent.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/debugger/Breakpoint.h trunk/Source/_javascript_Core/debugger/Debugger.cpp trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h trunk/Source/_javascript_Core/inspector/InjectedScript.cpp trunk/Source/_javascript_Core/inspector/InjectedScript.h trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.cpp trunk/Source/_javascript_Core/inspector/JSGlobalObjectScriptDebugServer.h trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFrame.cpp trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFrame.h trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFramePrototype.cpp trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFramePrototype.h trunk/Source/_javascript_Core/inspector/_javascript_CallFrame.cpp trunk/Source/_javascript_Core/inspector/_javascript_CallFrame.h trunk/Source/_javascript_Core/inspector/ScriptDebugListener.h trunk/Source/_javascript_Core/inspector/ScriptDebugServer.cpp trunk/Source/_javascript_Core/inspector/ScriptDebugServer.h trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.cpp trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (162969 => 162970) --- trunk/Source/_javascript_Core/ChangeLog 2014-01-28 23:22:56 UTC (rev 162969) +++ trunk/Source/_javascript_Core/ChangeLog 2014-01-28 23:29:30 UTC (rev 162970) @@ -1,3 +1,42 @@ +2014-01-28 Mark Lam + +Remove some unneeded debugger code. +https://bugs.webkit.org/show_bug.cgi?id=127805. + +Reviewed by Oliver Hunt. + +JSC will now always support the debugger. Hence, the #if ENABLE(_javascript__DEBUGGER) +checks can be removed. + +DebuggerCallFrame::callFrame() is also unused and will be removed. + +* debugger/Breakpoint.h: +* debugger/Debugger.cpp: +* debugger/DebuggerCallFrame.h: +* inspector/InjectedScript.cpp: +(Inspector::InjectedScript::wrapCallFrames): +* inspector/InjectedScript.h: +* inspector/JSGlobalObjectScriptDebugServer.cpp: +* inspector/JSGlobalObjectScriptDebugServer.h: +* inspector/JSJavaScriptCallFrame.cpp: +* inspector/JSJavaScriptCallFrame.h: +* inspector/JSJavaScriptCallFramePrototype.cpp: +* inspector/JSJavaScriptCallFramePrototype.h: +* inspector/_javascript_CallFrame.cpp: +* inspector/_javascript_CallFrame.h: +* inspector/ScriptDebugListener.h: +* inspector/ScriptDebugServer.cpp: +* inspector/ScriptDebugServer.h: +* inspector/agents/InspectorDebuggerAgent.cpp: +* inspector/agents/InspectorDebuggerAgent.h: +* inspector/agents/InspectorRuntimeAgent.cpp: +(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent): +(Inspector::setPauseOnExceptionsState): +(Inspector::InspectorRuntimeAgent::evaluate): +(Inspector::InspectorRuntimeAgent::callFunctionOn): +(Inspector::InspectorRuntimeAgent::getProperties): +* inspector/agents/InspectorRuntimeAgent.h: + 2014-01-28 Geoffrey Garen REGRESSION: _javascript_Core crash during OS Installation (due to Modified: trunk/Source/_javascript_Core/debugger/Breakpoint.h (162969 => 16
[webkit-changes] [162969] branches/jsCStack/Source/JavaScriptCore
Title: [162969] branches/jsCStack/Source/_javascript_Core
Revision 162969
Author fpi...@apple.com
Date 2014-01-28 15:22:56 -0800 (Tue, 28 Jan 2014)
Log Message
FTL should support ArrayPush
https://bugs.webkit.org/show_bug.cgi?id=127748
Reviewed by Oliver Hunt.
* ftl/FTLAbstractHeapRepository.h:
(JSC::FTL::AbstractHeapRepository::forArrayType):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLIntrinsicRepository.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
* tests/stress/array-push-contiguous.js: Added.
(foo):
* tests/stress/array-push-double.js: Added.
(foo):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h
branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp
branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h
branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Added Paths
branches/jsCStack/Source/_javascript_Core/tests/stress/array-push-contiguous.js
branches/jsCStack/Source/_javascript_Core/tests/stress/array-push-double-then-nan.js
branches/jsCStack/Source/_javascript_Core/tests/stress/array-push-double.js
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162968 => 162969)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 23:12:19 UTC (rev 162968)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 23:22:56 UTC (rev 162969)
@@ -1,3 +1,23 @@
+2014-01-27 Filip Pizlo
+
+FTL should support ArrayPush
+https://bugs.webkit.org/show_bug.cgi?id=127748
+
+Reviewed by Oliver Hunt.
+
+* ftl/FTLAbstractHeapRepository.h:
+(JSC::FTL::AbstractHeapRepository::forArrayType):
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* ftl/FTLIntrinsicRepository.h:
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::compileNode):
+(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
+* tests/stress/array-push-contiguous.js: Added.
+(foo):
+* tests/stress/array-push-double.js: Added.
+(foo):
+
2014-01-28 Filip Pizlo
Arity fixup clobbers callee-saves, causing FTL->FTL arity fixed-up calls to corrupt state
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (162968 => 162969)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-01-28 23:12:19 UTC (rev 162968)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h 2014-01-28 23:22:56 UTC (rev 162969)
@@ -30,6 +30,7 @@
#if ENABLE(FTL_JIT)
+#include "DFGArrayMode.h"
#include "FTLAbstractHeap.h"
#include "IndexingType.h"
@@ -136,6 +137,24 @@
return 0;
}
}
+
+IndexedAbstractHeap& forArrayType(DFG::Array::Type type)
+{
+switch (type) {
+case DFG::Array::Int32:
+return indexedInt32Properties;
+case DFG::Array::Double:
+return indexedDoubleProperties;
+case DFG::Array::Contiguous:
+return indexedContiguousProperties;
+case DFG::Array::ArrayStorage:
+case DFG::Array::SlowPutArrayStorage:
+return indexedArrayStorageProperties;
+default:
+RELEASE_ASSERT_NOT_REACHED();
+return indexedInt32Properties;
+}
+}
private:
friend class AbstractHeap;
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp (162968 => 162969)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-28 23:12:19 UTC (rev 162968)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-28 23:22:56 UTC (rev 162969)
@@ -201,6 +201,16 @@
return CannotCompile;
}
break;
+case ArrayPush:
+switch (node->arrayMode().type()) {
+case Array::Int32:
+case Array::Contiguous:
+case Array::Double:
+break;
+default:
+return CannotCompile;
+}
+break;
case CompareEq:
if (node->isBinaryUseKind(Int32Use))
break;
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h (162968 => 162969)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-28 23:12:19 UTC (rev 162968)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLIntrinsicRepository.h 2014-01-28 23:22:56 UTC (rev 162969)
@@ -63,6 +63,8 @@
macro(I_JITOperation_EJss, functionType(intPtr, intPtr, intPtr)) \
macro(J_JITOperation_E, functionType(int64, intPtr)) \
macro(J_JITOperation_EAZ, functionType(int64, intPtr, intPtr, int32)) \
+macro(J_JITOperation_EDA, functionType(int64, intPtr, doubleType, intPtr)) \
+macro(J_JITOperation_EJA, functionType(int64, intPtr, int64, intPtr)) \
macro(J_JITOperat
[webkit-changes] [162968] trunk/Source/JavaScriptCore
Title: [162968] trunk/Source/_javascript_Core
Revision 162968
Author gga...@apple.com
Date 2014-01-28 15:12:19 -0800 (Tue, 28 Jan 2014)
Log Message
REGRESSION: _javascript_Core crash during OS Installation (due to
Heap::m_operationInProgress ASSERT vs DelayedReleaseScope)
https://bugs.webkit.org/show_bug.cgi?id=127793
Reviewed by Mark Hahnenberg.
This was a mistaken ASSERT.
* API/tests/testapi.mm:
(-[EvilAllocationObject doEvilThingsWithContext:]): Added a test to verify
that GC from a DelayedReleaseScope doesn't crash.
* heap/DelayedReleaseScope.h:
(JSC::DelayedReleaseScope::~DelayedReleaseScope): Our contract is that
it is valid to do anything while running a DelayedReleaseScope -dealloc
method, so the Heap must be ready for new allocations and collections.
Change the Heap's operationInProgress value to NoOperation while running
-dealloc methods, so that it doesn't ASSERT in the face of new allocations
and collections.
* heap/Heap.h: Made DelayedReleaseScope a friend because exposing a setter
for m_operationInProgress seemed like the worse of the two options for
encapsulation: we don't really want arbitrary clients to set the Heap's
m_operationInProgress.
Modified Paths
trunk/Source/_javascript_Core/API/tests/testapi.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/DelayedReleaseScope.h
trunk/Source/_javascript_Core/heap/Heap.h
Diff
Modified: trunk/Source/_javascript_Core/API/tests/testapi.mm (162967 => 162968)
--- trunk/Source/_javascript_Core/API/tests/testapi.mm 2014-01-28 23:04:56 UTC (rev 162967)
+++ trunk/Source/_javascript_Core/API/tests/testapi.mm 2014-01-28 23:12:19 UTC (rev 162968)
@@ -453,7 +453,7 @@
- (JSValue *)doEvilThingsWithContext:(JSContext *)context
{
-return [context evaluateScript:@" \
+JSValue *result = [context evaluateScript:@" \
(function() { \
var a = []; \
var sum = 0; \
@@ -463,6 +463,9 @@
} \
return sum; \
})()"];
+
+JSSynchronousGarbageCollectForDebugging([context JSGlobalContextRef]);
+return result;
}
@end
@@ -1215,12 +1218,13 @@
@autoreleasepool {
JSContext *context = [[JSContext alloc] init];
-@autoreleasepool {
-EvilAllocationObject *evilObject = [[EvilAllocationObject alloc] initWithContext:context];
-context[@"evilObject"] = evilObject;
-context[@"evilObject"] = nil;
+while (!evilAllocationObjectWasDealloced) {
+@autoreleasepool {
+EvilAllocationObject *evilObject = [[EvilAllocationObject alloc] initWithContext:context];
+context[@"evilObject"] = evilObject;
+context[@"evilObject"] = nil;
+}
}
-JSSynchronousGarbageCollectForDebugging([context JSGlobalContextRef]);
checkResult(@"EvilAllocationObject was successfully dealloced without crashing", evilAllocationObjectWasDealloced);
}
Modified: trunk/Source/_javascript_Core/ChangeLog (162967 => 162968)
--- trunk/Source/_javascript_Core/ChangeLog 2014-01-28 23:04:56 UTC (rev 162967)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-01-28 23:12:19 UTC (rev 162968)
@@ -1,3 +1,31 @@
+2014-01-28 Geoffrey Garen
+
+REGRESSION: _javascript_Core crash during OS Installation (due to
+Heap::m_operationInProgress ASSERT vs DelayedReleaseScope)
+https://bugs.webkit.org/show_bug.cgi?id=127793
+
+Reviewed by Mark Hahnenberg.
+
+This was a mistaken ASSERT.
+
+* API/tests/testapi.mm:
+(-[EvilAllocationObject doEvilThingsWithContext:]): Added a test to verify
+that GC from a DelayedReleaseScope doesn't crash.
+
+* heap/DelayedReleaseScope.h:
+(JSC::DelayedReleaseScope::~DelayedReleaseScope): Our contract is that
+it is valid to do anything while running a DelayedReleaseScope -dealloc
+method, so the Heap must be ready for new allocations and collections.
+
+Change the Heap's operationInProgress value to NoOperation while running
+-dealloc methods, so that it doesn't ASSERT in the face of new allocations
+and collections.
+
+* heap/Heap.h: Made DelayedReleaseScope a friend because exposing a setter
+for m_operationInProgress seemed like the worse of the two options for
+encapsulation: we don't really want arbitrary clients to set the Heap's
+m_operationInProgress.
+
2014-01-28 Mark Lam
Jettison DFG code when neither breakpoints or the profiler are active.
Modified: trunk/Source/_javascript_Core/heap/DelayedReleaseScope.h (162967 => 162968)
--- trunk/Source/_javascript_Core/heap/DelayedReleaseScope.h 2014-01-28 23:04:56 UTC (rev 162967)
+++ trunk/Source/_javascript_Core/heap/DelayedReleaseScope.h 2014-01-28 23:12:19 UTC (rev 162968)
@@ -47,8 +47,13 @@
ASSERT(m_markedSpace.m_currentDelayedReleaseScope == this);
m_markedSpace.m_currentDelaye
[webkit-changes] [162967] trunk/Source/WebKit2
Title: [162967] trunk/Source/WebKit2
Revision 162967
Author ander...@apple.com
Date 2014-01-28 15:04:56 -0800 (Tue, 28 Jan 2014)
Log Message
Remove WebPageProxy::canGoBack and WebPageProxy::canGoForward
https://bugs.webkit.org/show_bug.cgi?id=127803
Reviewed by Andreas Kling.
* UIProcess/API/C/WKPage.cpp:
(WKPageCanGoForward):
(WKPageCanGoBack):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController canGoBack]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::sendWheelEvent):
* UIProcess/WebPageProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162966 => 162967)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 23:02:05 UTC (rev 162966)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 23:04:56 UTC (rev 162967)
@@ -1,5 +1,24 @@
2014-01-28 Anders Carlsson
+Remove WebPageProxy::canGoBack and WebPageProxy::canGoForward
+https://bugs.webkit.org/show_bug.cgi?id=127803
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageCanGoForward):
+(WKPageCanGoBack):
+* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+(-[WKBrowsingContextController canGoForward]):
+(-[WKBrowsingContextController canGoBack]):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::goForward):
+(WebKit::WebPageProxy::goBack):
+(WebKit::WebPageProxy::sendWheelEvent):
+* UIProcess/WebPageProxy.h:
+
+2014-01-28 Anders Carlsson
+
API::PolicyClient::decidePolicyForNavigationAction should take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=127798
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (162966 => 162967)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-01-28 23:02:05 UTC (rev 162966)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-01-28 23:04:56 UTC (rev 162967)
@@ -197,7 +197,7 @@
bool WKPageCanGoForward(WKPageRef pageRef)
{
-return toImpl(pageRef)->canGoForward();
+return toImpl(pageRef)->backForwardList().forwardItem();
}
void WKPageGoBack(WKPageRef pageRef)
@@ -207,7 +207,7 @@
bool WKPageCanGoBack(WKPageRef pageRef)
{
-return toImpl(pageRef)->canGoBack();
+return toImpl(pageRef)->backForwardList().backItem();
}
void WKPageGoToBackForwardListItem(WKPageRef pageRef, WKBackForwardListItemRef itemRef)
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm (162966 => 162967)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2014-01-28 23:02:05 UTC (rev 162966)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2014-01-28 23:04:56 UTC (rev 162967)
@@ -304,7 +304,7 @@
- (BOOL)canGoForward
{
-return _page->canGoForward();
+return !!_page->backForwardList().forwardItem();
}
- (void)goBack
@@ -314,7 +314,7 @@
- (BOOL)canGoBack
{
-return _page->canGoBack();
+return !!_page->backForwardList().backItem();
}
- (void)goToBackForwardListItem:(WKBackForwardListItem *)item
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (162966 => 162967)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-28 23:02:05 UTC (rev 162966)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-28 23:04:56 UTC (rev 162967)
@@ -768,9 +768,6 @@
void WebPageProxy::goForward()
{
-if (isValid() && !canGoForward())
-return;
-
WebBackForwardListItem* forwardItem = m_backForwardList->forwardItem();
if (!forwardItem)
return;
@@ -790,14 +787,9 @@
m_process->responsivenessTimer()->start();
}
-bool WebPageProxy::canGoForward() const
-{
-return m_backForwardList->forwardItem();
-}
-
void WebPageProxy::goBack()
{
-if (isValid() && !canGoBack())
+if (isValid())
return;
WebBackForwardListItem* backItem = m_backForwardList->backItem();
@@ -819,11 +811,6 @@
m_process->responsivenessTimer()->start();
}
-bool WebPageProxy::canGoBack() const
-{
-return m_backForwardList->backItem();
-}
-
void WebPageProxy::goToBackForwardItem(WebBackForwardListItem* item)
{
if (!isValid()) {
@@ -1313,8 +1300,8 @@
Messages::EventDispatcher::WheelEvent(
m_pageID,
event,
-m_useLegacyImplicitRubberBandControl ? !canGoBack() : rubberBandsAtLeft(),
-m_useLegacyImplicitRubberBandControl ? !canGoForward() : rubberBandsAtRight(),
+m_useLegacyImplicitRubberBandControl ? !m_backForwardList->backItem() : rubberBandsAtLeft(),
+m_useLegacyImplicitRubberBandCon
[webkit-changes] [162966] trunk/Source/WebInspectorUI
Title: [162966] trunk/Source/WebInspectorUI
Revision 162966
Author joep...@webkit.org
Date 2014-01-28 15:02:05 -0800 (Tue, 28 Jan 2014)
Log Message
Unreviewed follow-up to r162965. Better coding style.
Timothy Hatcher pointed out a clearer style for classes
on the is to specify body.class. I agree.
* UserInterface/DashboardView.css:
(body._javascript_ .toolbar .dashboard):
(body.web .toolbar.collapsed .dashboard > .logs):
(body._javascript_ .toolbar .dashboard > .resourcesCount):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/DashboardView.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (162965 => 162966)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 22:47:03 UTC (rev 162965)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 23:02:05 UTC (rev 162966)
@@ -1,5 +1,17 @@
2014-01-28 Joseph Pecoraro
+Unreviewed follow-up to r162965. Better coding style.
+
+Timothy Hatcher pointed out a clearer style for classes
+on the is to specify body.class. I agree.
+
+* UserInterface/DashboardView.css:
+(body._javascript_ .toolbar .dashboard):
+(body.web .toolbar.collapsed .dashboard > .logs):
+(body._javascript_ .toolbar .dashboard > .resourcesCount):
+
+2014-01-28 Joseph Pecoraro
+
Web Inspector: Tweak UI when debugging a JSContext
https://bugs.webkit.org/show_bug.cgi?id=127799
Modified: trunk/Source/WebInspectorUI/UserInterface/DashboardView.css (162965 => 162966)
--- trunk/Source/WebInspectorUI/UserInterface/DashboardView.css 2014-01-28 22:47:03 UTC (rev 162965)
+++ trunk/Source/WebInspectorUI/UserInterface/DashboardView.css 2014-01-28 23:02:05 UTC (rev 162966)
@@ -54,19 +54,19 @@
}
.toolbar.collapsed .dashboard,
-._javascript_ .toolbar .dashboard {
+body._javascript_ .toolbar .dashboard {
width: 175px;
}
-.web .toolbar.collapsed .dashboard > .time,
-.web .toolbar.collapsed .dashboard > .resourcesSize,
-.web .toolbar.collapsed .dashboard > .logs {
+body.web .toolbar.collapsed .dashboard > .time,
+body.web .toolbar.collapsed .dashboard > .resourcesSize,
+body.web .toolbar.collapsed .dashboard > .logs {
display: none;
}
-._javascript_ .toolbar .dashboard > .time,
-._javascript_ .toolbar .dashboard > .resourcesSize,
-._javascript_ .toolbar .dashboard > .resourcesCount {
+body._javascript_ .toolbar .dashboard > .time,
+body._javascript_ .toolbar .dashboard > .resourcesSize,
+body._javascript_ .toolbar .dashboard > .resourcesCount {
display: none;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162965] trunk/Source/WebInspectorUI
Title: [162965] trunk/Source/WebInspectorUI
Revision 162965
Author joep...@webkit.org
Date 2014-01-28 14:47:03 -0800 (Tue, 28 Jan 2014)
Log Message
Web Inspector: Tweak UI when debugging a JSContext
https://bugs.webkit.org/show_bug.cgi?id=127799
Reviewed by Timothy Hatcher.
* UserInterface/DashboardView.css:
(.toolbar._javascript_ .dashboard):
(.toolbar.web.collapsed .dashboard > .logs):
(.toolbar._javascript_ .dashboard > .resourcesCount):
Adjust collapsed dashboard in web and _javascript_ debugging modes.
_javascript_ debugging mode is always treated as collapsed.
* UserInterface/Main.js:
(WebInspector.contentLoaded):
Adjust what is created and shown when in _javascript_ debugging mode.
* UserInterface/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons .item.small):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
* UserInterface/TimelineSidebarPanel.css:
(.sidebar > .panel.timeline > .status-bar):
(.sidebar > .panel.timeline > .title-bar):
When _javascript_ debugging expect to put things at the root level, so hide
disclosure buttons and adjust the style so resources look nice here.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/DashboardView.css
trunk/Source/WebInspectorUI/UserInterface/Main.js
trunk/Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/TimelineSidebarPanel.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (162964 => 162965)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 22:46:43 UTC (rev 162964)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 22:47:03 UTC (rev 162965)
@@ -1,3 +1,32 @@
+2014-01-28 Joseph Pecoraro
+
+Web Inspector: Tweak UI when debugging a JSContext
+https://bugs.webkit.org/show_bug.cgi?id=127799
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/DashboardView.css:
+(.toolbar._javascript_ .dashboard):
+(.toolbar.web.collapsed .dashboard > .logs):
+(.toolbar._javascript_ .dashboard > .resourcesCount):
+Adjust collapsed dashboard in web and _javascript_ debugging modes.
+_javascript_ debugging mode is always treated as collapsed.
+
+* UserInterface/Main.js:
+(WebInspector.contentLoaded):
+Adjust what is created and shown when in _javascript_ debugging mode.
+
+* UserInterface/NavigationSidebarPanel.css:
+(.navigation-sidebar-panel-content-tree-outline.hide-disclosure-buttons .item.small):
+* UserInterface/ResourceSidebarPanel.js:
+(WebInspector.ResourceSidebarPanel):
+(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
+* UserInterface/TimelineSidebarPanel.css:
+(.sidebar > .panel.timeline > .status-bar):
+(.sidebar > .panel.timeline > .title-bar):
+When _javascript_ debugging expect to put things at the root level, so hide
+disclosure buttons and adjust the style so resources look nice here.
+
2014-01-28 Diego Pino Garcia
Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell
Modified: trunk/Source/WebInspectorUI/UserInterface/DashboardView.css (162964 => 162965)
--- trunk/Source/WebInspectorUI/UserInterface/DashboardView.css 2014-01-28 22:46:43 UTC (rev 162964)
+++ trunk/Source/WebInspectorUI/UserInterface/DashboardView.css 2014-01-28 22:47:03 UTC (rev 162965)
@@ -53,16 +53,23 @@
background-color: rgb(239, 239, 239);
}
-.toolbar.collapsed .dashboard {
+.toolbar.collapsed .dashboard,
+._javascript_ .toolbar .dashboard {
width: 175px;
}
-.toolbar.collapsed .dashboard > .time,
-.toolbar.collapsed .dashboard > .resourcesSize,
-.toolbar.collapsed .dashboard > .logs {
+.web .toolbar.collapsed .dashboard > .time,
+.web .toolbar.collapsed .dashboard > .resourcesSize,
+.web .toolbar.collapsed .dashboard > .logs {
display: none;
}
+._javascript_ .toolbar .dashboard > .time,
+._javascript_ .toolbar .dashboard > .resourcesSize,
+._javascript_ .toolbar .dashboard > .resourcesCount {
+display: none;
+}
+
.toolbar .dashboard > .item {
font-family: Helvetica, sans-serif;
font-weight: bold;
Modified: trunk/Source/WebInspectorUI/UserInterface/Main.js (162964 => 162965)
--- trunk/Source/WebInspectorUI/UserInterface/Main.js 2014-01-28 22:46:43 UTC (rev 162964)
+++ trunk/Source/WebInspectorUI/UserInterface/Main.js 2014-01-28 22:47:03 UTC (rev 162965)
@@ -37,7 +37,11 @@
DOMStorage: "dom-storage",
Resource: "resource", // includes Frame too.
Timelines: "timelines",
+};
+WebInspector.DebuggableType = {
+Web: "web",
+_javascript_: "_javascript_"
};
WebInspector.SelectedSidebarPanelCookieKey = "selected-sidebar-panel";
@@ -181,6 +185,9 @@
[webkit-changes] [162964] trunk/Source/WebKit2
Title: [162964] trunk/Source/WebKit2
Revision 162964
Author ander...@apple.com
Date 2014-01-28 14:46:43 -0800 (Tue, 28 Jan 2014)
Log Message
API::PolicyClient::decidePolicyForNavigationAction should take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=127798
Reviewed by Tim Horton.
* UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPagePolicyClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162963 => 162964)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 22:44:43 UTC (rev 162963)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 22:46:43 UTC (rev 162964)
@@ -1,5 +1,19 @@
2014-01-28 Anders Carlsson
+API::PolicyClient::decidePolicyForNavigationAction should take a NavigationActionData object
+https://bugs.webkit.org/show_bug.cgi?id=127798
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/APIPolicyClient.h:
+(API::PolicyClient::decidePolicyForNavigationAction):
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPagePolicyClient):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::decidePolicyForNavigationAction):
+
+2014-01-28 Anders Carlsson
+
Add an empty WKNavigation class
https://bugs.webkit.org/show_bug.cgi?id=127796
Modified: trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h (162963 => 162964)
--- trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h 2014-01-28 22:44:43 UTC (rev 162963)
+++ trunk/Source/WebKit2/UIProcess/API/APIPolicyClient.h 2014-01-28 22:46:43 UTC (rev 162964)
@@ -38,6 +38,7 @@
}
namespace WebKit {
+struct NavigationActionData;
class WebPageProxy;
class WebFrameProxy;
class WebFramePolicyListenerProxy;
@@ -50,7 +51,7 @@
public:
virtual ~PolicyClient() { }
-virtual void decidePolicyForNavigationAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebCore::NavigationType, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button, WebKit::WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest&, WebKit::WebFramePolicyListenerProxy* listener, API::Object* userData) { listener->use(); }
+virtual void decidePolicyForNavigationAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebKit::NavigationActionData&, WebKit::WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalRequest, const WebCore::ResourceRequest&, WebKit::WebFramePolicyListenerProxy* listener, API::Object* userData) { listener->use(); }
virtual void decidePolicyForNewWindowAction(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebCore::NavigationType, WebKit::WebEvent::Modifiers, WebKit::WebMouseEvent::Button, const WebCore::ResourceRequest&, const WTF::String& frameName, WebKit::WebFramePolicyListenerProxy* listener, API::Object* userData) { listener->use(); }
virtual void decidePolicyForResponse(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceResponse&, const WebCore::ResourceRequest&, bool canShowMIMEType, WebKit::WebFramePolicyListenerProxy* listener, API::Object* userData) { listener->use(); }
virtual void unableToImplementPolicy(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, const WebCore::ResourceError&, API::Object* userData) { }
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (162963 => 162964)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-01-28 22:44:43 UTC (rev 162963)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2014-01-28 22:46:43 UTC (rev 162964)
@@ -32,6 +32,7 @@
#include "APILoaderClient.h"
#include "APIPolicyClient.h"
#include "ImmutableDictionary.h"
+#include "NavigationActionData.h"
#include "PluginInformation.h"
#include "PrintInfo.h"
#include "WKAPICast.h"
@@ -992,7 +993,7 @@
}
private:
-virtual void decidePolicyForNavigationAction(WebPageProxy* page, WebFrameProxy* frame, WebCore::NavigationType type, WebEvent::Modifiers modifiers, WebMouseEvent::Button mouseButton, WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalResourceRequest, const WebCore::ResourceRequest& resourceRequest, WebFramePolicyListenerProxy* listener, API::Object* userData) override
+virtual void decidePolicyForNavigationAction(WebPageProxy* page, WebFrameProxy* frame, const NavigationActionData& navigationActionData, WebFrameProxy* originatingFrame, const WebCore::ResourceRequest& originalResourceRequest, const WebCore::ResourceRequest& resourceRequest, WebFramePolicyListenerProxy* listener, API::Object* userData) override
{
if (!m_client.decidePolicyForNavigationAction_deprecatedForUseWithV0 &&
[webkit-changes] [162963] trunk/LayoutTests
Title: [162963] trunk/LayoutTests Revision 162963 Author commit-qu...@webkit.org Date 2014-01-28 14:44:43 -0800 (Tue, 28 Jan 2014) Log Message Unreviewed GTK gardening. Remove failure/timeout expectations for the following passed tests: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html svg/custom/mouse-move-on-svg-container.xhtml svg/custom/mouse-move-on-svg-root.xhtml fast/css/style-scoped/style-scoped-with-dom-operation.html http/tests/download failures only affect gtk-wk1 now Report and mark flaky tests: http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html fast/parser/document-write-basic.html http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html media/crash-closing-page-with-media-as-plugin-fallback.html Add timeout to flaky test media/audio-garbage-collect.html Report and mark failed tests: accessibility/range-alter-by-percent.html media/video-restricted-no-preload-auto.html Patch by Carlos Alberto Lopez Perez on 2014-01-28 * platform/gtk/TestExpectations: * platform/gtk-wk1/TestExpectations: * platform/gtk-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wk1/TestExpectations trunk/LayoutTests/platform/gtk-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (162962 => 162963) --- trunk/LayoutTests/ChangeLog 2014-01-28 22:32:05 UTC (rev 162962) +++ trunk/LayoutTests/ChangeLog 2014-01-28 22:44:43 UTC (rev 162963) @@ -1,3 +1,33 @@ +2014-01-28 Carlos Alberto Lopez Perez + +Unreviewed GTK gardening. + +Remove failure/timeout expectations for the following passed tests: +fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html +fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html +svg/custom/mouse-move-on-svg-container.xhtml +svg/custom/mouse-move-on-svg-root.xhtml +fast/css/style-scoped/style-scoped-with-dom-operation.html + +http/tests/download failures only affect gtk-wk1 now + +Report and mark flaky tests: +http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html +fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html +fast/parser/document-write-basic.html +http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html +media/crash-closing-page-with-media-as-plugin-fallback.html + +Add timeout to flaky test media/audio-garbage-collect.html + +Report and mark failed tests: + accessibility/range-alter-by-percent.html + media/video-restricted-no-preload-auto.html + +* platform/gtk/TestExpectations: +* platform/gtk-wk1/TestExpectations: +* platform/gtk-wk2/TestExpectations: + 2014-01-28 Alexey Proskuryakov js/dom/post-message-numeric-property.html is flaky Modified: trunk/LayoutTests/platform/gtk/TestExpectations (162962 => 162963) --- trunk/LayoutTests/platform/gtk/TestExpectations 2014-01-28 22:32:05 UTC (rev 162962) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-01-28 22:44:43 UTC (rev 162963) @@ -500,6 +500,8 @@ # QuickTime plug-in not relevant to this port plugins/quicktime-plugin-replacement.html [ Skip ] +webkit.org/b/127743 media/video-restricted-no-preload-auto.html [ Failure ] + # # End of Expected failures # @@ -754,6 +756,16 @@ webkit.org/b/127280 media/audio-concurrent-supported.html [ Failure Pass ] +webkit.org/b/127682 http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html [ Failure Pass ] + +webkit.org/b/127742 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure Pass ] + +webkit.org/b/127745 fast/parser/document-write-basic.html [ Crash Pass ] + +webkit.org/b/127733 http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html [ Failure Pass ] + +webkit.org/b/127735 media/crash-closing-page-with-media-as-plugin-fallback.html [ Timeout Pass ] + # # End of Flaky tests # @@ -1175,9 +1187,6 @@ webkit.org/b/74282 editing/pasteboard/emacs-ctrl-k-with-move.html [ Failure ] -# Needs custom po
[webkit-changes] [162962] trunk/Source/WebCore
Title: [162962] trunk/Source/WebCore
Revision 162962
Author an...@apple.com
Date 2014-01-28 14:32:05 -0800 (Tue, 28 Jan 2014)
Log Message
Document::topDocument() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=127786
Reviewed by Darin Adler.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
* dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::implicitClose):
(WebCore::Document::topDocument):
(WebCore::Document::topOrigin):
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/Document.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::incrementScrollEventListenersCount):
(WebCore::DOMWindow::decrementScrollEventListenersCount):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isReplacementObscured):
* rendering/RenderView.cpp:
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (162961 => 162962)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 22:32:05 UTC (rev 162962)
@@ -1,3 +1,36 @@
+2014-01-28 Antti Koivisto
+
+Document::topDocument() should return a reference
+https://bugs.webkit.org/show_bug.cgi?id=127786
+
+Reviewed by Darin Adler.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::mainFrame):
+(WebCore::AccessibilityObject::topDocument):
+* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+(-[WebAccessibilityObjectWrapper accessibilityContainer]):
+* dom/Document.cpp:
+(WebCore::Document::~Document):
+(WebCore::Document::createRenderTree):
+(WebCore::Document::destroyRenderTree):
+(WebCore::Document::clearAXObjectCache):
+(WebCore::Document::existingAXObjectCache):
+(WebCore::Document::axObjectCache):
+(WebCore::Document::implicitClose):
+(WebCore::Document::topDocument):
+(WebCore::Document::topOrigin):
+(WebCore::Document::webkitCancelFullScreen):
+(WebCore::Document::webkitDidExitFullScreenForElement):
+* dom/Document.h:
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::incrementScrollEventListenersCount):
+(WebCore::DOMWindow::decrementScrollEventListenersCount):
+* rendering/RenderEmbeddedObject.cpp:
+(WebCore::RenderEmbeddedObject::isReplacementObscured):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
+
2014-01-28 Viatcheslav Ostapenko
Sticky positioning is broken for table rows
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (162961 => 162962)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2014-01-28 22:32:05 UTC (rev 162962)
@@ -609,11 +609,11 @@
{
Document* document = topDocument();
if (!document)
-return 0;
+return nullptr;
Frame* frame = document->frame();
if (!frame)
-return 0;
+return nullptr;
return &frame->mainFrame();
}
@@ -621,8 +621,8 @@
Document* AccessibilityObject::topDocument() const
{
if (!document())
-return 0;
-return document()->topDocument();
+return nullptr;
+return &document()->topDocument();
}
String AccessibilityObject::language() const
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (162961 => 162962)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-01-28 22:25:40 UTC (rev 162961)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-01-28 22:32:05 UTC (rev 162962)
@@ -1109,7 +1109,7 @@
// Verify this is the top document. If not, we might need to go through the platform widget.
FrameView* frameView = m_object->documentFrameView();
Document* document = m_object->document();
-if (document && frameView && document != document->topDocument())
+
[webkit-changes] [162961] trunk/LayoutTests
Title: [162961] trunk/LayoutTests Revision 162961 Author a...@apple.com Date 2014-01-28 14:25:40 -0800 (Tue, 28 Jan 2014) Log Message js/dom/post-message-numeric-property.html is flaky https://bugs.webkit.org/show_bug.cgi?id=127713 Reviewed by Geoffrey Garen. Plain testRunner and js-test-post.js approaches to being asynchronous don't work together, you need one or the other. * js/dom/post-message-numeric-property-expected.txt: * js/dom/script-tests/post-message-numeric-property.js: Updated to use jsTestIsAsync, as the wrapper includes js-test-post.js. The results are now always printed in correct order, not flakily. * js/dom/cross-global-object-inline-global-var-expected.txt: * js/dom/script-tests/cross-global-object-inline-global-var.js: Ditto. * js/dom/function-prototype.html: * js/dom/parse-error-external-script-in-eval.html: * js/dom/parse-error-external-script-in-new-Function.html: * js/dom/parse-syntax-error-in-initializer.html: Removed waitUntilDone, these tests are not asynchronous at all. * js/dom/script-tests/cross-frame-bad-time.js: * js/dom/script-tests/cross-frame-really-bad-time-with-__proto__.js: * js/dom/script-tests/cross-frame-really-bad-time.js: Updated to use jsTestIsAsync. These tests were not flaky because they happened to run synchronously in practice, but document.writing a script into subframe won't necessarily execute it synchronously in the future. * js/resources/fs-test-post.js: Removed. This file was unused. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/js/dom/cross-global-object-inline-global-var-expected.txt trunk/LayoutTests/js/dom/function-prototype.html trunk/LayoutTests/js/dom/parse-error-external-script-in-eval.html trunk/LayoutTests/js/dom/parse-error-external-script-in-new-Function.html trunk/LayoutTests/js/dom/parse-syntax-error-in-initializer.html trunk/LayoutTests/js/dom/post-message-numeric-property-expected.txt trunk/LayoutTests/js/dom/script-tests/cross-frame-bad-time.js trunk/LayoutTests/js/dom/script-tests/cross-frame-really-bad-time-with-__proto__.js trunk/LayoutTests/js/dom/script-tests/cross-frame-really-bad-time.js trunk/LayoutTests/js/dom/script-tests/cross-global-object-inline-global-var.js trunk/LayoutTests/js/dom/script-tests/post-message-numeric-property.js Removed Paths trunk/LayoutTests/js/resources/fs-test-post.js Diff Modified: trunk/LayoutTests/ChangeLog (162960 => 162961) --- trunk/LayoutTests/ChangeLog 2014-01-28 22:21:47 UTC (rev 162960) +++ trunk/LayoutTests/ChangeLog 2014-01-28 22:25:40 UTC (rev 162961) @@ -1,3 +1,37 @@ +2014-01-28 Alexey Proskuryakov + +js/dom/post-message-numeric-property.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=127713 + +Reviewed by Geoffrey Garen. + +Plain testRunner and js-test-post.js approaches to being asynchronous don't work +together, you need one or the other. + +* js/dom/post-message-numeric-property-expected.txt: +* js/dom/script-tests/post-message-numeric-property.js: +Updated to use jsTestIsAsync, as the wrapper includes js-test-post.js. The results +are now always printed in correct order, not flakily. + +* js/dom/cross-global-object-inline-global-var-expected.txt: +* js/dom/script-tests/cross-global-object-inline-global-var.js: +Ditto. + +* js/dom/function-prototype.html: +* js/dom/parse-error-external-script-in-eval.html: +* js/dom/parse-error-external-script-in-new-Function.html: +* js/dom/parse-syntax-error-in-initializer.html: +Removed waitUntilDone, these tests are not asynchronous at all. + +* js/dom/script-tests/cross-frame-bad-time.js: +* js/dom/script-tests/cross-frame-really-bad-time-with-__proto__.js: +* js/dom/script-tests/cross-frame-really-bad-time.js: +Updated to use jsTestIsAsync. These tests were not flaky because they happened to +run synchronously in practice, but document.writing a script into subframe won't +necessarily execute it synchronously in the future. + +* js/resources/fs-test-post.js: Removed. This file was unused. + 2014-01-28 Viatcheslav Ostapenko Sticky positioning is broken for table rows Modified: trunk/LayoutTests/js/dom/cross-global-object-inline-global-var-expected.txt (162960 => 162961) --- trunk/LayoutTests/js/dom/cross-global-object-inline-global-var-expected.txt 2014-01-28 22:21:47 UTC (rev 162960) +++ trunk/LayoutTests/js/dom/cross-global-object-inline-global-var-expected.txt 2014-01-28 22:25:40 UTC (rev 162961) @@ -4,8 +4,8 @@ PASS foo(3) is 324 +PASS done() called with 5770500 PASS successfullyParsed is true TEST COMPLETE -PASS done() called with 5770500 Modified: trunk/LayoutTests/js/dom/function-prototype.html (162960 => 162961) --- trunk/LayoutTests/js/dom/function-prototype.html 2014-01-28 22:21:47 UTC (rev 162960) +++ trunk/LayoutTests/js/dom/function-prototype.html 2014-01-28 22:2
[webkit-changes] [162960] trunk
Title: [162960] trunk
Revision 162960
Author commit-qu...@webkit.org
Date 2014-01-28 14:21:47 -0800 (Tue, 28 Jan 2014)
Log Message
Sticky positioning is broken for table rows
https://bugs.webkit.org/show_bug.cgi?id=112024
Patch by Viatcheslav Ostapenko on 2014-01-28
Reviewed by Simon Fraser.
Source/WebCore:
Enable sticky positioning for table elements.
Also includes fix for bug wkb.ug/105654
I don't have access to this bug, but from related commit message I
assume it says about "Heap use after free problem".
Debugging showed that it wasn't heap use after free.
The real problem that RenderObject::container() returns object which is
not RenderBlock and it is used as RenderBlock in
RenderBox::containingBlockLogicalHeightForPositioned() method.
Added extra isRenderBlock check and search for containingBlock if
current block is not RenderBlock.
Tests: fast/css/sticky/sticky-table-row-top.html
fast/css/sticky/sticky-table-thead-top.html
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
* rendering/RenderTableRow.h:
LayoutTests:
Add layout tests for sticky positioned table row and table thead.
* fast/css/sticky/sticky-table-row-top-expected.html: Added.
* fast/css/sticky/sticky-table-row-top.html: Added.
* fast/css/sticky/sticky-table-thead-top-expected.html: Added.
* fast/css/sticky/sticky-table-thead-top.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderTableRow.h
Added Paths
trunk/LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html
trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html
trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top-expected.html
trunk/LayoutTests/fast/css/sticky/sticky-table-thead-top.html
Diff
Modified: trunk/LayoutTests/ChangeLog (162959 => 162960)
--- trunk/LayoutTests/ChangeLog 2014-01-28 22:20:04 UTC (rev 162959)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 22:21:47 UTC (rev 162960)
@@ -1,3 +1,17 @@
+2014-01-28 Viatcheslav Ostapenko
+
+Sticky positioning is broken for table rows
+https://bugs.webkit.org/show_bug.cgi?id=112024
+
+Reviewed by Simon Fraser.
+
+Add layout tests for sticky positioned table row and table thead.
+
+* fast/css/sticky/sticky-table-row-top-expected.html: Added.
+* fast/css/sticky/sticky-table-row-top.html: Added.
+* fast/css/sticky/sticky-table-thead-top-expected.html: Added.
+* fast/css/sticky/sticky-table-thead-top.html: Added.
+
2014-01-28 Myles C. Maxfield
Fixing several incorrect assumptions with handling isolated inlines.
Added: trunk/LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html (0 => 162960)
--- trunk/LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/sticky/sticky-table-row-top-expected.html 2014-01-28 22:21:47 UTC (rev 162960)
@@ -0,0 +1,69 @@
+
+
+
+
+
+body {
+margin: 0;
+height: 2000px;
+overflow: hidden; /* hide scrollbars */
+}
+
+.group {
+display: inline-block;
+position: relative;
+width: 250px;
+height: 500px;
+}
+
+.container {
+width: 200px;
+height: 400px;
+outline: 2px solid black;
+}
+
+.box {
+width: 200px;
+height: 200px;
+}
+
+.sticky {
+position: absolute;
+background-color: green;
+}
+
+.indicator {
+position: absolute;
+top: 0;
+left: 0;
+background-color: red;
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+This test checks that sticky positioned table rows are contained by their table.
+There should be no red.
+
+
+
Added: trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html (0 => 162960)
--- trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html (rev 0)
+++ trunk/LayoutTests/fast/css/sticky/sticky-table-row-top.html 2014-01-28 22:21:47 UTC (rev 162960)
@@ -0,0 +1,105 @@
+
+
+
+
+
+body {
+margin: 0;
+height: 2000px;
+overflow: hidden; /* hide scrollbars */
+}
+
+.group {
+display: inline-block;
+position: relative;
+width: 250px;
+height: 500px;
+}
+
+.container {
+width: 200px;
+height: 400px;
+outline: 2px solid black;
+border: hidden;
+border-width: 0px;
+border-spacing: 0px !important;
+border-collapse:collapse;
+cellspacing: 0;
+cellpadding: 0;
+padding: 0;
+}
+
+.box {
+width: 200
[webkit-changes] [162959] trunk/Source/WebKit2
Title: [162959] trunk/Source/WebKit2 Revision 162959 Author ander...@apple.com Date 2014-01-28 14:20:04 -0800 (Tue, 28 Jan 2014) Log Message Add an empty WKNavigation class https://bugs.webkit.org/show_bug.cgi?id=127796 Reviewed by Tim Horton. * UIProcess/API/Cocoa/WKNavigation.h: Added. * UIProcess/API/Cocoa/WKNavigation.mm: Added. * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (162958 => 162959) --- trunk/Source/WebKit2/ChangeLog 2014-01-28 22:10:30 UTC (rev 162958) +++ trunk/Source/WebKit2/ChangeLog 2014-01-28 22:20:04 UTC (rev 162959) @@ -1,5 +1,16 @@ 2014-01-28 Anders Carlsson +Add an empty WKNavigation class +https://bugs.webkit.org/show_bug.cgi?id=127796 + +Reviewed by Tim Horton. + +* UIProcess/API/Cocoa/WKNavigation.h: Added. +* UIProcess/API/Cocoa/WKNavigation.mm: Added. +* WebKit2.xcodeproj/project.pbxproj: + +2014-01-28 Anders Carlsson + Add a NavigationActionData object for easy storage of navigation action data https://bugs.webkit.org/show_bug.cgi?id=127787 Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h (0 => 162959) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h (rev 0) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h 2014-01-28 22:20:04 UTC (rev 162959) @@ -0,0 +1,36 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +#import +#import + +#if WK_API_ENABLED + +WK_API_CLASS +@interface WKNavigation : NSObject + +@end + +#endif Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm (0 => 162959) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm (rev 0) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm 2014-01-28 22:20:04 UTC (rev 162959) @@ -0,0 +1,35 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "config.h" +#include "WKNavigation.h" + +#if WK_API_ENABLED + +@implementation WKNavigation + +@end + +#endif Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (162958 => 1629
[webkit-changes] [162958] branches/jsCStack/Source/JavaScriptCore
Title: [162958] branches/jsCStack/Source/_javascript_Core Revision 162958 Author fpi...@apple.com Date 2014-01-28 14:10:30 -0800 (Tue, 28 Jan 2014) Log Message Arity fixup clobbers callee-saves, causing FTL->FTL arity fixed-up calls to corrupt state https://bugs.webkit.org/show_bug.cgi?id=127791 Reviewed by Michael Saboff. Make the 64-bit path - i.e. the only path where the FTL matters - use regT6 instead of regT3. regT6 is not a callee save. * jit/ThunkGenerators.cpp: (JSC::arityFixup): * tests/stress/ftl-to-ftl-arity-fixup.js: Added. (foo): (bar): Modified Paths branches/jsCStack/Source/_javascript_Core/ChangeLog branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp Added Paths branches/jsCStack/Source/_javascript_Core/tests/stress/ftl-to-ftl-arity-fixup.js Diff Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162957 => 162958) --- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 22:03:57 UTC (rev 162957) +++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 22:10:30 UTC (rev 162958) @@ -1,5 +1,21 @@ 2014-01-28 Filip Pizlo +Arity fixup clobbers callee-saves, causing FTL->FTL arity fixed-up calls to corrupt state +https://bugs.webkit.org/show_bug.cgi?id=127791 + +Reviewed by Michael Saboff. + +Make the 64-bit path - i.e. the only path where the FTL matters - use regT6 instead +of regT3. regT6 is not a callee save. + +* jit/ThunkGenerators.cpp: +(JSC::arityFixup): +* tests/stress/ftl-to-ftl-arity-fixup.js: Added. +(foo): +(bar): + +2014-01-28 Filip Pizlo + FTL should really, *really* support NotCellUse https://bugs.webkit.org/show_bug.cgi?id=127790 Modified: branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp (162957 => 162958) --- branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-01-28 22:03:57 UTC (rev 162957) +++ branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2014-01-28 22:10:30 UTC (rev 162958) @@ -435,15 +435,15 @@ # endif jit.lshift32(JSInterfaceJIT::TrustedImm32(logStackAlignmentRegisters()), JSInterfaceJIT::regT0); jit.neg64(JSInterfaceJIT::regT0); -jit.move(JSInterfaceJIT::callFrameRegister, JSInterfaceJIT::regT3); +jit.move(JSInterfaceJIT::callFrameRegister, JSInterfaceJIT::regT6); jit.load32(JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister, JSStack::ArgumentCount * sizeof(Register)), JSInterfaceJIT::regT2); jit.add32(JSInterfaceJIT::TrustedImm32(JSStack::CallFrameHeaderSize), JSInterfaceJIT::regT2); // Move current frame down regT0 number of slots JSInterfaceJIT::Label copyLoop(jit.label()); -jit.load64(JSInterfaceJIT::regT3, JSInterfaceJIT::regT1); -jit.store64(JSInterfaceJIT::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT3, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); -jit.addPtr(JSInterfaceJIT::TrustedImm32(8), JSInterfaceJIT::regT3); +jit.load64(JSInterfaceJIT::regT6, JSInterfaceJIT::regT1); +jit.store64(JSInterfaceJIT::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT6, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); +jit.addPtr(JSInterfaceJIT::TrustedImm32(8), JSInterfaceJIT::regT6); jit.branchSub32(MacroAssembler::NonZero, JSInterfaceJIT::TrustedImm32(1), JSInterfaceJIT::regT2).linkTo(copyLoop, &jit); // Fill in regT0 - 1 missing arg slots with undefined @@ -451,8 +451,8 @@ jit.move(JSInterfaceJIT::TrustedImm64(ValueUndefined), JSInterfaceJIT::regT1); jit.add32(JSInterfaceJIT::TrustedImm32(1), JSInterfaceJIT::regT2); JSInterfaceJIT::Label fillUndefinedLoop(jit.label()); -jit.store64(JSInterfaceJIT::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT3, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); -jit.addPtr(JSInterfaceJIT::TrustedImm32(8), JSInterfaceJIT::regT3); +jit.store64(JSInterfaceJIT::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT6, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); +jit.addPtr(JSInterfaceJIT::TrustedImm32(8), JSInterfaceJIT::regT6); jit.branchAdd32(MacroAssembler::NonZero, JSInterfaceJIT::TrustedImm32(1), JSInterfaceJIT::regT2).linkTo(fillUndefinedLoop, &jit); // Adjust call frame register and stack pointer to account for missing args @@ -463,7 +463,7 @@ // Save the original return PC. jit.loadPtr(JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister, CallFrame::returnPCOffset()), GPRInfo::regT1); -jit.storePtr(GPRInfo::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT3, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); +jit.storePtr(GPRInfo::regT1, MacroAssembler::BaseIndex(JSInterfaceJIT::regT6, JSInterfaceJIT::regT0, JSInterfaceJIT::TimesEight)); // Install the new return PC. jit.storePtr(GPRInfo::regT5, JSInterfaceJIT::Address(JSInterfaceJIT::callFrameRegister, CallFrame::returnPCOffset
[webkit-changes] [162957] trunk/Source/WebCore
Title: [162957] trunk/Source/WebCore
Revision 162957
Author mmaxfi...@apple.com
Date 2014-01-28 14:03:57 -0800 (Tue, 28 Jan 2014)
Log Message
Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608
Reviewed by Simon Fraser.
Fixing capitalization.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setUpResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (162956 => 162957)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 21:53:22 UTC (rev 162956)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 22:03:57 UTC (rev 162957)
@@ -3,6 +3,19 @@
Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608
+Reviewed by Simon Fraser.
+
+Fixing capitalization.
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::setUpResolverToResumeInIsolate):
+(WebCore::constructBidiRunsForSegment):
+
+2014-01-28 Myles C. Maxfield
+
+Fixing several incorrect assumptions with handling isolated inlines.
+https://bugs.webkit.org/show_bug.cgi?id=127608
+
Reviewed by Dave Hyatt.
First, when an isolated inline spans multiple lines, we aren't guaranteed
Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (162956 => 162957)
--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 21:53:22 UTC (rev 162956)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2014-01-28 22:03:57 UTC (rev 162957)
@@ -872,11 +872,11 @@
lastRootBox()->appendFloat(floatingObject->renderer());
}
-static inline void setupResolverToResumeInIsolate(InlineBidiResolver& resolver, RenderObject* root, RenderObject* startObject)
+static inline void setUpResolverToResumeInIsolate(InlineBidiResolver& resolver, RenderObject* root, RenderObject* startObject)
{
if (root != startObject) {
RenderObject* parent = startObject->parent();
-setupResolverToResumeInIsolate(resolver, root, parent);
+setUpResolverToResumeInIsolate(resolver, root, parent);
notifyObserverEnteredObject(&resolver, startObject);
}
}
@@ -915,7 +915,7 @@
}
isolatedResolver.setStatus(BidiStatus(direction, isOverride(unicodeBidi)));
-setupResolverToResumeInIsolate(isolatedResolver, isolatedInline, &startObj);
+setUpResolverToResumeInIsolate(isolatedResolver, isolatedInline, &startObj);
// The starting position is the beginning of the first run within the isolate that was identified
// during the earlier call to createBidiRunsForLine. This can be but is not necessarily the
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162956] trunk
Title: [162956] trunk
Revision 162956
Author mmaxfi...@apple.com
Date 2014-01-28 13:53:22 -0800 (Tue, 28 Jan 2014)
Log Message
Fixing several incorrect assumptions with handling isolated inlines.
https://bugs.webkit.org/show_bug.cgi?id=127608
Reviewed by Dave Hyatt.
Source/WebCore:
First, when an isolated inline spans multiple lines, we aren't guaranteed
to exit BidiResolver with a nested inline count of zero. Removing the
assert that says otherwise.
Previously in constructBidiRunsForSegment, we called bidiFirst in
an attempt to properly setup the isolatedResolver for any dom/style
that applied, but this only worked on the first line the isolated
inline appeared in. Adding a function that approaches this properly
by recursing through the parents of the starting object for the line
and post-fixing direction attributes to the resolver.
Finally, addressing an issue where the line following a removed isolated
inline (with a continuation) failed to be marked dirty.
Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/72698f203b1c50900e535b80945563b92b7eef23
Tests: fast/text/nested-bidi-assert.html
fast/text/nested-bidi-with-continuation-crash.html
* platform/text/BidiResolver.h:
(WebCore::Run>::~BidiResolver):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setupResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
LayoutTests:
See file-specific info.
Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/72698f203b1c50900e535b80945563b92b7eef23
* fast/text/nested-bidi-assert-expected.txt: Added.
* fast/text/nested-bidi-assert.html: Added. Tests that no crash occurs
when an isolated inline spans several lines
* fast/text/nested-bidi-with-continuation-crash-expected.txt: Added.
* fast/text/nested-bidi-with-continuation-crash.html: Added. Tests that
no crash occurs when additional isolates need to be set up for a
continuation
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/BidiResolver.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderLineBoxList.cpp
Added Paths
trunk/LayoutTests/fast/text/nested-bidi-assert-expected.txt
trunk/LayoutTests/fast/text/nested-bidi-assert.html
trunk/LayoutTests/fast/text/nested-bidi-with-continuation-crash-expected.txt
trunk/LayoutTests/fast/text/nested-bidi-with-continuation-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (162955 => 162956)
--- trunk/LayoutTests/ChangeLog 2014-01-28 21:42:37 UTC (rev 162955)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 21:53:22 UTC (rev 162956)
@@ -1,3 +1,22 @@
+2014-01-28 Myles C. Maxfield
+
+Fixing several incorrect assumptions with handling isolated inlines.
+https://bugs.webkit.org/show_bug.cgi?id=127608
+
+Reviewed by Dave Hyatt.
+
+See file-specific info.
+
+Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/72698f203b1c50900e535b80945563b92b7eef23
+
+* fast/text/nested-bidi-assert-expected.txt: Added.
+* fast/text/nested-bidi-assert.html: Added. Tests that no crash occurs
+when an isolated inline spans several lines
+* fast/text/nested-bidi-with-continuation-crash-expected.txt: Added.
+* fast/text/nested-bidi-with-continuation-crash.html: Added. Tests that
+no crash occurs when additional isolates need to be set up for a
+continuation
+
2014-01-28 Antti Koivisto
Rebase fast/repaint/background-shorthand-with-gradient-and-height-changes.html after https://trac.webkit.org/r162947
Added: trunk/LayoutTests/fast/text/nested-bidi-assert-expected.txt (0 => 162956)
--- trunk/LayoutTests/fast/text/nested-bidi-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/nested-bidi-assert-expected.txt 2014-01-28 21:53:22 UTC (rev 162956)
@@ -0,0 +1 @@
+Test passes if there are no asserts in debug builds.
Added: trunk/LayoutTests/fast/text/nested-bidi-assert.html (0 => 162956)
--- trunk/LayoutTests/fast/text/nested-bidi-assert.html (rev 0)
+++ trunk/LayoutTests/fast/text/nested-bidi-assert.html 2014-01-28 21:53:22 UTC (rev 162956)
@@ -0,0 +1,10 @@
+
+foobarbaz
+Test passes if there are no asserts in debug builds.
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+var div = document.getElementById("test");
+div.offsetTop;
+div.parentNode.removeChild(div);
+
\ No newline at end of file
Added: trunk/LayoutTests/fast/text/nested-bidi-with-continuation-crash-expected.txt (0 => 162956)
--- trunk/LayoutTests/fast/text/nested-bidi-with-continuation-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/nested-bidi-with-continuation-crash-expected.txt 2014-01-28 21:53:22 UTC (rev 162956)
@@ -0,0 +1 @@
+Test passes if no crashes with asan.
Added: trunk/LayoutTes
[webkit-changes] [162955] branches/jsCStack/Source/JavaScriptCore
Title: [162955] branches/jsCStack/Source/_javascript_Core
Revision 162955
Author fpi...@apple.com
Date 2014-01-28 13:42:37 -0800 (Tue, 28 Jan 2014)
Log Message
FTL should really, *really* support NotCellUse
https://bugs.webkit.org/show_bug.cgi?id=127790
Reviewed by Mark Hahnenberg.
It's easy to forget about Phantoms. Any use kind that appears in any node can
eventually appear in a Phantom. This was covered by Octane/mandreel.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162954 => 162955)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 21:37:12 UTC (rev 162954)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 21:42:37 UTC (rev 162955)
@@ -1,5 +1,19 @@
2014-01-28 Filip Pizlo
+FTL should really, *really* support NotCellUse
+https://bugs.webkit.org/show_bug.cgi?id=127790
+
+Reviewed by Mark Hahnenberg.
+
+It's easy to forget about Phantoms. Any use kind that appears in any node can
+eventually appear in a Phantom. This was covered by Octane/mandreel.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::LowerDFGToLLVM::speculate):
+(JSC::FTL::LowerDFGToLLVM::speculateNotCell):
+
+2014-01-28 Filip Pizlo
+
FTL should really support NotCellUse
https://bugs.webkit.org/show_bug.cgi?id=127789
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (162954 => 162955)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-28 21:37:12 UTC (rev 162954)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2014-01-28 21:42:37 UTC (rev 162955)
@@ -4315,6 +4315,9 @@
case BooleanUse:
speculateBoolean(edge);
break;
+case NotCellUse:
+speculateNotCell(edge);
+break;
default:
dataLog("Unsupported speculation use kind: ", edge.useKind(), "\n");
RELEASE_ASSERT_NOT_REACHED();
@@ -4590,6 +4593,15 @@
lowBoolean(edge);
}
+void speculateNotCell(Edge edge)
+{
+if (!m_interpreter.needsTypeCheck(edge))
+return;
+
+LValue value = lowJSValue(edge);
+typeCheck(jsValueValue(value), edge, ~SpecCell, isCell(value));
+}
+
bool masqueradesAsUndefinedWatchpointIsStillValid()
{
return m_graph.masqueradesAsUndefinedWatchpointIsStillValid(m_node->codeOrigin);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162954] trunk/LayoutTests
Title: [162954] trunk/LayoutTests
Revision 162954
Author an...@apple.com
Date 2014-01-28 13:37:12 -0800 (Tue, 28 Jan 2014)
Log Message
Rebase fast/repaint/background-shorthand-with-gradient-and-height-changes.html after https://trac.webkit.org/r162947
* fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
* fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt
trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html
Diff
Modified: trunk/LayoutTests/ChangeLog (162953 => 162954)
--- trunk/LayoutTests/ChangeLog 2014-01-28 21:31:17 UTC (rev 162953)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 21:37:12 UTC (rev 162954)
@@ -1,5 +1,12 @@
2014-01-28 Antti Koivisto
+Rebase fast/repaint/background-shorthand-with-gradient-and-height-changes.html after https://trac.webkit.org/r162947
+
+* fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
+* fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
+
+2014-01-28 Antti Koivisto
+
Rebaseline some repaint test results after https://trac.webkit.org/r162947
There are less repaint rects.
Modified: trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt (162953 => 162954)
--- trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt 2014-01-28 21:31:17 UTC (rev 162953)
+++ trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt 2014-01-28 21:37:12 UTC (rev 162954)
@@ -3,8 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS repaintRects.indexOf('28 84') is not -1
-PASS repaintRects.indexOf('8 84') is not -1
+PASS repaintRects.indexOf('8 84 40 220') is not -1
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html (162953 => 162954)
--- trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html 2014-01-28 21:31:17 UTC (rev 162953)
+++ trunk/LayoutTests/fast/repaint/background-shorthand-with-gradient-and-height-changes.html 2014-01-28 21:37:12 UTC (rev 162954)
@@ -58,11 +58,10 @@
function logRepaints() {
if (!window.internals)
return;
-
+
repaintRects = window.internals.repaintRectsAsText();
window.internals.stopTrackingRepaints();
-shouldNotBe("repaintRects.indexOf('28 84')", "-1");
-shouldNotBe("repaintRects.indexOf('8 84')", "-1");
+shouldNotBe("repaintRects.indexOf('8 84 40 220')", "-1");
finishJSTest();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162953] branches/jsCStack/Source/JavaScriptCore
Title: [162953] branches/jsCStack/Source/_javascript_Core
Revision 162953
Author fpi...@apple.com
Date 2014-01-28 13:31:17 -0800 (Tue, 28 Jan 2014)
Log Message
FTL should really support NotCellUse
https://bugs.webkit.org/show_bug.cgi?id=127789
Reviewed by Mark Hahnenberg.
This is for ValueToInt32(NotCell:). That support was added ages ago, and it even
works as demonstrated by the new test case.
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* tests/stress/not-cell-use.js: Added.
(foo):
(bar):
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp
Added Paths
branches/jsCStack/Source/_javascript_Core/tests/stress/not-cell-use.js
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162952 => 162953)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 21:26:23 UTC (rev 162952)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 21:31:17 UTC (rev 162953)
@@ -1,3 +1,19 @@
+2014-01-28 Filip Pizlo
+
+FTL should really support NotCellUse
+https://bugs.webkit.org/show_bug.cgi?id=127789
+
+Reviewed by Mark Hahnenberg.
+
+This is for ValueToInt32(NotCell:). That support was added ages ago, and it even
+works as demonstrated by the new test case.
+
+* ftl/FTLCapabilities.cpp:
+(JSC::FTL::canCompile):
+* tests/stress/not-cell-use.js: Added.
+(foo):
+(bar):
+
2014-01-28 Michael Saboff
CStack Branch: Some LLInt symbols not declared extern "C"
Modified: branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp (162952 => 162953)
--- branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-28 21:26:23 UTC (rev 162952)
+++ branches/jsCStack/Source/_javascript_Core/ftl/FTLCapabilities.cpp 2014-01-28 21:31:17 UTC (rev 162953)
@@ -305,6 +305,7 @@
case StringObjectUse:
case StringOrStringObjectUse:
case FinalObjectUse:
+case NotCellUse:
// These are OK.
break;
default:
Added: branches/jsCStack/Source/_javascript_Core/tests/stress/not-cell-use.js (0 => 162953)
--- branches/jsCStack/Source/_javascript_Core/tests/stress/not-cell-use.js (rev 0)
+++ branches/jsCStack/Source/_javascript_Core/tests/stress/not-cell-use.js 2014-01-28 21:31:17 UTC (rev 162953)
@@ -0,0 +1,29 @@
+function foo(a, b, c) {
+return (a|0) + (b|0) + (c|0);
+}
+
+function bar(o) {
+var a = o.f;
+var b = o.g;
+var c = o.h;
+var d = o.i;
+var e = o.j;
+var f = o.k;
+var g = o.l;
+return foo(42, void 0, void 0) + a + b + c + d + e + f + g;
+}
+
+noInline(foo);
+noInline(bar);
+
+for (var i = 0; i < 10; ++i) {
+var result = bar({
+f:i * 3, g:i - 1, h:(i / 2)|0, i:-i, j:13 + ((i / 5)|0), k:14 - ((i / 6)|0),
+l:1 - i});
+
+var expected = 42 + i * 3 + i - 1 + ((i / 2)|0) - i + 13 + ((i / 5)|0) + 14 -
+((i / 6)|0) + 1 - i;
+
+if (result != expected)
+throw "Error: for iteration " + i + " expected " + expected + " but got " + result;
+}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162952] trunk/LayoutTests
Title: [162952] trunk/LayoutTests Revision 162952 Author an...@apple.com Date 2014-01-28 13:26:23 -0800 (Tue, 28 Jan 2014) Log Message Rebaseline some repaint test results after https://trac.webkit.org/r162947 There are less repaint rects. * compositing/repaint/resize-repaint-expected.txt: * fast/box-shadow/shadow-repaint-expected.txt: * fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: * fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: * fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: * fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: * fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt: * fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt: * fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt: * fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt: * fast/regions/repaint/invalid-region-repaint-crash-expected.txt: * fast/regions/repaint/repaint-element-inside-relative-region-expected.txt: * fast/regions/repaint/repaint-regions-overflow-expected.txt: * fast/repaint/horizontal-bt-overflow-child-expected.txt: * fast/repaint/horizontal-bt-overflow-parent-expected.txt: * fast/repaint/horizontal-bt-overflow-same-expected.txt: * fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: * fast/repaint/overflow-flipped-writing-mode-table-expected.txt: * fast/repaint/reflection-table-layout-expected.txt: * fast/repaint/transform-table-layout-expected.txt: * fast/repaint/vertical-overflow-child-expected.txt: * fast/repaint/vertical-overflow-parent-expected.txt: * fast/repaint/vertical-overflow-same-expected.txt: * platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: * platform/mac/fast/images/repaint-subrect-grid-expected.txt: * svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/compositing/repaint/resize-repaint-expected.txt trunk/LayoutTests/fast/box-shadow/shadow-repaint-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt trunk/LayoutTests/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt trunk/LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt trunk/LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt trunk/LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt trunk/LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt trunk/LayoutTests/fast/regions/repaint/invalid-region-repaint-crash-expected.txt trunk/LayoutTests/fast/regions/repaint/repaint-element-inside-relative-region-expected.txt trunk/LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt trunk/LayoutTests/fast/repaint/horizontal-bt-overflow-child-expected.txt trunk/LayoutTests/fast/repaint/horizontal-bt-overflow-parent-expected.txt trunk/LayoutTests/fast/repaint/horizontal-bt-overflow-same-expected.txt trunk/LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt trunk/LayoutTests/fast/repaint/overflow-flipped-writing-mode-table-expected.txt trunk/LayoutTests/fast/repaint/reflection-table-layout-expected.txt trunk/LayoutTests/fast/repaint/transform-table-layout-expected.txt trunk/LayoutTests/fast/repaint/vertical-overflow-child-expected.txt trunk/LayoutTests/fast/repaint/vertical-overflow-parent-expected.txt trunk/LayoutTests/fast/repaint/vertical-overflow-same-expected.txt trunk/LayoutTests/platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt trunk/LayoutTests/platform/mac/fast/images/repaint-subrect-grid-expected.txt trunk/LayoutTests/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (162951 => 162952) --- trunk/LayoutTests/ChangeLog 2014-01-28 21:15:23 UTC (rev 162951) +++ trunk/LayoutTests/ChangeLog 2014-01-28 21:26:23 UTC (rev 162952) @@ -1,3 +1,36 @@ +2014-01-28 Antti Koivisto + +Rebaseline some repaint test results after https://trac.webkit.org/r162947 + +There are less repaint rects. + +* compositing/repaint/resize-repaint-expected.txt: +* fast/box-shadow/shadow-repaint-expected.txt: +* fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: +* fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: +* fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: +* fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: +* fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt: +* fast/regions/repaint/element-
[webkit-changes] [162951] trunk/Source/WebKit2
Title: [162951] trunk/Source/WebKit2 Revision 162951 Author ander...@apple.com Date 2014-01-28 13:15:23 -0800 (Tue, 28 Jan 2014) Log Message Add a NavigationActionData object for easy storage of navigation action data https://bugs.webkit.org/show_bug.cgi?id=127787 Reviewed by Tim Horton. * Scripts/webkit2/messages.py: (struct_or_class): * Shared/NavigationActionData.cpp: Added. (WebKit::NavigationActionData::NavigationActionData): (WebKit::NavigationActionData::encode): (WebKit::NavigationActionData::decode): * Shared/NavigationActionData.h: Added. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * WebKit2.xcodeproj/project.pbxproj: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Scripts/webkit2/messages.py trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Added Paths trunk/Source/WebKit2/Shared/NavigationActionData.cpp trunk/Source/WebKit2/Shared/NavigationActionData.h Diff Modified: trunk/Source/WebKit2/ChangeLog (162950 => 162951) --- trunk/Source/WebKit2/ChangeLog 2014-01-28 20:49:49 UTC (rev 162950) +++ trunk/Source/WebKit2/ChangeLog 2014-01-28 21:15:23 UTC (rev 162951) @@ -1,3 +1,27 @@ +2014-01-28 Anders Carlsson + +Add a NavigationActionData object for easy storage of navigation action data +https://bugs.webkit.org/show_bug.cgi?id=127787 + +Reviewed by Tim Horton. + +* Scripts/webkit2/messages.py: +(struct_or_class): +* Shared/NavigationActionData.cpp: Added. +(WebKit::NavigationActionData::NavigationActionData): +(WebKit::NavigationActionData::encode): +(WebKit::NavigationActionData::decode): +* Shared/NavigationActionData.h: Added. +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::decidePolicyForNavigationAction): +(WebKit::WebPageProxy::decidePolicyForNewWindowAction): +* UIProcess/WebPageProxy.h: +* UIProcess/WebPageProxy.messages.in: +* WebKit2.xcodeproj/project.pbxproj: +* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: +(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): +(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): + 2014-01-28 Tim Horton Fix the Mountain Lion build. Modified: trunk/Source/WebKit2/Scripts/webkit2/messages.py (162950 => 162951) --- trunk/Source/WebKit2/Scripts/webkit2/messages.py 2014-01-28 20:49:49 UTC (rev 162950) +++ trunk/Source/WebKit2/Scripts/webkit2/messages.py 2014-01-28 21:15:23 UTC (rev 162951) @@ -212,6 +212,7 @@ 'WebKit::DrawingAreaInfo', 'WebKit::EditorState', 'WebKit::InteractionInformationAtPosition', +'WebKit::NavigationActionData', 'WebKit::NetworkProcessCreationParameters', 'WebKit::PlatformPopupMenuData', 'WebKit::PluginCreationParameters', Added: trunk/Source/WebKit2/Shared/NavigationActionData.cpp (0 => 162951) --- trunk/Source/WebKit2/Shared/NavigationActionData.cpp (rev 0) +++ trunk/Source/WebKit2/Shared/NavigationActionData.cpp 2014-01-28 21:15:23 UTC (rev 162951) @@ -0,0 +1,60 @@ +/* + * Copyright (C) 2014 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + *
[webkit-changes] [162950] trunk/Source/WebKit2
Title: [162950] trunk/Source/WebKit2
Revision 162950
Author timothy_hor...@apple.com
Date 2014-01-28 12:49:49 -0800 (Tue, 28 Jan 2014)
Log Message
Fix the Mountain Lion build.
* UIProcess/mac/ViewGestureController.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):
* UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::recordSnapshot):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm
trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162949 => 162950)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 20:25:24 UTC (rev 162949)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 20:49:49 UTC (rev 162950)
@@ -1,5 +1,15 @@
2014-01-28 Tim Horton
+Fix the Mountain Lion build.
+
+* UIProcess/mac/ViewGestureController.mm:
+(WebKit::ViewGestureController::beginSwipeGesture):
+(WebKit::ViewGestureController::removeSwipeSnapshot):
+* UIProcess/mac/ViewSnapshotStore.mm:
+(WebKit::ViewSnapshotStore::recordSnapshot):
+
+2014-01-28 Tim Horton
+
Fix the iOS build.
* UIProcess/WebPageProxy.cpp:
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm (162949 => 162950)
--- trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-28 20:25:24 UTC (rev 162949)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm 2014-01-28 20:49:49 UTC (rev 162950)
@@ -51,7 +51,9 @@
};
#endif
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
extern "C" IOReturn IOSurfaceSetPurgeable(IOSurfaceRef buffer, uint32_t newState, uint32_t *oldState);
+#endif
#if defined(__has_include) && __has_include()
#import
@@ -294,8 +296,10 @@
RetainPtr snapshot = ViewSnapshotStore::shared().snapshotAndRenderTreeSize(targetItem).first;
if (snapshot) {
-uint32_t purgeabilityState;
+uint32_t purgeabilityState = kIOSurfacePurgeableNonVolatile;
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
IOSurfaceSetPurgeable(snapshot.get(), kIOSurfacePurgeableNonVolatile, &purgeabilityState);
+#endif
if (purgeabilityState != kIOSurfacePurgeableEmpty)
[m_swipeSnapshotLayer setContents:(id)snapshot.get()];
@@ -403,9 +407,11 @@
if (m_activeGestureType != ViewGestureType::Swipe)
return;
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
IOSurfaceRef snapshotSurface = (IOSurfaceRef)[m_swipeSnapshotLayer contents];
if (snapshotSurface)
IOSurfaceSetPurgeable(snapshotSurface, kIOSurfacePurgeableVolatile, nullptr);
+#endif
[m_webPageProxy.acceleratedCompositingRootLayer() setPosition:CGPointZero];
[m_swipeSnapshotLayer removeFromSuperlayer];
Modified: trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm (162949 => 162950)
--- trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-01-28 20:25:24 UTC (rev 162949)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-01-28 20:49:49 UTC (rev 162950)
@@ -48,7 +48,9 @@
};
#endif
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
extern "C" IOReturn IOSurfaceSetPurgeable(IOSurfaceRef buffer, uint32_t newState, uint32_t *oldState);
+#endif
using namespace WebCore;
@@ -179,7 +181,9 @@
snapshot.surfaceContext = surfaceAndContext.second;
snapshot.creationTime = std::chrono::steady_clock::now();
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
IOSurfaceSetPurgeable(snapshot.surface.get(), kIOSurfacePurgeableVolatile, nullptr);
+#endif
m_snapshotMap.add(item->snapshotUUID(), snapshot);
m_renderTreeSizeMap.add(item->snapshotUUID(), webPageProxy.renderTreeSize());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162949] trunk/Source/WebKit2
Title: [162949] trunk/Source/WebKit2 Revision 162949 Author timothy_hor...@apple.com Date 2014-01-28 12:25:24 -0800 (Tue, 28 Jan 2014) Log Message Fix the iOS build. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::recordNavigationSnapshot): * UIProcess/mac/ViewSnapshotStore.h: * UIProcess/mac/ViewSnapshotStore.mm: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (162948 => 162949) --- trunk/Source/WebKit2/ChangeLog 2014-01-28 20:01:59 UTC (rev 162948) +++ trunk/Source/WebKit2/ChangeLog 2014-01-28 20:25:24 UTC (rev 162949) @@ -1,3 +1,12 @@ +2014-01-28 Tim Horton + +Fix the iOS build. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::recordNavigationSnapshot): +* UIProcess/mac/ViewSnapshotStore.h: +* UIProcess/mac/ViewSnapshotStore.mm: + 2014-01-28 Brady Eidson Remove unneeded “WebCore::” prefixing in two .cpp files. Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (162948 => 162949) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-28 20:01:59 UTC (rev 162948) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-01-28 20:25:24 UTC (rev 162949) @@ -760,7 +760,7 @@ if (!m_shouldRecordNavigationSnapshots) return; -#if PLATFORM(MAC) +#if PLATFORM(MAC) && !PLATFORM(IOS) ViewSnapshotStore::shared().recordSnapshot(*this); #endif } Modified: trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h (162948 => 162949) --- trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h 2014-01-28 20:01:59 UTC (rev 162948) +++ trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h 2014-01-28 20:25:24 UTC (rev 162949) @@ -26,6 +26,8 @@ #ifndef ViewSnapshotStore_h #define ViewSnapshotStore_h +#if !PLATFORM(IOS) + #include #include #include @@ -69,4 +71,6 @@ } // namespace WebKit +#endif // !PLATFORM(IOS) + #endif // ViewSnapshotStore_h Modified: trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm (162948 => 162949) --- trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-01-28 20:01:59 UTC (rev 162948) +++ trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-01-28 20:25:24 UTC (rev 162949) @@ -26,6 +26,8 @@ #import "config.h" #import "ViewSnapshotStore.h" +#if !PLATFORM(IOS) + #import "WebBackForwardList.h" #import "WebPageProxy.h" #import @@ -202,3 +204,5 @@ } } // namespace WebKit + +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162948] trunk/Source/WebKit2
Title: [162948] trunk/Source/WebKit2
Revision 162948
Author beid...@apple.com
Date 2014-01-28 12:01:59 -0800 (Tue, 28 Jan 2014)
Log Message
Remove unneeded “WebCore::” prefixing in two .cpp files.
Rubberstamped by Alexey Proskuryakov.
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp
trunk/Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162947 => 162948)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 19:40:05 UTC (rev 162947)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 20:01:59 UTC (rev 162948)
@@ -1,3 +1,12 @@
+2014-01-28 Brady Eidson
+
+Remove unneeded “WebCore::” prefixing in two .cpp files.
+
+Rubberstamped by Alexey Proskuryakov.
+
+* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
+* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
+
2014-01-28 Tim Horton
WebKit2 View Gestures (Swipe): Snapshots should be purgeable
Modified: trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp (162947 => 162948)
--- trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp 2014-01-28 19:40:05 UTC (rev 162947)
+++ trunk/Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp 2014-01-28 20:01:59 UTC (rev 162948)
@@ -433,7 +433,7 @@
postDatabaseTask(createAsyncTask(*this, &UniqueIDBDatabase::clearObjectStoreInBackingStore, requestID, transactionIdentifier, objectStoreID));
}
-void UniqueIDBDatabase::createIndex(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, const WebCore::IDBIndexMetadata& metadata, std::function successCallback)
+void UniqueIDBDatabase::createIndex(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, const IDBIndexMetadata& metadata, std::function successCallback)
{
ASSERT(isMainThread());
@@ -524,7 +524,7 @@
postDatabaseTask(createAsyncTask(*this, &UniqueIDBDatabase::putRecordInBackingStore, requestID, transactionIdentifier, m_metadata->objectStores.get(objectStoreID), keyData, value.vector(), putMode, indexIDs, indexKeys));
}
-void UniqueIDBDatabase::getRecord(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, int64_t indexID, const WebCore::IDBKeyRangeData& keyRangeData, WebCore::IndexedDB::CursorType cursorType, std::function callback)
+void UniqueIDBDatabase::getRecord(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, int64_t indexID, const IDBKeyRangeData& keyRangeData, IndexedDB::CursorType cursorType, std::function callback)
{
ASSERT(isMainThread());
@@ -547,7 +547,7 @@
postDatabaseTask(createAsyncTask(*this, &UniqueIDBDatabase::getRecordFromBackingStore, requestID, transactionIdentifier, m_metadata->objectStores.get(objectStoreID), indexID, keyRangeData, cursorType));
}
-void UniqueIDBDatabase::openCursor(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, int64_t indexID, WebCore::IndexedDB::CursorDirection cursorDirection, WebCore::IndexedDB::CursorType cursorType, WebCore::IDBDatabaseBackend::TaskType taskType, const WebCore::IDBKeyRangeData& keyRangeData, std::function callback)
+void UniqueIDBDatabase::openCursor(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, int64_t indexID, IndexedDB::CursorDirection cursorDirection, IndexedDB::CursorType cursorType, IDBDatabaseBackend::TaskType taskType, const IDBKeyRangeData& keyRangeData, std::function callback)
{
ASSERT(isMainThread());
@@ -570,7 +570,7 @@
postDatabaseTask(createAsyncTask(*this, &UniqueIDBDatabase::openCursorInBackingStore, requestID, transactionIdentifier, objectStoreID, indexID, cursorDirection, cursorType, taskType, keyRangeData));
}
-void UniqueIDBDatabase::cursorAdvance(const IDBIdentifier& cursorIdentifier, uint64_t count, std::function, uint32_t, const String&)> callback)
+void UniqueIDBDatabase::cursorAdvance(const IDBIdentifier& cursorIdentifier, uint64_t count, std::function, uint32_t, const String&)> callback)
{
ASSERT(isMainThread());
@@ -579,7 +579,7 @@
return;
}
-RefPtr request = AsyncRequestImpl, uint32_t, const String&>::create([this, callback](WebCore::IDBKeyData key, WebCore::IDBKeyData primaryKey, PassRefPtr value, uint32_t errorCode, const String& errorMessage) {
+RefPtr request = AsyncRequestImpl, uint32_t, const String&>::create([this, callback](IDBKeyData key, IDBKeyData primaryKey, PassRefPtr value, uint32_t errorCode, const String& errorMessage) {
callback(key, primaryKey, value, errorCode, errorMessage);
}, [this, callback]() {
callback(nullptr, nullptr, nullptr, INVALID_STATE_ERR, "Unable to advance cursor in database");
@@ -591,7 +591,7 @@
postDatabaseTask(createAsyncTask(*this, &Unique
[webkit-changes] [162947] trunk/Source/WebCore
Title: [162947] trunk/Source/WebCore
Revision 162947
Author an...@apple.com
Date 2014-01-28 11:40:05 -0800 (Tue, 28 Jan 2014)
Log Message
REGRESSION(r162837): 5% regression on html5-full-render and 3% regression in DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=127722
Reviewed by Darin Adler.
Accumulate repaint region in RendeView instead of flushing rects directly to the system.
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):
(WebCore::Document::topDocument):
Make less silly.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
(WebCore::RenderView::RepaintRegionAccumulator::~RepaintRegionAccumulator):
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (162946 => 162947)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 19:33:49 UTC (rev 162946)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 19:40:05 UTC (rev 162947)
@@ -1,3 +1,28 @@
+2014-01-28 Antti Koivisto
+
+REGRESSION(r162837): 5% regression on html5-full-render and 3% regression in DoYouEvenBench
+https://bugs.webkit.org/show_bug.cgi?id=127722
+
+Reviewed by Darin Adler.
+
+Accumulate repaint region in RendeView instead of flushing rects directly to the system.
+
+* dom/Document.cpp:
+(WebCore::Document::recalcStyle):
+(WebCore::Document::updateLayout):
+(WebCore::Document::topDocument):
+
+Make less silly.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::repaintViewRectangle):
+(WebCore::RenderView::flushAccumulatedRepaintRegion):
+(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
+(WebCore::RenderView::RepaintRegionAccumulator::~RepaintRegionAccumulator):
+* rendering/RenderView.h:
+
2014-01-28 Jeremy Jones
HTMLMediaElement::m_platformLayerBorrowed is uninitialized.
Modified: trunk/Source/WebCore/dom/Document.cpp (162946 => 162947)
--- trunk/Source/WebCore/dom/Document.cpp 2014-01-28 19:33:49 UTC (rev 162946)
+++ trunk/Source/WebCore/dom/Document.cpp 2014-01-28 19:40:05 UTC (rev 162947)
@@ -1720,6 +1720,8 @@
if (m_inStyleRecalc)
return; // Guard against re-entrancy. -dwh
+RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());
+
// FIXME: We should update style on our ancestor chain before proceeding (especially for seamless),
// however doing so currently causes several tests to crash, as Frame::setDocument calls Document::attach
// before setting the DOMWindow on the Frame, or the SecurityOrigin on the document. The attach, in turn
@@ -1811,6 +1813,8 @@
return;
}
+RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());
+
if (Element* oe = ownerElement())
oe->document().updateLayout();
@@ -4309,12 +4313,7 @@
Document* Document::topDocument() const
{
-// FIXME: Why does this walk up owner elements instead using the frame tree as parentDocument does?
-// The frame tree even has a top() function.
-Document* document = const_cast(this);
-while (Element* element = document->ownerElement())
-document = &element->document();
-return document;
+return m_frame ? m_frame->mainFrame().document() : const_cast(this);
}
PassRefPtr Document::createAttribute(const String& name, ExceptionCode& ec)
Modified: trunk/Source/WebCore/page/FrameView.cpp (162946 => 162947)
--- trunk/Source/WebCore/page/FrameView.cpp 2014-01-28 19:33:49 UTC (rev 162946)
+++ trunk/Source/WebCore/page/FrameView.cpp 2014-01-28 19:40:05 UTC (rev 162947)
@@ -1276,6 +1276,7 @@
root->view().pushLayoutState(*root);
}
LayoutStateDisabler layoutStateDisabler(disableLayoutState ? &root->view() : 0);
+RenderView::RepaintRegionAccumulator repaintRegionAccumulator(&root->view());
ASSERT(m_layoutPhase == InPreLayout);
m_layoutPhase = InLayout;
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (162946 => 162947)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2014-01-28 19:33:49 UTC (rev 162946)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2014-01-28 19:40:05 UTC (rev 162947)
@@ -605,35 +605,47 @@
repaint();
}
-void RenderView::repaintViewRectangle(const LayoutRect& ur, bool immediate) const
+void RenderView::repaintViewRectangle(const LayoutRect& repaintRect, bool immediate) const
{
-if (!shouldRepaint(ur))
+
[webkit-changes] [162946] trunk/Source/WebKit2
Title: [162946] trunk/Source/WebKit2 Revision 162946 Author timothy_hor...@apple.com Date 2014-01-28 11:33:49 -0800 (Tue, 28 Jan 2014) Log Message WebKit2 View Gestures (Swipe): Snapshots should be purgeable https://bugs.webkit.org/show_bug.cgi?id=127390 Reviewed by Anders Carlsson. Make snapshots be purgeable, and implement a straightforward (if perhaps expensive, for now) cache eviction strategy to limit the number of snapshots to 20. * UIProcess/mac/ViewGestureController.mm: (WebKit::ViewGestureController::beginSwipeGesture): When beginning a gesture, attempt to make the retrieved snapshot non-volatile. If it was purged while volatile, we won't use it, but if it is still valid, we'll go ahead and use it as the swipe layer's contents. (WebKit::ViewGestureController::removeSwipeSnapshot): When removing the swipe snapshot, make it volatile once again. * UIProcess/mac/ViewSnapshotStore.h: Store a creation time along with the image. Store and return IOSurfaces instead of CGImages. Store snapshots and render tree sizes separately, so that we can throw away snapshots but keep the render tree sizes indefinitely. * UIProcess/mac/ViewSnapshotStore.mm: (WebKit::ViewSnapshotStore::pruneSnapshots): Cap the number of snapshots we'll ever have live at 20. Enforce this cap by first trying to remove snapshots farthest from the current back-forward list's current item, falling back to removing the least recently created snapshot if there are no snapshots owned by the current back-forward list. (WebKit::createIOSurfaceFromImage): Build an IOSurface from the CGImage snapshot we took, for ease of use of its purgeability API. (WebKit::ViewSnapshotStore::recordSnapshot): Bail from taking the snapshot if the image is empty; this can happen if the view is out of the window when the snapshot is taken. Mark snapshots as purgeable as soon as they go into the cache. (WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize): Return the target render tree size even if there is no snapshot image. Take care not to look up an empty UUID. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (162945 => 162946) --- trunk/Source/WebKit2/ChangeLog 2014-01-28 19:26:21 UTC (rev 162945) +++ trunk/Source/WebKit2/ChangeLog 2014-01-28 19:33:49 UTC (rev 162946) @@ -1,3 +1,52 @@ +2014-01-28 Tim Horton + +WebKit2 View Gestures (Swipe): Snapshots should be purgeable +https://bugs.webkit.org/show_bug.cgi?id=127390 + + +Reviewed by Anders Carlsson. + +Make snapshots be purgeable, and implement a straightforward +(if perhaps expensive, for now) cache eviction strategy to limit the +number of snapshots to 20. + +* UIProcess/mac/ViewGestureController.mm: +(WebKit::ViewGestureController::beginSwipeGesture): +When beginning a gesture, attempt to make the retrieved snapshot +non-volatile. If it was purged while volatile, we won't use it, but if it +is still valid, we'll go ahead and use it as the swipe layer's contents. + +(WebKit::ViewGestureController::removeSwipeSnapshot): +When removing the swipe snapshot, make it volatile once again. + +* UIProcess/mac/ViewSnapshotStore.h: +Store a creation time along with the image. +Store and return IOSurfaces instead of CGImages. +Store snapshots and render tree sizes separately, so that we can +throw away snapshots but keep the render tree sizes indefinitely. + +* UIProcess/mac/ViewSnapshotStore.mm: +(WebKit::ViewSnapshotStore::pruneSnapshots): +Cap the number of snapshots we'll ever have live at 20. +Enforce this cap by first trying to remove snapshots farthest +from the current back-forward list's current item, falling back +to removing the least recently created snapshot if there are no +snapshots owned by the current back-forward list. + +(WebKit::createIOSurfaceFromImage): +Build an IOSurface from the CGImage snapshot we took, for ease of +use of its purgeability API. + +(WebKit::ViewSnapshotStore::recordSnapshot): +Bail from taking the snapshot if the image is empty; this can happen +if the view is out of the window when the snapshot is taken. + +Mark snapshots as purgeable as soon as they go into the cache. + +(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize): +Return the target render tree size even if there is no snapshot image. +Take care not to look up an empty UUID. + 2014-01-27 Alexey Proskuryakov Expose SQL database creation and modification times Modified: trunk/Source/WebKit2/UIProcess/mac/ViewGestureController.mm (162945 => 162946) --- trunk/Source/WebKit2/UIPr
[webkit-changes] [162945] trunk/Source/WebCore
Title: [162945] trunk/Source/WebCore Revision 162945 Author commit-qu...@webkit.org Date 2014-01-28 11:26:21 -0800 (Tue, 28 Jan 2014) Log Message HTMLMediaElement::m_platformLayerBorrowed is uninitialized. https://bugs.webkit.org/show_bug.cgi?id=127759 Patch by Jeremy Jones on 2014-01-28 Reviewed by Eric Carlson. Initalize m_platformLayerBorrowed to false. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (162944 => 162945) --- trunk/Source/WebCore/ChangeLog 2014-01-28 18:22:07 UTC (rev 162944) +++ trunk/Source/WebCore/ChangeLog 2014-01-28 19:26:21 UTC (rev 162945) @@ -1,3 +1,15 @@ +2014-01-28 Jeremy Jones + +HTMLMediaElement::m_platformLayerBorrowed is uninitialized. +https://bugs.webkit.org/show_bug.cgi?id=127759 + +Reviewed by Eric Carlson. + +Initalize m_platformLayerBorrowed to false. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::HTMLMediaElement): + 2014-01-28 Jer Noble [Mac] Use explicit, rather than canonical, AudioFormatFlags and types. Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (162944 => 162945) --- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-28 18:22:07 UTC (rev 162944) +++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2014-01-28 19:26:21 UTC (rev 162945) @@ -322,6 +322,7 @@ #endif #if PLATFORM(IOS) , m_requestingPlay(false) +, m_platformLayerBorrowed(false) #endif #if ENABLE(VIDEO_TRACK) , m_tracksAreReady(true) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162944] trunk/Source/WebCore
Title: [162944] trunk/Source/WebCore Revision 162944 Author jer.no...@apple.com Date 2014-01-28 10:22:07 -0800 (Tue, 28 Jan 2014) Log Message [Mac] Use explicit, rather than canonical, AudioFormatFlags and types. https://bugs.webkit.org/show_bug.cgi?id=127781 Reviewed by Eric Carlson. Since every mac platform uses Float32 audio samples, use these types explicitly rather than the implicit, canonical AudioSampleType type. Once we're using Float32 explicity, we can also use the explicit kAudioFormatFlagsNativeFloatPacked flag rather than the canonical version. * platform/audio/mac/AudioDestinationMac.cpp: (WebCore::AudioDestinationMac::configure): * platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp trunk/Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (162943 => 162944) --- trunk/Source/WebCore/ChangeLog 2014-01-28 18:18:47 UTC (rev 162943) +++ trunk/Source/WebCore/ChangeLog 2014-01-28 18:22:07 UTC (rev 162944) @@ -1,3 +1,20 @@ +2014-01-28 Jer Noble + +[Mac] Use explicit, rather than canonical, AudioFormatFlags and types. +https://bugs.webkit.org/show_bug.cgi?id=127781 + +Reviewed by Eric Carlson. + +Since every mac platform uses Float32 audio samples, use these types explicitly +rather than the implicit, canonical AudioSampleType type. Once we're using Float32 +explicity, we can also use the explicit kAudioFormatFlagsNativeFloatPacked flag +rather than the canonical version. + +* platform/audio/mac/AudioDestinationMac.cpp: +(WebCore::AudioDestinationMac::configure): +* platform/audio/mac/AudioFileReaderMac.cpp: +(WebCore::AudioFileReader::createBus): + 2014-01-27 Alexey Proskuryakov Expose SQL database creation and modification times Modified: trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp (162943 => 162944) --- trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp 2014-01-28 18:18:47 UTC (rev 162943) +++ trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp 2014-01-28 18:22:07 UTC (rev 162944) @@ -124,19 +124,16 @@ OSStatus result = AudioUnitSetProperty(m_outputUnit, kAudioUnitProperty_SetRenderCallback, kAudioUnitScope_Global, 0, &input, sizeof(input)); ASSERT(!result); -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wdeprecated-declarations" // Set stream format AudioStreamBasicDescription streamFormat; streamFormat.mSampleRate = m_sampleRate; streamFormat.mFormatID = kAudioFormatLinearPCM; -streamFormat.mFormatFlags = kAudioFormatFlagsCanonical | kAudioFormatFlagIsNonInterleaved; -streamFormat.mBitsPerChannel = 8 * sizeof(AudioSampleType); +streamFormat.mFormatFlags = kAudioFormatFlagsNativeFloatPacked | kAudioFormatFlagIsNonInterleaved; +streamFormat.mBitsPerChannel = 8 * sizeof(Float32); streamFormat.mChannelsPerFrame = 2; streamFormat.mFramesPerPacket = 1; -streamFormat.mBytesPerPacket = sizeof(AudioSampleType); -streamFormat.mBytesPerFrame = sizeof(AudioSampleType); -#pragma clang diagnostic pop +streamFormat.mBytesPerPacket = sizeof(Float32); +streamFormat.mBytesPerFrame = sizeof(Float32); result = AudioUnitSetProperty(m_outputUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Input, 0, (void*)&streamFormat, sizeof(AudioStreamBasicDescription)); ASSERT(!result); Modified: trunk/Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp (162943 => 162944) --- trunk/Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp 2014-01-28 18:18:47 UTC (rev 162943) +++ trunk/Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp 2014-01-28 18:22:07 UTC (rev 162944) @@ -157,17 +157,14 @@ // Client format will be linear PCM (canonical), and potentially change sample-rate. m_clientDataFormat = m_fileDataFormat; -#pragma clang diagnostic push -#pragma clang diagnostic ignored "-Wdeprecated-declarations" m_clientDataFormat.mFormatID = kAudioFormatLinearPCM; -m_clientDataFormat.mFormatFlags = kAudioFormatFlagsCanonical; -m_clientDataFormat.mBitsPerChannel = 8 * sizeof(AudioSampleType); +m_clientDataFormat.mFormatFlags = kAudioFormatFlagsNativeFloatPacked; +m_clientDataFormat.mBitsPerChannel = 8 * sizeof(Float32); m_clientDataFormat.mChannelsPerFrame = numberOfChannels; m_clientDataFormat.mFramesPerPacket = 1; -m_clientDataFormat.mBytesPerPacket = sizeof(AudioSampleType); -m_clientDataFormat.mBytesPerFrame = sizeof(AudioSampleType); +m_clientDataFormat.mBytesPerPacket = sizeof(Float32); +m_clientDataFormat.mBytesPerFrame = sizeof(Float32); m_clientDataFormat.mFormatFlags |= kAudioFormatFlagIsNonInterleaved; -#pragma clang diagnostic pop if (sampleRate) m_clientDataForma
[webkit-changes] [162943] trunk/Source
Title: [162943] trunk/Source Revision 162943 Author a...@apple.com Date 2014-01-28 10:18:47 -0800 (Tue, 28 Jan 2014) Log Message Expose SQL database creation and modification times https://bugs.webkit.org/show_bug.cgi?id=127728 Reviewed by Brady Eidson. Source/WebCore: * platform/FileSystem.h: * platform/posix/FileSystemPOSIX.cpp: (WebCore::getFileCreationTime): * platform/win/FileSystemWin.cpp: (WebCore::getFileCreationTimeFromFindData): (WebCore::getFileCreationTime): Added functions to get file creation times. Not all OSes support that, but Darwin and Windows do, as (I think) various BSD flavors. * platform/gtk/FileSystemGtk.cpp: Added a stub for getFileCreationTime(). * platform/sql/SQLiteFileSystem.h: * platform/sql/SQLiteFileSystem.cpp: (WebCore::SQLiteFileSystem::databaseCreationTime): (WebCore::SQLiteFileSystem::databaseModificationTime): Expose it in the same strange manner other database file operations are. * Modules/webdatabase/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::creationTime): (WebCore::DatabaseDetails::modificationTime): Added creation and modification times to DatabaseDetails. * Modules/webdatabase/DatabaseManager.cpp: (WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase): (WebCore::DatabaseManager::openDatabaseBackend): ProposedDatabase is an unfortunate mechanism for communicating quota errors to the client, we should really straighten it up. But for now, just leave the times uninitialized. * Modules/webdatabase/DatabaseBackendBase.cpp: (WebCore::DatabaseBackendBase::details): This code path is for handling quota errors, so there is no need to initialize most of DatabaseDetails here as well. * Modules/webdatabase/DatabaseTracker.cpp: (WebCore::DatabaseTracker::detailsForNameAndOrigin): * Modules/webdatabase/DatabaseTracker.h: Fill in database file times. Inlined and removed usageForDatabase function to avoid rebuilding the path multiple times. Source/WebKit2: * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): Encode and decode new DatabaseDetails member variables. * UIProcess/API/C/WKDatabaseManager.cpp: (WKDatabaseManagerGetDatabaseDetailsCreationTimeKey): (WKDatabaseManagerGetDatabaseDetailsModificationTimeKey): * UIProcess/API/C/WKDatabaseManager.h: Added new keys for database details. * UIProcess/WebDatabaseManagerProxy.cpp: (WebKit::WebDatabaseManagerProxy::databaseDetailsCreationTimeKey): (WebKit::WebDatabaseManagerProxy::databaseDetailsModificationTimeKey): (WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin): * UIProcess/WebDatabaseManagerProxy.h: Set the new keys if times are valid. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseDetails.h trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.h trunk/Source/WebCore/platform/FileSystem.h trunk/Source/WebCore/platform/gtk/FileSystemGtk.cpp trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp trunk/Source/WebCore/platform/sql/SQLiteFileSystem.cpp trunk/Source/WebCore/platform/sql/SQLiteFileSystem.h trunk/Source/WebCore/platform/win/FileSystemWin.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp trunk/Source/WebKit2/UIProcess/API/C/WKDatabaseManager.cpp trunk/Source/WebKit2/UIProcess/API/C/WKDatabaseManager.h trunk/Source/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebDatabaseManagerProxy.h Diff Modified: trunk/Source/WebCore/ChangeLog (162942 => 162943) --- trunk/Source/WebCore/ChangeLog 2014-01-28 17:55:17 UTC (rev 162942) +++ trunk/Source/WebCore/ChangeLog 2014-01-28 18:18:47 UTC (rev 162943) @@ -1,3 +1,48 @@ +2014-01-27 Alexey Proskuryakov + +Expose SQL database creation and modification times +https://bugs.webkit.org/show_bug.cgi?id=127728 + +Reviewed by Brady Eidson. + +* platform/FileSystem.h: +* platform/posix/FileSystemPOSIX.cpp: +(WebCore::getFileCreationTime): +* platform/win/FileSystemWin.cpp: +(WebCore::getFileCreationTimeFromFindData): +(WebCore::getFileCreationTime): +Added functions to get file creation times. Not all OSes support that, but Darwin +and Windows do, as (I think) various BSD flavors. + +* platform/gtk/FileSystemGtk.cpp: Added a stub for getFileCreationTime(). + +* platform/sql/SQLiteFileSystem.h: +* platform/sql/SQLiteFileSystem.cpp: +(WebCore::SQLiteFileSystem::databaseCreationTime): +(WebCore::SQLiteFileSystem::databaseModificationTime): +Expose it in the same strange manner other database file operations are. + +* Modules/webdatabase/DatabaseDetails.h: +(WebCore::DatabaseDetails::DatabaseDetails): +
[webkit-changes] [162942] trunk/LayoutTests
Title: [162942] trunk/LayoutTests Revision 162942 Author m.pak...@samsung.com Date 2014-01-28 09:55:17 -0800 (Tue, 28 Jan 2014) Log Message Unreviewed EFL gardening Skip crashing http tests. * platform/efl-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (162941 => 162942) --- trunk/LayoutTests/ChangeLog 2014-01-28 17:49:58 UTC (rev 162941) +++ trunk/LayoutTests/ChangeLog 2014-01-28 17:55:17 UTC (rev 162942) @@ -1,3 +1,11 @@ +2014-01-28 Michał Pakuła vel Rutka + +Unreviewed EFL gardening + +Skip crashing http tests. + +* platform/efl-wk2/TestExpectations: + 2014-01-28 Jer Noble Setting muted attribute on element is not reflected in controls Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (162941 => 162942) --- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-01-28 17:49:58 UTC (rev 162941) +++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-01-28 17:55:17 UTC (rev 162942) @@ -69,14 +69,18 @@ # EFL specific error : (_ecore_main_fd_handlers_bads_rem() No bad fd found) webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html [ Skip ] webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html [ Skip ] +webkit.org/b/116587 http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/broken-utf8.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/compressed-control-frame.html [ Skip ] +webkit.org/b/116587 http/tests/websocket/tests/hybi/cross-origin.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/extensions.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/fragmented-binary-frames.html [ Skip ] +webkit.org/b/116587 http/tests/websocket/tests/hybi/fragmented-frames.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/handshake-challenge-randomness.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/handshake-error.html [ Skip ] +webkit.org/b/116587 http/tests/websocket/tests/hybi/nocache.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/no-subprotocol.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/reserved-bits.html [ Skip ] webkit.org/b/116587 http/tests/websocket/tests/hybi/simple.html [ Skip ] @@ -343,7 +347,7 @@ # Websocket tests are flaky on WK2 webkit.org/b/111976 http/tests/websocket/tests/hybi/bufferedAmount-after-close.html [ Crash Pass ] webkit.org/b/111976 http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html [ Crash Pass ] -webkit.org/b/111976 http/tests/websocket/tests/hybi/fragmented-control-frame.html [ Crash Pass ] +webkit.org/b/111976 http/tests/websocket/tests/hybi/fragmented-control-frame.html [ Crash Pass Failure ] webkit.org/b/111976 http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header.html [ Crash Pass Failure ] webkit.org/b/111976 http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html [ Pass Failure ] webkit.org/b/111976 http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header.html [ Crash Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162941] trunk
Title: [162941] trunk
Revision 162941
Author jer.no...@apple.com
Date 2014-01-28 09:49:58 -0800 (Tue, 28 Jan 2014)
Log Message
Setting muted attribute on element is not reflected in controls
https://bugs.webkit.org/show_bug.cgi?id=127726
Reviewed by Eric Carlson.
Source/WebCore:
If the 'muted' IDL attribute is queried after the 'muted' and 'src' content attributes are
set but before loading begins, it will return 'false' until loading begins, but with no
way to query whether that value is valid, nor firing a volumechange event when its value
changes.
The HTML spec says that the 'muted' content attribute controls whether audio output is
muted "when the media element is created", not when loading begins, but we don't
necessarily have a signal that the element is fully parsed. Additionally, this means its
impossible to make an element via script and get this behavior.
So the new behavior is that the 'muted' IDL attribute will always reflect the 'muted'
content attribute up until one of the following three conditions:
- The 'muted' IDL attribute is set via script.
- The element is inserted in the document.
- The element begins loading.
After the first one of the above conditions, the 'muted' IDL attribute will no longer
change when the 'muted' content attribute changes.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
LayoutTests:
* media/video-defaultmuted-expected.txt:
* media/video-defaultmuted.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-defaultmuted-expected.txt
trunk/LayoutTests/media/video-defaultmuted.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
Diff
Modified: trunk/LayoutTests/ChangeLog (162940 => 162941)
--- trunk/LayoutTests/ChangeLog 2014-01-28 17:43:07 UTC (rev 162940)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 17:49:58 UTC (rev 162941)
@@ -1,3 +1,13 @@
+2014-01-28 Jer Noble
+
+Setting muted attribute on element is not reflected in controls
+https://bugs.webkit.org/show_bug.cgi?id=127726
+
+Reviewed by Eric Carlson.
+
+* media/video-defaultmuted-expected.txt:
+* media/video-defaultmuted.html:
+
2014-01-28 Mark Lam
Jettison DFG code when neither breakpoints or the profiler are active.
Modified: trunk/LayoutTests/media/video-defaultmuted-expected.txt (162940 => 162941)
--- trunk/LayoutTests/media/video-defaultmuted-expected.txt 2014-01-28 17:43:07 UTC (rev 162940)
+++ trunk/LayoutTests/media/video-defaultmuted-expected.txt 2014-01-28 17:49:58 UTC (rev 162941)
@@ -8,16 +8,12 @@
RUN(video.setAttribute('controls', 'controls'))
RUN(video.setAttribute('muted', 'muted'))
-*** Test before setting src, IDL attribute should default to false
-EXPECTED (video.muted == 'false') OK
+*** Test before setting src, muted IDL attribute should default to muted content attribute
+EXPECTED (video.muted == 'true') OK
EXPECTED (video.defaultMuted == 'true') OK
EVENT(loadedmetadata)
-*** After setting url, content attribute should have set IDL attribute
-EXPECTED (video.muted == 'true') OK
-EXPECTED (video.defaultMuted == 'true') OK
-
*** Change 'defaultMuted', IDL attribute should not change but content attribute should.
RUN(video.defaultMuted = false)
EXPECTED (video.muted == 'true') OK
@@ -41,16 +37,12 @@
RUN(video = document.createElement('video'))
RUN(video.setAttribute('controls', 'controls'))
-*** Test before setting src, IDL attribute should default to false
+*** Test before setting src, muted IDL attribute should default to muted content attribute
EXPECTED (video.muted == 'false') OK
EXPECTED (video.defaultMuted == 'false') OK
EVENT(loadedmetadata)
-*** After setting url, content attribute should have set IDL attribute
-EXPECTED (video.muted == 'false') OK
-EXPECTED (video.defaultMuted == 'false') OK
-
*** Change 'defaultMuted', IDL attribute should not change but content attribute should.
RUN(video.defaultMuted = true)
EXPECTED (video.muted == 'false') OK
@@ -68,5 +60,41 @@
EXPECTED (video.muted == 'false') OK
EXPECTED (video.defaultMuted == 'true') OK
+
+*** Test that the 'muted' content attribute reflects the 'muted' IDL attribute before the element is added to the document, and does not reflect after
+
+RUN(video = document.createElement('video'))
+RUN(video.setAttribute('controls', 'controls'))
+EXPECTED (video.muted == 'false') OK
+EXPECTED (video.defaultMuted == 'false') OK
+
+*** Change 'muted' content attribute, IDL attribute should change.
+RUN(video.setAttribute('muted', 'muted'))
+EXPECTED (video.muted == 'true') OK
+EXPECTED (video.defaultMuted == 'true') OK
+RUN(document.getElementById('parent').appendChild(video))
+
+*** Change 'muted' content attribute, IDL attribute should not change.
+EXPECTED (video.muted == 'true') OK
+EXPECTED (video.defaultMuted == 'false') OK
[webkit-changes] [162940] trunk
Title: [162940] trunk
Revision 162940
Author mark@apple.com
Date 2014-01-28 09:43:07 -0800 (Tue, 28 Jan 2014)
Log Message
Jettison DFG code when neither breakpoints or the profiler are active.
Reviewed by Geoffrey Garen.
Source/_javascript_Core:
We need to jettison the DFG CodeBlocks under the following circumstances:
1. When adding breakpoints to a CodeBlock, jettison it if it is a DFG CodeBlock.
2. When enabling stepping mode in a CodeBlock, jettison it if it a DFG CodeBlock.
3. When settign the enabled profiler in the VM, we need to jettison all DFG
CodeBlocks.
Instead of emitting speculation checks, the DFG code will now treat Breakpoint,
ProfileWillCall, and ProfileDidCall as no-ops similar to a Phantom node. We
still need to track these nodes so that they match the corresponding opcodes
in the baseline JIT when we jettison and OSR exit. Without them, we would OSR
exit to the wrong location in the baseline JIT code.
In DFGDriver's compileImpl() and DFGPlan's finalizeWithoutNotifyingCallback()
we fail the compilation effort with a CompilationInvalidated result. This allows
the DFG compiler to re-attampt the compilation of the function after some time
if it is hot. The CompilationInvalidated result is supposed to cause the DFG
to exercise an exponential back off before re-attempting compilation again
(see runtime/CompilationResult.h).
This patch improves the Octane score from ~2950 to ~3067.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addBreakpoint):
(JSC::CodeBlock::setSteppingMode):
* bytecode/CodeBlock.h:
* debugger/Debugger.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::SetEnabledProfilerFunctor::operator()):
(JSC::VM::setEnabledProfiler):
* runtime/VM.h:
(JSC::VM::enabledProfiler):
LayoutTests:
Added a test to exercise setting a breakpoint in 2 DFG compiled functions:
1 not inlined, and 1 inlined.
* inspector-protocol/debugger/resources/breakpoint.js:
(notInlineable):
(inlineable):
(notInliningFoo):
(inliningFoo):
(dfgWithoutInline):
(dfgWithInline):
* inspector-protocol/debugger/setBreakpoint-dfg-expected.txt: Added.
* inspector-protocol/debugger/setBreakpoint-dfg.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/debugger/Debugger.h
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDriver.cpp
trunk/Source/_javascript_Core/dfg/DFGPlan.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/profiler/LegacyProfiler.cpp
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
Added Paths
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-expected.txt
trunk/LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg.html
Diff
Modified: trunk/LayoutTests/ChangeLog (162939 => 162940)
--- trunk/LayoutTests/ChangeLog 2014-01-28 17:38:49 UTC (rev 162939)
+++ trunk/LayoutTests/ChangeLog 2014-01-28 17:43:07 UTC (rev 162940)
@@ -1,3 +1,23 @@
+2014-01-28 Mark Lam
+
+Jettison DFG code when neither breakpoints or the profiler are active.
+
+
+Reviewed by Geoffrey Garen.
+
+Added a test to exercise setting a breakpoint in 2 DFG compiled functions:
+1 not inlined, and 1 inlined.
+
+* inspector-protocol/debugger/resources/breakpoint.js:
+(notInlineable):
+(inlineable):
+(notInliningFoo):
+(inliningFoo):
+(dfgWithoutInline):
+(dfgWithInline):
+* inspector-protocol/debugger/setBreakpoint-dfg-expected.txt: Added.
+* inspector-protocol/debugger/setBreakpoint-dfg.html: Added.
+
2014-01-28 Gurpreet Kaur
Add support for menclose element
Modified: trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js (162939 => 162940)
--- trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js 2014-01-28 17:38:49 UTC (rev 162939)
+++ trunk/LayoutTests/inspector-protocol/debugger/resources/breakpoint.js 2014-01-28 17:43:07 UTC (rev 162940)
@@ -17,3 +17,42 @@
{
log("inside breakpointActions a:(" + a + ") b:(" + b + ")");
}
+
+function notInlineable(x)
+{
+var func
[webkit-changes] [162939] trunk/Source/WTF
Title: [162939] trunk/Source/WTF
Revision 162939
Author ander...@apple.com
Date 2014-01-28 09:38:49 -0800 (Tue, 28 Jan 2014)
Log Message
Actually turn stack stats back off.
* wtf/StackStats.cpp:
* wtf/StackStats.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StackStats.cpp
trunk/Source/WTF/wtf/StackStats.h
Diff
Modified: trunk/Source/WTF/ChangeLog (162938 => 162939)
--- trunk/Source/WTF/ChangeLog 2014-01-28 17:36:54 UTC (rev 162938)
+++ trunk/Source/WTF/ChangeLog 2014-01-28 17:38:49 UTC (rev 162939)
@@ -1,5 +1,12 @@
2014-01-28 Anders Carlsson
+Actually turn stack stats back off.
+
+* wtf/StackStats.cpp:
+* wtf/StackStats.h:
+
+2014-01-28 Anders Carlsson
+
Turn stack stats back off.
* wtf/StackStats.cpp:
Modified: trunk/Source/WTF/wtf/StackStats.cpp (162938 => 162939)
--- trunk/Source/WTF/wtf/StackStats.cpp 2014-01-28 17:36:54 UTC (rev 162938)
+++ trunk/Source/WTF/wtf/StackStats.cpp 2014-01-28 17:38:49 UTC (rev 162939)
@@ -36,7 +36,7 @@
// checkpoint. By default, we only log checkpoints that establish new
// max values.
-#define ENABLE_VERBOSE_STACK_STATS 0
+#define ENABLE_VERBOSE_STACK_STATS 1
namespace WTF {
Modified: trunk/Source/WTF/wtf/StackStats.h (162938 => 162939)
--- trunk/Source/WTF/wtf/StackStats.h 2014-01-28 17:36:54 UTC (rev 162938)
+++ trunk/Source/WTF/wtf/StackStats.h 2014-01-28 17:38:49 UTC (rev 162939)
@@ -40,7 +40,7 @@
// convenience for collecting that data. It is not meant to be enabled by
// default on release or debug builds.
-#define ENABLE_STACK_STATS 1
+#define ENABLE_STACK_STATS 0
namespace WTF {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162938] trunk/Source/WTF
Title: [162938] trunk/Source/WTF
Revision 162938
Author ander...@apple.com
Date 2014-01-28 09:36:54 -0800 (Tue, 28 Jan 2014)
Log Message
Turn stack stats back off.
* wtf/StackStats.cpp:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StackStats.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (162937 => 162938)
--- trunk/Source/WTF/ChangeLog 2014-01-28 17:28:44 UTC (rev 162937)
+++ trunk/Source/WTF/ChangeLog 2014-01-28 17:36:54 UTC (rev 162938)
@@ -1,5 +1,11 @@
2014-01-28 Anders Carlsson
+Turn stack stats back off.
+
+* wtf/StackStats.cpp:
+
+2014-01-28 Anders Carlsson
+
Use std::mutex instead of WTF::Mutex in WTF
https://bugs.webkit.org/show_bug.cgi?id=127783
Modified: trunk/Source/WTF/wtf/StackStats.cpp (162937 => 162938)
--- trunk/Source/WTF/wtf/StackStats.cpp 2014-01-28 17:28:44 UTC (rev 162937)
+++ trunk/Source/WTF/wtf/StackStats.cpp 2014-01-28 17:36:54 UTC (rev 162938)
@@ -36,7 +36,7 @@
// checkpoint. By default, we only log checkpoints that establish new
// max values.
-#define ENABLE_VERBOSE_STACK_STATS 1
+#define ENABLE_VERBOSE_STACK_STATS 0
namespace WTF {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162937] trunk/Source/WebCore
Title: [162937] trunk/Source/WebCore
Revision 162937
Author ander...@apple.com
Date 2014-01-28 09:28:44 -0800 (Tue, 28 Jan 2014)
Log Message
Add stubbed out VisitedLinkProvider class
https://bugs.webkit.org/show_bug.cgi?id=127744
Reviewed by Andreas Kling.
This is a first step towards moving responsibility of visited links from
the page group to a separate object.
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
* page/PageGroup.h:
(WebCore::PageGroup::visitedLinkProvider):
* page/VisitedLinkProvider.cpp: Added.
(WebCore::VisitedLinkProvider::VisitedLinkProvider):
(WebCore::VisitedLinkProvider::~VisitedLinkProvider):
* page/VisitedLinkProvider.h: Added.
(WebCore::VisitedLinkProvider::create):
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/page/PageGroup.cpp
trunk/Source/WebCore/page/PageGroup.h
Added Paths
trunk/Source/WebCore/page/VisitedLinkProvider.cpp
trunk/Source/WebCore/page/VisitedLinkProvider.h
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (162936 => 162937)
--- trunk/Source/WebCore/CMakeLists.txt 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/CMakeLists.txt 2014-01-28 17:28:44 UTC (rev 162937)
@@ -1768,6 +1768,7 @@
page/SuspendableTimer.cpp
page/UserContentController.cpp
page/UserContentURLPattern.cpp
+page/VisitedLinkProvider.cpp
page/WindowFeatures.cpp
page/WindowFocusAllowedIndicator.cpp
page/WorkerNavigator.cpp
Modified: trunk/Source/WebCore/ChangeLog (162936 => 162937)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 17:28:44 UTC (rev 162937)
@@ -1,3 +1,28 @@
+2014-01-28 Anders Carlsson
+
+Add stubbed out VisitedLinkProvider class
+https://bugs.webkit.org/show_bug.cgi?id=127744
+
+Reviewed by Andreas Kling.
+
+This is a first step towards moving responsibility of visited links from
+the page group to a separate object.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* WebCore.vcxproj/WebCore.vcxproj:
+* WebCore.vcxproj/WebCore.vcxproj.filters:
+* WebCore.xcodeproj/project.pbxproj:
+* page/PageGroup.cpp:
+(WebCore::PageGroup::PageGroup):
+* page/PageGroup.h:
+(WebCore::PageGroup::visitedLinkProvider):
+* page/VisitedLinkProvider.cpp: Added.
+(WebCore::VisitedLinkProvider::VisitedLinkProvider):
+(WebCore::VisitedLinkProvider::~VisitedLinkProvider):
+* page/VisitedLinkProvider.h: Added.
+(WebCore::VisitedLinkProvider::create):
+
2014-01-28 Gurpreet Kaur
Add support for menclose element
Modified: trunk/Source/WebCore/GNUmakefile.list.am (162936 => 162937)
--- trunk/Source/WebCore/GNUmakefile.list.am 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/GNUmakefile.list.am 2014-01-28 17:28:44 UTC (rev 162937)
@@ -4220,6 +4220,8 @@
Source/WebCore/page/UserStyleSheetTypes.h \
Source/WebCore/page/ValidationMessageClient.h \
Source/WebCore/page/ViewState.h \
+ Source/WebCore/page/VisitedLinkProvider.cpp \
+ Source/WebCore/page/VisitedLinkProvider.h \
Source/WebCore/page/WebCoreKeyboardUIMode.h \
Source/WebCore/page/WebKitPoint.h \
Source/WebCore/page/WindowFeatures.cpp \
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (162936 => 162937)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2014-01-28 17:28:44 UTC (rev 162937)
@@ -7059,6 +7059,7 @@
+
@@ -18830,6 +18831,7 @@
+
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (162936 => 162937)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2014-01-28 17:28:44 UTC (rev 162937)
@@ -792,6 +792,9 @@
page
+
+ page
+
page
@@ -7649,6 +7652,9 @@
page
+
+ page
+
page
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (162936 => 162937)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-28 17:19:05 UTC (rev 162936)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-01-28 17:28:44 UTC (rev 162937)
@@ -795,6 +795,8 @@
1ABA76C911D20E47004C201C /* ColorData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E406F3FB1198307D009D59D
[webkit-changes] [162935] trunk/Source/WTF
Title: [162935] trunk/Source/WTF
Revision 162935
Author ander...@apple.com
Date 2014-01-28 09:13:41 -0800 (Tue, 28 Jan 2014)
Log Message
Use std::mutex instead of WTF::Mutex in WTF
https://bugs.webkit.org/show_bug.cgi?id=127783
Reviewed by Antti Koivisto.
* wtf/CryptographicallyRandomNumber.cpp:
* wtf/MainThread.cpp:
(WTF::mainThreadFunctionQueueMutex):
(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):
(WTF::cancelCallOnMainThread):
* wtf/StackStats.cpp:
(WTF::StackStats::initialize):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):
* wtf/StackStats.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CryptographicallyRandomNumber.cpp
trunk/Source/WTF/wtf/MainThread.cpp
trunk/Source/WTF/wtf/StackStats.cpp
trunk/Source/WTF/wtf/StackStats.h
Diff
Modified: trunk/Source/WTF/ChangeLog (162934 => 162935)
--- trunk/Source/WTF/ChangeLog 2014-01-28 17:07:38 UTC (rev 162934)
+++ trunk/Source/WTF/ChangeLog 2014-01-28 17:13:41 UTC (rev 162935)
@@ -1,3 +1,26 @@
+2014-01-28 Anders Carlsson
+
+Use std::mutex instead of WTF::Mutex in WTF
+https://bugs.webkit.org/show_bug.cgi?id=127783
+
+Reviewed by Antti Koivisto.
+
+* wtf/CryptographicallyRandomNumber.cpp:
+* wtf/MainThread.cpp:
+(WTF::mainThreadFunctionQueueMutex):
+(WTF::functionQueue):
+(WTF::dispatchFunctionsFromMainThread):
+(WTF::callOnMainThread):
+(WTF::cancelCallOnMainThread):
+* wtf/StackStats.cpp:
+(WTF::StackStats::initialize):
+(WTF::StackStats::CheckPoint::CheckPoint):
+(WTF::StackStats::CheckPoint::~CheckPoint):
+(WTF::StackStats::probe):
+(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):
+(WTF::StackStats::LayoutCheckPoint::~LayoutCheckPoint):
+* wtf/StackStats.h:
+
2014-01-27 Joseph Pecoraro
WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Modified: trunk/Source/WTF/wtf/CryptographicallyRandomNumber.cpp (162934 => 162935)
--- trunk/Source/WTF/wtf/CryptographicallyRandomNumber.cpp 2014-01-28 17:07:38 UTC (rev 162934)
+++ trunk/Source/WTF/wtf/CryptographicallyRandomNumber.cpp 2014-01-28 17:13:41 UTC (rev 162935)
@@ -32,7 +32,7 @@
#include "NeverDestroyed.h"
#include "OSRandomSource.h"
-#include "ThreadingPrimitives.h"
+#include
namespace WTF {
@@ -64,7 +64,7 @@
ARC4Stream m_stream;
int m_count;
-Mutex m_mutex;
+std::mutex m_mutex;
};
ARC4Stream::ARC4Stream()
@@ -136,7 +136,7 @@
uint32_t ARC4RandomNumberGenerator::randomNumber()
{
-MutexLocker locker(m_mutex);
+std::lock_guard lock(m_mutex);
m_count -= 4;
stirIfNeeded();
@@ -145,7 +145,7 @@
void ARC4RandomNumberGenerator::randomValues(void* buffer, size_t length)
{
-MutexLocker locker(m_mutex);
+std::lock_guard lock(m_mutex);
unsigned char* result = reinterpret_cast(buffer);
stirIfNeeded();
Modified: trunk/Source/WTF/wtf/MainThread.cpp (162934 => 162935)
--- trunk/Source/WTF/wtf/MainThread.cpp 2014-01-28 17:07:38 UTC (rev 162934)
+++ trunk/Source/WTF/wtf/MainThread.cpp 2014-01-28 17:13:41 UTC (rev 162935)
@@ -33,7 +33,8 @@
#include "Deque.h"
#include "Functional.h"
#include "StdLibExtras.h"
-#include "Threading.h"
+#include
+#include
#include
namespace WTF {
@@ -68,16 +69,17 @@
static ThreadIdentifier mainThreadIdentifier;
#endif
-static Mutex& mainThreadFunctionQueueMutex()
+static std::mutex& mainThreadFunctionQueueMutex()
{
-DEFINE_STATIC_LOCAL(Mutex, staticMutex, ());
-return staticMutex;
+static NeverDestroyed mutex;
+
+return mutex;
}
static FunctionQueue& functionQueue()
{
-DEFINE_STATIC_LOCAL(FunctionQueue, staticFunctionQueue, ());
-return staticFunctionQueue;
+static NeverDestroyed functionQueue;
+return functionQueue;
}
@@ -154,7 +156,7 @@
FunctionWithContext invocation;
while (true) {
{
-MutexLocker locker(mainThreadFunctionQueueMutex());
+std::lock_guard lock(mainThreadFunctionQueueMutex());
if (!functionQueue().size())
break;
invocation = functionQueue().takeFirst();
@@ -178,7 +180,7 @@
ASSERT(function);
bool needToSchedule = false;
{
-MutexLocker locker(mainThreadFunctionQueueMutex());
+std::lock_guard lock(mainThreadFunctionQueueMutex());
needToSchedule = functionQueue().size() == 0;
functionQueue().append(FunctionWithContext(function, context));
}
@@ -190,7 +192,7 @@
{
ASSERT(function);
-MutexLocker locker(mainThreadFunctionQueueMutex());
+std::lock_guard lock(mainThreadFunctionQueueMutex());
FunctionWithContextFinder pred(FunctionWithContext(fun
[webkit-changes] [162936] trunk/Source/WebKit2
Title: [162936] trunk/Source/WebKit2
Revision 162936
Author timothy_hor...@apple.com
Date 2014-01-28 09:19:05 -0800 (Tue, 28 Jan 2014)
Log Message
WebKit2 View Gestures (Swipe): Use CGSCaptureWindowsContentsToRect for now
https://bugs.webkit.org/show_bug.cgi?id=127768
Reviewed by Simon Fraser.
* UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
Until is resolved, we'll use
CGSCaptureWindowsContentsToRect instead of CGWindowListCreateImage.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162935 => 162936)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 17:13:41 UTC (rev 162935)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 17:19:05 UTC (rev 162936)
@@ -1,3 +1,16 @@
+2014-01-28 Tim Horton
+
+WebKit2 View Gestures (Swipe): Use CGSCaptureWindowsContentsToRect for now
+https://bugs.webkit.org/show_bug.cgi?id=127768
+
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _takeViewSnapshot]):
+Until is resolved, we'll use
+CGSCaptureWindowsContentsToRect instead of CGWindowListCreateImage.
+
2014-01-28 Mark Rowe
Disable some deprecation warnings to fix the build.
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (162935 => 162936)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-28 17:13:41 UTC (rev 162935)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2014-01-28 17:19:05 UTC (rev 162936)
@@ -117,6 +117,7 @@
#if defined(__has_include) && __has_include()
#import
+#import
#endif
extern "C" {
@@ -124,6 +125,7 @@
typedef uint32_t CGSWindowID;
CGSConnectionID CGSMainConnectionID(void);
CGError CGSGetScreenRectForWindow(CGSConnectionID cid, CGSWindowID wid, CGRect *rect);
+CGError CGSCaptureWindowsContentsToRect(CGSConnectionID cid, const CGSWindowID windows[], uint32_t windowCount, CGRect rect, CGImageRef *outImage);
};
using namespace WebKit;
@@ -2545,7 +2547,11 @@
if (![window windowNumber])
return nullptr;
-RetainPtr windowSnapshotImage = adoptCF(CGWindowListCreateImage(CGRectNull, kCGWindowListOptionIncludingWindow, [window windowNumber], kCGWindowImageBoundsIgnoreFraming | kCGWindowImageShouldBeOpaque));
+// FIXME: This should use CGWindowListCreateImage once is resolved.
+CGSWindowID windowID = [window windowNumber];
+CGImageRef cgWindowImage = nullptr;
+CGSCaptureWindowsContentsToRect(CGSMainConnectionID(), &windowID, 1, CGRectNull, &cgWindowImage);
+RetainPtr windowSnapshotImage = adoptCF(cgWindowImage);
NSRect windowCaptureRect = [self convertRect:self.bounds toView:nil];
NSRect windowCaptureScreenRect = [window convertRectToScreen:windowCaptureRect];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162934] branches/jsCStack/Source/JavaScriptCore
Title: [162934] branches/jsCStack/Source/_javascript_Core
Revision 162934
Author msab...@apple.com
Date 2014-01-28 09:07:38 -0800 (Tue, 28 Jan 2014)
Log Message
CStack Branch: Some LLInt symbols not declared extern "C"
https://bugs.webkit.org/show_bug.cgi?id=127782
Reviewed by Geoffrey Garen.
Added 'extern "C"' to the definitions of llint_throw_stack_overflow_error() and
llint_stack_check_at_vm_entry(). Added WTF_INTERNAL to their declarations.
* _javascript_Core.xcodeproj/project.pbxproj:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_throw_stack_overflow_error):
(JSC::LLInt::llint_stack_check_at_vm_entry):
* llint/LLIntSlowPaths.h:
Modified Paths
branches/jsCStack/Source/_javascript_Core/ChangeLog
branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.h
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (162933 => 162934)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 16:34:52 UTC (rev 162933)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-28 17:07:38 UTC (rev 162934)
@@ -1,3 +1,19 @@
+2014-01-28 Michael Saboff
+
+CStack Branch: Some LLInt symbols not declared extern "C"
+https://bugs.webkit.org/show_bug.cgi?id=127782
+
+Reviewed by Geoffrey Garen.
+
+Added 'extern "C"' to the definitions of llint_throw_stack_overflow_error() and
+llint_stack_check_at_vm_entry(). Added WTF_INTERNAL to their declarations.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::llint_throw_stack_overflow_error):
+(JSC::LLInt::llint_stack_check_at_vm_entry):
+* llint/LLIntSlowPaths.h:
+
2014-01-27 Mark Hahnenberg
Merge branch up to ToT r162909.
Modified: branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.cpp (162933 => 162934)
--- branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2014-01-28 16:34:52 UTC (rev 162933)
+++ branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.cpp 2014-01-28 17:07:38 UTC (rev 162934)
@@ -1420,7 +1420,7 @@
LLINT_END();
}
-SlowPathReturnType llint_throw_stack_overflow_error(VM* vm, ProtoCallFrame* protoFrame)
+extern "C" SlowPathReturnType llint_throw_stack_overflow_error(VM* vm, ProtoCallFrame* protoFrame)
{
ExecState* exec = vm->topCallFrame;
if (!exec)
@@ -1430,7 +1430,7 @@
}
#if ENABLE(LLINT_C_LOOP)
-SlowPathReturnType llint_stack_check_at_vm_entry(VM* vm, Register* newTopOfStack)
+extern "C" SlowPathReturnType llint_stack_check_at_vm_entry(VM* vm, Register* newTopOfStack)
{
bool success = vm->interpreter->stack().ensureCapacityFor(newTopOfStack);
return encodeResult(reinterpret_cast(success), 0);
Modified: branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.h (162933 => 162934)
--- branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.h 2014-01-28 16:34:52 UTC (rev 162933)
+++ branches/jsCStack/Source/_javascript_Core/llint/LLIntSlowPaths.h 2014-01-28 17:07:38 UTC (rev 162934)
@@ -42,7 +42,7 @@
extern "C" SlowPathReturnType llint_trace_operand(ExecState*, Instruction*, int fromWhere, int operand);
extern "C" SlowPathReturnType llint_trace_value(ExecState*, Instruction*, int fromWhere, int operand);
-extern "C" void llint_write_barrier_slow(ExecState*, JSCell*);
+extern "C" void llint_write_barrier_slow(ExecState*, JSCell*) WTF_INTERNAL;
#define LLINT_SLOW_PATH_DECL(name) \
extern "C" SlowPathReturnType llint_##name(ExecState* exec, Instruction* pc)
@@ -124,9 +124,9 @@
LLINT_SLOW_PATH_HIDDEN_DECL(slow_path_resolve_scope);
LLINT_SLOW_PATH_HIDDEN_DECL(slow_path_get_from_scope);
LLINT_SLOW_PATH_HIDDEN_DECL(slow_path_put_to_scope);
-extern "C" SlowPathReturnType llint_throw_stack_overflow_error(VM*, ProtoCallFrame*);
+extern "C" SlowPathReturnType llint_throw_stack_overflow_error(VM*, ProtoCallFrame*) WTF_INTERNAL;
#if ENABLE(LLINT_C_LOOP)
-extern "C" SlowPathReturnType llint_stack_check_at_vm_entry(VM*, Register*);
+extern "C" SlowPathReturnType llint_stack_check_at_vm_entry(VM*, Register*) WTF_INTERNAL;
#endif
} } // namespace JSC::LLInt
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162931] trunk/Source/WebInspectorUI
Title: [162931] trunk/Source/WebInspectorUI
Revision 162931
Author commit-qu...@webkit.org
Date 2014-01-28 07:40:29 -0800 (Tue, 28 Jan 2014)
Log Message
Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell
https://bugs.webkit.org/show_bug.cgi?id=127613
Patch by Diego Pino Garcia on 2014-01-28
Reviewed by Timothy Hatcher.
* UserInterface/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype._editingCallback):
* UserInterface/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.createCell):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/DOMStorageContentView.js
trunk/Source/WebInspectorUI/UserInterface/DataGrid.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (162930 => 162931)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 15:08:31 UTC (rev 162930)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-01-28 15:40:29 UTC (rev 162931)
@@ -1,3 +1,18 @@
+2014-01-28 Diego Pino Garcia
+
+Web Inspector: In a DataGrid, store value of columnIdentifier to DOM node representing a cell
+https://bugs.webkit.org/show_bug.cgi?id=127613
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/DOMStorageContentView.js:
+(WebInspector.DOMStorageContentView.prototype._editingCallback):
+* UserInterface/DataGrid.js:
+(WebInspector.DataGrid):
+(WebInspector.DataGrid.prototype._keyDown):
+(WebInspector.DataGrid.prototype._contextMenuInDataTable):
+(WebInspector.DataGridNode.prototype.createCell):
+
2014-01-27 Joseph Pecoraro
Web Inspector: Feature Check all Protocol Generated Interfaces to get JSContext Inspection working
Modified: trunk/Source/WebInspectorUI/UserInterface/DOMStorageContentView.js (162930 => 162931)
--- trunk/Source/WebInspectorUI/UserInterface/DOMStorageContentView.js 2014-01-28 15:08:31 UTC (rev 162930)
+++ trunk/Source/WebInspectorUI/UserInterface/DOMStorageContentView.js 2014-01-28 15:40:29 UTC (rev 162931)
@@ -215,7 +215,7 @@
_editingCallback: function(editingNode, columnIdentifier, oldText, newText)
{
var domStorage = this.representedObject;
-if (columnIdentifier === 0) {
+if (columnIdentifier === "0") {
if (oldText)
domStorage.removeItem(oldText);
Modified: trunk/Source/WebInspectorUI/UserInterface/DataGrid.js (162930 => 162931)
--- trunk/Source/WebInspectorUI/UserInterface/DataGrid.js 2014-01-28 15:08:31 UTC (rev 162930)
+++ trunk/Source/WebInspectorUI/UserInterface/DataGrid.js 2014-01-28 15:40:29 UTC (rev 162931)
@@ -153,6 +153,7 @@
var column = columns[columnIdentifier];
var td = document.createElement("td");
td.className = columnIdentifier + "-column";
+td.__columnIdentifier = columnIdentifier;
var group = this.groups[columnIdentifier];
if (group)
td.classList.add("column-group-" + group);
@@ -343,8 +344,7 @@
// FIXME: We need more column identifiers here throughout this function.
// Not needed yet since only editable DataGrid is DOM Storage, which is Key - Value.
-// FIXME: Better way to do this than regular expressions?
-var columnIdentifier = parseInt(element.className.match(/\b(\d+)-column\b/)[1], 10);
+var columnIdentifier = element.__columnIdentifier;
var textBeforeEditing = this._editingNode.data[columnIdentifier] || "";
var currentEditingNode = this._editingNode;
@@ -901,8 +901,6 @@
} else if (isEnterKey(event)) {
if (this._editCallback) {
handled = true;
-// The first child of the selected element is the ,
-// and that's what we want to edit.
this._startEditing(this.selectedNode._element.children[0]);
}
}
@@ -1137,7 +1135,7 @@
contextMenu.appendItem(WebInspector.UIString("Add New"), this._startEditing.bind(this, event.target));
else {
var element = event.target.enclosingNodeOrSelfWithNodeName("td");
-var columnIdentifier = parseInt(element.className.match(/\b(\d+)-column\b/)[1], 10);
+var columnIdentifier = element.__columnIdentifier;
var columnTitle = this.dataGrid.columns[columnIdentifier].title;
contextMenu.appendItem(WebInspector.UIString("Edit “%s”").format(columnTitle), this._startEditing.bind(this, event.target));
}
@@ -1518,6 +1516,7 @@
{
var cell = document.createElement("td");
cell.className = columnIdentifier + "-column";
+cell.__columnIdentifier = columnIdentifier;
var alignment = this.dataGrid.aligned[columnIdentifier];
if
[webkit-changes] [162930] trunk/Source/WebKit/efl
Title: [162930] trunk/Source/WebKit/efl
Revision 162930
Author zandober...@gmail.com
Date 2014-01-28 07:08:31 -0800 (Tue, 28 Jan 2014)
Log Message
Remove unnecessary forward declarations of MessagePortChannel, MessagePortChannelArray in DumpRenderTreeSupportEfl.h
https://bugs.webkit.org/show_bug.cgi?id=127654
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/DumpRenderTreeSupportEfl.h: Remove the forward declarations of MessagePortChannel
and MessagePortChannelArray. They were most likely at one point used in DRT support methods, but are
not necessary anymore.
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (162929 => 162930)
--- trunk/Source/WebKit/efl/ChangeLog 2014-01-28 10:40:58 UTC (rev 162929)
+++ trunk/Source/WebKit/efl/ChangeLog 2014-01-28 15:08:31 UTC (rev 162930)
@@ -1,3 +1,14 @@
+2014-01-28 Zan Dobersek
+
+Remove unnecessary forward declarations of MessagePortChannel, MessagePortChannelArray in DumpRenderTreeSupportEfl.h
+https://bugs.webkit.org/show_bug.cgi?id=127654
+
+Reviewed by Alexey Proskuryakov.
+
+* WebCoreSupport/DumpRenderTreeSupportEfl.h: Remove the forward declarations of MessagePortChannel
+and MessagePortChannelArray. They were most likely at one point used in DRT support methods, but are
+not necessary anymore.
+
2014-01-27 Carlos Garcia Campos
[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (162929 => 162930)
--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2014-01-28 10:40:58 UTC (rev 162929)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h 2014-01-28 15:08:31 UTC (rev 162930)
@@ -41,8 +41,6 @@
namespace WebCore {
class Frame;
-class MessagePortChannel;
-typedef Vector, 1> MessagePortChannelArray;
}
class EAPI DumpRenderTreeSupportEfl {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162929] trunk/Source
Title: [162929] trunk/Source
Revision 162929
Author mr...@apple.com
Date 2014-01-28 02:40:58 -0800 (Tue, 28 Jan 2014)
Log Message
Disable some deprecation warnings to fix the build.
Reviewed by Ryosuke Niwa.
Source/WebCore:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestinationMac::configure):
* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
Source/WebKit/mac:
* WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::populate):
Source/WebKit2:
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp
trunk/Source/WebCore/platform/audio/mac/AudioFileReaderMac.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/PopupMenuMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (162928 => 162929)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 10:22:47 UTC (rev 162928)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 10:40:58 UTC (rev 162929)
@@ -1,3 +1,18 @@
+2014-01-28 Mark Rowe
+
+ Disable some deprecation warnings to fix the build.
+
+Reviewed by Ryosuke Niwa.
+
+* accessibility/mac/AXObjectCacheMac.mm:
+(WebCore::AXObjectCache::postPlatformNotification):
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
+* platform/audio/mac/AudioDestinationMac.cpp:
+(WebCore::AudioDestinationMac::configure):
+* platform/audio/mac/AudioFileReaderMac.cpp:
+(WebCore::AudioFileReader::createBus):
+
2014-01-28 Carlos Garcia Campos
[SOUP] Remove soupURIToKURL
Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (162928 => 162929)
--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-01-28 10:22:47 UTC (rev 162928)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2014-01-28 10:40:58 UTC (rev 162929)
@@ -135,7 +135,10 @@
// NSAccessibilityPostNotification will call this method, (but not when running DRT), so ASSERT here to make sure it does not crash.
// https://bugs.webkit.org/show_bug.cgi?id=46662
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
ASSERT([obj->wrapper() accessibilityIsIgnored] || true);
+#pragma clang diagnostic pop
NSAccessibilityPostNotification(obj->wrapper(), macNotification);
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (162928 => 162929)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-28 10:22:47 UTC (rev 162928)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2014-01-28 10:40:58 UTC (rev 162929)
@@ -1531,7 +1531,10 @@
Widget* widget = m_object->widget();
if (!widget)
return nil;
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
return [(widget->platformWidget()) accessibilityAttributeValue: NSAccessibilityChildrenAttribute];
+#pragma clang diagnostic pop
}
- (id)remoteAccessibilityParentObject
@@ -1835,6 +1838,8 @@
return NSAccessibilityUnknownRole;
}
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- (NSString*)subrole
{
if (m_object->isPasswordField())
@@ -1979,6 +1984,7 @@
return nil;
}
+#pragma clang diagnostic pop
- (NSString*)roleDescription
{
@@ -3625,6 +3631,8 @@
return NSNotFound;
}
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- (NSUInteger)accessibilityArrayAttributeCount:(NSString *)attribute
{
if (![self updateObjectBackingStore])
@@ -3645,6 +3653,7 @@
return [super accessibilityArrayAttributeCount:attribute];
}
+#pragma clang diagnostic pop
- (NSArray *)accessibilityArrayAttributeValues:(NSString *)attribute index:(NSUInteger)index maxCount:(NSUInteger)maxCount
{
Modified: trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp (162928 => 162929)
--- trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp 2014-01-28 10:22:47 UTC (rev 162928)
+++ trunk/Source/WebCore/platform/audio/mac/AudioDestinationMac.cpp 2014-01-28 10:40:58 UTC (rev 162929)
@@ -124,6 +124,8 @@
OSStatus result = AudioUnitSetPropert
[webkit-changes] [162928] trunk
Title: [162928] trunk
Revision 162928
Author commit-qu...@webkit.org
Date 2014-01-28 02:22:47 -0800 (Tue, 28 Jan 2014)
Log Message
[GTK] Add API to allow setting the process model in WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=125463
Patch by Adrian Perez de Castro on 2014-01-28
Reviewed by Carlos Garcia Campos.
Implements accessors in WebKitWebContext for the process model.
The default behavior is unchanged, and a single web process is
used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
as the process model will make use one web process for each
WebKitWebView. This also enables the network process. Setting
the process model must be done as early as possible, before the
very first web process is spawned.
Source/WebKit2:
* UIProcess/API/gtk/WebKitWebContext.cpp:
Add accessors in the API to get/set the process model.
(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):
* UIProcess/API/gtk/WebKitWebContext.h:
Define the WebKitProcessModel enum.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
Add new public API bits to the documentation.
Tools:
* MiniBrowser/gtk/main.c:
(main):
Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
environment variable is defined and not empty.
* TestWebKitAPI/GNUmakefile.am:
Add new TestMultiprocess test case.
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
Add new TestMultiprocess test case.
* TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
(loadChanged):
(testMultipleSecondaryProcesses):
(initializeWebExtensions):
(beforeAll):
(afterAll):
* TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(methodCallCallback):
Implement the GetProcessIdentifier D-Bus method.
(makeBusName):
Choose a different bus name when the web extension is used
from TestMultiprocess.
(webkit_web_extension_initialize_with_user_data):
Use makeBusName() to choose the bus name.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/main.c
trunk/Tools/TestWebKitAPI/GNUmakefile.am
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (162927 => 162928)
--- trunk/Source/WebKit2/ChangeLog 2014-01-28 10:02:21 UTC (rev 162927)
+++ trunk/Source/WebKit2/ChangeLog 2014-01-28 10:22:47 UTC (rev 162928)
@@ -1,3 +1,27 @@
+2014-01-28 Adrian Perez de Castro
+
+[GTK] Add API to allow setting the process model in WebKitWebContext
+https://bugs.webkit.org/show_bug.cgi?id=125463
+
+Reviewed by Carlos Garcia Campos.
+
+Implements accessors in WebKitWebContext for the process model.
+The default behavior is unchanged, and a single web process is
+used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
+as the process model will make use one web process for each
+WebKitWebView. This also enables the network process. Setting
+the process model must be done as early as possible, before the
+very first web process is spawned.
+
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+Add accessors in the API to get/set the process model.
+(webkit_web_context_set_process_model):
+(webkit_web_context_get_process_model):
+* UIProcess/API/gtk/WebKitWebContext.h:
+Define the WebKitProcessModel enum.
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
+Add new public API bits to the documentation.
+
2014-01-27 Carlos Garcia Campos
[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (162927 => 162928)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2014-01-28 10:02:21 UTC (rev 162927)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2014-01-28 10:22:47 UTC (rev 162928)
@@ -64,8 +64,9 @@
* The #WebKitWebContext manages all aspects common to all
* #WebKitWebViews.
*
- * You can define the #WebKitCacheModel with
- * webkit_web_context_set_cache_model(), depending on the needs of
+ * You can define the #WebKitCacheModel and #WebKitProcessModel with
+ * webkit_web_context_set_cache_model() and
+ * webkit_web_context_set_process_model(), depending on the needs of
* your application. You can access the #WebKitCookieManager or the
* #WebKitSecurityManager to specify the behaviour of your application
* regarding cookies and security, using
@@ -161,6 +162,9 @@
static guint signals[LAST_SIGNAL] = { 0, };
+COMPILE_ASSERT_MATCHING_ENUM(WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS, ProcessModelSharedSecondaryProcess);
+COMPILE_ASSERT_M
[webkit-changes] [162927] tags/Safari-538.14/Source/WebCore
Title: [162927] tags/Safari-538.14/Source/WebCore
Revision 162927
Author bshaf...@apple.com
Date 2014-01-28 02:02:21 -0800 (Tue, 28 Jan 2014)
Log Message
Merged r162885.
Modified Paths
tags/Safari-538.14/Source/WebCore/ChangeLog
tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h
tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h
Diff
Modified: tags/Safari-538.14/Source/WebCore/ChangeLog (162926 => 162927)
--- tags/Safari-538.14/Source/WebCore/ChangeLog 2014-01-28 09:56:14 UTC (rev 162926)
+++ tags/Safari-538.14/Source/WebCore/ChangeLog 2014-01-28 10:02:21 UTC (rev 162927)
@@ -1,9 +1,20 @@
2014-01-28 Babak Shafiei
-Merge r162881
+Merge r162885
2014-01-27 Andy Estes
+Update bindings test expectations after r162872
+
+* bindings/scripts/test/ObjC/DOMTestInterface.h:
+* bindings/scripts/test/ObjC/DOMTestObj.h:
+
+2014-01-28 Babak Shafiei
+
+Merge r162881
+
+2014-01-27 Andy Estes
+
Scrub WebKit API headers of WTF macros
https://bugs.webkit.org/show_bug.cgi?id=127706
Modified: tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h (162926 => 162927)
--- tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h 2014-01-28 09:56:14 UTC (rev 162926)
+++ tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h 2014-01-28 10:02:21 UTC (rev 162927)
@@ -31,18 +31,6 @@
@class NSString;
enum {
-#if ENABLE(Condition22) || ENABLE(Condition23)
-DOM_IMPLEMENTSCONSTANT1 = 1,
-#endif
-#if ENABLE(Condition22) || ENABLE(Condition23)
-DOM_IMPLEMENTSCONSTANT2 = 2,
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-DOM_SUPPLEMENTALCONSTANT1 = 1,
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-DOM_SUPPLEMENTALCONSTANT2 = 2
-#endif
} WEBKIT_ENUM_AVAILABLE_MAC(TBD);
@@ -56,29 +44,4 @@
@property (copy) NSString *supplementalStr2;
@property (copy) NSString *supplementalStr3;
@property (strong) DOMNode *supplementalNode;
-
-#if ENABLE(Condition22) || ENABLE(Condition23)
-- (void)implementsMethod1;
-#endif
-#if ENABLE(Condition22) || ENABLE(Condition23)
-- (DOMTestObj *)implementsMethod2:(NSString *)strArg objArg:(DOMTestObj *)objArg;
-#endif
-#if ENABLE(Condition22) || ENABLE(Condition23)
-- (void)implementsMethod3;
-#endif
-#if ENABLE(Condition22) || ENABLE(Condition23)
-- (void)implementsMethod4;
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-- (void)supplementalMethod1;
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-- (DOMTestObj *)supplementalMethod2:(NSString *)strArg objArg:(DOMTestObj *)objArg;
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-- (void)supplementalMethod3;
-#endif
-#if ENABLE(Condition11) || ENABLE(Condition12)
-- (void)supplementalMethod4;
-#endif
@end
Modified: tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h (162926 => 162927)
--- tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h 2014-01-28 09:56:14 UTC (rev 162926)
+++ tags/Safari-538.14/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h 2014-01-28 10:02:21 UTC (rev 162927)
@@ -44,9 +44,6 @@
@protocol DOMEventListener;
enum {
-#if ENABLE(Condition1)
-DOM_CONDITIONAL_CONST = 0,
-#endif
DOM_CONST_VALUE_0 = 0,
DOM_CONST_VALUE_1 = 1,
DOM_CONST_VALUE_2 = 2,
@@ -159,24 +156,9 @@
- (void)methodWithOptionalString:(NSString *)str;
- (void)methodWithOptionalStringIsUndefined:(NSString *)str;
- (void)methodWithOptionalStringIsNullString:(NSString *)str;
-#if ENABLE(Condition1)
-- (NSString *)conditionalMethod1;
-#endif
-#if ENABLE(Condition1) && ENABLE(Condition2)
-- (void)conditionalMethod2;
-#endif
-#if ENABLE(Condition1) || ENABLE(Condition2)
-- (void)conditionalMethod3;
-#endif
- (void)classMethod;
- (int)classMethodWithOptional:(int)arg;
- (void)classMethod2:(int)arg;
-#if ENABLE(Condition1)
-- (void)overloadedMethod1:(int)arg;
-#endif
-#if ENABLE(Condition1)
-- (void)overloadedMethod1:(NSString *)type;
-#endif
- (DOMSVGDocument *)getSVGDocument;
- (void)convert1:(DOMTestNode *)value;
- (void)convert2:(DOMTestNode *)value;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162926] tags/Safari-538.14
Title: [162926] tags/Safari-538.14 Revision 162926 Author bshaf...@apple.com Date 2014-01-28 01:56:14 -0800 (Tue, 28 Jan 2014) Log Message Merged r162881. Modified Paths tags/Safari-538.14/Source/_javascript_Core/ChangeLog tags/Safari-538.14/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig tags/Safari-538.14/Source/WebCore/ChangeLog tags/Safari-538.14/Source/WebCore/Configurations/FeatureDefines.xcconfig tags/Safari-538.14/Source/WebCore/bindings/objc/DOMEvents.h tags/Safari-538.14/Source/WebCore/platform/graphics/mac/MediaPlayerProxy.h tags/Safari-538.14/Source/WebCore/platform/ios/SystemMemory.h tags/Safari-538.14/Source/WebCore/platform/ios/wak/WKGraphics.h tags/Safari-538.14/Source/WebKit/ios/ChangeLog tags/Safari-538.14/Source/WebKit/ios/WebCoreSupport/WebMIMETypeRegistry.h tags/Safari-538.14/Source/WebKit/mac/ChangeLog tags/Safari-538.14/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig tags/Safari-538.14/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h tags/Safari-538.14/Source/WebKit/mac/postprocess-headers.sh tags/Safari-538.14/Source/WebKit2/ChangeLog tags/Safari-538.14/Source/WebKit2/Configurations/FeatureDefines.xcconfig tags/Safari-538.14/Tools/ChangeLog tags/Safari-538.14/Tools/Scripts/check-for-inappropriate-macros-in-external-headers Diff Modified: tags/Safari-538.14/Source/_javascript_Core/ChangeLog (162925 => 162926) --- tags/Safari-538.14/Source/_javascript_Core/ChangeLog 2014-01-28 09:38:06 UTC (rev 162925) +++ tags/Safari-538.14/Source/_javascript_Core/ChangeLog 2014-01-28 09:56:14 UTC (rev 162926) @@ -1,3 +1,16 @@ +2014-01-28 Babak Shafiei + +Merge r162881 + +2014-01-27 Andy Estes + +Scrub WebKit API headers of WTF macros +https://bugs.webkit.org/show_bug.cgi?id=127706 + +Reviewed by David Kilzer. + +* Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR. + 2014-01-26 Joseph Pecoraro Web Inspector: Move InspectorDebuggerAgent into _javascript_Core Modified: tags/Safari-538.14/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (162925 => 162926) --- tags/Safari-538.14/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-01-28 09:38:06 UTC (rev 162925) +++ tags/Safari-538.14/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-01-28 09:56:14 UTC (rev 162926) @@ -113,6 +113,7 @@ ENABLE_INPUT_TYPE_WEEK = $(ENABLE_INPUT_TYPE_WEEK_$(PLATFORM_NAME)); ENABLE_INPUT_TYPE_WEEK_iphoneos = ENABLE_INPUT_TYPE_WEEK; ENABLE_INPUT_TYPE_WEEK_iphonesimulator = $(ENABLE_INPUT_TYPE_WEEK_iphoneos); +ENABLE_INSPECTOR = ENABLE_INSPECTOR; ENABLE_IOS_AIRPLAY = $(ENABLE_IOS_AIRPLAY_$(PLATFORM_NAME)); ENABLE_IOS_AIRPLAY_iphoneos = ENABLE_IOS_AIRPLAY; ENABLE_IOS_AIRPLAY_iphonesimulator = $(ENABLE_IOS_AIRPLAY_iphoneos); @@ -195,4 +196,4 @@ ENABLE_FTL_JIT = ; ENABLE_LLINT_C_LOOP = ; -FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_BLOB) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CANVAS_PATH) $(ENABLE_CANVAS_PROXY) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CSP_NEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_REGIONS) $(ENABLE_CSS_SHAPES) $(ENABLE_CSS_STICKY_POSITION) $(ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED) $(ENABLE_CSS3_CONDITIONAL_RULES) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS3_TEXT_LINE_BREAK) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM4_EVENTS_CONSTRUCTOR) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_ENCRYPTED_MEDIA_V2) $(ENABLE_FILTERS) $(ENABLE_FONT_LOAD_EVENTS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING) $(ENABLE_HIGH_DPI_CANVAS) $(ENABLE_ICONDATABASE) $(ENABLE_IFRAME_SEAMLESS) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDIE_UI) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_COLOR_POPOVER) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_IOS_AIRPLAY) $(ENABLE_IOS_TEXT_AUTOSIZING) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_NOTIFICATIONS) $(ENABLE_LEGACY_VENDOR_PREFIXES) $(ENABLE_LEGACY_WEB_AUDIO) $(ENABLE_LETTERPRESS) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_PLUGIN_PROXY_FOR_VIDEO) $(ENA
[webkit-changes] [162925] tags/Safari-538.14/Source/WebCore
Title: [162925] tags/Safari-538.14/Source/WebCore
Revision 162925
Author bshaf...@apple.com
Date 2014-01-28 01:38:06 -0800 (Tue, 28 Jan 2014)
Log Message
Merged r162872.
Modified Paths
tags/Safari-538.14/Source/WebCore/ChangeLog
tags/Safari-538.14/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
Diff
Modified: tags/Safari-538.14/Source/WebCore/ChangeLog (162924 => 162925)
--- tags/Safari-538.14/Source/WebCore/ChangeLog 2014-01-28 09:21:07 UTC (rev 162924)
+++ tags/Safari-538.14/Source/WebCore/ChangeLog 2014-01-28 09:38:06 UTC (rev 162925)
@@ -1,3 +1,27 @@
+2014-01-28 Babak Shafiei
+
+Merge r162872
+
+2014-01-27 Andy Estes
+
+Stop the code generator from adding ENABLE() macros to Objective-C DOM headers
+https://bugs.webkit.org/show_bug.cgi?id=127706
+
+Reviewed by David Kilzer.
+
+Instead of adding ENABLE() macros to generated Objective-C DOM
+headers, which might become Public or Private headers, elide generated
+code for disabled features.
+
+* bindings/scripts/CodeGeneratorObjC.pm:
+(GenerateInterface): Passed $defines to GenerateHeader.
+(ConditionalIsEnabled): Checked if the given conditional is found in
+$defines. Handled conditionals with '&' and '|'.
+(GenerateHeader): Rather than calling GenerateConditionalString to
+generate an "#if ENABLE(...)", called ConditionalIsEnabled() to see
+whether we should generate code for the given constant, attribute, or
+function.
+
2014-01-26 Chris Fleizach
AX: Disable accessibility after every test run
Modified: tags/Safari-538.14/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm (162924 => 162925)
--- tags/Safari-538.14/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-01-28 09:21:07 UTC (rev 162924)
+++ tags/Safari-538.14/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm 2014-01-28 09:38:06 UTC (rev 162925)
@@ -28,6 +28,8 @@
use constant FileNamePrefix => "DOM";
+sub ConditionalIsEnabled(\%$);
+
# Global Variables
my $writeDependencies = 0;
my %publicInterfaces = ();
@@ -376,7 +378,7 @@
ReadPublicInterfaces($className, $parentClassName, $defines, $isProtocol);
# Start actual generation..
-$object->GenerateHeader($interface);
+$object->GenerateHeader($interface, $defines);
$object->GenerateImplementation($interface) unless $noImpl;
# Check for missing public API
@@ -790,11 +792,36 @@
return ($svgPropertyType, $svgListPropertyType, $svgNativeType);
}
+sub ConditionalIsEnabled(\%$)
+{
+my $defines = shift;
+my $conditional = shift;
+
+return 1 if !$conditional;
+
+my $operator = ($conditional =~ /&/ ? '&' : ($conditional =~ /\|/ ? '|' : ''));
+if (!$operator) {
+return exists($defines->{"ENABLE_" . $conditional});
+}
+
+my @conditions = split(/\Q$operator\E/, $conditional);
+foreach (@conditions) {
+my $enable = "ENABLE_" . $_;
+return 0 if ($operator eq '&') and !exists($defines->{$enable});
+return 1 if ($operator eq '|') and exists($defines->{$enable});
+}
+
+return $operator eq '&';
+}
+
sub GenerateHeader
{
my $object = shift;
my $interface = shift;
+my $defines = shift;
+my %definesRef = map { $_ => 1 } split(/\s+/, $defines);
+
my $interfaceName = $interface->name;
my $className = GetClassName($interfaceName);
@@ -851,20 +878,15 @@
foreach my $constant (@constants) {
my $constantName = $constant->name;
my $constantValue = $constant->value;
-my $conditional = $constant->extendedAttributes->{"Conditional"};
my $notLast = $constant ne $constants[-1];
-
-if ($conditional) {
-my $conditionalString = $codeGenerator->GenerateConditionalStringFromAttributeValue($conditional);
-$combinedConstants .= "#if ${conditionalString}\n";
+
+if (ConditionalIsEnabled(%definesRef, $constant->extendedAttributes->{"Conditional"})) {
+$combinedConstants .= "DOM_$constantName = $constantValue";
+$combinedConstants .= "," if $notLast;
+if ($notLast) {
+$combinedConstants .= "\n";
+}
}
-$combinedConstants .= "DOM_$constantName = $constantValue";
-$combinedConstants .= "," if $notLast;
-if ($conditional) {
-$combinedConstants .= "\n#endif\n";
-} elsif ($notLast) {
-$combinedConstants .= "\n";
-}
}
# FIXME: the formatting of the enums should line up the equal signs.
@@ -943,13 +965,7 @@
$property .= $declarationSuffix;
push(@headerAttributes, $property) if $public;
push(@privateHeaderAttributes, $property) unl
[webkit-changes] [162924] trunk/Source
Title: [162924] trunk/Source Revision 162924 Author bshaf...@apple.com Date 2014-01-28 01:21:07 -0800 (Tue, 28 Jan 2014) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (162923 => 162924) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-28 09:15:29 UTC (rev 162923) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2014-01-28 09:21:07 UTC (rev 162924) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 14; +MINOR_VERSION = 15; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (162923 => 162924) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2014-01-28 09:15:29 UTC (rev 162923) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2014-01-28 09:21:07 UTC (rev 162924) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 14; +MINOR_VERSION = 15; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (162923 => 162924) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-28 09:15:29 UTC (rev 162923) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2014-01-28 09:21:07 UTC (rev 162924) @@ -1,5 +1,5 @@ MAJOR_VERSION = 538; -MINOR_VERSION = 14; +MINOR_VERSION = 15; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (162923 => 162924) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-28 09:15:29 UTC (rev 162923) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2014-01-28 09:21:07 UTC (rev 162924) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 14; +MINOR_VERSION = 15; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (162923 => 162924) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-01-28 09:15:29 UTC (rev 162923) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2014-01-28 09:21:07 UTC (rev 162924) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 538; -MINOR_VERSION = 14; +MINOR_VERSION = 15; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162923] tags/Safari-538.14/
Title: [162923] tags/Safari-538.14/ Revision 162923 Author bshaf...@apple.com Date 2014-01-28 01:15:29 -0800 (Tue, 28 Jan 2014) Log Message New tag. Added Paths tags/Safari-538.14/ Diff Property changes: tags/Safari-538.14 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [162922] trunk
Title: [162922] trunk Revision 162922 Author carlo...@webkit.org Date 2014-01-28 01:08:40 -0800 (Tue, 28 Jan 2014) Log Message [SOUP] Remove soupURIToKURL https://bugs.webkit.org/show_bug.cgi?id=127104 Reviewed by Martin Robinson. Source/WebCore: In favor of a URL constructor receiving a SoupURI. Also add a method to URL to create a soupURI. * GNUmakefile.list.am: Remove SoupURIUtils and add URLSoup. * PlatformEfl.cmake: Ditto. * PlatformGTK.cmake: Ditto. * platform/URL.h: Add URL constructor receiving a SoupURI and createSoupURI() to create a new soupURI for the URL. * platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookiesFromDOM): Use URL::createSoupURI(). (WebCore::cookiesForSession): Ditto. (WebCore::getRawCookies): Ditto. (WebCore::deleteCookie): Ditto. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::doRedirect): Use the new URL constructor instead of soupURIToKURL. (WebCore::createSoupRequestAndMessageForHandle): Use URL::createSoupURI(). * platform/network/soup/ResourceRequest.h: Rename soupURI as createSoupURI to make it clear that the method returns a newly created SoupURI. * platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessageMembers): Use URL::createSoupURI(). (WebCore::ResourceRequest::updateSoupMessage): Ditto. (WebCore::ResourceRequest::updateFromSoupMessage): Use the new URL constructor instead of soupURIToKURL. (WebCore::ResourceRequest::createSoupURI): Use URL::createSoupURI(). * platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage): Use the new URL constructor instead of soupURIToKURL. * platform/network/soup/SoupURIUtils.cpp: Removed. * platform/network/soup/SoupURIUtils.h: Removed. * platform/soup/URLSoup.cpp: Added. (WebCore::URL::URL): (WebCore::URL::createSoupURI): Tools: * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit tests, because URL.h now includes GUniquePtrSoup.h. * TestWebKitAPI/CMakeLists.txt: Ditto. * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR, because URL.h now includes GUniquePtrSoup.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/platform/URL.h trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp trunk/Source/WebCore/platform/network/soup/ResourceRequest.h trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/CMakeLists.txt trunk/Tools/TestWebKitAPI/GNUmakefile.am trunk/Tools/WebKitTestRunner/PlatformEfl.cmake Added Paths trunk/Source/WebCore/platform/soup/URLSoup.cpp Removed Paths trunk/Source/WebCore/platform/network/soup/SoupURIUtils.cpp trunk/Source/WebCore/platform/network/soup/SoupURIUtils.h Diff Modified: trunk/Source/WebCore/ChangeLog (162921 => 162922) --- trunk/Source/WebCore/ChangeLog 2014-01-28 08:15:39 UTC (rev 162921) +++ trunk/Source/WebCore/ChangeLog 2014-01-28 09:08:40 UTC (rev 162922) @@ -1,3 +1,45 @@ +2014-01-28 Carlos Garcia Campos + +[SOUP] Remove soupURIToKURL +https://bugs.webkit.org/show_bug.cgi?id=127104 + +Reviewed by Martin Robinson. + +In favor of a URL constructor receiving a SoupURI. Also add a +method to URL to create a soupURI. + +* GNUmakefile.list.am: Remove SoupURIUtils and add URLSoup. +* PlatformEfl.cmake: Ditto. +* PlatformGTK.cmake: Ditto. +* platform/URL.h: Add URL constructor receiving a SoupURI and +createSoupURI() to create a new soupURI for the URL. +* platform/network/soup/CookieJarSoup.cpp: +(WebCore::setCookiesFromDOM): Use URL::createSoupURI(). +(WebCore::cookiesForSession): Ditto. +(WebCore::getRawCookies): Ditto. +(WebCore::deleteCookie): Ditto. +* platform/network/soup/ResourceHandleSoup.cpp: +(WebCore::doRedirect): Use the new URL constructor instead of +soupURIToKURL. +(WebCore::createSoupRequestAndMessageForHandle): Use URL::createSoupURI(). +* platform/network/soup/ResourceRequest.h: Rename soupURI as +createSoupURI to make it clear that the method returns a newly +created SoupURI. +* platform/network/soup/ResourceRequestSoup.cpp: +(WebCore::ResourceRequest::updateSoupMessageMembers): Use URL::createSoupURI(). +(WebCore::ResourceRequest::updateSoupMessage): Ditto. +(WebCore::ResourceRequest::updateFromSoupMessage): Use the new URL +constructor instead of soupURIToKURL. +(WebCore::ResourceRequest::createSoupURI): Use URL::createSoupURI(). +* platform/network/soup/ResourceResponseSoup.cpp: +(WebCore::ResourceResponse::updateFromSoupMessage): Use the new +URL constructor in
[webkit-changes] [162921] trunk/Source/WebCore
Title: [162921] trunk/Source/WebCore
Revision 162921
Author carlo...@webkit.org
Date 2014-01-28 00:15:39 -0800 (Tue, 28 Jan 2014)
Log Message
[GTK] Avoid unnecessary string duplications in FileSystemGtk
https://bugs.webkit.org/show_bug.cgi?id=127469
Reviewed by Martin Robinson.
We are using fileSystemRepresentation() everywhere internally
which returns a CString that always duplicates the string.
Add unescapedFilename() internal helper function that returns a
GUniquePtr and used it everywhere instead of fileSystemRepresentation().
* platform/gtk/FileSystemGtk.cpp:
(WebCore::unescapedFilename):
(WebCore::fileSystemRepresentation):
(WebCore::filenameForDisplay):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileStat):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::directoryName):
(WebCore::listDirectory):
(WebCore::openFile):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/FileSystemGtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (162920 => 162921)
--- trunk/Source/WebCore/ChangeLog 2014-01-28 07:52:01 UTC (rev 162920)
+++ trunk/Source/WebCore/ChangeLog 2014-01-28 08:15:39 UTC (rev 162921)
@@ -1,5 +1,35 @@
2014-01-27 Carlos Garcia Campos
+[GTK] Avoid unnecessary string duplications in FileSystemGtk
+https://bugs.webkit.org/show_bug.cgi?id=127469
+
+Reviewed by Martin Robinson.
+
+We are using fileSystemRepresentation() everywhere internally
+which returns a CString that always duplicates the string.
+Add unescapedFilename() internal helper function that returns a
+GUniquePtr and used it everywhere instead of fileSystemRepresentation().
+
+* platform/gtk/FileSystemGtk.cpp:
+(WebCore::unescapedFilename):
+(WebCore::fileSystemRepresentation):
+(WebCore::filenameForDisplay):
+(WebCore::fileExists):
+(WebCore::deleteFile):
+(WebCore::deleteEmptyDirectory):
+(WebCore::getFileStat):
+(WebCore::getFileSize):
+(WebCore::getFileModificationTime):
+(WebCore::getFileMetadata):
+(WebCore::pathByAppendingComponent):
+(WebCore::makeAllDirectories):
+(WebCore::pathGetFileName):
+(WebCore::directoryName):
+(WebCore::listDirectory):
+(WebCore::openFile):
+
+2014-01-27 Carlos Garcia Campos
+
[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127614
Modified: trunk/Source/WebCore/platform/gtk/FileSystemGtk.cpp (162920 => 162921)
--- trunk/Source/WebCore/platform/gtk/FileSystemGtk.cpp 2014-01-28 07:52:01 UTC (rev 162920)
+++ trunk/Source/WebCore/platform/gtk/FileSystemGtk.cpp 2014-01-28 08:15:39 UTC (rev 162921)
@@ -54,12 +54,23 @@
#endif
}
+static GUniquePtr unescapedFilename(const String& path)
+{
+if (path.isEmpty())
+return nullptr;
+#if OS(WINDOWS)
+return GUniquePtr(g_strdup(path.utf8().data()));
+#else
+return GUniquePtr(g_uri_unescape_string(path.utf8().data(), nullptr));
+#endif
+}
+
CString fileSystemRepresentation(const String& path)
{
#if OS(WINDOWS)
return path.utf8();
#else
-GUniquePtr filename(g_uri_unescape_string(path.utf8().data(), 0));
+GUniquePtr filename = unescapedFilename(path);
return filename.get();
#endif
}
@@ -70,8 +81,11 @@
#if OS(WINDOWS)
return string;
#else
-CString filename = fileSystemRepresentation(string);
-GUniquePtr display(g_filename_to_utf8(filename.data(), 0, 0, 0, 0));
+GUniquePtr filename = unescapedFilename(string);
+if (!filename)
+return string;
+
+GUniquePtr display(g_filename_to_utf8(filename.get(), -1, nullptr, nullptr, nullptr));
if (!display)
return string;
@@ -81,46 +95,35 @@
bool fileExists(const String& path)
{
-bool result = false;
-CString filename = fileSystemRepresentation(path);
-
-if (!filename.isNull())
-result = g_file_test(filename.data(), G_FILE_TEST_EXISTS);
-
-return result;
+GUniquePtr filename = unescapedFilename(path);
+return filename ? g_file_test(filename.get(), G_FILE_TEST_EXISTS) : false;
}
bool deleteFile(const String& path)
{
-bool result = false;
-CString filename = fileSystemRepresentation(path);
-
-if (!filename.isNull())
-result = g_remove(filename.data()) == 0;
-
-return result;
+GUniquePtr filename = unescapedFilename(path);
+return filename ? g_remove(filename.get()) != -1 : false;
}
bool deleteEmptyDirectory(const String& path)
{
-bool result = false;
-CString filename = fileSystemRepresentation(path);
+GUniquePtr filename = unescapedFilename(path);
+return filename ? g_rmdir(filename.get()) != -1 : false;
+}
-if (!file
