date:20140326

[webkit-changes] [166285] trunk/Websites/webkit.org

2014-03-26 Thread commit-queue

Title: [166285] trunk/Websites/webkit.org








Revision 166285
Author commit-qu...@webkit.org
Date 2014-03-26 00:03:20 -0700 (Wed, 26 Mar 2014)


Log Message
Blog-files: combobox demo needs aria-expanded support
https://bugs.webkit.org/show_bug.cgi?id=130766

Patch by James Craig jcr...@apple.com on 2014-03-25
Reviewed by Chris Fleizach.

* blog-files/aria1.0/combobox_with_live_region_status.html: Added missing aria-expanded.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (166284 => 166285)

--- trunk/Websites/webkit.org/ChangeLog	2014-03-26 05:37:00 UTC (rev 166284)
+++ trunk/Websites/webkit.org/ChangeLog	2014-03-26 07:03:20 UTC (rev 166285)
@@ -1,3 +1,12 @@
+2014-03-25  James Craig  jcr...@apple.com
+
+Blog-files: combobox demo needs aria-expanded support
+https://bugs.webkit.org/show_bug.cgi?id=130766
+
+Reviewed by Chris Fleizach.
+
+* blog-files/aria1.0/combobox_with_live_region_status.html: Added missing aria-expanded.
+
 2014-03-25  Benjamin Poulain  bpoul...@apple.com
 
 Add illustrations for a potential blog post


Modified: trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html (166284 => 166285)

--- trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html	2014-03-26 05:37:00 UTC (rev 166284)
+++ trunk/Websites/webkit.org/blog-files/aria1.0/combobox_with_live_region_status.html	2014-03-26 07:03:20 UTC (rev 166285)
@@ -141,11 +141,13 @@
 var updateMenuDisplay = function () {
 filter();
 list.hidden = hideAll ? true : false;
+field.setAttribute('aria-expanded', hideAll ? 'false': 'true');
 updateStatus();
 };
 
 var hideMenu = function () {
 list.hidden = true;
+field.setAttribute('aria-expanded', 'false');
 updateStatus();
 };
 
@@ -271,7 +273,7 @@
 }());
 
 window.addEventListener('load', function () {
-initComboBoxes()
+initComboBoxes();
 });
 /script
 /head
@@ -281,7 +283,7 @@
 form class=pc
 !-- Note that this field is labelled by itself, which in this case, is an explicit pointer to use the placeholder attribute value. --
 input type=text tabindex=0 id=state aria-labelledby=state role=combobox aria-autocomplete=list aria-owns=statelist placeholder=US State or Territory autocomplete=off autocorrect=off autocapitalize=off
-div role=status aria-live=polite
+div role=status aria-live=polite aria-expanded=false
 !-- This is the list status live region: e.g. 4 items. --
 !-- The attribute value, aria-live=polite is the default for role=status. --
 !-- It's just included here for demo clarity. --






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166286] trunk/Tools

2014-03-26 Thread philn

Title: [166286] trunk/Tools








Revision 166286
Author ph...@webkit.org
Date 2014-03-26 00:33:08 -0700 (Wed, 26 Mar 2014)


Log Message
[GTK] The gnumake package is no longer needed in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=130121

Reviewed by Martin Robinson.

For GTK build-webkit now relies on cmake and ninja/gnumake. Even
for a debug build cmake/system-gnumake worked just fine for me.

* gtk/jhbuild.modules: Removed gnumake.
* gtk/patches/make-3.82-arg-list-length.patch: Removed.
* gtk/patches/make-3.82-parallel-build.patch: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Removed Paths

trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch
trunk/Tools/gtk/patches/make-3.82-parallel-build.patch




Diff

Modified: trunk/Tools/ChangeLog (166285 => 166286)

--- trunk/Tools/ChangeLog	2014-03-26 07:03:20 UTC (rev 166285)
+++ trunk/Tools/ChangeLog	2014-03-26 07:33:08 UTC (rev 166286)
@@ -1,3 +1,17 @@
+2014-03-12  Philippe Normand  pnorm...@igalia.com
+
+[GTK] The gnumake package is no longer needed in jhbuild
+https://bugs.webkit.org/show_bug.cgi?id=130121
+
+Reviewed by Martin Robinson.
+
+For GTK build-webkit now relies on cmake and ninja/gnumake. Even
+for a debug build cmake/system-gnumake worked just fine for me.
+
+* gtk/jhbuild.modules: Removed gnumake.
+* gtk/patches/make-3.82-arg-list-length.patch: Removed.
+* gtk/patches/make-3.82-parallel-build.patch: Removed.
+
 2014-03-25  Andy Estes  aes...@apple.com
 
 Fix a failing API test on Mountain Lion and remove temporary debug logging.


Modified: trunk/Tools/gtk/jhbuild.modules (166285 => 166286)

--- trunk/Tools/gtk/jhbuild.modules	2014-03-26 07:03:20 UTC (rev 166285)
+++ trunk/Tools/gtk/jhbuild.modules	2014-03-26 07:33:08 UTC (rev 166286)
@@ -5,7 +5,6 @@
 
   metamodule id=webkitgtk-testing-dependencies
 dependencies
-  dep package=make/
   dep package=cairo/
   dep package=fonts/
   dep package=fontconfig/
@@ -35,8 +34,6 @@
 
   include href=""
 
-  repository type=tarball name=ftp.gnu.org
-  href=""
   repository type=git name=github.com
   href=""
   repository type=tarball name=sourceware.org-mirror
@@ -58,14 +55,6 @@
   repository type=tarball name=savannah.gnu.org
   href=""
 
-  autotools id=make autogen-sh=configure
-branch repo=ftp.gnu.org
-module=make/make-3.82.tar.bz2 version=3.82
-size=1242186 md5sum=1a11100f3c63fcf5753818e59d63088f
-  patch file=make-3.82-arg-list-length.patch strip=1/
-  patch file=make-3.82-parallel-build.patch strip=1/
-/branch
-  /autotools
 
   autotools id=cairo autogen-sh=configure
  autogenargs=--enable-gl=yes --enable-egl=yes --enable-glx=yes


Deleted: trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch (166285 => 166286)

--- trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	2014-03-26 07:03:20 UTC (rev 166285)
+++ trunk/Tools/gtk/patches/make-3.82-arg-list-length.patch	2014-03-26 07:33:08 UTC (rev 166286)
@@ -1,107 +0,0 @@
-diff -u make-3.82-orig/configure.in make-3.82/configure.in
 make-3.82-orig/configure.in	2010-07-28 07:39:50.0 +0200
-+++ make-3.82/configure.in	2012-03-21 12:34:20.0 +0100
-@@ -64,7 +64,8 @@
- AC_HEADER_STAT
- AC_HEADER_TIME
- AC_CHECK_HEADERS(stdlib.h locale.h unistd.h limits.h fcntl.h string.h \
--		 memory.h sys/param.h sys/resource.h sys/time.h sys/timeb.h)
-+		 memory.h sys/param.h sys/resource.h sys/time.h sys/timeb.h \
-+		 sys/user.h linux/binfmts.h)
- 
- # Set a flag if we have an ANSI C compiler
- if test $ac_cv_prog_cc_stdc != no; then
-Subdirectorios comunes: make-3.82-orig/doc y make-3.82/doc
-Subdirectorios comunes: make-3.82-orig/glob y make-3.82/glob
-diff -u make-3.82-orig/job.c make-3.82/job.c
 make-3.82-orig/job.c	2010-07-24 10:27:50.0 +0200
-+++ make-3.82/job.c	2012-03-21 12:34:20.0 +0100
-@@ -29,6 +29,11 @@
- 
- #include string.h
- 
-+#if defined (HAVE_LINUX_BINFMTS_H)  defined (HAVE_SYS_USER_H)
-+#include sys/user.h
-+#include linux/binfmts.h
-+#endif
-+
- /* Default shell to use.  */
- #ifdef WINDOWS32
- #include windows.h
-@@ -2795,6 +2800,7 @@
- unsigned int sflags_len = strlen (shellflags);
- char *command_ptr = NULL; /* used for batch_mode_shell mode */
- char *new_line;
-+char *args_ptr;
- 
- # ifdef __EMX__ /* is this necessary? */
- if (!unixy_shell)
-@@ -2865,8 +2871,20 @@
- 	return new_argv;
-   }
- 
-+#ifdef MAX_ARG_STRLEN
-+#ifndef PAGE_SIZE
-+#define PAGE_SIZE sysconf(_SC_PAGESIZE)
-+#endif
-+static char eval_line[] = eval\\ \\\set\\ x\\;\\ shift\\;\\ ;
-+#define ARG_NUMBER_DIGITS 5
-+#define EVAL_LEN (sizeof(eval_line)-1 + shell_len + 4   \
-+  + (7 + ARG_NUMBER_DIGITS) * 2 * line_len / (MAX_ARG_STRLEN - 2))
-+#else
-+#define EVAL_LEN 0
-+#endif
-+
- new_line = alloca (shell_len + 1 + sflags_len + 1
-- +

[webkit-changes] [166289] trunk/Tools

2014-03-26 Thread commit-queue

Title: [166289] trunk/Tools








Revision 166289
Author commit-qu...@webkit.org
Date 2014-03-26 03:17:27 -0700 (Wed, 26 Mar 2014)


Log Message
run-launcher is Perl script so use elsif and not elif
https://bugs.webkit.org/show_bug.cgi?id=130771

Patch by Tomas Popela tpop...@redhat.com on 2014-03-26
Reviewed by Carlos Garcia Campos.

* Scripts/run-launcher:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-launcher




Diff

Modified: trunk/Tools/ChangeLog (166288 => 166289)

--- trunk/Tools/ChangeLog	2014-03-26 10:16:46 UTC (rev 166288)
+++ trunk/Tools/ChangeLog	2014-03-26 10:17:27 UTC (rev 166289)
@@ -1,3 +1,12 @@
+2014-03-26  Tomas Popela  tpop...@redhat.com
+
+run-launcher is Perl script so use elsif and not elif
+https://bugs.webkit.org/show_bug.cgi?id=130771
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/run-launcher:
+
 2014-03-26  Krzysztof Czech  k.cz...@samsung.com
 
 [ATK] Utilize new AtkValue interface coming in ATK 2.11.92


Modified: trunk/Tools/Scripts/run-launcher (166288 => 166289)

--- trunk/Tools/Scripts/run-launcher	2014-03-26 10:16:46 UTC (rev 166288)
+++ trunk/Tools/Scripts/run-launcher	2014-03-26 10:17:27 UTC (rev 166289)
@@ -48,9 +48,9 @@
 if (isGtk() || isEfl()) {
 if (isWK2()) {
 $launcherPath = catdir($productDir, bin, MiniBrowser);
-} elif (isEfl()) {
+} elsif (isEfl()) {
 $launcherPath = catdir($productDir, bin, EWebLauncher);
-} elif (isGtk()) {
+} elsif (isGtk()) {
 $launcherPath = catdir($productDir, bin, GtkLauncher);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166290] trunk/LayoutTests

2014-03-26 Thread rego

Title: [166290] trunk/LayoutTests








Revision 166290
Author r...@igalia.com
Date 2014-03-26 04:11:53 -0700 (Wed, 26 Mar 2014)


Log Message
[CSS Grid Layout] Prevent issues with checkLayout() in grid items
https://bugs.webkit.org/show_bug.cgi?id=130770

Reviewed by Sergio Villar Senin.

When we use checkLayout() on a grid item, the results (PASS or FAIL
messages) are added as new auto-placed items in the grid. Which might
cause some unexpected behavior in the tests.

This patch modifies the related layout tests to use a different
container (usually the parent node of the grid) for the test results.
Avoiding any kind of interference with the grid code.

* fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
  Use parent node of grid when checking grid items. Check layout of the
  whole grid instead of grid item.
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
  Check layout of the whole grid instead of grid item.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html
trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166289 => 166290)

--- trunk/LayoutTests/ChangeLog	2014-03-26 10:17:27 UTC (rev 166289)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 11:11:53 UTC (rev 166290)
@@ -1,3 +1,24 @@
+2014-03-26  Manuel Rego Casasnovas  r...@igalia.com
+
+[CSS Grid Layout] Prevent issues with checkLayout() in grid items
+https://bugs.webkit.org/show_bug.cgi?id=130770
+
+Reviewed by Sergio Villar Senin.
+
+When we use checkLayout() on a grid item, the results (PASS or FAIL
+messages) are added as new auto-placed items in the grid. Which might
+cause some unexpected behavior in the tests.
+
+This patch modifies the related layout tests to use a different
+container (usually the parent node of the grid) for the test results.
+Avoiding any kind of interference with the grid code.
+
+* fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
+  Use parent node of grid when checking grid items. Check layout of the
+  whole grid instead of grid item.
+* fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
+  Check layout of the whole grid instead of grid item.
+
 2014-03-25  Jer Noble  jer.no...@apple.com
 
 [MSE] Duplicate 'seeked' events.


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html (166289 => 166290)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html	2014-03-26 10:17:27 UTC (rev 166289)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-addition-auto-placement-update.html	2014-03-26 11:11:53 UTC (rev 166290)
@@ -25,18 +25,18 @@
 var autoFlowElement = document.getElementById(autoFlowElementID);
 autoFlowElement.setAttribute(data-expected-width, size.width);
 autoFlowElement.setAttribute(data-expected-height, size.height);
-checkLayout(# + autoFlowElementID);
+checkLayout(# + autoFlowElementID, gridElement.parentNode);
 }
 
 function testAdditions()
 {
-checkLayout(#autoFlowColumnElement);
+checkLayout(#gridAutoFlowColumn);
 testAddition(gridAutoFlowColumn, { 'row': '1', 'column': '1' }, autoFlowColumnElement, { 'width': '50', 'height': '100' });
 testAddition(gridAutoFlowColumn, { 'row': '1', 'column': '2' }, autoFlowColumnElement, { 'width': '50', 'height': '100' });
 testAddition(gridAutoFlowColumn, { 'row': '2', 'column': '2' }, autoFlowColumnElement, { 'width': '50', 'height': '100' });
 testAddition(gridAutoFlowColumn, { 'row': '2', 'column': '1' }, autoFlowColumnElement, { 'width': '170', 'height': '50' });
 
-checkLayout(#autoFlowRowElement);
+checkLayout(#gridAutoFlowRow);
 testAddition(gridAutoFlowRow, { 'row': '1', 'column': '1' }, autoFlowRowElement, { 'width': '100', 'height': '50' });
 testAddition(gridAutoFlowRow, { 'row': '2', 'column': '1' }, autoFlowRowElement, { 'width': '100', 'height': '50' });
 testAddition(gridAutoFlowRow, { 'row': '2', 'column': '2' }, autoFlowRowElement, { 'width': '100', 'height': '50' });


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html (166289 => 166290)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html	2014-03-26 10:17:27 UTC (rev 166289)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-removal-auto-placement-update.html	2014-03-26 11:11:53 UTC (rev 166290)
@@ -29,13 +29,13 @@
 
 function testRemovals()
 {
-checkLayout(#autoFlowColumnElement);
+checkLayout(#gridAutoFlowColumn);
 testRemoval(gridAutoFlowColumn, autoFlowColumnElement, { 'width': '100', 'height': '100' });
 testRemoval(gridAutoFlowColumn, autoFlowColumnElement, { 'width': '100', 'height': '50' });

[webkit-changes] [166291] trunk/Tools

2014-03-26 Thread k . gurpreet

Title: [166291] trunk/Tools








Revision 166291
Author k.gurpr...@webkit.org
Date 2014-03-26 08:03:04 -0700 (Wed, 26 Mar 2014)


Log Message
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (166290 => 166291)

--- trunk/Tools/ChangeLog	2014-03-26 11:11:53 UTC (rev 166290)
+++ trunk/Tools/ChangeLog	2014-03-26 15:03:04 UTC (rev 166291)
@@ -1,3 +1,9 @@
+2014-02-27  Gurpreet Kaur  k.gurpr...@samsung.com
+
+Unreviewed. Add myself as a committer.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2014-03-26  Tomas Popela  tpop...@redhat.com
 
 run-launcher is Perl script so use elsif and not elif


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (166290 => 166291)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2014-03-26 11:11:53 UTC (rev 166290)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2014-03-26 15:03:04 UTC (rev 166291)
@@ -964,6 +964,15 @@
 grzegorz
  ]
   },
+	  Gurpreet Kaur : {
+ emails : [
+k.gurpr...@samsung.com,
+			k.gurpr...@webkit.org
+ ], 
+ nicks : [
+k.gurpreet
+ ]
+  },
   Gwang Yoon Hwang : {
  emails : [
 ryum...@company100.net,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166295] trunk

2014-03-26 Thread commit-queue

Title: [166295] trunk








Revision 166295
Author commit-qu...@webkit.org
Date 2014-03-26 08:18:30 -0700 (Wed, 26 Mar 2014)


Log Message
Web Inspector: AXI: crash when inspecting bar text node in getAccessibilityPropertiesForNode layout test
https://bugs.webkit.org/show_bug.cgi?id=130290

Patch by James Craig jcr...@apple.com on 2014-03-26
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Fixing regression from r165590. http://webkit.org/b/129779
Verify isElementNode to avoid calling toElement on document or text nodes.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

LayoutTests:

Updating test to include properties for document node.

* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt
trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (166294 => 166295)

--- trunk/LayoutTests/ChangeLog	2014-03-26 15:12:48 UTC (rev 166294)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 15:18:30 UTC (rev 166295)
@@ -1,3 +1,15 @@
+2014-03-26  James Craig  jcr...@apple.com
+
+Web Inspector: AXI: crash when inspecting bar text node in getAccessibilityPropertiesForNode layout test
+https://bugs.webkit.org/show_bug.cgi?id=130290
+
+Reviewed by Timothy Hatcher.
+
+Updating test to include properties for document node.
+
+* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
+* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
+
 2014-03-26  Manuel Rego Casasnovas  r...@igalia.com
 
 [CSS Grid Layout] Prevent issues with checkLayout() in grid items


Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt (166294 => 166295)

--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt	2014-03-26 15:12:48 UTC (rev 166294)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt	2014-03-26 15:18:30 UTC (rev 166295)
@@ -1,5 +1,12 @@
 Checking Web Inspector protocol for the Accessibility Node Inspector.
 
+#document
+exists: true
+label: 
+role: 
+childNodeIds.length: 19
+
+
 Total elements to be tested: 57.
 
 li role=treeitem aria-expanded=undefinedexpanded/li
@@ -446,5 +453,3 @@
 label: 
 role: 
 
-
-


Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html (166294 => 166295)

--- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html	2014-03-26 15:12:48 UTC (rev 166294)
+++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html	2014-03-26 15:18:30 UTC (rev 166295)
@@ -113,43 +113,56 @@
 function test() {
 
 var examples = [];
+var documentNodeId = null;
 
-function loop() {
-if (examples.length) {
-InspectorTest.sendCommand(DOM.getOuterHTML, {nodeId: examples[examples.length-1]}, onGotOuterHTML);
-} else {
-InspectorTest.log(\n);
-InspectorTest.sendCommand(Runtime.evaluate, {_expression_: cleanup()}, function(){
-InspectorTest.completeTest();
-});
-}
-};
-
 function onGotDocument(response) {
 InspectorTest.checkForError(response);
-InspectorTest.sendCommand(DOM.querySelectorAll, {nodeId: response.result.root.nodeId, selector: .ex}, onQuerySelectorAll);
+documentNodeId = response.result.root.nodeId;
+InspectorTest.sendCommand(DOM.getAccessibilityPropertiesForNode, {nodeId: documentNodeId}, onGotAccessibilityPropertiesForDocumentNode);
 }
 
-function onQuerySelectorAll(response) {
+function onGotAccessibilityPropertiesForDocumentNode(response) {
 InspectorTest.checkForError(response);
+InspectorTest.log(#document);
+logAccessibilityProperties(response.result.properties);
+InspectorTest.log(\n);
+InspectorTest.sendCommand(DOM.querySelectorAll, {nodeId: documentNodeId, selector: .ex}, onGotQuerySelectorAll);
+}
+
+function onGotQuerySelectorAll(response) {
+InspectorTest.checkForError(response);
 examples = response.result.nodeIds;
 InspectorTest.log(Total elements to be tested:  + examples.length + .);
 loop();
 }
 
+function loop() {
+if (examples.length) {
+InspectorTest.sendCommand(DOM.getOuterHTML, {nodeId: examples[examples.length-1]}, onGotOuterHTML);
+} else {
+finishTest();
+}
+}
+
 function onGotOuterHTML(response) {

[webkit-changes] [166296] trunk/Source

2014-03-26 Thread timothy_horton

Title: [166296] trunk/Source








Revision 166296
Author timothy_hor...@apple.com
Date 2014-03-26 08:25:28 -0700 (Wed, 26 Mar 2014)


Log Message
[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
https://bugs.webkit.org/show_bug.cgi?id=130768
rdar://problem/16421471

Reviewed by Simon Fraser.

* Shared/mac/RemoteLayerBackingStore.h:
Add flush(), which synchronously flushes painting operations on the underlying backing store.
Factor clearBackingStore() out of ensureBackingStore/display, which releases our reference to underlying backing store.
Add two members for storing the back surface and front buffer context until flush() is called.
- We need to keep the back surface alive because the CGImageRef created from it is referenced by
the front surface's drawing queue, and won't be freed until said queue is flushed. If we release
the back surface (and its associated CGContextRef) *before* the CGImageRef is freed, we will
do an expensive readback of the surface.
- When not using accelerated drawing, we need to keep the front buffer's CGContextRef around
until the flush occurs so that we can avoid re-creating it in order to perform the flush. This
happens automatically in the accelerated drawing case via WebCore::IOSurface.

* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::ensureBackingStore):
(RemoteLayerBackingStore::clearBackingStore):
(RemoteLayerBackingStore::display):
Factor clearBackingStore() out of ensureBackingStore() and display().
Update a comment about the above performance gotcha.
Store the current back surface/front buffer context.

(RemoteLayerBackingStore::drawInContext):
Don't flush the context immediately after painting.

(RemoteLayerBackingStore::applyBackingStoreToLayer):
Move things around to reduce duplicated code.

(RemoteLayerBackingStore::flush):
Flush the current front surface/buffer's context.
Clear the new pending-flush members.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::flushBackingStoreChangesInTransaction):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Crawl through all of the valid changed backing stores in the transaction and flush them.
Remove a completely useless assertion.

* platform/graphics/cocoa/IOSurface.h:
Add a non-ensuring platformContext() getter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166295 => 166296)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 15:18:30 UTC (rev 166295)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 15:25:28 UTC (rev 166296)
@@ -1,3 +1,14 @@
+2014-03-26  Tim Horton  timothy_hor...@apple.com
+
+[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
+https://bugs.webkit.org/show_bug.cgi?id=130768
+rdar://problem/16421471
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/cocoa/IOSurface.h:
+Add a non-ensuring platformContext() getter.
+
 2014-03-26  James Craig  jcr...@apple.com
 
 Web Inspector: AXI: crash when inspecting bar text node in getAccessibilityPropertiesForNode layout test


Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h (166295 => 166296)

--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2014-03-26 15:18:30 UTC (rev 166295)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2014-03-26 15:25:28 UTC (rev 166296)
@@ -52,6 +52,7 @@
 IOSurfaceRef surface() const { return m_surface.get(); }
 GraphicsContext ensureGraphicsContext();
 CGContextRef ensurePlatformContext();
+CGContextRef platformContext() { return m_cgContext.get(); }
 
 enum class SurfaceState {
 Valid,


Modified: trunk/Source/WebKit2/ChangeLog (166295 => 166296)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 15:18:30 UTC (rev 166295)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 15:25:28 UTC (rev 166296)
@@ -1,3 +1,47 @@
+2014-03-26  Tim Horton  timothy_hor...@apple.com
+
+[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
+https://bugs.webkit.org/show_bug.cgi?id=130768
+rdar://problem/16421471
+
+Reviewed by Simon Fraser.
+
+* Shared/mac/RemoteLayerBackingStore.h:
+Add flush(), which synchronously flushes painting operations on the underlying backing store.
+Factor clearBackingStore() out of ensureBackingStore/display, which releases our reference to underlying backing store.
+Add two members for storing the back surface and front buffer context until flush() is called.
+- We

[webkit-changes] [166297] trunk/LayoutTests

2014-03-26 Thread darin

Title: [166297] trunk/LayoutTests








Revision 166297
Author da...@apple.com
Date 2014-03-26 09:19:21 -0700 (Wed, 26 Mar 2014)


Log Message
Update LayoutTests to depend on load events rather than on starting loads synchronously
https://bugs.webkit.org/show_bug.cgi?id=130776

Reviewed by Antti Koivisto.

These tests were depending on loads starting synchronously. Instead, they should simply
depend on proper load event behavior.

* dom/html/level1/core/selfhtml.js:
(startTest): Call waitUntilDone immediately, not when the test starts.
* dom/html/level2/core/selfhtml.js:
(startTest): Ditto.
* dom/html/level2/events/selfhtml.js:
(startTest): Ditto.
* dom/html/level2/html/selfhtml.js:
(startTest): Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/dom/html/level1/core/selfhtml.js
trunk/LayoutTests/dom/html/level2/core/selfhtml.js
trunk/LayoutTests/dom/html/level2/events/selfhtml.js
trunk/LayoutTests/dom/html/level2/html/selfhtml.js




Diff

Modified: trunk/LayoutTests/ChangeLog (166296 => 166297)

--- trunk/LayoutTests/ChangeLog	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 16:19:21 UTC (rev 166297)
@@ -1,3 +1,22 @@
+2014-03-26  Darin Adler  da...@apple.com
+
+Update LayoutTests to depend on load events rather than on starting loads synchronously
+https://bugs.webkit.org/show_bug.cgi?id=130776
+
+Reviewed by Antti Koivisto.
+
+These tests were depending on loads starting synchronously. Instead, they should simply
+depend on proper load event behavior.
+
+* dom/html/level1/core/selfhtml.js:
+(startTest): Call waitUntilDone immediately, not when the test starts.
+* dom/html/level2/core/selfhtml.js:
+(startTest): Ditto.
+* dom/html/level2/events/selfhtml.js:
+(startTest): Ditto.
+* dom/html/level2/html/selfhtml.js:
+(startTest): Ditto.
+
 2014-03-26  James Craig  jcr...@apple.com
 
 Web Inspector: AXI: crash when inspecting bar text node in getAccessibilityPropertiesForNode layout test


Modified: trunk/LayoutTests/dom/html/level1/core/selfhtml.js (166296 => 166297)

--- trunk/LayoutTests/dom/html/level1/core/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level1/core/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//


Modified: trunk/LayoutTests/dom/html/level2/core/selfhtml.js (166296 => 166297)

--- trunk/LayoutTests/dom/html/level2/core/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/core/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//


Modified: trunk/LayoutTests/dom/html/level2/events/selfhtml.js (166296 => 166297)

--- trunk/LayoutTests/dom/html/level2/events/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/events/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//


Modified: trunk/LayoutTests/dom/html/level2/html/selfhtml.js (166296 => 166297)

--- trunk/LayoutTests/dom/html/level2/html/selfhtml.js	2014-03-26 15:25:28 UTC (rev 166296)
+++ trunk/LayoutTests/dom/html/level2/html/selfhtml.js	2014-03-26 16:19:21 UTC (rev 166297)
@@ -670,8 +670,6 @@
 
 
 
-function startTest() {
-
 //
 //  WebKit modification: 18-August-2005
 //
@@ -686,6 +684,8 @@
 //  End WebKit modification
 //
 
+function startTest() {
+
 	//
 	//   invoke test setup
 	//






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166298] trunk/Source/WebCore

2014-03-26 Thread simon . fraser

Title: [166298] trunk/Source/WebCore








Revision 166298
Author simon.fra...@apple.com
Date 2014-03-26 09:26:48 -0700 (Wed, 26 Mar 2014)


Log Message
Fix the iOS build.

* WebCore.exp.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (166297 => 166298)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 16:19:21 UTC (rev 166297)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 16:26:48 UTC (rev 166298)
@@ -1,3 +1,9 @@
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
+Fix the iOS build.
+
+* WebCore.exp.in:
+
 2014-03-26  Tim Horton  timothy_hor...@apple.com
 
 [iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one


Modified: trunk/Source/WebCore/WebCore.exp.in (166297 => 166298)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-26 16:19:21 UTC (rev 166297)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-26 16:26:48 UTC (rev 166298)
@@ -2410,11 +2410,11 @@
 _WebUIApplicationWillResignActiveNotification
 __ZN7WebCore10FloatPointC1ERK7CGPoint
 __ZN7WebCore10ScrollView15setScrollOffsetERKNS_8IntPointE
+__ZN7WebCore10ScrollView17setScrollVelocityEddd
 __ZN7WebCore10ScrollView21setExposedContentRectERKNS_7IntRectE
 __ZN7WebCore10ScrollView24setUnobscuredContentRectERKNS_7IntRectE
 __ZN7WebCore10XLinkNames4initEv
 __ZN7WebCore10inSameLineERKNS_15VisiblePositionES2_
-__ZN7WebCore10ScrollView17setScrollVelocityEddd
 __ZN7WebCore11BidiContext41copyStackRemovingUnicodeEmbeddingContextsEv
 __ZN7WebCore11BidiContext6createEh14UCharDirectionbNS_19BidiEmbeddingSourceEPS0_
 __ZN7WebCore11CachedImage5imageEv
@@ -2791,12 +2791,14 @@
 #endif
 
 #if ENABLE(ASYNC_SCROLLING)  PLATFORM(IOS)
+__ZN7WebCore29ScrollingTreeScrollingNodeIOS17setScrollPositionERKNS_10FloatPointE
+__ZN7WebCore29ScrollingTreeScrollingNodeIOS17updateForViewportERKNS_9FloatRectEd
+__ZN7WebCore29ScrollingTreeScrollingNodeIOS19updateAfterChildrenERKNS_18ScrollingStateNodeE
 __ZN7WebCore29ScrollingTreeScrollingNodeIOS20updateBeforeChildrenERKNS_18ScrollingStateNodeE
-__ZN7WebCore29ScrollingTreeScrollingNodeIOS19updateAfterChildrenERKNS_18ScrollingStateNodeE
-__ZN7WebCore29ScrollingTreeScrollingNodeIOS17setScrollPositionERKNS_10FloatPointE
+__ZN7WebCore29ScrollingTreeScrollingNodeIOS46setScrollPositionWithoutContentEdgeConstraintsERKNS_10FloatPointE
+__ZN7WebCore29ScrollingTreeScrollingNodeIOS6createERNS_13ScrollingTreeENS_17ScrollingNodeTypeEy
 __ZN7WebCore29ScrollingTreeScrollingNodeIOSC2ERNS_13ScrollingTreeENS_17ScrollingNodeTypeEy
 __ZN7WebCore29ScrollingTreeScrollingNodeIOSD2Ev
-__ZN7WebCore29ScrollingTreeScrollingNodeIOS6createERNS_13ScrollingTreeENS_17ScrollingNodeTypeEy
 #endif
 
 #if USE(AVFOUNDATION)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166300] trunk/Source/WebCore

2014-03-26 Thread bfulgham

Title: [166300] trunk/Source/WebCore








Revision 166300
Author bfulg...@apple.com
Date 2014-03-26 10:02:15 -0700 (Wed, 26 Mar 2014)


Log Message
Avoid duplicate size checks when creating empty image
https://bugs.webkit.org/show_bug.cgi?id=130730

Reviewed by Dean Jackson.

Merged from Blink (patch by ch.du...@samsung.com):
https://chromium.googlesource.com/chromium/blink/+/4861a71bc1f284fc97417f405ab7d08dc6947b88
http://crbug.com/190633011

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData): Don't perform overflow calculation twice.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166299 => 166300)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 16:45:21 UTC (rev 166299)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 17:02:15 UTC (rev 166300)
@@ -1,3 +1,17 @@
+2014-03-25  Brent Fulgham  bfulg...@apple.com
+
+Avoid duplicate size checks when creating empty image
+https://bugs.webkit.org/show_bug.cgi?id=130730
+
+Reviewed by Dean Jackson.
+
+Merged from Blink (patch by ch.du...@samsung.com):
+https://chromium.googlesource.com/chromium/blink/+/4861a71bc1f284fc97417f405ab7d08dc6947b88
+http://crbug.com/190633011
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::createEmptyImageData): Don't perform overflow calculation twice.
+
 2014-03-26  Sergio Villar Senin  svil...@igalia.com
 
 [CSS Grid Layout] getComputedStyle() must return the specified value for positioning properties


Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (166299 => 166300)

--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2014-03-26 16:45:21 UTC (rev 166299)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2014-03-26 17:02:15 UTC (rev 166300)
@@ -1827,15 +1827,12 @@
 
 static PassRefPtrImageData createEmptyImageData(const IntSize size)
 {
-Checkedint, RecordOverflow dataSize = 4;
-dataSize *= size.width();
-dataSize *= size.height();
-if (dataSize.hasOverflowed())
-return 0;
+if (RefPtrImageData data = "" {
+data-data()-zeroFill();
+return data.release();
+}
 
-RefPtrImageData data = ""
-data-data()-zeroFill();
-return data.release();
+return nullptr;
 }
 
 PassRefPtrImageData CanvasRenderingContext2D::createImageData(PassRefPtrImageData imageData, ExceptionCode ec) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166302] trunk

2014-03-26 Thread commit-queue

Title: [166302] trunk








Revision 166302
Author commit-qu...@webkit.org
Date 2014-03-26 11:31:58 -0700 (Wed, 26 Mar 2014)


Log Message
Unreviewed, rolling out r166264.
https://bugs.webkit.org/show_bug.cgi?id=130785

Broke some window.opener tests for WK2 Mavericks (Requested by
brrian__ on #webkit).

Reverted changeset:

Source/WebCore:

Web Replay: resource unique identifiers should be unique-per-
frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130632
http://trac.webkit.org/changeset/166264

Tools:

Web Replay: resource unique identifiers should be unique-per-
frame, not globally
https://bugs.webkit.org/show_bug.cgi?id=130632
http://trac.webkit.org/changeset/166264

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ProgressTracker.cpp
trunk/Source/WebCore/loader/ProgressTracker.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166301 => 166302)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 18:20:15 UTC (rev 166301)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 18:31:58 UTC (rev 166302)
@@ -1,3 +1,18 @@
+2014-03-26  Commit Queue  commit-qu...@webkit.org
+
+Unreviewed, rolling out r166264.
+https://bugs.webkit.org/show_bug.cgi?id=130785
+
+Broke some window.opener tests for WK2 Mavericks (Requested by
+brrian__ on #webkit).
+
+Reverted changeset:
+
+Web Replay: resource unique identifiers should be unique-per-
+frame, not globally
+https://bugs.webkit.org/show_bug.cgi?id=130632
+http://trac.webkit.org/changeset/166264
+
 2014-03-26  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Remove shape-inside support


Modified: trunk/Source/WebCore/loader/ProgressTracker.cpp (166301 => 166302)

--- trunk/Source/WebCore/loader/ProgressTracker.cpp	2014-03-26 18:20:15 UTC (rev 166301)
+++ trunk/Source/WebCore/loader/ProgressTracker.cpp	2014-03-26 18:31:58 UTC (rev 166302)
@@ -73,6 +73,8 @@
 long long estimatedLength;
 };
 
+unsigned long ProgressTracker::s_uniqueIdentifier = 0;
+
 ProgressTracker::ProgressTracker(ProgressTrackerClient client)
 : m_client(client)
 , m_totalPageAndResourceBytesToLoad(0)
@@ -82,7 +84,6 @@
 , m_progressNotificationTimeInterval(std::chrono::milliseconds(100))
 , m_finalProgressChangedSent(false)
 , m_progressValue(0)
-, m_nextUniqueIdentifier(1)
 , m_numProgressTrackedFrames(0)
 , m_progressHeartbeatTimer(this, ProgressTracker::progressHeartbeatTimerFired)
 , m_heartbeatsWithNoProgress(0)
@@ -113,7 +114,6 @@
 m_finalProgressChangedSent = false;
 m_numProgressTrackedFrames = 0;
 m_originatingProgressFrame = 0;
-// Don't reset m_nextUniqueIdentifier. More loads could start after reset() is called.
 
 m_heartbeatsWithNoProgress = 0;
 m_totalBytesReceivedBeforePreviousHeartbeat = 0;
@@ -294,7 +294,7 @@
 
 unsigned long ProgressTracker::createUniqueIdentifier()
 {
-return m_nextUniqueIdentifier++;
+return ++s_uniqueIdentifier;
 }
 
 bool ProgressTracker::isMainLoadProgressing() const


Modified: trunk/Source/WebCore/loader/ProgressTracker.h (166301 => 166302)

--- trunk/Source/WebCore/loader/ProgressTracker.h	2014-03-26 18:20:15 UTC (rev 166301)
+++ trunk/Source/WebCore/loader/ProgressTracker.h	2014-03-26 18:31:58 UTC (rev 166302)
@@ -46,7 +46,7 @@
 explicit ProgressTracker(ProgressTrackerClient);
 ~ProgressTracker();
 
-unsigned long createUniqueIdentifier();
+static unsigned long createUniqueIdentifier();
 
 double estimatedProgress() const;
 
@@ -68,6 +68,8 @@
 
 void progressHeartbeatTimerFired(TimerProgressTracker);
 
+static unsigned long s_uniqueIdentifier;
+
 ProgressTrackerClient m_client;
 long long m_totalPageAndResourceBytesToLoad;
 long long m_totalBytesReceived;
@@ -78,7 +80,6 @@
 bool m_finalProgressChangedSent;
 double m_progressValue;
 RefPtrFrame m_originatingProgressFrame;
-unsigned long m_nextUniqueIdentifier;
 
 int m_numProgressTrackedFrames;
 HashMapunsigned long, std::unique_ptrProgressItem m_progressItems;


Modified: trunk/Tools/ChangeLog (166301 => 166302)

--- trunk/Tools/ChangeLog	2014-03-26 18:20:15 UTC (rev 166301)
+++ trunk/Tools/ChangeLog	2014-03-26 18:31:58 UTC (rev 166302)
@@ -1,3 +1,18 @@
+2014-03-26  Commit Queue  commit-qu...@webkit.org
+
+Unreviewed, rolling out r166264.
+https://bugs.webkit.org/show_bug.cgi?id=130785
+
+Broke some window.opener tests for WK2 Mavericks (Requested by
+brrian__ on #webkit).
+
+Reverted changeset:
+
+Web Replay: resource unique identifiers should be unique-per-
+frame, not globally
+https://bugs.webkit.org/show_bug.cgi?id=130632
+http://trac.webkit.org/changeset/166264
+
 2014-03-26  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Remove shape-inside support


Modified:

[webkit-changes] [166303] trunk

2014-03-26 Thread antti

Title: [166303] trunk








Revision 166303
Author an...@apple.com
Date 2014-03-26 11:35:55 -0700 (Wed, 26 Mar 2014)


Log Message
Render tree construction is O(N^2) in number of siblings
https://bugs.webkit.org/show_bug.cgi?id=129065

Source/WebCore: 

Reviewed by Darin Adler.

When adding a new renderer to the tree we would search for the correct render tree
position by traversing DOM children forward to find something that already has a renderer.
In common case there is no such renderer. This would be repeated for each inserted renderer
leading to O(n^2) in respect to child node count.

This patch caches the computed render tree insertion position and passes it to siblings.
Until the cached position is reached it can be used for all new renderers.

Test: perf/sibling-renderer-On2.html

* style/StyleResolveTree.cpp:
(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::canInsert):
(WebCore::Style::RenderTreePosition::insert):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::RenderTreePosition::invalidateNextSibling):
(WebCore::Style::styleForElement):
(WebCore::Style::elementInsideRegionNeedsRenderer):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::attachTextRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

LayoutTests: 

Reviewed by Darin Adler.

* perf/sibling-renderer-On2-expected.txt: Added.
* perf/sibling-renderer-On2.html: Added.

The test doesn't use magnitude-perf.js as this requires a relatively long-running test function and
it seemed unsuitable for that.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleResolveTree.cpp


Added Paths

trunk/LayoutTests/perf/sibling-renderer-On2-expected.txt
trunk/LayoutTests/perf/sibling-renderer-On2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166302 => 166303)

--- trunk/LayoutTests/ChangeLog	2014-03-26 18:31:58 UTC (rev 166302)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 18:35:55 UTC (rev 166303)
@@ -1,3 +1,16 @@
+2014-03-26  Antti Koivisto  an...@apple.com
+
+Render tree construction is O(N^2) in number of siblings
+https://bugs.webkit.org/show_bug.cgi?id=129065
+
+Reviewed by Darin Adler.
+
+* perf/sibling-renderer-On2-expected.txt: Added.
+* perf/sibling-renderer-On2.html: Added.
+
+The test doesn't use magnitude-perf.js as this requires a relatively long-running test function and
+it seemed unsuitable for that.
+
 2014-03-26  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Remove shape-inside support


Added: trunk/LayoutTests/perf/sibling-renderer-On2-expected.txt (0 => 166303)

--- trunk/LayoutTests/perf/sibling-renderer-On2-expected.txt	(rev 0)
+++ trunk/LayoutTests/perf/sibling-renderer-On2-expected.txt	2014-03-26 18:35:55 UTC (rev 166303)
@@ -0,0 +1,5 @@
+PASS timeRenderTreeCreation(5000)  20 * timeRenderTreeCreation(500) is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/perf/sibling-renderer-On2.html (0 => 166303)

--- trunk/LayoutTests/perf/sibling-renderer-On2.html	(rev 0)
+++ trunk/LayoutTests/perf/sibling-renderer-On2.html	2014-03-26 18:35:55 UTC (rev 166303)
@@ -0,0 +1,13 @@
+script src=""
+body
+script
+function timeRenderTreeCreation(count) {
+var t = Date.now();
+for (var i = 0; i  count; ++i)
+document.body.appendChild(document.createElement('div'));
+document.body.offsetTop;
+return Date.now() - t;
+}
+shouldBe(timeRenderTreeCreation(5000)  20 * timeRenderTreeCreation(500), true);
+/script
+script src=""


Modified: trunk/Source/WebCore/ChangeLog (166302 => 166303)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 18:31:58 UTC (rev 166302)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 18:35:55 UTC (rev 166303)
@@ -1,3 +1,44 @@
+2014-03-26  Antti Koivisto  an...@apple.com
+
+Render tree construction is O(N^2) in number of siblings
+https://bugs.webkit.org/show_bug.cgi?id=129065
+
+Reviewed by Darin Adler.
+
+When adding a new renderer to the tree we would search for the correct render tree
+position by traversing DOM children forward to find something that already has a renderer.
+In common case there is no such renderer. This would be repeated for each inserted renderer
+leading to O(n^2) in respect to child node

[webkit-changes] [166304] trunk/Source/WebCore

2014-03-26 Thread jer . noble

Title: [166304] trunk/Source/WebCore








Revision 166304
Author jer.no...@apple.com
Date 2014-03-26 11:37:44 -0700 (Wed, 26 Mar 2014)


Log Message
REGRESSION(r162679): Poster image visible under the video
https://bugs.webkit.org/show_bug.cgi?id=130783

Reviewed by Simon Fraser.

In the listed revision, we started checking for isRenderImage()
instead of isImage(). RenderMedias return 'true' for the first
but 'false' for the second. Change the if() statement to check
for isRenderMedia() in addition to !isRenderImage().

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166303 => 166304)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 18:35:55 UTC (rev 166303)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 18:37:44 UTC (rev 166304)
@@ -1,3 +1,18 @@
+2014-03-26  Jer Noble  jer.no...@apple.com
+
+REGRESSION(r162679): Poster image visible under the video
+https://bugs.webkit.org/show_bug.cgi?id=130783
+
+Reviewed by Simon Fraser.
+
+In the listed revision, we started checking for isRenderImage()
+instead of isImage(). RenderMedias return 'true' for the first
+but 'false' for the second. Change the if() statement to check
+for isRenderMedia() in addition to !isRenderImage().
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
+
 2014-03-26  Antti Koivisto  an...@apple.com
 
 Render tree construction is O(N^2) in number of siblings


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (166303 => 166304)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 18:35:55 UTC (rev 166303)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 18:37:44 UTC (rev 166304)
@@ -1838,7 +1838,7 @@
 // that require painting. Direct compositing saves backing store.
 bool RenderLayerBacking::isDirectlyCompositedImage() const
 {
-if (!renderer().isRenderImage() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
+if (!renderer().isRenderImage() || renderer().isMedia() || m_owningLayer.hasBoxDecorationsOrBackground() || renderer().hasClip())
 return false;
 
 RenderImage imageRenderer = toRenderImage(renderer());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166305] branches/safari-537.75-branch/Source/WebCore

2014-03-26 Thread matthew_hanson

Title: [166305] branches/safari-537.75-branch/Source/WebCore








Revision 166305
Author matthew_han...@apple.com
Date 2014-03-26 12:17:16 -0700 (Wed, 26 Mar 2014)


Log Message
Merge r166304.

Modified Paths

branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (166304 => 166305)

--- branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-03-26 18:37:44 UTC (rev 166304)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-03-26 19:17:16 UTC (rev 166305)
@@ -1,3 +1,22 @@
+2014-03-26  Matthew Hanson  matthew_han...@apple.com
+
+Merge r166304.
+
+2014-03-26  Jer Noble  jer.no...@apple.com
+
+REGRESSION(r162679): Poster image visible under the video
+https://bugs.webkit.org/show_bug.cgi?id=130783
+
+Reviewed by Simon Fraser.
+
+In the listed revision, we started checking for isRenderImage()
+instead of isImage(). RenderMedias return 'true' for the first
+but 'false' for the second. Change the if() statement to check
+for isRenderMedia() in addition to !isRenderImage().
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
+
 2014-03-24  Matthew Hanson  matthew_han...@apple.com
 
 Remove a commented line of code introduced by r166104.


Modified: branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (166304 => 166305)

--- branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 18:37:44 UTC (rev 166304)
+++ branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 19:17:16 UTC (rev 166305)
@@ -1675,7 +1675,7 @@
 {
 RenderObject* renderObject = renderer();
 
-if (!renderObject-isRenderImage() || m_owningLayer-hasBoxDecorationsOrBackground() || renderObject-hasClip())
+if (!renderObject-isRenderImage() || !renderObject-isMedia() || m_owningLayer-hasBoxDecorationsOrBackground() || renderObject-hasClip())
 return false;
 
 RenderImage* imageRenderer = toRenderImage(renderObject);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166306] branches/safari-537.75-branch/Source/WebCore

2014-03-26 Thread matthew_hanson

Title: [166306] branches/safari-537.75-branch/Source/WebCore








Revision 166306
Author matthew_han...@apple.com
Date 2014-03-26 12:20:58 -0700 (Wed, 26 Mar 2014)


Log Message
Remove extraneous ! from merge of r166304.

Modified Paths

branches/safari-537.75-branch/Source/WebCore/ChangeLog
branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: branches/safari-537.75-branch/Source/WebCore/ChangeLog (166305 => 166306)

--- branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-03-26 19:17:16 UTC (rev 166305)
+++ branches/safari-537.75-branch/Source/WebCore/ChangeLog	2014-03-26 19:20:58 UTC (rev 166306)
@@ -1,5 +1,9 @@
 2014-03-26  Matthew Hanson  matthew_han...@apple.com
 
+Remove extraneous ! from merge of r166304.
+
+2014-03-26  Matthew Hanson  matthew_han...@apple.com
+
 Merge r166304.
 
 2014-03-26  Jer Noble  jer.no...@apple.com


Modified: branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (166305 => 166306)

--- branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 19:17:16 UTC (rev 166305)
+++ branches/safari-537.75-branch/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-26 19:20:58 UTC (rev 166306)
@@ -1675,7 +1675,7 @@
 {
 RenderObject* renderObject = renderer();
 
-if (!renderObject-isRenderImage() || !renderObject-isMedia() || m_owningLayer-hasBoxDecorationsOrBackground() || renderObject-hasClip())
+if (!renderObject-isRenderImage() || renderObject-isMedia() || m_owningLayer-hasBoxDecorationsOrBackground() || renderObject-hasClip())
 return false;
 
 RenderImage* imageRenderer = toRenderImage(renderObject);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166307] trunk/Source

2014-03-26 Thread bfulgham

Title: [166307] trunk/Source








Revision 166307
Author bfulg...@apple.com
Date 2014-03-26 12:21:49 -0700 (Wed, 26 Mar 2014)


Log Message
Source/_javascript_Core: Unreviewed build fix.

* runtime/JSCell.h: VS2013 confused about argument type.

Source/WebCore: Unreviewed test correction.

Because of the way DRT on Windows links to WebCore, having the implementaion of the update
method in the header caused a runtime failure due to duplicate symbols being bound to the
compilation unit.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Moved from header.
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Deleted.

Source/WebKit: Unreviewed build/test correction.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export the AXObjectCache::setEnhancedUserInterfaceEnabled
set function.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (166306 => 166307)

--- trunk/Source/_javascript_Core/ChangeLog	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-26 19:21:49 UTC (rev 166307)
@@ -1,3 +1,9 @@
+2014-03-26  Brent Fulgham  bfulg...@apple.com
+
+Unreviewed build fix.
+
+* runtime/JSCell.h: VS2013 confused about argument type.
+
 2014-03-26  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Remove shape-inside support


Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (166306 => 166307)

--- trunk/Source/_javascript_Core/runtime/JSCell.h	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h	2014-03-26 19:21:49 UTC (rev 166307)
@@ -92,7 +92,7 @@
 bool isGetterSetter() const;
 bool isProxy() const;
 bool inherits(const ClassInfo*) const;
-bool isAPIValueWrapper() const;
+JS_EXPORT_PRIVATE bool isAPIValueWrapper() const;
 
 JSType type() const;
 IndexingType indexingType() const;


Modified: trunk/Source/WebCore/ChangeLog (166306 => 166307)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 19:21:49 UTC (rev 166307)
@@ -1,3 +1,16 @@
+2014-03-26  Brent Fulgham  bfulg...@apple.com
+
+Unreviewed test correction.
+
+Because of the way DRT on Windows links to WebCore, having the implementaion of the update
+method in the header caused a runtime failure due to duplicate symbols being bound to the
+compilation unit.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Moved from header.
+* accessibility/AXObjectCache.h:
+(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility): Deleted.
+
 2014-03-26  Jer Noble  jer.no...@apple.com
 
 REGRESSION(r162679): Poster image visible under the video


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (166306 => 166307)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2014-03-26 19:21:49 UTC (rev 166307)
@@ -118,6 +118,11 @@
 gAccessibilityEnabled = false;
 }
 
+void AXObjectCache::setEnhancedUserInterfaceAccessibility(bool flag)
+{
+gAccessibilityEnhancedUserInterfaceEnabled = flag;
+}
+
 AXObjectCache::AXObjectCache(Document document)
 : m_document(document)
 , m_notificationPostTimer(this, AXObjectCache::notificationPostTimerFired)


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (166306 => 166307)

--- trunk/Source/WebCore/accessibility/AXObjectCache.h	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h	2014-03-26 19:21:49 UTC (rev 166307)
@@ -131,7 +131,7 @@
 static void disableAccessibility();
 
 // Enhanced user interface accessibility can be toggled by the assistive technology.
-static void setEnhancedUserInterfaceAccessibility(bool flag) { gAccessibilityEnhancedUserInterfaceEnabled = flag; }
+static void setEnhancedUserInterfaceAccessibility(bool flag);
 
 static bool accessibilityEnabled() { return gAccessibilityEnabled; }
 static bool accessibilityEnhancedUserInterfaceEnabled() { return gAccessibilityEnhancedUserInterfaceEnabled; }


Modified: trunk/Source/WebKit/ChangeLog (166306 => 166307)

--- trunk/Source/WebKit/ChangeLog	2014-03-26 19:20:58 UTC (rev 166306)
+++ trunk/Source/WebKit/ChangeLog	2014-03-26 19:21:49 UTC (rev 166307)
@@ -1,3 +1,10 @@
+2014-03-26  Brent Fulgham  bfulg...@apple.com
+
+Unreviewed build/test correction.
+
+*

[webkit-changes] [166309] trunk

2014-03-26 Thread simon . fraser

Title: [166309] trunk








Revision 166309
Author simon.fra...@apple.com
Date 2014-03-26 12:36:51 -0700 (Wed, 26 Mar 2014)


Log Message
REGRESSION (r155977): matrix animations no longer animate
https://bugs.webkit.org/show_bug.cgi?id=130789
rdar://problem/15650946

Source/WebCore:

Reviewed by Dean Jackson.

r155977 erroneously removed two lines that set the end points for
matrix animations (used when transform lists don't match), so
put them back.

Also don't repaint when updateContentsScale()
is called and doesn't change the contents scale.

Test: compositing/animation/matrix-animation.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateRootRelativeScale):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::updateContentsScale):

LayoutTests:

Reviewed by Dean Jackson.

Add test for fill-fowards animation with mismatched transform lists.

* compositing/animation/matrix-animation-expected.html: Added.
* compositing/animation/matrix-animation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp


Added Paths

trunk/LayoutTests/compositing/animation/matrix-animation-expected.html
trunk/LayoutTests/compositing/animation/matrix-animation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166308 => 166309)

--- trunk/LayoutTests/ChangeLog	2014-03-26 19:36:49 UTC (rev 166308)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 19:36:51 UTC (rev 166309)
@@ -1,3 +1,16 @@
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
+REGRESSION (r155977): matrix animations no longer animate
+https://bugs.webkit.org/show_bug.cgi?id=130789
+rdar://problem/15650946
+
+Reviewed by Dean Jackson.
+
+Add test for fill-fowards animation with mismatched transform lists.
+
+* compositing/animation/matrix-animation-expected.html: Added.
+* compositing/animation/matrix-animation.html: Added.
+
 2014-03-26  Antti Koivisto  an...@apple.com
 
 Render tree construction is O(N^2) in number of siblings


Added: trunk/LayoutTests/compositing/animation/matrix-animation-expected.html (0 => 166309)

--- trunk/LayoutTests/compositing/animation/matrix-animation-expected.html	(rev 0)
+++ trunk/LayoutTests/compositing/animation/matrix-animation-expected.html	2014-03-26 19:36:51 UTC (rev 166309)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+
+html
+head
+style
+.box {
+height: 100px;
+width: 100px;
+background-color: blue;
+-webkit-transform: scale(1, 1) translate3d(10px, 10px, 0);
+}
+/style
+/head
+body
+div class=box/div
+/body
+/html
Property changes on: trunk/LayoutTests/compositing/animation/matrix-animation-expected.html
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Added: trunk/LayoutTests/compositing/animation/matrix-animation.html (0 => 166309)

--- trunk/LayoutTests/compositing/animation/matrix-animation.html	(rev 0)
+++ trunk/LayoutTests/compositing/animation/matrix-animation.html	2014-03-26 19:36:51 UTC (rev 166309)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+
+html
+head
+style
+#box {
+height: 100px;
+width: 100px;
+background-color: blue;
+-webkit-transform: scale(0.1, 0.1);
+}
+
+.animating {
+-webkit-animation: zoom 1 0.05s forwards;
+}
+
+@-webkit-keyframes zoom {
+from {  }
+to { -webkit-transform: scale(1, 1) translate(10px, 10px); }
+}
+/style
+script
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function doTest()
+{
+var box = document.getElementById('box');
+box.addEventListener('webkitAnimationEnd', function() {
+if (window.testRunner)
+testRunner.notifyDone();
+}, false);
+box.classList.add('animating');
+}
+
+window.addEventListener('load', doTest, false);
+/script
+/head
+body
+div id=box
+/div
+/body
+/html
Property changes on: trunk/LayoutTests/compositing/animation/matrix-animation.html
___


Added: svn:mime-type

Added: svn:keywords

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (166308 => 166309)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:36:49 UTC (rev 166308)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 19:36:51 UTC (rev 166309)
@@ -1,5 +1,27 @@
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
+REGRESSION (r155977): matrix animations no longer animate
+https://bugs.webkit.org/show_bug.cgi?id=130789
+rdar://problem/15650946
+
+Reviewed by Dean Jackson.
+

[webkit-changes] [166308] trunk/Source

2014-03-26 Thread simon . fraser

Title: [166308] trunk/Source








Revision 166308
Author simon.fra...@apple.com
Date 2014-03-26 12:36:49 -0700 (Wed, 26 Mar 2014)


Log Message
Add a custom behavior flag to GraphicsLayer, piped down to PlatformCALayer, for scrolling layers
https://bugs.webkit.org/show_bug.cgi?id=130778

Reviewed by Tim Horton.

Make it possible to put a custom behavior flag on a layer so that,
with UI-side compositing, we know to create a specific type of
layer or view for that GraphicsLayer.

Source/WebCore:

* WebCore.exp.in:
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setCustomBehavior):
(WebCore::GraphicsLayer::customBehavior):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateCustomBehavior):
(WebCore::GraphicsLayerCA::setCustomBehavior):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateScrollingLayers):

Source/WebKit2:

* Shared/mac/RemoteLayerTreeTransaction.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::customBehavior):
(PlatformCALayerRemote::updateCustomBehavior):
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h
trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166307 => 166308)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:21:49 UTC (rev 166307)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 19:36:49 UTC (rev 166308)
@@ -1,3 +1,32 @@
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
+Add a custom behavior flag to GraphicsLayer, piped down to PlatformCALayer, for scrolling layers
+https://bugs.webkit.org/show_bug.cgi?id=130778
+
+Reviewed by Tim Horton.
+
+Make it possible to put a custom behavior flag on a layer so that,
+with UI-side compositing, we know to create a specific type of
+layer or view for that GraphicsLayer.
+
+* WebCore.exp.in:
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::GraphicsLayer):
+* platform/graphics/GraphicsLayer.h:
+(WebCore::GraphicsLayer::setCustomBehavior):
+(WebCore::GraphicsLayer::customBehavior):
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+(WebCore::GraphicsLayerCA::updateCustomBehavior):
+(WebCore::GraphicsLayerCA::setCustomBehavior):
+* platform/graphics/ca/GraphicsLayerCA.h:
+* platform/graphics/ca/PlatformCALayer.h:
+* platform/graphics/ca/mac/PlatformCALayerMac.h:
+* platform/graphics/ca/mac/PlatformCALayerMac.mm:
+(PlatformCALayerMac::PlatformCALayerMac):
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateScrollingLayers):
+
 2014-03-26  Brent Fulgham  bfulg...@apple.com
 
 Unreviewed test correction.


Modified: trunk/Source/WebCore/WebCore.exp.in (166307 => 166308)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-26 19:21:49 UTC (rev 166307)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-26 19:36:49 UTC (rev 166308)
@@ -545,6 +545,7 @@
 __ZN7WebCore15GraphicsLayerCA16resumeAnimationsEv
 __ZN7WebCore15GraphicsLayerCA16setMasksToBoundsEb
 __ZN7WebCore15GraphicsLayerCA17setContentsOpaqueEb
+__ZN7WebCore15GraphicsLayerCA17setCustomBehaviorENS_13GraphicsLayer14CustomBehaviorE
 __ZN7WebCore15GraphicsLayerCA17suspendAnimationsEd
 __ZN7WebCore15GraphicsLayerCA18setAllowTiledLayerEb
 __ZN7WebCore15GraphicsLayerCA18setBackgroundColorERKNS_5ColorE


Modified:

[webkit-changes] [166310] trunk/Source/WebCore

2014-03-26 Thread simon . fraser

Title: [166310] trunk/Source/WebCore








Revision 166310
Author simon.fra...@apple.com
Date 2014-03-26 12:42:03 -0700 (Wed, 26 Mar 2014)


Log Message
Fix the Windows build. Add a no-op impl for Mac non-UI-side.

* platform/graphics/ca/mac/PlatformCALayerMac.h:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::PlatformCALayerWin):
* platform/graphics/ca/win/PlatformCALayerWin.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166309 => 166310)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:36:51 UTC (rev 166309)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 19:42:03 UTC (rev 166310)
@@ -1,5 +1,14 @@
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
+Fix the Windows build. Add a no-op impl for Mac non-UI-side.
+
+* platform/graphics/ca/mac/PlatformCALayerMac.h:
+* platform/graphics/ca/win/PlatformCALayerWin.cpp:
+(PlatformCALayerWin::PlatformCALayerWin):
+* platform/graphics/ca/win/PlatformCALayerWin.h:
+
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
 REGRESSION (r155977): matrix animations no longer animate
 https://bugs.webkit.org/show_bug.cgi?id=130789
 rdar://problem/15650946


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h (166309 => 166310)

--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h	2014-03-26 19:36:51 UTC (rev 166309)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h	2014-03-26 19:42:03 UTC (rev 166310)
@@ -137,7 +137,7 @@
 virtual void updateCustomAppearance(GraphicsLayer::CustomAppearance) override;
 
 virtual GraphicsLayer::CustomBehavior customBehavior() const override { return m_customBehavior; }
-virtual void updateCustomBehavior(GraphicsLayer::CustomBehavior) override { }
+virtual void updateCustomBehavior(GraphicsLayer::CustomBehavior customBehavior) override { m_customBehavior = customBehavior; }
 
 virtual TiledBacking* tiledBacking() override;
 


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp (166309 => 166310)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2014-03-26 19:36:51 UTC (rev 166309)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp	2014-03-26 19:42:03 UTC (rev 166310)
@@ -108,6 +108,7 @@
 PlatformCALayerWin::PlatformCALayerWin(LayerType layerType, PlatformLayer* layer, PlatformCALayerClient* owner)
 : PlatformCALayer(layer ? LayerTypeCustom : layerType, owner)
 , m_customAppearance(GraphicsLayer::NoCustomAppearance)
+, m_customBehavior(GraphicsLayer::NoCustomBehavior)
 {
 if (layer) {
 m_layer = layer;


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h (166309 => 166310)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2014-03-26 19:36:51 UTC (rev 166309)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h	2014-03-26 19:42:03 UTC (rev 166310)
@@ -129,6 +129,9 @@
 virtual GraphicsLayer::CustomAppearance customAppearance() const override { return m_customAppearance; }
 virtual void updateCustomAppearance(GraphicsLayer::CustomAppearance customAppearance) override { m_customAppearance = customAppearance; }
 
+virtual GraphicsLayer::CustomBehavior customBehavior() const override { return m_customBehavior; }
+virtual void updateCustomBehavior(GraphicsLayer::CustomBehavior customBehavior) override { m_customBehavior = customBehavior; }
+
 virtual TiledBacking* tiledBacking() override { return nullptr; }
 
 virtual PlatformCALayer* rootLayer() const override;
@@ -148,6 +151,7 @@
 
 HashMapString, RefPtrPlatformCAAnimation m_animations;
 GraphicsLayer::CustomAppearance m_customAppearance;
+GraphicsLayer::CustomBehavior m_customBehavior;
 };
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166311] trunk/Source/WebCore

2014-03-26 Thread bfulgham

Title: [166311] trunk/Source/WebCore








Revision 166311
Author bfulg...@apple.com
Date 2014-03-26 12:52:07 -0700 (Wed, 26 Mar 2014)


Log Message
Fix OS X build.

* WebCore.exp.in: Add missing export symbol.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (166310 => 166311)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:42:03 UTC (rev 166310)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 19:52:07 UTC (rev 166311)
@@ -1,3 +1,9 @@
+2014-03-26  Brent Fulgham  bfulg...@apple.com
+
+Fix OS X build.
+
+* WebCore.exp.in: Add missing export symbol.
+
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
 Fix the Windows build. Add a no-op impl for Mac non-UI-side.


Modified: trunk/Source/WebCore/WebCore.exp.in (166310 => 166311)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-26 19:42:03 UTC (rev 166310)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-26 19:52:07 UTC (rev 166311)
@@ -251,6 +251,7 @@
 __ZN7WebCore12gcControllerEv
 __ZN7WebCore12iconDatabaseEv
 __ZN7WebCore13AXObjectCache10rootObjectEv
+__ZN7WebCore13AXObjectCache37setEnhancedUserInterfaceAccessibilityEb
 __ZN7WebCore13AXObjectCache18rootObjectForFrameEPNS_5FrameE
 __ZN7WebCore13AXObjectCache19enableAccessibilityEv
 __ZN7WebCore13AXObjectCache20disableAccessibilityEv






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166312] trunk/Source

2014-03-26 Thread commit-queue

Title: [166312] trunk/Source








Revision 166312
Author commit-qu...@webkit.org
Date 2014-03-26 13:17:39 -0700 (Wed, 26 Mar 2014)


Log Message
Implement hasLiveStreamingContent property in WebAVPlayerController
https://bugs.webkit.org/show_bug.cgi?id=128684

Patch by Jeremy Jones jere...@apple.com on 2014-03-26
Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.exp.in:
Add export for WebVideoFullscreenInterfaceAVKit::setSeekableRanges().

* platform/ios/WebVideoFullscreenInterface.h:
Add setSeekableRanges()

* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Add setSeekableRanges()

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Remove vestigial playerLayer property. Add seekableTimeRanges property.

(-[WebAVPlayerController dealloc]):
Release _seekableTimeRanges.
Remove references to _playerLayer.

(-[WebAVPlayerController hasLiveStreamingContent]):
Implement based on duration. Live stream has an infinite duration.

(+[WebAVPlayerController keyPathsForValuesAffectingHasLiveStreamingContent]):
Describe dependent keys for computed property hasLiveStreamingContent.

(-[WebAVPlayerController skipBackwardThirtySeconds:]):
Seek back 30 seconds if that time is in the seekable ranges.

(-[WebAVPlayerController gotoEndOfSeekableRanges:]):
Jump to live by going to the of the seekable ranges.

(WebVideoFullscreenInterfaceAVKit::setSeekableRanges):
Convert TimeRange to CMTimeRange.

* platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setMediaElement):
Set initial seekable ranges.

(WebVideoFullscreenModelMediaElement::handleEvent):
Update seekable ranges when time changes.

Source/WebKit2:

Plumb through the seekable ranges to the fullscreen interface.

* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
Add declaration for setSeekableRangesVector()

* UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
Add interface SetSeekableRangesVector()

* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setSeekableRangesVector):
Add setSeekableRangesVector that translates the vector into a TimeRanges and calls setSeekableRanges()

* WebProcess/ios/WebVideoFullscreenManager.h:
Add setSeekableRanges()

* WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::setSeekableRanges):
setSeekableRanges() converts TimeRanges to Vector and calls SetSeekableRangesVector()

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterface.h
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
trunk/Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h
trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in
trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm
trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h
trunk/Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166311 => 166312)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 19:52:07 UTC (rev 166311)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 20:17:39 UTC (rev 166312)
@@ -1,3 +1,48 @@
+2014-03-26  Jeremy Jones  jere...@apple.com
+
+Implement hasLiveStreamingContent property in WebAVPlayerController
+https://bugs.webkit.org/show_bug.cgi?id=128684
+
+Reviewed by Simon Fraser.
+
+* WebCore.exp.in:
+Add export for WebVideoFullscreenInterfaceAVKit::setSeekableRanges().
+
+* platform/ios/WebVideoFullscreenInterface.h:
+Add setSeekableRanges()
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
+Add setSeekableRanges()
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+Remove vestigial playerLayer property. Add seekableTimeRanges property.
+
+(-[WebAVPlayerController dealloc]):
+Release _seekableTimeRanges.
+Remove references to _playerLayer.
+
+(-[WebAVPlayerController hasLiveStreamingContent]):
+Implement based on duration. Live stream has an infinite duration.
+
+(+[WebAVPlayerController keyPathsForValuesAffectingHasLiveStreamingContent]):
+Describe dependent keys for computed property hasLiveStreamingContent.
+
+(-[WebAVPlayerController skipBackwardThirtySeconds:]):
+Seek back 30 seconds if that time is in the seekable ranges.
+
+(-[WebAVPlayerController gotoEndOfSeekableRanges:]):
+Jump to live by going to the of the seekable ranges.
+
+(WebVideoFullscreenInterfaceAVKit::setSeekableRanges):
+Convert TimeRange to CMTimeRange.
+
+* platform/ios/WebVideoFullscreenModelMediaElement.mm:
+(WebVideoFullscreenModelMediaElement::setMediaElement):
+Set initial seekable

[webkit-changes] [166313] trunk/Source/JavaScriptCore

2014-03-26 Thread fpizlo

Title: [166313] trunk/Source/_javascript_Core








Revision 166313
Author fpi...@apple.com
Date 2014-03-26 13:49:42 -0700 (Wed, 26 Mar 2014)


Log Message
Reasoning about DWARF register numbers should be moved out of FTL::Location
https://bugs.webkit.org/show_bug.cgi?id=130792

Reviewed by Oliver Hunt.

Moving this code makes it possible for things other than FTL::Location to reason about
DWARF register encoding. This refactoring also appears to reduce some code duplication
and makes FTLLocation.cpp cleaner.

* _javascript_Core.xcodeproj/project.pbxproj:
* ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
* ftl/FTLDWARFRegister.cpp: Added.
(JSC::FTL::DWARFRegister::reg):
(JSC::FTL::DWARFRegister::dump):
* ftl/FTLDWARFRegister.h: Added.
(JSC::FTL::DWARFRegister::DWARFRegister):
(JSC::FTL::DWARFRegister::dwarfRegNum):
* ftl/FTLLocation.cpp:
(JSC::FTL::Location::dump):
(JSC::FTL::Location::isGPR):
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::isFPR):
(JSC::FTL::Location::fpr):
* ftl/FTLLocation.h:
(JSC::FTL::Location::hasDwarfReg):
(JSC::FTL::Location::dwarfReg):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLLocation.cpp
trunk/Source/_javascript_Core/ftl/FTLLocation.h


Added Paths

trunk/Source/_javascript_Core/ftl/FTLDWARFRegister.cpp
trunk/Source/_javascript_Core/ftl/FTLDWARFRegister.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (166312 => 166313)

--- trunk/Source/_javascript_Core/ChangeLog	2014-03-26 20:17:39 UTC (rev 166312)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-26 20:49:42 UTC (rev 166313)
@@ -1,3 +1,33 @@
+2014-03-26  Filip Pizlo  fpi...@apple.com
+
+Reasoning about DWARF register numbers should be moved out of FTL::Location
+https://bugs.webkit.org/show_bug.cgi?id=130792
+
+Reviewed by Oliver Hunt.
+
+Moving this code makes it possible for things other than FTL::Location to reason about
+DWARF register encoding. This refactoring also appears to reduce some code duplication
+and makes FTLLocation.cpp cleaner.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* ftl/FTLCompile.cpp:
+(JSC::FTL::fixFunctionBasedOnStackMaps):
+* ftl/FTLDWARFRegister.cpp: Added.
+(JSC::FTL::DWARFRegister::reg):
+(JSC::FTL::DWARFRegister::dump):
+* ftl/FTLDWARFRegister.h: Added.
+(JSC::FTL::DWARFRegister::DWARFRegister):
+(JSC::FTL::DWARFRegister::dwarfRegNum):
+* ftl/FTLLocation.cpp:
+(JSC::FTL::Location::dump):
+(JSC::FTL::Location::isGPR):
+(JSC::FTL::Location::gpr):
+(JSC::FTL::Location::isFPR):
+(JSC::FTL::Location::fpr):
+* ftl/FTLLocation.h:
+(JSC::FTL::Location::hasDwarfReg):
+(JSC::FTL::Location::dwarfReg):
+
 2014-03-26  Brent Fulgham  bfulg...@apple.com
 
 Unreviewed build fix.


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (166312 => 166313)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2014-03-26 20:17:39 UTC (rev 166312)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2014-03-26 20:49:42 UTC (rev 166313)
@@ -380,6 +380,8 @@
 		0F9749711687ADE400A4FF6A /* JSCellInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F97496F1687ADE200A4FF6A /* JSCellInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0F98206016BFE38100240D02 /* PreciseJumpTargets.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F98205D16BFE37F00240D02 /* PreciseJumpTargets.cpp */; };
 		0F98206116BFE38300240D02 /* PreciseJumpTargets.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F98205E16BFE37F00240D02 /* PreciseJumpTargets.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		0F9C5E5E18E35F5E00D431C3 /* FTLDWARFRegister.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F9C5E5C18E35F5E00D431C3 /* FTLDWARFRegister.cpp */; };
+		0F9C5E5F18E35F5E00D431C3 /* FTLDWARFRegister.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F9C5E5D18E35F5E00D431C3 /* FTLDWARFRegister.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0F9D3370165DBB90005AD387 /* Disassembler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F9D336E165DBB8D005AD387 /* Disassembler.cpp */; };
 		0F9D339617FFC4E60073C2BC /* DFGFlushedAt.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0F9D339417FFC4E60073C2BC /* DFGFlushedAt.cpp */; };
 		0F9D339717FFC4E60073C2BC /* DFGFlushedAt.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F9D339517FFC4E60073C2BC /* DFGFlushedAt.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -1904,6 +1906,8 @@
 		0F97496F1687ADE200A4FF6A /* JSCellInlines.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSCellInlines.h; sourceTree = group; };
 		0F98205D16BFE37F00240D02 /*

[webkit-changes] [166314] trunk/Source/WebKit2

2014-03-26 Thread andersca

Title: [166314] trunk/Source/WebKit2








Revision 166314
Author ander...@apple.com
Date 2014-03-26 13:56:10 -0700 (Wed, 26 Mar 2014)


Log Message
Pass a real FrameLoadRequest to Chrome::createWindow
https://bugs.webkit.org/show_bug.cgi?id=130795

Reviewed by Dan Bernstein.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchCreatePage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166313 => 166314)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 20:49:42 UTC (rev 166313)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 20:56:10 UTC (rev 166314)
@@ -1,3 +1,13 @@
+2014-03-26  Anders Carlsson  ander...@apple.com
+
+Pass a real FrameLoadRequest to Chrome::createWindow
+https://bugs.webkit.org/show_bug.cgi?id=130795
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchCreatePage):
+
 2014-03-26  Jeremy Jones  jere...@apple.com
 
 Implement hasLiveStreamingContent property in WebAVPlayerController


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (166313 => 166314)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-03-26 20:49:42 UTC (rev 166313)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2014-03-26 20:56:10 UTC (rev 166314)
@@ -610,7 +610,7 @@
 return 0;
 
 // Just call through to the chrome client.
-Page* newPage = webPage-corePage()-chrome().createWindow(m_frame-coreFrame(), FrameLoadRequest(m_frame-coreFrame()-document()-securityOrigin()), WindowFeatures(), navigationAction);
+Page* newPage = webPage-corePage()-chrome().createWindow(m_frame-coreFrame(), FrameLoadRequest(m_frame-coreFrame()-document()-securityOrigin(), navigationAction.resourceRequest()), WindowFeatures(), navigationAction);
 if (!newPage)
 return 0;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166315] trunk/Source/WebKit2

2014-03-26 Thread aestes

Title: [166315] trunk/Source/WebKit2








Revision 166315
Author aes...@apple.com
Date 2014-03-26 14:04:27 -0700 (Wed, 26 Mar 2014)


Log Message
[Cocoa] Expose DownloadProxy::request()
https://bugs.webkit.org/show_bug.cgi?id=130796

Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/_WKDownload.h:
* UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload request]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166314 => 166315)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 20:56:10 UTC (rev 166314)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 21:04:27 UTC (rev 166315)
@@ -1,3 +1,14 @@
+2014-03-26  Andy Estes  aes...@apple.com
+
+[Cocoa] Expose DownloadProxy::request()
+https://bugs.webkit.org/show_bug.cgi?id=130796
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/Cocoa/_WKDownload.h:
+* UIProcess/API/Cocoa/_WKDownload.mm:
+(-[_WKDownload request]):
+
 2014-03-26  Anders Carlsson  ander...@apple.com
 
 Pass a real FrameLoadRequest to Chrome::createWindow


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h (166314 => 166315)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h	2014-03-26 20:56:10 UTC (rev 166314)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h	2014-03-26 21:04:27 UTC (rev 166315)
@@ -32,6 +32,8 @@
 WK_API_CLASS
 @interface _WKDownload : NSObject
 
+@property (nonatomic, readonly) NSURLRequest *request;
+
 @end
 
 #endif // WK_API_ENABLED


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm (166314 => 166315)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm	2014-03-26 20:56:10 UTC (rev 166314)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm	2014-03-26 21:04:27 UTC (rev 166315)
@@ -41,6 +41,11 @@
 [super dealloc];
 }
 
+- (NSURLRequest *)request
+{
+return _download-request().nsURLRequest(WebCore::DoNotUpdateHTTPBody);
+}
+
 #pragma mark WKObject protocol implementation
 
 - (API::Object)_apiObject






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166317] trunk/Source

2014-03-26 Thread timothy

Title: [166317] trunk/Source








Revision 166317
Author timo...@apple.com
Date 2014-03-26 14:20:01 -0700 (Wed, 26 Mar 2014)


Log Message
Propagate the hiddenFromInspector flag on ResourceRequest in
places when a new request a made or passed between processes.

https://bugs.webkit.org/show_bug.cgi?id=130741

Reviewed by Joseph Pecoraro.

Source/WebCore:

* WebCore.exp.in: Updated symbols for updateFromDelegatePreservingOldProperties.
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
* platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
* platform/network/soup/ResourceRequest.h:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSendRequest): Copy hiddenFromInspector to
the new request.

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest): Use updateFromDelegatePreservingOldProperties.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoderResourceRequest::encode): Added hiddenFromInspector support.
(IPC::ArgumentCoderResourceRequest::decode): Ditto.
* WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/network/cf/ResourceRequest.h
trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
trunk/Source/WebCore/platform/network/curl/ResourceRequest.h
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm
trunk/Source/WebCore/platform/network/soup/ResourceRequest.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166316 => 166317)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 21:06:49 UTC (rev 166316)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 21:20:01 UTC (rev 166317)
@@ -1,3 +1,27 @@
+2014-03-26  Timothy Hatcher  timo...@apple.com
+
+Propagate the hiddenFromInspector flag on ResourceRequest in
+places when a new request a made or passed between processes.
+
+https://bugs.webkit.org/show_bug.cgi?id=130741
+
+Reviewed by Joseph Pecoraro.
+
+* WebCore.exp.in: Updated symbols for updateFromDelegatePreservingOldProperties.
+* platform/network/cf/ResourceRequest.h:
+* platform/network/cf/ResourceRequestCFNet.cpp:
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
+* platform/network/curl/ResourceRequest.h:
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
+* platform/network/mac/ResourceRequestMac.mm:
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
+* platform/network/soup/ResourceRequest.h:
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Added.
+(WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody): Deleted.
+
 2014-03-26  Zoltan Horvath  zol...@webkit.org
 
 [CSS Shapes] Remove no-longer-used shape-inside geometry code


Modified: trunk/Source/WebCore/WebCore.exp.in (166316 => 166317)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-26 21:06:49 UTC (rev 166316)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-26 21:20:01 UTC (rev 166317)
@@ -2133,7 +2133,7 @@
 __ZN7WebCore14cookiesEnabledERKNS_21NetworkStorageSessionERKNS_3URLES5_
 __ZN7WebCore15GraphicsContext15drawNativeImageEP7CGImageRKNS_9FloatSizeENS_10ColorSpaceERKNS_9FloatRectES9_fNS_17CompositeOperatorENS_9BlendModeENS_16ImageOrientationE
 __ZN7WebCore15GraphicsContextC1EP9CGContext
-__ZN7WebCore15ResourceRequest39updateFromDelegatePreservingOldHTTPBodyERKS0_

[webkit-changes] [166318] trunk/Source/WebKit2

2014-03-26 Thread aestes

Title: [166318] trunk/Source/WebKit2








Revision 166318
Author aes...@apple.com
Date 2014-03-26 14:32:19 -0700 (Wed, 26 Mar 2014)


Log Message
[Cocoa] Expose DownloadProxy::cancel()
https://bugs.webkit.org/show_bug.cgi?id=130799

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/_WKDownload.h:
* UIProcess/API/Cocoa/_WKDownload.mm:
(-[_WKDownload cancel]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166317 => 166318)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 21:20:01 UTC (rev 166317)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 21:32:19 UTC (rev 166318)
@@ -1,3 +1,14 @@
+2014-03-26  Andy Estes  aes...@apple.com
+
+[Cocoa] Expose DownloadProxy::cancel()
+https://bugs.webkit.org/show_bug.cgi?id=130799
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/_WKDownload.h:
+* UIProcess/API/Cocoa/_WKDownload.mm:
+(-[_WKDownload cancel]):
+
 2014-03-26  Timothy Hatcher  timo...@apple.com
 
 Propagate the hiddenFromInspector flag on ResourceRequest in


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h (166317 => 166318)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h	2014-03-26 21:20:01 UTC (rev 166317)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.h	2014-03-26 21:32:19 UTC (rev 166318)
@@ -32,6 +32,8 @@
 WK_API_CLASS
 @interface _WKDownload : NSObject
 
+- (void)cancel;
+
 @property (nonatomic, readonly) NSURLRequest *request;
 
 @end


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm (166317 => 166318)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm	2014-03-26 21:20:01 UTC (rev 166317)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownload.mm	2014-03-26 21:32:19 UTC (rev 166318)
@@ -41,6 +41,11 @@
 [super dealloc];
 }
 
+- (void)cancel
+{
+_download-cancel();
+}
+
 - (NSURLRequest *)request
 {
 return _download-request().nsURLRequest(WebCore::DoNotUpdateHTTPBody);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166319] trunk/Source/WebCore

2014-03-26 Thread psolanki

Title: [166319] trunk/Source/WebCore








Revision 166319
Author psola...@apple.com
Date 2014-03-26 14:45:27 -0700 (Wed, 26 Mar 2014)


Log Message
Unreviewed. iOS build fix after r166312. Soft link CMTimeRangeGetEnd.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166318 => 166319)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 21:32:19 UTC (rev 166318)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 21:45:27 UTC (rev 166319)
@@ -1,3 +1,9 @@
+2014-03-26  Pratik Solanki  psola...@apple.com
+
+Unreviewed. iOS build fix after r166312. Soft link CMTimeRangeGetEnd.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+
 2014-03-26  Timothy Hatcher  timo...@apple.com
 
 Propagate the hiddenFromInspector flag on ResourceRequest in


Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (166318 => 166319)

--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-03-26 21:32:19 UTC (rev 166318)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2014-03-26 21:45:27 UTC (rev 166319)
@@ -68,6 +68,7 @@
 SOFT_LINK(CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time))
 SOFT_LINK(CoreMedia, CMTimeMake, CMTime, (int64_t value, int32_t timescale), (value, timescale))
 SOFT_LINK(CoreMedia, CMTimeRangeContainsTime, Boolean, (CMTimeRange range, CMTime time), (range, time))
+SOFT_LINK(CoreMedia, CMTimeRangeGetEnd, CMTime, (CMTimeRange range), (range))
 SOFT_LINK(CoreMedia, CMTimeRangeMake, CMTimeRange, (CMTime start, CMTime duration), (start, duration))
 SOFT_LINK(CoreMedia, CMTimeSubtract, CMTime, (CMTime minuend, CMTime subtrahend), (minuend, subtrahend))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166320] tags/Safari-537.75.14/

2014-03-26 Thread matthew_hanson

Title: [166320] tags/Safari-537.75.14/








Revision 166320
Author matthew_han...@apple.com
Date 2014-03-26 15:00:01 -0700 (Wed, 26 Mar 2014)


Log Message
New tag.

Added Paths

tags/Safari-537.75.14/




Diff

Property changes: tags/Safari-537.75.14



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166322] trunk

2014-03-26 Thread mmaxfield

Title: [166322] trunk








Revision 166322
Author mmaxfi...@apple.com
Date 2014-03-26 15:05:24 -0700 (Wed, 26 Mar 2014)


Log Message
Skipping underlines disregard points completely inside the underline rect
https://bugs.webkit.org/show_bug.cgi?id=130800

Patch by Myles C. Maxfield mmaxfi...@apple.com on 2014-03-26
Reviewed by Dean Jackson.

Source/WebCore:

When determining bounds for underline skipping, endpoints of glyph contours
that lie entirely within the rect of the underline are ignored. This patch
makes these points affect the skipping regions the same way that intersections
do.

Test: fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html

* platform/graphics/mac/FontMac.mm:
(WebCore::updateX): Refactored common code into a function
(WebCore::findPathIntersections): Test for endpoints which lie entirely within
the underline bounds

LayoutTests:

This test draws a glyph entire inside the underline. It should render the same
as it would without any underline at all.

* fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg: Added
an underscore glyph that would lie entirely within an underline
* fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm


Added Paths

trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline-expected.html
trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html




Diff

Modified: trunk/LayoutTests/ChangeLog (166321 => 166322)

--- trunk/LayoutTests/ChangeLog	2014-03-26 22:02:26 UTC (rev 166321)
+++ trunk/LayoutTests/ChangeLog	2014-03-26 22:05:24 UTC (rev 166322)
@@ -1,3 +1,17 @@
+2014-03-26  Myles C. Maxfield  mmaxfi...@apple.com
+
+Skipping underlines disregard points completely inside the underline rect
+https://bugs.webkit.org/show_bug.cgi?id=130800
+
+Reviewed by Dean Jackson.
+
+This test draws a glyph entire inside the underline. It should render the same
+as it would without any underline at all.
+
+* fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg: Added
+an underscore glyph that would lie entirely within an underline
+* fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html:
+
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
 REGRESSION (r155977): matrix animations no longer animate


Added: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline-expected.html (0 => 166322)

--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline-expected.html	2014-03-26 22:05:24 UTC (rev 166322)
@@ -0,0 +1,19 @@
+!DOCTYPE html
+html
+head
+style
+@font-face {
+font-family: 'Litherum';
+src: url(./resources/Litherum.svg) format(svg)
+}
+#p {
+font: 100px 'Litherum';
+}
+/style
+/head
+body
+This test draws an underscore that should entirely fit within an underline.
+The underline should skip over the entire glyph.
+div id=p_/div
+/body
+/html


Added: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html (0 => 166322)

--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html	(rev 0)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/glyph-inside-underline.html	2014-03-26 22:05:24 UTC (rev 166322)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+head
+style
+@font-face {
+font-family: 'Litherum';
+src: url(./resources/Litherum.svg) format(svg)
+}
+#p {
+font: 100px 'Litherum';
+text-decoration: underline;
+}
+/style
+/head
+body
+This test draws an underscore that should entirely fit within an underline.
+The underline should skip over the entire glyph.
+div id=p_/div
+/body
+/html


Modified: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg (166321 => 166322)

--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg	2014-03-26 22:02:26 UTC (rev 166321)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-skip/resources/Litherum.svg	2014-03-26 22:05:24 UTC (rev 166322)
@@ -4,8 +4,9 @@
 metadata/metadata
 defs
 font id=Litherum horiz-adv-x=1024
-font-face units-per-em=14 ascent=14 descent=-7/
-glyph unicode=| horiz-adv-x=14 d=M5 -7v21h4v-21z/
+font-face units-per-em=56 ascent=56 descent=-28/
+glyph unicode=| horiz-adv-x=56 d=M20

[webkit-changes] [166323] trunk/Source/WebCore

2014-03-26 Thread zalan

Title: [166323] trunk/Source/WebCore








Revision 166323
Author za...@apple.com
Date 2014-03-26 15:43:22 -0700 (Wed, 26 Mar 2014)


Log Message
Device scale factor should always be greater than 0.
https://bugs.webkit.org/show_bug.cgi?id=130798

Reviewed by David Kilzer.

Rendering context requires a device scale factor  0 so that we can map CSS pixels
to device pixels properly. Neither 0 nor a negative device pixel ratio are considered to be valid.

* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166322 => 166323)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 22:05:24 UTC (rev 166322)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 22:43:22 UTC (rev 166323)
@@ -1,3 +1,16 @@
+2014-03-26  Zalan Bujtas  za...@apple.com
+
+Device scale factor should always be greater than 0.
+https://bugs.webkit.org/show_bug.cgi?id=130798
+
+Reviewed by David Kilzer.
+
+Rendering context requires a device scale factor  0 so that we can map CSS pixels
+to device pixels properly. Neither 0 nor a negative device pixel ratio are considered to be valid.
+
+* page/Page.cpp:
+(WebCore::Page::setDeviceScaleFactor):
+
 2014-03-26  Myles C. Maxfield  mmaxfi...@apple.com
 
 Skipping underlines disregard points completely inside the underline rect


Modified: trunk/Source/WebCore/page/Page.cpp (166322 => 166323)

--- trunk/Source/WebCore/page/Page.cpp	2014-03-26 22:05:24 UTC (rev 166322)
+++ trunk/Source/WebCore/page/Page.cpp	2014-03-26 22:43:22 UTC (rev 166323)
@@ -734,6 +734,10 @@
 
 void Page::setDeviceScaleFactor(float scaleFactor)
 {
+ASSERT(scaleFactor  0);
+if (scaleFactor = 0)
+return;
+
 if (m_deviceScaleFactor == scaleFactor)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166324] branches/safari-537.75-branch/LayoutTests

2014-03-26 Thread matthew_hanson

Title: [166324] branches/safari-537.75-branch/LayoutTests








Revision 166324
Author matthew_han...@apple.com
Date 2014-03-26 16:17:27 -0700 (Wed, 26 Mar 2014)


Log Message
Remove artifacts of local changes that made it into a versioning commit.

Modified Paths

branches/safari-537.75-branch/LayoutTests/ChangeLog


Removed Paths

branches/safari-537.75-branch/LayoutTests/js/resources/




Diff

Modified: branches/safari-537.75-branch/LayoutTests/ChangeLog (166323 => 166324)

--- branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-03-26 22:43:22 UTC (rev 166323)
+++ branches/safari-537.75-branch/LayoutTests/ChangeLog	2014-03-26 23:17:27 UTC (rev 166324)
@@ -1,3 +1,38 @@
+2014-03-26  Matthew Hanson  matthew_han...@apple.com
+
+Remove artifacts of local changes that made it into a versioning commit.
+
+Unreviewed.
+
+* js/resources: Removed.
+* js/resources/JSON-parse.js: Removed.
+* js/resources/JSON-stringify.js: Removed.
+* js/resources/bom-in-file-retains-correct-offset.js: Removed.
+* js/resources/codegen-temporaries-multiple-global-blocks-1.js: Removed.
+* js/resources/codegen-temporaries-multiple-global-blocks-2.js: Removed.
+* js/resources/const.js: Removed.
+* js/resources/document-all-between-frames-subframe.html: Removed.
+* js/resources/empty-worker.js: Removed.
+* js/resources/fs-test-post.js: Removed.
+* js/resources/garbage-collect-after-string-appends.js-disabled: Removed.
+* js/resources/getOwnPropertyDescriptor.js: Removed.
+* js/resources/image-preload-helper.js: Removed.
+* js/resources/instanceof-operator-dummy-worker.js: Removed.
+* js/resources/js-constructors-use-correct-global.js: Removed.
+* js/resources/js-test-post-async.js: Removed.
+* js/resources/js-test-post.js: Removed.
+* js/resources/js-test-pre.js: Removed.
+* js/resources/js-test-style.css: Removed.
+* js/resources/json2-es5-compat.js: Removed.
+* js/resources/lexical-lookup-in-function-constructor-child.html: Removed.
+* js/resources/parse-error-external-script-in-eval.js: Removed.
+* js/resources/parse-error-external-script-in-new-Function.js: Removed.
+* js/resources/script-line-number.js: Removed.
+* js/resources/select-options-remove.js: Removed.
+* js/resources/standalone-post.js: Removed.
+* js/resources/standalone-pre.js: Removed.
+* js/resources/string-concatenate-outofmemory.js: Removed.
+
 2014-03-21  Matthew Hanson  matthew_han...@apple.com
 
 Merge r166090.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166325] trunk/Source/WebCore

2014-03-26 Thread thiago . lacerda

Title: [166325] trunk/Source/WebCore








Revision 166325
Author thiago.lace...@openbossa.org
Date 2014-03-26 16:26:48 -0700 (Wed, 26 Mar 2014)


Log Message
Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions
https://bugs.webkit.org/show_bug.cgi?id=130689

Reviewed by Eric Carlson.

RTCOfferAnswerOptions and RTCOfferOptions objects were being passed to platform class, causing a layer
violation.

* Modules/mediastream/RTCOfferAnswerOptions.cpp:
(WebCore::RTCOfferAnswerOptions::initialize):
(WebCore::RTCOfferOptions::initialize):
* Modules/mediastream/RTCOfferAnswerOptions.h:
(WebCore::RTCOfferAnswerOptions::requestIdentity):
(WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions):
(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
(WebCore::RTCOfferOptions::offerToReceiveVideo):
(WebCore::RTCOfferOptions::offerToReceiveAudio):
(WebCore::RTCOfferOptions::voiceActivityDetection):
(WebCore::RTCOfferOptions::iceRestart):
(WebCore::RTCOfferOptions::privateOfferOptions):
(WebCore::RTCOfferOptions::RTCOfferOptions):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
* platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Added.
* platform/mediastream/RTCPeerConnectionHandler.h:
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createOffer):
(WebCore::RTCPeerConnectionHandlerMock::createAnswer):
* platform/mock/RTCPeerConnectionHandlerMock.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.cpp
trunk/Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
trunk/Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h
trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.cpp
trunk/Source/WebCore/platform/mock/RTCPeerConnectionHandlerMock.h


Added Paths

trunk/Source/WebCore/platform/mediastream/RTCOfferAnswerOptionsPrivate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166324 => 166325)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 23:17:27 UTC (rev 166324)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 23:26:48 UTC (rev 166325)
@@ -1,3 +1,36 @@
+2014-03-26  Thiago de Barros Lacerda  thiago.lace...@openbossa.org
+
+Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions
+https://bugs.webkit.org/show_bug.cgi?id=130689
+
+Reviewed by Eric Carlson.
+
+RTCOfferAnswerOptions and RTCOfferOptions objects were being passed to platform class, causing a layer
+violation.
+
+* Modules/mediastream/RTCOfferAnswerOptions.cpp:
+(WebCore::RTCOfferAnswerOptions::initialize):
+(WebCore::RTCOfferOptions::initialize):
+* Modules/mediastream/RTCOfferAnswerOptions.h:
+(WebCore::RTCOfferAnswerOptions::requestIdentity):
+(WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions):
+(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
+(WebCore::RTCOfferOptions::offerToReceiveVideo):
+(WebCore::RTCOfferOptions::offerToReceiveAudio):
+(WebCore::RTCOfferOptions::voiceActivityDetection):
+(WebCore::RTCOfferOptions::iceRestart):
+(WebCore::RTCOfferOptions::privateOfferOptions):
+(WebCore::RTCOfferOptions::RTCOfferOptions):
+* Modules/mediastream/RTCPeerConnection.cpp:
+(WebCore::RTCPeerConnection::createOffer):
+(WebCore::RTCPeerConnection::createAnswer):
+* platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Added.
+* platform/mediastream/RTCPeerConnectionHandler.h:
+* platform/mock/RTCPeerConnectionHandlerMock.cpp:
+(WebCore::RTCPeerConnectionHandlerMock::createOffer):
+(WebCore::RTCPeerConnectionHandlerMock::createAnswer):
+* platform/mock/RTCPeerConnectionHandlerMock.h:
+
 2014-03-26  Zalan Bujtas  za...@apple.com
 
 Device scale factor should always be greater than 0.


Modified: trunk/Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.cpp (166324 => 166325)

--- trunk/Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.cpp	2014-03-26 23:17:27 UTC (rev 166324)
+++ trunk/Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.cpp	2014-03-26 23:26:48 UTC (rev 166325)
@@ -32,11 +32,6 @@
 
 namespace WebCore {
 
-static bool validateRequestIdentity(const String value)
-{
-return value == yes || value == no || value == ifconfigured;
-}
-
 PassRefPtrRTCOfferAnswerOptions RTCOfferAnswerOptions::create(const Dictionary options, ExceptionCode ec)
 {
 RefPtrRTCOfferAnswerOptions offerAnswerOptions = adoptRef(new RTCOfferAnswerOptions());
@@ -53,13 +48,14 @@
 
 bool RTCOfferAnswerOptions::initialize(const Dictionary options)
 {
+if (!m_private)
+m_private = RTCOfferAnswerOptionsPrivate::create();
+
 String requestIdentity;
 if (!options.isUndefinedOrNull()

[webkit-changes] [166326] trunk/Source/WebKit2

2014-03-26 Thread commit-queue

Title: [166326] trunk/Source/WebKit2








Revision 166326
Author commit-qu...@webkit.org
Date 2014-03-26 16:35:39 -0700 (Wed, 26 Mar 2014)


Log Message
-[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.

https://bugs.webkit.org/show_bug.cgi?id=130804

Patch by Cody Krieger c...@apple.com on 2014-03-26
Reviewed by Dan Bernstein.

The existing implementations of these methods are mis-cased
(HTMLInputELementIsUserEdited and HTMLTextAreaELementIsUserEdited —
note the EL in both cases). This results in us getting
auto-synthesized getters for the HTMLInputElementIsUserEdited and
HTMLTextAreaElementIsUserEdited properties, which will return NO
unconditionally.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
Fix the capitalization of -HTMLInputElementIsUserEdited and
-HTMLTextAreaElementIsUserEdited.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166325 => 166326)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 23:26:48 UTC (rev 166325)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 23:35:39 UTC (rev 166326)
@@ -1,3 +1,22 @@
+2014-03-26  Cody Krieger  c...@apple.com
+
+-[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.
+
+https://bugs.webkit.org/show_bug.cgi?id=130804
+
+Reviewed by Dan Bernstein.
+
+The existing implementations of these methods are mis-cased
+(HTMLInputELementIsUserEdited and HTMLTextAreaELementIsUserEdited —
+note the EL in both cases). This results in us getting
+auto-synthesized getters for the HTMLInputElementIsUserEdited and
+HTMLTextAreaElementIsUserEdited properties, which will return NO
+unconditionally.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
+Fix the capitalization of -HTMLInputElementIsUserEdited and
+-HTMLTextAreaElementIsUserEdited.
+
 2014-03-26  Andy Estes  aes...@apple.com
 
 [Cocoa] Expose DownloadProxy::cancel()


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm (166325 => 166326)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm	2014-03-26 23:26:48 UTC (rev 166325)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm	2014-03-26 23:35:39 UTC (rev 166326)
@@ -78,12 +78,12 @@
 _nodeHandle-setHTMLInputElementAutofilled(isAutoFilled);
 }
 
-- (BOOL)HTMLInputELementIsUserEdited
+- (BOOL)HTMLInputElementIsUserEdited
 {
 return _nodeHandle-htmlInputElementLastChangeWasUserEdit();
 }
 
-- (BOOL)HTMLTextAreaELementIsUserEdited
+- (BOOL)HTMLTextAreaElementIsUserEdited
 {
 return _nodeHandle-htmlTextAreaElementLastChangeWasUserEdit();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166327] trunk/Tools

2014-03-26 Thread andersca

Title: [166327] trunk/Tools








Revision 166327
Author ander...@apple.com
Date 2014-03-26 16:36:08 -0700 (Wed, 26 Mar 2014)


Log Message
Change MiniBrowser to hold on to window controllers instead of windows
https://bugs.webkit.org/show_bug.cgi?id=130797

Reviewed by Oliver Hunt.

* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate browserWindowWillClose:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate frontmostBrowserWindowController]):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/AppDelegate.h
trunk/Tools/MiniBrowser/mac/AppDelegate.m




Diff

Modified: trunk/Tools/ChangeLog (166326 => 166327)

--- trunk/Tools/ChangeLog	2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/ChangeLog	2014-03-26 23:36:08 UTC (rev 166327)
@@ -1,3 +1,18 @@
+2014-03-26  Anders Carlsson  ander...@apple.com
+
+Change MiniBrowser to hold on to window controllers instead of windows
+https://bugs.webkit.org/show_bug.cgi?id=130797
+
+Reviewed by Oliver Hunt.
+
+* MiniBrowser/mac/AppDelegate.h:
+* MiniBrowser/mac/AppDelegate.m:
+(-[BrowserAppDelegate init]):
+(-[BrowserAppDelegate newWindow:]):
+(-[BrowserAppDelegate browserWindowWillClose:]):
+(-[BrowserAppDelegate applicationWillTerminate:]):
+(-[BrowserAppDelegate frontmostBrowserWindowController]):
+
 2014-03-26  Commit Queue  commit-qu...@webkit.org
 
 Unreviewed, rolling out r166264.


Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.h (166326 => 166327)

--- trunk/Tools/MiniBrowser/mac/AppDelegate.h	2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.h	2014-03-26 23:36:08 UTC (rev 166327)
@@ -24,7 +24,7 @@
  */
 
 @interface BrowserAppDelegate : NSObject NSApplicationDelegate {
-NSMutableSet *_browserWindows;
+NSMutableSet *_browserWindowControllers;
 }
 
 - (void)browserWindowWillClose:(NSWindow *)window;


Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (166326 => 166327)

--- trunk/Tools/MiniBrowser/mac/AppDelegate.m	2014-03-26 23:35:39 UTC (rev 166326)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m	2014-03-26 23:36:08 UTC (rev 166327)
@@ -43,7 +43,7 @@
 {
 self = [super init];
 if (self) {
-_browserWindows = [[NSMutableSet alloc] init];
+_browserWindowControllers = [[NSMutableSet alloc] init];
 }
 
 return self;
@@ -63,14 +63,14 @@
 return;
 
 [[controller window] makeKeyAndOrderFront:sender];
-[_browserWindows addObject:[controller window]];
+[_browserWindowControllers addObject:controller];
 
 [controller loadURLString:defaultURL];
 }
 
 - (void)browserWindowWillClose:(NSWindow *)window
 {
-[_browserWindows removeObject:window];
+[_browserWindowControllers removeObject:window.windowController];
 }
 
 - (void)applicationDidFinishLaunching:(NSNotification *)aNotification
@@ -84,12 +84,8 @@
 
 - (void)applicationWillTerminate:(NSNotification *)notification
 {
-for (NSWindow* window in _browserWindows) {
-id delegate = [window delegate];
-assert([delegate isKindOfClass:[BrowserWindowController class]]);
-BrowserWindowController *controller = (BrowserWindowController *)delegate;
+for (BrowserWindowController* controller in _browserWindowControllers)
 [controller applicationTerminating];
-}
 }
 
 - (BrowserWindowController *)frontmostBrowserWindowController
@@ -101,11 +97,11 @@
 continue;
 
 BrowserWindowController *controller = (BrowserWindowController *)delegate;
-assert([_browserWindows containsObject:[controller window]]);
+assert([_browserWindowControllers containsObject:controller]);
 return controller;
 }
 
-return 0;
+return nil;
 }
 
 - (IBAction)openDocument:(id)sender






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166328] trunk

2014-03-26 Thread aestes

Title: [166328] trunk








Revision 166328
Author aes...@apple.com
Date 2014-03-26 16:51:12 -0700 (Wed, 26 Mar 2014)


Log Message
[Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
https://bugs.webkit.org/show_bug.cgi?id=130805

Reviewed by Dan Bernstein.

Source/WebKit2:

* UIProcess/API/Cocoa/_WKDownloadDelegate.h:
* UIProcess/Cocoa/DownloadClient.h:
* UIProcess/Cocoa/DownloadClient.mm:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::didCancel):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _downloadDidFinish:]):
(runTest):
(TEST):
(-[FailingDownloadDelegate _downloadDidFinish:]):
(-[FailingDownloadDelegate _download:didFailWithError:]):
(-[FailingDownloadDelegate _downloadDidCancel:]):
(-[CancelledDownloadDelegate _downloadDidStart:]):
(-[CancelledDownloadDelegate _downloadDidFinish:]):
(-[CancelledDownloadDelegate _download:didFailWithError:]):
(-[CancelledDownloadDelegate _downloadDidCancel:]):
(-[DownloadDelegate initWithSourceURL:]): Deleted.
(-[DownloadDelegate sourceURL]): Deleted.
(runTestWithNavigationDelegate): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownloadDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.h
trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166327 => 166328)

--- trunk/Source/WebKit2/ChangeLog	2014-03-26 23:36:08 UTC (rev 166327)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-26 23:51:12 UTC (rev 166328)
@@ -1,3 +1,17 @@
+2014-03-26  Andy Estes  aes...@apple.com
+
+[Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
+https://bugs.webkit.org/show_bug.cgi?id=130805
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/_WKDownloadDelegate.h:
+* UIProcess/Cocoa/DownloadClient.h:
+* UIProcess/Cocoa/DownloadClient.mm:
+(WebKit::DownloadClient::DownloadClient):
+(WebKit::DownloadClient::didFail):
+(WebKit::DownloadClient::didCancel):
+
 2014-03-26  Cody Krieger  c...@apple.com
 
 -[WKWebProcessPlugInNodeHandle HTMLInputElementIsUserEdited] and -HTMLTextAreaElementIsUserEdited do not return the correct values.


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownloadDelegate.h (166327 => 166328)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownloadDelegate.h	2014-03-26 23:36:08 UTC (rev 166327)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKDownloadDelegate.h	2014-03-26 23:51:12 UTC (rev 166328)
@@ -38,6 +38,8 @@
 - (void)_download:(_WKDownload *)download didReceiveData:(uint64_t)length;
 - (NSString *)_download:(_WKDownload *)download decideDestinationWithSuggestedFilename:(NSString *)filename allowOverwrite:(BOOL *)allowOverwrite;
 - (void)_downloadDidFinish:(_WKDownload *)download;
+- (void)_download:(_WKDownload *)download didFailWithError:(NSError *)error;
+- (void)_downloadDidCancel:(_WKDownload *)download;
 @end
 
 #endif


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.h (166327 => 166328)

--- trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.h	2014-03-26 23:36:08 UTC (rev 166327)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.h	2014-03-26 23:51:12 UTC (rev 166328)
@@ -36,6 +36,7 @@
 @protocol _WKDownloadDelegate;
 
 namespace WebCore {
+class ResourceError;
 class ResourceResponse;
 }
 
@@ -52,6 +53,8 @@
 virtual void didReceiveData(WebContext*, DownloadProxy*, uint64_t length);
 virtual String decideDestinationWithSuggestedFilename(WebContext*, DownloadProxy*, const String filename, bool allowOverwriteParam);
 virtual void didFinish(WebContext*, DownloadProxy*);
+virtual void didFail(WebContext*, DownloadProxy*, const WebCore::ResourceError);
+virtual void didCancel(WebContext*, DownloadProxy*);
 
 WeakObjCPtrid _WKDownloadDelegate m_delegate;
 
@@ -61,6 +64,8 @@
 bool downloadDidReceiveData : 1;
 bool downloadDecideDestinationWithSuggestedFilenameAllowOverwrite : 1;
 bool downloadDidFinish : 1;
+bool downloadDidFail : 1;
+bool downloadDidCancel : 1;
 } m_delegateMethods;
 };
 


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.mm (166327 => 166328)

--- trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.mm	2014-03-26 23:36:08 UTC (rev 166327)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/DownloadClient.mm	2014-03-26 23:51:12 UTC (rev 166328)
@@ -31,6 +31,7 @@
 #import _WKDownloadDelegate.h
 #import _WKDownloadInternal.h
 #import DownloadProxy.h
+#import WebCore/ResourceError.h
 #import WebCore/ResourceResponse.h
 
 namespace WebKit {
@@ -49,6 +50,8 @@
 m_delegateMethods.downloadDidReceiveData = [delegate respondsToSelector:@selector(_download:didReceiveData:)];

[webkit-changes] [166329] trunk/Source/WebCore

2014-03-26 Thread timothy

Title: [166329] trunk/Source/WebCore








Revision 166329
Author timo...@apple.com
Date 2014-03-26 16:58:15 -0700 (Wed, 26 Mar 2014)


Log Message
Modernize the loops in InspectorPageAgent.cpp.

Also moves the check for hiddenFromInspector to a lower level.
This hides hidden resources from more places.

https://bugs.webkit.org/show_bug.cgi?id=130803

Reviewed by Joseph Pecoraro.

* inspector/InspectorPageAgent.cpp:
(WebCore::buildArrayForCookies):
(WebCore::cachedResourcesForFrame):
(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::loaderDetachedFromFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166328 => 166329)

--- trunk/Source/WebCore/ChangeLog	2014-03-26 23:51:12 UTC (rev 166328)
+++ trunk/Source/WebCore/ChangeLog	2014-03-26 23:58:15 UTC (rev 166329)
@@ -1,3 +1,24 @@
+2014-03-26  Timothy Hatcher  timo...@apple.com
+
+Modernize the loops in InspectorPageAgent.cpp.
+
+Also moves the check for hiddenFromInspector to a lower level.
+This hides hidden resources from more places.
+
+https://bugs.webkit.org/show_bug.cgi?id=130803
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/InspectorPageAgent.cpp:
+(WebCore::buildArrayForCookies):
+(WebCore::cachedResourcesForFrame):
+(WebCore::allResourcesURLsForFrame):
+(WebCore::InspectorPageAgent::getCookies):
+(WebCore::InspectorPageAgent::searchInResources):
+(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
+(WebCore::InspectorPageAgent::loaderDetachedFromFrame):
+(WebCore::InspectorPageAgent::buildObjectForFrameTree):
+
 2014-03-26  Thiago de Barros Lacerda  thiago.lace...@openbossa.org
 
 Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions


Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (166328 => 166329)

--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2014-03-26 23:51:12 UTC (rev 166328)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2014-03-26 23:58:15 UTC (rev 166329)
@@ -451,10 +451,8 @@
 {
 RefPtrInspector::TypeBuilder::ArrayInspector::TypeBuilder::Page::Cookie cookies = Inspector::TypeBuilder::ArrayInspector::TypeBuilder::Page::Cookie::create();
 
-ListHashSetCookie::iterator end = cookiesList.end();
-ListHashSetCookie::iterator it = cookiesList.begin();
-for (int i = 0; it != end; ++it, i++)
-cookies-addItem(buildObjectForCookie(*it));
+for (auto cookie : cookiesList)
+cookies-addItem(buildObjectForCookie(cookie));
 
 return cookies;
 }
@@ -463,10 +461,10 @@
 {
 VectorCachedResource* result;
 
-const CachedResourceLoader::DocumentResourceMap allResources = frame-document()-cachedResourceLoader()-allCachedResources();
-CachedResourceLoader::DocumentResourceMap::const_iterator end = allResources.end();
-for (CachedResourceLoader::DocumentResourceMap::const_iterator it = allResources.begin(); it != end; ++it) {
-CachedResource* cachedResource = it-value.get();
+for (auto cachedResourceHandle : frame-document()-cachedResourceLoader()-allCachedResources().values()) {
+auto* cachedResource = cachedResourceHandle.get();
+if (cachedResource-resourceRequest().hiddenFromInspector())
+continue;
 
 switch (cachedResource-type()) {
 case CachedResource::ImageResource:
@@ -493,9 +491,8 @@
 
 result.append(frame-loader().documentLoader()-url());
 
-VectorCachedResource* allResources = cachedResourcesForFrame(frame);
-for (VectorCachedResource*::const_iterator it = allResources.begin(); it != allResources.end(); ++it)
-result.append((*it)-url());
+for (auto* cachedResource : cachedResourcesForFrame(frame))
+result.append(cachedResource-url());
 
 return result;
 }
@@ -515,13 +512,13 @@
 
 for (Frame* frame = mainFrame(); frame; frame = frame-tree().traverseNext(mainFrame())) {
 Document* document = frame-document();
-VectorURL allURLs = allResourcesURLsForFrame(frame);
-for (VectorURL::const_iterator it = allURLs.begin(); it != allURLs.end(); ++it) {
+
+for (auto url : allResourcesURLsForFrame(frame)) {
 VectorCookie docCookiesList;
-rawCookiesImplemented = getRawCookies(document, URL(ParsedURLString, *it), docCookiesList);
+rawCookiesImplemented = getRawCookies(document, URL(ParsedURLString, url), docCookiesList);
+
 if (!rawCookiesImplemented) {
 // FIXME: We need duplication checking for the String representation of cookies.
-//
 // Exceptions are thrown by cookie() in

[webkit-changes] [166330] trunk/Source/JavaScriptCore

2014-03-26 Thread mark . lam

Title: [166330] trunk/Source/_javascript_Core








Revision 166330
Author mark@apple.com
Date 2014-03-26 17:50:43 -0700 (Wed, 26 Mar 2014)


Log Message
Build fix after r166307.

Not reviewed.

* runtime/JSCell.h:
- The inline function isAPIValueWrapper() should not be exported.  This
  was causing a linkage error when building for 32-bit x86 on Mac.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (166329 => 166330)

--- trunk/Source/_javascript_Core/ChangeLog	2014-03-26 23:58:15 UTC (rev 166329)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-27 00:50:43 UTC (rev 166330)
@@ -1,3 +1,13 @@
+2014-03-26  Mark Lam  mark@apple.com
+
+Build fix after r166307.
+
+Not reviewed.
+
+* runtime/JSCell.h:
+- The inline function isAPIValueWrapper() should not be exported.  This
+  was causing a linkage error when building for 32-bit x86 on Mac.
+
 2014-03-26  Filip Pizlo  fpi...@apple.com
 
 Reasoning about DWARF register numbers should be moved out of FTL::Location


Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (166329 => 166330)

--- trunk/Source/_javascript_Core/runtime/JSCell.h	2014-03-26 23:58:15 UTC (rev 166329)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h	2014-03-27 00:50:43 UTC (rev 166330)
@@ -92,7 +92,7 @@
 bool isGetterSetter() const;
 bool isProxy() const;
 bool inherits(const ClassInfo*) const;
-JS_EXPORT_PRIVATE bool isAPIValueWrapper() const;
+bool isAPIValueWrapper() const;
 
 JSType type() const;
 IndexingType indexingType() const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166331] trunk/Source/WebKit2

2014-03-26 Thread timothy_horton

Title: [166331] trunk/Source/WebKit2








Revision 166331
Author timothy_hor...@apple.com
Date 2014-03-26 18:48:28 -0700 (Wed, 26 Mar 2014)


Log Message
Assertion failure in RemoteLayerBackingStore::flush
https://bugs.webkit.org/show_bug.cgi?id=130810
rdar://problem/16439276

Reviewed by Simon Fraser.

* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::flush):
We don't always have backing store to flush, if platformCALayerDrawsContent() is false.
We also can't assert that we have a back surface, because the very first paint will not.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166330 => 166331)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 00:50:43 UTC (rev 166330)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 01:48:28 UTC (rev 166331)
@@ -1,3 +1,16 @@
+2014-03-26  Tim Horton  timothy_hor...@apple.com
+
+Assertion failure in RemoteLayerBackingStore::flush
+https://bugs.webkit.org/show_bug.cgi?id=130810
+rdar://problem/16439276
+
+Reviewed by Simon Fraser.
+
+* Shared/mac/RemoteLayerBackingStore.mm:
+(RemoteLayerBackingStore::flush):
+We don't always have backing store to flush, if platformCALayerDrawsContent() is false.
+We also can't assert that we have a back surface, because the very first paint will not.
+
 2014-03-26  Andy Estes  aes...@apple.com
 
 [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()


Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (166330 => 166331)

--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-03-27 00:50:43 UTC (rev 166330)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-03-27 01:48:28 UTC (rev 166331)
@@ -331,17 +331,20 @@
 {
 #if USE(IOSURFACE)
 if (acceleratesDrawing()) {
-CGContextRef platformContext = m_frontSurface-platformContext();
-ASSERT(platformContext);
-ASSERT(m_backSurfacePendingFlush);
-CGContextFlush(platformContext);
-m_backSurfacePendingFlush = nullptr;
+if (m_frontSurface) {
+CGContextRef platformContext = m_frontSurface-platformContext();
+ASSERT(platformContext);
+CGContextFlush(platformContext);
+m_backSurfacePendingFlush = nullptr;
+}
 return;
 }
 #endif
 
 ASSERT(!acceleratesDrawing());
-ASSERT(m_bufferContextPendingFlush);
-CGContextFlush(m_bufferContextPendingFlush.get());
-m_bufferContextPendingFlush = nullptr;
+
+if (m_bufferContextPendingFlush) {
+CGContextFlush(m_bufferContextPendingFlush.get());
+m_bufferContextPendingFlush = nullptr;
+}
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166332] trunk/Source/WebKit2

2014-03-26 Thread andersca

Title: [166332] trunk/Source/WebKit2








Revision 166332
Author ander...@apple.com
Date 2014-03-26 18:54:24 -0700 (Wed, 26 Mar 2014)


Log Message
Add -[WKWebView stopLoading]
https://bugs.webkit.org/show_bug.cgi?id=130812

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView stopLoading]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166331 => 166332)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 01:48:28 UTC (rev 166331)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 01:54:24 UTC (rev 166332)
@@ -1,3 +1,14 @@
+2014-03-26  Anders Carlsson  ander...@apple.com
+
+Add -[WKWebView stopLoading]
+https://bugs.webkit.org/show_bug.cgi?id=130812
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView stopLoading]):
+
 2014-03-26  Tim Horton  timothy_hor...@apple.com
 
 Assertion failure in RemoteLayerBackingStore::flush


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h (166331 => 166332)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-03-27 01:48:28 UTC (rev 166331)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h	2014-03-27 01:54:24 UTC (rev 166332)
@@ -118,6 +118,9 @@
 - (WKNavigation *)goBack;
 - (WKNavigation *)goForward;
 
+- (void)stopLoading;
+
+// FIXME: Move this to WKIBActions.
 - (IBAction)stopLoading:(id)sender;
 
 @property (nonatomic) BOOL allowsBackForwardNavigationGestures;


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166331 => 166332)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-03-27 01:48:28 UTC (rev 166331)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2014-03-27 01:54:24 UTC (rev 166332)
@@ -307,6 +307,11 @@
 return nil;
 }
 
+- (void)stopLoading
+{
+_page-stopLoading();
+}
+
 - (IBAction)stopLoading:(id)sender
 {
 _page-stopLoading();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166333] trunk/Source

2014-03-26 Thread simon . fraser

Title: [166333] trunk/Source








Revision 166333
Author simon.fra...@apple.com
Date 2014-03-26 19:15:48 -0700 (Wed, 26 Mar 2014)


Log Message
Hook up -webkit-overflow-scrolling:touch for iOS WK2
https://bugs.webkit.org/show_bug.cgi?id=130809

Reviewed by Tim Horton.

Source/WebCore:

Get -webkit-overflow-scrolling: touch working for iOS WK2.

* WebCore.exp.in:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
Send in ScrollingGeometry when we update scrolling nodes.
* page/scrolling/AsyncScrollingCoordinator.h:
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateScrollingNode):
* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
Need to get to the scrolling layer in a subclass.
(WebCore::ScrollingTreeScrollingNodeIOS::scrollLayer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hasAcceleratedTouchScrolling): Remove code
that temporarily disabled touch-scrolling.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): When we
update scrolling nodes, send in the right scrolling geometry.

Source/WebKit2:

* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
Set the content size of the UIScrollVIew based on the geometry.
* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer): Make a UIScrollView if the
layer properties tell us that we have the scrolling behavior.
* UIProcess/ios/WKContentView.mm:
(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::webView:]):
We need to allow user interaction in the _rootContentView so that events get to
nested UIScrollViews (this could be optimized in future).
* UIProcess/mac/RemoteLayerTreeHost.h:
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::createLayer): Need to pass RemoteLayerTreeTransaction::LayerProperties
in so we can get at the custom behavior.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h
trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm
trunk/Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.h
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166332 => 166333)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 01:54:24 UTC (rev 166332)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 02:15:48 UTC (rev 166333)
@@ -1,3 +1,29 @@
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
+Hook up -webkit-overflow-scrolling:touch for iOS WK2
+https://bugs.webkit.org/show_bug.cgi?id=130809
+
+Reviewed by Tim Horton.
+
+Get -webkit-overflow-scrolling: touch working for iOS WK2.
+
+* WebCore.exp.in:
+* page/scrolling/AsyncScrollingCoordinator.cpp:
+(WebCore::AsyncScrollingCoordinator::updateScrollingNode):
+Send in ScrollingGeometry when we update scrolling nodes.
+* page/scrolling/AsyncScrollingCoordinator.h:
+* page/scrolling/ScrollingCoordinator.h:
+(WebCore::ScrollingCoordinator::updateScrollingNode):
+* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
+Need to get to the scrolling layer in a subclass.
+(WebCore::ScrollingTreeScrollingNodeIOS::scrollLayer):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::hasAcceleratedTouchScrolling): Remove code
+that temporarily disabled touch-scrolling.
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): When we
+update scrolling nodes, send in the right scrolling geometry.
+
 2014-03-26  Timothy Hatcher  timo...@apple.com
 
 Modernize the loops in InspectorPageAgent.cpp.


Modified: trunk/Source/WebCore/WebCore.exp.in (166332 => 166333)

--- trunk/Source/WebCore/WebCore.exp.in	2014-03-27 01:54:24 UTC (rev 166332)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-03-27 02:15:48 UTC (rev 166333)
@@ -2756,7 +2756,7 @@
 __ZN7WebCore25AsyncScrollingCoordinator17attachToStateTreeENS_17ScrollingNodeTypeEyy
 __ZN7WebCore25AsyncScrollingCoordinator18syncChildPositionsERKNS_10LayoutRectE

[webkit-changes] [166334] trunk/Source/WebKit2

2014-03-26 Thread simon . fraser

Title: [166334] trunk/Source/WebKit2








Revision 166334
Author simon.fra...@apple.com
Date 2014-03-26 19:25:14 -0700 (Wed, 26 Mar 2014)


Log Message
Fix the build: include UIKit headers inside the iOS #ifdef.

* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166333 => 166334)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 02:15:48 UTC (rev 166333)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 02:25:14 UTC (rev 166334)
@@ -1,5 +1,11 @@
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
+Fix the build: include UIKit headers inside the iOS #ifdef.
+
+* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
+
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
 Hook up -webkit-overflow-scrolling:touch for iOS WK2
 https://bugs.webkit.org/show_bug.cgi?id=130809
 


Modified: trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm (166333 => 166334)

--- trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm	2014-03-27 02:15:48 UTC (rev 166333)
+++ trunk/Source/WebKit2/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm	2014-03-27 02:25:14 UTC (rev 166334)
@@ -25,13 +25,14 @@
 
 #import config.h
 #import ScrollingTreeOverflowScrollingNodeIOS.h
+
+#if PLATFORM(IOS)
+#if ENABLE(ASYNC_SCROLLING)
+
 #import WebCore/BlockExceptions.h
 #import WebCore/ScrollingStateScrollingNode.h
 #import UIKit/UIScrollView.h
 
-#if PLATFORM(IOS)
-#if ENABLE(ASYNC_SCROLLING)
-
 using namespace WebCore;
 
 namespace WebKit {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166335] trunk/Source/WebCore

2014-03-26 Thread weinig

Title: [166335] trunk/Source/WebCore








Revision 166335
Author wei...@apple.com
Date 2014-03-26 20:22:59 -0700 (Wed, 26 Mar 2014)


Log Message
Convert more of HTMLConverter to C++
https://bugs.webkit.org/show_bug.cgi?id=130811

Reviewed by Anders Carlsson.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::HTMLConverter):
(HTMLConverter::~HTMLConverter):
(HTMLConverter::_blockLevelElementForNode):
(HTMLConverter::_colorForElement):
(HTMLConverter::_computedAttributesForElement):
(HTMLConverter::_attributesForElement):
(HTMLConverter::_fillInBlock):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_exitElement):
(HTMLConverter::_getFloat): Deleted.
(HTMLConverter::_elementIsBlockLevel): Deleted.
(HTMLConverter::_elementHasOwnBackgroundColor): Deleted.
(HTMLConverter::_colorForNode): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166334 => 166335)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 02:25:14 UTC (rev 166334)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 03:22:59 UTC (rev 166335)
@@ -1,3 +1,28 @@
+2014-03-26  Sam Weinig  s...@webkit.org
+
+Convert more of HTMLConverter to C++
+https://bugs.webkit.org/show_bug.cgi?id=130811
+
+Reviewed by Anders Carlsson.
+
+* editing/cocoa/HTMLConverter.mm:
+(HTMLConverter::HTMLConverter):
+(HTMLConverter::~HTMLConverter):
+(HTMLConverter::_blockLevelElementForNode):
+(HTMLConverter::_colorForElement):
+(HTMLConverter::_computedAttributesForElement):
+(HTMLConverter::_attributesForElement):
+(HTMLConverter::_fillInBlock):
+(HTMLConverter::_enterElement):
+(HTMLConverter::_addTableForElement):
+(HTMLConverter::_addTableCellForElement):
+(HTMLConverter::_processElement):
+(HTMLConverter::_exitElement):
+(HTMLConverter::_getFloat): Deleted.
+(HTMLConverter::_elementIsBlockLevel): Deleted.
+(HTMLConverter::_elementHasOwnBackgroundColor): Deleted.
+(HTMLConverter::_colorForNode): Deleted.
+
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
 Hook up -webkit-overflow-scrolling:touch for iOS WK2


Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166334 => 166335)

--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 02:25:14 UTC (rev 166334)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 03:22:59 UTC (rev 166335)
@@ -447,6 +447,8 @@
 }
 
 private:
+HashMapRefPtrElement, RetainPtrNSDictionary m_attributesForElements;
+
 NSMutableAttributedString *_attrStr;
 NSMutableDictionary *_documentAttrs;
 NSURL *_baseURL;
@@ -463,7 +465,6 @@
 NSMutableArray *_textTableRows;
 NSMutableArray *_textTableRowArrays;
 NSMutableArray *_textTableRowBackgroundColors;
-NSMutableDictionary *_attributesForElements;
 NSMutableDictionary *_fontCache;
 NSMutableArray *_writingDirectionArray;
 
@@ -484,18 +485,15 @@
 
 void _loadFromDOMRange();
 
-PlatformColor *_colorForNode(DOMNode *, CSSPropertyID);
-BOOL _getFloat(CGFloat *val, DOMNode *, CSSPropertyID);
-
+PlatformColor *_colorForElement(Element, CSSPropertyID);
+
 void _traverseNode(DOMNode *node, NSInteger depth, BOOL embedded);
 void _traverseFooterNode(DOMNode *node, NSInteger depth);
 
-NSDictionary *_computedAttributesForElement(DOMElement *);
+NSDictionary *_computedAttributesForElement(Element);
 NSDictionary *_attributesForElement(DOMElement *);
 
-bool _elementIsBlockLevel(DOMElement *);
-bool _elementHasOwnBackgroundColor(DOMElement *);
-DOMElement * _blockLevelElementForNode(DOMNode *);
+Element* _blockLevelElementForNode(Node*);
 
 void _newParagraphForElement(DOMElement *element, NSString *tag, BOOL flag, BOOL suppressTrailingSpace);
 void _newLineForElement(DOMElement *element);
@@ -503,11 +501,11 @@
 BOOL _addAttachmentForElement(DOMElement *element, NSURL *url, BOOL needsParagraph, BOOL usePlaceholder);
 void _addQuoteForElement(DOMElement *element, BOOL opening, NSInteger level);
 void _addValue(NSString *value, DOMElement *element);
-void _fillInBlock(NSTextBlock *block, DOMElement *element, PlatformColor *backgroundColor, CGFloat extraMargin, CGFloat extraPadding, BOOL isTable);
+void _fillInBlock(NSTextBlock *block, Element, PlatformColor *backgroundColor, CGFloat extraMargin, CGFloat extraPadding, BOOL isTable);
 void _processMetaElementWithName(NSString *name, NSString *content);
 void _processHeadElement(DOMElement *element);
 BOOL _enterElement(DOMElement *element, BOOL embedded);
-void _addTableForElement(DOMElement *tableElement);
+void _addTableForElement(Element *tableElement);
 void

[webkit-changes] [166336] trunk/Source/WebKit2

2014-03-26 Thread timothy_horton

Title: [166336] trunk/Source/WebKit2








Revision 166336
Author timothy_hor...@apple.com
Date 2014-03-26 20:41:40 -0700 (Wed, 26 Mar 2014)


Log Message
[iOS WebKit2] Crashes on swipe
rdar://problem/16440867

Reviewed by Benjamin Poulain.

* UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
Get the IOSurfaceRef from the WebCore::IOSurface.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166335 => 166336)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 03:22:59 UTC (rev 166335)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 03:41:40 UTC (rev 166336)
@@ -1,3 +1,14 @@
+2014-03-26  Tim Horton  timothy_hor...@apple.com
+
+[iOS WebKit2] Crashes on swipe
+rdar://problem/16440867
+
+Reviewed by Benjamin Poulain.
+
+* UIProcess/ios/ViewGestureControllerIOS.mm:
+(WebKit::ViewGestureController::beginSwipeGesture):
+Get the IOSurfaceRef from the WebCore::IOSurface.
+
 2014-03-26  Simon Fraser  simon.fra...@apple.com
 
 Fix the build: include UIKit headers inside the iOS #ifdef.


Modified: trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm (166335 => 166336)

--- trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm	2014-03-27 03:22:59 UTC (rev 166335)
+++ trunk/Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm	2014-03-27 03:41:40 UTC (rev 166336)
@@ -158,7 +158,7 @@
 if (snapshot) {
 #if USE(IOSURFACE)
 if (snapshot-setIsPurgeable(false) == IOSurface::SurfaceState::Valid) {
-[m_snapshotView layer].contents = (id)snapshot.get();
+[m_snapshotView layer].contents = (id)snapshot-surface();
 m_currentSwipeSnapshotSurface = snapshot;
 }
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166338] trunk/Source/WebKit2

2014-03-26 Thread andersca

Title: [166338] trunk/Source/WebKit2








Revision 166338
Author ander...@apple.com
Date 2014-03-26 20:46:04 -0700 (Wed, 26 Mar 2014)


Log Message
Rename a delegate method to -webView:didFinishNavigation:
https://bugs.webkit.org/show_bug.cgi?id=130814

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKNavigationDelegate.h:
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166337 => 166338)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 03:45:38 UTC (rev 166337)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 03:46:04 UTC (rev 166338)
@@ -1,3 +1,16 @@
+2014-03-26  Anders Carlsson  ander...@apple.com
+
+Rename a delegate method to -webView:didFinishNavigation:
+https://bugs.webkit.org/show_bug.cgi?id=130814
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/Cocoa/WKNavigationDelegate.h:
+* UIProcess/Cocoa/NavigationState.h:
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::setNavigationDelegate):
+(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
+
 2014-03-26  Tim Horton  timothy_hor...@apple.com
 
 [iOS WebKit2] Crashes on swipe


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegate.h (166337 => 166338)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegate.h	2014-03-27 03:45:38 UTC (rev 166337)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegate.h	2014-03-27 03:46:04 UTC (rev 166338)
@@ -57,7 +57,7 @@
 
 - (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError *)error;
 - (void)webView:(WKWebView *)webView didCommitNavigation:(WKNavigation *)navigation;
-- (void)webView:(WKWebView *)webView didFinishLoadingNavigation:(WKNavigation *)navigation;
+- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation;
 - (void)webView:(WKWebView *)webView didFailNavigation:(WKNavigation *)navigation withError:(NSError *)error;
 
 @end


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h (166337 => 166338)

--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h	2014-03-27 03:45:38 UTC (rev 166337)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h	2014-03-27 03:46:04 UTC (rev 166338)
@@ -42,6 +42,10 @@
 @protocol WKHistoryDelegatePrivate;
 @protocol WKNavigationDelegate;
 
+@interface NSObject (WKNavigationDelegateToBeRemoved)
+- (void)webView:(WKWebView *)webView didFinishLoadingNavigation:(WKNavigation *)navigation;
+@end
+
 namespace WebKit {
 
 struct WebNavigationDataStore;
@@ -129,13 +133,16 @@
 bool webViewDidReceiveServerRedirectForProvisionalNavigation : 1;
 bool webViewDidFailProvisionalNavigationWithError : 1;
 bool webViewDidCommitNavigation : 1;
-bool webViewDidFinishLoadingNavigation : 1;
+bool webViewDidFinishNavigation : 1;
 bool webViewDidFailNavigationWithError : 1;
 
 bool webViewRenderingProgressDidChange : 1;
 bool webViewCanAuthenticateAgainstProtectionSpace : 1;
 bool webViewDidReceiveAuthenticationChallenge : 1;
 bool webViewWebProcessDidCrash : 1;
+
+// FIXME: Remove this once no clients depend on it being called.
+bool webViewDidFinishLoadingNavigation : 1;
 } m_navigationDelegateMethods;
 
 HashMapuint64_t, RetainPtrWKNavigation m_navigations;


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (166337 => 166338)

--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-03-27 03:45:38 UTC (rev 166337)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm	2014-03-27 03:46:04 UTC (rev 166338)
@@ -112,13 +112,16 @@
 m_navigationDelegateMethods.webViewDidReceiveServerRedirectForProvisionalNavigation = [delegate respondsToSelector:@selector(webView:didReceiveServerRedirectForProvisionalNavigation:)];
 m_navigationDelegateMethods.webViewDidFailProvisionalNavigationWithError = [delegate respondsToSelector:@selector(webView:didFailProvisionalNavigation:withError:)];
 m_navigationDelegateMethods.webViewDidCommitNavigation = [delegate respondsToSelector:@selector(webView:didCommitNavigation:)];
-m_navigationDelegateMethods.webViewDidFinishLoadingNavigation = [delegate respondsToSelector:@selector(webView:didFinishLoadingNavigation:)];
+m_navigationDelegateMethods.webViewDidFinishNavigation = [delegate respondsToSelector:@selector(webView:didFinishNavigation:)];
 m_navigationDelegateMethods.webViewDidFailNavigationWithError = [delegate

[webkit-changes] [166337] trunk/Source/WebCore

2014-03-26 Thread bburg

Title: [166337] trunk/Source/WebCore








Revision 166337
Author bb...@apple.com
Date 2014-03-26 20:45:38 -0700 (Wed, 26 Mar 2014)


Log Message
Web Replay: disable page cache during capture/replay
https://bugs.webkit.org/show_bug.cgi?id=130672

Reviewed by Timothy Hatcher.

Save, set, and restore page cache settings at the correct times.

No new tests. If this code fails, then the tests for network replay will fail.

* replay/ReplayController.cpp:
(WebCore::ReplayController::setForceDeterministicSettings): Added.
(WebCore::ReplayController::startCapturing):
(WebCore::ReplayController::stopCapturing):
(WebCore::ReplayController::cancelPlayback):
(WebCore::ReplayController::replayToPosition):
* replay/ReplayController.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/replay/ReplayController.cpp
trunk/Source/WebCore/replay/ReplayController.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (166336 => 166337)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 03:41:40 UTC (rev 166336)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 03:45:38 UTC (rev 166337)
@@ -1,3 +1,22 @@
+2014-03-26  Brian Burg  bb...@apple.com
+
+Web Replay: disable page cache during capture/replay
+https://bugs.webkit.org/show_bug.cgi?id=130672
+
+Reviewed by Timothy Hatcher.
+
+Save, set, and restore page cache settings at the correct times.
+
+No new tests. If this code fails, then the tests for network replay will fail.
+
+* replay/ReplayController.cpp:
+(WebCore::ReplayController::setForceDeterministicSettings): Added.
+(WebCore::ReplayController::startCapturing):
+(WebCore::ReplayController::stopCapturing):
+(WebCore::ReplayController::cancelPlayback):
+(WebCore::ReplayController::replayToPosition):
+* replay/ReplayController.h:
+
 2014-03-26  Sam Weinig  s...@webkit.org
 
 Convert more of HTMLConverter to C++


Modified: trunk/Source/WebCore/replay/ReplayController.cpp (166336 => 166337)

--- trunk/Source/WebCore/replay/ReplayController.cpp	2014-03-27 03:41:40 UTC (rev 166336)
+++ trunk/Source/WebCore/replay/ReplayController.cpp	2014-03-27 03:45:38 UTC (rev 166337)
@@ -44,6 +44,7 @@
 #include ReplaySessionSegment.h
 #include ReplayingInputCursor.h
 #include ScriptController.h
+#include Settings.h
 #include UserInputBridge.h
 #include WebReplayInputs.h
 #include replay/EmptyInputCursor.h
@@ -65,6 +66,19 @@
 {
 }
 
+void ReplayController::setForceDeterministicSettings(bool shouldForce)
+{
+ASSERT(shouldForce ^ (m_sessionState == SessionState::Inactive));
+
+if (shouldForce) {
+m_savedSettings.usesPageCache = m_page.settings().usesPageCache();
+
+m_page.settings().setUsesPageCache(false);
+} else {
+m_page.settings().setUsesPageCache(m_savedSettings.usesPageCache);
+}
+}
+
 void ReplayController::setSessionState(SessionState state)
 {
 ASSERT(state != m_sessionState);
@@ -199,6 +213,7 @@
 ASSERT(m_segmentState == SegmentState::Unloaded);
 
 setSessionState(SessionState::Capturing);
+setForceDeterministicSettings(true);
 
 LOG(WebReplay, %-20s Starting capture.\n, ReplayController);
 InspectorInstrumentation::captureStarted(m_page);
@@ -216,6 +231,7 @@
 completeSegment();
 
 setSessionState(SessionState::Inactive);
+setForceDeterministicSettings(false);
 
 LOG(WebReplay, %-20s Stopping capture.\n, ReplayController);
 InspectorInstrumentation::captureStopped(m_page);
@@ -263,6 +279,7 @@
 ASSERT(m_segmentState == SegmentState::Loaded);
 unloadSegment();
 m_sessionState = SessionState::Inactive;
+setForceDeterministicSettings(false);
 InspectorInstrumentation::playbackFinished(m_page);
 }
 
@@ -274,8 +291,10 @@
 
 m_dispatchSpeed = speed;
 
-if (m_sessionState != SessionState::Replaying)
+if (m_sessionState != SessionState::Replaying) {
 setSessionState(SessionState::Replaying);
+setForceDeterministicSettings(true);
+}
 
 if (m_segmentState == SegmentState::Unloaded)
 loadSegmentAtIndex(position.segmentOffset);


Modified: trunk/Source/WebCore/replay/ReplayController.h (166336 => 166337)

--- trunk/Source/WebCore/replay/ReplayController.h	2014-03-27 03:41:40 UTC (rev 166336)
+++ trunk/Source/WebCore/replay/ReplayController.h	2014-03-27 03:45:38 UTC (rev 166337)
@@ -151,7 +151,16 @@
 EventLoopInputDispatcher dispatcher() const;
 
 void setSessionState(SessionState);
+void setForceDeterministicSettings(bool);
 
+struct SavedSettings {
+bool usesPageCache;
+
+SavedSettings()
+: usesPageCache(false)
+{ }
+};
+
 Page m_page;
 
 RefPtrReplaySessionSegment m_loadedSegment;
@@ -170,6 +179,7 @@
 SessionState m_sessionState;
 
 DispatchSpeed m_dispatchSpeed;
+SavedSettings m_savedSettings;
 };
 
 } // namespace WebCore






___
webkit-changes mailing list

[webkit-changes] [166339] trunk/Source/WebCore

2014-03-26 Thread simon . fraser

Title: [166339] trunk/Source/WebCore








Revision 166339
Author simon.fra...@apple.com
Date 2014-03-26 20:53:31 -0700 (Wed, 26 Mar 2014)


Log Message
Make sure childContainmentLayer is parented
https://bugs.webkit.org/show_bug.cgi?id=130808

Reviewed by Tim Horton.

m_childContainmentLayer was never parented if the page
created no other compositing layers, which left a dangling
GraphicsLayer which in turn confused UI-side compositing a little.
Fix by always parenting this layer.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (166338 => 166339)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 03:46:04 UTC (rev 166338)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 03:53:31 UTC (rev 166339)
@@ -1,3 +1,18 @@
+2014-03-26  Simon Fraser  simon.fra...@apple.com
+
+Make sure childContainmentLayer is parented
+https://bugs.webkit.org/show_bug.cgi?id=130808
+
+Reviewed by Tim Horton.
+
+m_childContainmentLayer was never parented if the page
+created no other compositing layers, which left a dangling
+GraphicsLayer which in turn confused UI-side compositing a little.
+Fix by always parenting this layer.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
+
 2014-03-26  Brian Burg  bb...@apple.com
 
 Web Replay: disable page cache during capture/replay


Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (166338 => 166339)

--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-27 03:46:04 UTC (rev 166338)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-27 03:53:31 UTC (rev 166339)
@@ -299,8 +299,10 @@
 m_graphicsLayer = createGraphicsLayer(layerName);
 m_creatingPrimaryGraphicsLayer = false;
 
-if (m_usingTiledCacheLayer)
+if (m_usingTiledCacheLayer) {
 m_childContainmentLayer = createGraphicsLayer(TiledBacking Flattening Layer);
+m_graphicsLayer-addChild(m_childContainmentLayer.get());
+}
 
 if (m_isMainFrameRenderViewLayer) {
 #if !PLATFORM(IOS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166340] trunk/Source/WebKit2

2014-03-26 Thread andersca

Title: [166340] trunk/Source/WebKit2








Revision 166340
Author ander...@apple.com
Date 2014-03-26 20:55:48 -0700 (Wed, 26 Mar 2014)


Log Message
Add a _WKScriptWorld class
https://bugs.webkit.org/show_bug.cgi?id=130817

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/_WKScriptWorld.h: Added.
* UIProcess/API/Cocoa/_WKScriptWorld.mm: Added.
(generateWorldID):
(+[_WKScriptWorld defaultWorld]):
(-[_WKScriptWorld init]):
(-[_WKScriptWorld _initWithWorldID:]):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166339 => 166340)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 03:53:31 UTC (rev 166339)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 03:55:48 UTC (rev 166340)
@@ -1,5 +1,20 @@
 2014-03-26  Anders Carlsson  ander...@apple.com
 
+Add a _WKScriptWorld class
+https://bugs.webkit.org/show_bug.cgi?id=130817
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/_WKScriptWorld.h: Added.
+* UIProcess/API/Cocoa/_WKScriptWorld.mm: Added.
+(generateWorldID):
+(+[_WKScriptWorld defaultWorld]):
+(-[_WKScriptWorld init]):
+(-[_WKScriptWorld _initWithWorldID:]):
+* WebKit2.xcodeproj/project.pbxproj:
+
+2014-03-26  Anders Carlsson  ander...@apple.com
+
 Rename a delegate method to -webView:didFinishNavigation:
 https://bugs.webkit.org/show_bug.cgi?id=130814
 


Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h (0 => 166340)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h	2014-03-27 03:55:48 UTC (rev 166340)
@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import Foundation/Foundation.h
+#import WebKit2/WKFoundation.h
+
+#if WK_API_ENABLED
+
+WK_API_CLASS
+@interface _WKScriptWorld : NSObject
+
++(instancetype)defaultWorld;
+
+@end
+
+#endif


Added: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm (0 => 166340)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm	2014-03-27 03:55:48 UTC (rev 166340)
@@ -0,0 +1,70 @@
+/*
+ * Copyright (C) 2014 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ *

[webkit-changes] [166342] trunk/Source/WebCore

2014-03-26 Thread rniwa

Title: [166342] trunk/Source/WebCore








Revision 166342
Author rn...@webkit.org
Date 2014-03-26 21:16:32 -0700 (Wed, 26 Mar 2014)


Log Message
Make _processText and _traverseNode in HTMLConverter more efficient
https://bugs.webkit.org/show_bug.cgi?id=130769

Reviewed by Sam Weinig.

Rewrote a bunch of code in C++ and avoided creating wrappers.
This reduces the runtime of Interactive/CopyAll.html from ~16.5s to 15s.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::isAncestorsOfStartToBeConverted):
(HTMLConverter::HTMLConverter):
(HTMLConverter::~HTMLConverter):
(HTMLConverter::_processElement):
(HTMLConverter::_processText):
(HTMLConverter::_traverseNode):
(HTMLConverter::_traverseFooterNode):
(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
(HTMLConverter::_loadFromDOMRange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166341 => 166342)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 04:14:22 UTC (rev 166341)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 04:16:32 UTC (rev 166342)
@@ -1,3 +1,24 @@
+2014-03-26  Ryosuke Niwa  rn...@webkit.org
+
+Make _processText and _traverseNode in HTMLConverter more efficient
+https://bugs.webkit.org/show_bug.cgi?id=130769
+
+Reviewed by Sam Weinig.
+
+Rewrote a bunch of code in C++ and avoided creating wrappers.
+This reduces the runtime of Interactive/CopyAll.html from ~16.5s to 15s.
+
+* editing/cocoa/HTMLConverter.mm:
+(HTMLConverterCaches::isAncestorsOfStartToBeConverted):
+(HTMLConverter::HTMLConverter):
+(HTMLConverter::~HTMLConverter):
+(HTMLConverter::_processElement):
+(HTMLConverter::_processText):
+(HTMLConverter::_traverseNode):
+(HTMLConverter::_traverseFooterNode):
+(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted):
+(HTMLConverter::_loadFromDOMRange):
+
 2014-03-26  Adenilson Cavalcanti  cavalcan...@gmail.com
 
 FEGaussianBlur: unify and const-ify calculateKernelSize


Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166341 => 166342)

--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 04:14:22 UTC (rev 166341)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 04:16:32 UTC (rev 166342)
@@ -49,6 +49,7 @@
 #import Frame.h
 #import FrameLoader.h
 #import HTMLElement.h
+#import HTMLFrameElementBase.h
 #import HTMLNames.h
 #import HTMLParserIdioms.h
 #import LoaderNSURLExtras.h
@@ -60,6 +61,7 @@
 #import TextIterator.h
 #import objc/runtime.h
 #import wtf/ASCIICType.h
+#import wtf/text/StringBuilder.h
 
 #if PLATFORM(IOS)
 
@@ -416,8 +418,12 @@
 PassRefPtrCSSValue computedStylePropertyForElement(Element, CSSPropertyID);
 PassRefPtrCSSValue inlineStylePropertyForElement(Element, CSSPropertyID);
 
+Node* cacheAncestorsOfStartToBeConverted(const Range);
+bool isAncestorsOfStartToBeConverted(Node* node) const { return m_ancestorsUnderCommonAncestor.contains(node); }
+
 private:
 HashMapElement*, std::unique_ptrComputedStyleExtractor m_computedStyles;
+HashSetNode* m_ancestorsUnderCommonAncestor;
 };
 
 @interface NSTextList (WebCoreNSTextListDetails)
@@ -454,7 +460,6 @@
 NSURL *_baseURL;
 DOMDocument *_document;
 DOMRange *_domRange;
-NSMutableArray *_domStartAncestors;
 WebCore::DocumentLoader *_dataSource;
 NSMutableArray *_textLists;
 NSMutableArray *_textBlocks;
@@ -487,7 +492,7 @@
 
 PlatformColor *_colorForElement(Element, CSSPropertyID);
 
-void _traverseNode(DOMNode *node, NSInteger depth, BOOL embedded);
+void _traverseNode(Node* node, unsigned depth, bool embedded);
 void _traverseFooterNode(DOMNode *node, NSInteger depth);
 
 NSDictionary *_computedAttributesForElement(Element);
@@ -510,7 +515,7 @@
 BOOL _processElement(DOMElement *element, NSInteger depth);
 void _addMarkersToList(NSTextList *list, NSRange range);
 void _exitElement(DOMElement *element, NSInteger depth, NSUInteger startIndex);
-void _processText(DOMCharacterData *text);
+void _processText(CharacterData);
 void _adjustTrailingNewline();
 };
 
@@ -521,7 +526,6 @@
 _documentAttrs = [[NSMutableDictionary alloc] init];
 _baseURL = nil;
 _document = nil;
-_domStartAncestors = nil;
 _dataSource = nullptr;
 _textLists = [[NSMutableArray alloc] init];
 _textBlocks = [[NSMutableArray alloc] init];
@@ -552,7 +556,6 @@
 [_attrStr release];
 [_documentAttrs release];
 [_domRange release];
-[_domStartAncestors release];
 [_textLists release];
 [_textBlocks release];
 [_textTables release];
@@ -1980,21 +1983,11 @@
 if (url)
 retval = !_addAttachmentForElement(element, url, isBlockLevel, NO);
 }
-} else if (coreElement.hasTagName(frameTag)) {
-if ([element

[webkit-changes] [166343] trunk/Source/WebKit2

2014-03-26 Thread benjamin

Title: [166343] trunk/Source/WebKit2








Revision 166343
Author benja...@webkit.org
Date 2014-03-26 21:31:07 -0700 (Wed, 26 Mar 2014)


Log Message
[iOS][WK2] rdar://problem/16265272 REGRESSION (WebKit2): Some pages appear blank until you scroll
https://bugs.webkit.org/show_bug.cgi?id=130819

Patch by Benjamin Poulain bpoul...@apple.com on 2014-03-26
Reviewed by Tim Horton.

When loading a new page, we never define the unobscured rect and exposed rect on the new frame.
As a result, there is nothing to render.

It uses to work thanks to dumb luck and a bug in Safari updating the visibleContentRects from
the UIProcess. Now that the bug is gone, dumb luck is not reliable enough to get the content rects :)

What this patch does is save if we have ever received new rects from the UI. If we have not, create them
based on the minimum layout size. This works because we know Safari shows the minimum layout size by default
and will tell us if it changes the obscured rects.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didCommitLoad):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateVisibleContentRects):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (166342 => 166343)

--- trunk/Source/WebKit2/ChangeLog	2014-03-27 04:16:32 UTC (rev 166342)
+++ trunk/Source/WebKit2/ChangeLog	2014-03-27 04:31:07 UTC (rev 166343)
@@ -1,3 +1,28 @@
+2014-03-26  Benjamin Poulain  bpoul...@apple.com
+
+[iOS][WK2] rdar://problem/16265272 REGRESSION (WebKit2): Some pages appear blank until you scroll
+https://bugs.webkit.org/show_bug.cgi?id=130819
+
+Reviewed by Tim Horton.
+
+When loading a new page, we never define the unobscured rect and exposed rect on the new frame.
+As a result, there is nothing to render.
+
+It uses to work thanks to dumb luck and a bug in Safari updating the visibleContentRects from
+the UIProcess. Now that the bug is gone, dumb luck is not reliable enough to get the content rects :)
+
+What this patch does is save if we have ever received new rects from the UI. If we have not, create them
+based on the minimum layout size. This works because we know Safari shows the minimum layout size by default
+and will tell us if it changes the obscured rects.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::WebPage):
+(WebKit::WebPage::didCommitLoad):
+* WebProcess/WebPage/WebPage.h:
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::viewportConfigurationChanged):
+(WebKit::WebPage::updateVisibleContentRects):
+
 2014-03-26  Anders Carlsson  ander...@apple.com
 
 Add a _WKScriptWorld class


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (166342 => 166343)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-03-27 04:16:32 UTC (rev 166342)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2014-03-27 04:31:07 UTC (rev 166343)
@@ -285,6 +285,7 @@
 #if PLATFORM(IOS)
 , m_shouldReturnWordAtSelection(false)
 , m_lastVisibleContentRectUpdateID(0)
+, m_hasReceivedVisibleContentRectsAfterDidCommitLoad(false)
 , m_scaleWasSetByUIProcess(false)
 , m_userHasChangedPageScaleFactor(false)
 , m_viewportScreenSize(parameters.viewportScreenSize)
@@ -4229,6 +4230,7 @@
 }
 }
 #if PLATFORM(IOS)
+m_hasReceivedVisibleContentRectsAfterDidCommitLoad = false;
 m_userHasChangedPageScaleFactor = false;
 
 Document* document = frame-coreFrame()-document();


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h (166342 => 166343)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-03-27 04:16:32 UTC (rev 166342)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h	2014-03-27 04:31:07 UTC (rev 166343)
@@ -1133,6 +1133,7 @@
 
 WebCore::ViewportConfiguration m_viewportConfiguration;
 uint64_t m_lastVisibleContentRectUpdateID;
+bool m_hasReceivedVisibleContentRectsAfterDidCommitLoad;
 bool m_scaleWasSetByUIProcess;
 bool m_userHasChangedPageScaleFactor;
 WebCore::FloatSize m_viewportScreenSize;


Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (166342 => 166343)

--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-03-27 04:16:32 UTC (rev 166342)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-03-27 04:31:07 UTC (rev 166343)
@@ -1703,7 +1703,21 @@
 else
 scale = m_viewportConfiguration.initialScale();
 
-scalePage(scale, m_page-mainFrame().view()-scrollPosition());
+FrameView frameView = *m_page-mainFrame().view();
+IntPoint scrollPosition = frameView.scrollPosition();

[webkit-changes] [166344] trunk/Source/WebCore

2014-03-26 Thread weinig

Title: [166344] trunk/Source/WebCore








Revision 166344
Author wei...@apple.com
Date 2014-03-26 21:42:50 -0700 (Wed, 26 Mar 2014)


Log Message
Fix iOS build.

* editing/cocoa/HTMLConverter.mm:
(_font):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (166343 => 166344)

--- trunk/Source/WebCore/ChangeLog	2014-03-27 04:31:07 UTC (rev 166343)
+++ trunk/Source/WebCore/ChangeLog	2014-03-27 04:42:50 UTC (rev 166344)
@@ -1,3 +1,10 @@
+2014-03-26  Sam Weinig  s...@webkit.org
+
+Fix iOS build.
+
+* editing/cocoa/HTMLConverter.mm:
+(_font):
+
 2014-03-26  Ryosuke Niwa  rn...@webkit.org
 
 Make _processText and _traverseNode in HTMLConverter more efficient


Modified: trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm (166343 => 166344)

--- trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 04:31:07 UTC (rev 166343)
+++ trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm	2014-03-27 04:42:50 UTC (rev 166344)
@@ -1125,7 +1125,7 @@
 auto renderer = element.renderer();
 if (!renderer)
 return nil;
-return renderer-style().font().primaryFont()-getCTFont();
+return (PlatformFont *)renderer-style().font().primaryFont()-getCTFont();
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [166345] trunk/Source/JavaScriptCore

2014-03-26 Thread fpizlo

Title: [166345] trunk/Source/_javascript_Core








Revision 166345
Author fpi...@apple.com
Date 2014-03-26 22:05:55 -0700 (Wed, 26 Mar 2014)


Log Message
Parse stackmaps liveOuts
https://bugs.webkit.org/show_bug.cgi?id=130801

Reviewed by Geoffrey Garen.

This just adds the code to parse them but doesn't do anything with them, yet.

* ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
* ftl/FTLLocation.h:
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):
* ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::Location::dump):
(JSC::FTL::StackMaps::LiveOut::parse):
(JSC::FTL::StackMaps::LiveOut::dump):
(JSC::FTL::StackMaps::Record::parse):
(JSC::FTL::StackMaps::Record::dump):
* ftl/FTLStackMaps.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLocation.cpp
trunk/Source/_javascript_Core/ftl/FTLLocation.h
trunk/Source/_javascript_Core/ftl/FTLStackMaps.cpp
trunk/Source/_javascript_Core/ftl/FTLStackMaps.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (166344 => 166345)

--- trunk/Source/_javascript_Core/ChangeLog	2014-03-27 04:42:50 UTC (rev 166344)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-03-27 05:05:55 UTC (rev 166345)
@@ -1,3 +1,26 @@
+2014-03-26  Filip Pizlo  fpi...@apple.com
+
+Parse stackmaps liveOuts
+https://bugs.webkit.org/show_bug.cgi?id=130801
+
+Reviewed by Geoffrey Garen.
+
+This just adds the code to parse them but doesn't do anything with them, yet.
+
+* ftl/FTLLocation.cpp:
+(JSC::FTL::Location::forStackmaps):
+* ftl/FTLLocation.h:
+(JSC::FTL::Location::forRegister):
+(JSC::FTL::Location::forIndirect):
+* ftl/FTLStackMaps.cpp:
+(JSC::FTL::StackMaps::Location::parse):
+(JSC::FTL::StackMaps::Location::dump):
+(JSC::FTL::StackMaps::LiveOut::parse):
+(JSC::FTL::StackMaps::LiveOut::dump):
+(JSC::FTL::StackMaps::Record::parse):
+(JSC::FTL::StackMaps::Record::dump):
+* ftl/FTLStackMaps.h:
+
 2014-03-26  Mark Lam  mark@apple.com
 
 Build fix after r166307.


Modified: trunk/Source/_javascript_Core/ftl/FTLLocation.cpp (166344 => 166345)

--- trunk/Source/_javascript_Core/ftl/FTLLocation.cpp	2014-03-27 04:42:50 UTC (rev 166344)
+++ trunk/Source/_javascript_Core/ftl/FTLLocation.cpp	2014-03-27 05:05:55 UTC (rev 166345)
@@ -45,10 +45,10 @@
 
 case StackMaps::Location::Register:
 case StackMaps::Location::Direct:
-return forRegister(location.dwarfRegNum, location.offset);
+return forRegister(location.dwarfReg, location.offset);
 
 case StackMaps::Location::Indirect:
-return forIndirect(location.dwarfRegNum, location.offset);
+return forIndirect(location.dwarfReg, location.offset);
 
 case StackMaps::Location::Constant:
 return forConstant(location.offset);


Modified: trunk/Source/_javascript_Core/ftl/FTLLocation.h (166344 => 166345)

--- trunk/Source/_javascript_Core/ftl/FTLLocation.h	2014-03-27 04:42:50 UTC (rev 166344)
+++ trunk/Source/_javascript_Core/ftl/FTLLocation.h	2014-03-27 05:05:55 UTC (rev 166345)
@@ -57,20 +57,20 @@
 u.constant = 1;
 }
 
-static Location forRegister(int16_t dwarfRegNum, int32_t addend)
+static Location forRegister(DWARFRegister dwarfReg, int32_t addend)
 {
 Location result;
 result.m_kind = Register;
-result.u.variable.dwarfRegNum = dwarfRegNum;
+result.u.variable.dwarfRegNum = dwarfReg.dwarfRegNum();
 result.u.variable.offset = addend;
 return result;
 }
 
-static Location forIndirect(int16_t dwarfRegNum, int32_t offset)
+static Location forIndirect(DWARFRegister dwarfReg, int32_t offset)
 {
 Location result;
 result.m_kind = Indirect;
-result.u.variable.dwarfRegNum = dwarfRegNum;
+result.u.variable.dwarfRegNum = dwarfReg.dwarfRegNum();
 result.u.variable.offset = offset;
 return result;
 }


Modified: trunk/Source/_javascript_Core/ftl/FTLStackMaps.cpp (166344 => 166345)

--- trunk/Source/_javascript_Core/ftl/FTLStackMaps.cpp	2014-03-27 04:42:50 UTC (rev 166344)
+++ trunk/Source/_javascript_Core/ftl/FTLStackMaps.cpp	2014-03-27 05:05:55 UTC (rev 166345)
@@ -77,13 +77,13 @@
 {
 kind = static_castKind(context.view-readuint8_t(context.offset, true));
 size = context.view-readuint8_t(context.offset, true);
-dwarfRegNum = context.view-readuint16_t(context.offset, true);
+dwarfReg = DWARFRegister(context.view-readuint16_t(context.offset, true));
 this-offset = context.view-readint32_t(context.offset, true);
 }
 
 void StackMaps::Location::dump(PrintStream out) const
 {
-out.print((, kind, , reg, dwarfRegNum, , off:, offset, , size:, size, ));
+out.print((, kind, , , dwarfReg, , off:, offset, , size:, size, ));
 }
 
 GPRReg

51 matches

Mail list logo